GNU bug report logs - #59975
[PATCH] guix: Show better progress bars.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59975: closed ([PATCH] guix: Show better progress bars.)
Date: Sun, 19 Feb 2023 09:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 19 Feb 2023 10:11:47 +0100
with message-id <20230219101147.246695b1 <at> sybil.lepiller.eu>
and subject line Re: [bug#59975] [PATCH v3 0/2] guix: Show better progress bars.
has caused the debbugs.gnu.org bug report #59975,
regarding [PATCH] guix: Show better progress bars.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59975: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59975
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: Show better progress bars.
Date: Sun, 11 Dec 2022 19:00:59 +0100

[Message part 3 (text/plain, inline)]

Hi Guix!

The attached patch is a small improvement on our progress bars. Instead
of our cute ASCII art:

1.2MiB/s 00:04 [###               ]  18.5%

We get something a little more smooth:

1.1MiB/s 00:04 ▕███               ▏  17.1%
1.2MiB/s 00:05 ▕███▋              ▏  20.7%

Using unicode characters that can represent 1/8 of a character width.

I used port-encoding to detect when the output supports unicode, but
maybe there's something more dedicated to figuring that out? When the
port encoding is not UTF-8, we fall back to the ASCII version.

Thoughts?

[0001-guix-Show-better-progress-bars.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Julien Lepiller <julien <at> lepiller.eu>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 59975-done <at> debbugs.gnu.org
Subject: Re: [bug#59975] [PATCH v3 0/2] guix: Show better progress bars.
Date: Sun, 19 Feb 2023 10:11:47 +0100

[Message part 6 (text/plain, inline)]

Finally pushed to master as 01334a61c7541d8ae29c5252e2e5b3ed7a59c552
and 189525412e3d803f3f77e15ec4a62aaa57f65a2d.

Le Sun, 12 Feb 2023 10:02:50 +0000,
Christopher Baines <mail <at> cbaines.net> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > Here's the new version, it's now a small series. The first patch
> > sets unifont as default, so we can see the fancy bars in a TTY :)
> > The second hasn't changed.
> >
> > Julien Lepiller (2):
> >   gnu: Use unifont by default in TTYs.
> >   guix: Show better progress bars.
> >
> >  gnu/services/base.scm |  7 +++----
> >  guix/progress.scm     | 45
> > ++++++++++++++++++++++++++++++++++++------- 2 files changed, 41
> > insertions(+), 11 deletions(-)
> >
> >
> > base-commit: 92755c6352fd967bc74d8e5354aad057d779b717  
> 
> I haven't tried this out, but the changes look good to me :)
> 
> Thanks,
> 
> Chris

[Message part 7 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.