From unknown Tue Sep 09 22:28:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59975 <59975@debbugs.gnu.org> To: bug#59975 <59975@debbugs.gnu.org> Subject: Status: [PATCH] guix: Show better progress bars. Reply-To: bug#59975 <59975@debbugs.gnu.org> Date: Wed, 10 Sep 2025 05:28:56 +0000 retitle 59975 [PATCH] guix: Show better progress bars. reassign 59975 guix-patches submitter 59975 Julien Lepiller severity 59975 normal tag 59975 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 13:02:14 2022 Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 18:02:14 +0000 Received: from localhost ([127.0.0.1]:47413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QeT-0001Gr-KQ for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:02:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:57262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QeR-0001Gl-Je for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:02:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QeR-0004OT-8f for guix-patches@gnu.org; Sun, 11 Dec 2022 13:02:11 -0500 Received: from lepiller.eu ([2a00:5884:8208::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QeP-0003lg-Jh for guix-patches@gnu.org; Sun, 11 Dec 2022 13:02:11 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id a16ba8fc for ; Sun, 11 Dec 2022 18:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:message-id:mime-version:content-type; s=dkim; bh=O7f m0eXsaBMEtvC7PQ/S7BlIeHHlH28YtZ06hGe8ec0=; b=Yxu8ZBMp+9GdicLJ9ni PhZSnhJdF1MGm6dliFsWUkrbp2ZiV48ZWCFpOUYCg/av1fylwKJ/RdLsMCpwqNpC wC2XioiJff/QZ3XLhUSEKPujBpyXsFl2UjF4KEuZ8jzO5vvFrBMKvNkVR5YhGSeZ 5YHel3zdT8/nIVWiYLSXJU37txvQ70euBLj8LPN212GfHYzVrZ8Va4lAQWtGkjVr l4qCyg7/Sq85UVEJBY5WkNNpG8h8GhJcwws0ZUgD6mNqfvH/MguSWXPQbOiWBkss IqF/fyxqznipzwuNSoHhxpgaXsxwmSFfPZkuS/vMxDtblIBAVQHdLGsE/EGlHxM4 pQw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 067294c0 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO) for ; Sun, 11 Dec 2022 18:01:02 +0000 (UTC) Date: Sun, 11 Dec 2022 19:00:59 +0100 From: Julien Lepiller To: guix-patches@gnu.org Subject: [PATCH] guix: Show better progress bars. Message-ID: <20221211190059.51c44520@sybil.lepiller.eu> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/.HCC6bQL1gh1VPY.aX8hpR8" Received-SPF: pass client-ip=2a00:5884:8208::1; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --MP_/.HCC6bQL1gh1VPY.aX8hpR8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Guix! The attached patch is a small improvement on our progress bars. Instead of our cute ASCII=C2=A0art: 1.2MiB/s 00:04 [### ] 18.5% We get something a little more smooth: 1.1MiB/s 00:04 =E2=96=95=E2=96=88=E2=96=88=E2=96=88 =E2=96=8F= 17.1% 1.2MiB/s 00:05 =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B = =E2=96=8F 20.7% Using unicode characters that can represent 1/8 of a character width. I used port-encoding to detect when the output supports unicode, but maybe there's something more dedicated to figuring that out? When the port encoding is not UTF-8, we fall back to the ASCII version. Thoughts? --MP_/.HCC6bQL1gh1VPY.aX8hpR8 Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-guix-Show-better-progress-bars.patch >From c428c80fd628797ae80029a0a22678ef55c68d6c Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Sun, 11 Dec 2022 18:51:13 +0100 Subject: [PATCH] guix: Show better progress bars. * guix/progress.scm (progress-bar): When supported, use unicode variant. --- guix/progress.scm | 43 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 36 insertions(+), 7 deletions(-) diff --git a/guix/progress.scm b/guix/progress.scm index 4f8e98edc0..527bf72839 100644 --- a/guix/progress.scm +++ b/guix/progress.scm @@ -166,16 +166,45 @@ (define current-terminal-columns ;; Number of columns of the terminal. (make-parameter 80)) +(define-record-type* + progress-bar-style make-progress-bar-style progress-bar-style? + (start progress-bar-style-start + (default #\x2595)) + (stop progress-bar-style-stop + (default #\x258f)) + (filled progress-bar-style-filled + (default #\x2588)) + (steps progress-bar-style-steps + (default '(#\x258F #\x258E #\x258D #\x258C #\x258B #\x258A #\x2589)))) + +(define unicode-bar-style (progress-bar-style)) +(define ascii-bar-style + (progress-bar-style + (start #\[) + (stop #\]) + (filled #\#) + (steps '()))) + (define* (progress-bar % #:optional (bar-width 20)) "Return % as a string representing an ASCII-art progress bar. The total width of the bar is BAR-WIDTH." - (let* ((bar-width (max 3 (- bar-width 2))) - (fraction (/ % 100)) - (filled (inexact->exact (floor (* fraction bar-width)))) - (empty (- bar-width filled))) - (format #f "[~a~a]" - (make-string filled #\#) - (make-string empty #\space)))) + (let* ((bar-style (if (equal? (port-encoding (current-output-port)) "UTF-8") + unicode-bar-style + ascii-bar-style)) + (bar-width (max 3 (- bar-width 2))) + (intermediates (+ (length (progress-bar-style-steps bar-style)) 1)) + (step (inexact->exact (floor (/ (* % bar-width intermediates) 100)))) + (filled (quotient step intermediates)) + (intermediate + (list-ref (cons #f (progress-bar-style-steps bar-style)) + (modulo step intermediates))) + (empty (- bar-width filled (if intermediate 1 0)))) + (format #f "~a~a~a~a~a" + (string (progress-bar-style-start bar-style)) + (make-string filled (progress-bar-style-filled bar-style)) + (if intermediate (string intermediate) "") + (make-string empty #\space) + (string (progress-bar-style-stop bar-style))))) (define (erase-current-line port) "Write an ANSI erase-current-line sequence to PORT to erase the whole line and -- 2.38.1 --MP_/.HCC6bQL1gh1VPY.aX8hpR8-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 11:20:41 2022 Received: (at submit) by debbugs.gnu.org; 21 Dec 2022 16:20:41 +0000 Received: from localhost ([127.0.0.1]:52699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p81pg-0007uJ-OE for submit@debbugs.gnu.org; Wed, 21 Dec 2022 11:20:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:36522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p81pe-0007uD-P2 for submit@debbugs.gnu.org; Wed, 21 Dec 2022 11:20:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p81pe-0000H2-GS for guix-patches@gnu.org; Wed, 21 Dec 2022 11:20:38 -0500 Received: from lepiller.eu ([89.234.186.109]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p81pc-0001Cj-Fo for guix-patches@gnu.org; Wed, 21 Dec 2022 11:20:37 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 209518c4; Wed, 21 Dec 2022 16:20:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=GJxXon1hxrrZ MPOo2QW4zwoYHR6qBQhOXz9WNs7woFY=; b=TpK0oNbW+icDgWPMmMTou1XwkZ9B LmFFhi80x7G6QW/lwinRITMDE5jqmyL5bTczpzfzT+ijSyQCGsqSqAIwJblGF27t ZvJL4jFORE6hJRx4q2ic8AtyzaKwxkmdpzIopkd6or6hm25yaVKrQx83sHiQts/E 18h20HGNlQoTdJ1y6LOOZI7qIpn+Jp8e1BWYE9nRwDyf4G31kgNjr2ZJFWYvJa4B +XMDNczrihNpsWXLYRQlsu8q+ki4Q70Q3nWPv/ul41eqGBCEsqcTFpr2nmaFv6wQ P96v2YC5yQPD6cEadZ00+5uqPiX0QGHqncrnpEjXFUHRCYExhEqkBwNIKg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 29bfa60f (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 21 Dec 2022 16:20:28 +0000 (UTC) Date: Wed, 21 Dec 2022 17:20:26 +0100 From: Julien Lepiller To: guix-patches@gnu.org, 59975@debbugs.gnu.org Subject: Re: [bug#59975] [PATCH] guix: Show better progress bars. User-Agent: K-9 Mail for Android In-Reply-To: <20221211190059.51c44520@sybil.lepiller.eu> References: <20221211190059.51c44520@sybil.lepiller.eu> Message-ID: <07A3E592-FE42-48AA-B5D4-16D72C3881FC@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----LE14JC1I1T6GKTTOAOBB72R3U7UYON Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=89.234.186.109; envelope-from=julien@lepiller.eu; helo=lepiller.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) ------LE14JC1I1T6GKTTOAOBB72R3U7UYON Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Guix! The patch is pretty simple, but I'm surprised nobody bikeshedded yet :) Thoughts? Le 11 d=C3=A9cembre 2022 19:00:59 GMT+01:00, Julien Lepiller a =C3=A9crit=C2=A0: >Hi Guix! > >The attached patch is a small improvement on our progress bars=2E Instead >of our cute ASCII=C2=A0art: > >1=2E2MiB/s 00:04 [### ] 18=2E5% > >We get something a little more smooth: > >1=2E1MiB/s 00:04 =E2=96=95=E2=96=88=E2=96=88=E2=96=88 =E2= =96=8F 17=2E1% >1=2E2MiB/s 00:05 =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B = =E2=96=8F 20=2E7% > >Using unicode characters that can represent 1/8 of a character width=2E > >I used port-encoding to detect when the output supports unicode, but >maybe there's something more dedicated to figuring that out? When the >port encoding is not UTF-8, we fall back to the ASCII version=2E > >Thoughts? ------LE14JC1I1T6GKTTOAOBB72R3U7UYON Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Guix!

The patch is pretty simple, but I'= m surprised nobody bikeshedded yet :)

Thoughts?

Le 11 d=C3=A9cembre 2022 19:00:59 GMT+01:00, Julien Lepiller = <julien@lepiller=2Eeu> a =C3=A9crit=C2=A0:
Hi Guix!

The attached patch is a=
 small improvement on our progress bars=2E Instead
of our cute ASCII&nbs=
p;art:

1=2E2MiB/s 00:04 [###               ]  18=2E5%

We get =
something a little more smooth:

1=2E1MiB/s 00:04 =E2=96=95=E2=96=88=
=E2=96=88=E2=96=88               =E2=96=8F  17=2E1%
1=2E2MiB/s 00:05 =E2=
=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B              =E2=96=8F  20=2E7%<=
br>
Using unicode characters that can represent 1/8 of a character width=
=2E

I used port-encoding to detect when the output supports unicode,=
 but
maybe there's something more dedicated to figuring that out? When t=
he
port encoding is not UTF-8, we fall back to the ASCII version=2E
<=
br>Thoughts?
------LE14JC1I1T6GKTTOAOBB72R3U7UYON-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 06 13:01:34 2023 Received: (at 59975) by debbugs.gnu.org; 6 Jan 2023 18:01:34 +0000 Received: from localhost ([127.0.0.1]:55795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDr25-0006m2-Mh for submit@debbugs.gnu.org; Fri, 06 Jan 2023 13:01:33 -0500 Received: from mail-wm1-f48.google.com ([209.85.128.48]:39869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDr22-0006l8-72 for 59975@debbugs.gnu.org; Fri, 06 Jan 2023 13:01:30 -0500 Received: by mail-wm1-f48.google.com with SMTP id g25-20020a7bc4d9000000b003d97c8d4941so4093415wmk.4 for <59975@debbugs.gnu.org>; Fri, 06 Jan 2023 10:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=iPlz6cjzlvHjFZOtYl2gqpGQ3axHxiUauRmZvaparfE=; b=SU7oCbaK2JTCCFR+Qwo0SxlVgjVHbIsvsiD3ac0+KcTKz/jJ+hxD3RMu/yWVwft4OB 7lHkHF1gO6HMf97i0ph/1nClAgEpgJpn5c9uuW/yV/HWXdYFKzn3sB6X6DC1Arxw07mg O1hr24jYUX5UVQ/whxodo9UECI4lQvwFjWMi32r55RVl2CjeArpR/Yv6Gy4AmNHce8Kh mD1ctaPlDNBx0DBgDU9R7WRFaD1ltI+W452A8g7wrYRXjxp+E19F6uJIWiBzd0xq+b5g PJav84E+4hVAm2bBolP8xJfJfrUa9jeS8Hj0TkaAhIvLVbzt7AScWaBg13xlYN6rLAwL RaFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=iPlz6cjzlvHjFZOtYl2gqpGQ3axHxiUauRmZvaparfE=; b=iGXB+SWQev8DUEUVDzuQWTxmfcNHa559DekUsnqMjIX5jGwJi8jdIktK6x/nhneZp2 O3yaM6yZoVv+JIipujZ64iO8opFpnmigyHyIZUkyOn0IE9pyKgERyjPVvznWjWrTYs+e AgK20FqTQZhi63LF0oDYjrKRIS5zlHUUcNVgR7Bgm2Jh8bXO2tOQol9p9jBU4VNWDK99 3AvVg4AsCf6ThNHP6k+XDeV39n1Co8tVmSgxW8NnXAxIPAjOHRNSYX1zF2mSzBmKsgvK o4ZqN26LuNhcJqDo3uLdHXXAeyyS+FogHuEH3+uHxIOgLcpADSPboeigv1QUllPxndA2 NIMA== X-Gm-Message-State: AFqh2kq0tGp6sfFU1f4sJuW5Q5DSlyrbghUKH/ZAKRx2THuWIRlyHT39 enPrrPmiu946jQ0KYu2ingUBStchGiQ= X-Google-Smtp-Source: AMrXdXtSXzFlvGVYXq40zPMDxiph+BEHTiaS/78Y5Zi5B+ZhIR7XA13LJEsrFWqRK+RFMAQGFtFWog== X-Received: by 2002:a05:600c:1d9b:b0:3c6:e63e:ba76 with SMTP id p27-20020a05600c1d9b00b003c6e63eba76mr10180250wms.4.1673028084767; Fri, 06 Jan 2023 10:01:24 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id d8-20020a05600c34c800b003c5571c27a1sm3002634wmq.32.2023.01.06.10.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jan 2023 10:01:24 -0800 (PST) From: Simon Tournier To: Julien Lepiller , 59975@debbugs.gnu.org Subject: Re: [bug#59975] [PATCH] guix: Show better progress bars. In-Reply-To: <07A3E592-FE42-48AA-B5D4-16D72C3881FC@lepiller.eu> References: <20221211190059.51c44520@sybil.lepiller.eu> <07A3E592-FE42-48AA-B5D4-16D72C3881FC@lepiller.eu> Date: Fri, 06 Jan 2023 18:45:48 +0100 Message-ID: <87358nh7zn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59975 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Julien, > Le 11 d=C3=A9cembre 2022 19:00:59 GMT+01:00, Julien Lepiller a =C3=A9crit=C2=A0: >>1.1MiB/s 00:04 =E2=96=95=E2=96=88=E2=96=88=E2=96=88 =E2=96= =8F 17.1% >>1.2MiB/s 00:05 =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B = =E2=96=8F 20.7% On Wed, 21 Dec 2022 at 17:20, Julien Lepiller wrote: > The patch is pretty simple, but I'm surprised nobody bikeshedded yet :) Personally, I am not fan of fancy Unicode. :-) But the patch LGTM. Well, if there is no strong objection and since it is more than 25 days, maybe you could apply it after waiting a couple more of days. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 13 12:08:05 2023 Received: (at 59975) by debbugs.gnu.org; 13 Jan 2023 17:08:05 +0000 Received: from localhost ([127.0.0.1]:52261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGNXB-0001xE-4a for submit@debbugs.gnu.org; Fri, 13 Jan 2023 12:08:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pGNX9-0001wh-Ll for 59975@debbugs.gnu.org; Fri, 13 Jan 2023 12:08:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGNWr-0006ld-5M; Fri, 13 Jan 2023 12:07:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=apyBmW53qBDK2o7iVA+H7dVx9o6UG4cFXJm2r2dKX40=; b=kIbplnmrxKjTDeww1Qyf ua1drTK/NjC4ZtJ0rs2h5gWi+sHXurXrAZkfgl1YFoF41dD8/eOIAf+WW11Ri1JwOci/xmH3n85/S kATOw6henuUP/69HdjWpzhK663OVy68fn9TPjz63Jc0C8+IX+Sb5TyPd+VU9NzakhijMA57lvhj8c 5qNoIm42IjSmdTmvtc9Yuhq4GB/W3idzBpdNNAFh5UFSkNLWBCxcso5ThHKI1bsfZoYHFv09wxlAE Ub4qnu39WwjVffZ4C0wzBiFlnLqQdf3Eyf4Ai+U0f29wRrgYsl2DlkIoCIHSA+kehnigzNmpG0Gkh Thup8nz0BTbR+Q==; Received: from [193.50.110.246] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pGNWq-0004CY-IT; Fri, 13 Jan 2023 12:07:44 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: bug#59975: [PATCH] guix: Show better progress bars. References: <20221211190059.51c44520@sybil.lepiller.eu> Date: Fri, 13 Jan 2023 18:07:42 +0100 In-Reply-To: <20221211190059.51c44520@sybil.lepiller.eu> (Julien Lepiller's message of "Sun, 11 Dec 2022 19:00:59 +0100") Message-ID: <877cxqbbxd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59975 Cc: 59975@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello! Julien Lepiller skribis: > Hi Guix! > > The attached patch is a small improvement on our progress bars. Instead > of our cute ASCII=C2=A0art: > > 1.2MiB/s 00:04 [### ] 18.5% > > We get something a little more smooth: > > 1.1MiB/s 00:04 =E2=96=95=E2=96=88=E2=96=88=E2=96=88 =E2=96= =8F 17.1% > 1.2MiB/s 00:05 =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B = =E2=96=8F 20.7% > > Using unicode characters that can represent 1/8 of a character width. Woow, fancy! Love it!! Too bad I was too late to have it under the Newtonmas tree. =F0=9F=8E=84 > I used port-encoding to detect when the output supports unicode, but > maybe there's something more dedicated to figuring that out? When the > port encoding is not UTF-8, we fall back to the ASCII version. One question: how likely is it that people won=E2=80=99t have a font with t= hose glyphs to display it correctly? It would be good to check in xterm, Linux console with some default font, and GNOME/Xfce terminals with defaults. (Works for me in xterm and in Emacs, FWIW.) >>>From c428c80fd628797ae80029a0a22678ef55c68d6c Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sun, 11 Dec 2022 18:51:13 +0100 > Subject: [PATCH] guix: Show better progress bars. > > * guix/progress.scm (progress-bar): When supported, use unicode variant. Please describe all the changes. > +(define-record-type* > + progress-bar-style make-progress-bar-style progress-bar-style? > + (start progress-bar-style-start > + (default #\x2595)) > + (stop progress-bar-style-stop > + (default #\x258f)) > + (filled progress-bar-style-filled > + (default #\x2588)) > + (steps progress-bar-style-steps > + (default '(#\x258F #\x258E #\x258D #\x258C #\x258B #\x258A #\x= 2589)))) > + > +(define unicode-bar-style (progress-bar-style)) How about just dropping the =E2=80=98default=E2=80=99 bits and being explic= it here? > + (let* ((bar-style (if (equal? (port-encoding (current-output-port)) "U= TF-8") > + unicode-bar-style > + ascii-bar-style)) In theory you want to check for Unicode-capable, not UTF-8-encoded. There are ways to do that (see =E2=80=98right-arrow=E2=80=99 in (guix ui)),= but it=E2=80=99s more expensive and trickier, so what you=E2=80=99re doing here is good enou= gh IMO (I actually did that in (guix scripts weather) too). > + (bar-width (max 3 (- bar-width 2))) > + (intermediates (+ (length (progress-bar-style-steps bar-style))= 1)) > + (step (inexact->exact (floor (/ (* % bar-width intermediate= s) 100)))) > + (filled (quotient step intermediates)) > + (intermediate > + (list-ref (cons #f (progress-bar-style-steps bar-style)) > + (modulo step intermediates))) > + (empty (- bar-width filled (if intermediate 1 0)))) > + (format #f "~a~a~a~a~a" s/format/simple-format/ for slightly better performance. Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 15 05:12:31 2023 Received: (at 59975) by debbugs.gnu.org; 15 Jan 2023 10:12:31 +0000 Received: from localhost ([127.0.0.1]:56163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH006-0007A7-T9 for submit@debbugs.gnu.org; Sun, 15 Jan 2023 05:12:31 -0500 Received: from lepiller.eu ([89.234.186.109]:57670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH002-00079t-Im for 59975@debbugs.gnu.org; Sun, 15 Jan 2023 05:12:29 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 30f174cc; Sun, 15 Jan 2023 10:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=XRse83JCb35i565g+9pxPkrKdUOwjPLcDNkcOB zBZJU=; b=Lk+/7BgdJDYUYrQqh/LIxxO9yUk/bc+JrXUim3e5623A5agI+YcJx4 RmLSfuWQeycv9s37kVf67cD2kYpwwbWiw7BKzG0j08rp+cbyjpv5Ufr3WjMGpZLh o/0FVKeSfTsfC1MshNRj6oslMwjmYeERUDp1gAg2BhhSuKbn37WoVe9tRHLagsNj 4wnlKaqQv/pglcyIGmvuFvjt3kLp6xdNdzTjthRui8xU5y2J6vrC5pjeCn80xVd5 Eg4luyDR4EVF+xTqiZ/0OyPxRz3cFDkRGI9RpQ87ZQ27IXyv5FcIeDixVVBrVg1w ayHDVGeP9npnoPJxvrpwJYs/A5XoQ3EQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 6b45923f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 15 Jan 2023 10:12:13 +0000 (UTC) Date: Sun, 15 Jan 2023 11:12:02 +0100 From: Julien Lepiller To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Subject: Re: bug#59975: [PATCH] guix: Show better progress bars. Message-ID: <20230115111202.1874dc7f@sybil.lepiller.eu> In-Reply-To: <877cxqbbxd.fsf@gnu.org> References: <20221211190059.51c44520@sybil.lepiller.eu> <877cxqbbxd.fsf@gnu.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/Oozoe8KU_MepTzscpA8r3vc" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59975 Cc: 59975@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --MP_/Oozoe8KU_MepTzscpA8r3vc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Le Fri, 13 Jan 2023 18:07:42 +0100, Ludovic Court=C3=A8s a =C3=A9crit : > Hello! >=20 > Julien Lepiller skribis: >=20 > > Hi Guix! > > > > The attached patch is a small improvement on our progress bars. > > Instead of our cute ASCII=C2=A0art: > > > > 1.2MiB/s 00:04 [### ] 18.5% > > > > We get something a little more smooth: > > > > 1.1MiB/s 00:04 =E2=96=95=E2=96=88=E2=96=88=E2=96=88 =E2= =96=8F 17.1% > > 1.2MiB/s 00:05 =E2=96=95=E2=96=88=E2=96=88=E2=96=88=E2=96=8B = =E2=96=8F 20.7% > > > > Using unicode characters that can represent 1/8 of a character > > width. =20 >=20 > Woow, fancy! Love it!! Too bad I was too late to have it under the > Newtonmas tree. =F0=9F=8E=84 >=20 > > I used port-encoding to detect when the output supports unicode, but > > maybe there's something more dedicated to figuring that out? When > > the port encoding is not UTF-8, we fall back to the ASCII version. =20 >=20 > One question: how likely is it that people won=E2=80=99t have a font with > those glyphs to display it correctly? >=20 > It would be good to check in xterm, Linux console with some default > font, and GNOME/Xfce terminals with defaults. >=20 > (Works for me in xterm and in Emacs, FWIW.) I think it's pretty common to have these characters, since they are used by many other projects. However, testing on a tty, I can only see the filled characters, but not the semi-filled ones, so I get something like: ?=E2=96=88=E2=96=88=E2=96=88? ? What do you think? Attached v2. --MP_/Oozoe8KU_MepTzscpA8r3vc Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-guix-Show-better-progress-bars.patch >From 7e4c8fbcc49068ce5a9a592d8daf7b0039ce6680 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Sun, 11 Dec 2022 18:51:13 +0100 Subject: [PATCH] guix: Show better progress bars. Style provides information on the characters to use before and after the progress bar content (`[` and `]` for the ascii style), as well as the character for filled step (`#` for ascii style). When supported, it provides intermediate steps. This is used for unicode style, to show better precision. * guix/progress.scm (): New record type. (ascii-bar-style, unicode-bar-style): New variables. (progress-bar): Draw progress depending on style. When supported, use unicode style. Fall back to ascii style. --- guix/progress.scm | 45 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/guix/progress.scm b/guix/progress.scm index 4f8e98edc0..33cf6f4a1a 100644 --- a/guix/progress.scm +++ b/guix/progress.scm @@ -166,16 +166,47 @@ (define current-terminal-columns ;; Number of columns of the terminal. (make-parameter 80)) +(define-record-type* + progress-bar-style make-progress-bar-style progress-bar-style? + (start progress-bar-style-start) + (stop progress-bar-style-stop) + (filled progress-bar-style-filled) + (steps progress-bar-style-steps)) + +(define ascii-bar-style + (progress-bar-style + (start #\[) + (stop #\]) + (filled #\#) + (steps '()))) + +(define unicode-bar-style + (progress-bar-style + (start #\x2595) + (stop #\x258f) + (filled #\x2588) + (steps '(#\x258F #\x258E #\x258D #\x258C #\x258B #\x258A #\x2589)))) + (define* (progress-bar % #:optional (bar-width 20)) "Return % as a string representing an ASCII-art progress bar. The total width of the bar is BAR-WIDTH." - (let* ((bar-width (max 3 (- bar-width 2))) - (fraction (/ % 100)) - (filled (inexact->exact (floor (* fraction bar-width)))) - (empty (- bar-width filled))) - (format #f "[~a~a]" - (make-string filled #\#) - (make-string empty #\space)))) + (let* ((bar-style (if (equal? (port-encoding (current-output-port)) "UTF-8") + unicode-bar-style + ascii-bar-style)) + (bar-width (max 3 (- bar-width 2))) + (intermediates (+ (length (progress-bar-style-steps bar-style)) 1)) + (step (inexact->exact (floor (/ (* % bar-width intermediates) 100)))) + (filled (quotient step intermediates)) + (intermediate + (list-ref (cons #f (progress-bar-style-steps bar-style)) + (modulo step intermediates))) + (empty (- bar-width filled (if intermediate 1 0)))) + (simple-format #f "~a~a~a~a~a" + (string (progress-bar-style-start bar-style)) + (make-string filled (progress-bar-style-filled bar-style)) + (if intermediate (string intermediate) "") + (make-string empty #\space) + (string (progress-bar-style-stop bar-style))))) (define (erase-current-line port) "Write an ANSI erase-current-line sequence to PORT to erase the whole line and -- 2.38.1 --MP_/Oozoe8KU_MepTzscpA8r3vc-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 17 04:06:41 2023 Received: (at 59975) by debbugs.gnu.org; 17 Jan 2023 09:06:41 +0000 Received: from localhost ([127.0.0.1]:35650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHhvU-0008BD-Ox for submit@debbugs.gnu.org; Tue, 17 Jan 2023 04:06:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHhvT-0008Ay-Bh for 59975@debbugs.gnu.org; Tue, 17 Jan 2023 04:06:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHhvN-0002fz-OX; Tue, 17 Jan 2023 04:06:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=MMvmMkImp7b5oAyECohyFNYaUGcxhUB1UJkUxdrwY6k=; b=feLFyuGSO0RqWtD9OlIE Xv0Xtgs+cD1aWLfOu0st2pCU6bjCbDk6+D/nn2EjGuybll32TWcPwRwXRn0DfCUI9NqtxUxjpWQ+z WkJcdHdqq/4cunbdxLi5ui9n0NCZRLz0ykdNPKly/zvUzaW5dsP9vIe9KS0v9gYgn+DaIwnR4LeKL CKAsrzrqt74iQtWneOZQWwJ8vPeURwDI64SjcwnTM/ZW0WRwuvlRfp8nWehesXBekG7fjUYgka3DI XNOPktnE3f/6J/5IIC+xtEqr3QIooWBjPkxTApQ/8gV8FIxM2RwVeXnv9yDTeX6TNOA1rfS9oLVBC 5LaEswS5y0Hn3Q==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHhvM-00057n-7q; Tue, 17 Jan 2023 04:06:33 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Julien Lepiller Subject: Re: bug#59975: [PATCH] guix: Show better progress bars. References: <20221211190059.51c44520@sybil.lepiller.eu> <877cxqbbxd.fsf@gnu.org> <20230115111202.1874dc7f@sybil.lepiller.eu> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 28 =?utf-8?Q?Niv=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Zinc X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 17 Jan 2023 10:06:30 +0100 In-Reply-To: <20230115111202.1874dc7f@sybil.lepiller.eu> (Julien Lepiller's message of "Sun, 15 Jan 2023 11:12:02 +0100") Message-ID: <87ilh5jzs9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59975 Cc: 59975@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Julien Lepiller skribis: > Le Fri, 13 Jan 2023 18:07:42 +0100, > Ludovic Court=C3=A8s a =C3=A9crit : [...] >> It would be good to check in xterm, Linux console with some default >> font, and GNOME/Xfce terminals with defaults. >>=20 >> (Works for me in xterm and in Emacs, FWIW.) > > I think it's pretty common to have these characters, since they are > used by many other projects. However, testing on a tty, I can only see > the filled characters, but not the semi-filled ones, so I get something > like: > > ?=E2=96=88=E2=96=88=E2=96=88? ? > > What do you think? Maybe use ASCII when $TERM is =E2=80=9Clinux=E2=80=9D? Though again that probably depends on the font, not on the terminal type, and that you cannot guess. > Attached v2. > > From 7e4c8fbcc49068ce5a9a592d8daf7b0039ce6680 Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sun, 11 Dec 2022 18:51:13 +0100 > Subject: [PATCH] guix: Show better progress bars. > > Style provides information on the characters to use before and after the > progress bar content (`[` and `]` for the ascii style), as well as the > character for filled step (`#` for ascii style). When supported, it > provides intermediate steps. This is used for unicode style, to show > better precision. > > * guix/progress.scm (): New record type. > (ascii-bar-style, unicode-bar-style): New variables. > (progress-bar): Draw progress depending on style. When supported, use > unicode style. Fall back to ascii style. LGTM. Maybe send a heads-up on guix-devel to see if someone has something to say about the ability to display those glyphs, wait a few more days, and push if there are no objections? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 13:56:30 2023 Received: (at 59975) by debbugs.gnu.org; 27 Jan 2023 18:56:30 +0000 Received: from localhost ([127.0.0.1]:38463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLTtl-0003gt-PE for submit@debbugs.gnu.org; Fri, 27 Jan 2023 13:56:30 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:36745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLTth-0003g1-Cf for 59975@debbugs.gnu.org; Fri, 27 Jan 2023 13:56:25 -0500 Received: by mail-wr1-f47.google.com with SMTP id b7so5827241wrt.3 for <59975@debbugs.gnu.org>; Fri, 27 Jan 2023 10:56:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8vqIKamTuHQhy35aHd6Q5grbx2c839/n6bvE1F38Nns=; b=EnSItlkOOGa50a3L6O+r9CYFz0Y0KoeEY84CD+RXGsaWsk9r3YW8WvWcATiBollJaB xRmfLQMu1bN/Mmrs9gYRxu8wTTEN6QQubr0J03GUHahqCngxP0v7Saspi7h7Zvo6c0c2 +8xOftHfO+rOHSRvgXa2UMIVi5jC+ngKljfQ6SMPjnpZ2YTkNCcEfuPe9Jy6vXydDEEd Uo7rLyYfSTNSsOAAp4PpUqR1DFMcK+IIQLe+vb/APfBLzACPuVt7WHExqpd5ldEXJ61O f2CygrNV8NyI/sT9d0EPOj0WGoUsptAKHbJeq+/9yUAIF4VJ6HJLFNkarHH7u3NemCxt wU7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8vqIKamTuHQhy35aHd6Q5grbx2c839/n6bvE1F38Nns=; b=QEvnLMcbsRJa9CUdr3BjE2W0m9THWaahkyow7EzFracq2x6pHART7awMMMi800aUnt lcHXrZPGBgZU/NcYE9Gz0b6WxbBZqZlk04W3s01wbkAVJCEM0uPX6QYRaSPQFsfM+ViF VjXEU3PmJfGvCR8XxfctW2IPx8VxVlqtCF1YkZwd4GH5SNL4ztqYZOdC8lRKGUxfbAK2 XicCrWX0A6bXVMv6UmJbTX9p27032dNBaks5ecBTyly3yyOJ7WFGbIN7Qyx0fSgjbj03 IZVLnBTJ+Z6k29Sshry/KVbJyX/RMWv4geD6c1MbD6Vqr0ciR+68hqNSaoSeOufZhmv3 XlPQ== X-Gm-Message-State: AFqh2ko4nX+4jLrqCv+z/+T6smywH2rol11h1DXIR6HygppvuS4KHh+d V1eoL2L3ErTjRjYZdInt5HA9vAD2FPU= X-Google-Smtp-Source: AMrXdXswEtTEva6gOrNDL75yrSPCykq0zhGU3/qhAjSldvE+zG5+bCcPOtnBWapAcGtxpbls1r1Lhg== X-Received: by 2002:a5d:5d0c:0:b0:2be:5402:18e7 with SMTP id ch12-20020a5d5d0c000000b002be540218e7mr7047433wrb.5.1674845779754; Fri, 27 Jan 2023 10:56:19 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id i6-20020adff306000000b002425be3c9e2sm4732057wro.60.2023.01.27.10.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 10:56:19 -0800 (PST) From: Simon Tournier To: Ludovic =?utf-8?Q?Court=C3=A8s?= , Julien Lepiller Subject: Re: [bug#59975] [PATCH] guix: Show better progress bars. In-Reply-To: <87ilh5jzs9.fsf@gnu.org> References: <20221211190059.51c44520@sybil.lepiller.eu> <877cxqbbxd.fsf@gnu.org> <20230115111202.1874dc7f@sybil.lepiller.eu> <87ilh5jzs9.fsf@gnu.org> Date: Fri, 27 Jan 2023 19:05:10 +0100 Message-ID: <87tu0bn99l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59975 Cc: 59975@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On mar., 17 janv. 2023 at 10:06, Ludovic Court=C3=A8s wrote: > LGTM. And it LGTM too [1]. :-) 1: > Maybe send a heads-up on guix-devel to see if someone has something to > say about the ability to display those glyphs, wait a few more days, and > push if there are no objections? What is the status of this patch? I am sure people will find it nice. :-) Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 06:56:29 2023 Received: (at 59975) by debbugs.gnu.org; 3 Feb 2023 11:56:29 +0000 Received: from localhost ([127.0.0.1]:36621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNug9-0000f9-BA for submit@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:29 -0500 Received: from lepiller.eu ([89.234.186.109]:46082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNug6-0000es-Jo for 59975@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:27 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 66c0a1dd for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=dkim; bh=b/EuZfwFi79JMmDZjAie38n+sskHpLYpG+/clM07Ptg=; b=F+tk pZShKZ9p/wT2ezQm+hcHB1eISgREwpU19qh1wM5tauRe1y4w9fD5rtqSiFQpcQNT PEBza+59Lz5RmwyGwDXivgdZ9fG2TAIPYC0La8Ge//RsxVCb0AlVYVnO2tLvXm2y iXwS1/jbywaNM6Kw4VznRHAbudb4Sbl9WLL9C8342wcecH8rrRRJp1ci6Rjk+7XH 5cVYQaNd+ljF6Cdk/ZlX1VKHtf1GJjnIveloJWLHAnymvs2nfqHIZFIDtOcFqYDX SyVGx4KKP+xgb+DgMqfvpoLGJ/uiTEHVGk+F8KpgSTqkS7hAj0CBMKlYlmSomDCs 7xtBF5gi2SQt2+78xQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 3e34f256 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:23 +0000 (UTC) From: Julien Lepiller To: 59975@debbugs.gnu.org Subject: [PATCH v3 0/2] guix: Show better progress bars. Date: Fri, 3 Feb 2023 12:56:01 +0100 Message-Id: X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59975 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Guix! Here's the new version, it's now a small series. The first patch sets unifont as default, so we can see the fancy bars in a TTY :) The second hasn't changed. Julien Lepiller (2): gnu: Use unifont by default in TTYs. guix: Show better progress bars. gnu/services/base.scm | 7 +++---- guix/progress.scm | 45 ++++++++++++++++++++++++++++++++++++------- 2 files changed, 41 insertions(+), 11 deletions(-) base-commit: 92755c6352fd967bc74d8e5354aad057d779b717 -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 06:56:30 2023 Received: (at 59975) by debbugs.gnu.org; 3 Feb 2023 11:56:30 +0000 Received: from localhost ([127.0.0.1]:36624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNug9-0000fD-OP for submit@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:30 -0500 Received: from lepiller.eu ([89.234.186.109]:46082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNug8-0000es-0X for 59975@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:28 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 6307fa18 for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=dkim; bh=3rAkWM31cpLJM1lru/vmcL7/m oiClVSo353VBZqmq18=; b=UkrnvMI7ohfi0RtS+bD5mfaYLzZAdp3xgNh7esKND 4Gintm4JxVsxjGHoc21sPesLrpJ6jdIZSuaLaWGr7xMgnNqL2Uok7pWjdVOTjfrc KN3UssYt7vrP60gEO/uqisAR/FX1w5PqRvQa9VfYsSmQ7O5lyXA8cUEUyFW4rF3w 1hqwtZhYIwHxiHcgO5qW4SyfjV2cnmop/y72diiovsk6Mi8ungi7cchTWt5EUUoQ nmWgc3zeUtMLHrvDr1MRP+rkA3/PNKu2z3zJBdurQisgssV/mPxl47analH/GNPK FzmBFHQw2dbdmLWrFTtBaVPD3udUp1C+Awn/DgSM3i+uQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 86d43e64 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:24 +0000 (UTC) From: Julien Lepiller To: 59975@debbugs.gnu.org Subject: [PATCH v3 1/2] gnu: Use unifont by default in TTYs. Date: Fri, 3 Feb 2023 12:56:02 +0100 Message-Id: <7ed43a449e8d598e316c649454363f5a2e7d7d7b.1675425118.git.julien@lepiller.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59975 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It has even better language support than LatGrkCyr-8x16 and can show fancy progress bars. * gnu/services/base.scm (%default-console-font): Use unifont. --- gnu/services/base.scm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gnu/services/base.scm b/gnu/services/base.scm index 9e799445d2..b062e445f2 100644 --- a/gnu/services/base.scm +++ b/gnu/services/base.scm @@ -64,6 +64,7 @@ (define-module (gnu services base) #:select (coreutils glibc glibc-utf8-locales tar canonical-package)) #:use-module ((gnu packages compression) #:select (gzip)) + #:use-module (gnu packages fonts) #:autoload (gnu packages guile-xyz) (guile-netlink) #:autoload (gnu packages hurd) (hurd) #:use-module (gnu packages package-management) @@ -749,10 +750,8 @@ (define console-keymap-service-type of console keymaps with @command{loadkeys}."))) (define %default-console-font - ;; Note: 'LatGrkCyr-8x16' has the advantage of providing three common - ;; scripts as well as glyphs for em dash, quotation marks, and other Unicode - ;; codepoints notably found in the UTF-8 manual. - "LatGrkCyr-8x16") + #~(string-append #$font-gnu-unifont:psf + "/share/consolefonts/Unifont-APL8x16.psf.gz")) (define (console-font-shepherd-services tty+font) "Return a list of Shepherd services for each pair in TTY+FONT." -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 06:56:35 2023 Received: (at 59975) by debbugs.gnu.org; 3 Feb 2023 11:56:35 +0000 Received: from localhost ([127.0.0.1]:36626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNugD-0000fX-6h for submit@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:35 -0500 Received: from lepiller.eu ([89.234.186.109]:46082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNug9-0000es-3G for 59975@debbugs.gnu.org; Fri, 03 Feb 2023 06:56:29 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id fd846c3c for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=from:to :subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; s=dkim; bh=nx7qSxU2/i4xCOUJZpgvmthrF 0UgB5d+wEWDvlDEFUA=; b=cV9rK/6qpeOZd7tugcc9jgEcqyvyjIvwMIWjT2iwt /gTkTxi0KjJLL92lE5UFaioBgPEztn3mBjlKfzdZR26fJuwNZqNmvFdWr4Ei6Ov3 qe/OgsYygxAjCCiSPwFhVxJhEx1UIQ6no3UOpZ2v4qw9Y6yRKPlhTjyFyIXMdqdl p72XtEDSuXllCaZihNzkDyaKZS0V6j6A0c2BVX3Ukjy4bLjSprJmkYOlWUfs2Tp1 ry6knESUb9/Ese1e/JEaH8OA/e79bHQnaU3XCE+775rOEnaKMoyEN8JsMkDDjN/g JZouTkCqUeFQlOAHcneycJBqbB8aFfYWKARpCisEJwpSg== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 61da51f6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for <59975@debbugs.gnu.org>; Fri, 3 Feb 2023 11:56:24 +0000 (UTC) From: Julien Lepiller To: 59975@debbugs.gnu.org Subject: [PATCH v3 2/2] guix: Show better progress bars. Date: Fri, 3 Feb 2023 12:56:03 +0100 Message-Id: <11508dcf7a46f6570d329f6c3b98e73198842ca4.1675425118.git.julien@lepiller.eu> X-Mailer: git-send-email 2.38.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59975 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Style provides information on the characters to use before and after the progress bar content (`[` and `]` for the ascii style), as well as the character for filled step (`#` for ascii style). When supported, it provides intermediate steps. This is used for unicode style, to show better precision. * guix/progress.scm (): New record type. (ascii-bar-style, unicode-bar-style): New variables. (progress-bar): Draw progress depending on style. When supported, use unicode style. Fall back to ascii style. --- guix/progress.scm | 45 ++++++++++++++++++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 7 deletions(-) diff --git a/guix/progress.scm b/guix/progress.scm index 4f8e98edc0..33cf6f4a1a 100644 --- a/guix/progress.scm +++ b/guix/progress.scm @@ -166,16 +166,47 @@ (define current-terminal-columns ;; Number of columns of the terminal. (make-parameter 80)) +(define-record-type* + progress-bar-style make-progress-bar-style progress-bar-style? + (start progress-bar-style-start) + (stop progress-bar-style-stop) + (filled progress-bar-style-filled) + (steps progress-bar-style-steps)) + +(define ascii-bar-style + (progress-bar-style + (start #\[) + (stop #\]) + (filled #\#) + (steps '()))) + +(define unicode-bar-style + (progress-bar-style + (start #\x2595) + (stop #\x258f) + (filled #\x2588) + (steps '(#\x258F #\x258E #\x258D #\x258C #\x258B #\x258A #\x2589)))) + (define* (progress-bar % #:optional (bar-width 20)) "Return % as a string representing an ASCII-art progress bar. The total width of the bar is BAR-WIDTH." - (let* ((bar-width (max 3 (- bar-width 2))) - (fraction (/ % 100)) - (filled (inexact->exact (floor (* fraction bar-width)))) - (empty (- bar-width filled))) - (format #f "[~a~a]" - (make-string filled #\#) - (make-string empty #\space)))) + (let* ((bar-style (if (equal? (port-encoding (current-output-port)) "UTF-8") + unicode-bar-style + ascii-bar-style)) + (bar-width (max 3 (- bar-width 2))) + (intermediates (+ (length (progress-bar-style-steps bar-style)) 1)) + (step (inexact->exact (floor (/ (* % bar-width intermediates) 100)))) + (filled (quotient step intermediates)) + (intermediate + (list-ref (cons #f (progress-bar-style-steps bar-style)) + (modulo step intermediates))) + (empty (- bar-width filled (if intermediate 1 0)))) + (simple-format #f "~a~a~a~a~a" + (string (progress-bar-style-start bar-style)) + (make-string filled (progress-bar-style-filled bar-style)) + (if intermediate (string intermediate) "") + (make-string empty #\space) + (string (progress-bar-style-stop bar-style))))) (define (erase-current-line port) "Write an ANSI erase-current-line sequence to PORT to erase the whole line and -- 2.38.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 05:03:17 2023 Received: (at submit) by debbugs.gnu.org; 12 Feb 2023 10:03:17 +0000 Received: from localhost ([127.0.0.1]:44109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR9CX-000479-8H for submit@debbugs.gnu.org; Sun, 12 Feb 2023 05:03:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:34926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR9CV-00046u-4Q for submit@debbugs.gnu.org; Sun, 12 Feb 2023 05:03:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pR9CU-000568-Pr for guix-patches@gnu.org; Sun, 12 Feb 2023 05:03:14 -0500 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pR9CT-0002cU-9E for guix-patches@gnu.org; Sun, 12 Feb 2023 05:03:14 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 848A41661A; Sun, 12 Feb 2023 10:03:11 +0000 (GMT) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ba9ce061; Sun, 12 Feb 2023 10:03:10 +0000 (UTC) References: <20221211190059.51c44520@sybil.lepiller.eu> User-agent: mu4e 1.8.11; emacs 28.2 From: Christopher Baines To: Julien Lepiller Subject: Re: [bug#59975] [PATCH v3 0/2] guix: Show better progress bars. Date: Sun, 12 Feb 2023 10:02:50 +0000 In-reply-to: Message-ID: <87a61j42w3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 59975@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Julien Lepiller writes: > Here's the new version, it's now a small series. The first patch sets > unifont as default, so we can see the fancy bars in a TTY :) The second > hasn't changed. > > Julien Lepiller (2): > gnu: Use unifont by default in TTYs. > guix: Show better progress bars. > > gnu/services/base.scm | 7 +++---- > guix/progress.scm | 45 ++++++++++++++++++++++++++++++++++++------- > 2 files changed, 41 insertions(+), 11 deletions(-) > > > base-commit: 92755c6352fd967bc74d8e5354aad057d779b717 I haven't tried this out, but the changes look good to me :) Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmPouVxfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XciVQ//dCf/TpGji3auy8sI6KzC7dNDBSesp4wy +jS8ZWDWtizUTVOqH69bss5b+LSh6ss/EW0pViuwSkWCdo3YtwBGNftodRHONLwZ f4uvx7NkuOTmh0MXTLZ4D9V47+n3omJbhmAjPHeADWhpkbsqlu4EYEgN2i/AP9XY Vueqtu7OAjgI6aaDkTfEVtp1rkxlQHBwOfg7sts0LYnQupOGwLpY37d6LNA6NYV9 gw39hrblc6r+6oxhx3+5OTdv7xsuIZUqJvCinFc1n1I36SA2iMAqAJn9797+n4Em /w2QWiyw7+H9BxCy0O+kHD8DYP9zg8weI0/IIj3n75lqtH3Bf7r7X7D0SdsK7fIG 3cvzdEAZMU2d78Fk5LTwG0iJNt0XA6rZJEPfRj2bCT5WHQAp3werh4M/qP0YCwEd W6FzlJC1xZ1+yYVKMTkYNXAeEv/ZxVNWRuPCkbHa+0+MCkd3aI2liYAV+dZrIjUj vHbxw72b0W454p/OT1LLEmvKOyxavAL82TVpMD1aPtDUx4GFaJsktjO5ftH6zxrR nzHsOePJEEiB3vVqgmq1OOgxhVVX7p6Wgesrm7UyM3DySlKJ622G6/ImBSPKcxtR MGgZS0h9dtlIkwfw2BtahFXJJNt1ZUs4eOtyRo9fGNCESgWxPMtK0aHyb4z77dO/ pS5cdLO5DFU= =J6ei -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 04:11:59 2023 Received: (at 59975-done) by debbugs.gnu.org; 19 Feb 2023 09:11:59 +0000 Received: from localhost ([127.0.0.1]:45657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTfji-0005Id-Sj for submit@debbugs.gnu.org; Sun, 19 Feb 2023 04:11:59 -0500 Received: from lepiller.eu ([89.234.186.109]:39784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTfjf-0005IQ-Tq for 59975-done@debbugs.gnu.org; Sun, 19 Feb 2023 04:11:57 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 8ddf17bd; Sun, 19 Feb 2023 09:11:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type; s=dkim; bh=YOXMUdXkCPVc6KzboZFmJDwlMRpFnChg4PyaP5 D0xgs=; b=C0fRdkmDm9mJso0Nm804R04y70fDRPuuXygTSiFleYKOzpELa+6AoT NiWY9y97w/EM9K/040VI1QpsykkeLncEyrH5KiW4kw4ED3Wo/nUZ/5Fca+DzxtfD KlOTkJ1xCp8FiXFaLxOt6c5HF29PDqstV+9p/1iHiwyK4uDYc2ZILS2IBET7g1JS 2HwPPw8POevTkBirtr6I/dv7zgWVmjcpwcKvrIt43o2csOA/00aDQo6B+Rt5LUAH DP2NPHCmXDHvNnVcD/570sl7snvzjyau3FBsBROBCcU7RjiIl9hL0+wGDCZnKulI 14DjXt212r9YVt9ewWLdNNls0RHAy/ZQ== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 9d983735 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 19 Feb 2023 09:11:53 +0000 (UTC) Date: Sun, 19 Feb 2023 10:11:47 +0100 From: Julien Lepiller To: Christopher Baines Subject: Re: [bug#59975] [PATCH v3 0/2] guix: Show better progress bars. Message-ID: <20230219101147.246695b1@sybil.lepiller.eu> In-Reply-To: <87a61j42w3.fsf@cbaines.net> References: <20221211190059.51c44520@sybil.lepiller.eu> <87a61j42w3.fsf@cbaines.net> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/oYVZzCBl=UeB5opI/4G6Lcx"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59975-done Cc: 59975-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Sig_/oYVZzCBl=UeB5opI/4G6Lcx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Finally pushed to master as 01334a61c7541d8ae29c5252e2e5b3ed7a59c552 and 189525412e3d803f3f77e15ec4a62aaa57f65a2d. Le Sun, 12 Feb 2023 10:02:50 +0000, Christopher Baines a =C3=A9crit : > Julien Lepiller writes: >=20 > > Here's the new version, it's now a small series. The first patch > > sets unifont as default, so we can see the fancy bars in a TTY :) > > The second hasn't changed. > > > > Julien Lepiller (2): > > gnu: Use unifont by default in TTYs. > > guix: Show better progress bars. > > > > gnu/services/base.scm | 7 +++---- > > guix/progress.scm | 45 > > ++++++++++++++++++++++++++++++++++++------- 2 files changed, 41 > > insertions(+), 11 deletions(-) > > > > > > base-commit: 92755c6352fd967bc74d8e5354aad057d779b717 =20 >=20 > I haven't tried this out, but the changes look good to me :) >=20 > Thanks, >=20 > Chris --Sig_/oYVZzCBl=UeB5opI/4G6Lcx Content-Type: application/pgp-signature Content-Description: Signature digitale OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEHvsJCR8X0ozL+bE6U9RXstY27oIFAmPx59MACgkQU9RXstY2 7oKLkg/8C40oBO1BqPWfMrREzzPa5seJj5x618rQUdoGIEwB0xLj26WBqAoAAcv8 v/3hQ+53OHU1Q4u/fVqXah0iIT5ucg19/qCKUenNZSltB/yeYtp10R9Pr1cknrTh rNpl/V8AMR8w5zBhicFEtj0FLAnVIqqZnMIeKKdA5KM5Iepp+MRdOzjjFB1n1b0Y vdK2YYj9GZ6aqnoCP+A2c5u12Mhq33h62QFo8fHK648SQwgCxY50yXGwDptjYlLV 2R2jzJMi8shuhDa/2dA4VXqDAs6jPc0Y0/FU7+iTzaL8d5prwSWmJJkvxLefL0a5 lzNef5mGdyitAXoAiESSFyLXG6dHmJlLO4qyQFb/kkJliFtCmqDkmVotFcUW52gX RbANVhSkvOKPFFcmZWePCllrneNp4bLtX5VaMxJipeCIJPWNEz5t8vewSLldpd3H ImbV452mQrdAFdPTVVk6EgYOegxl7EkaJrO/j0EJpkEdQEykSud3iwhW64nlDOf+ CFhelhlsiW3OkrWsgCQUHhzuYlJI9L7eD8GAJZ1fdwt6A1qBfKK4t3GazGurFc/f SoUgMbxut8yNuT8HL1dmNTneCQTQD+7N36rvUd6TpyTQFDUSfrJ/+4tDwgK9I7Q4 UhuZCCBSXMNibN7hnaojSTh9WDMgUCq3od9jq/NeCIWr/EBKn1Q= =umm4 -----END PGP SIGNATURE----- --Sig_/oYVZzCBl=UeB5opI/4G6Lcx-- From unknown Tue Sep 09 22:28:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Mar 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator