From unknown Wed Sep 10 01:58:33 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59962 <59962@debbugs.gnu.org> To: bug#59962 <59962@debbugs.gnu.org> Subject: Status: 29.0.60; vc commands fail in diff-mode Reply-To: bug#59962 <59962@debbugs.gnu.org> Date: Wed, 10 Sep 2025 08:58:33 +0000 retitle 59962 29.0.60; vc commands fail in diff-mode reassign 59962 emacs submitter 59962 Sven Joachim severity 59962 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 07:25:30 2022 Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 12:25:30 +0000 Received: from localhost ([127.0.0.1]:46378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4LOb-0001W0-Pe for submit@debbugs.gnu.org; Sun, 11 Dec 2022 07:25:30 -0500 Received: from lists.gnu.org ([209.51.188.17]:48590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4LOa-0001Vu-Ny for submit@debbugs.gnu.org; Sun, 11 Dec 2022 07:25:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4LOZ-0003b4-Vy for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 07:25:28 -0500 Received: from mout.gmx.net ([212.227.15.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4LOW-0005HR-Qn for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 07:25:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1670761514; bh=15G34OXB2oIGKpM+/QB/rAIi6BGH47yxIAk+fhNR1hE=; h=X-UI-Sender-Class:From:To:Subject:Date; b=hJH8cCN+O5tATGtR2THJuXRKUfMITP0cIsCCmPaANwqU6mZ6sfxQYaPVLFCY/iXwn 2BjEsu3OGMGCMvEnmPuRyEKrOrMgDwipmpS+UKzk5ZBKPlU6/K80KITXOIcSp87WWX rZhy9kYaf9U2LZZZB6QCAEhrUWp+BPbJGHKkz60bnfdIEtI313IWzH+1fbf+FfjVGU gKPl6vQpczLoEDkWwIwT3sOw8Al88ukYDi3lP+/1itOZYlx/fPpXfBGzqdkLmswYZN FK/voxFTMzypQ4bnBDWu587nvKLSPo2cbTxLLQWJQIGouen7RxZrepdHOEeeB3Q4qv e2hRQOeEdgSOw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.localdomain ([79.203.76.89]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MG9kM-1p9slK0ICC-00GdFf for ; Sun, 11 Dec 2022 13:25:14 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id 604878007C; Sun, 11 Dec 2022 13:25:11 +0100 (CET) From: Sven Joachim To: bug-gnu-emacs@gnu.org Subject: 29.0.60; vc commands fail in diff-mode X-Debbugs-Cc: Sven Joachim Date: Sun, 11 Dec 2022 13:25:11 +0100 Message-ID: <87pmcqktzs.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:tYUzle0jMlVmgysPac07sqSa5UV6LFUwD3VSfA8N0egOKvp5i1d 4wMZMp3aTch4hlaYiDWJ7aQHYK5rVdC7W+3eiE7+lS1oZYW6OlNxV67ptBm7OaZ3/X5/XiZ mYnrXSg6fzuj1QmjGVYMVPMAwNWrnSRMd9x+LOsiBv4+b7odFBR3zlDG6lFaMrEhgPSHVcP MPC7vaCMOdZUKclkdczlg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:zlEB/9C2Y3M=;61ffPiNGhhDNNaAHMdBfj9aAY2d q234gBCkS/Eszd7kkpkrlMwXLBF1GdzAHJJC8I5luKmeZeUzl4wkVsfGwbKwtmodY5KdxIT94 LLmwe5pwbvbDEAuBtPHOeKeslDL+EuEqT+eT5Y2imxtJZNaGbPFzVAg1iqqdKSjrt2fzF/8zX UhUsPpfjqgsLe/4jkzQiR1tMGZ5jJ88UzgWUkfVv4E8PJfRyvpkp+cId/O4rlTE5K8gaMR7he ZSG0P55x2VxQI0mrLZQ4K9ehjYlQ97ImpM38G1e3xg2ApU2VkIrtj5yB/CHpPnsH1lZMbe+V3 NC20XGhA/cZpr1jrzLfA0t4Fda/Y/SsdS3pce8Mhv4k5XSGWqNzysTTdmTnXWpcJmqE+FPp4p hilC1szQNuEmGolkx/StUUlnFL8gEM8jmtMeSPQ0ju56VgMO/7+aDZgPGNxZRLHreZM4bNNI6 aHeVSs7kDnHL+Hu5oXOTXN6WQ+QKw2+AKJbTL2CKdkKw3/De99yJR0bFpI/+d10wWcaSkhR0b jH5i0rNIKRFmWdGOs5nVBEPYw2zbsSC0AwCpt95DwCdp+YQCo2FE0XojTPlvZ1Q/IqpEAtzim RBZMdJco9PMRwGfhifM3dNhbeTwHXwKama9m8WFXG+tfiDLYNFsjp0xTaTh1Gq8fukv6eQ/hM uoBbnWUx3cSd8JfdCMSQ5OsofMrWme9uO41tsDevSDgtsykerbK90yKB+FVzx+dFrJnyLVbjb ra6utjfPzZZ4XG4XVR47YYN3xUrA9rEIVm10GuOhbZZf9hWrigxfTIl3xLEPCoGq77Cc/KrED C9OjAL1pRuwQ5pdiDyZA1Orx6c9CI+tL0vhaiCQJXD2rv+14mDw/A2vHyEXtp6/0IWN80ELYW +mMDvNsvCAK7+Djir3JIAfFcQ5v+hwVB1qm6/YRgOFZjTxvPGss6L1hRtWpgAhD5ToXud3USs AiEy6Q== Received-SPF: pass client-ip=212.227.15.19; envelope-from=svenjoac@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) As a distribution maintainer, I find myself working with version-controlled patches which Emacs visits in diff-mode. Unfortunately, there is a bad interaction between diff-mode and vc, which makes all vc commands fail. This is what I got on C-x v l: ,---- | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) | file-truename(nil) | find-buffer-visiting(nil) | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) | vc-diff(nil t) | funcall-interactively(vc-diff nil t) | call-interactively(vc-diff nil nil) | command-execute(vc-diff) `---- In GNU Emacs 29.0.60 (build 7, x86_64-pc-linux-gnu, GTK+ Version 2.24.33, cairo version 1.16.0) of 2022-12-11 built on turtle Repository revision: 9f7e5584a4ff3c61a90301f70366a829c2c0ac04 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure --build x86_64-linux-gnu --host x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var --infodir=/usr/share/info/emacs-snapshot --mandir=/usr/share/man --with-mailutils --enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/29.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/29.0.60/site-lisp:/usr/share/emacs/site-lisp --without-wide-int --without-modules --disable-silent-rules --without-compress-install --with-x=yes --with-x-toolkit=gtk2 --without-gconf --without-gsettings build_alias=x86_64-linux-gnu host_alias=x86_64-linux-gnu 'CFLAGS=-g -O2 -fdebug-prefix-map=/usr/local/src/emacs=. -fstack-protector-strong -Wformat -Werror=format-security' 'LDFLAGS=-Wl,-z,relro -Wl,--as-needed' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2 -DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -DGLIB_DISABLE_DEPRECATION_WARNINGS'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK2 ZLIB Important settings: value of $LC_COLLATE: C value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix Major mode: Debugger Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils display-line-numbers cl-extra help-fns radix-tree cl-print byte-opt gv bytecomp byte-compile debug backtrace help-mode find-func vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util vc cus-start cus-load smerge-mode diff vc-git vc-dispatcher diff-mode easy-mmode dired-aux cl-loaddefs cl-lib dired dired-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 73162 8220) (symbols 48 8827 0) (strings 32 25552 1356) (string-bytes 1 703829) (vectors 16 15405) (vector-slots 8 205042 14002) (floats 8 34 35) (intervals 56 755 0) (buffers 976 15)) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 11:47:03 2022 Received: (at 59962) by debbugs.gnu.org; 11 Dec 2022 16:47:04 +0000 Received: from localhost ([127.0.0.1]:47016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PTj-0006TR-Jw for submit@debbugs.gnu.org; Sun, 11 Dec 2022 11:47:03 -0500 Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]:39468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PTh-0006T4-BU for 59962@debbugs.gnu.org; Sun, 11 Dec 2022 11:47:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1670777213; bh=8/qHxjAbTVPURTelE2clcARmBP7MV0qASkT3RtyjvCE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=T5scJMSOOQXT09WGADSBhN263ai1Tdbw7L7sd9esNqGw1DQ0STtDlKxv4geWkSn6u35p/+DIBZCjpIkSsVhtO9TvtR7z1VnBCT6D8bXK4TBR6B+VPFGMDoe1moPJSwW6pJBFThIf54tn8OLZ47P61O20NVLfqaYpQJC1Mw+8oYtOjfujw9oXA7J60SMvbDSn6SnL5efOCfXql5e3EqLVvAkbgPl2J67h1isBB/D17IU94K7An7JgFIyKsuVxsKRFoM2wYZ0OCAu3Nu9z3sRSwrin2H38pwB7aOk07tDhDUZjAItyRpA3AFXoCoX1RbTq4p49rg6h8EqqVOCzgYstLw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1670777213; bh=yvaAVAsqTFZX9lRwWs/y0r07Kr64eskL8sL1+zCGF9j=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QkoR3BGy3lfvO2wWkoboPCdqsWiy4nkYcMZbm1oLglmzVTrgscK0qQdNIFbtBlsWBrpB8xA5OBjttecuMQu9LUI4GXnmG3KrD93Y433LrdkWPWjujm8es0qEGxBUv9djbxkfKH0/PuE21h0TKnGj+XrZa+M3XGfvGvOKgtj4FU+jn3tC2mALXNu86jMneM6mYz7JsSNyYWFq0OkXhvO5Skmfz1FKZKCXAJXZhC/l/poBZrD2z+t/kcvwMgr7Ym3hiBzT0zCNaSdmACA88E4V7cJJ5J1WQc7flF04g9XHjfC0+RBN3pRKyBlgO+U5U6576qXpgynvawvdTvKR5hWOWg== X-YMail-OSG: NwTTam8VM1nfnmi_S6o8RsVtfY3KiTghxmGsaiIygNyC2R8aT9FawQLg9oOZUjF bAnW3fzoaZjBhygzowzibMoSMOv79HS6kstuAGkV64bn5nX8PujohrH6r435Q.sY.zAuNjg9gEFs QBWvx61OIeTdBf3c85Ad9C621h_FLFoAl_u40_Rl.yVXDmjU6NtuFmOZQmtHQaDb9Z4bdM60H6J7 TK2bRED4iJ1CL5sJkCq0hJHOhVr2o06u68DyUgq2ZREGcLWDRA3LzJMC0btOjrs1zGlWLfPL4QGC VaXJxNJeF1fJS5PIz_aCcbGDd.KW0i3R63CVOnM2Lqjp5uh7TFFZs_UkrGyqjZeRwzO0rd0v6BZn HpgX6Akr1zy8A7Zw_MJ_Z4cxVmkScVO1FBhNtwvw4KfpFWHcO7wfq90HjR5dmdS4UKv3012z5icz P5GLtjydn_E_ZpUSatMiHLGns_I3MTNI1d4CU1MzmqLl7u7i_sLIKcdg0WFbQJ3rZtusEI.z7FkD CiLrfXwyLJnWnQBRb7OOmaHMswyqRwYo3tt8XcHPqsHYBpmTJnh2Vpk.ExpsAO9qiRecPu1owe6i KJI4HzY0rFE8mRgWYNn_hkcUy1FwAJnaysbarztJ44gJvn3d39M6EUx.NyZrnWBG0s4ioPzNor2Q pecFsXEucMJ_0J2jhE7RGLhqmvBKJY7H5vaZE7XkfvRiiLdSvKuQLW3E04kB01CYk1ZmP12ZKHwt Ew1lFIQJuGjM4abbQBorklZ8I66GigKbNBopWWe3c0mVfKgk2xVwpRG1XoYw4bZYNTWbHw1PmAn2 tK8SxqRZ5w5.7hI7pGXTOHbCeE5Ax1.BkUFEdZDgqkAm5qAUpQ3xACrmg55AygtBlToiHqzhEW7M j4IiPtdWLmC6M8jWFoorVciid7WSFjqyOAIQ237PBmdqgjdCQHnx3VkVXrZCmHvoFt2oojxOfWeS Q17xBb7vp_wsfl5_E_srMAA53.WovzWlW25al3rWo4P_9t5d__92wjsZ6g591Or4xnXSyGio8zLe zZmY.h1RJ6jf3.YfgapnnS3lsL92RdrX0RGIPqi02.A00JIKvFuvI08ysxjlfzhrb7ZHdqyfhaRW Lzsh1udOlV30MaQaXGS4pHQIRReQky3ql9g1gFk6vPvN.f5DHEEXAdzE_hunRkZ4sqZU8qlhdD4. kkTiDFDyjeGppIaKrSU2XJPlZhPgoymcF1ch.mRA8QgewUo1JeaESlMZqtQRy9U5iMzprrlebpaN GPislnuJimzjjgNYP93gR50KrNuPFOgiyoW7QZWkYprpbCQxO2VhUvt4UqJnkgBcM_ekpGjuSABx MUb2KehNNsqkGrkSllpwX2kob9NjP5uURuRICOidNG4WLNhEbcny0wvalO6IYq5AHdv2eGUWUyES S4yEerDNgGON0AFlWJrkBjVxhTGKPPo793sS90unkgxtaSxGd88X8QU9CGx286n0PTZTaLfMO6Wk _0a3q0iUtNfIvHtQVUky7DT0J7vkKiX6z2p56EsbDIjVm6kY7aGPbUeNo6GM2QMhWZL8m9BCayGh YMOpdyEJGAQC5fBVw8iccxSgag8ft_qxU2zszZTaLNvr2dPoJlPK7EtRnlsHxImYVEDFz5J_vvJd _KTfYKNkrfzIScy9OGFSxXtgQXbQQdzQA3D2zF8TqTxMVV3X.MWkQ8sUxzeHgBj6nn8ZZU8y89R8 BoqLL1QGRr5R_vxGghZ2IpwwoHjJ2XXQMlwwtH4TNax4vRXJyBzrjOiy4ab0ct.4vfGaCycNFRD3 waXSkFrw2VxgwFbFPW8aJ3eMvF7zmN4WK2UgJhTRs2yfQTjBMX1lpFegv4RENK6OwaL8ikADzWfJ IZVb.L25XEMvZzPrEIQbHkFWn8rKulEGe5UYaqe0ErXztX2kRgKz.NOqpaberG_eEezW6VMEPorP ZxtAcC52LKGFo_YREyug6hV3MCkX3dOI7T_eBEdluoYqYWS4P_qt6rAQJViFfy1U4ULAsXMQeztv M7hMZ97P8UkZaS8VrGCOpF9RL4wQtRCfVzN3QBwlPPIHnbI3kOsQvMX5m3.o853RfqWdBlq061Lw ck9z6w3.QwhnBm97IVWz.MlT80krjFUn8XZlVKxt0INYL6rlTC136O6CojVl_QocpD25jhc1E34T VOYkM9Vad4QoiV1V7TanagQD.Qpdb4aLUHQVxeUuDSsOOCsfZCe4HWfGbtYxFLDCVxq.z9YC10VZ xi0vTbIK_9fAQm.LeooNPPH3mOU.v7wL.rnkpzf2luL4bOg-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Sun, 11 Dec 2022 16:46:53 +0000 Received: by hermes--production-ir2-5795fc58c8-xpjmk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b1005f3e26cba58a8ae481f8b261508e; Sun, 11 Dec 2022 16:46:48 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Sven Joachim Subject: Re: bug#59962: 29.0.60; vc commands fail in diff-mode References: <87pmcqktzs.fsf@turtle.gmx.de> Date: Sun, 11 Dec 2022 17:46:47 +0100 In-Reply-To: <87pmcqktzs.fsf@turtle.gmx.de> (Sven Joachim's message of "Sun, 11 Dec 2022 13:25:11 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20926 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 855 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 59962 Cc: 59962@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Sven Joachim writes: > As a distribution maintainer, I find myself working with > version-controlled patches which Emacs visits in diff-mode. > Unfortunately, there is a bad interaction between diff-mode and vc, > which makes all vc commands fail. This is what I got on C-x v l: > > ,---- > | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > | file-truename(nil) > | find-buffer-visiting(nil) > | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) > | vc-diff(nil t) > | funcall-interactively(vc-diff nil t) > | call-interactively(vc-diff nil nil) > | command-execute(vc-diff) > `---- > Could you detail the steps to reproduce this issue (preferably from emacs -Q)? I've tried C-x v l on a few Git-version-controlled .patch files (in Diff mode) but I couldn't reproduce the error. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 12:18:54 2022 Received: (at 59962) by debbugs.gnu.org; 11 Dec 2022 17:18:54 +0000 Received: from localhost ([127.0.0.1]:47168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PyX-0006qH-VT for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:18:54 -0500 Received: from mout.gmx.net ([212.227.15.19]:58981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PyV-0006q9-Mz for 59962@debbugs.gnu.org; Sun, 11 Dec 2022 12:18:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1670779125; bh=gFcyLsJxPLhvd2F1vg63mVjp6VTJOugmcRQuodYW22o=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=aCtpEk1B066dJarpZe1XJVjCzERavAUYYOd806egzLiUCGFo9cv2UR7WGQQnT1IS3 +mcD4vgf4pfDykfM4VgaAtJ4fL81xnVqAvGGvGm+AbP/zEDqfISYBOVXt1auVd4lA7 EuyhHxrzMf8lKF7n+7D2kV+Kf46qydgCFK20TQ3wsHC7MxrQDK/mxacPWu9/hIf5LX 1In9NoBRcaqP9Uc/aAncwFbEPFmK081onTmA6F6IuuzdOe4VghC4l5g6fsmDsdUKRI KjHYuNWf674+MnIJ7xrRQG8wkADSMRqwu6O7Dc2v97lFdj1MLhrDk0vT3wdt8OdDVA mwnJz5/xJ0myg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.localdomain ([79.203.76.89]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N4QsO-1ouDND01SQ-011QWs; Sun, 11 Dec 2022 18:18:45 +0100 Received: by localhost.localdomain (Postfix, from userid 1000) id 39BCC8007C; Sun, 11 Dec 2022 18:18:44 +0100 (CET) From: Sven Joachim To: Daniel =?iso-8859-1?Q?Mart=EDn?= Subject: Re: bug#59962: 29.0.60; vc commands fail in diff-mode In-Reply-To: ("Daniel =?iso-8859-1?Q?Mart=EDn=22?= =?iso-8859-1?Q?'s?= message of "Sun, 11 Dec 2022 17:46:47 +0100") References: <87pmcqktzs.fsf@turtle.gmx.de> Date: Sun, 11 Dec 2022 18:18:44 +0100 Message-ID: <87bko9505n.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:GcSwOkGcNqbkWQI8iFr0DWGVNDt/twDUnx5WwlTUqTDrUausm5v +BxW5ZOLcRvLXc+lwUZztdxe22vtCDoAHjBydH+MRWk54UnbLEXUjyPKHnMp+PA61Zx5nX4 X6nRMYHNsnTfwmtz9svZKNzVlQV9jSjl99Hl6/Dchx67lwoiiyxQ4mhbfiEg8H4eRq84P/X OrE83MOIhHw1YhzsxDvFw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0NszzezGFJQ=;EnAEKJuPL4xKfUYgDgiGB8rNflt wo4iV3iDyh9Z5aoYJ1UMHe5Cxu0spdw5gikV3J7oT+/YDSTcF1dSUDJCu+mefQbF/MXO9mB7N Bj7JgL2RBLJOB1s6FXUAYpXTkCQWvuWBSrTGwlmgC26DCpp2pVeI4YNtO+WBHmpIpi0ZRAxIi RPZGoCZ1B4BuYLmk+7j/XUzjWz6/PE4lIAvrSwwu+FN9fZRdSJBdokBWixjoIVvPRvTst3XBV St2DAUJXq5LpmwOX1SsWQaNDXh0GDDOzUB/cAPVdKiJ1LYSKhHVbBrx5sDqY0q5yn+2nx3UcG kupNlYRb65vSd1bwnzFHbWWFYntoYg5dMr+HgWXZXvHMxgnpDh94UbR+BBBZ9gAsi7sWnjkJx IageF7P/lC0FdOFcdxWVDwmpfX/uFeQyGKp9JaJ0kA922v9KhoqV4+mG03m2G+Z2naCpfNuyn xrIxzzdFs5FRqcNq7qMbSkfPpNsXX/IXlH/RENcTAbdQjS0GI8leoptu/ZjxW0QQ9YxEccrmy 2NZEvQdlIlNiv1hLeBUhf3ldjJjL9oAetKlFwrpCz2Shkt3C56eM/3keXaFNMwYlPEdJpkwge ucrJ2+0m6ePTjJQkLh6Z5LnjVytd+gz3a2WK9SlYUnvOTQceqMgXeca2YaHGmcN1xq4dHhuJW U80Iiz58OIontywb0CUTBWcyO986XpwG1L5L8VhvkkyyquO3XjyukQqpIm2G02Ex3NNZFVeQo EtayUAvWdzNX0LHKgmFv/EoibqragJM5w1jr/JgQogyGd58U7E1RG868s4w0BSkih8vuXRJMp 7smKWbQYAXJdSoQPBUyjTT/kZs3K0hKHrByKtxmZccARmp/Kky0/gXRV5RHpH/fONnJLHO8rH G9cgiEIfx1YUA63cwCrAvJsK0nA4J7QXw2MuCUvRXII5Bs6/vKG8eyWjJdtckFtZcsaee5FIe ID+0gtcvazR57+MuMqYlGFyRFzM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59962 Cc: 59962@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 2022-12-11 17:46 +0100, Daniel Mart=EDn wrote: > Sven Joachim writes: > >> As a distribution maintainer, I find myself working with >> version-controlled patches which Emacs visits in diff-mode. >> Unfortunately, there is a bad interaction between diff-mode and vc, >> which makes all vc commands fail. This is what I got on C-x v l: >> >> ,---- >> | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) >> | file-truename(nil) >> | find-buffer-visiting(nil) >> | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) >> | vc-diff(nil t) >> | funcall-interactively(vc-diff nil t) >> | call-interactively(vc-diff nil nil) >> | command-execute(vc-diff) >> `---- >> > > Could you detail the steps to reproduce this issue (preferably from > emacs -Q)? I've tried C-x v l on a few Git-version-controlled .patch > files (in Diff mode) but I couldn't reproduce the error. Thanks. $ git clone https://salsa.debian.org/xorg-team/app/xterm.git Then visit any of the xterm/debian/patches/*.diff files and type C-x v l. Cheers, Sven From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 12:25:23 2022 Received: (at 59962) by debbugs.gnu.org; 11 Dec 2022 17:25:23 +0000 Received: from localhost ([127.0.0.1]:47195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q4o-0006vt-Rk for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:25:23 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:39213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q4m-0006vh-NY; Sun, 11 Dec 2022 12:25:21 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 30D1D20007; Sun, 11 Dec 2022 17:25:11 +0000 (UTC) From: Juri Linkov To: Sven Joachim Subject: Re: bug#59962: 29.0.60; vc commands fail in diff-mode In-Reply-To: <87pmcqktzs.fsf@turtle.gmx.de> (Sven Joachim's message of "Sun, 11 Dec 2022 13:25:11 +0100") Organization: LINKOV.NET References: <87pmcqktzs.fsf@turtle.gmx.de> Date: Sun, 11 Dec 2022 19:24:54 +0200 Message-ID: <86359ln995.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59962 Cc: 59962@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 59962 29.0.60 thanks > As a distribution maintainer, I find myself working with > version-controlled patches which Emacs visits in diff-mode. > Unfortunately, there is a bad interaction between diff-mode and vc, > which makes all vc commands fail. This is what I got on C-x v l: > > ,---- > | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > | file-truename(nil) > | find-buffer-visiting(nil) > | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) > | vc-diff(nil t) > | funcall-interactively(vc-diff nil t) > | call-interactively(vc-diff nil nil) > | command-execute(vc-diff) > `---- Thanks for the bug report. It's fixed now on the emacs-29 branch. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 11 12:30:16 2022 Received: (at 59962) by debbugs.gnu.org; 11 Dec 2022 17:30:16 +0000 Received: from localhost ([127.0.0.1]:47224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q9X-0007gz-SO for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:30:16 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:56251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Q9W-0007GX-Uv for 59962@debbugs.gnu.org; Sun, 11 Dec 2022 12:30:15 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C47BD100008; Sun, 11 Dec 2022 17:30:06 +0000 (UTC) From: Juri Linkov To: Daniel =?iso-8859-1?Q?Mart=EDn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#59962: 29.0.60; vc commands fail in diff-mode In-Reply-To: ("Daniel =?iso-8859-1?Q?Mart=EDn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Sun, 11 Dec 2022 17:46:47 +0100") Organization: LINKOV.NET References: <87pmcqktzs.fsf@turtle.gmx.de> Date: Sun, 11 Dec 2022 19:28:06 +0200 Message-ID: <86mt7tlujd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59962 Cc: 59962@debbugs.gnu.org, Sven Joachim , Daniel =?iso-8859-1?Q?Mart=EDn?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> As a distribution maintainer, I find myself working with >> version-controlled patches which Emacs visits in diff-mode. >> Unfortunately, there is a bad interaction between diff-mode and vc, >> which makes all vc commands fail. This is what I got on C-x v l: >> >> ,---- >> | Debugger entered--Lisp error: (wrong-type-argument arrayp nil) >> | file-truename(nil) >> | find-buffer-visiting(nil) >> | vc-buffer-sync-fileset((Git (nil nil nil nil) nil nil patch) t) >> | vc-diff(nil t) >> | funcall-interactively(vc-diff nil t) >> | call-interactively(vc-diff nil nil) >> | command-execute(vc-diff) >> `---- > > Could you detail the steps to reproduce this issue (preferably from > emacs -Q)? I've tried C-x v l on a few Git-version-controlled .patch > files (in Diff mode) but I couldn't reproduce the error. Thanks. The new feature of using 'C-x v v' on a diff buffer to commit it as a patch should not be used when the diff buffer is vc-controlled. This also means that 'C-x v v' on a file that even is not yet vc-controlled, after the recent fix will register the file in vcs, instead of committing it as a patch. 'C-x v v' for committing the patch will be supported only on non-file buffers. From unknown Wed Sep 10 01:58:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Jan 2023 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator