From unknown Sat Jun 21 10:10:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5996 <5996@debbugs.gnu.org> To: bug#5996 <5996@debbugs.gnu.org> Subject: Status: [PATCH] base64: always treat input in binary mode Reply-To: bug#5996 <5996@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:10:06 +0000 retitle 5996 [PATCH] base64: always treat input in binary mode reassign 5996 coreutils submitter 5996 Eric Blake severity 5996 normal tag 5996 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 21 10:23:30 2010 Received: (at submit) by debbugs.gnu.org; 21 Apr 2010 14:23:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4apu-0002lh-7o for submit@debbugs.gnu.org; Wed, 21 Apr 2010 10:23:30 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4apr-0002lc-PL for submit@debbugs.gnu.org; Wed, 21 Apr 2010 10:23:28 -0400 Received: from lists.gnu.org ([199.232.76.165]:41519) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O4apm-0006Ys-Ij for submit@debbugs.gnu.org; Wed, 21 Apr 2010 10:23:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O4apm-0000Jr-3x for bug-coreutils@gnu.org; Wed, 21 Apr 2010 10:23:22 -0400 Received: from [140.186.70.92] (port=35382 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O4apk-0000Jc-Ei for bug-coreutils@gnu.org; Wed, 21 Apr 2010 10:23:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O4apg-0005SR-Du for bug-coreutils@gnu.org; Wed, 21 Apr 2010 10:23:20 -0400 Received: from qmta02.westchester.pa.mail.comcast.net ([76.96.62.24]:38848) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4apf-0005SD-JH for bug-coreutils@gnu.org; Wed, 21 Apr 2010 10:23:16 -0400 Received: from omta21.westchester.pa.mail.comcast.net ([76.96.62.72]) by qmta02.westchester.pa.mail.comcast.net with comcast id 8AK61e0021ZXKqc52EPGDq; Wed, 21 Apr 2010 14:23:16 +0000 Received: from localhost.localdomain ([98.202.176.54]) by omta21.westchester.pa.mail.comcast.net with comcast id 8ETc1e0011Anwcq3hETg4H; Wed, 21 Apr 2010 14:27:41 +0000 From: Eric Blake To: bug-coreutils@gnu.org Subject: [PATCH] base64: always treat input in binary mode Date: Wed, 21 Apr 2010 08:23:00 -0600 Message-Id: <1271859780-14172-1-git-send-email-eblake@redhat.com> X-Mailer: git-send-email 1.6.6.1 In-Reply-To: <4BCEC96F.70004@jade.plala.or.jp> References: <4BCEC96F.70004@jade.plala.or.jp> To: 5994@debbugs.gnu.org X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit Cc: yasai-itame1942@jade.plala.or.jp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.6 (-----) Necessary for cygwin. Technically, this patch is not correct, in that it clobbers O_APPEND, but it is no different than any other use of xfreopen to force binary mode, so all such uses should be fixed at once in a later patch. * src/base64.c (main): Open input in binary mode. * THANKS: Update. Reported by Yutaka Amanai. --- > base64 doesn't call freopen() nor setmode() against stdin, and doesn't > give "rb" flag to fopen(). So, base64 sometimes fails to encode data > correctly on some environment. For example, zsh on Cygwin forces stdin > to be text-mode. Thanks for the report. I'll commit this later today if there are no objections; it should have no impact for any platform that does not have O_BINARY, and although it is not perfect on Cygwin, it is not too much to add to my workload for creating the cygwin port of coreutils 8.5. And someday I'll get around to creating the new gnulib interface for gracefully enforcing binary streams without clobbering O_APPEND. src/base64.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/base64.c b/src/base64.c index 34569ec..41e9dea 100644 --- a/src/base64.c +++ b/src/base64.c @@ -29,6 +29,7 @@ #include "xstrtol.h" #include "quote.h" #include "quotearg.h" +#include "xfreopen.h" #include "base64.h" @@ -289,10 +290,14 @@ main (int argc, char **argv) infile = "-"; if (STREQ (infile, "-")) - input_fh = stdin; + { + if (O_BINARY) + xfreopen (NULL, "rb", stdin); + input_fh = stdin; + } else { - input_fh = fopen (infile, "r"); + input_fh = fopen (infile, "rb"); if (input_fh == NULL) error (EXIT_FAILURE, errno, "%s", infile); } -- 1.6.6.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 01:59:54 2010 Received: (at control) by debbugs.gnu.org; 22 Apr 2010 05:59:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4pS6-000311-8k for submit@debbugs.gnu.org; Thu, 22 Apr 2010 01:59:54 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4pS4-00030v-PK for control@debbugs.gnu.org; Thu, 22 Apr 2010 01:59:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1O4pS0-0003BR-NN; Thu, 22 Apr 2010 01:59:48 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19407.58836.582672.710952@fencepost.gnu.org> Date: Thu, 22 Apr 2010 01:59:48 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: blue X-Ran: RbV2KoB>vtD'rO-*g4Ur+FkKqQP(MFZ;;`sq9K{h9%r-az"_d-tW74y!8{1K[1]x1z&6VN X-Debbugs-No-Ack: yes X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) reassign 5996 coreutils merge 5994 5996 retitle 5997 vhdl-comment-uncomment-region severity 5986 minor From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:00:33 2010 Received: (at 5996) by debbugs.gnu.org; 22 Apr 2010 17:00:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4zlR-0000eh-Dl for submit@debbugs.gnu.org; Thu, 22 Apr 2010 13:00:33 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4zlP-0000ec-PS for 5996@debbugs.gnu.org; Thu, 22 Apr 2010 13:00:32 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1O4zlK-0008Jn-QS; Thu, 22 Apr 2010 13:00:26 -0400 To: Eric Blake Subject: Re: bug#5996: [PATCH] base64: always treat input in binary mode References: <4BCEC96F.70004@jade.plala.or.jp> <1271859780-14172-1-git-send-email-eblake@redhat.com> From: Glenn Morris X-Spook: halcon JSOFC3IP terrorist espionage STARLAN Croatian X-Ran: paa+Y'IPego;pp0=@>jdXE|*mw*@myt|67cFg?`H:-U?]@QgYhz[yHC*1"b)Zsgs[`j:6@ X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 22 Apr 2010 13:00:26 -0400 In-Reply-To: <1271859780-14172-1-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed\, 21 Apr 2010 08\:23\:00 -0600") Message-ID: <8qmxwvpglx.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 5996 Cc: 5996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi, The following message got resent to bug-gnu-emacs rather than bug-coreutils, because debbugs got confused. We can discuss the reasons on help-debbugs if anyone is interested. (Short answer: it looks like the mail you sent had two separate To: headers, and a changed Subject: header with no bug number, both of which confused debbugs. It may be possible to improve this a bit.) Eric Blake wrote: > Necessary for cygwin. Technically, this patch is not correct, > in that it clobbers O_APPEND, but it is no different than any > other use of xfreopen to force binary mode, so all such uses > should be fixed at once in a later patch. > > * src/base64.c (main): Open input in binary mode. > * THANKS: Update. > Reported by Yutaka Amanai. > --- > >> base64 doesn't call freopen() nor setmode() against stdin, and doesn't >> give "rb" flag to fopen(). So, base64 sometimes fails to encode data >> correctly on some environment. For example, zsh on Cygwin forces stdin >> to be text-mode. > > Thanks for the report. I'll commit this later today if there are no > objections; it should have no impact for any platform that does not > have O_BINARY, and although it is not perfect on Cygwin, it is not > too much to add to my workload for creating the cygwin port of coreutils > 8.5. And someday I'll get around to creating the new gnulib interface > for gracefully enforcing binary streams without clobbering O_APPEND. > > src/base64.c | 9 +++++++-- > 1 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/base64.c b/src/base64.c > index 34569ec..41e9dea 100644 > --- a/src/base64.c > +++ b/src/base64.c > @@ -29,6 +29,7 @@ > #include "xstrtol.h" > #include "quote.h" > #include "quotearg.h" > +#include "xfreopen.h" > > #include "base64.h" > > @@ -289,10 +290,14 @@ main (int argc, char **argv) > infile = "-"; > > if (STREQ (infile, "-")) > - input_fh = stdin; > + { > + if (O_BINARY) > + xfreopen (NULL, "rb", stdin); > + input_fh = stdin; > + } > else > { > - input_fh = fopen (infile, "r"); > + input_fh = fopen (infile, "rb"); > if (input_fh == NULL) > error (EXIT_FAILURE, errno, "%s", infile); > } > -- > 1.6.6.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:12:58 2010 Received: (at 5996) by debbugs.gnu.org; 22 Apr 2010 17:12:58 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4zxR-0000kI-TD for submit@debbugs.gnu.org; Thu, 22 Apr 2010 13:12:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4zxP-0000kC-Qq for 5996@debbugs.gnu.org; Thu, 22 Apr 2010 13:12:57 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3MHCo8m028555 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <5996@debbugs.gnu.org>; Thu, 22 Apr 2010 13:12:50 -0400 Received: from [10.3.252.186] (vpn-252-186.phx2.redhat.com [10.3.252.186]) by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3MHCnND015004 for <5996@debbugs.gnu.org>; Thu, 22 Apr 2010 13:12:50 -0400 Message-ID: <4BD08394.6020805@redhat.com> Date: Thu, 22 Apr 2010 11:12:52 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 MIME-Version: 1.0 Subject: Re: bug#5996: [PATCH] base64: always treat input in binary mode References: <4BCEC96F.70004@jade.plala.or.jp> <1271859780-14172-1-git-send-email-eblake@redhat.com> <8qmxwvpglx.fsf@fencepost.gnu.org> In-Reply-To: <8qmxwvpglx.fsf@fencepost.gnu.org> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig37A2EDFD986CCDD2F3A62E28" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.18 X-Spam-Score: -9.6 (---------) X-Debbugs-Envelope-To: 5996 Cc: 5996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -9.6 (---------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig37A2EDFD986CCDD2F3A62E28 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/22/2010 11:00 AM, Glenn Morris wrote: >=20 > Hi, >=20 > The following message got resent to bug-gnu-emacs rather than > bug-coreutils, because debbugs got confused. Well, my screw-up with To: fields means that my planned review period was delayed... >> Thanks for the report. I'll commit this later today if there are no >> objections; it should have no impact for any platform that does not >> have O_BINARY, and although it is not perfect on Cygwin, it is not >> too much to add to my workload for creating the cygwin port of coreuti= ls >> 8.5. And someday I'll get around to creating the new gnulib interface= >> for gracefully enforcing binary streams without clobbering O_APPEND. But I'd still like to commit this in time for coreutils 8.5 later today if there are no complaints. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enig37A2EDFD986CCDD2F3A62E28 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJL0IOUAAoJEKeha0olJ0NqDlEH/iMkT3Ky3IIu+L91cAVFOYCJ 6RawoTULYC2DZSqPAzbwH40te4En2osD+W9t6qbNAx2EOMwtrTkwuggm6FZzy4vs dNFLwA9I8WWep2LmUf4TPJlVdbol+Z33Qnh3CKU/sLdKAewuwRdm1fKN8eChwxc2 A13KMn3BXTCIIKU8jwaFw05g3oKLFkQRyDuEbu+gYvtM7i8hQ6V5WCu5jdLna14d C0/Pub1VJLtBAM8dkrbTfHEfdCbiTwy21jSK2ofncyHAaaDQGvOUYOWSr9wwl93I 0aj10M2kBDJJ1EQOJKMXuN5Y9ySqsnCL1sHfuqfci9AW+ctLgPW0fBNDxrqGBG8= =uQgJ -----END PGP SIGNATURE----- --------------enig37A2EDFD986CCDD2F3A62E28-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 13:52:29 2010 Received: (at 5996-done) by debbugs.gnu.org; 22 Apr 2010 17:52:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O50Zh-00011a-1n for submit@debbugs.gnu.org; Thu, 22 Apr 2010 13:52:29 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O50Zd-00011V-MV for 5996-done@debbugs.gnu.org; Thu, 22 Apr 2010 13:52:27 -0400 Received: from smtp1-g21.free.fr (localhost [127.0.0.1]) by smtp1-g21.free.fr (Postfix) with ESMTP id 2F095940005 for <5996-done@debbugs.gnu.org>; Thu, 22 Apr 2010 19:52:17 +0200 (CEST) Received: from mx.meyering.net (mx.meyering.net [82.230.74.64]) by smtp1-g21.free.fr (Postfix) with ESMTP id 1B849940111 for <5996-done@debbugs.gnu.org>; Thu, 22 Apr 2010 19:52:15 +0200 (CEST) Received: by rho.meyering.net (Acme Bit-Twister, from userid 1000) id B4C24E8F2; Thu, 22 Apr 2010 19:52:14 +0200 (CEST) From: Jim Meyering To: Eric Blake Subject: Re: bug#5996: [PATCH] base64: always treat input in binary mode In-Reply-To: <4BD08394.6020805@redhat.com> (Eric Blake's message of "Thu, 22 Apr 2010 11:12:52 -0600") References: <4BCEC96F.70004@jade.plala.or.jp> <1271859780-14172-1-git-send-email-eblake@redhat.com> <8qmxwvpglx.fsf@fencepost.gnu.org> <4BD08394.6020805@redhat.com> Date: Thu, 22 Apr 2010 19:52:14 +0200 Message-ID: <87iq7j5q9d.fsf@meyering.net> Lines: 23 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 5996-done Cc: 5996-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) Eric Blake wrote: > On 04/22/2010 11:00 AM, Glenn Morris wrote: >> >> Hi, >> >> The following message got resent to bug-gnu-emacs rather than >> bug-coreutils, because debbugs got confused. > > Well, my screw-up with To: fields means that my planned review period > was delayed... > >>> Thanks for the report. I'll commit this later today if there are no >>> objections; it should have no impact for any platform that does not >>> have O_BINARY, and although it is not perfect on Cygwin, it is not >>> too much to add to my workload for creating the cygwin port of coreutils >>> 8.5. And someday I'll get around to creating the new gnulib interface >>> for gracefully enforcing binary streams without clobbering O_APPEND. > > But I'd still like to commit this in time for coreutils 8.5 later today > if there are no complaints. That patch looks fine. You're welcome to push it. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 22 14:04:13 2010 Received: (at 5996-done) by debbugs.gnu.org; 22 Apr 2010 18:04:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O50l3-00016c-7v for submit@debbugs.gnu.org; Thu, 22 Apr 2010 14:04:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O50l0-00016X-7n for 5996-done@debbugs.gnu.org; Thu, 22 Apr 2010 14:04:11 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o3MI45tO025217 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 22 Apr 2010 14:04:05 -0400 Received: from [10.3.252.186] (vpn-252-186.phx2.redhat.com [10.3.252.186]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o3MI446X030004; Thu, 22 Apr 2010 14:04:04 -0400 Message-ID: <4BD08F97.8010109@redhat.com> Date: Thu, 22 Apr 2010 12:04:07 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100330 Fedora/3.0.4-1.fc12 Lightning/1.0b1 Thunderbird/3.0.4 MIME-Version: 1.0 To: Jim Meyering Subject: Re: bug#5996: [PATCH] base64: always treat input in binary mode References: <4BCEC96F.70004@jade.plala.or.jp> <1271859780-14172-1-git-send-email-eblake@redhat.com> <8qmxwvpglx.fsf@fencepost.gnu.org> <4BD08394.6020805@redhat.com> <87iq7j5q9d.fsf@meyering.net> In-Reply-To: <87iq7j5q9d.fsf@meyering.net> X-Enigmail-Version: 1.0.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCF70E78E35EECBB113C52118" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-Spam-Score: -10.2 (----------) X-Debbugs-Envelope-To: 5996-done Cc: 5996-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -10.2 (----------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCF70E78E35EECBB113C52118 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04/22/2010 11:52 AM, Jim Meyering wrote: >> But I'd still like to commit this in time for coreutils 8.5 later toda= y >> if there are no complaints. >=20 > That patch looks fine. > You're welcome to push it. Thanks! Committed. --=20 Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org --------------enigCF70E78E35EECBB113C52118 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJL0I+XAAoJEKeha0olJ0NqXlYIAK4Zx8lHF4uWdv6uY/d+V5nQ Gukf1feF7PlSKw8QBFRJsaIBMN0kCJtZJDU+tsp3gXQ8SJYhhKfnc2lUIAxa5Y5g BsEHrlObxCWSAw5s7a31nynd5ns6OVvRIJhCcm+IcxqffgiPSZ1yG7rhPPwWiUWt RjjgWyRO8WdK6sd0fLdp4IroW1o7UCoU05UCqSPlHEjEMiBP9XDzRrAEWMEld9kQ em8eFpf7ssJZkDlxTkqfAfG2vkcerCZSOW1yOMKPRUAzFzo8zA1kw6vNvFz3HFlf SJuUcV4cXtjLHtNQd1t1gnkp396d2oaJAmAejlCBWVXM3Ny2xkR3lcdazJhaKIk= =hv0Z -----END PGP SIGNATURE----- --------------enigCF70E78E35EECBB113C52118-- From unknown Sat Jun 21 10:10:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 May 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator