GNU bug report logs - #59945
[PATCH] Fix empty pairs in js tree-sitter imenu alist

Previous Next

Full log

Message #55 received at 59945 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 59945 <at> debbugs.gnu.org, cpbotha <at> vxlabs.com, Eli Zaretskii <eliz <at> gnu.org>,
 59945-done <at> debbugs.gnu.org
Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist
Date: Thu, 22 Dec 2022 00:10:03 -0800

> On Dec 21, 2022, at 9:25 AM, Robert Pluim <rpluim <at> gmail.com> wrote:
> 
>>>>>> On Tue, 20 Dec 2022 20:48:58 -0800, Yuan Fu <casouri <at> gmail.com> said:
> 
>    Yuan> "Charl P. Botha" <cpbotha <at> vxlabs.com> writes:
> 
>>> On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote:
>>>>>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" <cpbotha <at> vxlabs.com> said:
>    Charl> I followed the instructions at
>    Charl> 
>>>> https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.html
>    Charl> which said to use "git format-patch master" and include 
>>>> either inline
>    Charl> (which I did) or as a mime attachment.
>>>> 
>>>> Not quite. You sent the result of 'git format-patch master' as an
>>>> email, not inline in an email (presumably with 'git send-email'). That
>>>> shouldnʼt matter, because 'git apply' should work in either case, but
>>>> attachments are sometimes easier to work with.
>>> 
>>> Thank you for the correction, Robert! I thought that sending the
>>> output of `git format-patch master` as a plain-text email was what was
>>> meant by "inline". I'm sorry about this, I'll stick to attachments in
>>> the future.
> 
>    Yuan> Not really about attachment vs inline. The first patch doesn’t have
>    Yuan> author, commit message, etc. I’m fine with either attachment or inline
>    Yuan> :-)
> 
> It did, itʼs just that the Author was the From of the email itself,
> and the commit message was everything before '---' :-)
> 
> Itʼs the style used on linux-kernel and related lists.

Ahhhh, TIL.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.