From unknown Sun Jun 22 03:51:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59945 <59945@debbugs.gnu.org> To: bug#59945 <59945@debbugs.gnu.org> Subject: Status: [PATCH] Fix empty pairs in js tree-sitter imenu alist Reply-To: bug#59945 <59945@debbugs.gnu.org> Date: Sun, 22 Jun 2025 10:51:21 +0000 retitle 59945 [PATCH] Fix empty pairs in js tree-sitter imenu alist reassign 59945 emacs submitter 59945 "Charl P. Botha" severity 59945 normal tag 59945 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 12:45:53 2022 Received: (at submit) by debbugs.gnu.org; 10 Dec 2022 17:45:53 +0000 Received: from localhost ([127.0.0.1]:44153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p43v6-0001TW-P9 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 12:45:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:44402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p43UM-00019c-5Y for submit@debbugs.gnu.org; Sat, 10 Dec 2022 12:18:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p43UH-0003B0-5c for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 12:18:10 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p43UD-0002PX-Gc for bug-gnu-emacs@gnu.org; Sat, 10 Dec 2022 12:18:07 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6E3455C00C3 for ; Sat, 10 Dec 2022 12:18:02 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Sat, 10 Dec 2022 12:18:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1670692682; x=1670779082; bh=TzZLeRGxIUTNkg9eexsZiOxs+RaBojjyYnv MEEoLNHg=; b=R5dTD/yC7fBa2Ttl7G9c617GYGlO79nXPxJG7Jnu6vNHwKFj120 jAGO1mcSau9rYuq7NBsHYhGd5IiOM0aLt6y1tBDhGyABcG1ftUiR5eBQX8Ag0DZg IHL/NbQ2LU1aB+svwo9ea92s8jdQfOl46ajU81NXk9JY8WddTX6+Mj8pNnCQxj8I iNva5zsFbOCt8L4x5IO+poEQCXCC/anbm0d492hHHDD8luWMvf457BqTCQLmXGPE nRpNkE89HxOYy66LANTaSTcv9T+NUYV/gLWI74YqyyrJ+JxHwY305OdBaTzNvhV3 J8YPzUvYmnjZe2qnb/o3fos4mO51p3FqxNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670692682; x= 1670779082; bh=TzZLeRGxIUTNkg9eexsZiOxs+RaBojjyYnvMEEoLNHg=; b=M WGFO802S+FQXfIOJIsDn2ebD9XYqAiL+wCqq15Nic8EtUMONusvhYal4J78a1Uku v0DvtGCDmqNUiF+vdZLAwE8x3FeJagAHO2f5xllKTrS7xsaSRVYD+n3N3bE63QeS U2EBankUHiXsuVsXiITACjBZwl3Smq8RDNdXDkJfLZvWZjGt2qFjDiiZomQHDqF5 i1I1K8FyHVSvqfQ5CFf3yZNMj9+SGeX1A3DykfPcYjURhk0XmVdI30rLroCpd/qO 1JydTV9T/HzycucS9YS209L/tw7Fi/S1pw4zE1Su/IFldMEXYHbVGMIVjO3DnjWc bHPMLYsCRCgrFLtA9S4dA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeggdelkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhvffutgesthdtredtre ertdenucfhrhhomhepfdevhhgrrhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrges vhiglhgrsghsrdgtohhmqeenucggtffrrghtthgvrhhnpefhgfejheekfefgleegtdetle egvdehhfdvkeefhfegjedvjedtfeduudeiudegkeenucffohhmrghinhepghhithhhuhgs rdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eptghpsghothhhrgesvhiglhgrsghsrdgtohhm X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 06B3F36A0073; Sat, 10 Dec 2022 12:18:01 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: <43c6e6ed-3ddc-4ae0-a150-f86e852bd83b@app.fastmail.com> Date: Sat, 10 Dec 2022 19:17:41 +0200 From: "Charl P. Botha" To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.27; envelope-from=cpbotha@vxlabs.com; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 10 Dec 2022 12:45:51 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The current js--treesit-imenu, used by the JavaScript, TypeScript and TSX tree-sitter modes, would return empty pairs in the imenu alist if there were none of that type of symbol. This would break both the built in imenu and also packages like consult-imenu. See https://github.com/minad/consult/issues/697 for the discussion there. --- lisp/progmodes/js.el | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index 45dfef372cd..6ca260ad8ad 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3732,10 +3732,17 @@ js--treesit-imenu (func-tree (treesit-induce-sparse-tree node "function_declaration" nil 1000)) (var-tree (treesit-induce-sparse-tree - node "lexical_declaration" nil 1000))) - `(("Class" . ,(js--treesit-imenu-1 class-tree)) - ("Variable" . ,(js--treesit-imenu-1 var-tree)) - ("Function" . ,(js--treesit-imenu-1 func-tree))))) + node "lexical_declaration" nil 1000)) + (imenu-alist nil)) + ;; when a sub-tree is empty, we should not return that pair at all + ;; https://github.com/minad/consult/issues/697#issuecomment-1345302734 + (when func-tree + (setq imenu-alist (cons `("Function" . ,(js--treesit-imenu-1 func-tree)) imenu-alist))) + (when var-tree + (setq imenu-alist (cons `("Variable" . ,(js--treesit-imenu-1 var-tree)) imenu-alist))) + (when class-tree + (setq imenu-alist (cons `("Class" . ,(js--treesit-imenu-1 class-tree)) imenu-alist))) + imenu-alist)) ;;; Main Function -- 2.25.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:28:30 2022 Received: (at 59945) by debbugs.gnu.org; 12 Dec 2022 22:28:30 +0000 Received: from localhost ([127.0.0.1]:55818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rHi-00052g-Ao for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:28:30 -0500 Received: from mail-pg1-f178.google.com ([209.85.215.178]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rHf-00052Y-On for 59945@debbugs.gnu.org; Mon, 12 Dec 2022 17:28:28 -0500 Received: by mail-pg1-f178.google.com with SMTP id e126so3064925pgc.6 for <59945@debbugs.gnu.org>; Mon, 12 Dec 2022 14:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=rYSpzlq4+xzHyV/iks3opZ5FYy51tiuRowVAHOzGI5c=; b=kofGQwPIDVnBfVBiNKbmkw+XO2n/1PJ1m43GcbXji7Pr5bngcSjAzm7HWqdjEyeo9H La7dGMh16e5HsqZGQSjBmexM2JBuNNs+ooGYsnv2+0evnqI+P0g0zcNaxjkXjfivknpP ZGQn4/QUdzFgBMFj4dHxvE9vF3Ri6zTnUdiB/yti2VFR3qPTCYgtsNLVzcCsDXneAepS 9bZ5NSaIqzs/gabLuEenYgYhn6hxCdwVdWfbfaup1JfmNOXP6Q5Yce01zvXiHGStYWc1 3qRRRMPjS9UWJy2SryXwlzevaqhbgHS7osGRhNunTxm06zr2xYkKE5l/bDDnGkqGSxHc vK3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rYSpzlq4+xzHyV/iks3opZ5FYy51tiuRowVAHOzGI5c=; b=31KfbOd6U2MqXuOeAhqIwdA/yNPos4QfzJRZguZ4EJZWCS2Csyt8aObxwP5MYnFsql 9hiLOXN4oDcWMDnPwBvHRseoGbwzvV1zgzUcTM94EhOvsEC7UiXzbFFs97btgJYEJmdP jxaq2CxbtV5k2xwuRFRviXEw8908jqnhDGx47gn4v+cGL28oOSRs6oXXkVh55tZY/f7s 4lbL0R3Cr+mk7xgeTkWxNxLiY1Srg1wRT2pPX+jqIfGvegJ7VddkmDDpkTzZS3YtE8YX N1jfB9le8vmI55SQ2YfyrV+hIfIob2as3u5tp/VNly2NwUbq7bwZkfJH6ysyvcIsKBTu q/QQ== X-Gm-Message-State: ANoB5pmP/YXlLMY3kWkD5OiUp9w8dhfq0BKcr+BlUgOVnVHU8P9S04Gu 0ZLIf8j9xs7Z2fZ0NbEOL5w= X-Google-Smtp-Source: AA0mqf6UFv63tLKWyfn8/RrWtqRaTc3vx4naMh6pBBQkSIXha6SO98VCNsnsVXhmW+Rzqd1CAuk2Rg== X-Received: by 2002:aa7:8518:0:b0:576:cda4:16c4 with SMTP id v24-20020aa78518000000b00576cda416c4mr17533731pfn.10.1670884101639; Mon, 12 Dec 2022 14:28:21 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z13-20020aa79e4d000000b005779110635asm6300260pfq.51.2022.12.12.14.28.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:28:21 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Message-Id: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> Date: Mon, 12 Dec 2022 14:28:19 -0800 To: cpbotha@vxlabs.com X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Charl P. Botha" writes: > The current js--treesit-imenu, used by the JavaScript, TypeScript and > TSX tree-sitter modes, would return empty pairs in the imenu alist if > there were none of that type of symbol. > > This would break both the built in imenu and also packages like > consult-imenu. > > See https://github.com/minad/consult/issues/697 for the discussion > there. Thank you very much! Sorry for the inconvenience it caused. Have you signed the copyright assignment? I=E2=80=99m asking because this change = is on the verge of 15 lines. Eli, WDYT? Yuan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 03:02:58 2022 Received: (at 59945) by debbugs.gnu.org; 13 Dec 2022 08:02:59 +0000 Received: from localhost ([127.0.0.1]:58784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p50Fe-0001Lx-Bn for submit@debbugs.gnu.org; Tue, 13 Dec 2022 03:02:58 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:53011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p501d-0001D0-I2 for 59945@debbugs.gnu.org; Tue, 13 Dec 2022 02:48:30 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8C4233200950; Tue, 13 Dec 2022 02:48:23 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Tue, 13 Dec 2022 02:48:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1670917703; x= 1671004103; bh=ykfvn6VB8fThATsQ2VblLUYwKEDCg+Ean2loB4/vXlk=; b=G WDPi8+tjb/gR+KxmIaJ2ioQrIw/LEKRBg/7IER5/oYYbk+TQ6VZyvWpSmBWoxxq9 3o+uv3ZrFC20Dt23ADjF7YvwiXqqVH5Hu6hhChEOdtGenBjG+TZDI7xZ0fSiaBh7 cTkmA+C41Hf3X/CnAzpZYQq0m0YjlYbhyAZBBBDpPCi9EljdiZnZUT6HTkyP82wx fYqm3Ur7Fqysz5Yu+8b85eg2gvXxPFFVp9sijwf2PuqMpf4ypHbdBkftQvXEbsII 90a/abDQyRfidQVhQOv2qnKufy9eDPAnc/h5koFn5kp3nSDY6SeImE5ka2vx68kf 0VyFPAimEEgKtA1cJ0qRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670917703; x= 1671004103; bh=ykfvn6VB8fThATsQ2VblLUYwKEDCg+Ean2loB4/vXlk=; b=C 9L2Gk6PloyUiDNgcTKzrsoKmU9UkQlb3AHcKSRRb7pr1jXX5MfKB0O45H8Y2PaOf F9AEDu4k+kmij0ul2ZrnmCkLRKREO7pKoMq+HpgOxASs0jm+hZsUi9AI5Ms72say RyQrsLemkgu+KcBteGeQxpUnJ0oz2Z9wMKtaGTQSCWkCFB/7h1kd8nTFjngtAMp/ y5h3xB02oabT2ey5nsOCTp9lNrO9RFFyqSfVW7F7m6JmvhWDEdBnBEtAcMc0cAlp ssIzPPEAbLI7rhQ5CUwkNcM4QG1YVLk0wYS+5a2d2XEbduaW8yEDf9pm7ayeJsDL lBIoOOlUcZJCSQ7Yst0yw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelgdduudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdev hhgrrhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrgesvhiglhgrsghsrdgtohhmqe enucggtffrrghtthgvrhhnpedtveeiledvhfehjeekueeiteefvedtleekteelvdegledu udegkeffudehieekveenucffohhmrghinhepghhithhhuhgsrdgtohhmpdhmihhtrdgvug hupdhkvgihsggrshgvrdhiohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggsshdrtghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id CBB2536A0073; Tue, 13 Dec 2022 02:48:22 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: <7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com> In-Reply-To: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> Date: Tue, 13 Dec 2022 09:48:02 +0200 From: "Charl P. Botha" To: "Yuan Fu" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59945 X-Mailman-Approved-At: Tue, 13 Dec 2022 03:02:53 -0500 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dear Yuan Fu, dear Eli, On Tue, Dec 13, 2022, at 00:28, Yuan Fu wrote: > "Charl P. Botha" writes: > >> The current js--treesit-imenu, used by the JavaScript, TypeScript and >> TSX tree-sitter modes, would return empty pairs in the imenu alist if >> there were none of that type of symbol. >> >> This would break both the built in imenu and also packages like >> consult-imenu. >> >> See https://github.com/minad/consult/issues/697 for the discussion >> there. > > Thank you very much! Sorry for the inconvenience it caused. Have you > signed the copyright assignment? I=E2=80=99m asking because this chang= e is on > the verge of 15 lines. Eli, WDYT? Emacs is (and always has been) a positive force in my life, thank you fo= r all the energy that you pour into it! I have not yet signed the copyright assignment, I would gladly do so. Hopefully we can do this digitally? I live in South Africa, but I'm a Du= tch citizen, in case that matters. I also have a PGP key [1] that's fair= ly well connected and can be verified on keybase (FWIW) [2] Kind regards, Charl [1] http://pgp.mit.edu:11371/pks/lookup?op=3Dget&search=3D0x384435C7E77A= 4564 [2] https://keybase.io/cpbotha From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 07:03:58 2022 Received: (at 59945) by debbugs.gnu.org; 13 Dec 2022 12:03:58 +0000 Received: from localhost ([127.0.0.1]:59908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p540s-0004BL-I1 for submit@debbugs.gnu.org; Tue, 13 Dec 2022 07:03:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p540p-0004BD-TQ for 59945@debbugs.gnu.org; Tue, 13 Dec 2022 07:03:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p540k-0000mg-J2; Tue, 13 Dec 2022 07:03:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=GqcZMc/nMPPZWUoJ4jxxI4xEzEnmzgA7a2dMRLPS63k=; b=gG9/aOPS83avyK51ckMl Jcxoa8/IvdjMWWYBko2/wXuR3DsfDV/R+EKu+uAQeFwiaBwDPxY6lq1FgPQMiNcc+OVGNwXn0bzyr 1wtGmbnR1tpv1FzsoHQVw1y/vrloiUF9Fwej26duvmTC8USV2CYeaJNo4ZZmcKy54e/kxprbW1QbJ u5E9p+fww1HFY71BnSWUHGJMbZaaFSfMDYVAJuXv9BtJQBO0+VMXTomHAmE+8OgfeGc1jUFyC36r9 GyU0jGQ4O5xS1FE7EN7YoF/BJbeP4Hbs5kZBdg7vhSz+IUoFxQcm812H7J1UXsfUusEw6AQ2xxZUe +lQF/FULzgoRTg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p540h-0006Xg-Gt; Tue, 13 Dec 2022 07:03:48 -0500 Date: Tue, 13 Dec 2022 14:03:52 +0200 Message-Id: <83zgbrpl1z.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> (message from Yuan Fu on Mon, 12 Dec 2022 14:28:19 -0800) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59945 Cc: cpbotha@vxlabs.com, 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Mon, 12 Dec 2022 14:28:19 -0800 > Cc: 59945@debbugs.gnu.org, > Eli Zaretskii > > Thank you very much! Sorry for the inconvenience it caused. Have you > signed the copyright assignment? I’m asking because this change is on > the verge of 15 lines. Eli, WDYT? Yes, it's fine to install this, but please remember to add the Copyright-paperwork-exempt thingy to the log message. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 13 07:40:10 2022 Received: (at 59945) by debbugs.gnu.org; 13 Dec 2022 12:40:10 +0000 Received: from localhost ([127.0.0.1]:60095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p54Zu-0006rN-Bu for submit@debbugs.gnu.org; Tue, 13 Dec 2022 07:40:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p54Zr-0006rF-Py for 59945@debbugs.gnu.org; Tue, 13 Dec 2022 07:40:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p54Zl-0006dT-KH; Tue, 13 Dec 2022 07:40:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gNWAW897I8pvMXP62gFyv4KpiU3jA0vSocCGd6O4g0U=; b=b30XfY6TvGOq aeBSTnbUdsSHKgBxyyLuhinxltvFG6vzXl+tiVb1N0YOiKASRXuDDleDoq02AcH4j7JgfRmfHu9Sj t+Nzx0mcpCg9o3H6oxyvBs2/WX2ghE8GYEvnDOfpYtw7cjecRYMlMrAZDi/YYaCeSH81De3HzNKOn MJF94hFomYRW2koHuCbgW/No2OfGxv7qZo778bGS23DYuProseiGIl5GTWsBuNOnZ5KunDM6iXLaR QSTQxVumkjIQ7BjHJgOpz1fvkOtMjm+hQQjPrRU8NWaeS25KYcNWzddksS2B8G94gc120sah/Mqj7 XFoXP/UvqJwrtFTzCU9AiA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p54Zl-00071K-3C; Tue, 13 Dec 2022 07:40:01 -0500 Date: Tue, 13 Dec 2022 14:40:05 +0200 Message-Id: <83mt7rpjdm.fsf@gnu.org> From: Eli Zaretskii To: "Charl P. Botha" In-Reply-To: <7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com> (cpbotha@vxlabs.com) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> <7c331556-090e-4e44-a337-6f506e81d811@app.fastmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59945 Cc: casouri@gmail.com, 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 13 Dec 2022 09:48:02 +0200 > From: "Charl P. Botha" > Cc: 59945@debbugs.gnu.org, "Eli Zaretskii" > > Emacs is (and always has been) a positive force in my life, thank you for all the energy that you pour into it! > > I have not yet signed the copyright assignment, I would gladly do so. Thanks, form sent off-list. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 04:46:26 2022 Received: (at 59945) by debbugs.gnu.org; 15 Dec 2022 09:46:26 +0000 Received: from localhost ([127.0.0.1]:42671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5kor-0000rz-Le for submit@debbugs.gnu.org; Thu, 15 Dec 2022 04:46:26 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5kJW-0000Uc-Ln for 59945@debbugs.gnu.org; Thu, 15 Dec 2022 04:14:05 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id C86E632008FF; Thu, 15 Dec 2022 04:13:56 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Thu, 15 Dec 2022 04:13:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1671095636; x= 1671182036; bh=Ezms5wJvz/ja2btJNMxT/P1h3ZmaPbYL3cCC3vO5Vxc=; b=Q UF4PgaFrA3FzceehGcgDWJe12UrnFvSNb0UgWqgGiFbIa3jxYvvmYR15P/CCoAhW D7L6rk1Oi7TbqYVfJOV+jJc1+POWBRkxiBcMINW5U8KI9+3Vxu9rJ1IUA0Z6L/w3 Y6IBd0Csoi75Ki45nonligmm/ZF8sOdS+ZyWQH8MCp8IX/623lK6PSyFnyg2it2U udJ39m7RyTC4yhLIoQ7pUcCOnUSGWVKTCp2z8uvKUYZ697SVjCk4if2kauVQEAAc sLJu0F1uGM2SUOzw6Q270o9jE5Le131c9gCP2WobQwFU7dbnFbzGU+yC8KXeF0xq KDEK1iuvx/7X8TEnSmFvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671095636; x= 1671182036; bh=Ezms5wJvz/ja2btJNMxT/P1h3ZmaPbYL3cCC3vO5Vxc=; b=O H+aPsqUY3awL82v7QOqGzhPkjcHPhGFiXbZvAdyhz0RKZvRIF9fjRuzVIogOeVel LnqFu2Rne52I7EH6SqT/obrDluG1NkOLbsXvmv8rtrGPl9KVSubwtX9ybrKbKAzB Lenv9Abfg6C+3j5c8HzukjXqiLG+gVfdG1aGVyIuF4mls4fUJLHFwId3dllYCBlO Ula2MElhKWp+N+E30OwxmscS7bGWrjeU4BY7OWNlttfmB80UblGbIAvzRAX3GO0b QnwwKEzqOgtNfya9ppfWY6r8RgoQkgqtGMOTa704oFiG0CZ8eLrYBPPRYqgknuPO WpVzgwB6PirfkExV/H0qA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfvehh rghrlhcurfdruceuohhthhgrfdcuoegtphgsohhthhgrsehvgihlrggsshdrtghomheqne cuggftrfgrthhtvghrnhepudegieeiheeifedtveetieejhfefkeevgfehtdeviedtueeh veeuheeugfdvjeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomheptghpsghothhhrgesvhiglhgrsghsrdgtohhm X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 355F536A0073; Thu, 15 Dec 2022 04:13:56 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: In-Reply-To: <83zgbrpl1z.fsf@gnu.org> References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> <83zgbrpl1z.fsf@gnu.org> Date: Thu, 15 Dec 2022 11:13:41 +0200 From: "Charl P. Botha" To: "Yuan Fu" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59945 X-Mailman-Approved-At: Thu, 15 Dec 2022 04:46:24 -0500 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dear Yuan, On Tue, Dec 13, 2022, at 14:03, Eli Zaretskii wrote: >> From: Yuan Fu >> Date: Mon, 12 Dec 2022 14:28:19 -0800 >> Cc: 59945@debbugs.gnu.org, >> Eli Zaretskii >>=20 >> Thank you very much! Sorry for the inconvenience it caused. Have you >> signed the copyright assignment? I=E2=80=99m asking because this chan= ge is on >> the verge of 15 lines. Eli, WDYT? > > Yes, it's fine to install this, but please remember to add the > Copyright-paperwork-exempt thingy to the log message. In the meantime, I've sent my signed copyright assignment, and my employ= er's docusigned disclaimer of rights, to the FSF. I would be super grateful if you could add the commit when you can make = the time. Kind regards, Charl From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 05:41:48 2022 Received: (at 59945) by debbugs.gnu.org; 15 Dec 2022 10:41:48 +0000 Received: from localhost ([127.0.0.1]:42766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5lgS-0001Xi-8D for submit@debbugs.gnu.org; Thu, 15 Dec 2022 05:41:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5lgP-0001Xa-AN for 59945@debbugs.gnu.org; Thu, 15 Dec 2022 05:41:47 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5lgJ-0003l0-Hu; Thu, 15 Dec 2022 05:41:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=W2XFaQz2Jr5bigwWMaDBEnXOyBLsEJG2zky+3dAV49Y=; b=Azutr110/cVDYpYBkhQB 5XkKe8afl3jP7SpR7uj2VqMNcFP6AUVYJnXO19oH937D5YOCYst1RWw3zvpjRQ7eY8bmblkaAQzas 3lrWEXSJ232W8ECha/r3j6RVzbd+R0C/6SYBJoqJmvwyR3N1j9/HFl1VX0T2RIHnQSqxmwcPGE37Z lMuySHHkSqclfSjp8RR4IMkZBq+NNDUrM0OhcGqJoAlrF98e963UwJK/f5c0ZM5J0ZdKtjGgmthIm nCQn+a7WlrNFqvIQXA83LoAs0QYggXD/HeZZ1F0Kq/6t0Q1LUXLIdTxTSmvCtlL1H0aRdBSuEr33G S/weg8i4c0xXbg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5lgI-0004g6-RX; Thu, 15 Dec 2022 05:41:39 -0500 Date: Thu, 15 Dec 2022 12:41:37 +0200 Message-Id: <83h6xxkkym.fsf@gnu.org> From: Eli Zaretskii To: "Charl P. Botha" In-Reply-To: (cpbotha@vxlabs.com) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist References: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> <83zgbrpl1z.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59945 Cc: casouri@gmail.com, 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 15 Dec 2022 11:13:41 +0200 > From: "Charl P. Botha" > Cc: 59945@debbugs.gnu.org, "Eli Zaretskii" > > Dear Yuan, > > On Tue, Dec 13, 2022, at 14:03, Eli Zaretskii wrote: > >> From: Yuan Fu > >> Date: Mon, 12 Dec 2022 14:28:19 -0800 > >> Cc: 59945@debbugs.gnu.org, > >> Eli Zaretskii > >> > >> Thank you very much! Sorry for the inconvenience it caused. Have you > >> signed the copyright assignment? I’m asking because this change is on > >> the verge of 15 lines. Eli, WDYT? > > > > Yes, it's fine to install this, but please remember to add the > > Copyright-paperwork-exempt thingy to the log message. > > In the meantime, I've sent my signed copyright assignment, and my employer's docusigned disclaimer of rights, to the FSF. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 15 20:40:44 2022 Received: (at 59945) by debbugs.gnu.org; 16 Dec 2022 01:40:44 +0000 Received: from localhost ([127.0.0.1]:46122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ziO-0007Bi-7P for submit@debbugs.gnu.org; Thu, 15 Dec 2022 20:40:44 -0500 Received: from mail-pj1-f47.google.com ([209.85.216.47]:46037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ziK-0007Ba-9t for 59945@debbugs.gnu.org; Thu, 15 Dec 2022 20:40:42 -0500 Received: by mail-pj1-f47.google.com with SMTP id v13-20020a17090a6b0d00b00219c3be9830so928075pjj.4 for <59945@debbugs.gnu.org>; Thu, 15 Dec 2022 17:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=xpvfKLQsDxduj1j1RrNShseIFzJ20KQjAT702m6+KCA=; b=DfE3fHarPq5ykRVRqzLmrZp3yExcvjeHjjiFZPYdCsn4SXKocBgQ0b9uv8I2YXhD9l DTxhf3FNkf137p1a0MzrIqdg4YgBuZsDc7AncFDc3C6JYBerMMWvtG5mIMUxxi6avqAo oQ+Vf1ocS8DAKzC06cgoYt67kwePEuoHms0RObJdm7f7hmHVBnVEKEcnXOZU9n+wvyHe 1RpqAt0vk7uq2VYYj0Cc3qzMYYl2ra/WJB2CgukrtPr/+MzJZcFhwZ788A1q3NZRic7D a5XatilYTRoRPlxr5nl5dsifjcHgKIlj9JRrAs9NtHhXgcZ7GPUDFlRr8SwLaxqfpJTG DQTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xpvfKLQsDxduj1j1RrNShseIFzJ20KQjAT702m6+KCA=; b=ilbsaYfQGJvv+4TPxlMb8AUkW8RwwmPYnvrh8A0eqVA98uYCfgwwuxXVzHTYUxQf8g h+xdgsGsvp/22qj5G/bcKw/3v6b3w2asqenAk71H4q+q01wR+kZ8hKTuzFG3lP08oyNg NeGXJR4StI3DdzzHUY6gWFNIqFo9rQXKKXvGk6XMp1KTCVui+SK66nblFXVNTQhlrJW5 oe1jHkXU/T0xolzvEGtfKImVGnFjFXC3u2DzZMBEGJmMWpxzS+ys25upVr+CR0FixMVu TP8/AGZL8vs3KBL0YY1YA5HWrr9t5Gl+hjbufG5NZ/s+O2DWmL004UWfQ2k6MqokxUt8 HzFQ== X-Gm-Message-State: ANoB5pmyUo9jnVHq4gJ4lyqGhJfKsb1bFb9QqX1jjnxxg68VnIL987gM lOkxafzh1WPk0XikkrcjLvI= X-Google-Smtp-Source: AA0mqf4bZ4E2C27YSTb160hyHNX5qTZFpPYrR2fbqJVXtYkRumHIymBPLXX4ysHBw34S+gC9u/lMzQ== X-Received: by 2002:a17:902:f292:b0:190:d283:7faf with SMTP id k18-20020a170902f29200b00190d2837fafmr10824638plc.13.1671154834533; Thu, 15 Dec 2022 17:40:34 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id l13-20020a170903244d00b0017849a2b56asm302088pls.46.2022.12.15.17.40.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2022 17:40:33 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Message-Id: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> Date: Thu, 15 Dec 2022 17:40:32 -0800 To: cpbotha@vxlabs.com X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Charl P. Botha" writes: > Dear Yuan, > > On Tue, Dec 13, 2022, at 14:03, Eli Zaretskii wrote: >>> From: Yuan Fu >>> Date: Mon, 12 Dec 2022 14:28:19 -0800 >>> Cc: 59945@debbugs.gnu.org, >>> Eli Zaretskii >>>=20 >>> Thank you very much! Sorry for the inconvenience it caused. Have you >>> signed the copyright assignment? I=E2=80=99m asking because this = change is on >>> the verge of 15 lines. Eli, WDYT? >> >> Yes, it's fine to install this, but please remember to add the >> Copyright-paperwork-exempt thingy to the log message. > > In the meantime, I've sent my signed copyright assignment, and my = employer's docusigned disclaimer of rights, to the FSF. > > I would be super grateful if you could add the commit when you can = make the time. Thanks. Unless I=E2=80=99m missing something, your patch is a diff file = rather than a patch file. You can generate one with git format-patch -1 --stdout >~/mypatch.patch Don=E2=80=99t worry about commit message this time, I=E2=80=99ll reword = your commit and add it. But if you want to submit more patches in the future I recommend you to read CONTRIBUTE file under repo root, which describes the commit message format Emacs uses. Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 03:36:23 2022 Received: (at 59945) by debbugs.gnu.org; 16 Dec 2022 08:36:23 +0000 Received: from localhost ([127.0.0.1]:47960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p66CZ-0005vQ-SM for submit@debbugs.gnu.org; Fri, 16 Dec 2022 03:36:23 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p63kY-0003x3-Oj for 59945@debbugs.gnu.org; Fri, 16 Dec 2022 00:59:15 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9180C5C010A; Fri, 16 Dec 2022 00:59:09 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Fri, 16 Dec 2022 00:59:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1671170349; x=1671256749; bh=APmeFgAwwG iVv/GfXAsVaM71qhmEuX3LLzsBhOnSYUE=; b=XXQptWzGaYfm6uMZKEVgMhUB+g 1cu7d0TgXBRs3XZqOEb2DG46QXBh/mT+CZ27Ehut1oobfPyVjU8uV99d6R8G6KYU rl//7Gm1xNklYmc+JO4Di/ZTJwgEoulQU7ppgbYrXQc1kgHhuaX62uodGsA4NL4X Bid2vC0A3ypYcF8AuQk1tyDcrkXBLiwp1tM/+M8i8z/4hRKwpvOvkan+8xbJ9FVH GGjatgczkoUTdCfbo/UJajXipAWoKxekVswv4Fn78Zlccyf2rolAU3tWjdpbCL5L gi6QrSnMd7/1Is2LSxonUGgEa5Cc3oXijrW87wX4arQqo2+0c8FzJfytKUMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1671170349; x=1671256749; bh=APmeFgAwwGiVv/GfXAsVaM71qhmE uX3LLzsBhOnSYUE=; b=nEQtR9dfqjbsskR5FjtHvdugQR9zxTFv0NguRayiwby/ xajzXfHiGOafskYiwYwGHlouCeQJIxxDu7oH/8TLNtuq5rX5kGcheQvvSBxNDnOY rW+pzWEYOzuBUnVgAjOs65iP3mBmjn/SkTkg319hbiBZlUfc0+k+OZWzzNH1QFLd zVWr4dQvZy8SNHdJeG8sOigu8O/3gh2d1QjgmF5o5erkyCjrpIACivm8p8lzvsVp W7v80KiXOgyuSwFNLibF9Ca2Yx8sd5+G+16XD7cgB21Xy0lNCC8UQcRkPdoJzug+ WSfAlBiTBgAk19qTwKFBmcvU6vTFKH9xT4d5OSS92Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeigdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesmhdtreerreerjeenucfhrhhomhepfdevhhgr rhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrgesvhiglhgrsghsrdgtohhmqeenuc ggtffrrghtthgvrhhnpedufeejiedvffefhfeiieehgfdtudejffevuedvueevudelledu veeffeejgfelueenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggsshdr tghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 15F2736A0073; Fri, 16 Dec 2022 00:59:08 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: In-Reply-To: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> References: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> Date: Fri, 16 Dec 2022 07:58:46 +0200 From: "Charl P. Botha" To: "Yuan Fu" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: multipart/mixed; boundary=04f1092c324644f6aa046898ec265df1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59945 X-Mailman-Approved-At: Fri, 16 Dec 2022 03:36:18 -0500 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --04f1092c324644f6aa046898ec265df1 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Dear Yuan, On Fri, Dec 16, 2022, at 03:40, Yuan Fu wrote: > "Charl P. Botha" writes: >> In the meantime, I've sent my signed copyright assignment, and my emp= loyer's docusigned disclaimer of rights, to the FSF. >> >> I would be super grateful if you could add the commit when you can ma= ke the time. > > Thanks. Unless I=E2=80=99m missing something, your patch is a diff fil= e rather > than a patch file. You can generate one with > > git format-patch -1 --stdout >~/mypatch.patch > > Don=E2=80=99t worry about commit message this time, I=E2=80=99ll rewor= d your commit and > add it. But if you want to submit more patches in the future I recomme= nd > you to read CONTRIBUTE file under repo root, which describes the commit > message format Emacs uses. I followed the instructions at https://www.gnu.org/software/emacs/manual= /html_node/emacs/Sending-Patches.html which said to use "git format-patc= h master" and include either inline (which I did) or as a mime attachmen= t. I have now re-done it using your advice above, and included the patch fi= le as attachment to this email. Next time (would be great if it happens), I'll attach by default. Kind regards, Charl --04f1092c324644f6aa046898ec265df1 Content-Disposition: attachment; filename="cpb-fix-empty-pairs-js-ts.patch" Content-Type: application/octet-stream; name="cpb-fix-empty-pairs-js-ts.patch" Content-Transfer-Encoding: BASE64 RnJvbSAwMWM0ZjNhZGU1YzYxYjk2NzE4YmJmMzZiMmVkN2I0YjFlZDg0YWEwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhcmwgUC4gQm90aGEiIDxjcGJvdGhhQHZ4bGFi cy5jb20+CkRhdGU6IFNhdCwgMTAgRGVjIDIwMjIgMTk6MDk6MzggKzAyMDAKU3ViamVjdDog W1BBVENIXSBGaXggZW1wdHkgcGFpcnMgaW4ganMgdHJlZS1zaXR0ZXIgaW1lbnUgYWxpc3QK ClRoZSBjdXJyZW50IGpzLS10cmVlc2l0LWltZW51LCB1c2VkIGJ5IHRoZSBKYXZhU2NyaXB0 LCBUeXBlU2NyaXB0IGFuZApUU1ggdHJlZS1zaXR0ZXIgbW9kZXMsIHdvdWxkIHJldHVybiBl bXB0eSBwYWlycyBpbiB0aGUgaW1lbnUgYWxpc3QgaWYKdGhlcmUgd2VyZSBub25lIG9mIHRo YXQgdHlwZSBvZiBzeW1ib2wuCgpUaGlzIHdvdWxkIGJyZWFrIGJvdGggdGhlIGJ1aWx0IGlu IGltZW51IGFuZCBhbHNvIHBhY2thZ2VzIGxpa2UKY29uc3VsdC1pbWVudS4KClNlZSBodHRw czovL2dpdGh1Yi5jb20vbWluYWQvY29uc3VsdC9pc3N1ZXMvNjk3IGZvciB0aGUgZGlzY3Vz c2lvbiB0aGVyZS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9qcy5lbCB8IDE1ICsrKysrKysrKysr LS0tLQogMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvanMuZWwgYi9saXNwL3Byb2dtb2Rlcy9q cy5lbAppbmRleCBlMDYyNTk1MWI2NS4uOGZkMDM4NmU2YWUgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2pzLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2pzLmVsCkBAIC0zNzM4LDEw ICszNzM4LDE3IEBAIGpzLS10cmVlc2l0LWltZW51CiAgICAgICAgICAoZnVuYy10cmVlICh0 cmVlc2l0LWluZHVjZS1zcGFyc2UtdHJlZQogICAgICAgICAgICAgICAgICAgICAgbm9kZSAi ZnVuY3Rpb25fZGVjbGFyYXRpb24iIG5pbCAxMDAwKSkKICAgICAgICAgICh2YXItdHJlZSAo dHJlZXNpdC1pbmR1Y2Utc3BhcnNlLXRyZWUKLSAgICAgICAgICAgICAgICAgICAgbm9kZSAi bGV4aWNhbF9kZWNsYXJhdGlvbiIgbmlsIDEwMDApKSkKLSAgICBgKCgiQ2xhc3MiIC4gLChq cy0tdHJlZXNpdC1pbWVudS0xIGNsYXNzLXRyZWUpKQotICAgICAgKCJWYXJpYWJsZSIgLiAs KGpzLS10cmVlc2l0LWltZW51LTEgdmFyLXRyZWUpKQotICAgICAgKCJGdW5jdGlvbiIgLiAs KGpzLS10cmVlc2l0LWltZW51LTEgZnVuYy10cmVlKSkpKSkKKyAgICAgICAgICAgICAgICAg ICAgbm9kZSAibGV4aWNhbF9kZWNsYXJhdGlvbiIgbmlsIDEwMDApKQorICAgICAgICAgKGlt ZW51LWFsaXN0IG5pbCkpCisgICAgOzsgd2hlbiBhIHN1Yi10cmVlIGlzIGVtcHR5LCB3ZSBz aG91bGQgbm90IHJldHVybiB0aGF0IHBhaXIgYXQgYWxsCisgICAgOzsgaHR0cHM6Ly9naXRo dWIuY29tL21pbmFkL2NvbnN1bHQvaXNzdWVzLzY5NyNpc3N1ZWNvbW1lbnQtMTM0NTMwMjcz NAorICAgICh3aGVuIGZ1bmMtdHJlZQorICAgICAgKHNldHEgaW1lbnUtYWxpc3QgKGNvbnMg YCgiRnVuY3Rpb24iIC4gLChqcy0tdHJlZXNpdC1pbWVudS0xIGZ1bmMtdHJlZSkpIGltZW51 LWFsaXN0KSkpCisgICAgKHdoZW4gdmFyLXRyZWUKKyAgICAgIChzZXRxIGltZW51LWFsaXN0 IChjb25zIGAoIlZhcmlhYmxlIiAuICwoanMtLXRyZWVzaXQtaW1lbnUtMSB2YXItdHJlZSkp IGltZW51LWFsaXN0KSkpCisgICAgKHdoZW4gY2xhc3MtdHJlZQorICAgICAgKHNldHEgaW1l bnUtYWxpc3QgKGNvbnMgYCgiQ2xhc3MiIC4gLChqcy0tdHJlZXNpdC1pbWVudS0xIGNsYXNz LXRyZWUpKSBpbWVudS1hbGlzdCkpKQorICAgIGltZW51LWFsaXN0KSkKIAogOzs7IE1haW4g RnVuY3Rpb24KIAotLSAKMi4yNS4xCgo= --04f1092c324644f6aa046898ec265df1-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 09:11:34 2022 Received: (at 59945) by debbugs.gnu.org; 16 Dec 2022 14:11:34 +0000 Received: from localhost ([127.0.0.1]:49572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6BR0-000633-DF for submit@debbugs.gnu.org; Fri, 16 Dec 2022 09:11:34 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:38897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6BQu-00062q-GQ for 59945@debbugs.gnu.org; Fri, 16 Dec 2022 09:11:32 -0500 Received: by mail-wm1-f52.google.com with SMTP id i187-20020a1c3bc4000000b003d1e906ca23so1285409wma.3 for <59945@debbugs.gnu.org>; Fri, 16 Dec 2022 06:11:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=iAMBBFmJmiWNFmuVecHXTBC9s8nHGgG8miHZj0AopSk=; b=T3H6dAq6DEAJULn7r1ilD5VXE+O43nRqFPae4Q3Ha/fWHXxDtXaL3UPBZdT62TIPr0 Ot1bJAPIN3rGhDe1zhxkerqaTsMHBj7grJCKLDnY+9Bgeev2Sj6yZaenHUC7NsfWidz9 zhDjpLUQGPDxWXBnWEkNTo8LkAWhMApRGaYQs5dVU3cdTjKMNXt0VyFS8X4dfBrEthMz Wdc7wgYithf4eJ7LLBiSU2VbdfW3WFxTH8h29kYPvFosaE3tlzJRpLqqcrcK3IuL52dc ESKEcVq3SbX8s3GenMIvYONmcqk1d0CP/pMsQKurdy+i6YppUyJoJooJfUfe3+sqy86l FDkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iAMBBFmJmiWNFmuVecHXTBC9s8nHGgG8miHZj0AopSk=; b=n6Ovew5OmWXiDXSXXVnxtFKKHkZ8X3j3KGp4O9oz10cMyIgq0zsSeWPQ1FzkfIJdIj EIU7OBxkGDdhXo+L3aoCFgxucrSwqvOq0+zYKQ8JY+6GIfGA4kwlJmLUKx1J5jjyYwff F9ZElH9PSzN+52fRdncgQeRFQzWEnaXvrpm2LyxIV+Jc+4LBEjDeGLXt2opg4EytufRT EtyP2NaDq02flb0/buWRMQ/13f4KyqabGYijZc2IsELNX/MdL1orLfnJJbKrImlMGwVA Klrf/2ZWpLs1sAh6BnL0GpR+1o06VlZhGR8gmTrdv3i1Mf2ubOFOPQ5J+MAtPh/ldwbj pxuA== X-Gm-Message-State: ANoB5pnb4+S8rCsWgkJ6LxnUZNuMY5NrtlS9mOXamM8BZf47l0VzTVwy Ko0A364lEqA1kzeE39vGTxux8fATK/o= X-Google-Smtp-Source: AA0mqf6qfDGlZcmLgOUZEuZOsq4fzZshEOqBWdonF6nQelD+A7JCw/OMG5trTvM59xgC+y8pYEi/fw== X-Received: by 2002:a05:600c:4451:b0:3cf:894d:1d06 with SMTP id v17-20020a05600c445100b003cf894d1d06mr26801240wmn.30.1671199882122; Fri, 16 Dec 2022 06:11:22 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id ay14-20020a05600c1e0e00b003cfd4a50d5asm9803706wmb.34.2022.12.16.06.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 06:11:21 -0800 (PST) From: Robert Pluim To: "Charl P. Botha" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist In-Reply-To: (Charl P. Botha's message of "Fri, 16 Dec 2022 07:58:46 +0200") References: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> Date: Fri, 16 Dec 2022 15:11:20 +0100 Message-ID: <87ilibo2uv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: Yuan Fu , Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" said: Charl> I followed the instructions at Charl> https://www.gnu.org/software/emacs/manual/html_node/emacs/Sendin= g-Patches.html Charl> which said to use "git format-patch master" and include either i= nline Charl> (which I did) or as a mime attachment. Not quite. You sent the result of 'git format-patch master' as an email, not inline in an email (presumably with 'git send-email'). That shouldn=CA=BCt matter, because 'git apply' should work in either case, but attachments are sometimes easier to work with. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 16 22:34:42 2022 Received: (at 59945) by debbugs.gnu.org; 17 Dec 2022 03:34:42 +0000 Received: from localhost ([127.0.0.1]:53347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6NyD-00018C-Nn for submit@debbugs.gnu.org; Fri, 16 Dec 2022 22:34:42 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6Etl-0004hf-JP for 59945@debbugs.gnu.org; Fri, 16 Dec 2022 12:53:30 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 782CA5C00B5; Fri, 16 Dec 2022 12:53:24 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Fri, 16 Dec 2022 12:53:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1671213204; x= 1671299604; bh=IqWK9GclbEH3xBN9QJChznHonWXiN7YljCbrrtOo4bQ=; b=p 3YO0WN6zxCisqjOneqj+0NnRhH6Y+GuiCrOT7E4WlQ1Ec90aryWpKhX/YvtS0NdP 927NxSb0ku2VyEhNX/qCyX+EzkmZOtm7nAPSgTHp4WLEpPkzb2gMYtjHm6AOgbcy iWf/V+eCIvb5zTk3LLDzojMtSoVD7iS9KQwph7jC1Qq3ELvT59XzfXUIHHdCviAk xP6mEmw4hutBykfvFulOyqAfbi2/ERvwMVWjmzht38N2FNK134+IZCSlvLvVl40S ebUIf4QEp8Sy1vHqFi2xQWfwtvbQQjogMIK65urryNqKyQQqZ0mQfQI0OfBBfzIG Zd/eqZ8XGOdQTn2u39Qnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671213204; x= 1671299604; bh=IqWK9GclbEH3xBN9QJChznHonWXiN7YljCbrrtOo4bQ=; b=L k5DSFDqb3Gt4PMmpg5QlGV8+yHvX7JH4vekI+1rQZKHT08G7vwzN5SAjHrxbBQlb 0M2/dOjNPmUu54cN/i+ZEz1E7q3bPsmMa31xkkDebNtZjtBsMoEyHyYU3fMDFKsp pDZDD96I5Tv7fvZU1w98ygpLKZV2z6qAppMUZXh22BhADtrRhbj1J8QabMlq8uIs EKhz0/mCEUWlKj7U0lwPsGIyMPgQ1Skqk++rCN5k//80gNsnY9SklvUNQfGOE71W SHU26vAGln/9+9GF9/c/lJ9mJdq/MXF/Bnc0ft5e+3hTTeSJKGGtaA6kEznwBs8C t9zNS8iKqfgEtw3FRGl9g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejgddutdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdev hhgrrhhlucfrrdcuuehothhhrgdfuceotghpsghothhhrgesvhiglhgrsghsrdgtohhmqe enucggtffrrghtthgvrhhnpeeuieeuteelvefggfdttdefhfevtdffffdvtdejheefhfek tdffledtvdevveejfeenucffohhmrghinhepghhnuhdrohhrghenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggs shdrtghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1A6B336A0073; Fri, 16 Dec 2022 12:53:24 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: <8c8e575c-da72-4292-8753-5af9608171fa@app.fastmail.com> In-Reply-To: <87ilibo2uv.fsf@gmail.com> References: <94476C6A-CCEA-43CE-A6B7-0232998FCBCC@gmail.com> <87ilibo2uv.fsf@gmail.com> Date: Fri, 16 Dec 2022 19:52:27 +0200 From: "Charl P. Botha" To: "Robert Pluim" , "Yuan Fu" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59945 X-Mailman-Approved-At: Fri, 16 Dec 2022 22:34:38 -0500 Cc: Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote: >>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" said: > Charl> I followed the instructions at > Charl>=20 > https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patc= hes.html > Charl> which said to use "git format-patch master" and include=20 > either inline > Charl> (which I did) or as a mime attachment. > > Not quite. You sent the result of 'git format-patch master' as an > email, not inline in an email (presumably with 'git send-email'). That > shouldn=CA=BCt matter, because 'git apply' should work in either case,= but > attachments are sometimes easier to work with. Thank you for the correction, Robert! I thought that sending the output = of `git format-patch master` as a plain-text email was what was meant by= "inline". I'm sorry about this, I'll stick to attachments in the future. Yuan, can you confirm that the patch I eventually attached is OK? Kind regards, Charl From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 20 23:49:07 2022 Received: (at 59945) by debbugs.gnu.org; 21 Dec 2022 04:49:07 +0000 Received: from localhost ([127.0.0.1]:49276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7r2Q-0001GA-TG for submit@debbugs.gnu.org; Tue, 20 Dec 2022 23:49:07 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:41944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7r2Q-0001Fk-39; Tue, 20 Dec 2022 23:49:06 -0500 Received: by mail-pl1-f176.google.com with SMTP id l10so14401484plb.8; Tue, 20 Dec 2022 20:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=ZGSAjj6Mc+xIE2YLxKsk7Tj+4vvcSJ4g0KPmhY2WCho=; b=U4bA8BTBXrwzFILGD4zO6rirBZuNUhSSUj+w2P3PqYIwDCw3kc4cZrChgbUEX9Wldf Dr10W/JwopFDK6vrpYg1cxTDiZ+mn3P0ZSCbW1G4m7QrHSpMYGdmmrqVBMc8rEZoWkNG oN1WJLLIBKKRaNhuiPSqc91gNF9SeWnHYDuFD25awOhxTgqakwouWC1KrnCOtSqUZcuZ R2b2uv6aTkBqW4V4GuLltCyfCVOKKdhK13Mxey9p2zlTfJuZZPFobgqM7RjYr87ESMv3 n1kQ2/OmIh/FSm5CAtFPSPDfGZtmbYdjHs2ReGysaZ8CInUBXpqHpgXUnNoJx9k2dBOO gClg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZGSAjj6Mc+xIE2YLxKsk7Tj+4vvcSJ4g0KPmhY2WCho=; b=dTKjgjUX4yu/3AYFWe9iQffzZdCyrR0GBdbp/cTwIepz4rDOWu/j7UdDaAHPH8Aerb D2kOEKSDCtVoM/a042hNeiA9tzUGOUuwP4lW2BbPQbWa2WYV3Q12J6bLj69z7QZo2+h9 thcgm47WbUpW4bh7OnqawGZWnTzDpnglqArE11Bet2nHWHT0kNczji8Nzh7JQ8M43ZOj sBcQnMWZ3MbiBdXWZo8VrPZaO3YEs2wRj49K2zRd1rtwosd4FKrhvYktFqCHz8teuHsw +KriBfOjbt9AejZMO4no+8tvdnyA5nIJqbjEjL8Q18TkuFw6+r7jY24MNrcdXCfGETfw PPBg== X-Gm-Message-State: AFqh2kr2Zm9ZbsF0vFqtk2CHTuMviWjhqPTVv2KFZ2y1yNblRXUZt4OW LFVntr2U/0PDumBuvyMBXfA= X-Google-Smtp-Source: AMrXdXvajClCH+nOx8RPKXBicmZy66stN0n3TXv4z7FdzX7yi3OJhEn/yf2A1sdEKtqf/FiPuI+SrQ== X-Received: by 2002:a17:903:40d2:b0:191:19ed:d6b3 with SMTP id t18-20020a17090340d200b0019119edd6b3mr844649pld.3.1671598140334; Tue, 20 Dec 2022 20:49:00 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id d15-20020a170902cecf00b00189758e2b99sm10268166plg.92.2022.12.20.20.48.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Dec 2022 20:48:59 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Message-Id: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> Date: Tue, 20 Dec 2022 20:48:58 -0800 To: cpbotha@vxlabs.com X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: Robert Pluim , 59945-done@debbugs.gnu.org, Eli Zaretskii , 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) "Charl P. Botha" writes: > On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote: >>>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" = said: >> Charl> I followed the instructions at >> Charl>=20 >> = https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.= html >> Charl> which said to use "git format-patch master" and include=20 >> either inline >> Charl> (which I did) or as a mime attachment. >> >> Not quite. You sent the result of 'git format-patch master' as an >> email, not inline in an email (presumably with 'git send-email'). = That >> shouldn=CA=BCt matter, because 'git apply' should work in either = case, but >> attachments are sometimes easier to work with. > > Thank you for the correction, Robert! I thought that sending the > output of `git format-patch master` as a plain-text email was what was > meant by "inline". I'm sorry about this, I'll stick to attachments in > the future. Not really about attachment vs inline. The first patch doesn=E2=80=99t = have author, commit message, etc. I=E2=80=99m fine with either attachment or = inline :-) > Yuan, can you confirm that the patch I eventually attached is OK? Thanks! I applied your patch. I made a little change to it so it=E2=80=99s= more idiomatic. Elisp tip of the day: if you want to make a list of possibly nil objects and don=E2=80=99t want nil=E2=80=99s in the list, you can use append. = Basically change (list a b c) to (append (and xxx (list a)) (and yyy (list b)) (and zzz (list c))) If the condition aren=E2=80=99t met, eg, (and xxx (list a)) returns nil, = append just appends an empty list. Yuan From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 05:16:20 2022 Received: (at 59945) by debbugs.gnu.org; 21 Dec 2022 10:16:20 +0000 Received: from localhost ([127.0.0.1]:50980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7w95-00054W-MW for submit@debbugs.gnu.org; Wed, 21 Dec 2022 05:16:19 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:55497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7w90-00053y-Nz for 59945@debbugs.gnu.org; Wed, 21 Dec 2022 05:16:17 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id A02F732005BC; Wed, 21 Dec 2022 05:16:08 -0500 (EST) Received: from imap44 ([10.202.2.94]) by compute2.internal (MEProxy); Wed, 21 Dec 2022 05:16:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vxlabs.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1671617768; x= 1671704168; bh=nrMxYTpWVbTa1I0CB9JntWiEL9zo4aHmrb6SiHCFKy0=; b=J tCDB+fxm8M8ORX0mC5NoXHFxsEe+QFBpAYiYftXNcAXmL/8keE0l382wIXJa0QQd EbSyln6nxmrCZ7w1Xdvu6x80ziX1u5gnH5ByrdV4m2DfjzKExIUOhKJYYVxcyIiX zy3cqfl6bhDnvlroRZfv8YriSUJg60MsyUbn7HjtQR6HGlAEfyeCpYFgkwhampB7 +dvQVIzRVsOKxR5KIPpyqD6xHQW9dqA/0IHw6KLHFc6KSRk2qyu6f/GrWNASfEln nEoKeVFkR7C5Bm51g3qOB7HXObubo6i7bnCyBR/Tk/HAkt98jXV08tzm4Pgr0y7z nMvdxH+EDikc+2i+UbTzg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671617768; x= 1671704168; bh=nrMxYTpWVbTa1I0CB9JntWiEL9zo4aHmrb6SiHCFKy0=; b=b E2wHiIf1c+deLImWbq7o6lDWdOugLiXS3FUwcIetbzk1ZO4lAzlSInJeXzXMDMTp FG8QZ7555UUI2gCqIbQ5dmSEIfk85dFsTeLK87B/N9Molb241Lch4D9T8IsWQkwb u+TdU37dGshUKY7s0hspI/CgppmN/oCDN/AztaOVJoZy+oLzryDf4KzBuZ0OXb0j BeTAwALaj2K4OrS4bTtDdtVcAyObEn5NqvbrfPuCDerbc5k5ql/1sdxd1KYQX9va 813SglTFVHDzsnRpKeY2lr+yIMfFMjMi1M4c/8Q7Oie8Zg+34YZ6hi9JyLX8d/XK OjK8sjhrp1yApiUSnVjjQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeekgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvfevufgtgfesth hqredtreerjeenucfhrhhomhepfdevhhgrrhhlucfrrdcuuehothhhrgdfuceotghpsgho thhhrgesvhiglhgrsghsrdgtohhmqeenucggtffrrghtthgvrhhnpedugeeiieehieeftd evteeijefhfeekvefghedtveeitdeuheevueehuefgvdejieenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegtphgsohhthhgrsehvgihlrggssh drtghomh X-ME-Proxy: Feedback-ID: i502842e6:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 13C4936A0073; Wed, 21 Dec 2022 05:16:07 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1185-g841157300a-fm-20221208.002-g84115730 Mime-Version: 1.0 Message-Id: In-Reply-To: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> References: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> Date: Wed, 21 Dec 2022 12:15:47 +0200 From: "Charl P. Botha" To: "Yuan Fu" Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59945 Cc: 59945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dear Yuan, On Wed, Dec 21, 2022, at 06:48, Yuan Fu wrote: > Thanks! I applied your patch. I made a little change to it so it=E2=80= =99s more > idiomatic. > > Elisp tip of the day: if you want to make a list of possibly nil objec= ts > and don=E2=80=99t want nil=E2=80=99s in the list, you can use append. = Basically change > > (list a b c) > > to > > (append (and xxx (list a)) (and yyy (list b)) (and zzz (list c))) > > If the condition aren=E2=80=99t met, eg, (and xxx (list a)) returns ni= l, append > just appends an empty list. Thank you very much for taking care of this, and thank you for your emac= s-lisp improvement and tip. On that day, I searched for but was not able= to find a better formulation than my klunky one. Kind regards, Charl From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 21 12:26:08 2022 Received: (at 59945) by debbugs.gnu.org; 21 Dec 2022 17:26:08 +0000 Received: from localhost ([127.0.0.1]:53004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p82r1-0000Ep-JQ for submit@debbugs.gnu.org; Wed, 21 Dec 2022 12:26:07 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:47076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p82qz-0000EP-NF; Wed, 21 Dec 2022 12:26:06 -0500 Received: by mail-wm1-f54.google.com with SMTP id f13-20020a1cc90d000000b003d08c4cf679so1937124wmb.5; Wed, 21 Dec 2022 09:26:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UIDU8rW4tLvPYpmFLkve414hKkpASURAhnTEzoK6H4w=; b=S/qMcedoA1vV7YrNHkrmul0Y+PmxwHiyB5KaVvGY8FGHB68B3qz/eAXCJCIGLDQ8Tv 67cpMHBRhbpRcNqNIsp3pDDg581aX6TA/kad/zJRnuZhqNI+vI48WBiw02tMRuRLZKev cLRkKUQScfv65WeYQpWp3+9J/MmtUhNK9e5KsNWGG0ozHmBZh9Z5ANM4gsTshHhv3AAl 2siSSoQecFgXLXf3cWXcXTOxWQm8t5qq41ZWky/aLKsikiqHzzgglDHmeSEAlrpdZfze oNyf0dA4+XFZTnSqJpRgORd3QuHhljFnJtESvNtiD3+k21mgaYa44BZWDdSg1DqFB7Ag EJvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UIDU8rW4tLvPYpmFLkve414hKkpASURAhnTEzoK6H4w=; b=IKd5ISEExqF0lrFtRlp9GyxfuVAOKgdNL0j1UgvzfLjPNcBFyBn6KxmXLM2Q+4w0ZO +XrNc389s4Ug6rnySRqabNoLPJ/YRvNBz3QtpIHLMF5/7zWTf7rNbqsR9wyNiAv1hiw7 9qp56NgiCwV07Tfb2Tfg4nbgTT5elWPfP0/mSWbztfqbkFJRmJ65Bug3AGhduD/7oTdC gdoRisrNgcIYbAiQcIEwoLMctEAEWjzRE920JHdD+A18I6wRYKF9/TW2MoT89+SH/g5J aQTctb2jOjLPNxJY8+rArZi3+TQgLLOnW9qP1timz/sUxlkJaL3qp+j0+yvK5q5+c6tC gykg== X-Gm-Message-State: AFqh2krRW6MMu7lwOFlTYn+i1ovEeNsdfZ1OdrjCnWC3eQF2Mzm4l3/a wKD8xZUNGoU7uSO1J88BjtNlxUH8J88= X-Google-Smtp-Source: AMrXdXtU8obhbSPEdUaNdXEYjm8/+XurpJh4mFzikm5noomPvTSgCOx5dqJoLAz+InRHG7nmmn06QA== X-Received: by 2002:a05:600c:43ca:b0:3d0:73f5:b2c0 with SMTP id f10-20020a05600c43ca00b003d073f5b2c0mr2443751wmn.20.1671643559351; Wed, 21 Dec 2022 09:25:59 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id w16-20020a5d5450000000b0026a4bb75477sm2286107wrv.28.2022.12.21.09.25.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 09:25:58 -0800 (PST) From: Robert Pluim To: Yuan Fu Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist In-Reply-To: <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> (Yuan Fu's message of "Tue, 20 Dec 2022 20:48:58 -0800") References: <43c6e6ed-3ddc-4ae0-a150-f86e852bd83b@app.fastmail.com> <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> Date: Wed, 21 Dec 2022 18:25:58 +0100 Message-ID: <87k02kllcp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: 59945@debbugs.gnu.org, cpbotha@vxlabs.com, Eli Zaretskii , 59945-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 20 Dec 2022 20:48:58 -0800, Yuan Fu said: Yuan> "Charl P. Botha" writes: >> On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote: >>>>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" said: Charl> I followed the instructions at Charl>=20 >>> https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-P= atches.html Charl> which said to use "git format-patch master" and include=20 >>> either inline Charl> (which I did) or as a mime attachment. >>>=20 >>> Not quite. You sent the result of 'git format-patch master' as an >>> email, not inline in an email (presumably with 'git send-email'). T= hat >>> shouldn=CA=BCt matter, because 'git apply' should work in either ca= se, but >>> attachments are sometimes easier to work with. >>=20 >> Thank you for the correction, Robert! I thought that sending the >> output of `git format-patch master` as a plain-text email was what w= as >> meant by "inline". I'm sorry about this, I'll stick to attachments in >> the future. Yuan> Not really about attachment vs inline. The first patch doesn=E2= =80=99t have Yuan> author, commit message, etc. I=E2=80=99m fine with either attachm= ent or inline Yuan> :-) It did, it=CA=BCs just that the Author was the From of the email itself, and the commit message was everything before '---' :-) It=CA=BCs the style used on linux-kernel and related lists. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 22 03:10:13 2022 Received: (at 59945) by debbugs.gnu.org; 22 Dec 2022 08:10:14 +0000 Received: from localhost ([127.0.0.1]:56865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8Geb-00045D-Ht for submit@debbugs.gnu.org; Thu, 22 Dec 2022 03:10:13 -0500 Received: from mail-pf1-f176.google.com ([209.85.210.176]:33364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p8GeZ-000450-Dx; Thu, 22 Dec 2022 03:10:12 -0500 Received: by mail-pf1-f176.google.com with SMTP id 124so731379pfy.0; Thu, 22 Dec 2022 00:10:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zvTY+GbqR+8GmtQ+KxO8W0L/ClUPf3OgOn9F1BZi3lM=; b=oC4cTLMSao59DbNVudpK7UiYbJm6o/r5HpFtF72ch4lyfoEog8uKkdVmXW0iLUt8d0 LtBZXIbAW1dEOkZW5ENtvhSnRCEjJ6zKOfhqASYKnDz9rNdZc7ZnFEPl73EFBMstq+0V Lvt+/V6PqPY9EHX3AGNkXO3G2CRqJvRT/Fsc/k5c6XZ17RQnPx/+VbtH+tXl4xma2WaE SWcI11+b2bTr0d8I3BhGE+RXe0kw/iaU2FXQIseWBAG+6G3KPR8phF3bSNHANNhTqVCR aQU8mIkluFb2D8a8U9zY7o+B4H4kEVIO9uuIiDjpM1XlNozItrgduDpG3vNbCje24A+D VB3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zvTY+GbqR+8GmtQ+KxO8W0L/ClUPf3OgOn9F1BZi3lM=; b=3tuxVNxjYh6wRSS3YI/tiq7PysYFIbuMYYxdeCI/+L/H8PvKHOUtTVT0TGDsMP0Xn3 FC19xKNQnQvdXNGrF6TdvP9gAdla9RoZPzBJ5ePKqX1igwYTGW1EV+4s0L1y+zEScwFH V5xNEdaNncUHth4JJX+x2varTWWMAzafsPbXgQ5xnTF3FiwjkwzXDLK2iEOYuJHtYYWG mDlkLWSbAlPNcor9lRYDR05xyP53taxhU2xKLCrJ6PhLitcFGef/pJuyWZdF3rOZPkPU 1S8GG/Skh21IdDnH0NHM9vvYtuFvt9TKXzF/HlN+2QNwrvs2tKUrZhjD1FXURbquLIwq ncNg== X-Gm-Message-State: AFqh2korpsjzfJb09SoDlhu/x0bNA6bZQ3usyTGQyzdCFCpdMulZUuPz uUATVjXjffF2QHxOma7TyFY= X-Google-Smtp-Source: AMrXdXuCZjTqs1kp8KwhZ9h5A/I0NqIZtUY3Obvhgvr4G4jeSRd9+IYeQGkGyXvlHhDYl1THUOELFw== X-Received: by 2002:a05:6a00:1d97:b0:576:9eed:61de with SMTP id z23-20020a056a001d9700b005769eed61demr5936878pfw.4.1671696605164; Thu, 22 Dec 2022 00:10:05 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 68-20020a620647000000b005756a67e227sm55688pfg.90.2022.12.22.00.10.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2022 00:10:04 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist From: Yuan Fu In-Reply-To: <87k02kllcp.fsf@gmail.com> Date: Thu, 22 Dec 2022 00:10:03 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <52080296-2E7B-494C-8264-AF3273CEAF95@gmail.com> References: <43c6e6ed-3ddc-4ae0-a150-f86e852bd83b@app.fastmail.com> <7B3A9410-A4E4-4B32-83CE-FADB9588C7A7@gmail.com> <87k02kllcp.fsf@gmail.com> To: Robert Pluim X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59945 Cc: 59945@debbugs.gnu.org, cpbotha@vxlabs.com, Eli Zaretskii , 59945-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 21, 2022, at 9:25 AM, Robert Pluim wrote: >=20 >>>>>> On Tue, 20 Dec 2022 20:48:58 -0800, Yuan Fu = said: >=20 > Yuan> "Charl P. Botha" writes: >=20 >>> On Fri, Dec 16, 2022, at 16:11, Robert Pluim wrote: >>>>>>>>> On Fri, 16 Dec 2022 07:58:46 +0200, "Charl P. Botha" = said: > Charl> I followed the instructions at > Charl>=20 >>>> = https://www.gnu.org/software/emacs/manual/html_node/emacs/Sending-Patches.= html > Charl> which said to use "git format-patch master" and include=20 >>>> either inline > Charl> (which I did) or as a mime attachment. >>>>=20 >>>> Not quite. You sent the result of 'git format-patch master' as an >>>> email, not inline in an email (presumably with 'git send-email'). = That >>>> shouldn=CA=BCt matter, because 'git apply' should work in either = case, but >>>> attachments are sometimes easier to work with. >>>=20 >>> Thank you for the correction, Robert! I thought that sending the >>> output of `git format-patch master` as a plain-text email was what = was >>> meant by "inline". I'm sorry about this, I'll stick to attachments = in >>> the future. >=20 > Yuan> Not really about attachment vs inline. The first patch = doesn=E2=80=99t have > Yuan> author, commit message, etc. I=E2=80=99m fine with either = attachment or inline > Yuan> :-) >=20 > It did, it=CA=BCs just that the Author was the =46rom of the email = itself, > and the commit message was everything before '---' :-) >=20 > It=CA=BCs the style used on linux-kernel and related lists. Ahhhh, TIL. Yuan= From unknown Sun Jun 22 03:51:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 19 Jan 2023 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator