GNU bug report logs - #59941
use-package-defaults type not updated for added keywords :pin, :ensure etc

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59941: closed (use-package-defaults type not updated for
 added keywords :pin, :ensure etc)
Date: Sun, 11 Dec 2022 16:11:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 11 Dec 2022 17:10:47 +0100
with message-id <58797246-A94A-4E44-86DE-4CC8E43454B2 <at> gmail.com>
and subject line Re: use-package-defaults type not updated for added keywords :pin, :ensure etc
has caused the debbugs.gnu.org bug report #59941,
regarding use-package-defaults type not updated for added keywords :pin, :ensure etc
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59941: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59941
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: John Wiegley <johnw <at> newartisans.com>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: use-package-defaults type not updated for added keywords :pin,
 :ensure etc
Date: Sat, 10 Dec 2022 11:41:42 +0100

The type of `use-package-defaults` does not include the keywords :pin and :ensure, since these are added to `use-package-keywords` after the declaration of the former.

As a consequence these keywords cannot occur in `use-package-defaults` when using the interactive customisation interface, and since they are present in the default value, the `test-custom-opts` test fails with a type mismatch:

variable: use-package-defaults
   value: ((:config '(t) t) (:init nil t) (:catch t (lambda (name args) (not use-package-expand-minimally))) (:defer use-package-always-defer (lambda (name args) (and use-package-always-defer (not (plist-member args :defer)) (not (plist-member args :demand))))) (:demand use-package-always-demand (lambda (name args) (and use-package-always-demand (not (plist-member args :defer)) (not (plist-member args :demand))))) (:ensure (list use-package-always-ensure) (lambda (name args) (and use-package-always-ensure (not (plist-member args :load-path))))) (:pin use-package-always-pin use-package-always-pin))
    type: (repeat (list (choice :tag "Keyword" (const :disabled) (const :load-path) (const :requires) (const :defines) (const :functions) (const :preface) (const :if) (const :when) (const :unless) (const :no-require) (const :catch) (const :after) (const :custom) (const :custom-face) (const :bind) (const :bind*) (const :bind-keymap) (const :bind-keymap*) (const :interpreter) (const :mode) (const :magic) (const :magic-fallback) (const :hook) (const :commands) (const :autoload) (const :init) (const :defer) (const :demand) (const :load) (const :config)) (choice :tag "Default value" sexp function) (choice :tag "Enable if non-nil" sexp function)))

There are various ways to fix this. Easiest is probably to cease pretending that :pin and :ensure are somehow special and just include them in `use-package-keywords` from the start instead of adding them afterwards.

Alternatives include making the defcustom type less specific and allow any keyword, or modifying that type after adding keywords (a bit messy).

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: 59941-done <at> debbugs.gnu.org
Cc: John Wiegley <johnw <at> newartisans.com>,
 Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: use-package-defaults type not updated for added keywords :pin,
 :ensure etc
Date: Sun, 11 Dec 2022 17:10:47 +0100

A simple fix has been pushed to emacs-29 (4893a15631) -- closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.