From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: juri@linkov.net, bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 01:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 59935@debbugs.gnu.org Cc: juri@linkov.net X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: juri@linkov.net Received: via spool by submit@debbugs.gnu.org id=B.16706369996444 (code B ref -1); Sat, 10 Dec 2022 01:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Dec 2022 01:49:59 +0000 Received: from localhost ([127.0.0.1]:39770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3p02-0001fs-Ty for submit@debbugs.gnu.org; Fri, 09 Dec 2022 20:49:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:37218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3p01-0001fm-AR for submit@debbugs.gnu.org; Fri, 09 Dec 2022 20:49:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ozx-0001gh-G0 for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 20:49:57 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3ozu-00059H-NI for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 20:49:52 -0500 Received: by mail-wm1-x32a.google.com with SMTP id n9-20020a05600c3b8900b003d0944dba41so1078120wms.4 for ; Fri, 09 Dec 2022 17:49:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:from:content-language:subject:to :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=J/2hInnGfLS+pagH1DXH722BP/b3RAOGIoVHiN1t7nc=; b=ZAIT2vDaSvviepz5ARfVU2/7CHI7VjqK2PXKsR+GcysQCFJENJFWdNbz5mdvhFglCC KL4360p+4WZSmh/liiR7U31B7GcyfPN6ddielRntHStjODSxp6MfCulhUDQACQf0zC3i u4rCc6W7EsnYB9ti8mBqcMLOrHWIvW7rzrRGGHnTyU13Tul2wONlSnPx33nj5TvXebxq 5y/80cTCBJyX7YwZsn3B9yMZG45UplE8MZpxOW5EdkmiLtA79IkYFm31IfZ0/XwXbKqD xndaqm1l3hBwrkWxG9p/W9PtZFaEsH4imN83Ox/JC52pDUx0EiJqYIxYVaFq3iCq+qIn /5KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:from:content-language:subject:to :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=J/2hInnGfLS+pagH1DXH722BP/b3RAOGIoVHiN1t7nc=; b=k+R6cEVaN/s6FevkN7mnoRRP7KpvrlxOqwKmQPAyOuT+XlrECzA0dNxshkI+tyHjSV Gbyhj9+Irj+wAvZDzS0p32eVY+q+ogG+4JiOlAUy+3DRazruDH5NqcA5yGyHVQfGa7Tr EJXAv5pPxgsLEef/J0jSGN/GHx8nW4HCxji7D9W9iQ+HYM6TGBNM6+pdgMrrk5xBpfX1 dCEi6T74en8nTOXJNbPkGuaoIllWVR60UfsFR72Ua18RGVIawlFI2hq8F9saPjJqXaji QF/HX0k+M0qupRXadJUdbLrnL0YQqoI4uN9b+Br1UH2KxWbD7DzovWlw113gAgZ25xre VSSA== X-Gm-Message-State: ANoB5plb6tUXhfdjO6Y+N03Z1eUb9U0KRUmDzYQVWW+YdTrW3ta1kJnH 1tK78chlH0wl3rujUKALTU1Pixmq8w0= X-Google-Smtp-Source: AA0mqf4KkPpSKmLg4aMILlD6mfvQobRFO2dcM+/L/uppGR/MqqFlYz1rko70Z0W6x1Sx6YV5eglCWQ== X-Received: by 2002:a05:600c:500b:b0:3cf:6d5b:8768 with SMTP id n11-20020a05600c500b00b003cf6d5b8768mr6521828wmr.8.1670636989154; Fri, 09 Dec 2022 17:49:49 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t2-20020a1c7702000000b003cffd3c3d6csm1278996wmi.12.2022.12.09.17.49.48 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 17:49:48 -0800 (PST) Message-ID: Date: Sat, 10 Dec 2022 03:49:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US From: Dmitry Gutov Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) X-Debbugs-Cc: juri@linkov.net When you invoke 'C-x p C-b', there's a noticeable pause before the buffer list is displayed. It's ~400ms over here when there are 46 non-hidden buffers in the running session. What I think is happening, the predicate is called 46, which in turn calls (project-buffers pr) 46 times, and that ends up being 46 times slower than one might have anticipated. Not sure what's the best fix here (especially in time for the release), but if the FILTER-PREDICATE arg to list-buffers-noselect turned into a factory function (e.g. FILTER-PREDICATE-MAKER), that would be one solution. Another would be to only leave the legacy codepath: it's not affected, project-buffers is only called once there. Curiously, though, it shows a different list of buffers. It also includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look into that either way. And the patch is this: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 016dfdd5b4..ad49df0423 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1342,16 +1342,13 @@ project-list-buffers (interactive "P") (let ((pr (project-current t))) (display-buffer - (if (version< emacs-version "29.0.50") - (let ((buf (list-buffers-noselect arg (project-buffers pr)))) - (with-current-buffer buf - (setq-local revert-buffer-function - (lambda (&rest _ignored) - (list-buffers--refresh (project-buffers pr)) - (tabulated-list-print t)))) - buf) - (list-buffers-noselect - arg nil (lambda (buf) (memq buf (project-buffers pr)))))))) + (let ((buf (list-buffers-noselect arg (project-buffers pr)))) + (with-current-buffer buf + (setq-local revert-buffer-function + (lambda (&rest _ignored) + (list-buffers--refresh (project-buffers pr)) + (tabulated-list-print t)))) + buf)))) (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 59935@debbugs.gnu.org Cc: juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16706378017355 (code B ref 59935); Sat, 10 Dec 2022 02:04:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 02:03:21 +0000 Received: from localhost ([127.0.0.1]:39830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3pCy-0001uZ-Lc for submit@debbugs.gnu.org; Fri, 09 Dec 2022 21:03:20 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:37624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3pCw-0001uT-W7 for 59935@debbugs.gnu.org; Fri, 09 Dec 2022 21:03:19 -0500 Received: by mail-wr1-f53.google.com with SMTP id co23so6937663wrb.4 for <59935@debbugs.gnu.org>; Fri, 09 Dec 2022 18:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=H69fy8EjEV9xTokfuhBD3r2tl1c11E8UjpthnQzMdxk=; b=DP1fYLGMztzchBCL8B7RfexMyDtVHkX/SLXXvXoGpE77nEx3+XruNMSvENJad+iwN3 aRlWe4haRa98nsowCsYsyi7qt8WSXbN4N62SYzoE5PblAeBjF2bWdYMF4usnoClfiu5t jc6g8ouEFtkLybPHyq9Xq1c1ukS6U7lJZ1lRxnEySY3qlp8Rqa4r5AOeW73nO/PB79lO oEIQtmrtjlT++g4GG6tGjNgSKZIX7+N/vnySzBePotNka1kLkPduQROkk2e6wUR29Z2+ 07VbxjBAXOyRxwqDs+iwGOtlAL7+0IYAlen1mgPK8nkdTJf7ks7LjvyHVCAwOPeB7kRO Y4BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=H69fy8EjEV9xTokfuhBD3r2tl1c11E8UjpthnQzMdxk=; b=6ws+mznAwUpelDKQfcC5dk7m6LrpkuAW6K7HUFccQ0VbrlufHH5UiTVdo9uKq2puPx FYRxG40oitlLabd7En0QPH30xf3RFytdL4Y/BdFm2ymCHdFs72UMDnjjPmjn5fTddD8d i4Y7daC0QVTTZZyAXhVg0ELfw6diOEJoxyYCdnWE5dZCNXl34koBWXasXO5UBspm/8XU MrvhQ9TP7y2Hgg/DSy6F0bx4n4yFd+4kogzmOVGQr62TB9ylJcg3ON0XjiaNip9YgXyW bTyCCwvL/zA1gSzpu+YjO/7jPcPF3e8eXXxQHw7l0mHXY37aLtgi9SopOsuls2zmpvfH jO0w== X-Gm-Message-State: ANoB5pl/LuUGgTzlkLXcr3+2rMh8VxenHvnqIyiGEJbIWs3jEo5diAA5 FEQSXzGzggCVyqTNkEhMJ9/z2aN35j0= X-Google-Smtp-Source: AA0mqf5Ie5w/8+eFHnJEIr9P03A/EZ/cQfHqo1ksbXG4WLD9rxLWovC9AnxaZ/nWticH6bNX9CHoIQ== X-Received: by 2002:adf:a1c3:0:b0:24b:b74d:8012 with SMTP id v3-20020adfa1c3000000b0024bb74d8012mr1793327wrv.18.1670637793055; Fri, 09 Dec 2022 18:03:13 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l5-20020adfe9c5000000b0023c8026841csm2644638wrn.23.2022.12.09.18.03.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Dec 2022 18:03:12 -0800 (PST) Message-ID: Date: Sat, 10 Dec 2022 04:03:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US From: Dmitry Gutov References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 03:49, Dmitry Gutov wrote: > Curiously, though, it shows a different list of buffers. It also > includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look > into that either way. The combined fix for both can be this: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 016dfdd5b4..835ab07e50 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1340,18 +1340,21 @@ project-list-buffers start with a space (which are for internal use). With prefix argument ARG, show only buffers that are visiting files." (interactive "P") - (let ((pr (project-current t))) + (let* ((pr (project-current t)) + (fetcher (lambda () + (cl-delete-if-not + (lambda (b) + (or (buffer-file-name b) + (string-match-p "\\`[^ ]" (buffer-name b)))) + (project-buffers pr))))) (display-buffer - (if (version< emacs-version "29.0.50") - (let ((buf (list-buffers-noselect arg (project-buffers pr)))) - (with-current-buffer buf - (setq-local revert-buffer-function - (lambda (&rest _ignored) - (list-buffers--refresh (project-buffers pr)) - (tabulated-list-print t)))) - buf) - (list-buffers-noselect - arg nil (lambda (buf) (memq buf (project-buffers pr)))))))) + (let ((buf (list-buffers-noselect arg (funcall fetcher)))) + (with-current-buffer buf + (setq-local revert-buffer-function + (lambda (&rest _ignored) + (list-buffers--refresh (funcall fetcher)) + (tabulated-list-print t)))) + buf)))) (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 08:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167065989221485 (code B ref 59935); Sat, 10 Dec 2022 08:12:02 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 08:11:32 +0000 Received: from localhost ([127.0.0.1]:41337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3uxH-0005aT-Ss for submit@debbugs.gnu.org; Sat, 10 Dec 2022 03:11:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3uxF-0005aK-Ok for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 03:11:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ux8-0005v7-Tr; Sat, 10 Dec 2022 03:11:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=W+RqFPCPtJ2p2iMSWJNwvx/DAFgwFnYqKxuvfFxju38=; b=DkQLu0l/fNCy 1FwjUT3vC+OdaNWQJtMPF2KQfRZ3U9ZgVULopdxee9EceemZG4bYskmjbNsXflMji+yIZwdaY8Fek HpX/VrkeoM9LrGofJb5AqgWOjCNZ+FhHwZXatKYgV1FG0s2Pw+zZ95smT3ofG8zXWWMP1Cw05bC/f FpDxAi7sAWdgns5stXnyVDam2mCu6/C6ZeFa7yImIMu72AQlVE1Cb32gfRKU5h5uVVzNq7v21aMOv oXns36eoXaVXrD7/9c0O4xxgJZFglfJMsYwIIok9uexx83Cy83UrNliMFDwaASI8Yqdu9S8/x2+IL WmfDyJ6ysS0qBghS2tyf2A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ux5-00070I-Nc; Sat, 10 Dec 2022 03:11:22 -0500 Date: Sat, 10 Dec 2022 10:11:15 +0200 Message-Id: <83o7sby8yk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Sat, 10 Dec 2022 03:49:47 +0200) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: juri@linkov.net > Date: Sat, 10 Dec 2022 03:49:47 +0200 > From: Dmitry Gutov > > When you invoke 'C-x p C-b', there's a noticeable pause before the > buffer list is displayed. It's ~400ms over here when there are 46 > non-hidden buffers in the running session. > > What I think is happening, the predicate is called 46, which in turn > calls (project-buffers pr) 46 times, and that ends up being 46 times > slower than one might have anticipated. > > Not sure what's the best fix here (especially in time for the release), > but if the FILTER-PREDICATE arg to list-buffers-noselect turned into a > factory function (e.g. FILTER-PREDICATE-MAKER), that would be one > solution. > > Another would be to only leave the legacy codepath: it's not affected, > project-buffers is only called once there. > > Curiously, though, it shows a different list of buffers. It also > includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look > into that either way. I'm not following. Are you saying that the problem is that the FILTER-PREDICATE argument to list-buffers-noselect calls project-buffers for each buffer? If so, I don't understand why a trivial change to project-list-buffers could not call project-buffers just once, and then reuse the value in the call to list-buffers-noselect both as the BUFFER-LIST argument and (if needed) in the FILTER-PREDICATE argument, using memq. If this is not the problem, then what is? > And the patch is this: Consequently, I don't understand the rationale for this patch, nor for the combined one you posted later. Please elaborate. P.S. Btw, if you are not sure the multiple calls to project-buffers is the reason for the slow operation, how about profiling it to be sure? We may be barking up the wrong tree. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167066926823115 (code B ref 59935); Sat, 10 Dec 2022 10:48:02 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 10:47:48 +0000 Received: from localhost ([127.0.0.1]:42043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xOW-00060j-26 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 05:47:48 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:43942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xOU-000606-Ka for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 05:47:46 -0500 Received: by mail-wm1-f42.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so1565023wms.2 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 02:47:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=jh/u80AIYFpn9phWIm/nEScxDpQDDADFf3xPLJ28+CI=; b=DA4h2RRzdQnOwnpnjJ/2veRkK3zOx8QVoAhwCZwEyv7WYrzfLhMgFVrTcLC6EE7XLs G/Mgt1IvJIvO5KCqdi5OjF/x6/TZZP1G66SUqkFZCxZSrFeKBGGwYxCsq+mtK9cnWJjU 2hICmIrqIqPCRgbtr86lLp+2hzRj4NOB5VZouWoy+jIf4b9l01qiP6Cdfyfkg/y/OfCP Sa2CDTixoAhDlsK6MkH3LkxBo+78Kz/aMp8guKa01mUOd/ubmdOew2U4gBcZ/p16FpGm KD+WELDMA7o8FQcLzee84qbVIuTM8BjWSc+H66v6vCnEyvI563etLWkByPFlekfDIqXM LeIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jh/u80AIYFpn9phWIm/nEScxDpQDDADFf3xPLJ28+CI=; b=1tgmhu181MNcOPx0e1OPtNx83S2YpF5WtukNFFiia4k0n7t/6bC3UJWwTR0UEeIm2S r7Kxw23kDhcyry0wmZ/C7QtwA2VvPUfFYv9U6dsfkbPndVSRb85aCf9/nCyuvmfvyAdo IcQlbCGXdfwsts9PnYGXMIdF7MPFue99KfRHTxrMsYquX6nfcQQnhi09Tq8/+i/Q4xIA wCd4eyKBUqldLlcV94MAb9ycs7Rd5piHPXuV1YngoYR2QGN/aZmqCwmkYyBjEB0pPoaX X4VxOMnAFI6HFFtaq4TIB5faWmSWKYFNhoEVtMYgkubDRFkYMPTSDnRGsQASa+JFaBsV Jg/Q== X-Gm-Message-State: ANoB5pmez0K2DirZUPls4dJaV5sp9eL4B7XqZp5TOB1lZkfwhGAhIScm N6P8lWL5EUWFGQk7uozJzR8= X-Google-Smtp-Source: AA0mqf5hhqsUDKB6DB0sh/4o7vT9WVXl4wF0RZu1cxZtszStqNQdR6cjvSvBOvFoY4EM1oKlnvOMlQ== X-Received: by 2002:a1c:7c18:0:b0:3cf:a6d9:7b3c with SMTP id x24-20020a1c7c18000000b003cfa6d97b3cmr7125959wmc.21.1670669260544; Sat, 10 Dec 2022 02:47:40 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c66-20020a1c3545000000b003d09150b339sm2485248wma.20.2022.12.10.02.47.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 02:47:39 -0800 (PST) Message-ID: <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> Date: Sat, 10 Dec 2022 12:47:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83o7sby8yk.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 10:11, Eli Zaretskii wrote: > I'm not following. Are you saying that the problem is that the > FILTER-PREDICATE argument to list-buffers-noselect calls > project-buffers for each buffer? Yes. > If so, I don't understand why a > trivial change to project-list-buffers could not call project-buffers > just once, and then reuse the value in the call to > list-buffers-noselect both as the BUFFER-LIST argument and (if needed) > in the FILTER-PREDICATE argument, using memq. If we just do that, pressing 'g' will only show the buffers that belonged to the project when project-list-buffers was called. And not necessarily the *current* list of project buffers. The previously attached patches solved that problem. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 11:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.1670670749810 (code B ref 59935); Sat, 10 Dec 2022 11:13:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 11:12:29 +0000 Received: from localhost ([127.0.0.1]:42176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xmP-0000D0-BU for submit@debbugs.gnu.org; Sat, 10 Dec 2022 06:12:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3xmM-0000Cq-Kx for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 06:12:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3xmG-0006xr-Eh; Sat, 10 Dec 2022 06:12:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wERz50MFdsvmW1paD/O5QuPmY0dgrtz4ZDcsznhtm90=; b=Vttpk1ittSw2 zXtd7FQxNqCOPLPcxPxOZs7hIjJxxTwjAObY2hYiffj0EBrdpYS6zD2hu8AxWE0KcHZJGXvBgkHZb WeNjv3L1NubRtmHQYOm+PBH1VKD34A0F+JGdpdoojYZTN8S6j2G3pluMe6pirFYFN3Biq1FchNEGU 7FgG55OyBTKwLdI5sSrBs/RcHB+epTiH80AvGZVcPQVv6Kt2uoPa3jDMFpg8TRfoiV0ifFS4z4RGw X3TrIA58GSPrbOIzopxN0/x4SZsMyBcqMR6qS0BI8EU3H2OtODLXA0Z0mlfxuPk89dE6VPorSzvtY hSVpzGEmGHQSsilx3HXKMw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3xmF-00040n-Ha; Sat, 10 Dec 2022 06:12:19 -0500 Date: Sat, 10 Dec 2022 13:12:14 +0200 Message-Id: <838rjfy0kx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> (message from Dmitry Gutov on Sat, 10 Dec 2022 12:47:38 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Dec 2022 12:47:38 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > > If so, I don't understand why a > > trivial change to project-list-buffers could not call project-buffers > > just once, and then reuse the value in the call to > > list-buffers-noselect both as the BUFFER-LIST argument and (if needed) > > in the FILTER-PREDICATE argument, using memq. > > If we just do that, pressing 'g' will only show the buffers that > belonged to the project when project-list-buffers was called. And not > necessarily the *current* list of project buffers. > > The previously attached patches solved that problem. I don't understand: how is 'g' relevant? You were talking about 'C-x p C-b' in your original message. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16706722702746 (code B ref 59935); Sat, 10 Dec 2022 11:38:02 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 11:37:50 +0000 Received: from localhost ([127.0.0.1]:42281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3yAw-0000iE-8P for submit@debbugs.gnu.org; Sat, 10 Dec 2022 06:37:50 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3yAs-0000i0-5U for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 06:37:49 -0500 Received: by mail-wm1-f45.google.com with SMTP id ay40so1689828wmb.2 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 03:37:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=A8TC6U5zuwP1i1wjZSBk7iIo3OyqEexsYvmMrcVmkgk=; b=npqCbwQZ4EBCnZiFzzvtO2yYpNh121pxHYCP4WOnDa/ldcNTiG/yZ6wcZyW6Atw1P9 RVN9e5bfa49/UySJpvQLx6zr+FnwQYTGa8BIoqAacUAMlGwkv743ZbtQore5YxVIUen5 IFISZrgv6guldOnn9FgqUOkm0y66CdMJGdLpnZJm2FNnzI9AqIBDiSyns61XAIjB3rzF +pGZAI6Nct60mUMWHJWdS4tKLEmgUU4kFpyyJsbb9Lm8W2A1krZ59jfU0Re0BtuMiP34 dLG6sz9Qa54AKOLfv7+G4jdFROO25mJ6XhSy3QfdoHVaR1oIuX6dvF+oEX2mpSsKtepH oV9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A8TC6U5zuwP1i1wjZSBk7iIo3OyqEexsYvmMrcVmkgk=; b=375GFoWqWWutUchJ0ZWEQMfy9UHuwTyvUGQpLCSkGHJ+2GgmGMHlCEIXW+3gI666jp V3C7dyACHn5Tp+GW6yrRwMWmL+1KpPXOz+PXFbRUGfeV1MHiBjBRVPF1foammFXp+T6G iZB/E6W6ln4gNKfRcZ+l7m9DqGgraKE53DK4uQzC79AFmcnAcgJrIejz37c8B3gkux20 fehdXvr1UKHIyzH4TAIdYJ2lhpncNiZuEdfI7oey2AkMP61XeygwEm5PuPDXf49jdIfW LrkUV7sAG2gABWhZOBKWsYBBaFQ1zm5aOKkqHMb6wr0eX7rXcV6OBgC6vZeQAtEOYetb mS0w== X-Gm-Message-State: ANoB5pneIRsbKt/Svw6T88qx2VAB2dQTrZNbm/TQvlVF7SJRGd+6GUq3 0yZ/W6dlQQxN2U+4ws8w5zU= X-Google-Smtp-Source: AA0mqf4mAOK5oQZNg1ijjs9WvYZgC+u10kVEDAYxlr7LhGywBJkU8AUXExCWCg0mORZL9xmDhgYWbw== X-Received: by 2002:a05:600c:2d07:b0:3d1:ee3a:62ae with SMTP id x7-20020a05600c2d0700b003d1ee3a62aemr7345387wmf.8.1670672260069; Sat, 10 Dec 2022 03:37:40 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p17-20020a05600c359100b003c6b7f5567csm17763804wmq.0.2022.12.10.03.37.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 03:37:39 -0800 (PST) Message-ID: <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> Date: Sat, 10 Dec 2022 13:37:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <838rjfy0kx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 13:12, Eli Zaretskii wrote: >> Date: Sat, 10 Dec 2022 12:47:38 +0200 >> Cc:59935@debbugs.gnu.org,juri@linkov.net >> From: Dmitry Gutov >> >>> If so, I don't understand why a >>> trivial change to project-list-buffers could not call project-buffers >>> just once, and then reuse the value in the call to >>> list-buffers-noselect both as the BUFFER-LIST argument and (if needed) >>> in the FILTER-PREDICATE argument, using memq. >> If we just do that, pressing 'g' will only show the buffers that >> belonged to the project when project-list-buffers was called. And not >> necessarily the*current* list of project buffers. >> >> The previously attached patches solved that problem. > I don't understand: how is 'g' relevant? You were talking about > 'C-x p C-b' in your original message. 'C-x p C-b' creates a buffer which lists buffers. It also sets up revert-buffer-function in that buffer. And pressing 'g' in that new buffer should supposedly refresh that list of buffers appropriately. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167068285429747 (code B ref 59935); Sat, 10 Dec 2022 14:35:02 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 14:34:14 +0000 Received: from localhost ([127.0.0.1]:43098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p40ve-0007jj-3T for submit@debbugs.gnu.org; Sat, 10 Dec 2022 09:34:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p40vb-0007jb-4G for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 09:34:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p40vS-00078P-Ui; Sat, 10 Dec 2022 09:34:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PMfH5H0+W/Dt7igCrnQAQAHCGyGvwoyFizK42JhByLk=; b=rpLZfQky5gT9 prciJzSuYyHEIAJ3ZRUGnIebsJDXjMRYthWa7FUN9e5flwKiSM1Wyjn7d8wKo0QznqdpHH+QIPT9E 8bKUzoPl3y24fkntItb8BJ9gCI/LXjjF352fs90Lp3SlghpV62R6g7JylPwTKrAJZLLEdJ8pIrSJj LCo/0AYnGbVmsFoL9rXzt+uHDEfDPHOFiIZTO1w5vEVFDxk2Ky73R07RZkdA95nCHGH8zvv5fCAl5 Kg6qB6U9XR8kH1/XE5FzE25d5c63DJLe2B+Fuk0e72+Q4tPQxmUMszeSWgICzRyinbYpDYVty7ne+ TkO1YhFhqMIerBXrCEnDbA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p40vS-0005m9-DS; Sat, 10 Dec 2022 09:34:02 -0500 Date: Sat, 10 Dec 2022 16:33:59 +0200 Message-Id: <83h6y3wco8.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> (message from Dmitry Gutov on Sat, 10 Dec 2022 13:37:37 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Dec 2022 13:37:37 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 10/12/2022 13:12, Eli Zaretskii wrote: > >> Date: Sat, 10 Dec 2022 12:47:38 +0200 > >> Cc:59935@debbugs.gnu.org,juri@linkov.net > >> From: Dmitry Gutov > >> > >>> If so, I don't understand why a > >>> trivial change to project-list-buffers could not call project-buffers > >>> just once, and then reuse the value in the call to > >>> list-buffers-noselect both as the BUFFER-LIST argument and (if needed) > >>> in the FILTER-PREDICATE argument, using memq. > >> If we just do that, pressing 'g' will only show the buffers that > >> belonged to the project when project-list-buffers was called. And not > >> necessarily the*current* list of project buffers. > >> > >> The previously attached patches solved that problem. > > I don't understand: how is 'g' relevant? You were talking about > > 'C-x p C-b' in your original message. > > 'C-x p C-b' creates a buffer which lists buffers. It also sets up > revert-buffer-function in that buffer. > > And pressing 'g' in that new buffer should supposedly refresh that list > of buffers appropriately. OK, but I didn't suggest making any changes to revert-buffer-function set up by "C-x p C-b". You can still use process-buffers there, and it shouldn't slow down "C-x p C-b" itself, since the call to process-buffers that is part of revert-buffer-function is not supposed to be evaluated when you set revert-buffer-function. Right? Or what else am I missing? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 17:48:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16706944485935 (code B ref 59935); Sat, 10 Dec 2022 17:48:03 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 17:47:28 +0000 Received: from localhost ([127.0.0.1]:44188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p43we-0001Xf-4d for submit@debbugs.gnu.org; Sat, 10 Dec 2022 12:47:28 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:44587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p43wa-0001XJ-7i for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 12:47:24 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id DAC651C0003; Sat, 10 Dec 2022 17:47:17 +0000 (UTC) From: Juri Linkov In-Reply-To: (Dmitry Gutov's message of "Sat, 10 Dec 2022 03:49:47 +0200") Organization: LINKOV.NET References: Date: Sat, 10 Dec 2022 19:45:09 +0200 Message-ID: <86a63vi2lu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Not sure what's the best fix here (especially in time for the release), > but if the FILTER-PREDICATE arg to list-buffers-noselect turned into a > factory function (e.g. FILTER-PREDICATE-MAKER), that would be one > solution. I see only one solution: to replace the argument FILTER-PREDICATE with BUFFER-LIST-FUNCTION. >> Curiously, though, it shows a different list of buffers. It also >> includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look >> into that either way. > + (cl-delete-if-not > + (lambda (b) > + (or (buffer-file-name b) > + (string-match-p "\\`[^ ]" (buffer-name b)))) > + (project-buffers pr))))) Please try to copy the exact logic from list-buffers--refresh: (and (or (not (string= (substring name 0 1) " ")) buffer-file-name) (not (eq buffer (current-buffer))) (or file (not Buffer-menu-files-only)) From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167069998118929 (code B ref 59935); Sat, 10 Dec 2022 19:20:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:19:41 +0000 Received: from localhost ([127.0.0.1]:44582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Nt-0004vF-0V for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:19:41 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:44771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Nq-0004v7-UD for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:19:39 -0500 Received: by mail-wm1-f46.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso560118wmp.3 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 11:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=AbUV5cb70vvrNLlH9QA7F2kADoQmdY8bbq4QBzbOc4g=; b=gIaYa7PE7i/7fW8a/Iy9oaEM5HFhcF6MO+xGVaMRBAE02MN+i2pR7axuDKSz4B9Fve hqE0dbYMmKZqfcFXtmbG3NzbJQgC9/LxOBL1zeQUYfOGmInnRlTUEjvjKcpY4PWIS/h9 yf7M3cayVPb9+LkedsBcNcrjQ5H2ffrmMFaHZk7lM9qp6XXzrHAhtEG7NaxSkcw8LHOO UefmI+Jvt+1wHt/2sXgGjOuKNS5HhuT9eCAlSbMOqFFIWDKUGQMs2VitU87VjNtEXT99 bm7Kge7apz383m7vx+AZJytqoq58UMs0L6ZQkGyh/GIxZCJGnlmgZKE1dUlUIQck1g2o FZcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AbUV5cb70vvrNLlH9QA7F2kADoQmdY8bbq4QBzbOc4g=; b=XTMhBJVRw+xMKotucsRwlxl4uKdMN2uYcg6EwkZMZe32ITETGtXY8LAB5IuuCnFF1y rizihJqXnXIO5WkZMEBMmZ3FzChW79oKr2Nlkyf4h9ucXqB3BUFP74tst1qD+Gd3cNno FpQA7C9GpcOtpiVQlhPHubS/nyRxk4q63Y8qsaNOow2yX8vwVNYM5KBani8EwkK5bbNs gZaQZZ21zdtE2z8auXX2Q8yWXlAYnF2SQc9HrycYOehIJ/dln7TCy854/KAS137e63Ep 8lcYkD8oRrGOkeoCiwGy3g6tJln823RhJVGobGTo66nig2y4kgsKC93ZfEsZS0+7v8wC 1+Pw== X-Gm-Message-State: ANoB5pnsdV1cQvy+FR5n446779vRz3EIWb6N94brSg0HlVimWdoY8o8h BcrMdstLZF0zTUwT+LBZvHs= X-Google-Smtp-Source: AA0mqf6chQ5Q39a8YK8D6cbYvVa/pNp3Q9ro1gVx3FIBCBXo6Ou4hNvCy1efuvgvYxmqUGTayhxcLQ== X-Received: by 2002:a05:600c:2d07:b0:3d1:ee3a:62ae with SMTP id x7-20020a05600c2d0700b003d1ee3a62aemr8136492wmf.8.1670699972841; Sat, 10 Dec 2022 11:19:32 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id k32-20020a05600c1ca000b003b4ff30e566sm21348670wms.3.2022.12.10.11.19.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 11:19:32 -0800 (PST) Message-ID: Date: Sat, 10 Dec 2022 21:19:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83h6y3wco8.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 16:33, Eli Zaretskii wrote: > OK, but I didn't suggest making any changes to revert-buffer-function > set up by "C-x p C-b". You can still use process-buffers there, and > it shouldn't slow down "C-x p C-b" itself, since the call to > process-buffers that is part of revert-buffer-function is not supposed > to be evaluated when you set revert-buffer-function. Right? Or what > else am I missing? Then only the 'g' binding will remain slow. An improvement, of course. But if we go this route, then we don't use the "new" list-buffers-noselect convention either, so we might as well do the full fix. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070015319071 (code B ref 59935); Sat, 10 Dec 2022 19:23:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:22:33 +0000 Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Qf-0004xX-Gg for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:22:33 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:46737) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45Qa-0004xN-09 for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:22:32 -0500 Received: by mail-wr1-f51.google.com with SMTP id h11so8256649wrw.13 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 11:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=hNA3XTS5DPSVyhTn9bRvz8ndXP6Z0e0MigidvKOT658=; b=eNcwUoNzbXo2/0ldusv9rnsM0/VH8Yt3T0ogWUQ/Lme/w+qAHlGxxc7uIWA5iHdjKR BrJ34vTvcV7moQ9882xOYYRTIhYezAKfNabCh5BKbVxsmTw0edRyyTKaGl0ytN1eIYvy 04V1Xa+QzwF7cJPIOG7frheifMNpwEyGF6nXfNjnBS/4a6HAM9y6AehzkLTf3riyKo+w HO7FLgAAab1cv93ISmL+ew/hfpJ43JQjnahijbu+PeI376/TY1ai4nKigNybdxXyFNAW mJsVvuBa+0Y+hZycN0qguYWQ2yr6Ux2E2hasuYZx1Gv6VlsIKwzkLKr6cJihhTjTbeyr Mwhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hNA3XTS5DPSVyhTn9bRvz8ndXP6Z0e0MigidvKOT658=; b=FpS3MTHCwDXdPLX3lGSL6CYKezWi/rnE5rv6gtOpx7SJhZNDXGX84P5LSOEGZuTf65 DQL7XLq6Hke9lKw7EUpbuugRD5wPCqjdDlcV47ar5LXs9uF1WKHpGRtxFKONjOzupqfa xoM1sglht91KlhCEp+AHhwYLCYP7/ep0ykVlEiI49EG4jrEnpmw4Xycnu8VMLwsnOuKT nx728A4j8oicjMaBcG7Zb2CE34/pJPZVy75Oe/JKdvMTOjFOjH3Th04bGhXdt6Cxm56c yPplmFTrWUZkO5n+iqybu5JGHbUWtT50/hmP6Y3mZT0ILCrMT4guNX/D8Jtwr6Zbhvnd D8Iw== X-Gm-Message-State: ANoB5plLcYXZ1BZWKN6wiCG2H5d4eAQXUKVwmWEr+nKvMw62HqPpmUlP OkqfCFXBmLwryxE8rh8efnL95wdP0zE= X-Google-Smtp-Source: AA0mqf4bbVRkGJmVHBv0Dgusbt9Nao9uWZiCBcNxHhJ2XG0O6xn9eSASgN9dIFRO0le/BD9OJcxoQQ== X-Received: by 2002:a5d:6e87:0:b0:242:5057:8b15 with SMTP id k7-20020a5d6e87000000b0024250578b15mr5668312wrz.66.1670700142081; Sat, 10 Dec 2022 11:22:22 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p12-20020a056000018c00b002420a2cdc96sm4550579wrx.70.2022.12.10.11.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 11:22:21 -0800 (PST) Message-ID: <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> Date: Sat, 10 Dec 2022 21:22:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86a63vi2lu.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 19:45, Juri Linkov wrote: >> Not sure what's the best fix here (especially in time for the release), >> but if the FILTER-PREDICATE arg to list-buffers-noselect turned into a >> factory function (e.g. FILTER-PREDICATE-MAKER), that would be one >> solution. > > I see only one solution: to replace the argument FILTER-PREDICATE > with BUFFER-LIST-FUNCTION. Ah yeah, that should also work. >>> Curiously, though, it shows a different list of buffers. It also >>> includes "hidden" buffers - diff-syntax, Echo Area, etc. We should look >>> into that either way. >> + (cl-delete-if-not >> + (lambda (b) >> + (or (buffer-file-name b) >> + (string-match-p "\\`[^ ]" (buffer-name b)))) >> + (project-buffers pr))))) > > Please try to copy the exact logic from list-buffers--refresh: > > (and (or (not (string= (substring name 0 1) " ")) > buffer-file-name) > (not (eq buffer (current-buffer))) > (or file (not Buffer-menu-files-only)) Do you have the time to finish the fix yourself? It was your feature, after all. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070135819848 (code B ref 59935); Sat, 10 Dec 2022 19:43:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:42:38 +0000 Received: from localhost ([127.0.0.1]:44683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45k6-0005A4-46 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:42:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45k1-00059y-E4 for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:42:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p45ju-0002s6-Jf; Sat, 10 Dec 2022 14:42:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2qfADLqih9iRVG5/tMVhphmoX8SNHM4Pv8StfAfRtrA=; b=aave/so/WMjB X2lEpGn9vJQ+6GZOnHtFxshUs2L9pdfAHi8Q6gcvtywZndrGSMSULlsGMlC8sMXJbFDixATS7yfld ivi5tecSyhvN5f1J7YrJ1hCGGVMP77B/gQKvfOqxKtlh8mVZyFrP0U6Xwg1U2miT35kOujafKj2xj OXZ920iuC77CTx8KT5nBe3xzplE2mvx8i7yWVPnB9dJZumAY/9nx7kcLMjfTWotjCA9zAoBxn2r/Z rxLuT9Xravqm9ip82rrDtC94j4G85uKsYoHR2a4rRNnSNavM1RPd81B8Dppie2ROUdYjak5cFuICd Kg98roiIW5VzqdHbx7/oRg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p45jt-0006jc-SJ; Sat, 10 Dec 2022 14:42:26 -0500 Date: Sat, 10 Dec 2022 21:42:20 +0200 Message-Id: <834ju3vyeb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Sat, 10 Dec 2022 21:19:30 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Dec 2022 21:19:30 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 10/12/2022 16:33, Eli Zaretskii wrote: > > OK, but I didn't suggest making any changes to revert-buffer-function > > set up by "C-x p C-b". You can still use process-buffers there, and > > it shouldn't slow down "C-x p C-b" itself, since the call to > > process-buffers that is part of revert-buffer-function is not supposed > > to be evaluated when you set revert-buffer-function. Right? Or what > > else am I missing? > > Then only the 'g' binding will remain slow. An improvement, of course. Why slow? it calls project-buffers only once. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070201820508 (code B ref 59935); Sat, 10 Dec 2022 19:54:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 19:53:38 +0000 Received: from localhost ([127.0.0.1]:44744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45uk-0005Ki-05 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 14:53:38 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p45uh-0005Kc-Vy for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 14:53:37 -0500 Received: by mail-wm1-f42.google.com with SMTP id r7-20020a1c4407000000b003d1e906ca23so970853wma.3 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 11:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=35UEx3HW7QBVRRwWhCSKwUm0vsaYq6OY9HMqQxCH9no=; b=GePGKjNYvTq3eQ5m7E7THg3CmJAXdvLBV+W9+4U/wNrR7IbiK1vgGUlFoZlbalfoJy rW77Kd2wsw0hhFKk5ZRQYOupHrcoANNuMZ/eIvqL9zye7T3VEIy/amTf5e6u1hITv/4M S3a2qGNeK0rBXXfEWvtZabcwo0EPngHlyKsnD0R0jcb6a99WzSQYTJ0WsxY/GWB32OTi h+PA2hFXxrkceyl16B07I35gzz+wn6TYd+uwZVPLHpt7AAwf4aXrJX9Di7ViXt4XhUnl vQsAj58MsKNd6g7MtF9jMPqaTN5/stgeuf4U45PenSWqbyt9gTY16jqUzq7wDdFMBIP5 HVAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=35UEx3HW7QBVRRwWhCSKwUm0vsaYq6OY9HMqQxCH9no=; b=Mnn7ehhiqMXpSEsxk6QtMsyRBR9jwkMCb9e0jlWhr20CKCbJFKLCfp454ecSluBZO+ 3uToP/uwQQzJ33gR9yqt9fqOzwS/eMEpGTEd4tKBFNJcJ/h1xy+/qUoZGIPQTf9hsnRS IUmPLwTILulGCnjTBP6Vs2PcJgFgOHj1Y3Ieaod61XiE/H7khiH4R0xGm6Fnan/cZtx1 SwXNjHJo2jxpZ++suWQq4TVOC9SCDyvTPIOm+ueuQZlzc+tOJwSUob86qbmdSUyClw/X NzssTR68kbEzWJ4ZX2/sHWAt37twL4/3aVgNICoB8FxwkNNaYO1JGGULxXA4WovQyGCC iSzQ== X-Gm-Message-State: ANoB5pkLBvonFvnROiw0ahv3Hi1eB5GNy2d7OgFsm/EFq2SqqXgjHbGr wU0tBE+wSY9gyf52j4Kyg/I= X-Google-Smtp-Source: AA0mqf6Nz1F7LIbi1rI+AVe5R9HebKFPfBGyIlsvMXHUw8Kg3gHjCQqPft9xoP4FzDgLPAhjHnaQ5Q== X-Received: by 2002:a05:600c:4f85:b0:3cf:93de:14e8 with SMTP id n5-20020a05600c4f8500b003cf93de14e8mr8302639wmq.39.1670702010450; Sat, 10 Dec 2022 11:53:30 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id r5-20020a05600c35c500b003a2f2bb72d5sm4787572wmq.45.2022.12.10.11.53.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 11:53:30 -0800 (PST) Message-ID: <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> Date: Sat, 10 Dec 2022 21:53:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <834ju3vyeb.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 21:42, Eli Zaretskii wrote: >> Date: Sat, 10 Dec 2022 21:19:30 +0200 >> Cc:59935@debbugs.gnu.org,juri@linkov.net >> From: Dmitry Gutov >> >> On 10/12/2022 16:33, Eli Zaretskii wrote: >>> OK, but I didn't suggest making any changes to revert-buffer-function >>> set up by "C-x p C-b". You can still use process-buffers there, and >>> it shouldn't slow down "C-x p C-b" itself, since the call to >>> process-buffers that is part of revert-buffer-function is not supposed >>> to be evaluated when you set revert-buffer-function. Right? Or what >>> else am I missing? >> Then only the 'g' binding will remain slow. An improvement, of course. > Why slow? it calls project-buffers only once. You're looking at the "legacy" code path. Where emacs-version is < 29. In the "new" one revert-buffer-function uses the filter-predicate argument we pass to list-buffers-noselect. Which is (lambda (buf) (memq buf (project-buffers pr))) From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 20:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070308621184 (code B ref 59935); Sat, 10 Dec 2022 20:12:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 20:11:26 +0000 Received: from localhost ([127.0.0.1]:44819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p46By-0005Vb-BG for submit@debbugs.gnu.org; Sat, 10 Dec 2022 15:11:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p46Bw-0005VR-0D for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 15:11:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p46Bq-0002Cx-A2; Sat, 10 Dec 2022 15:11:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GfXZXKmpVUKgGDSTjF0qeKtJbnGgYO9mOsdDyyMOfiI=; b=ZzTwpzPCY9nV OkG2W3LVPae32b2FTlQbk4byEVO4sjB8noBKMl26V0uzx9y7A6DkpmIyfIQjlSi59avMYcPCeUH1F mMMniFCAX+BbF4IH9nudwU2oLTvRz5yQhpkGjWNmZ3vUadbYdJWT9XvAhjFaLxGJP500EjVlPf1nV RiYEW/LffaCN0WhtIJjc8dRWdC6CyDopXAuaK/19YneuuSKVLJmq/CTrvu1kn0YG/DY4dgBXkyS6n 6V3rBUe0lF0Rr7XESaqFXU1U3OjPz9eGquNam+D8aLV0qhJ08JgO2FNgw0QX8fq6g6tzYn2agaNZT 984yckHS5SCtX9hNZsXKcQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p46Bp-0006V3-NV; Sat, 10 Dec 2022 15:11:18 -0500 Date: Sat, 10 Dec 2022 22:11:13 +0200 Message-Id: <831qp7vx26.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> (message from Dmitry Gutov on Sat, 10 Dec 2022 21:53:28 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Dec 2022 21:53:28 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 10/12/2022 21:42, Eli Zaretskii wrote: > >> Date: Sat, 10 Dec 2022 21:19:30 +0200 > >> Cc:59935@debbugs.gnu.org,juri@linkov.net > >> From: Dmitry Gutov > >> > >> On 10/12/2022 16:33, Eli Zaretskii wrote: > >>> OK, but I didn't suggest making any changes to revert-buffer-function > >>> set up by "C-x p C-b". You can still use process-buffers there, and > >>> it shouldn't slow down "C-x p C-b" itself, since the call to > >>> process-buffers that is part of revert-buffer-function is not supposed > >>> to be evaluated when you set revert-buffer-function. Right? Or what > >>> else am I missing? > >> Then only the 'g' binding will remain slow. An improvement, of course. > > Why slow? it calls project-buffers only once. > > You're looking at the "legacy" code path. Where emacs-version is < 29. I'm looking at the code you posted as the original one, which is identical to what I see on the current emacs-29 branch. That means Emacs 29, unless I'm seriously confused. > In the "new" one revert-buffer-function uses the filter-predicate > argument we pass to list-buffers-noselect. Which is > > (lambda (buf) (memq buf (project-buffers pr))) I see this in emacs-29: (setq-local revert-buffer-function (lambda (&rest _ignored) (list-buffers--refresh (project-buffers pr)) (tabulated-list-print t)))) So I still don't understand your fears. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Dec 2022 20:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167070379221638 (code B ref 59935); Sat, 10 Dec 2022 20:24:01 +0000 Received: (at 59935) by debbugs.gnu.org; 10 Dec 2022 20:23:12 +0000 Received: from localhost ([127.0.0.1]:44875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p46NL-0005cw-Qp for submit@debbugs.gnu.org; Sat, 10 Dec 2022 15:23:12 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:35484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p46NJ-0005cp-00 for 59935@debbugs.gnu.org; Sat, 10 Dec 2022 15:23:10 -0500 Received: by mail-wm1-f53.google.com with SMTP id h8-20020a1c2108000000b003d1efd60b65so2203667wmh.0 for <59935@debbugs.gnu.org>; Sat, 10 Dec 2022 12:23:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=oRaNEWRtrZctWSdoxCu5JozMwe8o7cDWOXg1SKQIcFY=; b=RjvHirvAMJOAosLo0Wf2NlSpSU4F//x3hfwBake+0OI6LkLur0Z9LqS4EUAHY8F2F5 r9+Q9+yTCjuFeJeMZW/agYM5Oq3ZzwHzxTfsB1ufjk/hV+vtOdFInFDEJ1XPiyrOzxVe cnt/u5wwQmwp8fdL6p/dDsh8vhVPc5u/jzt7jAjPI4aNOQ/dIlVzPiQBBzebzwRcl+FB htMhSo+BfA82VyDCxW76ogBG9ucn0jyIOx7ZVYNI8wMgWUHy2NtxK7ltkDSmLlgpYdBG adBZNdyWcbbOtn4bj868qJgd3HVQ4njYubvcAgtOZShx7/4e0RbuuEYujlubxLWVLFHZ Xw6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oRaNEWRtrZctWSdoxCu5JozMwe8o7cDWOXg1SKQIcFY=; b=M7Yq/hpQtElzlr8mqk68UKqSFJ5xV8pn+uZh4tC+UnfUbCmYxTguydcyAKpbl3/lbW LICMv5C2vId7RYuz8WcUsuT9B0AG93hWIkMzbNNmuIrMlNjE1/klYmN/aE9CA6526Mhq s5N07McLSNFMnrRPT4RFJ6UpRMl9Brn66jl+melEvhlWLVVP+KdElm6yLjSyjvPdTTvF IRPTRajjLCDJHF5dZ8j2N02X4uOjPAI4cTQaBRQosOkoTnOjMHB0UM+Nxtr8NGZMfOJy dmYTzetLpSkEVj+YbPdr8Ync1s2G1XV84jKkjjTNcC61Hyy4U049aq2rdhyMTmLwOezB RE/w== X-Gm-Message-State: ANoB5pnAGe47CIPy5xycg39kNwS5FXloxw+B8TGF90Rux8yqvyhkzmdF SM+KQgzp9b20mzmSdDsefVI= X-Google-Smtp-Source: AA0mqf7bWE3mEDZLISSLEu01DcaXx4W6i6bCp9px6jEmX7FgT0zvhSvqK7XbQaWpUbLhnbqv5VP6ug== X-Received: by 2002:a05:600c:502c:b0:3cf:900c:de6b with SMTP id n44-20020a05600c502c00b003cf900cde6bmr8494734wmr.15.1670703783194; Sat, 10 Dec 2022 12:23:03 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j4-20020a05600c410400b003cfbbd54178sm18832380wmi.2.2022.12.10.12.23.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 12:23:02 -0800 (PST) Message-ID: <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> Date: Sat, 10 Dec 2022 22:23:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <831qp7vx26.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 10/12/2022 22:11, Eli Zaretskii wrote: > I see this in emacs-29: > > (setq-local revert-buffer-function > (lambda (&rest _ignored) > (list-buffers--refresh (project-buffers pr)) > (tabulated-list-print t)))) > > So I still don't understand your fears. That's the (version< emacs-version "29.0.50") branch. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167073955920429 (code B ref 59935); Sun, 11 Dec 2022 06:20:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 06:19:19 +0000 Received: from localhost ([127.0.0.1]:46107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4FgE-0005JR-T2 for submit@debbugs.gnu.org; Sun, 11 Dec 2022 01:19:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4FgA-0005JG-SN for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 01:19:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Fg4-0007Qa-TH; Sun, 11 Dec 2022 01:19:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VRQAUoI0rzjfr7v9NxrzjE/NsALdJ1gjKxDLfvDbIjU=; b=Wk1bv/IRR6N9 wQCgvWb+shUeHe7PylrX5LpupZ6GIfMm5yN5nmHBG59tyHOzAKgak+bTH8rLRiqJn6K91K/8SCh5/ 16XDlm5D5PdZ8sQ9aXGgL0dIi3wr5vpeMZcC372gPpc4FX0VpQF2Sw3sSU3tHUW8kyzZR9HXaqZjx cbRw2gkz1uvZbGvHdy3z12Q6yfpQaxF+6ohTQ1y5fNBw4GYjvTCCu3dTg9j6DAALsVDw/lOV07SyZ Tg8iM5x6pr12i2xVb5gxmsMOXvx2BCqaFQl0AJrfpvj+Z9jlLy5TvUbbg+3kBCQT18f6EFnTTnifm giG5ZTRdZH5eUhtjq5R0RQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Fg4-0004Zo-6N; Sun, 11 Dec 2022 01:19:08 -0500 Date: Sun, 11 Dec 2022 08:19:05 +0200 Message-Id: <83v8miv4x2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> (message from Dmitry Gutov on Sat, 10 Dec 2022 22:23:01 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Dec 2022 22:23:01 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 10/12/2022 22:11, Eli Zaretskii wrote: > > I see this in emacs-29: > > > > (setq-local revert-buffer-function > > (lambda (&rest _ignored) > > (list-buffers--refresh (project-buffers pr)) > > (tabulated-list-print t)))) > > > > So I still don't understand your fears. > > That's the (version< emacs-version "29.0.50") branch. Still unclear. It almost looks like you don't _want_ me to understand. A detailed explanation with code fragments would be much more effective. Anyway, I only entered this discussion because you asked about making some non-trivial changes on the release branch. If that is no longer an issue, I will gladly bow out of this. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167075420432288 (code B ref 59935); Sun, 11 Dec 2022 10:24:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 10:23:24 +0000 Received: from localhost ([127.0.0.1]:46286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4JUS-0008Oi-7O for submit@debbugs.gnu.org; Sun, 11 Dec 2022 05:23:24 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:36358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4JUP-0008Oa-T1 for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 05:23:23 -0500 Received: by mail-wm1-f50.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so2840945wma.1 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 02:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=K/rs4VbQ/jlPI9OcW+U//HmQpQsqLEwHtZrsoFKZ30k=; b=nyRNEDhnM7MPidQg8B6dhNS2g26TfrbINcvH/5Y7KewAC9nLEqkQ/Zk8ZvJH9iyw1N u/ylnCX76O8sXF5WRKaD7NclJE/9OxJetLr5uPSom3B+gPwxy14FmDxyRttUTTb+098v sixeMSwHvahIa1bhFFRuN8Mnn8YUQRsNPTZhbf2tROOD2/uTUP0wTTRHHydbdQ80nytj zTqV7CKecWAi6sliIE6O/IABsdszFbk5V2ucOMkrzM4NaSfzl2Gtiz8NA7v7eVp3+Awo 5mH+uswVybZUHfHBnEehGXDZU2CXjrtivnHjD6Uq0z+1qEhXKmblaQyOYtmY7X5qLqFO k5vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K/rs4VbQ/jlPI9OcW+U//HmQpQsqLEwHtZrsoFKZ30k=; b=rVE8pvic2Lq6VpcYw9nifxbRmlBqGH0ICjoDMbe+Z1IaBL3nAEueFWf8+16zgk531Y WlsJKIsC2MKuC7MruY5g5hu6UKS7ex6sB08IoxHnHPaLXrUBhjUiTW2L7BlfQv6bIrv0 vOkobo8DDtlvm++ZM2VZr0dHssLTbCc5eJs8z0DAguDuBqNvKrTb9E5YrDnGUZ8lR9R+ S/rwbtKLmInzhbSEI+kvJdR2e9A3RtZq4awf5a6vhS5Xkz4Ub34KxNYWXDrr9coopaWL 6kqlRWLlfHIcZ7pxy7ScZDG9ehOAZTob5kl1xqCxFbkNZopIMy3fjgq7VD7keT2gMVe0 9xFA== X-Gm-Message-State: ANoB5pmHVUQDUa/yMz2es2OdADwBXoYxLbeHEvsKCbUSI6mLerJk9yD4 ifDBPpnDLjVTGJp4yQilQFc= X-Google-Smtp-Source: AA0mqf6PZU5Rmnclmx66QsjmReT9ZKv0Op3JmhyS78yB+5FZSi83UXeDFZ1kbdB1PwuI7aWOizA+PA== X-Received: by 2002:a7b:c30e:0:b0:3cf:7397:c768 with SMTP id k14-20020a7bc30e000000b003cf7397c768mr9652219wmj.30.1670754195797; Sun, 11 Dec 2022 02:23:15 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p17-20020a05600c359100b003c6b7f5567csm21236259wmq.0.2022.12.11.02.23.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 02:23:15 -0800 (PST) Message-ID: Date: Sun, 11 Dec 2022 12:23:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> <83v8miv4x2.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83v8miv4x2.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 08:19, Eli Zaretskii wrote: >> Date: Sat, 10 Dec 2022 22:23:01 +0200 >> Cc: 59935@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> On 10/12/2022 22:11, Eli Zaretskii wrote: >>> I see this in emacs-29: >>> >>> (setq-local revert-buffer-function >>> (lambda (&rest _ignored) >>> (list-buffers--refresh (project-buffers pr)) >>> (tabulated-list-print t)))) >>> >>> So I still don't understand your fears. >> >> That's the (version< emacs-version "29.0.50") branch. > > Still unclear. It almost looks like you don't _want_ me to > understand. A detailed explanation with code fragments would be much > more effective. I think I've explained everything, and we are now going in circles. Why not look at the definition yourself? It's 12 lines. The function has two execution branches: one for the latest Emacs (at the moment), and one (the largest one) for older Emacsen. The main problematic behavior (low performance) is exhibited by the "latest" branch, which looks like this: (let ((pr (project-current t))) (display-buffer (if (version< emacs-version "29.0.50") ;; ... (list-buffers-noselect arg nil (lambda (buf) (memq buf (project-buffers pr))))))) > Anyway, I only entered this discussion because you asked about making > some non-trivial changes on the release branch. If that is no longer > an issue, I will gladly bow out of this. I expect Juri is going to argue for that later. For non-trivial changes in buff-menu.el, no less. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 10:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707560981247 (code B ref 59935); Sun, 11 Dec 2022 10:55:01 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 10:54:58 +0000 Received: from localhost ([127.0.0.1]:46323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Jz0-0000K3-Bj for submit@debbugs.gnu.org; Sun, 11 Dec 2022 05:54:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4Jyy-0000Jo-B7 for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 05:54:56 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Jys-0001Yw-C0; Sun, 11 Dec 2022 05:54:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wljDkU5A1zVoPk6ncfAONyq+r5r8PdeDma1vIcS63Bg=; b=pTAerx5KPUjs w4bsI7rOSV52rqbnohOaXpxbs4av7gZNm2nfFNz0euJhexO/0LEnAWAbX6I0VRwOt6uuAGK02ZrJC 3Pqt2WyiJqDwwWVivFLVEm2v+J8HcHnpYkd1EZZG7pDwacGlzEW0dp1JNEGnl/Xy2iSlCKclTXXID MT4D+N43MluYXE0LgOIuLT9OLUkaz9XcqFnUG/xiSPUiu+0sASrmww3dcU3+LGuEUhCrtFLq5oV02 4dIZHG577FAKnCnW2zGyKT3sg0nXosaJYSDGJCQTXSEJnE/pvZZ7K32nOzts1UqRDaYCVQOTiLQhz ccU5gqBFt7g7chaytzFiUw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Jyr-0004n3-Rj; Sun, 11 Dec 2022 05:54:50 -0500 Date: Sun, 11 Dec 2022 12:54:48 +0200 Message-Id: <83y1retdl3.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Sun, 11 Dec 2022 12:23:13 +0200) References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> <83v8miv4x2.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 11 Dec 2022 12:23:13 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > The main problematic behavior (low performance) is exhibited by the > "latest" branch, which looks like this: > > (let ((pr (project-current t))) > (display-buffer > (if (version< emacs-version "29.0.50") > ;; ... > (list-buffers-noselect > arg nil (lambda (buf) (memq buf (project-buffers pr))))))) Yes, I see that. I still don't understand: this can easily be changed to call project-buffers just once. > > Anyway, I only entered this discussion because you asked about making > > some non-trivial changes on the release branch. If that is no longer > > an issue, I will gladly bow out of this. > > I expect Juri is going to argue for that later. For non-trivial changes > in buff-menu.el, no less. I will wait for his comments, then. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167077635324268 (code B ref 59935); Sun, 11 Dec 2022 16:33:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 16:32:33 +0000 Received: from localhost ([127.0.0.1]:46939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PFg-0006JM-SJ for submit@debbugs.gnu.org; Sun, 11 Dec 2022 11:32:33 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:36746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PFf-0006JE-Am for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 11:32:31 -0500 Received: by mail-wm1-f54.google.com with SMTP id c65-20020a1c3544000000b003cfffd00fc0so3232197wma.1 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 08:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=QE52h1Mrdwhh0LVOaTTLUbscExU8IV371EYRdMDr4Ow=; b=h06nyHZefiadDPuurPc0ruQORYKIXcc0s3rI9rvxYaXEnYk9BDyYnT3DM4tjiiCCgt zrIPVDIFlHFkHQ5R/ee4U40l0aV76f9Sp7JwYp+zwSDQgP1ji8jRBC6E2mA/bz9Zwq6s tZsZQYtN3Egn/NfbU1ABaQ01nSjJi1NFGfFdkfXf0Vp0gBrHdYoArzPgLp4qZ+qu58E0 D6ldQCUuhPizGuTnL7fq7AXHYAxzxF/TSFfDEltMndVYwELsiE2wJ3dgmgDow6Co3MZL xvnuoPHReX3hNVHbhV0mZICz8H4OghwLscA1de+xY4kHomNRbVtYgCa1FUfi96FdsEnc lkFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QE52h1Mrdwhh0LVOaTTLUbscExU8IV371EYRdMDr4Ow=; b=tGBJDT+Y2womN/4kLFljQirahqSqCGdrlyNGJ9E9nd6UMv4ACD0u+l4Np59ctGfHz/ +veHOQSsmCyB4pZCBy/oijugcEaNhJue2tHDkEJrbFnHEAb+NfmR0GIDuaPZLZrtV1bg lwHX5oJ/H1BImR15YxdhbU3lMP15fTvLQkQl5pQNcbm7ykAzTABR6q379w9zBt9mAoAn dtjYiYu9lDA6ImJ7p8he1Zc9WMuDTz7zA33GTkJcg2ywWp0oF7O5jPuh2Z8sEhDitnQw mH/Mi1TtfqVykxa2rb8L0+36oSnCKEjn71fFQ6MdGeaMCFqnjc5mmNknJgbQzsFEtth8 KlxQ== X-Gm-Message-State: ANoB5pnS7kMxvTWStokUzAQ5BdJFKCU6QJyCuPcXpXJ6QtWClBinbbN/ T0bR9fUWBmLokvfMBTcb6SA= X-Google-Smtp-Source: AA0mqf7pYhr7qHTwmeS4f9j6UslG7iMzVMN49xdMyEZnSJ7Q3xLgAcPGI8C/grqLSnmAtg6qVOeeBQ== X-Received: by 2002:a05:600c:a54:b0:3cf:a41d:844b with SMTP id c20-20020a05600c0a5400b003cfa41d844bmr10478574wmq.5.1670776344252; Sun, 11 Dec 2022 08:32:24 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m37-20020a05600c3b2500b003cfd4cf0761sm6973178wms.1.2022.12.11.08.32.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 08:32:23 -0800 (PST) Message-ID: <1f3414b2-3150-789d-2340-ab928d0ee8b0@yandex.ru> Date: Sun, 11 Dec 2022 18:32:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <6e848f0c-0bb2-af8a-ad13-7b43e08be7c6@yandex.ru> <83v8miv4x2.fsf@gnu.org> <83y1retdl3.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83y1retdl3.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 12:54, Eli Zaretskii wrote: >> Date: Sun, 11 Dec 2022 12:23:13 +0200 >> Cc: 59935@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> The main problematic behavior (low performance) is exhibited by the >> "latest" branch, which looks like this: >> >> (let ((pr (project-current t))) >> (display-buffer >> (if (version< emacs-version "29.0.50") >> ;; ... >> (list-buffers-noselect >> arg nil (lambda (buf) (memq buf (project-buffers pr))))))) > > Yes, I see that. I still don't understand: this can easily be changed > to call project-buffers just once. Cue my very first response: If we just do that, pressing 'g' will only show the buffers that belonged to the project when project-list-buffers was called. And not necessarily the *current* list of project buffers. Though I guess there might be ways to avoid this, like creating a cache which will be invalidated in post-command-hook, something like that. >>> Anyway, I only entered this discussion because you asked about making >>> some non-trivial changes on the release branch. If that is no longer >>> an issue, I will gladly bow out of this. >> >> I expect Juri is going to argue for that later. For non-trivial changes >> in buff-menu.el, no less. > > I will wait for his comments, then. Let's. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 17:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167077894326151 (code B ref 59935); Sun, 11 Dec 2022 17:16:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 17:15:43 +0000 Received: from localhost ([127.0.0.1]:47146 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PvT-0006nj-0B for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:15:43 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:44843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4PvF-0006nQ-It for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 12:15:40 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 36514FF803; Sun, 11 Dec 2022 17:15:20 +0000 (UTC) From: Juri Linkov In-Reply-To: <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> (Dmitry Gutov's message of "Sat, 10 Dec 2022 21:22:20 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> Date: Sun, 11 Dec 2022 19:07:27 +0200 Message-ID: <86bko9na29.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain > Do you have the time to finish the fix yourself? It was your feature, after > all. Here is a complete patch tested for all possible cases: - emacs 28/29 - with/without file arg - with/without reverting --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=Buffer-menu-buffer-list-function.patch diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index 38d4fdad5fc..64af86558e4 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1321,18 +1321,31 @@ project-list-buffers start with a space (which are for internal use). With prefix argument ARG, show only buffers that are visiting files." (interactive "P") - (let ((pr (project-current t))) + (let* ((pr (project-current t)) + (buffer-list-function + (lambda () + (seq-filter + (lambda (buffer) + (let ((name (buffer-name buffer)) + (file (buffer-file-name buffer))) + (and (or (not (string= (substring name 0 1) " ")) + file) + (not (eq buffer (current-buffer))) + (or file (not Buffer-menu-files-only))))) + (project-buffers pr))))) (display-buffer (if (version< emacs-version "29.0.50") - (let ((buf (list-buffers-noselect arg (project-buffers pr)))) + (let ((buf (list-buffers-noselect + arg (let ((Buffer-menu-files-only arg)) + (funcall buffer-list-function))))) (with-current-buffer buf (setq-local revert-buffer-function (lambda (&rest _ignored) - (list-buffers--refresh (project-buffers pr)) + (list-buffers--refresh + (funcall buffer-list-function)) (tabulated-list-print t)))) buf) - (list-buffers-noselect - arg nil (lambda (buf) (memq buf (project-buffers pr)))))))) + (list-buffers-noselect arg buffer-list-function))))) (defcustom project-kill-buffer-conditions '(buffer-file-name ; All file-visiting buffers are included. diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 588fe599a46..cabf7cb8fc4 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -100,12 +100,8 @@ Buffer-menu-files-only This is set by the prefix argument to `buffer-menu' and related commands.") -(defvar-local Buffer-menu-filter-predicate nil - "Function to filter out buffers in the buffer list. -Buffers that don't satisfy the predicate will be skipped. -The value should be a function of one argument; it will be -called with the buffer. If this function returns non-nil, -then the buffer will be displayed in the buffer list.") +(defvar-local Buffer-menu-buffer-list-function nil + "Function to return buffers for the buffer list.") (defvar-keymap Buffer-menu-mode-map :doc "Local keymap for `Buffer-menu-mode' buffers." @@ -623,23 +619,23 @@ Buffer-menu-view-other-window ;;; Functions for populating the Buffer Menu. ;;;###autoload -(defun list-buffers-noselect (&optional files-only buffer-list filter-predicate) +(defun list-buffers-noselect (&optional files-only buffer-list) "Create and return a Buffer Menu buffer. This is called by `buffer-menu' and others as a subroutine. If FILES-ONLY is non-nil, show only file-visiting buffers. -If BUFFER-LIST is non-nil, it should be a list of buffers; it -means list those buffers and no others. -If FILTER-PREDICATE is non-nil, it should be a function -that filters out buffers from the list of buffers. -See more at `Buffer-menu-filter-predicate'." +If BUFFER-LIST is non-nil, it should be either a list of buffers +or a function that returns a list of buffers; it means +list those buffers and no others. +See more at `Buffer-menu-buffer-list-function'." (let ((old-buffer (current-buffer)) (buffer (get-buffer-create "*Buffer List*"))) (with-current-buffer buffer (Buffer-menu-mode) (setq Buffer-menu-files-only (and files-only (>= (prefix-numeric-value files-only) 0))) - (setq Buffer-menu-filter-predicate filter-predicate) + (when (functionp buffer-list) + (setq Buffer-menu-buffer-list-function buffer-list)) (list-buffers--refresh buffer-list old-buffer) (tabulated-list-print)) buffer)) @@ -661,13 +657,17 @@ list-buffers--refresh (marked-buffers (Buffer-menu-marked-buffers)) (buffer-menu-buffer (current-buffer)) (show-non-file (not Buffer-menu-files-only)) - (filter-predicate (and (functionp Buffer-menu-filter-predicate) - Buffer-menu-filter-predicate)) entries name-width) ;; Collect info for each buffer we're interested in. - (dolist (buffer (or buffer-list - (buffer-list (if Buffer-menu-use-frame-buffer-list - (selected-frame))))) + (dolist (buffer (cond + ((functionp buffer-list) + (funcall buffer-list)) + (buffer-list) + (Buffer-menu-buffer-list-function + (funcall Buffer-menu-buffer-list-function)) + (t (buffer-list + (if Buffer-menu-use-frame-buffer-list + (selected-frame)))))) (with-current-buffer buffer (let* ((name (buffer-name)) (file buffer-file-name)) @@ -676,9 +676,7 @@ list-buffers--refresh (and (or (not (string= (substring name 0 1) " ")) file) (not (eq buffer buffer-menu-buffer)) - (or file show-non-file) - (or (not filter-predicate) - (funcall filter-predicate buffer))))) + (or file show-non-file)))) (push (list buffer (vector (cond ((eq buffer old-buffer) ".") --=-=-=-- From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707809594284 (code B ref 59935); Sun, 11 Dec 2022 17:50:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 17:49:19 +0000 Received: from localhost ([127.0.0.1]:47329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QRz-000172-GA for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:49:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QRy-00016w-2p for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 12:49:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QRs-00045V-21; Sun, 11 Dec 2022 12:49:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sgvjE5R42ySg/cPT/t9PTZbrUSM7tKACtM/f3rHqG+Q=; b=XynyRHbSKm6Z nW12jEAnliBicHke45wvT2XHXnbrrvrrwVzykXkeoTxu2aNvg/sOmNEEKz2Otciq/v53VswlVuoVO fiGC2MTNiXnnYw2sNhaVZma9KWTxXspmGifOwnZE+Y3oJOhowQyVripE3EEqBWeqVcKbpn9VU9oCp iOpKBYhDc9UBM+7gtZbq0wiCbm46PDiWFy4575oEXXJcrHUHHk4f3sr/Va1DIXYlXowR2blKyUv4h +f9DFIlTn8VOpGQTYY6QVN481lzMmvgE9Q6PKriggm+/v8/UDyuFhkmZMGnbhyOghDyxPpmchqUWb kLxSOQn6WJ/gdBhOx3+tuQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QRr-0006A2-Bo; Sun, 11 Dec 2022 12:49:11 -0500 Date: Sun, 11 Dec 2022 19:49:09 +0200 Message-Id: <83bko9u8yy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86bko9na29.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 11 Dec 2022 19:07:27 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 59935@debbugs.gnu.org > From: Juri Linkov > Date: Sun, 11 Dec 2022 19:07:27 +0200 > > > Do you have the time to finish the fix yourself? It was your feature, after > > all. > > Here is a complete patch tested for all possible cases: > - emacs 28/29 > - with/without file arg > - with/without reverting Thanks, but I hope you don't intend to ask to install this on the release branch. And changing back the signature of list-buffers-noselect is extremely problematic, even though we changed it only for Emacs 29. Please try to find a safer, more compatible solution. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 17:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707814194560 (code B ref 59935); Sun, 11 Dec 2022 17:57:01 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 17:56:59 +0000 Received: from localhost ([127.0.0.1]:47379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QZP-0001BU-DV for submit@debbugs.gnu.org; Sun, 11 Dec 2022 12:56:59 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QZN-0001BO-FW for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 12:56:58 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 22F3860006; Sun, 11 Dec 2022 17:56:48 +0000 (UTC) From: Juri Linkov In-Reply-To: <83bko9u8yy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Dec 2022 19:49:09 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> Date: Sun, 11 Dec 2022 19:56:24 +0200 Message-ID: <86edt5lt87.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > Do you have the time to finish the fix yourself? It was your feature, after >> > all. >> >> Here is a complete patch tested for all possible cases: >> - emacs 28/29 >> - with/without file arg >> - with/without reverting > > Thanks, but I hope you don't intend to ask to install this on the > release branch. And changing back the signature of > list-buffers-noselect is extremely problematic, even though we changed > it only for Emacs 29. > > Please try to find a safer, more compatible solution. This is the safest solution for the emacs-29 branch. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707821515156 (code B ref 59935); Sun, 11 Dec 2022 18:10:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:09:11 +0000 Received: from localhost ([127.0.0.1]:47451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QlC-0001L4-Vn for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:09:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QlB-0001Kx-Dl for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:09:09 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Ql5-0001ea-BH; Sun, 11 Dec 2022 13:09:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4KlbY1vxjTskctnC8VGQPU17F5X9Z5nE0wMHlrF4uCA=; b=mvfJwu6IGYFS 5panu0Jp0dF+nOG/j3bF8PKzXA/BJNk7dX/joJqNhLYyX0oOgS74H1cwtfaKaw4oN8Hw4k58REU1I o8wuAN9mUibfqIaOjhjVSmzI6tv0ethyLao/6MqJqHo7NcF+HcvcM/0OorB6t4Bi0zpcqElULGZDt nS93nd8/uKKElf21amcH5Ak7X8eQRvCI0lR5dPvwN1aMNT3SJZATHTligrpsQ3nBFf51xY5gY1Ld+ OPGU1ajvD1cGT0Q00YVOt4mOBX9H9L2zijc/g16V4IoKuhw8rNqpignU6Xts3grwRN83PI7S8wXUU X3kVWrtr5EfCu18Mh560ZA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Ql4-0008OB-KN; Sun, 11 Dec 2022 13:09:02 -0500 Date: Sun, 11 Dec 2022 20:08:59 +0200 Message-Id: <83a63tu81w.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86edt5lt87.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 11 Dec 2022 19:56:24 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <86edt5lt87.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, 59935@debbugs.gnu.org > Date: Sun, 11 Dec 2022 19:56:24 +0200 > > >> > Do you have the time to finish the fix yourself? It was your feature, after > >> > all. > >> > >> Here is a complete patch tested for all possible cases: > >> - emacs 28/29 > >> - with/without file arg > >> - with/without reverting > > > > Thanks, but I hope you don't intend to ask to install this on the > > release branch. And changing back the signature of > > list-buffers-noselect is extremely problematic, even though we changed > > it only for Emacs 29. > > > > Please try to find a safer, more compatible solution. > > This is the safest solution for the emacs-29 branch. I don't see how it could be the safest. For example, an almost identical changeset that doesn't change the signature of list-buffers-noselect is definitely safer. And likewise with the change of list-buffers--refresh -- why do we have to do that? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Juri Linkov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707823565263 (code B ref 59935); Sun, 11 Dec 2022 18:13:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:12:36 +0000 Received: from localhost ([127.0.0.1]:47467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QoV-0001Mp-Li for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:12:35 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:39582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QoT-0001Mi-Mh for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:12:34 -0500 Received: by mail-wm1-f42.google.com with SMTP id 206-20020a1c02d7000000b003d21f02fbaaso932525wmc.4 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:12:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=zgFR15n2eBorUDiJRZBTS1gCVgYx+8RJ1tmVGEkxtIM=; b=Bk4Y+/+OipnVy1NBimmo2HvNFhS1tusuYPxQ1v2pErlidhCXv8KznwnB1RiO2hA26X d573Xb3xwlAQvpHqdMLRyXkKjucCzQrXpjMt74k4fbvxeGjVgBBDaPcMcQXVdvyDVALB 10mLfAzVPXwlbfako36UjQOJWJmrIMR6Hw8oWL1uSxr26k83IZGWFY9W2XFhCVQ/OJkS MBIvW9WO8qIP3ek3HYaF+SN7H1n+fS0PEtnq7IBpKhEg+V9ocOitNLeMvsDsvXJFhpxS geSwNa+/zhoGD5Drzh1HT/4wJKFZIiz3yeu6udnGxE/gy9lUY4PzHTGszIP9DwOx92/I Z6JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zgFR15n2eBorUDiJRZBTS1gCVgYx+8RJ1tmVGEkxtIM=; b=r0SyX8HS4XlFh8ko/R4P6qJsIm1FuwkkqsTgXzJ3V4vqaEvyGXMy1aGDnycLEQuls8 N0hhdjf4N1IbM+zcG3i0UprjrkUFuqOQSKKec5hEMzwuIvIHayd49DPpwNjxL5kg1LaN pdINxg2MlCneGI0rgltKu+fXjkrwQ7CdTPHf30JucWWUrNeocz9UJTnsSgwWWBgFnFJF zykcFluJ3VaimwSHOlK8ER34R2o0D3SmShgqDIN5AMyScDg9Qjb8FCGTSUuQ87UhnMH4 2Qfw5JEngjPwbZ2VfZpKcY1nlWot5qy3HPZgFhLK5HuuSrCU2VLi+ZUdG8WNFiYuXx4V Ysbw== X-Gm-Message-State: ANoB5pmLEnbsBWI7eqnLi09v+Gz9paQHjKuQUmX/S3j1j+lkzptfN4oo ZkPhIYx+5ZwxC0OBG4vp+9A= X-Google-Smtp-Source: AA0mqf67cTtD39a7lZQE3iColub3FujmBILPevuq5Ph6FbonHpKTBKAXlq1wTVA4qbt4a1qR4+n9kQ== X-Received: by 2002:a05:600c:35c3:b0:3d2:1bf6:5796 with SMTP id r3-20020a05600c35c300b003d21bf65796mr4098835wmq.35.1670782347868; Sun, 11 Dec 2022 10:12:27 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z5-20020adff1c5000000b002258235bda3sm6749514wro.61.2022.12.11.10.12.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:12:27 -0800 (PST) Message-ID: <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> Date: Sun, 11 Dec 2022 20:12:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83bko9u8yy.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 19:49, Eli Zaretskii wrote: > Thanks, but I hope you don't intend to ask to install this on the > release branch. And changing back the signature of > list-buffers-noselect is extremely problematic, even though we changed > it only for Emacs 29. The problem with *not* changing it, is we don't seem to be able to use the new calling convention to implement project-list-buffers working without this performance problem. We could just use the old (private) interface, but then the new calling convention will be left without any users at all. We extended it in order to implement this feature anyway. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Juri Linkov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707824155309 (code B ref 59935); Sun, 11 Dec 2022 18:14:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:13:35 +0000 Received: from localhost ([127.0.0.1]:47475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QpT-0001NZ-26 for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:13:35 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:40579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QpR-0001NR-5s for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:13:33 -0500 Received: by mail-wm1-f54.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso3336420wme.5 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=lMnmdDoKVkhNVXbSmMYonXD97B/7wqNfLGZmbgpHGlw=; b=kZyM3/FK25vi1hQNf5meco1gnNZ0h+uRtfY1ftsR5UcGqvPpZYHzJb+93y/2oqAXWi KPrB/7jf+tq8my3igEN/loe25TE/v1xXt9tTx1mI5ip5zdHFEIDC/UD2j3u+ItxUBqiP wW20RgKFMSA27uMWyeJ5kI2ejtR1tQa2pMGwuMnlv8XaVDcIRlZkFiukuIhSH3qeEf2p /qNoIKdYG0fxeaHeuBOj86vbH2s14M4NZXJ3Yu3ge7JN0S0z5D6AWk4BsxIMDe3gY6N+ s8XXwHbwEXdR8NnEvkMvaUZF0+Q87THhJOY9cvw/s+GwsZIP+/AfgchQxZo8/zO+H4dG tb0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lMnmdDoKVkhNVXbSmMYonXD97B/7wqNfLGZmbgpHGlw=; b=JXkrI/gjX49ksuiAQDcpijBwe8+HrT20EHm6OOr2Tq2AZk7gyEQdKJ0cTiY7aK6vEU ThYtaRZS2VSWJxbkrTlDYC9q+uqM4SDVQ/+hHTtOjzjjWD6D1ihukUMBWiXXgyslwuc4 emuT2yFSOKjCAFp6Zzv32NtmKWkFoSFc87N+lnxBi05aQV3q+rCE91hn/v0/ns7wJAXX ZtGZ84275bgkaYDplfQ8c60BXmenUjJYIelw9DOl6I8fnYn/+GPwSJAL/OYtlL/soetz lfGr1FqmszoYL6/Ry+HC3esnxp7ol0bFX8U2DmINBoC3+xTodXYf2yFgc31WJITYGJnD 5Sdw== X-Gm-Message-State: ANoB5pkGbgsv2S8+D7P/5AvWKVr5hQYxNl73QOoUsjhC+7s90CsMlBbx yU+cbL/mqATyZ1E20dOfe5E+yrwab4Y= X-Google-Smtp-Source: AA0mqf4rli1VGhjNnyQQWHeuZKqLUoHXcQKJ4Sa4V663fQ0iHm6D7gk94o7WOOz3HDeTnvqlXOApjg== X-Received: by 2002:a05:600c:1c87:b0:3cf:ae53:9193 with SMTP id k7-20020a05600c1c8700b003cfae539193mr11128787wms.39.1670782407535; Sun, 11 Dec 2022 10:13:27 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o17-20020a05600c511100b003cfa3a12660sm25492412wms.1.2022.12.11.10.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:13:27 -0800 (PST) Message-ID: Date: Sun, 11 Dec 2022 20:13:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <86edt5lt87.fsf@mail.linkov.net> <83a63tu81w.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83a63tu81w.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 20:08, Eli Zaretskii wrote: > I don't see how it could be the safest. For example, an almost > identical changeset that doesn't change the signature of > list-buffers-noselect is definitely safer. And likewise with the > change of list-buffers--refresh -- why do we have to do that? How do we avoid changing the signature? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707826605498 (code B ref 59935); Sun, 11 Dec 2022 18:18:01 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:17:40 +0000 Received: from localhost ([127.0.0.1]:47500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QtP-0001Qc-UL for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:17:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4QtN-0001QW-Jb for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:17:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QtH-0004MM-RB; Sun, 11 Dec 2022 13:17:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z+GlW5d1gRMloCJL8kiWs/qhvUrwcidnHSV4Fkh5HLQ=; b=ebYa/J2q2+nx VV1V5Hl7zNa4RK9NMz5a2g62iincqSLD9LmohTeVux+ruRZ9m5/ZgRJ7OgQfPfIWP4zfQUhYNXqTc 0nYO5b4RdJDruolVeXvq8V6rtod2bW9OXk8vc/JRM65OR6KEKMyu5Dialbzum3qRH40fm7KtYSEVO nYOZuDVxc+w2Min4t8PxlbWj5FLM2qPKPqkIuJ3YzTyipjLwzrCZHX+eK8b7xgap4WgMj9y+vr2vt 15ea+xDCkRnQZaMH3L40zBdXGx0vOIVfrHwB8mt0FFBAIxFkHXm/0sGr7OfRth2rUectbwLzIINKL 1Dody4JtCtaWAAkvPe7H1Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4QtH-0000sD-4l; Sun, 11 Dec 2022 13:17:31 -0500 Date: Sun, 11 Dec 2022 20:17:30 +0200 Message-Id: <838rjdu7np.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> (message from Dmitry Gutov on Sun, 11 Dec 2022 20:12:25 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 11 Dec 2022 20:12:25 +0200 > Cc: 59935@debbugs.gnu.org > From: Dmitry Gutov > > On 11/12/2022 19:49, Eli Zaretskii wrote: > > Thanks, but I hope you don't intend to ask to install this on the > > release branch. And changing back the signature of > > list-buffers-noselect is extremely problematic, even though we changed > > it only for Emacs 29. > > The problem with *not* changing it, is we don't seem to be able to use > the new calling convention to implement project-list-buffers working > without this performance problem. > > We could just use the old (private) interface, but then the new calling > convention will be left without any users at all. We extended it in > order to implement this feature anyway. I don't think I follow. Why not leave alone that additional PREDICATE argument of list-buffers-noselect, and add a feature where the BUFFER-LIST argument could be a function? That's be a compatible change. Just keep the PREDICATE argument and the code which supports it, and document that if PREDICATE is a function, BUFFER-LIST cannot be a function. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707837346246 (code B ref 59935); Sun, 11 Dec 2022 18:36:01 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:35:34 +0000 Received: from localhost ([127.0.0.1]:47577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RAj-0001cg-Us for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:35:34 -0500 Received: from mail-wm1-f42.google.com ([209.85.128.42]:44739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RAi-0001cX-Iy for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:35:32 -0500 Received: by mail-wm1-f42.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso1845157wmp.3 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=PykR7canuO7Y9PU8YL4bmp9m8HTcSsx5fLqoJHbNoYk=; b=gqwHcgtE6JQ7pJUW1m6bJQ10z83SERccs3zGQ+oStos7RPEnMDtnFzm5J958mVdGHU DRs83l6nZXpzcNhYY2NKNDMJhbi3m25hFR6TfBRdaeum5jNL2G/wbCJI6EabpwN6wI95 7UKcV+fqT7pcAJHwXxYnFeKXTelEZ5A8vzaBA57ZzChfHfjp+zvjMKELp7iLTPHLZG3B vLVT4tvbbOc4eTw+VIZXwd+PdyOYU07ng0NIHoke4whhmbbUFI3PLJsws0oukRF54aEo jNJnEXpr8Gsyco6f4uk1xz5swZZpSLFOKfro+IJguB3V4tOHlYTygKVhELIDA+V6rp2S Ybaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PykR7canuO7Y9PU8YL4bmp9m8HTcSsx5fLqoJHbNoYk=; b=5p2rQnWxCV5Yt5mm3eymnY6Z3UZVBjZSmgmMcniAmHxMoVDH8+hS5ZskEjvBZ8jwkK IZ9jLgWLdQRbXFjvh2BpGisZAZZP0exOr5w76SbmATT4TzoOQuMpg5/IzqthgY7lZjWf lfVY2uurVaPxBV9+z9ko1bxz0T4ev2Qa0abJ9d4bElQtCp7Waic4Sz4r6t5hzWjx4N7L 8GCBiSlmv76KVBLuNinMNeC9Q81+Of0or+UkL1M8rarY2mJghvTq8jNRDCMFhMcRySU5 LZN6IiDz0vg8mEz8Ws/MTWG0XD/w94gCtId0RUn7s6itDuVmlBB8zIulGYphcq4124sn 4rRA== X-Gm-Message-State: ANoB5plng/eK8WAcVSp/vCVTnMK5DdElR2T7c/NUSbHMGPLrhviojxip /fqpGGJ7/RV5R1Olq110u2E= X-Google-Smtp-Source: AA0mqf7UaMpRmPqojKN7n3r7RZpLwtCnAtvVoKbN3VHr1XmdciMymJrtNoJGsIw0PSlO0SwdnUVB7Q== X-Received: by 2002:a7b:c30e:0:b0:3cf:ab98:2245 with SMTP id k14-20020a7bc30e000000b003cfab982245mr10503688wmj.28.1670783726667; Sun, 11 Dec 2022 10:35:26 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t17-20020a05600c199100b003c6f1732f65sm6819761wmq.38.2022.12.11.10.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:35:26 -0800 (PST) Message-ID: <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> Date: Sun, 11 Dec 2022 20:35:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <838rjdu7np.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 20:17, Eli Zaretskii wrote: > Why not leave alone that additional PREDICATE > argument of list-buffers-noselect, and add a feature where the > BUFFER-LIST argument could be a function? That's be a compatible > change. Just keep the PREDICATE argument and the code which supports > it, and document that if PREDICATE is a function, BUFFER-LIST cannot > be a function. While that should work, that change would *also* change the signature. Though in a safer way, yes. Are you worried about some out-of-tree clients that started using the new feature in the meantime? Otherwise, this change could be split into two steps: - Rollback that signature to pre-commit 125b5684c (i.e. revert its part in buff-menu.el). This is something we usually considered to be safe. - Add new change that allows BUFFER-LIST to be a function. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707838796386 (code B ref 59935); Sun, 11 Dec 2022 18:38:01 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:37:59 +0000 Received: from localhost ([127.0.0.1]:47601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RD5-0001ew-Hv for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:37:59 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:47021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RD4-0001ep-1C for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:37:58 -0500 Received: by mail-wm1-f53.google.com with SMTP id f13-20020a1cc90d000000b003d08c4cf679so3365947wmb.5 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=SXxcZTLJjIgF0ZstxsCBJE2T47wv1miMSlGS+yMQQnw=; b=qwAeebUuieKX894PX+xxX4YTqpizpj/N7Sh8xquQADXs6MrcHnPjkdtsyUqbfb1ygl K3hkj9bUFHuErCb2YW3mRgBmGmnSDArs80uHgIllQq1ReN45krnyeURixoykgaGclTP3 ncDWgwqG3r69rWnmx7MQEb9VR6xnLzSuw9IinaHB1rsb3l53jarWx55F3HTxrZrf8CCI ow6sw2c39sIixb6awLsi5cbyXtSW3/RYnQgDLSIgD0zNh709RWMfYqak2dD7fn+Nj2Rk o97W0vMO4iBcwFvSSvoN1+s2Q2T6QWfo5ImvLhd/GJQdG9fT6ErHK/NvmiTXADez9vjn ZfVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SXxcZTLJjIgF0ZstxsCBJE2T47wv1miMSlGS+yMQQnw=; b=Fs+luau1EsLU1t+ryJhbL4FIHgryKfvU6Dy5RfCLOFoSYR6d30HwVcoOnxnW88r3Z4 cNJE9fXwTTIInh0QSUaIINsAcZql9qzarQKI5mL/4Xn/2D/ah71ifCQS6EfCkJ8OmuN/ y6JPdWk66zxWoYPN9KmqztcQjEPNTzmb8l4zPLF1B3RLmlMHGYoS7wysaIe56EJrbItD MmqCJ3vAPlBeBNpFDsgklxNyBwZgDLG5zRq4SzOAC66JJzpXvqI2zsqJ/gxeVygcmpUk q/lION3U+iCahjoxzHvILwEkH04SrJkO7ZKxDFIq155/foZmnXvlPinPmLDWRI0M6ZWw xtuQ== X-Gm-Message-State: ANoB5pmMsaqtTma7WF3tH75riIGbtwI2sttfBGBcID/WjjB5OKuYJhJQ NYlBFwa0wQRBkRPnCfv7xDKoWuEWRs0= X-Google-Smtp-Source: AA0mqf6KRO4h9CYICCebeXFA/sH9VW97xiAn7zfxOnEy8AeyDTPSJehteu0giwsMkwwOW1t9lqoV6w== X-Received: by 2002:a05:600c:a15:b0:3c6:f0b8:74e6 with SMTP id z21-20020a05600c0a1500b003c6f0b874e6mr10165083wmp.4.1670783872463; Sun, 11 Dec 2022 10:37:52 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v1-20020a5d6781000000b002422b462975sm6728860wru.34.2022.12.11.10.37.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:37:52 -0800 (PST) Message-ID: <119c73c2-b219-5ee6-6fb3-c92d7ffea37d@yandex.ru> Date: Sun, 11 Dec 2022 20:37:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <86bko9na29.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 19:07, Juri Linkov wrote: > +(defvar-local Buffer-menu-buffer-list-function nil > + "Function to return buffers for the buffer list.") > > (setq Buffer-menu-files-only > (and files-only (>= (prefix-numeric-value files-only) 0))) > - (setq Buffer-menu-filter-predicate filter-predicate) > + (when (functionp buffer-list) > + (setq Buffer-menu-buffer-list-function buffer-list)) Here's an idea: when 'list-buffers-noselect' received a plain list of buffers in its BUFFER-LIST argument, it doesn't save that anywhere. That seems like a bug, doesn't it? That hitting 'g' in such a buffer-list buffer resets its contents to all buffer (except hidden, etc). So it probably makes sense to save it as well. Long story short, I suggest to name the new variable Buffer-menu-buffer-list, and save the value of the BUFFER-LIST argument to it no matter what. And, likewise, use it. But when the value is a function, call it to obtain the actual list. One side-effect of this, though, is that the BUFFER-LIST argument to list-buffers--refresh will have no purpose anymore. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707852347366 (code B ref 59935); Sun, 11 Dec 2022 19:01:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 19:00:34 +0000 Received: from localhost ([127.0.0.1]:47696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RYw-0001uk-6H for submit@debbugs.gnu.org; Sun, 11 Dec 2022 14:00:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RYt-0001ue-Ms for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 14:00:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RYn-00049o-Gc; Sun, 11 Dec 2022 14:00:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+IBpaWpNfKDDO9S/fRWW5XhrEa3KqKnM6rsBBvwC1ls=; b=qHxrlg61r+z2 E4hBiHWCsa3RqP8mem7yMPvH/2avFKahCXUvCNBNSZ4O1S1nZWJKiXg82BYpP7JSGow7iHpKfS/Q1 Zf7AawFy+woAZXZep4d3dEvkygEvXdXjDje6iSWojm7JOrFgOGWvbpq2dgbycl+AbCCadd5+T25FT 5DKTS9rqshsCs/LNkr5+L8QG4mbX1J58bqJcu3U8Yk0Nlqz8n2l+jjJaGrdc8W9uXxM6bhbVXrXKm NQFndWK4yh5Hj2B5pWOjhakPvTyZg1WL/pTyU+jJlY6RjSwjrjbBg/yMujYlNw20M5GG8AGDoVY/b Sdf8rAoKj77W+oog8/Gg9g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RYn-0003gw-1S; Sun, 11 Dec 2022 14:00:25 -0500 Date: Sun, 11 Dec 2022 21:00:25 +0200 Message-Id: <83359lu5o6.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> (message from Dmitry Gutov on Sun, 11 Dec 2022 20:35:24 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 11 Dec 2022 20:35:24 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 11/12/2022 20:17, Eli Zaretskii wrote: > > Why not leave alone that additional PREDICATE > > argument of list-buffers-noselect, and add a feature where the > > BUFFER-LIST argument could be a function? That's be a compatible > > change. Just keep the PREDICATE argument and the code which supports > > it, and document that if PREDICATE is a function, BUFFER-LIST cannot > > be a function. > > While that should work, that change would *also* change the signature. > Though in a safer way, yes. Indeed. > Are you worried about some out-of-tree clients that started using the > new feature in the meantime? Yes. In particular, we never change signatures after the branch point of a release branch -- the branch point is a de-facto code-freeze point for the release branch. > Otherwise, this change could be split into two steps: > > - Rollback that signature to pre-commit 125b5684c (i.e. revert its part > in buff-menu.el). This is something we usually considered to be safe. > > - Add new change that allows BUFFER-LIST to be a function. We can do it safer, so I'd prefer that. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 19:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707877108690 (code B ref 59935); Sun, 11 Dec 2022 19:42:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 19:41:50 +0000 Received: from localhost ([127.0.0.1]:47872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4SCr-0002G6-W7 for submit@debbugs.gnu.org; Sun, 11 Dec 2022 14:41:50 -0500 Received: from mail-wm1-f54.google.com ([209.85.128.54]:46030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4SCq-0002G0-Ph for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 14:41:49 -0500 Received: by mail-wm1-f54.google.com with SMTP id n9-20020a05600c3b8900b003d0944dba41so3486962wms.4 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 11:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=S18gVOiB3rGze28PozOShVwafsBZtQqROi5r6soM4R8=; b=qXm3vfAFnRlue8tVCe5Zj2rW2+FnF+7keV4kOVb2mr1rf8IehHSPxKyWL8XdKQbrHp lq8vIV/Np7o3+RB1rPoaYub+hHLE63SBWRTIrofVYddA0DOBZAGMtfiDK3aSGmggsz+p p3rxscmZy09JbfskX2xVeqNvaggDlFz+sGGuRr/fXler5qO3cpINQeatk3ig/KDedEhm sIVmtk8B4LL3qFtBCTTXiiEGeaSt7EOLe3A/TBcwhVdGJdxmWW4izEHrgQ+MN4SkxT3C QEaXNMRqb1D/VjnAkQWZckfOf+hFga8SPyhHPdYq5YL20QpyLs70YjESHudu6FFWif5H fqIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=S18gVOiB3rGze28PozOShVwafsBZtQqROi5r6soM4R8=; b=Grfs7QSC6n6yz+Uo6loGNAwMpbaknF+h41H5TtF7HRsFLwueatBwj+W41ymjHiQOv3 uQCFRxCnDMltHC9EjrFYP/64z7uGkF6gKqA0+Xs4jUaEPfPMK+5tUqLWEXnEXU60XK+W 6bki4WanSZZPJaFJym3mIc07Pzw9L8CjA8thaIwckNfFzQrm5SeecVcBghJoW1N3d4gu icJhZSycvVqtk16i5hcvWzTWCm6rndg4X8mDTbGsbkV/VFZky1FdfgMKbf8MdXTrthA5 t70Mb9e8tttlDEq6h1z/weNvkbgNX25CGMYAVmrbIT5SE6IX9Oq0N0RC5qys785i+WiH 5adg== X-Gm-Message-State: ANoB5plyHBCdhCgooHB0Xfru5OB4myOC5cmf4176gT4m/q4qVLVw/oOo 7gLoC0NSrDq8RpFDnDiZPkE= X-Google-Smtp-Source: AA0mqf5eCI3DBG1D1ZdmtfXroKcjgYSDUoLWDEqtxa1rSaGqvwsJ4IGMk6m5NueqRxwBTH+MuRO0hg== X-Received: by 2002:a05:600c:4f14:b0:3cf:e91d:f263 with SMTP id l20-20020a05600c4f1400b003cfe91df263mr10419201wmq.4.1670787702887; Sun, 11 Dec 2022 11:41:42 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id n22-20020a05600c3b9600b003cfd0bd8c0asm7193193wms.30.2022.12.11.11.41.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 11:41:42 -0800 (PST) Message-ID: <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> Date: Sun, 11 Dec 2022 21:41:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83359lu5o6.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 11/12/2022 21:00, Eli Zaretskii wrote: >> Otherwise, this change could be split into two steps: >> >> - Rollback that signature to pre-commit 125b5684c (i.e. revert its part >> in buff-menu.el). This is something we usually considered to be safe. >> >> - Add new change that allows BUFFER-LIST to be a function. > We can do it safer, so I'd prefer that. I don't like that idea because we'll leave an unproven new feature in the codebase, without any known callers or requestors. That's just extra complexity, with all associated long-term costs. But you're the boss. It's better to fix this than not, obviously. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 20:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167079133511053 (code B ref 59935); Sun, 11 Dec 2022 20:43:02 +0000 Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 20:42:15 +0000 Received: from localhost ([127.0.0.1]:48142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4T9L-0002sD-H3 for submit@debbugs.gnu.org; Sun, 11 Dec 2022 15:42:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4T9K-0002s7-0q for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 15:42:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T9E-0002hd-B6; Sun, 11 Dec 2022 15:42:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VSqBRIeRwjoC5yvlrX/ViCx8bzbjdvqFsIxBAAfsCWM=; b=c+v/GvTaJw9t yV4QchNqdphowiwYAS42KPIVT9sjcavWClHOcf4LODKfdo5h3YULUO7hFvXbqktqafkuF8RxArdjs VZdkSnyZhISy/ebXSVTLDfU4Jp37HddOGvnWUd4ARPbLfQtmrz4SM+qTTbKmjjn0+1ZGvOImlqTi5 xGhLFvyudUNC5EvK0XaZ1UPF198+jhe+74l4JLh3qzlpmnG5VwwRW3mWkv0pzA1syHZekB0thc0YK dIMKOTcmwytgNuLSjPiniUZgRBHpDaMOsgGXfuCOU6IJJVo6n7ThkNtr2x7QTRZeJoggeIHj8WIih 6UuXcZ9CqjeGYHLmw56eGw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4T9D-0001g8-MG; Sun, 11 Dec 2022 15:42:08 -0500 Date: Sun, 11 Dec 2022 22:42:08 +0200 Message-Id: <83wn6xsme7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> (message from Dmitry Gutov on Sun, 11 Dec 2022 21:41:40 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 11 Dec 2022 21:41:40 +0200 > Cc: 59935@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > > On 11/12/2022 21:00, Eli Zaretskii wrote: > >> Otherwise, this change could be split into two steps: > >> > >> - Rollback that signature to pre-commit 125b5684c (i.e. revert its part > >> in buff-menu.el). This is something we usually considered to be safe. > >> > >> - Add new change that allows BUFFER-LIST to be a function. > > We can do it safer, so I'd prefer that. > > I don't like that idea because we'll leave an unproven new feature in > the codebase, without any known callers or requestors. Neither do I. But this is a price to pay for coming this late with changes in interfaces that are needed to make commands faster, and we cannot wait. If this came up half a year ago, we wouldn't be having this conversation. The schedule for releasing Emacs 29.1 is very ambitious, from where I stand, and I don't want any risks we can avoid. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 10:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: juri@linkov.net, 59935@debbugs.gnu.org, Dmitry Gutov Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167084199332606 (code B ref 59935); Mon, 12 Dec 2022 10:47:02 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 10:46:33 +0000 Received: from localhost ([127.0.0.1]:52120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gKO-0008Tq-SW for submit@debbugs.gnu.org; Mon, 12 Dec 2022 05:46:33 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:54641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4gKN-0008Tg-3v for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 05:46:31 -0500 Received: from localhost ([::ffff:197.239.6.30]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000561BB.0000000063970687.00004C49; Mon, 12 Dec 2022 03:46:31 -0700 Date: Mon, 12 Dec 2022 13:36:48 +0300 From: Jean Louis Message-ID: References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <831qp7vx26.fsf@gnu.org> User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: If I may add to this, that project-list-buffers also incidentally invokes re-connection of any Tramp buffers. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.6.30 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: If I may add to this, that project-list-buffers also incidentally invokes re-connection of any Tramp buffers. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.6.30 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager If I may add to this, that project-list-buffers also incidentally invokes re-connection of any Tramp buffers. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/ From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jean Louis Cc: Eli Zaretskii , 59935@debbugs.gnu.org, Dmitry Gutov Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708656134533 (code B ref 59935); Mon, 12 Dec 2022 17:21:02 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 17:20:13 +0000 Received: from localhost ([127.0.0.1]:54211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mTM-0001B3-NJ for submit@debbugs.gnu.org; Mon, 12 Dec 2022 12:20:12 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:38021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mTL-0001Au-Lq for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 12:20:11 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 37573FF807; Mon, 12 Dec 2022 17:20:02 +0000 (UTC) From: Juri Linkov In-Reply-To: (Jean Louis's message of "Mon, 12 Dec 2022 13:36:48 +0300") Organization: LINKOV.NET References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> Date: Mon, 12 Dec 2022 19:12:17 +0200 Message-ID: <868rjcsjkq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > If I may add to this, that project-list-buffers also incidentally > invokes re-connection of any Tramp buffers. Does list-buffers invoke Tramp re-connection as well? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 17:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, Dmitry Gutov Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708656174550 (code B ref 59935); Mon, 12 Dec 2022 17:21:02 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 17:20:17 +0000 Received: from localhost ([127.0.0.1]:54214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mTQ-0001BJ-Uz for submit@debbugs.gnu.org; Mon, 12 Dec 2022 12:20:17 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:58601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mTP-0001Av-0f for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 12:20:15 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 73FD360004; Mon, 12 Dec 2022 17:20:07 +0000 (UTC) From: Juri Linkov In-Reply-To: <83wn6xsme7.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 11 Dec 2022 22:42:08 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> Date: Mon, 12 Dec 2022 19:16:22 +0200 Message-ID: <86359ksj29.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I don't like that idea because we'll leave an unproven new feature in >> the codebase, without any known callers or requestors. > > Neither do I. But this is a price to pay for coming this late with > changes in interfaces that are needed to make commands faster, and we > cannot wait. If this came up half a year ago, we wouldn't be having > this conversation. Ok, then here is the patch for emacs-29: diff --git a/etc/NEWS b/etc/NEWS index 233ef3f5729..2e5bb40c972 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -3437,6 +3437,10 @@ The following generalized variables have been made obsolete: * Lisp Changes in Emacs 29.1 +--- +** The argument FILTER-PREDICATE of 'list-buffers-noselect' is obsolete now. +It will be removed in next versions. + +++ ** Interpreted closures are "safe for space". As was already the case for byte-compiled closures, instead of capturing From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708660864989 (code B ref 59935); Mon, 12 Dec 2022 17:29:01 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 17:28:06 +0000 Received: from localhost ([127.0.0.1]:54254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4mb0-0001IP-2H for submit@debbugs.gnu.org; Mon, 12 Dec 2022 12:28:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4max-0001Hu-B3 for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 12:28:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4maq-0004gu-Kb; Mon, 12 Dec 2022 12:27:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tbgh1yd490OveHE/IrqK0MlBY32cmePWU2Unl+FHbAI=; b=lLE+ZCZCXhJq z0PgQvWNDTT9uK9nqPBNyiYNFfKGlvLvsDvT2pQB4cAK55mRoVEwmW9QwUuYX3PaViZ5lBeALCot0 D0ux5W/OyVBVSkwO32uC3zBSNXqcJ9o6O2m8b3lTYFn2FGq9zJclMsTRJUvsTM9H25mRIDan0oSYR VB1IZ0lHBgvvtaV3bBLIIQssehjn4IAN/aSXrD8kwVU/ru4OJOaFeIfV+QglXm1/y/UmqwWwT4ARg ypEDrge1YKDh7V2abCxzxdOpBfrPrL5t3NYmGfi0e/UpwkQxLK/TUPTnO9zx3NYW5xEvL7GfgxAY2 Vaq0fdOUANaTDLHhNy2eBQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4map-00058D-L3; Mon, 12 Dec 2022 12:27:56 -0500 Date: Mon, 12 Dec 2022 19:27:57 +0200 Message-Id: <83mt7sr0pu.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86359ksj29.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 19:16:22 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Dmitry Gutov , 59935@debbugs.gnu.org > Date: Mon, 12 Dec 2022 19:16:22 +0200 > > >> I don't like that idea because we'll leave an unproven new feature in > >> the codebase, without any known callers or requestors. > > > > Neither do I. But this is a price to pay for coming this late with > > changes in interfaces that are needed to make commands faster, and we > > cannot wait. If this came up half a year ago, we wouldn't be having > > this conversation. > > Ok, then here is the patch for emacs-29: > > diff --git a/etc/NEWS b/etc/NEWS > index 233ef3f5729..2e5bb40c972 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -3437,6 +3437,10 @@ The following generalized variables have been made obsolete: > > * Lisp Changes in Emacs 29.1 > > +--- > +** The argument FILTER-PREDICATE of 'list-buffers-noselect' is obsolete now. > +It will be removed in next versions. > + > +++ > ** Interpreted closures are "safe for space". > As was already the case for byte-compiled closures, instead of capturing I thought we wanted to make the command faster in Emacs 29. I very much doubt that deprecation of an argument will have that effect. I'm also not sure I agree with obsoleting and removing that argument. We don't have enough justification for that, not yet. That it was introduced for a particular use case, and that use case no longer uses it, doesn't mean there won't be others. After all, we don't introduce additional arguments unless we think it will be useful in more than one case. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 17:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708675696515 (code B ref 59935); Mon, 12 Dec 2022 17:53:01 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 17:52:49 +0000 Received: from localhost ([127.0.0.1]:54390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4myv-0001h1-8B for submit@debbugs.gnu.org; Mon, 12 Dec 2022 12:52:49 -0500 Received: from relay11.mail.gandi.net ([217.70.178.231]:56415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4myt-0001gt-BM for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 12:52:47 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 78067100021; Mon, 12 Dec 2022 17:52:18 +0000 (UTC) From: Juri Linkov In-Reply-To: <83mt7sr0pu.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 19:27:57 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> <83mt7sr0pu.fsf@gnu.org> Date: Mon, 12 Dec 2022 19:51:48 +0200 Message-ID: <86k02wpl1n.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> +** The argument FILTER-PREDICATE of 'list-buffers-noselect' is obsolete now. >> +It will be removed in next versions. > > I thought we wanted to make the command faster in Emacs 29. I very > much doubt that deprecation of an argument will have that effect. > > I'm also not sure I agree with obsoleting and removing that argument. > We don't have enough justification for that, not yet. That it was > introduced for a particular use case, and that use case no longer uses > it, doesn't mean there won't be others. After all, we don't introduce > additional arguments unless we think it will be useful in more than > one case. Having both FILTER-PREDICATE and BUFFER-LIST-FUNCTION is too problematic. Which one should take priority over another when both specified? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708686417436 (code B ref 59935); Mon, 12 Dec 2022 18:11:02 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 18:10:41 +0000 Received: from localhost ([127.0.0.1]:54484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nGD-0001vs-0D for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:10:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nG8-0001vk-43 for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 13:10:39 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nG2-000098-A6; Mon, 12 Dec 2022 13:10:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cgkcFJCaVNhaTHn/hlvtNrcSsbnSDOwPJ8ZaG0iFbVA=; b=Avzj4mTDR6wE iIaNQDSqOLQ2zgXaMTKNjIjWkQ96dt6rypdsXIAfvKFkEG3MMyrcOjBYFkkkx4rwF+sKB80J1rhAU TXBpKxix4jfCrOd362QTyAGE3nUCEebpLT8J8Cu4DvTukAp88yWgtACSHaFBa1cgSMQd0mpT8jOM/ KRvkzm/KBvEgCBfNFie2QhdNmsRrqAjsKIE3XhmQElVjduzMqpuDTX8JhliMOoSyo/ycTirzZH9gU e+koHKfeJZJM3p3kGJL6b8uNCGH4di2C8b/9du+pum/O8mQIP9XxzzcBOasPphYqzn0w6X/aRc5jy 6U/d+65NNl9ryjhKjS9NOA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nG1-0005fH-Gc; Mon, 12 Dec 2022 13:10:29 -0500 Date: Mon, 12 Dec 2022 20:10:32 +0200 Message-Id: <83h6y0qyqv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86k02wpl1n.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 19:51:48 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> <83mt7sr0pu.fsf@gnu.org> <86k02wpl1n.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, 59935@debbugs.gnu.org > Date: Mon, 12 Dec 2022 19:51:48 +0200 > > >> +** The argument FILTER-PREDICATE of 'list-buffers-noselect' is obsolete now. > >> +It will be removed in next versions. > > > > I thought we wanted to make the command faster in Emacs 29. I very > > much doubt that deprecation of an argument will have that effect. > > > > I'm also not sure I agree with obsoleting and removing that argument. > > We don't have enough justification for that, not yet. That it was > > introduced for a particular use case, and that use case no longer uses > > it, doesn't mean there won't be others. After all, we don't introduce > > additional arguments unless we think it will be useful in more than > > one case. > > Having both FILTER-PREDICATE and BUFFER-LIST-FUNCTION is too problematic. > Which one should take priority over another when both specified? I thought I answered that in my original proposal: > Why not leave alone that additional PREDICATE argument of > list-buffers-noselect, and add a feature where the BUFFER-LIST > argument could be a function? That's be a compatible change. Just > keep the PREDICATE argument and the code which supports it, and > document that if PREDICATE is a function, BUFFER-LIST cannot be a > function. Note the last sentence. Doesn't it resolve the difficulty in a reasonable way? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708689257655 (code B ref 59935); Mon, 12 Dec 2022 18:16:02 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 18:15:25 +0000 Received: from localhost ([127.0.0.1]:54506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nKm-0001zP-OZ for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:15:25 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nKl-0001zJ-0L for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 13:15:23 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 166A3E0006; Mon, 12 Dec 2022 18:15:15 +0000 (UTC) From: Juri Linkov In-Reply-To: <83h6y0qyqv.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 20:10:32 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> <83mt7sr0pu.fsf@gnu.org> <86k02wpl1n.fsf@mail.linkov.net> <83h6y0qyqv.fsf@gnu.org> Date: Mon, 12 Dec 2022 20:14:46 +0200 Message-ID: <86pmcoo5ex.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Why not leave alone that additional PREDICATE argument of >> list-buffers-noselect, and add a feature where the BUFFER-LIST >> argument could be a function? That's be a compatible change. Just >> keep the PREDICATE argument and the code which supports it, and >> document that if PREDICATE is a function, BUFFER-LIST cannot be a >> function. > > Note the last sentence. Doesn't it resolve the difficulty in a > reasonable way? Then support for a function in BUFFER-LIST should be implemented in emacs-29? (while keeping the recently added PREDICATE argument) From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 18:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16708693548025 (code B ref 59935); Mon, 12 Dec 2022 18:23:01 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 18:22:34 +0000 Received: from localhost ([127.0.0.1]:54552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nRi-00025N-7G for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:22:34 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nRg-00025F-QK for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 13:22:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nRb-0004D6-24; Mon, 12 Dec 2022 13:22:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x1E2Xxe7yf3+HFR8FfEwUHNzpLG2YNqRp3yJZTsbbTU=; b=k6O+y12Qu8R/ 01mo8QGs8C8U1d/5BPDsiSxKMyktrqZ77yTEGr9PXhyDjN6nbqqeWb71BI+9y7EUYIFkWdj9mnEkk lkRahiokGT+8QwOIlMGAT+bbaheDGRZeFjuwfBSpooaRUTLX4ogkGAhOTSTI3QKbyELjUifrcTH3Q 8e3MV5eziY+ULWgTNMUwj+R5xXfQ9WJ9pUj+xuy977+YzE32ZhCYdq+aWY0L2qblamfUeUmAlUK7k Q4xN0/ZkKgR1u+bPTsxI+XXJA2uJmKLgN1anzTTVYKSl428Tzd/EZcS6u9Fqlc3NcwZG2Y3a/UMwH I+1aaKviogQBvBLryikVZA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nRa-0007LN-Ai; Mon, 12 Dec 2022 13:22:26 -0500 Date: Mon, 12 Dec 2022 20:22:28 +0200 Message-Id: <83bko8qy6z.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86pmcoo5ex.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 20:14:46 +0200) References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> <83mt7sr0pu.fsf@gnu.org> <86k02wpl1n.fsf@mail.linkov.net> <83h6y0qyqv.fsf@gnu.org> <86pmcoo5ex.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: dgutov@yandex.ru, 59935@debbugs.gnu.org > Date: Mon, 12 Dec 2022 20:14:46 +0200 > > >> Why not leave alone that additional PREDICATE argument of > >> list-buffers-noselect, and add a feature where the BUFFER-LIST > >> argument could be a function? That's be a compatible change. Just > >> keep the PREDICATE argument and the code which supports it, and > >> document that if PREDICATE is a function, BUFFER-LIST cannot be a > >> function. > > > > Note the last sentence. Doesn't it resolve the difficulty in a > > reasonable way? > > Then support for a function in BUFFER-LIST should be implemented > in emacs-29? (while keeping the recently added PREDICATE argument) Yes. Why not? It cannot possibly hurt any existing callers, because they won't use a function. Right? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 19:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jean Louis , Eli Zaretskii Cc: 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167087513712264 (code B ref 59935); Mon, 12 Dec 2022 19:59:01 +0000 Received: (at 59935) by debbugs.gnu.org; 12 Dec 2022 19:58:57 +0000 Received: from localhost ([127.0.0.1]:54988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4owz-0003Bk-28 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 14:58:57 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:40696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4oww-0003Be-VZ for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 14:58:55 -0500 Received: by mail-wm1-f46.google.com with SMTP id v124-20020a1cac82000000b003cf7a4ea2caso6159405wme.5 for <59935@debbugs.gnu.org>; Mon, 12 Dec 2022 11:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=DJI+QPso5RUdQGXoEMxGm+rnsAIufEj13Wz6uENZYP0=; b=jmYLlA31XnhnxbA1y1C+lCIM7fu1i/O/pYKndac2QuEiMvNHmmAIFpiDJ1nc8ajPfG 1LXz9iOfspriYGPy/EWVhVI3ma+f8H+RkN02C7rMD5iPV1tji8XiN14pErIJkXcOL3Rd Q1WA3kJyO91obnBekX316uIEnVrji8G9WWTBYiaBcMf6HiDLm5Eo9g9NUGjZPgdOqvhN KKEEHFW7SvjUHQffMGixdmWWgGPc2UsrXkKthYarq3iKkpn/XP0VCLvMTEPKP/N/naP8 ArO833uUXERuYRPRrMdtEe033DTcVTmhnawxe4fJh5WnQW9pBYiFCa0j2MSTmhAWUbvv PzUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DJI+QPso5RUdQGXoEMxGm+rnsAIufEj13Wz6uENZYP0=; b=NRmywvbn3JuqR1ttxNSwPgnIN9psq8mabBvZAiWojC69yATDsmAtLL4KwR0fCEMsMQ W0ecZ9/Cp8U4tz55F14lrNPvbn2u3nnROgowLohjJA5ioIuKkt/QMlAHDYalk4Pv9a03 5pGxGl6aCi4A5PVKU82Xw85ukWeBbRxZHz0ej0kemo8Shh/D1hz75CJ2aXuXkGjbra/a TcQkQacJjW3NjaZeAgRsWVBIRpV5hHb4U/Tm6ghlDcW03xY6QOQYgPsttNJXZtYWHvry sYRlhJWkjV93dh0nZWCCLwCEG9OVUswWe4nWri1HcCL0xUrkvs/bNF99NMVvE7Lv6wXX iSQg== X-Gm-Message-State: ANoB5pnA3ugPzZSFHw0OvN2J8jbqg/IvoUgUdkGNsJiIZIAiVqQqXeKW vk9zpphTpOUdL3hpxBEbaLA= X-Google-Smtp-Source: AA0mqf7kIrB1z7DI+s1GeFm8pLbDJ81RmN6dGKO8vP1OZZpIZDyeBE6c57jf7p9VVdn60I0GDQcitQ== X-Received: by 2002:a05:600c:358f:b0:3d0:2815:77a1 with SMTP id p15-20020a05600c358f00b003d0281577a1mr13764959wmq.21.1670875129073; Mon, 12 Dec 2022 11:58:49 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w10-20020a05600c474a00b003c701c12a17sm10878799wmo.12.2022.12.12.11.58.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 11:58:48 -0800 (PST) Message-ID: <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> Date: Mon, 12 Dec 2022 21:58:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <83o7sby8yk.fsf@gnu.org> <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 12/12/2022 12:36, Jean Louis wrote: > If I may add to this, that project-list-buffers also incidentally > invokes re-connection of any Tramp buffers. Which part of it does? The project-buffers call, or some other step? From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 03:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167090114314306 (code B ref 59935); Tue, 13 Dec 2022 03:13:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 03:12:23 +0000 Received: from localhost ([127.0.0.1]:57378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4viR-0003if-2b for submit@debbugs.gnu.org; Mon, 12 Dec 2022 22:12:23 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:53051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4viN-0003iP-6x for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 22:12:21 -0500 Received: from localhost ([::ffff:197.239.7.93]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000C5A8F.000000006397ED93.00004B77; Mon, 12 Dec 2022 20:12:19 -0700 Date: Tue, 13 Dec 2022 06:10:16 +0300 From: Jean Louis Message-ID: References: <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * Dmitry Gutov [2022-12-12 22:59]: > On 12/12/2022 12:36, Jean Louis wrote: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tr [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.7.93 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * Dmitry Gutov [2022-12-12 22:59]: > On 12/12/2022 12:36, Jean Louis wrote: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tr [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.7.93 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * Dmitry Gutov [2022-12-12 22:59]: > On 12/12/2022 12:36, Jean Louis wrote: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tramp buffers. > > Which part of it does? The project-buffers call, or some other step? I don't know which part. All I can see is message below: Tramp: Opening connection nil for root@my.localdomain.localhost using sudo...done Because I was in sudo buffer (my.localdomain.localhost has been changed) -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/ From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 03:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 59935@debbugs.gnu.org, Dmitry Gutov Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167090114314312 (code B ref 59935); Tue, 13 Dec 2022 03:13:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 03:12:23 +0000 Received: from localhost ([127.0.0.1]:57380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4viR-0003ih-BE for submit@debbugs.gnu.org; Mon, 12 Dec 2022 22:12:23 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:52709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4viP-0003iS-Cg for 59935@debbugs.gnu.org; Mon, 12 Dec 2022 22:12:21 -0500 Received: from localhost ([::ffff:197.239.7.93]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000C5D65.000000006397ED96.00004B8B; Mon, 12 Dec 2022 20:12:22 -0700 Date: Tue, 13 Dec 2022 06:10:41 +0300 From: Jean Louis Message-ID: References: <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <868rjcsjkq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <868rjcsjkq.fsf@mail.linkov.net> User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * Juri Linkov [2022-12-12 20:20]: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tramp buffers. > > Does list-buffers invoke T [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.7.93 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * Juri Linkov [2022-12-12 20:20]: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tramp buffers. > > Does list-buffers invoke T [...] Content analysis details: (1.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 2.6 RCVD_IN_SBL RBL: Received via a relay in Spamhaus SBL [197.239.7.93 listed in zen.spamhaus.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * Juri Linkov [2022-12-12 20:20]: > > If I may add to this, that project-list-buffers also incidentally > > invokes re-connection of any Tramp buffers. > > Does list-buffers invoke Tramp re-connection as well? I have never observed it. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/ From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 15:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jean Louis Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167094540320234 (code B ref 59935); Tue, 13 Dec 2022 15:31:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 15:30:03 +0000 Received: from localhost ([127.0.0.1]:32852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p57EI-0005G6-2l for submit@debbugs.gnu.org; Tue, 13 Dec 2022 10:30:02 -0500 Received: from mail-wm1-f47.google.com ([209.85.128.47]:35705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p57EE-0005Fi-P5 for 59935@debbugs.gnu.org; Tue, 13 Dec 2022 10:30:00 -0500 Received: by mail-wm1-f47.google.com with SMTP id h8-20020a1c2108000000b003d1efd60b65so8208848wmh.0 for <59935@debbugs.gnu.org>; Tue, 13 Dec 2022 07:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=hOBZ0GeQxxuSw4mlFPTwAz3idwqj8tDomsDgRmD7SW4=; b=Z2VCaXFXLm0VxE6mboPGR+43A3TX6qcs+eTN659O4duh0mmoCXiKXl2X6x2J9RUeOu g+BBLD3Lhi0tf5ZW0VPdtZ884/xRTlAk/+0HrrBcCWbeigyRCD9NW6abyCo5hLdu7EXT iGkBG87NA7cSCk79Tg/dmpuQNDqmlUdi6WBKjKlP+1WJMaa0oaeOwtCU0ltnQIomHfQK uCDIY1gMjtb5jMHXyf2ZnsYUeUzA1rHFtmdJDcqNI5pbP6rkw0br3MDa86PduZtzSmVb 2ku+E/ADR+9qRA7EB+68mpHMKHaD4ZBkpCHBZM5vatoe9Oq1jXLZvUfRoN9Z9Z0CfdnU 1EzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hOBZ0GeQxxuSw4mlFPTwAz3idwqj8tDomsDgRmD7SW4=; b=TzC6jpCblTvyieS/SJLOcR9bpaazmGOtlbr0HBGwgHOwMFrCTHfbee+Ti/6bvu6MRy Ezkq1oL2+9gBxa8PucOyUvnbW2QFApb9pGoPLkwIww/Q7E/CdXay6nVMAIJWoEt/A2r8 jobWWN1ACOZxEVC8dA6VoVY+GuEYrginIYD0cZnr/Ywl7/8JqqbjypKdR5foWuaiF8Ct jf7yInMTwPi+M/RJpCL9gxuUuCCqA/HKG7s9vBlb9UzHc8Cg3kYAp+bivnv3SN/b1UdZ +SaKKvglOF/CQlbvJcY3IlEGpUOlqgnhj8en+XqFfy7E4upk9SP1v/I+8OIALFycgEDf 1e4A== X-Gm-Message-State: ANoB5pkluuEn0Naw6NxLMCyolENfLnjV+jP9hc99d5BgicVeoJR2BWsv IKoNqMLLvKhzW5oeNEn1zto= X-Google-Smtp-Source: AA0mqf5coIJpOwc+u5Elk/l3CO+6mKdNbV+MklraMxom6USZM1Cxta9KuikhS3LllYdxsXaaRs166A== X-Received: by 2002:a05:600c:3ac8:b0:3c6:e63e:89c5 with SMTP id d8-20020a05600c3ac800b003c6e63e89c5mr16144168wms.33.1670945392687; Tue, 13 Dec 2022 07:29:52 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id iw3-20020a05600c54c300b003d220ef3232sm9906848wmb.34.2022.12.13.07.29.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 07:29:51 -0800 (PST) Message-ID: <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> Date: Tue, 13 Dec 2022 17:29:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <33ee7805-b5ee-ce62-042f-d980184e327e@yandex.ru> <838rjfy0kx.fsf@gnu.org> <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 13/12/2022 05:10, Jean Louis wrote: > * Dmitry Gutov [2022-12-12 22:59]: >> On 12/12/2022 12:36, Jean Louis wrote: >>> If I may add to this, that project-list-buffers also incidentally >>> invokes re-connection of any Tramp buffers. >> Which part of it does? The project-buffers call, or some other step? > I don't know which part. All I can see is message below: You can find out by stepping through project-list-buffers with edebug. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 17:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 59935@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16709538653209 (code B ref 59935); Tue, 13 Dec 2022 17:52:01 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 17:51:05 +0000 Received: from localhost ([127.0.0.1]:33634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59Qn-0000pg-3R for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:51:05 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:32923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59Ql-0000op-NO; Tue, 13 Dec 2022 12:51:04 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31A61E0009; Tue, 13 Dec 2022 17:50:55 +0000 (UTC) From: Juri Linkov In-Reply-To: <83bko8qy6z.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Dec 2022 20:22:28 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> <83359lu5o6.fsf@gnu.org> <70602760-546c-0c7c-b4a9-fdfe8d2c4e5e@yandex.ru> <83wn6xsme7.fsf@gnu.org> <86359ksj29.fsf@mail.linkov.net> <83mt7sr0pu.fsf@gnu.org> <86k02wpl1n.fsf@mail.linkov.net> <83h6y0qyqv.fsf@gnu.org> <86pmcoo5ex.fsf@mail.linkov.net> <83bko8qy6z.fsf@gnu.org> Date: Tue, 13 Dec 2022 19:49:39 +0200 Message-ID: <865yeftcr0.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 59935 29.0.60 thanks >> Then support for a function in BUFFER-LIST should be implemented >> in emacs-29? (while keeping the recently added PREDICATE argument) > > Yes. Why not? It cannot possibly hurt any existing callers, because > they won't use a function. Right? So now pushed to emacs-29 and closed. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16709538733228 (code B ref 59935); Tue, 13 Dec 2022 17:52:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 17:51:13 +0000 Received: from localhost ([127.0.0.1]:33639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59Qu-0000q0-MU for submit@debbugs.gnu.org; Tue, 13 Dec 2022 12:51:12 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:33393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p59Qs-0000pf-PK for 59935@debbugs.gnu.org; Tue, 13 Dec 2022 12:51:11 -0500 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4058CC000A; Tue, 13 Dec 2022 17:50:59 +0000 (UTC) From: Juri Linkov In-Reply-To: <119c73c2-b219-5ee6-6fb3-c92d7ffea37d@yandex.ru> (Dmitry Gutov's message of "Sun, 11 Dec 2022 20:37:51 +0200") Organization: LINKOV.NET References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <119c73c2-b219-5ee6-6fb3-c92d7ffea37d@yandex.ru> Date: Tue, 13 Dec 2022 19:49:47 +0200 Message-ID: <864jtztcqs.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Here's an idea: when 'list-buffers-noselect' received a plain list of > buffers in its BUFFER-LIST argument, it doesn't save that anywhere. > > That seems like a bug, doesn't it? That hitting 'g' in such a buffer-list > buffer resets its contents to all buffer (except hidden, etc). > > So it probably makes sense to save it as well. > > Long story short, I suggest to name the new variable > Buffer-menu-buffer-list, and save the value of the BUFFER-LIST argument to > it no matter what. And, likewise, use it. But when the value is a function, > call it to obtain the actual list. Thanks for the idea. Implemented in the commit a99d0e7e6c9. > One side-effect of this, though, is that the BUFFER-LIST argument to > list-buffers--refresh will have no purpose anymore. I'm not sure about removing the old argument BUFFER-LIST from list-buffers--refresh, even though it's an internal function. It also has another argument OLD-BUFFER that could be turned later into buffer-local, to keep the current buffer marker after revert. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 18:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 59935@debbugs.gnu.org Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167095750023713 (code B ref 59935); Tue, 13 Dec 2022 18:52:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 18:51:40 +0000 Received: from localhost ([127.0.0.1]:33999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ANQ-0006AP-EF for submit@debbugs.gnu.org; Tue, 13 Dec 2022 13:51:40 -0500 Received: from mail-wr1-f52.google.com ([209.85.221.52]:40846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ANO-0006AJ-OY for 59935@debbugs.gnu.org; Tue, 13 Dec 2022 13:51:39 -0500 Received: by mail-wr1-f52.google.com with SMTP id m14so16680799wrh.7 for <59935@debbugs.gnu.org>; Tue, 13 Dec 2022 10:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=jxTNiiAIdle44zr9o+z1nq2Q6O2t1qDmHPR/00XPuFw=; b=GPFuRJdsQpGxQwEMRbsGSqQ9A8PXeC1XR287uJwmtGvqulupdH08vtVCmib4QBUJaR 0qF7ylwuzsZSKOBgwNLrF+eIITT1V61gV+RNNBu1+sy0zrJQGKyWR6mgN0UGshGxvfpi ZPhSJ8e8V+QWrJyqHKDLVIEFGKOD/BCdeFPdlSD/1QlrXGvFm6KneB00fhkYG+wNuyNG s5RSGTMs3jyjCMKnyTQUKwTSJKQA4eGnT4mL6TlYOuwWolmVSYymMuJJ1ttyhdBkn431 Fg82W6HCSHsh2v6rjEEcbJ+gNi79TYlAcAYti8oDNF75x5OVBuV8NZ5sE3d01x1oXfcR +ceA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jxTNiiAIdle44zr9o+z1nq2Q6O2t1qDmHPR/00XPuFw=; b=XeZ2sS4HW6WS5rm4gY1yBHS7AaAd3nr9lyMfpN9GbNKavivS1cnX2yyIz3huZDloYt sGnk3ym3SP6YgjHONwTmPg7ClkMb7PdPiRSD4pgiJUmXDRUCoN3YurCEbU7sY6Et/7Lw h/RdBDlmI5kKatbg58Flm/Z1l0669pPy7PIkKh4K74vpDJO+79jTP540dFVi4nSaQDhu 6sAb42LZoSAetWa48Un0f3gIxg+CVlce6dbd4ZNsjVTwxWBcrvbbMbSHut/gP4a72g+V 4C5RovkIKaE/Z5t5BY/9hldhVkEwBjbGaFPib4Mx4WSdohEwj1TMYWBxXWejjJ5qmnX9 zCrA== X-Gm-Message-State: ANoB5pnKZLoaRvJP+mU4qyLja3xRtjpexlLdTXw/BIXtfcK0T6aTZDlS vP3XrUKGc7D9gX0IgqcFO6o= X-Google-Smtp-Source: AA0mqf6z5I8WNHGkfxtDjUQrLnN9rtWPdJMXu0gdK1CElbFVqHYKiLlxvJhoJOLKuylh/Dc0WjD6qA== X-Received: by 2002:a5d:4848:0:b0:242:8b69:cf2b with SMTP id n8-20020a5d4848000000b002428b69cf2bmr14783260wrs.47.1670957492460; Tue, 13 Dec 2022 10:51:32 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id j14-20020a5d564e000000b0024165454262sm556620wrw.11.2022.12.13.10.51.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 10:51:31 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 20:51:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <119c73c2-b219-5ee6-6fb3-c92d7ffea37d@yandex.ru> <864jtztcqs.fsf@mail.linkov.net> From: Dmitry Gutov In-Reply-To: <864jtztcqs.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 13/12/2022 19:49, Juri Linkov wrote: >> Here's an idea: when 'list-buffers-noselect' received a plain list of >> buffers in its BUFFER-LIST argument, it doesn't save that anywhere. >> >> That seems like a bug, doesn't it? That hitting 'g' in such a buffer-list >> buffer resets its contents to all buffer (except hidden, etc). >> >> So it probably makes sense to save it as well. >> >> Long story short, I suggest to name the new variable >> Buffer-menu-buffer-list, and save the value of the BUFFER-LIST argument to >> it no matter what. And, likewise, use it. But when the value is a function, >> call it to obtain the actual list. > > Thanks for the idea. Implemented in the commit a99d0e7e6c9. Thank you. >> One side-effect of this, though, is that the BUFFER-LIST argument to >> list-buffers--refresh will have no purpose anymore. > > I'm not sure about removing the old argument BUFFER-LIST from > list-buffers--refresh, even though it's an internal function. Maybe sometime later on master. > It also has another argument OLD-BUFFER that could be turned later > into buffer-local, to keep the current buffer marker after revert. Why not. Although at that point which of the buffers was current previously doesn't seem too important. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167095995925138 (code B ref 59935); Tue, 13 Dec 2022 19:33:01 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 19:32:39 +0000 Received: from localhost ([127.0.0.1]:34177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5B15-0006XO-4o for submit@debbugs.gnu.org; Tue, 13 Dec 2022 14:32:39 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:48161) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5B11-0006XI-UK for 59935@debbugs.gnu.org; Tue, 13 Dec 2022 14:32:37 -0500 Received: from localhost ([::ffff:197.239.12.90]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 00000000000561FD.000000006398D353.00003B6B; Tue, 13 Dec 2022 12:32:35 -0700 Date: Tue, 13 Dec 2022 22:30:59 +0300 From: Jean Louis Message-ID: References: <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Dmitry Gutov [2022-12-13 18:30]: > On 13/12/2022 05:10, Jean Louis wrote: > > * Dmitry Gutov [2022-12-12 22:59]: > > > On 12/12/2022 12:36, Jean Louis wrote: > > > > If I may add to this, that project-list-buffers also incidentally > > > > invokes re-connection of any Tramp buffers. > > > Which part of it does? The project-buffers call, or some other step? > > I don't know which part. All I can see is message below: > > You can find out by stepping through project-list-buffers with edebug. It iterates over results of list-buffers-noselect and among many buffers finds those Tramp buffers. But why those Tramp buffers start re-connecting I do not know. For me this description below is not what that function does, as that function seem not to select properly. What are project buffers? Are they not files which are in directories specified as project? It seems that function is iterating over buffers not necessary to iterate. project-list-buffers is an autoloaded interactive Lisp closure in ‘project.el’. It is bound to C-x p C-b. (project-list-buffers &optional ARG) Display a list of project buffers. The list is displayed in a buffer named "*Buffer List*". By default, all project buffers are listed except those whose names start with a space (which are for internal use). With prefix argument ARG, show only buffers that are visiting files. -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/ From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Dec 2022 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jean Louis Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167096351927473 (code B ref 59935); Tue, 13 Dec 2022 20:32:02 +0000 Received: (at 59935) by debbugs.gnu.org; 13 Dec 2022 20:31:59 +0000 Received: from localhost ([127.0.0.1]:34483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5BwV-000793-4M for submit@debbugs.gnu.org; Tue, 13 Dec 2022 15:31:59 -0500 Received: from mail-wr1-f45.google.com ([209.85.221.45]:43665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5BwO-00078w-Nq for 59935@debbugs.gnu.org; Tue, 13 Dec 2022 15:31:57 -0500 Received: by mail-wr1-f45.google.com with SMTP id h12so16986639wrv.10 for <59935@debbugs.gnu.org>; Tue, 13 Dec 2022 12:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=AsWupXWa+OHJxgD7bhob7MWIBel24w/E6Czb5MDtAoI=; b=opYfNHAbbw0OAkVBPcL8h68a2NDR3b6q1XD6r/HsH8X3d0ZudqIBl2OK86Os8rLC/u LFAbkZ6/p+ZV87eshr5EEXaWYcfAwyJg5oyQPqxEu96JslsF9lTc5qpzR4IbzU3Urr2g S8RwYyfqstivjI8LW7JiMZKj5S39SfhjiLKl1AosysFlNf5cpr+LbbZUROa5EMEdS9gW fdDLFwfe5YxYRbCbtG2EDz6yXLKl3n1nnWFDBS0e6JQph5+qGWipema1LgjG7UAT/3zP qDVvN5YRDNGScuQCatRFEMqGvlqwfQG3aCwVb6EZJzfGiqhkhLp0G3Sl0b0Hd+PKcyOM EBMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AsWupXWa+OHJxgD7bhob7MWIBel24w/E6Czb5MDtAoI=; b=FsKzfYP9AoVMSYGlDspHyB9FPP6wy5kDlW8TUEzdQv/Ed13iPoldRoXoUhl2pdWwY7 nUweIc9tVEyAaHWDOMqI5LDv0lE54Gk+IWcR2dOh0aWrchEiBqIalmvkYgH7icJNRyFy ePcWJoD1WnWIBsKpxxEHtONnHrQC0SXMmY9emQ+GM8umlTt7juA0ro3Fycc8j4fTrPX0 IY6d9q+3RVhXJwkUuHzvkzzqmr5eNFAxqUYcYby24Yu4IT03DICr452jYV+J9LcEILMy p6J2ahrna62td99ODXbmWvagVAW3QzrJy1fbIcZq7TgY6CzRdvt4UEGIUL86CQi1DT0f XdYg== X-Gm-Message-State: ANoB5pmqeKI7iKRF70tJXxTNDDkdVus4p5zzmwbfJEii5zBvS/jbVKyF Q2AFuYaH0T2AjQRLaCKqF/Q= X-Google-Smtp-Source: AA0mqf7V307Xc5vLPtmSzGl1CoMtqrBC+3Wh7vCOiNTYTtTlfQoaYWCnPpSkkC2YdaCcpyVwGnmkIA== X-Received: by 2002:a5d:4888:0:b0:232:be5c:ec7e with SMTP id g8-20020a5d4888000000b00232be5cec7emr13816961wrq.58.1670963506808; Tue, 13 Dec 2022 12:31:46 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g5-20020adffc85000000b0023677081f3asm734082wrr.42.2022.12.13.12.31.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Dec 2022 12:31:46 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 22:31:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <2fe25562-401b-1b7b-d3fd-8d0820f4567c@yandex.ru> <83h6y3wco8.fsf@gnu.org> <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 13/12/2022 21:30, Jean Louis wrote: > * Dmitry Gutov [2022-12-13 18:30]: >> On 13/12/2022 05:10, Jean Louis wrote: >>> * Dmitry Gutov [2022-12-12 22:59]: >>>> On 12/12/2022 12:36, Jean Louis wrote: >>>>> If I may add to this, that project-list-buffers also incidentally >>>>> invokes re-connection of any Tramp buffers. >>>> Which part of it does? The project-buffers call, or some other step? >>> I don't know which part. All I can see is message below: >> >> You can find out by stepping through project-list-buffers with edebug. > > It iterates over results of list-buffers-noselect and among many > buffers finds those Tramp buffers. But why those Tramp buffers start > re-connecting I do not know. So 'M-x list-buffers' or 'C-x C-b' have the same effect? This is not specific to project-list-buffers? > For me this description below is not what that function does, as that > function seem not to select properly. What are project buffers? Are > they not files which are in directories specified as project? It seems > that function is iterating over buffers not necessary to iterate. The answer to what buffers are project buffers is encoded in each project backend's implementation of 'project-buffers'. The default considers non-file buffers as well. From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Jean Louis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 14:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167111631327485 (code B ref 59935); Thu, 15 Dec 2022 14:59:01 +0000 Received: (at 59935) by debbugs.gnu.org; 15 Dec 2022 14:58:33 +0000 Received: from localhost ([127.0.0.1]:43145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pgu-00079F-Q1 for submit@debbugs.gnu.org; Thu, 15 Dec 2022 09:58:33 -0500 Received: from stw1.rcdrun.com ([217.170.207.13]:56623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pgs-000799-Kj for 59935@debbugs.gnu.org; Thu, 15 Dec 2022 09:58:31 -0500 Received: from localhost ([::ffff:102.85.142.63]) (AUTH: PLAIN admin, TLS: TLS1.3,256bits,ECDHE_RSA_AES_256_GCM_SHA384) by stw1.rcdrun.com with ESMTPSA id 000000000005611E.00000000639B3617.00004D6A; Thu, 15 Dec 2022 07:58:31 -0700 Date: Thu, 15 Dec 2022 17:58:06 +0300 From: Jean Louis Message-ID: References: <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9+54 (af2080d) (2022-11-21) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * Dmitry Gutov [2022-12-13 23:32]: > > It iterates over results of list-buffers-noselect and among many > > buffers finds those Tramp buffers. But why those Tramp buffers start > > re-connecting I do not know. > > So 'M-x list-buffers' or 'C-x C-b' have the same effect? This is not > specific to project-list-buffers? Not, it is specific to project-list-buffers and not to list-buffers. > > For me this description below is not what that function does, as that > > function seem not to select properly. What are project buffers? Are > > they not files which are in directories specified as project? It seems > > that function is iterating over buffers not necessary to iterate. > > The answer to what buffers are project buffers is encoded in each project > backend's implementation of 'project-buffers'. > > The default considers non-file buffers as well. How do I define non-default? -- Jean Take action in Free Software Foundation campaigns: https://www.fsf.org/campaigns In support of Richard M. Stallman https://stallmansupport.org/ From unknown Fri Aug 15 20:05:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#59935: 29.0.60; project-list-buffers is slow Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 15:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Jean Louis Cc: Eli Zaretskii , 59935@debbugs.gnu.org, juri@linkov.net Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.167111716228145 (code B ref 59935); Thu, 15 Dec 2022 15:13:01 +0000 Received: (at 59935) by debbugs.gnu.org; 15 Dec 2022 15:12:42 +0000 Received: from localhost ([127.0.0.1]:43229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5pub-0007Jt-Pn for submit@debbugs.gnu.org; Thu, 15 Dec 2022 10:12:42 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:43875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5puY-0007Jn-5m for 59935@debbugs.gnu.org; Thu, 15 Dec 2022 10:12:40 -0500 Received: by mail-wm1-f49.google.com with SMTP id k22-20020a05600c1c9600b003d1ee3a6289so2084991wms.2 for <59935@debbugs.gnu.org>; Thu, 15 Dec 2022 07:12:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=D5XngivTq6bg4JnZTTWv9nK2+CateVXA34r8feZA3mg=; b=R8p5xvp2WS8Uv04W0SeFo8dVrXwE1v0sk50J9mRu61IIOVg/M2XS4YfLTiek5UqNt0 b/15AE8kKh5JATyPSSCYeDesK/0sDeA7ZOdE7/ORgN9AEVoMEMnhhX8LFyppNqkzj0Iz b6afOI/lkIIiS8Bo7HOCdKA+n/WCWNtDnV5UUVmKCfWnFsrtq3mqmXws7b1INZSEH0Kc ueDvm8SjGG6vQEhCmUGzHRPjtGPfihiumuG3+QX2duXh4z9VDHv85aghpQUI2hpqIq+J EVwkdLtbm+eMNl8DnEEIB15g58SrueBeKbkIW22Ace4O6Cjf0s3pE7DsfaK3lc26DfrB khHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D5XngivTq6bg4JnZTTWv9nK2+CateVXA34r8feZA3mg=; b=0rKoRj+U5l6SBuF/WLO0kiaBdVo5dq4d1wdznKdzFLHt09Ni+SwvKqJmI6ykQaGAmb +sQdyxNQPasAqauW8nRMwEbuNKjqCBkn5/CVzl/fjPVAzZAO44f6sOdg52wJw1Y316eq 52hPFA7TjZMOfzF8l8/JNVIK39YIw41sfFER3X9nRpkadwubRjypqd/AEV5wwq0+Hbjw YCUI7R8w0+3CYwBdbM+NYoYpf89cB57+/aFT478xPnn4Y4dX1q5/3SCmR/+ife6Vc5MP dvNhHaTsAP3viE5UeeD6w9AFbjXiEBdQteky0OkHweXYtgOIi253dy9paUjMj7zgBLBC ZnLQ== X-Gm-Message-State: ANoB5pkhJxPzbOVPbp7+WoyiNmUd+H7KDFtc8w1PqiZ9DPxEV9kGYn6i s2RRexMdl5tbQpXJBib3OTQ= X-Google-Smtp-Source: AA0mqf4jjYJeBU663EDT8czHKWkF1KHEruySv5Ru4iuLiyOkF4BsM3YJHocuF9GHntNClVy1Jm57Gg== X-Received: by 2002:a05:600c:17d5:b0:3d1:f2de:195a with SMTP id y21-20020a05600c17d500b003d1f2de195amr21947265wmo.32.1671117152120; Thu, 15 Dec 2022 07:12:32 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id iv19-20020a05600c549300b003d09150b339sm7968776wmb.20.2022.12.15.07.12.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 07:12:31 -0800 (PST) Message-ID: <786bf9fe-d271-3970-5720-13f902545ebe@yandex.ru> Date: Thu, 15 Dec 2022 17:12:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <834ju3vyeb.fsf@gnu.org> <16e4e192-21f9-c46d-2e86-5c24fd4962b7@yandex.ru> <831qp7vx26.fsf@gnu.org> <723155fb-392e-8b51-6e15-07ff427067f6@yandex.ru> <4a0daa6b-4b4a-8db3-6689-d22f404e3ab8@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On 15/12/2022 16:58, Jean Louis wrote: > * Dmitry Gutov [2022-12-13 23:32]: >>> It iterates over results of list-buffers-noselect and among many >>> buffers finds those Tramp buffers. But why those Tramp buffers start >>> re-connecting I do not know. >> >> So 'M-x list-buffers' or 'C-x C-b' have the same effect? This is not >> specific to project-list-buffers? > > Not, it is specific to project-list-buffers and not to list-buffers. Then could you explain it in more detail? When you say "It iterates over results of list-buffers-noselect", what is "it"? Surely not project-list-buffers itself: list-buffers-noselect returns a buffer, not a list anyway. >>> For me this description below is not what that function does, as that >>> function seem not to select properly. What are project buffers? Are >>> they not files which are in directories specified as project? It seems >>> that function is iterating over buffers not necessary to iterate. >> >> The answer to what buffers are project buffers is encoded in each project >> backend's implementation of 'project-buffers'. >> >> The default considers non-file buffers as well. > > How do I define non-default? By either redefinining project-vc's project-buffers method, or writing your own entire backend.