From unknown Thu Aug 14 17:30:14 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59929 <59929@debbugs.gnu.org> To: bug#59929 <59929@debbugs.gnu.org> Subject: Status: [PATCH]: Eglot, request progress notification on server init Reply-To: bug#59929 <59929@debbugs.gnu.org> Date: Fri, 15 Aug 2025 00:30:14 +0000 retitle 59929 [PATCH]: Eglot, request progress notification on server init reassign 59929 emacs submitter 59929 Danny Freeman severity 59929 wishlist tag 59929 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 15:07:38 2022 Received: (at submit) by debbugs.gnu.org; 9 Dec 2022 20:07:38 +0000 Received: from localhost ([127.0.0.1]:38204 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3jej-0002ii-Ks for submit@debbugs.gnu.org; Fri, 09 Dec 2022 15:07:37 -0500 Received: from lists.gnu.org ([209.51.188.17]:33214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3jeh-0002ia-6C for submit@debbugs.gnu.org; Fri, 09 Dec 2022 15:07:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3jee-0002bU-4f for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 15:07:35 -0500 Received: from out2.migadu.com ([2001:41d0:2:aacc::]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3jeb-000074-EJ for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 15:07:31 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1670616447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=2WPDMOFzeSFgaSoB26KDA3cUgz9VwGeiax4rAZHxndI=; b=TLHbGy51zo3M8CxHHDUP5xyiqmyIgKm4DkRG119ck6dMtjxe1JA1tn4Fh/jeqFKUGDrfxo NTjhRMLRtoBDfmV4+MbMkGYVV18mvc4xN6F+fE/u430DI10TZrTCc+YHQhomDWkWBXfD07 4RSXLylG3V2YDotj4gL9rsoyXBQSjM4= From: Danny Freeman To: bug-gnu-emacs@gnu.org Subject: [PATCH]: Eglot, request progress notification on server init Date: Fri, 09 Dec 2022 14:55:05 -0500 Message-ID: <87y1rgtk78.fsf@dfreeman.email> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:2:aacc::; envelope-from=danny@dfreeman.email; helo=out2.migadu.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain I would like to propose a change to Eglot that builds on my last patch in bug 59149. What I did not realize at the time of writing that patch, is that clients can opt into receiving progress notifications for server initialization when sending the `:initialize` request. This is useful for slow starting servers or large projects that require the lsp server to do a lot of analysis on startup. The server of course has to be able to send these progress reports. Not all of them do and may ignore this parameter. If users do not want to see this, they can set `eglot-report-progress` to `nil`. There are other requests that extend the WorkDoneProgressParams interface that this could also be done for. It may be worth looking through the spec and seeing if it makes sense to send this param with other requests. Many of them are for typically quick requests like `textDocument/definition` Thank you, -- Danny Freeman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Eglot-show-progress-reports-for-slow-starting-server.patch Content-Description: Eglot report initialization progress >From 1b81fa34ff282bfca0f754afad2c9eca04ad7985 Mon Sep 17 00:00:00 2001 From: dannyfreeman Date: Fri, 9 Dec 2022 14:40:01 -0500 Subject: [PATCH] Eglot: show progress reports for slow starting servers * lisp/progmodes/eglot.el (eglot--connect): report progress on initialization This takes advantage of the new `eglot-handle-notification` implementation of the LSP $/progress method. Slow starting servers will now show their progress in the minibuffer if `eglot-report-progress` is `t`. The server must also opt in to providing the $/progress notifications. See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize for more information on the InitializeParams interface. --- lisp/progmodes/eglot.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index a53f62fc565..cceb9fb5b32 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -1291,7 +1291,10 @@ eglot--connect :initializationOptions (eglot-initialization-options server) :capabilities (eglot-client-capabilities server) - :workspaceFolders (eglot-workspace-folders server)) + :workspaceFolders (eglot-workspace-folders server) + ;; Request $/progress notifications from the + ;; server on startup. + :workDoneToken "initialize") :success-fn (eglot--lambda ((InitializeResult) capabilities serverInfo) (unless canceled -- 2.38.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:56:57 2022 Received: (at 59929) by debbugs.gnu.org; 9 Dec 2022 21:56:57 +0000 Received: from localhost ([127.0.0.1]:38759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3lMX-0006K0-48 for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:56:57 -0500 Received: from out2.migadu.com ([188.165.223.204]:16192) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3lMU-0006Js-SN for 59929@debbugs.gnu.org; Fri, 09 Dec 2022 16:56:56 -0500 References: <87y1rgtk78.fsf@dfreeman.email> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1670623013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=elJDtJ27YjA9erITB8249lLWTrDHkDIzr6E6WmqiEeY=; b=JE6/JGy6ViypWflswhfUZJY6htzVXuwzOZETzDyDDVc03mdn5l+wvB5HA0XvwP/4pDs0qm ChSm7HzwQL/PNN1eCp+oANkseW0lqIsm9mRQWnC08FH0HJ7WFmVEEJgSHcdSkVEVHP3tXd W/Se+ecTfqXiQxGUGtvCSkJ7I9QAKhM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Danny Freeman To: 59929@debbugs.gnu.org Subject: Re: [PATCH]: Eglot, request progress notification on server init Date: Fri, 09 Dec 2022 15:59:24 -0500 In-reply-to: Message-ID: <87k030tf4t.fsf@dfreeman.email> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Another patch for consideration related to the first in this thread, I've confirmed that clients can signal to servers that they are willing to accept server initiated progress notifications with the client capability in the attached patch. Note: there is still no server capability for this that can be ignored, and the `eglot-report-progress` defcustom remains relevant here. Any server initiated progress report will be ignored if `eglot-report-progress` is `nil`. Server will send a `window/workDoneProgress/create` request, but nothing needs to be done with it. That request will be followed by the already implemented $/progress notifications. I need to find a server that I can test this with before this patch is applied. I will report back in this thread once I've done that. -- Danny Freeman --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Eglot-Enable-server-initiated-progress-reports.patch >From f30bd7d7396d29c38249a232e36f4b811dd27f56 Mon Sep 17 00:00:00 2001 From: dannyfreeman Date: Fri, 9 Dec 2022 15:55:28 -0500 Subject: [PATCH] Eglot: Enable server initiated progress reports * lisp/progmodes/eglot (eglot-client-capabilities): servers can initiate progress reports --- lisp/progmodes/eglot.el | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index cceb9fb5b32..e909efdb6f4 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -728,6 +728,7 @@ eglot-client-capabilities "What the Eglot LSP client supports for SERVER." (:method (s) (list + :window (list :workDoneProgress t) :workspace (list :applyEdit t :executeCommand `(:dynamicRegistration :json-false) @@ -2062,6 +2063,10 @@ eglot-handle-notification (_server (_method (eql telemetry/event)) &rest _any) "Handle notification telemetry/event.") ;; noop, use events buffer +(cl-defmethod eglot-handle-reqeust + (_server (_method (eql window/workDoneProgress/create)) &rest _any) + "Handle request window/workDoneProgress/create.") ;; noop, use events buffer + (cl-defmethod eglot-handle-notification (server (_method (eql $/progress)) &key token value) "Handle $/progress notification identified by TOKEN from SERVER." -- 2.38.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 19:48:47 2022 Received: (at control) by debbugs.gnu.org; 13 Dec 2022 00:48:47 +0000 Received: from localhost ([127.0.0.1]:56609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tTS-0000zA-Vp for submit@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:47 -0500 Received: from mail-ot1-f51.google.com ([209.85.210.51]:38685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4tTR-0000yl-H0 for control@debbugs.gnu.org; Mon, 12 Dec 2022 19:48:46 -0500 Received: by mail-ot1-f51.google.com with SMTP id v19-20020a9d5a13000000b0066e82a3872dso8406452oth.5 for ; Mon, 12 Dec 2022 16:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=DvtRP6hCNT6V9nC992XsREEnfvbz/MQWHFksm1j4UpI=; b=GoTTVPgWzi3IAQd/U8XA9HXv3RN4Rgro1XgfBxhn8Awr+ciO+Y5uNGPbIYan8LjrB5 iSz8DblMj92ZWHFKivw6CjzyHn4BVOk0hH9ACejGINN6rdruuBjHL7UHx0zc7AzXBhpO IFuMApduJB2uL4qYxY507KJhuhAdpoBEwz+YQ6JEijTVJalssRZKRrPx1f5WnZCzZbIf iIUM7qfrnvcPgeo8oNufPUPOyiKZsZQmbQiBuchXSOgfAPVlWbVHCjpkJKm/1acof39a WMvwNb9yWqFCP9Yt0oristZAF0XYTU9MDTocbzyFBURkhIsBA/tRbQUwMKog77brozWi chWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DvtRP6hCNT6V9nC992XsREEnfvbz/MQWHFksm1j4UpI=; b=Qf2MeQzfqzEDExmupZxXK3q7tNX+BRH6o1/isnfgn0OkhLOjD3eQpTGTNmlGqeqend Cqn1b2/AkbJjJDB7cDbc4r453H0Y/SacnxRaGTkzN7xNr8/0yrXqt1HWiBz1NBz+WwtQ 9+3KO2b2wbSfVSabNy6kqHncCvYyNFZlmX8U3rBhTbnHfo2x95ZUGZYjeIfMZHpsWjnO WeKfaz+6cl/Vul1glFLXzhD8U9HO4s5OHoAFXaaVJq7SpHdMZhokbdgdrbzQw8pRiqJA OR+Jcml1qL58lXTqtcUgJHB1WaPFifeYt/5fnmonPrJzOzkx5Pi5zngbJ/1jL8e2perN MfsQ== X-Gm-Message-State: ANoB5pk8XgmxykMi35qPE8cyT3rtYKjjgbTYElkSuHx5dAFItuY/UxV9 2ztL7vHzBSxa6mwOmCJPRZ56mtREupbFJxAfKrNMuEiT X-Google-Smtp-Source: AA0mqf4paKIsgrizFU6XpAkZGObi6+0U+1HkcqM1yH4546zwlMFOep10HjyV3kBe35nnXVEYerf6p1CdE3+Exldah0I= X-Received: by 2002:a05:6830:11cd:b0:66e:7741:ed1d with SMTP id v13-20020a05683011cd00b0066e7741ed1dmr11473608otq.224.1670892519964; Mon, 12 Dec 2022 16:48:39 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 12 Dec 2022 16:48:39 -0800 From: Stefan Kangas X-Hashcash: 1:20:221213:control@debbugs.gnu.org::TGF8caDnAhVEzDYR:1d0z MIME-Version: 1.0 Date: Mon, 12 Dec 2022 16:48:39 -0800 Message-ID: Subject: control message for bug #59929 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 59929 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 25 15:12:07 2023 Received: (at 59929) by debbugs.gnu.org; 25 Mar 2023 19:12:07 +0000 Received: from localhost ([127.0.0.1]:43509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9J9-00021e-7E for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:12:07 -0400 Received: from out-16.mta1.migadu.com ([95.215.58.16]:34404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9J6-00021S-8o for 59929@debbugs.gnu.org; Sat, 25 Mar 2023 15:12:05 -0400 References: <87y1rgtk78.fsf@dfreeman.email> <87k030tf4t.fsf@dfreeman.email> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1679771520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BS6DyXrrrkljLYwSCHr+fd7rDEVdncIr0Ra+yRbWku8=; b=ar03x8J16VtWEnCIDRXco7aoYE1hPhHaztUPNP1sRnx7LxZXRl4Dt9xG6/g0pTBQZ4HVUN 3hgBDjqeu6lQdRObZm9wwoI5wQXA+qsCmuuMdZVUq3AE4hssa1irMs6e7OIJbQk+7cUKrx XKRm7uIOqXtOhfBcUw0DpL5cJlBoje0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Danny Freeman To: 59929@debbugs.gnu.org, =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: [PATCH]: Eglot, request progress notification on server init Date: Sat, 25 Mar 2023 15:10:20 -0400 In-reply-to: <87k030tf4t.fsf@dfreeman.email> Message-ID: <87fs9s7iiq.fsf@dfreeman.email> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59929 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Danny Freeman writes: > Another patch for consideration related to the first in this thread, > I've confirmed that clients can signal to servers that they are willing > to accept server initiated progress notifications with the client > capability in the attached patch. > > Note: there is still no server capability for this that can be ignored, > and the `eglot-report-progress` defcustom remains relevant here. Any > server initiated progress report will be ignored if > `eglot-report-progress` is `nil`. > > Server will send a `window/workDoneProgress/create` request, but nothing > needs to be done with it. That request will be followed by the already > implemented $/progress notifications. > > I need to find a server that I can test this with before this patch is > applied. I will report back in this thread once I've done that. I think this bug can be closed. It is old and I lost track of it, but some recent commits in Emacs I think addressed this - 82523dc621ace104d8f379509a436fcb03c48c26 - 47d8e4b0d3835f5e0b0b6ab76f242ef0aa25bda7 Thank you, Danny Freeman From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 25 15:13:44 2023 Received: (at 59929-done) by debbugs.gnu.org; 25 Mar 2023 19:13:45 +0000 Received: from localhost ([127.0.0.1]:43513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9Ki-00024F-Jr for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:13:44 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:35491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9Kg-00023z-M4 for 59929-done@debbugs.gnu.org; Sat, 25 Mar 2023 15:13:43 -0400 Received: by mail-oi1-f170.google.com with SMTP id s8so3634657ois.2 for <59929-done@debbugs.gnu.org>; Sat, 25 Mar 2023 12:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679771617; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=by5M0R54r0bdrrecdMGGR/t42uvgtk7+k1NFH/mObMo=; b=BiwKUV/dv2pACbaaYuKsATHu2QG054LXwayR3hFHg2n67tstW1QEp7HJsm1Per3ulP n5XkWCAGkT437nI6PfBPUcRjW+QWJt9nCHdy1ejLEfndbVHMZIe49swhvhE2Dphwl1mY pa1SqjpJiDfkj4+aS0KEfukw79nC66hl/7Jtn5qiWNvZTILoGHTCQMsGzF7hY21CHcwU Gfp7Hlu9ZlWhk0A+A57A4SvS05nR3d39GNFceZ/g02e6ZFIdQ/8DvDDjVAVgRoulizJy y6QskdLE8uV6ORX/RMGn8IYyZ9jXfOZ/0wI/L063WI9MeWl/Y8uq3nUXog2MsCFTJD9P v4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679771617; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=by5M0R54r0bdrrecdMGGR/t42uvgtk7+k1NFH/mObMo=; b=IdqXuECeZe1QkAHgdfY7l6XBVG2cJjI/FHeQdrPjbYvc5tjJb4IvZjqKmluZPtA7wa I2QuuS8Glf1H7BewVP+ZnERaS2lZiDH+wWfQJekcGA0ku3uVeisCYL/GCKv0AtIRzmjW UigzpXl9xo8/QVyA68NNYsqeZCa8MBImOllRLkStzwv4jpKfFj5Ljv5kRgOE46xHwYwe /Qsy90XaJORx/+qC6bVa8CbjPD5caa/tSHIETqa1JqPfHUM9168/YhFOnJ6XvxTR8ZyV zqyasEFK9pJj40gRl6FjUgLjlEHFtOYzA8ObI0X4lKyyvW9P0SDFE1VD5mO7dFuStJcW L1Ow== X-Gm-Message-State: AO0yUKUT0Cwcj8BSWXWiHbt5sB26ALR9lsnZd2O6bih2NUiQBOg6UVJG noJb3+6aAVAPwWY7Zz40EJffx8wm+wIZNfoEQuWbqA7b X-Google-Smtp-Source: AK7set8WdTHsZe/LIqJqhqiq6FmP2/1JH1QsRsQjcRUfR7HxvqwNgDyS+XqNHhlJcLj+KzSvoId76OSfAYuHLN/L9ZA= X-Received: by 2002:aca:240d:0:b0:386:9b6f:f300 with SMTP id n13-20020aca240d000000b003869b6ff300mr1922807oic.5.1679771616893; Sat, 25 Mar 2023 12:13:36 -0700 (PDT) MIME-Version: 1.0 References: <87y1rgtk78.fsf@dfreeman.email> <87k030tf4t.fsf@dfreeman.email> <87fs9s7iiq.fsf@dfreeman.email> In-Reply-To: <87fs9s7iiq.fsf@dfreeman.email> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sat, 25 Mar 2023 19:15:29 +0000 Message-ID: Subject: Re: [PATCH]: Eglot, request progress notification on server init To: Danny Freeman , 59929-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59929-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, Mar 25, 2023 at 7:12=E2=80=AFPM Danny Freeman wrote: > > > Danny Freeman writes: > > > Another patch for consideration related to the first in this thread, > > I've confirmed that clients can signal to servers that they are willing > > to accept server initiated progress notifications with the client > > capability in the attached patch. > > > > Note: there is still no server capability for this that can be ignored, > > and the `eglot-report-progress` defcustom remains relevant here. Any > > server initiated progress report will be ignored if > > `eglot-report-progress` is `nil`. > > > > Server will send a `window/workDoneProgress/create` request, but nothin= g > > needs to be done with it. That request will be followed by the already > > implemented $/progress notifications. > > > > I need to find a server that I can test this with before this patch is > > applied. I will report back in this thread once I've done that. > > I think this bug can be closed. It is old and I lost track of it, but > some recent commits in Emacs I think addressed this > > - 82523dc621ace104d8f379509a436fcb03c48c26 > - 47d8e4b0d3835f5e0b0b6ab76f242ef0aa25bda7 > > Thank you, > Danny Freeman Yes, I think so to. I had lost track of this bug, thanks for reminding me. Jo=C3=A3o From unknown Thu Aug 14 17:30:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator