GNU bug report logs - #59927
[PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59927: closed ([PATCH] gnu: go-gopkg-in-yaml-v3: update after
 hash mismatch)
Date: Wed, 15 Feb 2023 11:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 15 Feb 2023 11:51:42 +0100
with message-id <87k00jcher.fsf <at> nckx>
and subject line Re: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
has caused the debbugs.gnu.org bug report #59927,
regarding [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59927: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59927
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Gleb Zakharov <snyssfx <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gleb Zakharov <snyssfx <at> gmail.com>
Subject: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
Date: Fri,  9 Dec 2022 16:04:37 +0100

It seems the authors of go yaml package made a bugfix
in the repository and updated the v3 branch. Because of
the resulting hash mismatch, a docker package couldn't
be built.

I updated the hash, changed a version from
a branch of the repository to the v3.0.1 tag
and applied guix style command.
---
 gnu/packages/golang.scm | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 70ddef52f1..b49fe7566d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -38,6 +38,7 @@
 ;;; Copyright © 2022 Dhruvin Gandhi <contact <at> dhruvin.dev>
 ;;; Copyright © 2022 Nicolas Graves <ngraves <at> ngraves.fr>
 ;;; Copyright © 2022 ( <paren <at> disroot.org>
+;;; Copyright © 2022 Gleb Zakharov <snyssfx <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -4520,21 +4521,20 @@ (define-public go-gopkg-in-yaml-v2
 (define-public go-gopkg-in-yaml-v3
   (package
     (name "go-gopkg-in-yaml-v3")
-    (version "3")
-    (source
-     (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://gopkg.in/yaml.v3")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
-       (sha256
-        (base32 "06f4lnrp494wqaygv09dggr2dwf3z2bawqhnlnnwiamg5y787k4g"))))
+    (version "3.0.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://gopkg.in/yaml.v3")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "01b0wjb7yzv8wzzz2iim8mjpkwjnykcanrwiq06pkl89lr6gv8hn"))))
     (build-system go-build-system)
     (arguments
      '(#:import-path "gopkg.in/yaml.v3"))
-    (native-inputs
-     (list go-gopkg-in-check-v1))
+    (native-inputs (list go-gopkg-in-check-v1))
     (home-page "https://gopkg.in/yaml.v3")
     (synopsis "YAML reader and writer for the Go language")
     (description

base-commit: 0ffa501f2b3e83ae56e9c2bd31418439090e869a
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 59927-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: go-gopkg-in-yaml-v3: update after hash mismatch
Date: Wed, 15 Feb 2023 11:51:42 +0100

[Message part 4 (text/plain, inline)]

Hi Gleb,

Thanks for this fix!  I've applied it with suitable delay to the 
master branch.

I added a GNU ‘Change Log’ line to follow our standards[1]. 
Trivial in this case but always required:

 * gnu/packages/golang.scm (go-gopkg-in-yaml-v3): Update to 
 3.0.1.

Don't mix unrelated changes: ‘guix style’ turned this 
trivially-audited patch:

 -(version "3")
 +(version "3.0.1")
 -(base32 "foo")
 +(base32 "bar")

into a 20-line diff :-)

Unfortunately, such changes are not considered copyrightable by 
current standards.

I disagreed with ‘guix style's’ mangling of the source field, so I 
just dropped it entirely.

Thanks again!

T G-R

[1]: 
https://guix.gnu.org/en/manual/devel/en/html_node/Submitting-Patches.html#Submitting-Patches

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.