GNU bug report logs - #59906
29.0.60; typescript-ts-mode is not highlighting escape sequences

Previous Next

Full log

View this message in rfc822 format

From: Theodor Thornhill <theo <at> thornhill.no>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: 59906 <at> debbugs.gnu.org, casouri <at> gmail.com
Subject: bug#59906: 29.0.60; typescript-ts-mode is not highlighting escape sequences
Date: Thu, 08 Dec 2022 16:19:51 +0100

[Message part 1 (text/plain, inline)]

Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:

> In a buffer with typescript-ts-mode activated, write the following code:
>
> const test = "quoted\"string\" contents";
>
> The entire text, include the \" is highlighted as strings, and escape sequences are not handled:
>
> This code has the following tree-sitter syntax tree:
>
>  (lexical_declaration kind: const
>   (variable_declarator name: (identifier) value: =
>    (string " (string_fragment) (escape_sequence) (string_fragment) (escape_sequence) (string_fragment) "))
>   ;)
>
> In typescript-ts-mode we seemingly have rules to handle fontification of escape sequences: 
>
>     :language language
>     :feature 'escape-sequence
>     :override t
>     '((escape_sequence) @font-lock-escape-face))
>
> This feature is however not activated in the major-mode setup: 
>
>      (setq-local treesit-font-lock-feature-list
>                  '((comment declaration)
>                    (keyword string)
>                    (constant expression identifier number pattern property)
>                    (bracket delimiter)))
>
> Naively I assumed that simply adding this feature would activate this rule, but still \" is fontified as string.

Yeah, there was an error there.  See below patch.

Yuan, can you install this?

Theo

[0001-Fix-escape-sequence-feature-in-typescript-ts-mode-bu.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.