From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 04:50:58 2022 Received: (at submit) by debbugs.gnu.org; 8 Dec 2022 09:50:58 +0000 Received: from localhost ([127.0.0.1]:55667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DYP-0007yj-Va for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:50:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:33606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Bft-0005K8-Ns for submit@debbugs.gnu.org; Thu, 08 Dec 2022 02:50:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Bfs-0004bR-QC for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 02:50:33 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3Bfr-0002o8-8P for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 02:50:32 -0500 Received: by mail-pl1-x631.google.com with SMTP id jl24so767366plb.8 for ; Wed, 07 Dec 2022 23:50:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mP4TM2Lh+6KyVs4mzf4/mtE+vvGJQ0WPo4Pfvt6vK1Q=; b=fEYtYzSjaBoJc8V10t1n5B9YYqIVk69P/aG65ubdrlfAfiBCekUMW2l/LmqzILwy/V 8XiDh7Zqv18SW1QEyn6ZuE8Ax0QdfvpvNiy4avJKvT9q4RaTZltAwBBvYhX9/REr2uO3 pk+vS9h3zvmbKwCYkNgdxXyyo7JIC+4GdSNVueYQspJIYD2x3xM5dNr0IgQMQ2/eW/j3 Mnpzq89dhZDhybrLbUd3CoG2BqmltMJ7ONZfxiwuGumyQLjSc6zgqfTZNmXmP2H8UXag 1xCyi3hTjSZOYOOqgpYys0neh/M6ePBlDGLJhPHsFBlnRnap3eNmLWaHFprXPHGUNOsr VMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mP4TM2Lh+6KyVs4mzf4/mtE+vvGJQ0WPo4Pfvt6vK1Q=; b=Y6xz2azIlBKvrecfM2wisEev4oDGTZe2uNJcLKrIRpvKOEqmDyvuv1SXNoLgI8kFsM 4cPTsfwSWqM0TsngNUkii4ca61SIrDM4SHvs44MF8ohmiwpA01jKZI901PgxOQR5Sc3Q QLUbaoj2+VguqaRE2JHzPX0dtVDkpyjdA8/CHXwDCOgiJReOzBv4nebs8n1hrhnnOLbs Bqy6Ft/Z7Ga2sxLDWuULT6zPbQD+i/st9MADJphMz4SdDikN9d3LHUIiWWkkEwluhPHi C/HmM6XP45T9xD6zQZCqvUbleDq+DVbdyq3mdXQMkUXY3ML3gMMI89WV2Gz5dDFgtJos LRAQ== X-Gm-Message-State: ANoB5pmbLvKyqnYH+z2G7kT6oKO3P/+t66Tl1qG5fxuJfxGtsXLhEZ+x RHTQuuVLnj7yF714xx9dGfcDVBtdtTQ= X-Google-Smtp-Source: AA0mqf7kKfshEEHFio5PdnXFb3ldxHuyNx9Fc44wF/wy7poR6ljWbB4cU00tw47XwesO5K9aAEdbvg== X-Received: by 2002:a17:902:d885:b0:185:441f:70aa with SMTP id b5-20020a170902d88500b00185441f70aamr1788376plz.47.1670485828481; Wed, 07 Dec 2022 23:50:28 -0800 (PST) Received: from li (42-150-27-70.rev.home.ne.jp. [42.150.27.70]) by smtp.gmail.com with ESMTPSA id o17-20020a170902d4d100b00186cf82717fsm15963011plg.165.2022.12.07.23.50.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 23:50:27 -0800 (PST) From: Akira Komamura To: bug-gnu-emacs@gnu.org Subject: 30.0.50; map pattern in pcase causes a byte-compile error Date: Thu, 08 Dec 2022 16:50:25 +0900 Message-ID: <877cz22v26.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=akira.komamura@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 08 Dec 2022 04:50:53 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) After upgrading to Emacs 29, some packages throw byte-compile errors due to use of `map' pattern in `pcase': > org-bookmark-heading.el:176:6: Error: Unknown map pattern: (map > 'filename 'outline-path 'id 'front-context-string 'indirectp) The error can be avoided by `require'ing `map' at compile time in the library depending on pcase: (eval-when-compile ;; Support map pattern in pcase (require 'map)) However, this was not necessary in the previous versions. As a similar example, the `rx' pattern for `pcase' is autoloaded (see `rx.el'), so shouldn't the `map' pattern support be autoloaded as well? ;;;###autoload (pcase-defmacro rx (&rest regexps) ... From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 06:07:03 2022 Received: (at 59900) by debbugs.gnu.org; 8 Dec 2022 11:07:04 +0000 Received: from localhost ([127.0.0.1]:56083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ek3-0000RA-MH for submit@debbugs.gnu.org; Thu, 08 Dec 2022 06:07:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ek0-0000Qn-D2 for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 06:07:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Ejv-00015E-0e; Thu, 08 Dec 2022 06:06:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7Rpx3/PiUBBhsDJZ4hL6PXnuhAXlUjgbgl2+hy1maoE=; b=ZUxe8ygHcu35 zWR2eQewpV0OEhu8HDVVtS83gMMEbXsA12HDFo63B+pWPkwgSaokhWqbYYHEth2RtgYrTNmru+/H8 V2fC5grdRhs4JZjP6JvfIufCeOWVXxmSWSoRBL7Bt1CZJqAyE+nph7Wy3yyHmhBdSd/B5ETyHGKw7 rttA04w1/AxiJxzsdwJV2iyPuh+1FYZuyWqwGImhdgk3f37OPP6IlvbYW49bfYgynpNucL1X67OVc thUrXhojgOEGBNDEU1QaBm86GiMdI8igk5jAxBPvVS4kew0TpT7Jd/vVRsn4KTC4hABCR0hpTodet o7XHrYQJbNDHB1YddtlYxw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Eju-0001xH-7A; Thu, 08 Dec 2022 06:06:54 -0500 Date: Thu, 08 Dec 2022 13:06:44 +0200 Message-Id: <83ilim2lyz.fsf@gnu.org> From: Eli Zaretskii To: Akira Komamura In-Reply-To: <877cz22v26.fsf@gmail.com> (message from Akira Komamura on Thu, 08 Dec 2022 16:50:25 +0900) Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error References: <877cz22v26.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59900 Cc: 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Akira Komamura > Date: Thu, 08 Dec 2022 16:50:25 +0900 > > After upgrading to Emacs 29, some packages throw byte-compile errors > due to use of `map' pattern in `pcase': > > > org-bookmark-heading.el:176:6: Error: Unknown map pattern: (map > > 'filename 'outline-path 'id 'front-context-string 'indirectp) > > The error can be avoided by `require'ing `map' at compile time in the > library depending on pcase: > > (eval-when-compile > ;; Support map pattern in pcase > (require 'map)) > > However, this was not necessary in the previous versions. Could you please point out where does pcase.el uses 'map' in its source? The error message you quote doesn't reference pcase.el, only org-bookmark-heading.el, which is not part of Emacs and is not on ELPA, AFAICT. So I wonder where's the place in the core Emacs sources which causes the problem, and I couldn't find it. I'm probably missing something. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 08:03:34 2022 Received: (at 59900) by debbugs.gnu.org; 8 Dec 2022 13:03:34 +0000 Received: from localhost ([127.0.0.1]:56667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3GYo-0002kd-1N for submit@debbugs.gnu.org; Thu, 08 Dec 2022 08:03:34 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:43577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3GYm-0002kX-4R for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 08:03:32 -0500 Received: by mail-pf1-f196.google.com with SMTP id n3so1226738pfq.10 for <59900@debbugs.gnu.org>; Thu, 08 Dec 2022 05:03:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lbCJhTOd8ZDzc8TsGuunfrmOLXxm2KU17XVvl49PzSk=; b=WrWtegJytwo8AX/0RRo1dg7ct4m5FnhNv9NS1c0gzDqbOq6VLNMx61l1FfEYyYPWU0 ysxA0cdIVFWhGWFx5VsrS4mSvyLrQ0/nP5mcmJD8bBmRg2wmsqRXGQsEXfgRmdSVhZxA 98x3YZjCPKKSQ/+Ic98+77kYO55kinNzaabxtrJntw7LJM1SkMuxZE+o+D1vQJUPce1g p1smX5IjEn3OA0QLzFzBx73JIzu9YtLdouVvk894DtzFr5CIT6lnterfo9otaswhVm2S DX6UaAp5BIu2GNW7qtvrQpT0ulVTmdlswJCETu/ACs7e7KwjKCt0iZzp6EQJ0cyBoClM 4tAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lbCJhTOd8ZDzc8TsGuunfrmOLXxm2KU17XVvl49PzSk=; b=Z6BLJ8/MrJMqw3DEIBia5x+/7kjFKiH1mVfS1HhRDAt9VTTuhZMH7uOFhCC998i1To 1QGURo7Acp4Y7TkWaX7s4Gff56GKux+uX9s/ROE7F4iQFiPB73yqRFX4IadvaYdK6xOO v9uaK1P8reOTnL4TQOk27PUXJ3Pm/FGnWxn3MI0Y3/33AXB00JQI4fVSTVV1Jfs+oyRx 2HDzRRRE2YLJS2ccJ3usvLwZEp/2Svq5Sai0F30nJqqZVoISXE5ft82jDVqBal1wXr5g DrfNp6PQsE3QLz4tJI5a+n7ysqQRps4WtQrPi7C3WabkR6BwgZ60FGd4sC1XofuAe9YF FDBQ== X-Gm-Message-State: ANoB5ply0le9QNgwauLaob8HLfT3msS5yfIt4ZDumQow9mjsiHfkvDvp KFD2QyTbZpeIgrMo21D+L9hnB2MpoPM= X-Google-Smtp-Source: AA0mqf7T55QO8pk3hYOBBH0qPSdOuvlTlgCuVxFKKTK7lCnSLdC3PtroEps62D+41jwdPjW1ICCJuQ== X-Received: by 2002:aa7:8298:0:b0:56d:5de0:111b with SMTP id s24-20020aa78298000000b0056d5de0111bmr2237722pfm.33.1670504606191; Thu, 08 Dec 2022 05:03:26 -0800 (PST) Received: from localhost ([49.204.142.121]) by smtp.gmail.com with ESMTPSA id 21-20020a621615000000b00575f348aa3esm14738781pfw.122.2022.12.08.05.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 05:03:25 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: <83ilim2lyz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Dec 2022 13:06:44 +0200") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> Date: Thu, 08 Dec 2022 18:33:17 +0530 Message-ID: <87tu262gkq.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59900 Cc: Akira Komamura , 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) W+CuteCuv+Cur+CuvuCutOCuqeCvjSDgrp/grr/grprgrq7gr43grqrgrrDgr40gMDgsIDIwMjJd IEVsaSBaYXJldHNraWkgd3JvdGU6DQoNCj4gQ291bGQgeW91IHBsZWFzZSBwb2ludCBvdXQgd2hl cmUgZG9lcyBwY2FzZS5lbCB1c2VzICdtYXAnIGluIGl0cw0KPiBzb3VyY2U/DQoNClBjYXNlIG1h dGNoZXIgdGhhdCB1c2VzIHRoZSBtYXAgbGlicmFyeSBpcyBpbiBpbiBtYXAuZWwuDQpTZWUgdGhl IChwY2FzZS1kZWZtYWNybyBtYXAgKCZyZXN0IGFyZ3MpIGxpbmUuDQo= From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 09:20:28 2022 Received: (at 59900) by debbugs.gnu.org; 8 Dec 2022 14:20:28 +0000 Received: from localhost ([127.0.0.1]:57077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3HlE-0003Vn-D6 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 09:20:28 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3HlC-0003Vh-DY for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 09:20:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Hl7-0000BT-6l; Thu, 08 Dec 2022 09:20:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=wCSDEJrb3ipuLSJxfHuVx7gtGx8DJqZgjV7aXY/f1Do=; b=dI/vZrrNWqMSti+q1m/A INH1k1JLAslqVjmdhNyC6DBrMv/uK7shANk5ilV0qXTs0mY2F1EJz04Kgt4ZEv2klZR6f08m+2wxB 34KqOB3YOVjyhRIXy5zQwU+F6i0GZ9pnJByvRCbs4K32LRVVPwUFYOgqqlNsvwX5DLGjfxVlwS+Tt kYlQtJvwVnEKhJaxPbgO4k1zy8Utr6eVqJ+vIZvsPorDIakq0UlhiCQKZzti3pSjl9TgXGQ3T98J1 sRwFZ0WGCgzSw5Pvkc4i44GHDSEmUbgc5cS73z7Mvdan+2iKaneJT67lEII8zfTXgFnlrkZTvpf1Z sT3cs+mEtCEC+Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3Hl5-0005DP-PN; Thu, 08 Dec 2022 09:20:20 -0500 Date: Thu, 08 Dec 2022 16:20:11 +0200 Message-Id: <83bkoe2d0k.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87tu262gkq.fsf@gmail.com> (message from Visuwesh on Thu, 08 Dec 2022 18:33:17 +0530) Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87tu262gkq.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: Akira Komamura , 59900@debbugs.gnu.org > Date: Thu, 08 Dec 2022 18:33:17 +0530 > > [வியாழன் டிசம்பர் 08, 2022] Eli Zaretskii wrote: > > > Could you please point out where does pcase.el uses 'map' in its > > source? > > Pcase matcher that uses the map library is in in map.el. > See the (pcase-defmacro map (&rest args) line. Thanks, but if the offending code is in map.el, then there should be no problem for it to use functions or macros in map.el, right? Or what am I missing? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 09:49:37 2022 Received: (at 59900) by debbugs.gnu.org; 8 Dec 2022 14:49:37 +0000 Received: from localhost ([127.0.0.1]:57206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3IDR-0003k1-DJ for submit@debbugs.gnu.org; Thu, 08 Dec 2022 09:49:37 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:46028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3IDP-0003ju-M7 for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 09:49:36 -0500 Received: by mail-pj1-f65.google.com with SMTP id v13-20020a17090a6b0d00b00219c3be9830so1761180pjj.4 for <59900@debbugs.gnu.org>; Thu, 08 Dec 2022 06:49:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nc3cTKo3ZNOBFnNAkJSNJ7g43qoVGhph/ElsDtGtvJ4=; b=XXncNkq5InplJlJZpi1dSSLVv8u2H6/Pf6tJa6TSKydxPwOalpJAczLUkBZy6LlMQK E51eGtE+j8bffWBI7t3KlYK/gHa2H7M/cuPAGQifxa7V4UQmqyKEu6Ckk7qoiL8RqbY3 EDo0SqQlAwNgycWHfcnL537r2Ot3cxhEiczPQuoHEBLuppAVeWVRKh9y7QPCgnFxQXJ0 UPJHdT3hVWj/gjyFAKylI/EG9gXZCJrXl/RAlI8yWThylUrJz/heCLP80RME956nnZwq pkzUb2tURePvP+GVj3168BEa5Y6lqhWRg//rZaDdUFcfrY5X9ddmDDseg+2QrT4BMRQk htrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Nc3cTKo3ZNOBFnNAkJSNJ7g43qoVGhph/ElsDtGtvJ4=; b=GB3C5CZiwUffR/ZelHscTxnLSdnGO5ixP9GliFAcpdesKv5bhISvXHas3xV4fE8beD ncxjxL+qg+XsF3KDht/hkVMrlSz050QERp8ysQL+sMOX6dCTcmW7hSwf+Nd0Ri7hptvk gq/0qAvv4wsV/ZPNny3SFavqUnSAHfrTnj8pVpoAz20KuV2Wj25DsiU75KkzMgec6zGF JAU46cMunoNX1zflSlOTRY+z/YJEiALRMOOk3w07Law+9IC/kwudga9VC5upJbifuFYR WROLS/BUPHSTMmlJ0Gt7NG2paLUQrFOP13U6KRsyaLqUrkGbwSobvbj3sEfa2gRQCdTM cRjQ== X-Gm-Message-State: ANoB5pm6k4EKUrvemGaJjE+s7BDz3g83UqanLT1uqnF6BETVVYr6bgwJ sALZhymj6HbUzldeu+T2DLQ= X-Google-Smtp-Source: AA0mqf79phVThOFm+H9Pn2k55j9twXmknmVbBeJTiKiXN3x/Ir/FfHu5tCX9gdkIKUlgMuWoaOzzGw== X-Received: by 2002:a17:902:d4cb:b0:189:d0b4:52d0 with SMTP id o11-20020a170902d4cb00b00189d0b452d0mr3304840plg.46.1670510969783; Thu, 08 Dec 2022 06:49:29 -0800 (PST) Received: from localhost ([49.204.142.121]) by smtp.gmail.com with ESMTPSA id iw10-20020a170903044a00b001871461688esm13303419plb.175.2022.12.08.06.49.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 06:49:29 -0800 (PST) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: <83bkoe2d0k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Dec 2022 16:20:11 +0200") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87tu262gkq.fsf@gmail.com> <83bkoe2d0k.fsf@gnu.org> Date: Thu, 08 Dec 2022 20:19:26 +0530 Message-ID: <87mt7y2bnt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE=9F= =E0=AE=BF=E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 08, 2022] E= li Zaretskii wrote: >> From: Visuwesh >> Cc: Akira Komamura , 59900@debbugs.gnu.org >> Date: Thu, 08 Dec 2022 18:33:17 +0530 >>=20 >> [=E0=AE=B5=E0=AE=BF=E0=AE=AF=E0=AE=BE=E0=AE=B4=E0=AE=A9=E0=AF=8D =E0=AE= =9F=E0=AE=BF=E0=AE=9A=E0=AE=AE=E0=AF=8D=E0=AE=AA=E0=AE=B0=E0=AF=8D 08, 2022= ] Eli Zaretskii wrote: >>=20 >> > Could you please point out where does pcase.el uses 'map' in its >> > source? >>=20 >> Pcase matcher that uses the map library is in in map.el. >> See the (pcase-defmacro map (&rest args) line. > > Thanks, but if the offending code is in map.el, then there should be > no problem for it to use functions or macros in map.el, right? > > Or what am I missing? I do not understand your reply but AFAIU, the error shows up because the compiler does not know about the pcase map matching pattern during compilation-time so I think the problem is in org-bookmark-heading package missing a require statement for map.el and not in core. [ Akira proposes to autoload the map.el matching pattern to avoid future errors as rx's pattern is already autoloaded. ] From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 12:35:11 2022 Received: (at 59900) by debbugs.gnu.org; 8 Dec 2022 17:35:11 +0000 Received: from localhost ([127.0.0.1]:58082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Kne-0001Yf-Sm for submit@debbugs.gnu.org; Thu, 08 Dec 2022 12:35:11 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:45996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ggw-0002oK-6O for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 08:12:02 -0500 Received: by mail-ej1-f49.google.com with SMTP id fc4so3662330ejc.12 for <59900@debbugs.gnu.org>; Thu, 08 Dec 2022 05:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jx8ZL0DPTKIeaZwGgU09xBGbh0eqqdCnyaAEWoDPHqg=; b=boXeNIOuMEPmddw63isl1VnAfFLrvxVlbZymH2XpG1Qhb++1jpVNQ13lcGLYYsZ1FZ aRqiz9Vz5E8dEYXluGnQ8OFv179VRG3uwhkV0PC37QR0FM+yHkK0vyd2u88uCCll+25H yzHgBlE0Y9vf9FZyPF/oA92TEhCPmm6XVqbrRy5oHeMf/h4KeAASZKS5FEGpkgQ1Zl7F HUv6M7yMjixgdxffb5DQvyrs6ZSiWcveuC90A2uwY56mkEHpMEycREh9ajQlFOhF+RAO hUBpRmZ2daWPEbUw75d5a8p2eTX5q/UCT4XF56PSKKIl3yfvUISa3bdYcrlk+/shKNrK j8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jx8ZL0DPTKIeaZwGgU09xBGbh0eqqdCnyaAEWoDPHqg=; b=FP/ZNmAAGpeBDu42TMP646VFW+wilEFAX18jcalZe58+KkEKLgu4crCZVr/CENQWv5 NTEV7Io/HCZyYSja1iUkNbTMiaXLHx7JI6OYRrQtZhBpSHlLdTlIcGrK1cku7QFjaEpS T2Yjaw0EEgtJBvCXNz05B8sXcYKVEJ4K/nPA80/NwGEIq4haTkS68YMZqrTbgeS34ViT Tj/J1JUoonNmCTAUjttXb1h+Xgf0zoX5i3yeYBB/6Z3qm8mVplOUZsLpYEemSraNIwbr tmkDu3HCn/pTyZrS7szUp1DreUendll7cDYAvRtPhIQxi/kmoPmSiohItVJKOnkPa1d4 X6lQ== X-Gm-Message-State: ANoB5pmj0p74kkwWiAOq/UkK9RtIF6W6XWUE76GEmF4PhzY0uJrbKY1t uWgzBRW0WHqzGrGGEuk/hbNaGMR8WF/ViK8g7fLeDXbX1hw= X-Google-Smtp-Source: AA0mqf494qMVpU0Phm28Vh1YOOmcCLi4xvtnP9gJTvtiK8RZBEYHa8IL5j34CtIenL2gD96ojtuM251UcZ804le4ERQ= X-Received: by 2002:a17:906:d10f:b0:7c0:f727:5dd2 with SMTP id b15-20020a170906d10f00b007c0f7275dd2mr12716019ejz.319.1670505111109; Thu, 08 Dec 2022 05:11:51 -0800 (PST) MIME-Version: 1.0 References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> In-Reply-To: <83ilim2lyz.fsf@gnu.org> From: Akira Komamura Date: Thu, 8 Dec 2022 22:11:39 +0900 Message-ID: Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000be476705ef50c7dc" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59900 X-Mailman-Approved-At: Thu, 08 Dec 2022 12:35:09 -0500 Cc: 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000be476705ef50c7dc Content-Type: text/plain; charset="UTF-8" > Could you please point out where does pcase.el uses 'map' in its > source? The error message you quote doesn't reference pcase.el, only > org-bookmark-heading.el, which is not part of Emacs and is not on > ELPA, AFAICT. Apology for the misleading title. `pcase.el' itself doesn't depend on `map.el', nor does it contain `map' pattern in its source. `pcase.el' itself successfully compiles. I encountered the error while trying to byte-compile `org-bookmark-heading.el', which contains a `map' pattern at the following location: https://github.com/alphapapa/org-bookmark-heading/blob/f245c9023df28d6ee545dae4b96a1c237e6965ba/org-bookmark-heading.el#L176 The error vanishes if I add `(eval-when-compile (require 'map))' as in the following PR: https://github.com/alphapapa/org-bookmark-heading/pull/19/files I encountered similar errors in other libraries that contain a `map' pattern inside a `pcase' form. It didn't happen until recently, when I updated Emacs and began to get those errors. > So I wonder where's the place in the core Emacs sources > which causes the problem, and I couldn't find it. I'm probably > missing something. There are some other additional patterns for `pcase'. One of them is `rx' pattern. There is an autoload cookie right above the definition of `(pcase-defmacro rx ...' in `rx.el'. On the other hand, there is no autoload above `(pcase-defmacro map ...' in `map.el'. I think this might be the cause. Is there any reason for not autoloading the `pcase-defmacro` form? Thanks. --000000000000be476705ef50c7dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Could you please point out where does pcase.el uses = 9;map' in its
source?=C2=A0 The error message you quote doesn't reference pcase.el, o= nly
org-bookmark-heading.el, which is not part of Emacs and is not on
ELPA, AFAICT.=C2=A0

Apology for the mislea= ding title.

`pcase.el' itself doesn't depend on `map.el'= , nor does it contain `map' pattern
in its source. `pcase.el' it= self successfully compiles.

I encountered the error while trying to = byte-compile `org-bookmark-heading.el',
which contains a `map' p= attern at the following location:

https://github.com/alphapapa/org-bookmark-headi= ng/blob/f245c9023df28d6ee545dae4b96a1c237e6965ba/org-bookmark-heading.el#L1= 76

The error vanishes if I add `(eval-when-compile (require '= ;map))' as in the
following PR:

https://github.com/alphapapa= /org-bookmark-heading/pull/19/files

I encountered similar errors= in other libraries that contain a `map' pattern
inside a `pcase'= ; form. It didn't happen until recently, when I updated Emacs and
be= gan to get those errors.
=C2=A0
So I wonder where's the place in the core Ema= cs sources
which causes the problem, and I couldn't find it.=C2=A0 I'm probabl= y
missing something.

=C2=A0There are some oth= er additional patterns for `pcase'. One of them is `rx'
pattern.= There is an autoload cookie right above the definition of
`(pcase-defma= cro rx ...' in `rx.el'. On the other hand, there is no autoload
= above `(pcase-defmacro map ...' in `map.el'. I think this might be = the cause.
Is there any reason for not autoloading the `pcase-def= macro` form?

Thanks.

--000000000000be476705ef50c7dc-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 21:11:28 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 02:11:29 +0000 Received: from localhost ([127.0.0.1]:60464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3SrI-0000Lu-Ll for submit@debbugs.gnu.org; Thu, 08 Dec 2022 21:11:28 -0500 Received: from mout.web.de ([212.227.17.12]:60939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3SrG-0000Lo-MQ for 59900@debbugs.gnu.org; Thu, 08 Dec 2022 21:11:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1670551880; bh=umQHQNM0N3ep1xIClZeXp9ak0ESgju2sgCmjijABsFU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=BjjO6aD7SeHyDX7RjmKMxkJ68NCYQAesN5/uD5sT/9ch0CNPpOQmr5E5/y49sRcz4 1mp5iSQ3nHdNi6ilbjVoyI9axTgCcOrhPcyV7XkzAsaRWgqeFzJyzsN6NWXGtC78BH a/r50PRA7cnPpV6XMpeNSd7ILd1YFWoH6w0uU9R710WCVYXF4Zo4uRns6Kmwjkcynz eOA+WsvYYu0J9hQvnW/wJdyRGwAVsAk6qDu1v6smOBjSdTcFcEBb18vuZvuoxCi4Qu V2aoT0BqdzPXfPM4GLcNZfLaWXM2tbWK3/GGmQuIslUZETCbDzgZb4biQE4yCrjwhr h98OMe0ClnBWQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MY5fb-1pT7Oc3tmP-00YEiM; Fri, 09 Dec 2022 03:11:20 +0100 From: Michael Heerdegen To: Akira Komamura Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: (Akira Komamura's message of "Thu, 8 Dec 2022 22:11:39 +0900") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> Date: Fri, 09 Dec 2022 03:11:14 +0100 Message-ID: <87k031nx6l.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:01Fb7pcTRQsA/mASI4ivET6rqpcJeV1plnlRFgc2hJICUrz61i4 Fxn4NJSSCjDrMFhz+vSz60F5y3gy/W+y85wh6Rb8m4KQELml3sqJW2XgaBuZ2+jAilyWE98 l+8lXOgLhXWpiRvFINyLQZtHp6qLW+IFMvWg/ba6WSph0LGAE7r/tSEjWhuValtcrESs78/ 4Wmwp5nwDFskkz8eKGrog== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:l5PTHa6+6z4=;T5PQypbfYWtDoFjAh/x5vzFoeZV ZVAO9vwMPP+jPXi4Mxp5gE1AA0w/BI3Knas9aLojGbtUagHFkmH4Qi1CnIAbX45nTcJGMl1ki lcAfEGYGeDUhdvr3g1XouY/tUFb9kgyqSxoYNyr3xszswPFnA6zMvYwum2oe5QCuEyGcUSjlw lZ/Wg2D9NzDJdJ0rKdJMzmmIAZAmiedS8YBHdBk+xDRTJqSY8NfcMMfNyaTBQOrVMXURzkBcn PCyNqKWv41UOtpKmgqugE9bCewlrSIe6BoGWTQMxORWli/tXsUqmYZZI12SCJkbcVb4cbEo04 YjcWxYVmbtPjgsNKXRCIgw74MDIwT85kZmKXt+NIiYhQl3Oe+CiEy9Cop/5iEFFjwcf5T+Mhh TdGNd1ZGFR537u+/OoB/t8q2M1AeyM0gZFrugXAKPwNpEVORlGKlFA8cvxoRtOlaSv0mMNh8z wjh+Ork17FN1zNiAJLkmtCbtMWXo9PQaFE7wyQ66XNctlvkAZxDUaoTxROuvPrEQjU5s7ZybH 7owNtvCRtqjMwR+7Ug5h4bjQ4B611Oxh1z4BLvScoKLfAPgEKHy/sOLMruOJe4X+ySfRbgGsD stKTjyVW0UNG5YP4j186ZBn1JUdmCG2dgVRdBJdLOKwsCpT3g0nosEW+QAi2BYc/BKyeN+3Ke ZhxwTaFhC2tYktpr2lMfMYoHXEgn66FGUip65f9z7IOT3oK1OSx2jn/q6GSp4H0NIetAfEI5C gAYBBlOt4pdNJHp0lJLHHAkZQRWHjUlhGgr7DiDE2cuqmZIxLS54cOmsXrjyyZ4xbfCRZV94y UPAXx9mW4MkUy0XY+D3lacgLplbw7N8y3VcmNJprC11GBolG2RGzX6zsU8ioosZCRCUkTrGG3 ZHvD/ErRkvzakZH6qHYM2mhVB1NvUSn13A7wxr4liFOAofCL5GFrF/qDyJXhvu6PiofUuRelj iMUJYZ3IKb85EGFs8FOu5vY9bKo= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59900 Cc: Eli Zaretskii , 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Akira Komamura writes: > I encountered similar errors in other libraries that contain a `map' pat= tern > inside a `pcase' form. It didn't happen until recently, when I updated E= macs > and > began to get those errors. > > So I wonder where's the place in the core Emacs sources > which causes the problem, and I couldn't find it. I'm probably > missing something. Maybe it started with | 85555ad3b79 ; Require map only during compilation | Philip Kaludercic 2022-10-23 Anyway, AFAIU currently compiling pcase forms with `map' patterns requires map.el to be currently loaded, and since you can't (and could not) rely on that, it's better to add (eval-when-compile (require 'map)). > There are some other additional patterns for `pcase'. One of them is `rx= ' > pattern. There is an autoload cookie right above the definition of > `(pcase-defmacro rx ...' in `rx.el'. On the other hand, there is no auto= load > above `(pcase-defmacro map ...' in `map.el'. I think this might be the c= ause. > Is there any reason for not autoloading the `pcase-defmacro` form? I see no reason, it should be doable. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 02:12:45 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 07:12:45 +0000 Received: from localhost ([127.0.0.1]:34096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3XYq-0003kj-PL for submit@debbugs.gnu.org; Fri, 09 Dec 2022 02:12:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3XYp-0003kb-0t for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 02:12:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3XYi-0003P1-HR; Fri, 09 Dec 2022 02:12:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eAIdw/kCBKMXPUBh0u+3WMv4hJeDWT06Zcfl33Plom8=; b=e2ulduBPT3wC hz2UwpimI7Jr9V2PKiDjNB84+f1kPZBydmQUsDr0kd7EFMWZaduTGnFp4NsTj71QZUAlAL1oZpRgG TxoVo4JUv6jsWBkKYiuMuMHaDxz7F+77BQERvfRf7cZZO4H3W3tjDDe7ErOalHrbg1S/khDjoniRY xCyV24tWOZUl4pZaZq+XjlWyEVjTXDW9Lg1VDyCWhlVE2Ed1weHK0YtW5G3ZgOSmULMpN681lSRn3 vcZ3b1lxiFKsqFlkw4GbBnNFaQw9K+1nSYRGpA1RAUtvhCfe7Q/gVxvORkaDvtUt4pzEOWCjVEvIr JrrWhvNAeeHfmABSIz/hpA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3XYV-00045y-Rp; Fri, 09 Dec 2022 02:12:34 -0500 Date: Fri, 09 Dec 2022 09:12:17 +0200 Message-Id: <837cz1125q.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87k031nx6l.fsf@web.de> (message from Michael Heerdegen on Fri, 09 Dec 2022 03:11:14 +0100) Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Eli Zaretskii , 59900@debbugs.gnu.org > Date: Fri, 09 Dec 2022 03:11:14 +0100 > > Akira Komamura writes: > > > I encountered similar errors in other libraries that contain a `map' pattern > > inside a `pcase' form. It didn't happen until recently, when I updated Emacs > > and > > began to get those errors. > > > > So I wonder where's the place in the core Emacs sources > > which causes the problem, and I couldn't find it. I'm probably > > missing something. > > Maybe it started with > > | 85555ad3b79 ; Require map only during compilation > | Philip Kaludercic 2022-10-23 > > Anyway, AFAIU currently compiling pcase forms with `map' patterns > requires map.el to be currently loaded, and since you can't (and could > not) rely on that, it's better to add > (eval-when-compile (require 'map)). Thanks, but all this still doesn't answer my questions, unfortunately. You-all are describing something that I cannot wrap my head around, because that basic question was not answered yet. Would someone please take me through the problem step by step? ELI5, OK? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 02:58:47 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 07:58:48 +0000 Received: from localhost ([127.0.0.1]:34428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3YHP-0004I8-JA for submit@debbugs.gnu.org; Fri, 09 Dec 2022 02:58:47 -0500 Received: from mail-ej1-f42.google.com ([209.85.218.42]:40729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3YHN-0004I1-VX for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 02:58:46 -0500 Received: by mail-ej1-f42.google.com with SMTP id b2so9620827eja.7 for <59900@debbugs.gnu.org>; Thu, 08 Dec 2022 23:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=xUWO1O5mb2cjdslRhosqmi8h6gafNjEmQ/fqb0ck7sc=; b=E0p69U5gyv8AXiz1pHt4Hpv7uWvN/40k91DiaQLwaxNd3+igEJQoxpUBUna4cwxP65 X1ViPUfvzev5U7dY0rnqwfEl1o1IoWMg/xK2jh6LFzUaFhzKL3q8TWwEa2gh27L4ThCt d2zW7pGk8AMUkTJlfBdOe1I1g2GZggNH7ClUDy1pxGwiDXGRPxCdhuZmqHAlxul/X16r mGe3sYZus1nokuXLdXPHFJt6KA1yopmmSr/fgmeHxs8YdUgi6rtrxblmeKVqmZBSFibz q7vjge074HpSH9OBjBOgsrk/clCKscdPfWi0FuW/5Sbk39CYlrzFEPGKHwj9giOKip2A 6Brg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xUWO1O5mb2cjdslRhosqmi8h6gafNjEmQ/fqb0ck7sc=; b=M+Ch7d1uhcmWROVA35qNpBgZ92YQHQ8gKlSsW0mlTufnalmfgbSpEUwke2yaRBohFe KNzvplVcw+5jxotQhtdRJoXVnsy+Rx9mAesXiL7JPw/g4HqYMnSFLunMVgukBFU8LA4Y k8E/NJUCw0PKbj0+f09rMHnx/NvUlB8c//NTKq0fWB9bN8HihdkVaenwU1iI31RKlT3T p+VKbvXEVxcfQe3AUuYfsJ5/xdfUwnx4+K05+3CAwZN51dtGQAl/11Z8uY+plQJvi6wj 0VKvCOuznD2RqMXwaLI51HHFLWo+OGeONI7Amw9WXJV40pzOu6INQSs3C5vRNfdKLYmQ +hEw== X-Gm-Message-State: ANoB5pmLJnAYisYJk0hn5yaHtU4EGZXXiZASdB4jS10IEFLNP1iC1Ofi 72jlgtlN2TEDIzuyw+tYq5lgSlaSVcmtqt/9uSU= X-Google-Smtp-Source: AA0mqf5RSZP+s28KzF+q1E52Oww2XSQxM6bbZ64Og4Zj62XljFOS/aNMca1q8dzHs3djsnV31J1qjBrZtBgQ+ReTWNs= X-Received: by 2002:a17:906:5055:b0:78d:cdce:bc52 with SMTP id e21-20020a170906505500b0078dcdcebc52mr66339207ejk.469.1670572719734; Thu, 08 Dec 2022 23:58:39 -0800 (PST) MIME-Version: 1.0 References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> In-Reply-To: <837cz1125q.fsf@gnu.org> From: Akira Komamura Date: Fri, 9 Dec 2022 16:58:28 +0900 Message-ID: Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000008810eb05ef608515" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59900 Cc: Michael Heerdegen , 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000008810eb05ef608515 Content-Type: text/plain; charset="UTF-8" On Fri, Dec 9, 2022 at 4:12 PM Eli Zaretskii wrote: > Thanks, but all this still doesn't answer my questions, > unfortunately. You-all are describing something that I cannot wrap my > head around, because that basic question was not answered yet. > > Would someone please take me through the problem step by step? > There is a MELPA package depending on `pcase'. It contains a `map' pattern: (pcase-let* ((`(,_name . ,(map filename outline-path id front-context-string indirectp)) ...) The support for `map' pattern is not built into `pcase.el'. Instead, it is enabled through `pcase--get-macroexpander', which is implemented as follows: (defun pcase--get-macroexpander (s) "Return the macroexpander for pcase pattern head S, or nil." (get s 'pcase-macroexpander)) It returns `pcase-macroexpander' property of the symbol (i.e. `map' in this case). The property should be available at compile time. If not, the library will fail to byte-compile. To set the property of an additional pattern, `rx', `map', `seq', etc. all use `pcase-defmacro'. I think autoloading the `pcase-defmacro' form in `map.el' can prevent the error as well as possible future errors in other libraries. This is already done in `rx.el'. --0000000000008810eb05ef608515 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Dec 9, 2022 at 4:12 PM Eli Zaretskii <eliz@gnu.org> wrote:
Thanks, but all this still doesn't answer my q= uestions,
unfortunately.=C2=A0 You-all are describing something that I cannot wrap my=
head around, because that basic question was not answered yet.

Would someone please take me through the problem step by step?

There is a MELPA package depending = on `pcase'. It contains a `map' pattern:

(pcase-let* ((`(,_n= ame . ,(map filename outline-path id front-context-string indirectp))
= =C2=A0 ...)

The support for `map' pattern is not built into `pca= se.el'. Instead, it is
enabled through `pcase--get-macroexpander'= ;, which is implemented as follows:

(defun pcase--get-macroexpander = (s)
=C2=A0 "Return the macroexpander for pcase pattern head S, or n= il."
=C2=A0 (get s 'pcase-macroexpander))

It returns `pc= ase-macroexpander' property of the symbol (i.e. `map' in this
ca= se). The property should be available at compile time. If not, the library<= br>will fail to byte-compile.

To set the property of an additional p= attern, `rx', `map', `seq', etc. all use
`pcase-defmacro'= ;. I think autoloading the `pcase-defmacro' form in `map.el' canprevent the error as well as possible future errors in other libraries. Th= is is
already done in `rx.el'.
--0000000000008810eb05ef608515-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 13:02:45 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 18:02:45 +0000 Received: from localhost ([127.0.0.1]:37527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3hhs-0001J1-NG for submit@debbugs.gnu.org; Fri, 09 Dec 2022 13:02:45 -0500 Received: from mout.web.de ([212.227.15.3]:56699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3hhq-0001Iv-As for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 13:02:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1670608953; bh=XfLb9cdTJY6U2IQ5KJyAuI+97t/xB9WWwVlBkyINv5M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=sUPZ9oEpwYfvOCUFlOcACM177DkVbNYFqNfnFO9MUqhbc+oxlHmibkYD46Z6y1qqJ o9aNPBqVmglmkJGXeAd+S1lhgXGn8NAq8uAnspT8sGgD22EPoL7iFGC56P0+arqazp +AdfPMzOpxwwk2co2+lH/lP2uX4E9S0aDyGT3wS4/iyb+TDgtj9FsQW4q/QfjRSgOi WOTo0JkZzPq/EfsYwQAdijfrdVcUrCTxDYKkDkcAQd0OpqyvY8paZfLXiMljA6X65G FjKuhIfiIqnATzY8d4CO9DAHxXeo5TXaMxb+W8DpLt2MjlEw4vhkfKZLiVkcopsMxs qxM5l+apGlDVA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N5UgI-1osALr2LiE-016ywi; Fri, 09 Dec 2022 19:02:33 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: <837cz1125q.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 09 Dec 2022 09:12:17 +0200") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> Date: Fri, 09 Dec 2022 19:02:32 +0100 Message-ID: <875yekv4jr.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:BdlgzHStOjpP5UnT+XE0d2oQUOdKukHXky10DRCUn3LW1Z2fx6l 8hElGhaEw1Bx4VS2XjjAsOnPgGVLbrYqyLpCYUdL9pr43eM+xvEtNcpJtIphifBU1sjyMXm o+ZrDwLkuD5V1iqV4i6zbzbUnPeCgzxfn4O9Q14cVMCi6vECBG6b8mqwNZ+21dVCsWlIMgl dSxT/sQex9S3eBc+pLuYQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:dglfXzBT0iA=;Q6l1nTSb1h0aQNbRHhEpDmpZ+dy HCLl+lKcmI8PxbfEQwtfy6Kt4rOhqCYXeYSDE98Od+lVxh5ia7L/ee1B1vnDCAJf8X35dcu5Q jqQwtTkNakm2fGWne5cSWdE6YLELft1EofQCuc53dXhwoDnZYvaaWbgCfTu2ckg7x+qUPBCk6 ggSbtUs2uZL1WmXJvE90CU1EVP4uCRQQHhEIl5ZjzdLF5Tfi9CEATmQozLZ5M2ZDC6tK60pLW cIXlXzcPAdJJFQiGB5OwMs0tGchT5hf2S2OXTIjyfgrkgyyJtNh/M53ZbVAVp10gFHR08bUjW 3PSxs734PAsWpgC0La8XO5Khmc1hPqc6VBec1ZXTxWP0V7eTzISncuyrXQINEcTo7E2DZZj4v nUe4F81ChFUhVY/giuUwDnimflKGLA6PmxwZG4tmygkBwDYeGKJD83yucMenwAx2PscQspwEU CBMCt1ZgRSI5c8hyQYYJ3kgDMeMykepKqOcS5YjAGGfk458oE3qGDFudGYHw9Xvvz1usZTZUu L/KJgRLrZJSWaG7a9bHV13whxzjYBTL0XPJSGTSMxPfhE4Xjo+Z0uYp5s1KWM0FmfVJnJgNdO S1uFpXssU4RHr+pcy031Cf64XGDoON+v9Xql1dSJ5ynq/yJ6bCIHCfU3YG7yHh9Ms2EaljrGq bTWnDjkdtnr63Vy6aVbHprFLivqOTYFgo5vYE+UrllI/TLUKGLY96f8azAko8LUucV+wuO13h +HNYJM4MtqKEDZLwAGejXEbiGBxh3c5grmiZlxjM2+8uc9SBtkHeGr14+1hM5OQzMTEDJLBzZ ZmD/Cn1/BdsWRsrCXXHpRmacY+J7hoj9Kx4GxmisWv5ZpaVxwQMjiTt9Eu9bxyML6n4QGkEid sfymlIwRGiIL//lR2Hfp1BY3hQufhF7Li5eC2rP2YSk4ytCp5+xc4jLWTc4MXt3fvu6STpymA UhWVeA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Thanks, but all this still doesn't answer my questions, > unfortunately. You-all are describing something that I cannot wrap my > head around, because that basic question was not answered yet. What specific question? pcase is extensible: It allows to define new pattern types. "rx.el" defines a `rx' pcase pattern, "map.el" a `map' pcase pattern. The normal way to be able to use them is to `require' the library in which they are defined. Since `pcase' is a macro, the library (rx.el or map.el) must be loaded when a `pcase' form using such a pattern is compiled. The `rx' pattern definition in rx.el uses autoload cookies so that compiling works even when rx.el is not loaded - it gets loaded automatically when compiling. The map.el `map' pcase pattern doesn't use autoloading. The OP found a case where compiling succeeded until some days ago without requiring map.el explictily, and now a require is needed. But that was only by luck: AFAIU, map.el was already loaded in that scenario, and now it is any more. But there is no guarantee that the library is always loaded when compiling arbitrary files, so one should _always_ explicitly require map.el when the file contains pcase forms with `map' patterns - even if this worked without in some cases in the past by luck. The wish of the OP to make the `map' pattern in map.el `autoload'able like the `rx' pattern in rx.el is reasonable, I can try to create a patch. But strictly speaking here is no bug, just the OP relying on something that in the past worked by luck. Hope this answers everything - else please ask specific questions. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 14:07:00 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 19:07:00 +0000 Received: from localhost ([127.0.0.1]:37867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ii4-0001yq-9S for submit@debbugs.gnu.org; Fri, 09 Dec 2022 14:07:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ii2-0001yi-Qd for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 14:06:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ihx-0005gK-IR; Fri, 09 Dec 2022 14:06:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qO3VyxtcdtsF/Y0uPHvCnJdQCprKrm6WSzXcNi0dIsI=; b=nST/eefrUv7f DwMeG7KqtTs2jbG2t77pFhrpa35mEhkJQ0sEZoaIgxZ046rxbRdVWLnqpDVlU9OyMaSPUCDDK1DSK FMnHVJ+qkefS5pR04UebO7A8E6ehu76uR0Y5gng1Dl9+pIIjexVzE1RarkicBm2EM3+6xlb6PUYJ8 GHjydeZypetGNW9juwx/eWrlqBe+PEIG7hqRAMgpZbPQfag92NtgMh56eqTeNLgqOrT0whOC/MNPq Clbn5d5CSNhroy0uFx5kXxnCfwgrgB/nKUiqfUSgRJ1x6p/xgPVHQW4OdVYP+VJ+uUfgda8rL2nHu Ij3L8Cghi1NvPymC5aGHjQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ihw-0002kZ-OL; Fri, 09 Dec 2022 14:06:53 -0500 Date: Fri, 09 Dec 2022 21:06:46 +0200 Message-Id: <83a63wz9a1.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <875yekv4jr.fsf@web.de> (message from Michael Heerdegen on Fri, 09 Dec 2022 19:02:32 +0100) Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> <875yekv4jr.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org > Date: Fri, 09 Dec 2022 19:02:32 +0100 > > Eli Zaretskii writes: > > > Thanks, but all this still doesn't answer my questions, > > unfortunately. You-all are describing something that I cannot wrap my > > head around, because that basic question was not answered yet. > > What specific question? The one I asked at the very beginning of this discussion: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59900#8 > pcase is extensible: It allows to define new pattern types. "rx.el" > defines a `rx' pcase pattern, "map.el" a `map' pcase pattern. The > normal way to be able to use them is to `require' the library in which > they are defined. > > Since `pcase' is a macro, the library (rx.el or map.el) must be loaded > when a `pcase' form using such a pattern is compiled. > > The `rx' pattern definition in rx.el uses autoload cookies so that > compiling works even when rx.el is not loaded - it gets loaded > automatically when compiling. > > The map.el `map' pcase pattern doesn't use autoloading. The OP found a > case where compiling succeeded until some days ago without requiring > map.el explictily, and now a require is needed. But that was only by > luck: AFAIU, map.el was already loaded in that scenario, and now it is > any more. But there is no guarantee that the library is always loaded > when compiling arbitrary files, so one should _always_ explicitly > require map.el when the file contains pcase forms with `map' patterns - > even if this worked without in some cases in the past by luck. > > The wish of the OP to make the `map' pattern in map.el `autoload'able > like the `rx' pattern in rx.el is reasonable, I can try to create a > patch. > > But strictly speaking here is no bug, just the OP relying on something > that in the past worked by luck. It sounds like the bug is in the package which uses map.el, and that package is not part of Emacs. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:02:19 2022 Received: (at 59900) by debbugs.gnu.org; 9 Dec 2022 21:02:19 +0000 Received: from localhost ([127.0.0.1]:38485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kVe-0005cP-QB for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:02:19 -0500 Received: from mout.web.de ([212.227.15.4]:58395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kVd-0005cG-3F for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 16:02:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1670619730; bh=3FYjNRHgXip5a4Hj9wtAmG3IheGtaPDIZq0qelSrbBM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Am12ldWQiBDrMDYGfZxHQuVD2/axCQRKR4Prj/7tYFoRhMkT4w4IXnezOtdQobkoM 61PtQ7sLeVjgxBCXn7t5J8Fbc79pEHN70AmzXYFa6q+0FHpEM26wWhgjurSuNV4FmH /XJL+ObTpMiAaPUkPfHknenjfCKokVGH+AZ1r87tnI/51fXvuer2A8eC/RSmhmPp6z w2toAXYvmtMN9dayGeNHPw4KidgMu5Fn391+YTSx7ddIFcqIvZBYu0m9SIUC0fL+Xy PI6wA/8D4qL8TQ+i53Qulx4GfrXcyYZNEOnMyTK/yGWbP/l1weuGAapUYgpTe4famr V8KKv+u3ZTrJw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MYu16-1pPnbW1azY-00VBNl; Fri, 09 Dec 2022 22:02:10 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: <83a63wz9a1.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 09 Dec 2022 21:06:46 +0200") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> <875yekv4jr.fsf@web.de> <83a63wz9a1.fsf@gnu.org> Date: Fri, 09 Dec 2022 22:02:09 +0100 Message-ID: <87lengs33i.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:t+TV3ukFvY/Coeb40d1ZrUxOeqhKrKg9jCkPuhct61cMKfnTyZX L5fVNozeZg9A92Hlv9C6HXyldVMmMRHpXmaIVjmA8/pgq8i1Y/ZBROR96DB80I4X4BeQbA5 WstcW6cO6ulAbao/oGvCGelqssFvq/q/pBNRKQKpk8mEGoi+f1jZViED5+QPLoY9UyoOw5m K1ujVPeL2eG9MccA77n2Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IQXpxBl8EKo=;jGK5Z+aYcqF+JnROSqm529M0U4y w7FVwXNm/oYKgA138GsP9tR9JJS8g5KucQgNivpGt+0JOuYB2b4iQbw42uIRbtlklI4uu4uuQ ROMkQBKOar0fZ12bIGvhZNYpJtVk5cf/xFnOg7tB0lQiSkCYNaLU2alCbJ1h/eRdjQjikeFA/ DF90ymAIkocvat/NSfCYG5dp4iU6yKOSsBe2dtJUZ4wcrZPq/IcIOPupt6sTbUOKzD7RoLRsB xBrgg9hpv38Qeo8ly7a1DHylYQopUSQsRyvWzgAcWCByvZ5RmE4JsOYT5h83xTfvA7EO3JRvW gVeLfPgvUfAc7a0okYx7UBX1XFrpBmenidGhbOS+i+uCEXTu89ud29wd6eSlLQ2S6Y+qfGLrn ALNarEXexe/UZJGOQQr9vWs1RbhpONlLo13ykHlDK8DF9/wYZSQ5zTKfbPXIx7Hrrn1cM0xt5 HCCf0Io3MPOVk83BJSH4349pg9l3VqsHpjEZ4RanItrh+VVIPPMF+rhGg4JHxc9t3kJLI9BjM RTFaRpNaxhsH4G47Gr9RXosabkLBMio7oTaxrjc+tYCg9UZ7840z2+2MafdKArhKZltJBXdOT 2rkWh54qqpnDP9w/nBtjSvjIfMJfa6DiuvJR/L7rvToasZvuFxPebjgKWSExkgsgLl9w82rQn r2rBeIYX6PwaFp1LfiHStpJBqzu82T9vG5PN4sTdYfB+m8z6D1kudlHvnyV9CIA48tiStUOgf nhXgUctdni8fu4zj7PKbKPp2s6VX8n3OTgFOoKWDCEJhFCB5En5EDzNDKJDXjoJDHojdE4xm7 PuD+lJkXAx8K7OgyOsDm1X/NnfPo5QRA1uSKLDqXRM6/+BbYPd+Ndcozw66+RUAocHacomFPY HWZKzqBeTndXR37CSfRgBQPfS982k0651C9FPa7QJgxzctqpiu0tW+3ZDedLAmnm5Y+vZH05D dkLpE2ElPAEYiPCzyLJC04d/oR0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > > What specific question? > The one I asked at the very beginning of this discussion: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59900#8 The same compiler error happens in emacs -Q if you compile a pcase form that uses the map pattern and miss to require the map library, e.g. compiling #+begin_src emacs-lisp (defun test (plist) (pcase-let (((map :one (:two two)) plist)) (list one two))) #+end_src gives you | Error: Unknown map pattern: (map :one (:two two)) but it's expected. > It sounds like the bug is in the package which uses map.el, and that > package is not part of Emacs. Exactly. But I still want to create a patch to support autoloading of the `map' pattern in "map.el", this is a good idea. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 20:01:46 2022 Received: (at 59900) by debbugs.gnu.org; 10 Dec 2022 01:01:46 +0000 Received: from localhost ([127.0.0.1]:39548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3oFO-0000r2-1H for submit@debbugs.gnu.org; Fri, 09 Dec 2022 20:01:46 -0500 Received: from mout.web.de ([212.227.15.3]:56327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3oFL-0000qs-JA for 59900@debbugs.gnu.org; Fri, 09 Dec 2022 20:01:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1670634096; bh=J8G57Kl6P3evAeywDrm0/Yk8/xufE+/C+CPv3fQO+Ao=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=afHc6tRpUWYrziYFHqIYcV5wE/vEKn7AeEoYR1GXMtJFeV9kQgrIiLzHUogpU/p/c Olsb1bGC9n+0tGTo19X1k33btOa0T48pCThNY0+K1o3YaimpKhcOBAmEAcX//Sq0O9 uqOQAPavV+6QRSQzr94nW+VW1tRNdwInluzyY/8wVffy6ZRJ3cSgML8HBL3rYVS7D1 +/mk8kTEPGQazNOb7CrmpcHuy87rao0vlzvfGUvDbaK1tVMfHgW30xtquoi9WQq2xa uBnw5y8OURQCqw6yYzOr9ZbHgR6bs2tVm5Xrqyw81ibcbo23b48DdnKFiyGjUEOLBB X1dtszD6mejkw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MI3t5-1p8VKZ2jyB-00F8oz; Sat, 10 Dec 2022 02:01:36 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error In-Reply-To: <87lengs33i.fsf@web.de> (Michael Heerdegen's message of "Fri, 09 Dec 2022 22:02:09 +0100") References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> <875yekv4jr.fsf@web.de> <83a63wz9a1.fsf@gnu.org> <87lengs33i.fsf@web.de> Date: Sat, 10 Dec 2022 02:01:35 +0100 Message-ID: <87cz8sxea8.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wMsu/rA2YB8PDBaLLtOAPZDpcvvbtslC5AwX+owQXRaNrxPoasO H6cVm1Q1MD/kYQNOQlhWYROaY4gyr+ZPHrLgV86HB7uAk1JZrdDrks9XsO0A3V93e98CYsR xYa47PTBLt2PDVRb1ed440uLG+6UG2VKscgtLKfngTOmOffNRUcObJKPcJgnjQU8nvI7reT UXZHthIg/+p/Nv6b49hIg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tht7u7Fr5O8=;shuuc/fDfPqy8TA/TYzR5gA/4ns 8im+btGW0FElIcrseJVt0/hRTNJuRxjhTUKOIJP6VfrT14LpwFazqZm00jb5qQufjJgxg8qmW 6fLTp2ysDQiC5XC3sK04UYT76Z5Af2rteUz/Tmy6/SCU/X+5/DUIYHAFepRPd/kAxvZldEDe9 2krfjy/X5wWPykPo2ee/1Y2WTnycLNwdmksJo7X/A7BoE/nzdSXu3LXmFDrO+LeWjmu2Q9XOG DbS8OujfXB4oo2f80ley/rGa5ckKFSiY68NE1FMFJw2qibv7k0Z+4ZjfURUdnWFvIRo2hzV7W nWE7BwZxI9qhC6/B1mmsKb6RbW7vpgE6HaJatTgpGcaYiShlXCOQJRutTpAekW5KElXNa30DF z4mIH55N64mnagHxjN32PVS7t2lJ/LUiz/Bvwy7LHkOkfaYoxVcKjVVqfaCcy7GxuWorcC/fa rBl0uRNroGOuUQ0Rn957dX1JTlu31XhtyuanmwdtCek25U4aaPSSo26baXIpzafS7bs0nfGCx aOOdHxel5rbETsqy77UYZj0JsCxxCAtjZ2YNCXGwf5dFy0TeRCFzYkRPXPzJzscgdD2yDsVQQ aiwzRPIyA2FW4uC4ZaBpGswHZ9XVpE++PAXEOIXzhLPY+t9d6hy5vhpMlMzOjThfQfk2FFlsF oiIdZ5tk6kM4VT/kYwinDr+0Ulm9ES8WXYuUWYS5GhHAauSsq6NDqjqe3Ds7IfvU+14sj61se j3dd/nxQXpBzeAgdM3loibLB5hVdriMWI7iPxTogk0oMa7QSDDV/wm7/QsCRe9JQ1bWBkKpKD ccxVE0lhIEUCmI/bHjstAE1zb2XeP23XSr2U9ifRCWQglRbETyVo7J4hFxsJ1KPg/FRMZpyik pc3kfkXwtkfH/5UaIV88VSs7I+QyjhXs1RYKqs0jaIXrk5NVgoRKXT9yNISpoI7rWctg+R+1a c8wNSqwSGqjF+aQNLNrmbLdL5Gg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59900 Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > But I still want to create a patch to support autoloading of the `map' > pattern in "map.el", this is a good idea. I'm not so sure after thinking more about it: _Nothing_ in "map.el" has an autoload cookie. I'm not convinced that out of all things `map' pcase patterns should be the only thing that are autoloaded whereby everything else in map.el requires an explicit `require'. That would be hardly consistent I don't know why the library has no autoload cookies at all but I guess there is a reason for it. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 02:53:54 2022 Received: (at 59900-done) by debbugs.gnu.org; 10 Dec 2022 07:53:54 +0000 Received: from localhost ([127.0.0.1]:41266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ugE-0005Q8-6C for submit@debbugs.gnu.org; Sat, 10 Dec 2022 02:53:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ugC-0005Q1-FC for 59900-done@debbugs.gnu.org; Sat, 10 Dec 2022 02:53:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ug6-0000AF-VE; Sat, 10 Dec 2022 02:53:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=nrrzO1GszIiHwe4XFKQUJLCwfB+ziYZlwTCjnwXjmzg=; b=lPJatduFa1bz wkq5QZYzs4Zx4WLT1nY9dmjpmgdiU6plSQyg4OBMOcL1V4i4DBKnd6jC474dSO46UHPmLa/UnNgV7 c4ZZ/YQpI2FqiIvtnorFKWyxEC8JH2tFvfXAGRGTMyfQ7q8U67cZq6UGB7FsBhA+kJz/afgfRsgmu KObRopJxIq26WkulrlrlBs7tcLyxXYxFs6QwJ7U/JJoVRMAWJOJp2iJdx2Clh8hetSIDcDxwVhHt2 yt64GrEGCefYZUYuAbQ5pfMxzKtcPV0eoxKn8WGSe6A9xHDWXvqIX1FMaWPxar2QtxCOWq1kE/T3b nmjocRuXd8V5UDD+oLckwg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3ug6-0005bR-3L; Sat, 10 Dec 2022 02:53:46 -0500 Date: Sat, 10 Dec 2022 09:53:42 +0200 Message-Id: <83pmcry9rt.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87cz8sxea8.fsf@web.de> (message from Michael Heerdegen on Sat, 10 Dec 2022 02:01:35 +0100) Subject: Re: bug#59900: 30.0.50; map pattern in pcase causes a byte-compile error References: <877cz22v26.fsf@gmail.com> <83ilim2lyz.fsf@gnu.org> <87k031nx6l.fsf@web.de> <837cz1125q.fsf@gnu.org> <875yekv4jr.fsf@web.de> <83a63wz9a1.fsf@gnu.org> <87lengs33i.fsf@web.de> <87cz8sxea8.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59900-done Cc: akira.komamura@gmail.com, 59900-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: akira.komamura@gmail.com, 59900@debbugs.gnu.org > Date: Sat, 10 Dec 2022 02:01:35 +0100 > > Michael Heerdegen writes: > > > But I still want to create a patch to support autoloading of the `map' > > pattern in "map.el", this is a good idea. > > I'm not so sure after thinking more about it: _Nothing_ in "map.el" has > an autoload cookie. I'm not convinced that out of all things `map' > pcase patterns should be the only thing that are autoloaded whereby > everything else in map.el requires an explicit `require'. That would be > hardly consistent Thanks. I agree with that conclusion, and so I'm closing this bug report. The fix should be in the programs that use pcase-map, not in core. From unknown Sat Aug 09 13:14:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Jan 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator