From unknown Fri Aug 15 20:24:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59897 <59897@debbugs.gnu.org> To: bug#59897 <59897@debbugs.gnu.org> Subject: Status: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Reply-To: bug#59897 <59897@debbugs.gnu.org> Date: Sat, 16 Aug 2025 03:24:59 +0000 retitle 59897 29.0.60; csharp-ts-mode: variable-name fontified as method wh= en invoking method with generic type-argument. reassign 59897 emacs submitter 59897 jostein@kjonigsen.net severity 59897 normal tag 59897 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 04:29:53 2022 Received: (at submit) by debbugs.gnu.org; 8 Dec 2022 09:29:53 +0000 Received: from localhost ([127.0.0.1]:55563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DE0-0006JF-3G for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:29:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:51856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DDt-0006J9-Vz for submit@debbugs.gnu.org; Thu, 08 Dec 2022 04:29:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3DDt-0008N5-Gw for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:29:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3DDn-0005fj-Vk for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2022 04:29:44 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0866C5C0108 for ; Thu, 8 Dec 2022 04:29:37 -0500 (EST) Received: from imap50 ([10.202.2.100]) by compute3.internal (MEProxy); Thu, 08 Dec 2022 04:29:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1670491777; x=1670578177; bh=f8 ELWmC1g0LlI531IHeK8f1TZ+OC7Zjh76bud1EYKKM=; b=pfSdKEgR0Eign5v+8w WY3VpMylx33E8OoRgtmmJPQBU8w6POoSabCmEo6fd6lxiSeGdi60lImo+cYckolM xxEKAv+0WOI/BBj8RvOGK4NkIWvBYj4R0bfy7W3fxPz9czbhMaPLlvyDDags/iaD wCFP3DlFQPZIYHUgXEClgAny9b+Up/DrTQEaRCyMEiwZJ4okL7Ru/JYg870ecDif cd6CDtJlCHlxR+WnLm1oGb/rxBM3F3IB+d++whJhfmEtaptkX8DG3uQHJAb+ZAsX TwIE2sBAwALvV/IePigAZQZg07h0dZxKlKRSUuJlf+Cu6O57cpyGhmZs75XPYqRo l4Jg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1670491777; x=1670578177; bh=f8ELWmC1g0LlI531IHeK8f1TZ+OC7Zjh76b ud1EYKKM=; b=c+bgm7JPErMk9nE/2grQOA6CQbAhpG2sFkAYdCEn88r104ontI5 xsxCNN6oNna9GK4OiHt4VA4xveFzIXspBN3sz+Cy3uJLvrsNwzRYwepfZiIwsb6K zm4fZD0LfZqb6vBYQZeb7tmfz1EtbfHMXkFvfhkoek8GXX/C6A7mjOMsnqNGfMfE wZsqVRJMwnEbpkVHbNZ2ydjSE1Z91+d4/hBPmcDFU4YSeThcwCDFv96tuZ2hbs06 2Fr+NSaT4HGqh7y+tM/sH+LtEwP3tSRA9n97qR0V2En4nA2cgC5Arahy4er1W5Yu k+NTS3qNxFaYMZHTVfg+QsnJe6QRmvn4+3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkfffhrhfvufgtsegrtderre erreejnecuhfhrohhmpeflohhsthgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghi nhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpe etueeigeetgeegheejuddugfeftedtvdegvdevledvueefhfeiveeujeejvdejvdenucff ohhmrghinheprghsphdrnhgvthdpkhhjnhhighhsvghnrdhnohenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhr vgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id AF5471700089; Thu, 8 Dec 2022 04:29:36 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.7.0-alpha0-1115-g8b801eadce-fm-20221102.001-g8b801ead Mime-Version: 1.0 Message-Id: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> Date: Thu, 08 Dec 2022 10:29:15 +0100 From: =?UTF-8?Q?Jostein_Kj=C3=B8nigsen?= To: bug-gnu-emacs@gnu.org Subject: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Type: multipart/alternative; boundary=67f1f6923254400ab9cf730ac38188bd Received-SPF: pass client-ip=66.111.4.28; envelope-from=jostein@secure.kjonigsen.net; helo=out4-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --67f1f6923254400ab9cf730ac38188bd Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable When I use the new csharp-ts-mode, method fontification is usually accur= ate with only 1 exception which I have encountered so far: When calling methods on objects, and that method accepts a generic type-= argument. You typically see this in Startup.cs-like files in ASP.Net Cor= e projects: services.AddSomeExtensionWithoutTypeArguments(); services.AddSomeExtensionWithTypeArguments(); In the above cases we see that fontification of "services" differs. For the first line, services is fontified using font-lock-variable-name-= face (correct), but in the latter case services is fontified using font-= lock-function-name-face (incorrect). In both cases I expected services to be fontified using font-lock-variab= le-name-face. -- Jostein In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0) of 2022-12-08 built on dev-jostein Repository revision: 8fb2afe051168b2eac2bba0ee102039d0af90a05 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.122010= 01 System Description: Ubuntu 22.04.1 LTS Configured using: 'configure --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_MONETARY: nb_NO.UTF-8 value of $LC_NUMERIC: nb_NO.UTF-8 value of $LC_TIME: nb_NO.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: C# Minor modes in effect: electric-pair-mode: t editorconfig-mode: t treesit-explore-mode: t flycheck-mode: t highlight-symbol-mode: t which-function-mode: t nlinum-mode: t company-mode: t global-ede-mode: t ede-minor-mode: t dap-tooltip-mode: t dap-ui-many-windows-mode: t dap-ui-controls-mode: t dap-ui-mode: t treemacs-filewatch-mode: t treemacs-follow-mode: t treemacs-git-mode: t treemacs-fringe-indicator-mode: t dap-auto-configure-mode: t dap-mode: t global-undo-tree-mode: t undo-tree-mode: t doom-modeline-mode: t projectile-mode: t ido-yes-or-no-mode: t helm-mode: t helm-minibuffer-history-mode: t shell-dirtrack-mode: t helm--remap-mouse-mode: t async-bytecomp-package-mode: t delete-selection-mode: t global-auto-revert-mode: t server-mode: t global-hl-line-mode: t yas-global-mode: t yas-minor-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /hom= e/jostein/build/emacs/lisp/transient Features: (shadow sort flyspell ispell mail-extr emacsbug message yank-media rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums face-remap semantic/lex-spp ede/emacs semantic/db semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local bug-reference helm-command helm-elisp helm-eval helm-info view vc-git diff-mode vc-dispatcher disp-table elec-pair csharp-mode cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch realgud realgud-zshdb realgud:zshdb-track-mode realgud:zshdb-core realgud:zshdb-init realgud-trepan3k realgud:trepan3k-track-mode realgud:trepan3k-core realgud:trepan3k-init realgud-trepan2 realgud:trepan2-track-mode realgud:trepan2-core realgud:trepan2-init realgud-trepanpl realgud:trepanpl-track-mode realgud:trepanpl-core realgud:trepanpl-init realgud-trepanjs realgud:trepanjs-track-mode realgud:trepanjs-core realgud:trepanjs-init realgud-lang-js realgud-trepan realgud:trepan-track-mode realgud:trepan-core realgud:trepan-init realgud-remake realgud:remake-track-mode realgud:remake-core realgud:remake-init realgud-rdebug realgud-rdebug-track-mode realgud-rdebug-core realgud-rdebug-init realgud-lang-ruby realgud-perldb realgud:perldb-track-mode realgud:perldb-core realgud:perldb-init realgud-lang-perl realgud-pdb realgud:pdb-track-mode realgud:pdb-core realgud:pdb-init realgud-lang-python python treesit realgud-kshdb realgud:kshdb-track-mode realgud:kshdb-core realgud:kshdb-init realgud-gub realgud:gub-track-mode realgud:gub-core realgud:gub-init realgud-gdb realgud:gdb-track-mode realgud:gdb-init realgud:gdb-core realgud-bashdb realgud:bashdb-track-mode realgud:bashdb-core realgud:bashdb-init realgud-lang-posix-shell realgud:run realgud-locals-mode realgud-breakpoint-mode realgud-backtrack-mode realgud-track-mode realgud-backtrace-mode realgud-attach realgud-lang-java realgud-track realgud-shortkey realgud-menu realgud-eval realgud-cmds realgud-send realgud-window realgud-utils eshell realgud-init realgud-file realgud-core realgud-reset realgud-buffer-helper realgud-buffer-breakpoint realgud-buffer-backtrace realgud-locals realgud-buffer-locals realgud-buffer-command realgud-buffer-info realgud-lochist realgud-bp realgud-bp-image-data realgud-lang esh-mode esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util cus-start realgud-loc realgud-buffer-source realgud-key key realgud-follow realgud-fringe realgud-helper loc-changes realgud-regexp realgud-custom load-relative flycheck highlight-symbol which-func edebug debug backtrace nlinum linum company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company-web-html company-web company-css web-completion-data company eww url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs ido-yes-or-no advice ido helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel cl-extra autorevert server hl-line lsp-mode lsp-protocol yasnippet help-mode xref project tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode color thingatpt noutline outline icons lv inline imenu ht filenotify f f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme compile-eslint compile text-property-search comint ansi-osc ansi-color ring cl finder-inf tree-sitter-indent-autoloads expand-region-autoloads ido-yes-or-no-autoloads nodejs-repl-autoloads marmalade-client-autoloads doom-modeline-autoloads elisp-slime-nav-autoloads multiple-cursors-autoloads dracula-theme-autoloads git-timemachine-autoloads crontab-mode-autoloads highlight-symbol-autoloads ssh-config-mode-autoloads langtool-autoloads dap-mode-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads gh-autoloads marshal-autoloads logito-autoloads pcache-autoloads kv-autoloads toml-mode-autoloads company-web-autoloads shrink-path-autoloads realgud-autoloads realgud-recursive-autoloads load-relative-autoloads paredit-autoloads bui-autoloads tree-sitter-langs-autoloads helpful-autoloads elisp-refs-autoloads magit-autoloads magit-section-autoloads git-commit-autoloads with-editor-autoloads flycheck-package-autoloads package-lint-autoloads rust-mode-autoloads yaml-mode-autoloads macrostep-autoloads lsp-docker-autoloads yaml-autoloads lsp-mode-autoloads spinner-autoloads f-autoloads hydra-autoloads nlinum-autoloads ht-autoloads loc-changes-autoloads transient-autoloads compat-autoloads web-mode-autoloads undo-tree-autoloads queue-autoloads ace-window-autoloads avy-autoloads bmx-mode-autoloads company-autoloads test-simple-autoloads js2-mode-autoloads web-autoloads s-autoloads ido-completing-read+-autoloads memoize-autoloads lv-autoloads imenu-anywhere-autoloads helm-projectile-autoloads projectile-autoloads helm-autoloads popup-autoloads helm-core-autoloads async-autoloads tree-sitter-autoloads tsc-autoloads editorconfig-autoloads json-mode-autoloads rx json-snatcher-autoloads yasnippet-autoloads web-completion-data-autoloads cargo-autoloads markdown-mode-autoloads pfuture-autoloads flycheck-autoloads pkg-info-autoloads epl-autoloads info dash-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 592007 30876) (symbols 48 54353 1) (strings 32 189953 13159) (string-bytes 1 6128946) (vectors 16 108411) (vector-slots 8 2026816 187502) (floats 8 550 561) (intervals 56 4720 24) (buffers 992 25)) -- Vennlig hilsen Jostein Kj=C3=B8nigsen jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com https://jostein.kj=C3=B8nigsen.no --67f1f6923254400ab9cf730ac38188bd Content-Type: text/html;charset=utf-8 Content-Transfer-Encoding: quoted-printable
When I use the = new csharp-ts-mode, method fontification is usually accurate with only 1= exception which I have encountered so far:

When calling methods on objects, and that method accepts a generic type= -argument. You typically see this in Startup.cs-like files in ASP.Net Co= re projects:

services.AddSomeExtensionWitho= utTypeArguments();
services.AddSomeExtensionWithTypeArgume= nts<MyType>();

In the above cases we = see that fontification of "services" differs.

For the first line, services is fontified using font-lock-variable-na= me-face (correct), but in the latter case services is fontified using fo= nt-lock-function-name-face (incorrect).

In = both cases I expected services to be fontified using font-lock-vari= able-name-face.

--
Jostein


In GNU Emacs 29.0.60 (build 1, x86= _64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16= .0) of 2022-12-08 built on dev-jostein
Repository revision= : 8fb2afe051168b2eac2bba0ee102039d0af90a05
Repository bran= ch: emacs-29
Windowing system distributor 'The X.Org Found= ation', version 11.0.12201001
System Description: Ubuntu 2= 2.04.1 LTS

Configured using:
= 'configure --with-tree-sitter'

Configured f= eatures:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM G= SETTINGS HARFBUZZ JPEG
LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD = LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG S= ECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER = X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Importan= t settings:
  value of $LC_MONETARY: nb_NO.UTF-8
<= /div>
  value of $LC_NUMERIC: nb_NO.UTF-8
  = value of $LC_TIME: nb_NO.UTF-8
  value of $LANG: en_U= S.UTF-8
  locale-coding-system: utf-8-unix
<= div>
Major mode: C#

Minor mod= es in effect:
  electric-pair-mode: t
&= nbsp; editorconfig-mode: t
  treesit-explore-mode: t<= br>
  flycheck-mode: t
  highlight-sym= bol-mode: t
  which-function-mode: t
&n= bsp; nlinum-mode: t
  company-mode: t
&= nbsp; global-ede-mode: t
  ede-minor-mode: t
  dap-tooltip-mode: t
  dap-ui-many-window= s-mode: t
  dap-ui-controls-mode: t
&nb= sp; dap-ui-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-gi= t-mode: t
  treemacs-fringe-indicator-mode: t
  dap-auto-configure-mode: t
  dap-mode: = t
  global-undo-tree-mode: t
  und= o-tree-mode: t
  doom-modeline-mode: t
=   projectile-mode: t
  ido-yes-or-no-mode: t
=
  helm-mode: t
  helm-minibuffer-hist= ory-mode: t
  shell-dirtrack-mode: t
&n= bsp; helm--remap-mouse-mode: t
  async-bytecomp-packa= ge-mode: t
  delete-selection-mode: t
&= nbsp; global-auto-revert-mode: t
  server-mode: t
=
  global-hl-line-mode: t
  yas-global= -mode: t
  yas-minor-mode: t
  too= ltip-mode: t
  global-eldoc-mode: t
&nb= sp; show-paren-mode: t
  electric-indent-mode: t
<= /div>
  mouse-wheel-mode: t
  menu-bar-mode:= t
  file-name-shadow-mode: t
  gl= obal-font-lock-mode: t
  font-lock-mode: t
<= div>  blink-cursor-mode: t
  column-number-mode:= t
  line-number-mode: t
  transie= nt-mark-mode: t
  auto-composition-mode: t
<= div>  auto-encryption-mode: t
  auto-compression= -mode: t

Load-path shadows:
/= home/jostein/.emacs.d/elpa/transient-20221202.1727/transient hides /home= /jostein/build/emacs/lisp/transient

Feature= s:
(shadow sort flyspell ispell mail-extr emacsbug message= yank-media
rfc822 mml mml-sec epa derived mm-decode mm-bo= dies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mai= lheader sendmail rfc2047 rfc2045
ietf-drums face-remap sem= antic/lex-spp ede/emacs semantic/db
semantic/util-modes se= mantic/util semantic semantic/tag semantic/lex
semantic/fw= mode-local bug-reference helm-command helm-elisp helm-eval
helm-info view vc-git diff-mode vc-dispatcher disp-table elec-pair
=
csharp-mode cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cm= ds
cc-styles cc-align cc-engine cc-vars cc-defs winner ffa= p tramp-archive
tramp-gvfs tramp-cache warnings time-stamp= zeroconf dbus add-log lsp-zig
lsp-steep lsp-svelte lsp-sq= ls lsp-ruby-syntax-tree lsp-yaml lsp-xml
lsp-vimscript lsp= -vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala
ls= p-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet
=
lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r
lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlna= vigator
lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix = lsp-nim lsp-nginx
lsp-mint lsp-marksman lsp-markdown lsp-l= ua lsp-kotlin lsp-json
lsp-javascript lsp-idris lsp-haxe l= sp-groovy lsp-hack lsp-graphql
lsp-gleam lsp-go lsp-comple= tion lsp-gdscript lsp-fsharp lsp-fortran
lsp-eslint lsp-er= lang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile
lsp-dhall= lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake
lsp= -clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash
=
lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript
ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit=
editorconfig editorconfig-core editorconfig-core-handle
editorconfig-fnmatch realgud realgud-zshdb realgud:zshdb-tr= ack-mode
realgud:zshdb-core realgud:zshdb-init realgud-tre= pan3k
realgud:trepan3k-track-mode realgud:trepan3k-core re= algud:trepan3k-init
realgud-trepan2 realgud:trepan2-track-= mode realgud:trepan2-core
realgud:trepan2-init realgud-tre= panpl realgud:trepanpl-track-mode
realgud:trepanpl-core re= algud:trepanpl-init realgud-trepanjs
realgud:trepanjs-trac= k-mode realgud:trepanjs-core realgud:trepanjs-init
realgud= -lang-js realgud-trepan realgud:trepan-track-mode
realgud:= trepan-core realgud:trepan-init realgud-remake
realgud:rem= ake-track-mode realgud:remake-core realgud:remake-init
rea= lgud-rdebug realgud-rdebug-track-mode realgud-rdebug-core
= realgud-rdebug-init realgud-lang-ruby realgud-perldb
realg= ud:perldb-track-mode realgud:perldb-core realgud:perldb-init
realgud-lang-perl realgud-pdb realgud:pdb-track-mode realgud:pdb-core=
realgud:pdb-init realgud-lang-python python treesit realg= ud-kshdb
realgud:kshdb-track-mode realgud:kshdb-core realg= ud:kshdb-init
realgud-gub realgud:gub-track-mode realgud:g= ub-core realgud:gub-init
realgud-gdb realgud:gdb-track-mod= e realgud:gdb-init realgud:gdb-core
realgud-bashdb realgud= :bashdb-track-mode realgud:bashdb-core
realgud:bashdb-init= realgud-lang-posix-shell realgud:run
realgud-locals-mode = realgud-breakpoint-mode realgud-backtrack-mode
realgud-tra= ck-mode realgud-backtrace-mode realgud-attach
realgud-lang= -java realgud-track realgud-shortkey realgud-menu
realgud-= eval realgud-cmds realgud-send realgud-window realgud-utils
eshell realgud-init realgud-file realgud-core realgud-reset
<= div>realgud-buffer-helper realgud-buffer-breakpoint realgud-buffer-backt= race
realgud-locals realgud-buffer-locals realgud-buffer-c= ommand
realgud-buffer-info realgud-lochist realgud-bp real= gud-bp-image-data
realgud-lang esh-mode esh-cmd esh-ext es= h-opt esh-proc esh-io esh-arg
esh-module esh-groups esh-ut= il cus-start realgud-loc
realgud-buffer-source realgud-key= key realgud-follow realgud-fringe
realgud-helper loc-chan= ges realgud-regexp realgud-custom load-relative
flycheck h= ighlight-symbol which-func edebug debug backtrace nlinum linum
=
company-oddmuse company-keywords company-etags etags fileloop gener= ator
company-gtags company-dabbrev-code company-dabbrev co= mpany-files
company-clang company-capf company-cmake compa= ny-semantic
company-template company-bbdb company-web-html= company-web company-css
web-completion-data company eww u= rl-queue shr pixel-fill kinsoku
url-file svg mm-url gnus n= nheader gnus-util mail-utils range mm-util
mail-prsvr ede/= speedbar ede/files ede ede/detect ede/base ede/auto
ede/so= urce eieio-base eieio-speedbar speedbar ezimage dframe
eie= io-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic
lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-l= ine
treemacs-compatibility treemacs-mode treemacs-interfac= e
treemacs-persistence treemacs-filewatch-mode treemacs-fo= llow-mode
treemacs-rendering treemacs-annotations treemacs= -async
treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator treemacs-scope pulse treemacs-fac= es
treemacs-icons treemacs-themes treemacs-core-utils pfut= ure
treemacs-logging treemacs-customization treemacs-macro= s gdb-mi bindat
gud bui bui-list bui-info bui-entry bui-co= re bui-history bui-button
bui-utils lsp-lens dap-gdb-lldb = dap-netcore dap-node dap-utils dom xml
dap-pwsh lsp-pwsh d= ap-python dap-mode dap-tasks dap-launch lsp-docker
yaml po= sframe dap-overlays undo-tree diff queue doom-modeline
doo= m-modeline-segments doom-modeline-env doom-modeline-core shrink-path
=
compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer<= br>
ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle o= b-ref ob-lob
ob-table ob-exp org-macro org-src ob-comint o= rg-pcomplete org-list
org-footnote org-faces org-entities = ob-emacs-lisp ob-core ob-eval
org-cycle org-table ol org-f= old org-fold-core org-keys oc org-loaddefs
find-func cal-m= enu calendar cal-loaddefs org-version org-compat org-macs
= ido-yes-or-no advice ido helm-mode helm-misc helm-files image-dired
<= /div>
image-dired-tags image-dired-external image-dired-util xdg ima= ge-mode
dired dired-loaddefs exif tramp tramp-loaddefs tra= mpver
tramp-integration cus-edit pp cus-load files-x tramp= -compat shell
pcomplete parse-time iso8601 time-date ls-li= sp helm-buffers helm-occur
helm-tags helm-locate helm-grep= helm-regexp format-spec helm-utils
helm-help helm-types h= elm helm-global-bindings helm-easymenu edmacro
kmacro helm= -core easy-mmode async-bytecomp helm-source helm-multi-match
helm-lib async helm-config delsel cl-extra autorevert server hl-line<= br>
lsp-mode lsp-protocol yasnippet help-mode xref project tre= e-widget
wid-edit spinner pcase network-stream puny nsm ma= rkdown-mode color
thingatpt noutline outline icons lv inli= ne imenu ht filenotify f
f-shortdoc shortdoc s ewoc epg rf= c6068 epg-config dash dracula-theme
compile-eslint compile= text-property-search comint ansi-osc ansi-color
ring cl f= inder-inf tree-sitter-indent-autoloads expand-region-autoloads
=
ido-yes-or-no-autoloads nodejs-repl-autoloads marmalade-client-auto= loads
doom-modeline-autoloads elisp-slime-nav-autoloads
multiple-cursors-autoloads dracula-theme-autoloads
=
git-timemachine-autoloads crontab-mode-autoloads
high= light-symbol-autoloads ssh-config-mode-autoloads langtool-autoloads
<= /div>
dap-mode-autoloads lsp-treemacs-autoloads treemacs-autoloads
cfrs-autoloads posframe-autoloads gh-autoloads marshal-auto= loads
logito-autoloads pcache-autoloads kv-autoloads toml-= mode-autoloads
company-web-autoloads shrink-path-autoloads= realgud-autoloads
realgud-recursive-autoloads load-relati= ve-autoloads paredit-autoloads
bui-autoloads tree-sitter-l= angs-autoloads helpful-autoloads
elisp-refs-autoloads magi= t-autoloads magit-section-autoloads
git-commit-autoloads w= ith-editor-autoloads flycheck-package-autoloads
package-li= nt-autoloads rust-mode-autoloads yaml-mode-autoloads
macro= step-autoloads lsp-docker-autoloads yaml-autoloads
lsp-mod= e-autoloads spinner-autoloads f-autoloads hydra-autoloads
= nlinum-autoloads ht-autoloads loc-changes-autoloads transient-autoloads<= br>
compat-autoloads web-mode-autoloads undo-tree-autoloads qu= eue-autoloads
ace-window-autoloads avy-autoloads bmx-mode-= autoloads company-autoloads
test-simple-autoloads js2-mode= -autoloads web-autoloads s-autoloads
ido-completing-read+-= autoloads memoize-autoloads lv-autoloads
imenu-anywhere-au= toloads helm-projectile-autoloads projectile-autoloads
hel= m-autoloads popup-autoloads helm-core-autoloads async-autoloads
tree-sitter-autoloads tsc-autoloads editorconfig-autoloads
json-mode-autoloads rx json-snatcher-autoloads yasnippet-autoload= s
web-completion-data-autoloads cargo-autoloads markdown-m= ode-autoloads
pfuture-autoloads flycheck-autoloads pkg-inf= o-autoloads epl-autoloads
info dash-autoloads package brow= se-url url url-proxy url-privacy
url-expand url-methods ur= l-history url-cookie generate-lisp-file
url-domsuf url-uti= l mailcap url-handlers url-parse auth-source cl-seq
eieio = eieio-core cl-macs password-cache json subr-x map byte-opt gv
<= div>bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl too= ltip
cconv eldoc paren electric uniquify ediff-hook vc-hoo= ks lisp-float-type
elisp-mode mwheel term/x-win x-win term= /common-win x-dnd tool-bar dnd
fontset image regexp-opt fr= inge tabulated-list replace newcomment
text-mode lisp-mode= prog-mode register page tab-bar menu-bar rfn-eshadow
isea= rch easymenu timer select scroll-bar mouse jit-lock font-lock syntax
=
font-core term/tty-colors frame minibuffer nadvice seq simple= cl-generic
indonesian philippine cham georgian utf-8-lang= misc-lang vietnamese
tibetan thai tai-viet lao korean jap= anese eucjp-ms cp51932 hebrew greek
romanian slovak czech = european ethiopic indian cyrillic chinese
composite emoji-= zwj charscript charprop case-table epa-hook
jka-cmpr-hook = help abbrev obarray oclosure cl-preloaded button loaddefs
= theme-loaddefs faces cus-face macroexp files window text-properties
<= /div>
overlay sha1 md5 base64 format env code-pages mule custom widg= et keymap
hashtable-print-readable backquote threads dbusb= ind inotify lcms2
dynamic-setting system-font-setting font= -render-setting cairo
move-toolbar gtk x-toolkit xinput2 x= multi-tty make-network-process
emacs)

<= /div>
Memory information:
((conses 16 592007 30876)
(symbols 48 54353 1)
(strings 32 189953 13159)=
(string-bytes 1 6128946)
(vectors 16 108411= )
(vector-slots 8 2026816 187502)
(floats 8 = 550 561)
(intervals 56 4720 24)
(buffers 992= 25))


--
Vennlig hilsen
Jostein Kj=C3=B8nigsen
jostein@kjonigsen.net =F0=9F=8D=B5 jostein@gmail.com
https://jostein.kj=C3=B8nigsen.no=

--67f1f6923254400ab9cf730ac38188bd-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 05:09:22 2022 Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 10:09:22 +0000 Received: from localhost ([127.0.0.1]:55771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3DqD-0008Bk-RA for submit@debbugs.gnu.org; Thu, 08 Dec 2022 05:09:22 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Dq8-0008BY-UR for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 05:09:20 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3A8E55C0115; Thu, 8 Dec 2022 05:09:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 08 Dec 2022 05:09:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670494151; x= 1670580551; bh=ShU+x+wA51ULwdRRFeNFooMHqbHbN2HQ2HRbhsdPmYE=; b=i H+QukQyNumVMol5vi/Zo0BMsIiQ1wt3WPTVsp9v0lHuJ8VNWrvqnLGFk+4jgbZTW vYFGoyDMzvhg0xFBFAPfI0sV7YC5uhpMBZtblfynOunRqVEgEeru6/uZ7yYjc91A ls5siNqCF7xUjoKd20U4UqjCxhXB8EQ8B0Ys52w7drti2mCOWErHZUtFz9tdtMtC egUp3rV1iMr3djSnKhF+0rbIHuH4JPpRpq7BO6eZfejxxEfy2zgwvOlvegnP6rB7 mEBmbWusKpYcIqUqJsCnvUKKjDZ0yhY9imyUqMQtXpY2xgdn4n4aSHb+2s7zn9cc BkYVgNx/Ff7ZAy15sQEAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670494151; x=1670580551; bh=ShU+x+wA51ULwdRRFeNFooMHqbHb N2HQ2HRbhsdPmYE=; b=E4nvJlnc1dT+JNOnQJS9hqhdmGiyPWbEzkWheNi+t8M0 8oFxTY4GOSOnlJIcF1oCH9ZZGcFR/rwtMq48C/aXIE72L2k6/TXdUWRqQcEW7o4d sFPkzoOC4r+vGOPOnBK5qCVj5rnxfkeJXaP2zqRQzmV14QNq4wJgWqGOWLDScBX+ owZEkez1bzwrurjwL95EL7zq19sTjwv18wLCZBvtW8WP58PJ0xO9y/IAWyvOESUC jrz5aH4B1cegFb8rK+/BsSd0FlT0MXnkiyktS6d1BenuIUobG3o8NfBYZW9phVXG YNZlZEKcFuPGsg6vCpOhCfjYuMT5hq0X4LacJvTqQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffvfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshhtvghi nhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgsh gvnhdrnhgvtheqnecuggftrfgrthhtvghrnhephfeiieehleeludejtefgteefiedvudeu ffevhfejgeduleejteegteetgeeuhfeknecuffhomhgrihhnpehkjhhnihhgshgvnhdrnh hopdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghi lhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 05:09:10 -0500 (EST) Content-Type: multipart/mixed; boundary="------------YjZmk0MKrjoAS9lDEiRWD30U" Message-ID: <7498aef6-892b-48a3-2214-775232501489@secure.kjonigsen.net> Date: Thu, 8 Dec 2022 11:09:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59897: Acknowledgement (29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument.) Content-Language: en-US To: 59897@debbugs.gnu.org, Yuan Fu , Theodor Thornhill References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------YjZmk0MKrjoAS9lDEiRWD30U Content-Type: multipart/alternative; boundary="------------Ud0g3Ubitpaw7rEgVKYHOvBW" --------------Ud0g3Ubitpaw7rEgVKYHOvBW Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit And here's the patch to fix it. *Jostein Kjønigsen* jostein.kjønigsen.no jostein@kjonigsen.net - jostein@gmail.com On 08.12.2022 10:30, GNU bug Tracking System wrote: > Thank you for filing a new bug report with debbugs.gnu.org. > > This is an automatically generated reply to let you know your message > has been received. > > Your message is being forwarded to the package maintainers and other > interested parties for their attention; they will reply in due course. > > Your message has been sent to the package maintainer(s): > bug-gnu-emacs@gnu.org > > If you wish to submit further information on this problem, please > send it to59897@debbugs.gnu.org. > > Please do not send mail tohelp-debbugs@gnu.org unless you wish > to report a problem with the Bug-tracking system. > --------------Ud0g3Ubitpaw7rEgVKYHOvBW Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

And here's the patch to fix it.


Jostein Kjønigsen
jostein.kjønigsen.no
jostein@kjonigsen.net - jostein@gmail.com
On 08.12.2022 10:30, GNU bug Tracking System wrote:
Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@gnu.org

If you wish to submit further information on this problem, please
send it to 59897@debbugs.gnu.org.

Please do not send mail to help-debbugs@gnu.org unless you wish
to report a problem with the Bug-tracking system.
--------------Ud0g3Ubitpaw7rEgVKYHOvBW-- --------------YjZmk0MKrjoAS9lDEiRWD30U Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-csharp-mode.el-improve-fontification-.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-csharp-mode.el-improve-fontification-.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBhYjczYzFlYTA2ODUzOGU3OWIwNjAxMmI5MTJjMDJiMGU5NjFiODQxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogVGh1LCA4IERlYyAyMDIyIDEx OjA3OjE1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvY3NoYXJwLW1v ZGUuZWw6IGltcHJvdmUgZm9udGlmaWNhdGlvbiBpbgogY3NoYXJwLXRzLW1vZGUKCkZpeGVz IGhpZ2hsaWdodGluZyBvZiBnZW5lcmljIG1ldGhvZHMgbGlrZSB0aGUgb25lIGJlbG93OgoK aW5zdGFuY2UuTWV0aG9kV2l0aFR5cGVBcmd1bWVudHM8VHlwZT4oLi4uKTsKSW5DbGFzc01l dGhvZFdpdGhUeXBlQXJndW1lbnRzPFR5cGU+KC4uLik7Ci0tLQogbGlzcC9wcm9nbW9kZXMv Y3NoYXJwLW1vZGUuZWwgfCAxMCArKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgOSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMv Y3NoYXJwLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9jc2hhcnAtbW9kZS5lbAppbmRleCA4 MmUzYmMwZDU0MS4uMTJlNDUyNzI1NTEgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2Nz aGFycC1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2NzaGFycC1tb2RlLmVsCkBAIC03 OTEsNyArNzkxLDE1IEBAIGNzaGFycC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKICAg ICAgKGludm9jYXRpb25fZXhwcmVzc2lvbgogICAgICAgKGlkZW50aWZpZXIpIEBmb250LWxv Y2stZnVuY3Rpb24tbmFtZS1mYWNlKQogICAgICAoaW52b2NhdGlvbl9leHByZXNzaW9uCi0g ICAgICAobWVtYmVyX2FjY2Vzc19leHByZXNzaW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LWZ1bmN0aW9uLW5hbWUtZmFjZSkpCisgICAgICAobWVtYmVyX2FjY2Vzc19leHByZXNzaW9u CisgICAgICAgZXhwcmVzc2lvbjogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUt bmFtZS1mYWNlKSkKKyAgICAgKGludm9jYXRpb25fZXhwcmVzc2lvbgorICAgICAgZnVuY3Rp b246IFsoZ2VuZXJpY19uYW1lIChpZGVudGlmaWVyKSkgQGZvbnQtbG9jay1mdW5jdGlvbi1u YW1lLWZhY2UKKyAgICAgICAgICAgICAgICAgKGdlbmVyaWNfbmFtZSAodHlwZV9hcmd1bWVu dF9saXN0CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFsiPCJdIEBmb250LWxv Y2stYnJhY2tldC1mYWNlCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChpZGVu dGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZQorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBbIj4iXSBAZm9udC1sb2NrLWJyYWNrZXQtZmFjZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICApXSkKIAogICAgICAoY2F0Y2hfZGVjbGFyYXRpb24KICAgICAg ICgoaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UpKQotLSAKMi4zNC4xCgo= --------------YjZmk0MKrjoAS9lDEiRWD30U-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 05:13:02 2022 Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 10:13:03 +0000 Received: from localhost ([127.0.0.1]:55790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Dtm-0008Dh-Ip for submit@debbugs.gnu.org; Thu, 08 Dec 2022 05:13:02 -0500 Received: from out-40.mta0.migadu.com ([91.218.175.40]:48238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Dth-0008DG-0q for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 05:13:01 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670494375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kEbOlDclbWvkUdYDC743lWfLbvpFPDkff8gRnxIwRWg=; b=QxT0rQl4lsP61kWDnctGnzVDC+F4dQCLYpzRMxk/gvxcOS0lWmb+XMjhoIGdmg0xrGMtPO qJ0LDbcaiHC0KQdeOq0ulNVERqzXwCLAtR9xtypBNXcm5AlSpTMEgUZsqY6oI2WH8UCnO0 oDV7Y/lIxZGDQs0lLL50oapHIWR4VJRjYH534ZBbNHRdadEqFu6x/XFdpMJ86cu+f9rsws tfXLHmMfZ7WvQk5wG7shOaqQZ8LWaSmln/EWfl22pwYV2KyvgsuD3Ay9ySo1CfkQ794SX5 ez4c28sNN6rMsWkOa1QRzuAo69L40nm7MnPiYaNv3Ap8AASaXsdmDAh/9fRt/g== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. In-Reply-To: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> ("Jostein =?utf-8?Q?Kj=C3=B8nigsen=22's?= message of "Thu, 08 Dec 2022 10:29:15 +0100") References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> Date: Thu, 08 Dec 2022 11:12:54 +0100 Message-ID: <87zgby9pax.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: casouri@gmail.com, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jostein Kj=C3=B8nigsen writes: > When I use the new csharp-ts-mode, method fontification is usually accura= te with only 1 exception which I have > encountered so far: > > When calling methods on objects, and that method accepts a generic type-a= rgument. You typically see this in > Startup.cs-like files in ASP.Net Core projects: > > services.AddSomeExtensionWithoutTypeArguments(); > services.AddSomeExtensionWithTypeArguments(); > > In the above cases we see that fontification of "services" differs. > > For the first line, services is fontified using font-lock-variable-name-f= ace (correct), but in the latter case services > is fontified using font-lock-function-name-face (incorrect). > > In both cases I expected services to be fontified using font-lock-variabl= e-name-face. > Can you test this patch, Jostein, and if you're happy, please install, Yuan :-) BTW, I think the ruleset is getting pretty gnarly in csharp-mode, so maybe we should consider slimming it down a little (without losing granularity) for perf reasons down the line! Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-expression-for-generic_name-in-csharp-ts-mode.patch >From 34fa2bc67ddffca65f219644f055f75a2b073aba Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Thu, 8 Dec 2022 11:08:28 +0100 Subject: [PATCH] Add expression for generic_name in csharp-ts-mode Given the below example, we want 'services' to be font-locked in 'font-lock-variable-name-face' in all cases. Previously this only worked in the first case, and the other was font-locked as 'font-lock-function-name-face'. namespace Foo { void Foo() { services.Add(); services.Add(); } } * lisp/progmodes/csharp-mode.el (csharp-ts-mode--font-lock-settings): Add new query that makes the mentioned example work. (bug#59897) --- lisp/progmodes/csharp-mode.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 82e3bc0d54..bedf3f4342 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -784,6 +784,10 @@ csharp-ts-mode--font-lock-settings (invocation_expression (member_access_expression (generic_name (identifier) @font-lock-function-name-face))) + (invocation_expression + (member_access_expression + expression: (identifier) @font-lock-variable-name-face + name: (generic_name (type_argument_list (identifier))))) (invocation_expression (member_access_expression ((identifier) @font-lock-variable-name-face -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 05:53:04 2022 Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 10:53:04 +0000 Received: from localhost ([127.0.0.1]:56010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EWV-0000H0-Q3 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 05:53:04 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:50425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EWT-0000GS-KE for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 05:53:02 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 82C135C00D9; Thu, 8 Dec 2022 05:52:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 08 Dec 2022 05:52:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1670496775; x=1670583175; bh=GhV8zelzGu tQLDt4+rkUxnWADYanUYMAq5C2vncuAvw=; b=jHpKxH9P4D8H2ostt6sjdBwC7V fDVF7cwW2zT8QsGNOQDKbMKcNpbVHabFSJ/bmRO62f5nYeVJ4aMt4TTFzqOjR+0f 5UN/dyashu8LZcO3nR6J+j3cs7PfvIjZWuDUH8wXxARwMQ2asU76bbMpR8gnXdIE j3CrMpEYn+qVvLHMzBxp5cVtdHCKP9Q5Tf3kMIpv+UxQY8SZRL5EQlWnIyCVzTlC AC+axhoyJAUmfH6Rn3ts60bEz8t0ZlKCYMVnd2kv2V3pT78HSi68q/TUhkyKLzAp 6E3srxNs4366c2khfQr5awqJg7vqhLx8iB1699NCv0rWAagDbO29vj/2My1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1670496775; x= 1670583175; bh=GhV8zelzGutQLDt4+rkUxnWADYanUYMAq5C2vncuAvw=; b=C KTKN9UP7Yrn3aslYNaCMl6EURMeDzMxI45A2N4cnCK4FqEQtKJ2MHVD79wmTEAdO 9tcq1k+18k40NLk4xRGXBl53/kK3IKFQ+GF2xRl9eM4OynxjnBKx/UFb/ZRN4VH+ if6qRgyJ2jpaNQMfsbeFwyd16A87G8wihj3twBVs4UCMMX0+xkFM9FhEYaM7m/Yt FMcttRHY0xs1JUt+9ifrD9Y5Z4O18IIEoKFikbSS+3+lzYdmzjLHK6+CjVmbP4D7 2JcgNWISvRTtABCMtLmCrKY46mLmhrt1wQxMLB4qHcJNfaZdeeuBX4MA0PfRqzVt G7sIBXeTSZCXR2EX5eGvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddvudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepffduleeiueegveffueekffeiffej udekleevhefgkeekueetlefhheeggefgtdehnecuffhomhgrihhnpegrshhprdhnvghtne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshht vghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 05:52:54 -0500 (EST) Message-ID: <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> Date: Thu, 8 Dec 2022 11:52:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Language: en-US To: Theodor Thornhill , =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87zgby9pax.fsf@thornhill.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 Cc: casouri@gmail.com, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 08.12.2022 11:12, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >> When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have >> encountered so far: >> >> When calling methods on objects, and that method accepts a generic type-argument. You typically see this in >> Startup.cs-like files in ASP.Net Core projects: >> >> services.AddSomeExtensionWithoutTypeArguments(); >> services.AddSomeExtensionWithTypeArguments(); >> >> In the above cases we see that fontification of "services" differs. >> >> For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services >> is fontified using font-lock-function-name-face (incorrect). >> >> In both cases I expected services to be fontified using font-lock-variable-name-face. >> > Can you test this patch, Jostein, and if you're happy, please install, > Yuan :-) I beat you by 3 minutes, but I'll be a gentleman and test none the less :D You test mine, and we can see which one we prefer? > BTW, I think the ruleset is getting pretty gnarly in csharp-mode, so > maybe we should consider slimming it down a little (without losing > granularity) for perf reasons down the line! > > Theo It's getting somewhat intricate, agreed. It's IMO not entirely obvious what the different rules are for or what cases they are meant to support. In that regard, I miss our old test-suite from github's csharp-mode. It was a nice safety-net when making changes like this. -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 06:12:22 2022 Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 11:12:22 +0000 Received: from localhost ([127.0.0.1]:56112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3EpB-0000Tr-Qy for submit@debbugs.gnu.org; Thu, 08 Dec 2022 06:12:22 -0500 Received: from out-28.mta0.migadu.com ([91.218.175.28]:55355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3Ep9-0000Tl-H0 for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 06:12:20 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670497938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tqtkfpjB4ahPsILdQiOBu5gkxvSOmi2MSzCmWd2QQlo=; b=VlcspuCy5cY1Oc5fO245e4rtmCVteIoUA31vefQBVjoS+978+4zMUgjXe8JC4GgUrIz1fI vLp7ebG/OWtb7fWeihynQp9B+HPei32IfxTU+7amb67BZDN4rh9H5sa6cr8U1gLhAxptv3 Iy06HoH8r+ItfL5NFM7xbfL4w8BF8xqyLCQr0QmUEnhGbaWlu5s5XKyt7230re2tATCTjd y7BO1l+zdj7B2DwLlGaguRstS9osFmkkLOLVUMFfGwZeTLWnDNi0TegHmzzipXvCbSzEZs Th7KrclU83D/BmWitcW1J75vVF7EhpWVI6u2AR3h4qvPsxWx8IOBhvlot/Do2A== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. In-Reply-To: <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> Date: Thu, 08 Dec 2022 12:12:17 +0100 Message-ID: <87r0xa9mjy.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: casouri@gmail.com, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > On 08.12.2022 11:12, Theodor Thornhill wrote: >> Jostein Kj=C3=B8nigsen writes: >> >>> When I use the new csharp-ts-mode, method fontification is usually accu= rate with only 1 exception which I have >>> encountered so far: >>> >>> When calling methods on objects, and that method accepts a generic type= -argument. You typically see this in >>> Startup.cs-like files in ASP.Net Core projects: >>> >>> services.AddSomeExtensionWithoutTypeArguments(); >>> services.AddSomeExtensionWithTypeArguments(); >>> >>> In the above cases we see that fontification of "services" differs. >>> >>> For the first line, services is fontified using font-lock-variable-name= -face (correct), but in the latter case services >>> is fontified using font-lock-function-name-face (incorrect). >>> >>> In both cases I expected services to be fontified using font-lock-varia= ble-name-face. >>> >> Can you test this patch, Jostein, and if you're happy, please install, >> Yuan :-) > > I beat you by 3 minutes, but I'll be a gentleman and test none the less :D > > You test mine, and we can see which one we prefer? Sure! Both seems to work from what I can tell :-) I'll let you be the judge! Theo From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 06:32:07 2022 Received: (at 59897) by debbugs.gnu.org; 8 Dec 2022 11:32:07 +0000 Received: from localhost ([127.0.0.1]:56202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3F8I-00038l-Hr for submit@debbugs.gnu.org; Thu, 08 Dec 2022 06:32:07 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:46899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3F8E-00038O-Lo for 59897@debbugs.gnu.org; Thu, 08 Dec 2022 06:32:05 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 20A225C00D2; Thu, 8 Dec 2022 06:31:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 08 Dec 2022 06:31:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670499117; x= 1670585517; bh=M1Uv9Kt9r2zsPwuklYM1xmjtgXXMbR5/T6vGZGj5Mhg=; b=c 7t1t3riUL+FibBa7or0y/Ja4GnaWF1GZNVzgMWTKaFv7+iNLz61t+XivTep4qwRl +kPHZcwgWJcqs4LzH1heSnylyzANbgSZeuh9bM2sb74w+AGtVh3bfL94f7P2kKjG xnDvwmChCo0JMRqe8nD+3srOjMWY7i4p6x4yiobRS7JQf8r88VV9w8EDtnDyEqUV kMO//fjZHX3TJ07VzW/4MpJD6EKVI0NC5rXwZAite/OdRNvHkB/bQhn+0IWreS8A CTVlCm3rCFkwI9fdlzOChbsS5wg6WfoxrPzteeFCoScNolrVjldMfYpfzDwIuph4 vjfDm8IvgH/vWM/7+uH7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670499117; x=1670585517; bh=M1Uv9Kt9r2zsPwuklYM1xmjtgXXM bR5/T6vGZGj5Mhg=; b=AC/10iyUrCT+hhQEeJBnHyildDQxmmZjk8jahmzLRIJA RlomyLCulJEUqMvfOMh02j1WwktDC4QMGAN3IcGbUtSvTGC+2LG8qd0Vc5Zf5RTC m/y9oIOv/qCVsZhkAEi7Kt9hY/ieXwvHlCQ2v/1mqe9tlW14TOe1KkFDWGaa/gjz HBC/8IoIIrx1veH+fTdS7qhFMCSNAYcssbv1fz7Sv5H6hyv9y4Wz7L/f2bt4G4jD 8uMw8jyaFcftCsZ1FYv3KRIceQVF3Qxpp47rwhW5C1GP/4bofrnUuSLhwsXDKTD+ 1+U/zt5yi3vrSirTV4CLEtpOPbDcv5PXXKJ3a3DJqw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgddvlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfuffvvehfhfgjsegrtderredtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefggeduueefudfhleegjeffffelffeh ueduvdelheejueeigeeuieeftdfggfdugfenucffohhmrghinheprghsphdrnhgvthenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgv ihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Dec 2022 06:31:56 -0500 (EST) Content-Type: multipart/alternative; boundary="------------PQTzMZChn4GgAa5H0vzI5B0i" Message-ID: <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> Date: Thu, 8 Dec 2022 12:31:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Language: en-US To: Theodor Thornhill , =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87r0xa9mjy.fsf@thornhill.no> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 Cc: casouri@gmail.com, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------PQTzMZChn4GgAa5H0vzI5B0i Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08.12.2022 12:12, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >> On 08.12.2022 11:12, Theodor Thornhill wrote: >>> Jostein Kjønigsen writes: >>> >>>> When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have >>>> encountered so far: >>>> >>>> When calling methods on objects, and that method accepts a generic type-argument. You typically see this in >>>> Startup.cs-like files in ASP.Net Core projects: >>>> >>>> services.AddSomeExtensionWithoutTypeArguments(); >>>> services.AddSomeExtensionWithTypeArguments(); >>>> >>>> In the above cases we see that fontification of "services" differs. >>>> >>>> For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services >>>> is fontified using font-lock-function-name-face (incorrect). >>>> >>>> In both cases I expected services to be fontified using font-lock-variable-name-face. >>>> >>> Can you test this patch, Jostein, and if you're happy, please install, >>> Yuan :-) >> I beat you by 3 minutes, but I'll be a gentleman and test none the less :D >> >> You test mine, and we can see which one we prefer? > Sure! Both seems to work from what I can tell :-) I'll let you be the > judge! > > Theo Your patch solves the issue described in the bug, but does not handle another fontification error I discovered while testing my patch: SimpleGenericMethod(params); In the above example SimpleGenericMethod is fontified using font-lock-type-face instead of font-lock-function-name-face. My patch fixes that case as well. As for which patch to choose: * From an objective perspective, the way I understand the code, your patch overrides an existing fontification to apply variable-name instead. * My patch however changes some selectors to be more specific selectors to avoid fontifying the variable-identifier, and also creates a new, highly-specific selector to fontify the variable-name aspect as well. From a performance perspective, I would assume the latter approach is more performant, but I don't know enough tree-sitter internals to say that with 100% confidence. Does anyone else know? -- Jostein --------------PQTzMZChn4GgAa5H0vzI5B0i Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08.12.2022 12:12, Theodor Thornhill wrote:
Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


On 08.12.2022 11:12, Theodor Thornhill wrote:

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have
encountered so far:

When calling methods on objects, and that method accepts a generic type-argument. You typically see this in
Startup.cs-like files in ASP.Net Core projects:

services.AddSomeExtensionWithoutTypeArguments();
services.AddSomeExtensionWithTypeArguments<MyType>();

In the above cases we see that fontification of "services" differs.

For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services
is fontified using font-lock-function-name-face (incorrect).

In both cases I expected services to be fontified using font-lock-variable-name-face.


Can you test this patch, Jostein, and if you're happy, please install,
Yuan :-)

I beat you by 3 minutes, but I'll be a gentleman and test none the less :D

You test mine, and we can see which one we prefer?

Sure!  Both seems to work from what I can tell :-)  I'll let you be the
judge!

Theo

Your patch solves the issue described in the bug, but does not handle another fontification error I discovered while testing my patch:

SimpleGenericMethod<Type>(params);

In the above example SimpleGenericMethod is fontified using font-lock-type-face instead of font-lock-function-name-face. My patch fixes that case as well.

As for which patch to choose:

  • From an objective perspective, the way I understand the code, your patch overrides an existing fontification to apply variable-name instead.
  • My patch however changes some selectors to be more specific selectors to avoid fontifying the variable-identifier, and also creates a new, highly-specific selector to fontify the variable-name aspect as well.

From a performance perspective, I would assume the latter approach is more performant, but I don't know enough tree-sitter internals to say that with 100% confidence.

Does anyone else know?

--
Jostein

--------------PQTzMZChn4GgAa5H0vzI5B0i-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 15:57:45 2022 Received: (at 59897) by debbugs.gnu.org; 9 Dec 2022 20:57:45 +0000 Received: from localhost ([127.0.0.1]:38458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kRE-0005Y0-Ep for submit@debbugs.gnu.org; Fri, 09 Dec 2022 15:57:45 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:38815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kRC-0005Xt-21 for 59897@debbugs.gnu.org; Fri, 09 Dec 2022 15:57:42 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id B14433200684; Fri, 9 Dec 2022 15:57:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 09 Dec 2022 15:57:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670619451; x= 1670705851; bh=59ccak+4zBQ2yS3aWs+JkLywLsapFg/WrooBtsV4hfU=; b=Y Pq+r84Fy9q95vu4oZR7Nd8JBZeqiDqSTdvqbMc0JV6SszZHfn2RuHtZ7/xJgSK2y N8WlzZuVr1f9z52E+YjA/osoGcIgLqYLu90c6GHivSBTuamgQQO8+gscedj+r5xT A0PafmurQD7lg+/oJ0mRhr+yIQd+cayybOiKf1/ZKcX3u0a4lLfyY4GPhdDW30XP S+QheVgqqYQHseHCrSSfDiRUhy/YJYYiud6Ml+kSUWkVX3M4pGGxNcNS/M07P471 J/wGSCufcT+pcBMOsc906Nk4a/Pu2gQaF1CkH4Q5z7uXzkYAwGcNsuRCS6ySqTPS 5BbOvggNTiuxavrY62EiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670619451; x=1670705851; bh=59ccak+4zBQ2yS3aWs+JkLywLsap Fg/WrooBtsV4hfU=; b=h0k9/xyqt6YtYKYI32ipt60qYW+FsO4y1+caOxLOIjTD gHY/XiR59O6bxzJuTaV1plLve+0mgHe1+CjOXuTl6NC2YWpR45vJypaQZmC5lia0 5Us0k7118teiZ73rQzXBf84iMgeK5NmLXDh4lUx0CWpPZE9Ggk4MPLWH3vlgaE+Y PCBE6bx4nZowOJq/ZPtN0ZSrIZoAqqeVC5Yeu8/z7ItZkp6AEYZRuDh68V6UfgLZ C0BXfF5MjwE0rq2DvIY4wy0C/W3dQojt/CELK2mjsPoSN52js4eDTjCDbvtDN4Kq lydimhNVgDv+LOMvfNxfW6J7QqWsJB1Mb1WhxZcjYg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvgddugeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuhffvvehfjgesrgdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdeijeegkefhjefgveehleekjedu uefhgfdvteeiieeifeetledtudevkefhfeeknecuffhomhgrihhnpegrshhprdhnvghtne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepjhhoshht vghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 9 Dec 2022 15:57:30 -0500 (EST) Content-Type: multipart/alternative; boundary="------------21pIo1aFI6Misno7QBqMH0kY" Message-ID: <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> Date: Fri, 9 Dec 2022 21:57:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Language: nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Yuan Fu References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> In-Reply-To: <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 Cc: Theodor Thornhill , 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------21pIo1aFI6Misno7QBqMH0kY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08.12.2022 12:31, Jostein Kjønigsen wrote: > On 08.12.2022 12:12, Theodor Thornhill wrote: >> Jostein Kjønigsen writes: >> >>> On 08.12.2022 11:12, Theodor Thornhill wrote: >>>> Jostein Kjønigsen writes: >>>> >>>>> When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have >>>>> encountered so far: >>>>> >>>>> When calling methods on objects, and that method accepts a generic type-argument. You typically see this in >>>>> Startup.cs-like files in ASP.Net Core projects: >>>>> >>>>> services.AddSomeExtensionWithoutTypeArguments(); >>>>> services.AddSomeExtensionWithTypeArguments(); >>>>> >>>>> In the above cases we see that fontification of "services" differs. >>>>> >>>>> For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services >>>>> is fontified using font-lock-function-name-face (incorrect). >>>>> >>>>> In both cases I expected services to be fontified using font-lock-variable-name-face. >>>>> >>>> Can you test this patch, Jostein, and if you're happy, please install, >>>> Yuan :-) >>> I beat you by 3 minutes, but I'll be a gentleman and test none the less :D >>> >>> You test mine, and we can see which one we prefer? >> Sure! Both seems to work from what I can tell :-) I'll let you be the >> judge! >> >> Theo > > Your patch solves the issue described in the bug, but does not handle > another fontification error I discovered while testing my patch: > > SimpleGenericMethod(params); > > In the above example SimpleGenericMethod is fontified using > font-lock-type-face instead of font-lock-function-name-face. My patch > fixes that case as well. > > As for which patch to choose: > > * From an objective perspective, the way I understand the code, your > patch overrides an existing fontification to apply variable-name > instead. > * My patch however changes some selectors to be more specific > selectors to avoid fontifying the variable-identifier, and also > creates a new, highly-specific selector to fontify the > variable-name aspect as well. > > From a performance perspective, I would assume the latter approach is > more performant, but I don't know enough tree-sitter internals to say > that with 100% confidence. > > Does anyone else know? > > -- > Jostein > Hey guys. This patch seems to have been left out, or slightly forgotten. Yuan, I think in this case we are going to prefer my patch over Theo's since it fixes 2 issues, instead of just 1. Could you install this? :) -- Jostein --------------21pIo1aFI6Misno7QBqMH0kY Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08.12.2022 12:31, Jostein Kjønigsen wrote:
On 08.12.2022 12:12, Theodor Thornhill wrote:
Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


On 08.12.2022 11:12, Theodor Thornhill wrote:

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


When I use the new csharp-ts-mode, method fontification is usually accurate with only 1 exception which I have
encountered so far:

When calling methods on objects, and that method accepts a generic type-argument. You typically see this in
Startup.cs-like files in ASP.Net Core projects:

services.AddSomeExtensionWithoutTypeArguments();
services.AddSomeExtensionWithTypeArguments<MyType>();

In the above cases we see that fontification of "services" differs.

For the first line, services is fontified using font-lock-variable-name-face (correct), but in the latter case services
is fontified using font-lock-function-name-face (incorrect).

In both cases I expected services to be fontified using font-lock-variable-name-face.


Can you test this patch, Jostein, and if you're happy, please install,
Yuan :-)

I beat you by 3 minutes, but I'll be a gentleman and test none the less :D

You test mine, and we can see which one we prefer?

Sure!  Both seems to work from what I can tell :-)  I'll let you be the
judge!

Theo

Your patch solves the issue described in the bug, but does not handle another fontification error I discovered while testing my patch:

SimpleGenericMethod<Type>(params);

In the above example SimpleGenericMethod is fontified using font-lock-type-face instead of font-lock-function-name-face. My patch fixes that case as well.

As for which patch to choose:

  • From an objective perspective, the way I understand the code, your patch overrides an existing fontification to apply variable-name instead.
  • My patch however changes some selectors to be more specific selectors to avoid fontifying the variable-identifier, and also creates a new, highly-specific selector to fontify the variable-name aspect as well.

From a performance perspective, I would assume the latter approach is more performant, but I don't know enough tree-sitter internals to say that with 100% confidence.

Does anyone else know?

--
Jostein

Hey guys.

This patch seems to have been left out, or slightly forgotten.

Yuan, I think in this case we are going to prefer my patch over Theo's since it fixes 2 issues, instead of just 1.

Could you install this? :)

--
Jostein

--------------21pIo1aFI6Misno7QBqMH0kY-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:05:16 2022 Received: (at 59897) by debbugs.gnu.org; 9 Dec 2022 21:05:16 +0000 Received: from localhost ([127.0.0.1]:38500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kYW-0005eU-CW for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:05:16 -0500 Received: from mail-pl1-f181.google.com ([209.85.214.181]:35711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kYT-0005eK-DX for 59897@debbugs.gnu.org; Fri, 09 Dec 2022 16:05:14 -0500 Received: by mail-pl1-f181.google.com with SMTP id t2so3159030ply.2 for <59897@debbugs.gnu.org>; Fri, 09 Dec 2022 13:05:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=kpsGkXqv/dZF8CxIlfe65xwei9Y+AKPxcbNE0cy9mCA=; b=SDtJGA7q+W0tt1966ko8tYeiKh/bbiNGf/0vMSbSfu0U5LguFwilABosdtMo1pB83K U0qVfaoGgYv2v34snyaqcTxnngnJ0go1Y9af9rQQZk82ySwPpGvNyhCZsGwotloYSrmb 8hz/VsbfXLdMxau58UU/EhlHt9JMhEcGGbXSqmLjK1Ta2+d5pJ9NDemypBmSnJ6IyESc Gs2HjyZIz+N2MrAr81fdCk0tqj2AW+Y3WU9+dvI8Y9cctu4rVgxUwrTFtOYHcpLhj9/H Jj4hTQwtngDGGOLwYssKDAPNssayiNFAZ/QlJM2pK8vka9DEykRTq5k0iU36ltbJFlpW sYdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kpsGkXqv/dZF8CxIlfe65xwei9Y+AKPxcbNE0cy9mCA=; b=je0SpCuSw+cMRNE9ejxkrH9Hh+ObX3uTYBCliTyM5BtG5sdvTbl44/uqUK+gkwWwgi tt3bJ8GJcL64QTDR87GW6MaaVuGwfZYoyGCGh64cPny7j9eOnARIAGOneKmtaTJuiqJf eUVClTaLK/tE59K9GWetXubhCBhZjDkAggcuyWOkakOS9lXYtpjnEmWb+shfAoCWTzS0 pC0Kj11rpW7PW1GReUXg9PsmA3zogvfhR6OqhlwpaoFMLJc6FUU/zl39Bl0UMJ5ru93o DRF0Ss0TyFACIEd0gnxhHrVf0k1scCuGCG+b3B8gaS2/SpObE5aBls08Y0I1X98UDSYy +toA== X-Gm-Message-State: ANoB5plODGe0rfeUfiiMKEPBQU9akuF/z23xdz6sAw+kpMBbewpKsc7f 6ZFWahwH+xQgRFtBEKS7jq4= X-Google-Smtp-Source: AA0mqf6Z4yBAvHa6TL12CmKrCgQV11JvA4G1Md3bAQf8Ls7K8deHMRMod86RwT4fsSo8dquLmbhevg== X-Received: by 2002:a05:6a20:441d:b0:a9:af6a:c9ef with SMTP id ce29-20020a056a20441d00b000a9af6ac9efmr13116873pzb.33.1670619907530; Fri, 09 Dec 2022 13:05:07 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id i134-20020a62878c000000b005761c4754e7sm1672282pfe.144.2022.12.09.13.05.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 13:05:06 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Message-Id: <3703C4B6-0BCF-4EFB-A996-F1B0D6896DD6@gmail.com> Date: Fri, 9 Dec 2022 13:05:04 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: jostein@kjonigsen.net, Theodor Thornhill , 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > On 08.12.2022 11:12, Theodor Thornhill wrote: >> Jostein Kj=C3=B8nigsen writes: >> >>> When I use the new csharp-ts-mode, method fontification is usually = accurate with only 1 exception which I have >>> encountered so far: >>> >>> When calling methods on objects, and that method accepts a generic = type-argument. You typically see this in >>> Startup.cs-like files in ASP.Net Core projects: >>> >>> services.AddSomeExtensionWithoutTypeArguments(); >>> services.AddSomeExtensionWithTypeArguments(); >>> >>> In the above cases we see that fontification of "services" differs. >>> >>> For the first line, services is fontified using = font-lock-variable-name-face (correct), but in the latter case services >>> is fontified using font-lock-function-name-face (incorrect). >>> >>> In both cases I expected services to be fontified using = font-lock-variable-name-face. >>> >> Can you test this patch, Jostein, and if you're happy, please = install, >> Yuan :-) > > I beat you by 3 minutes, but I'll be a gentleman and test none the = less :D > > You test mine, and we can see which one we prefer? >> BTW, I think the ruleset is getting pretty gnarly in csharp-mode, so >> maybe we should consider slimming it down a little (without losing >> granularity) for perf reasons down the line! >> >> Theo > > It's getting somewhat intricate, agreed. It's IMO not entirely obvious > what the different rules are for or what cases they are meant to > support. We had a discussion on emacs-devel that aims to standardize and define feature names, here is the list so far: Basic tokens: delimiter ,.; (delimit things) operator =3D=3D !=3D || (produces a value) bracket []{}() misc-punctuation constant true, false, null number keyword comment (includes doc-comments) string (includes chars and docstrings) string-interpolation f"text {variable}" escape-sequence "\n\t\\" function every function identifier variable every variable identifier type every type identifier property a.b <--- highlight b key { a: b, c: d } <--- highlight a, c error highlight parse error Abstract features: assignment: the LHS of an assignment (thing being assigned to), eg: a =3D b <--- highlight a a.b =3D c <--- highlight b a[1] =3D d <--- highlight a definition: the thing being defined, eg: int a(int b) { <--- highlight a return 0 } int a; <-- highlight a struct a { <--- highlight a int b; <--- highlight b } > > In that regard, I miss our old test-suite from github's csharp-mode. > It was a nice safety-net when making changes like this. A test suite is most welcome. I think we can even come up with a general framework for testing fontification, indent, defun movement, imenu, etc. To generate a test you would just need to open a file, verify everything is expected, and run a command which records the current fontification and indentation, etc, to a file. Then a test suite will just use that file. I wonder if csharp-mode had something like this? Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:07:39 2022 Received: (at 59897) by debbugs.gnu.org; 9 Dec 2022 21:07:39 +0000 Received: from localhost ([127.0.0.1]:38512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kap-0005g1-0j for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:07:39 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:56242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kam-0005ft-3D for 59897@debbugs.gnu.org; Fri, 09 Dec 2022 16:07:37 -0500 Received: by mail-pj1-f44.google.com with SMTP id u5so6019982pjy.5 for <59897@debbugs.gnu.org>; Fri, 09 Dec 2022 13:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=JsV8AWyX8acUS6WHQpB/l/52RmHryH1nT2n4AQxjNFw=; b=VZRSvjw9i3VJDgeJI2ZaqRnZRDX0cWMSHD+BzbgB2aXERopkR+3Tov7oRNkaX5UFJz dA3HmQf/p7t6TOM9FxoQLnGmbvZqCM8/G+yKO25ydo3S9lei+l4Ezsk+6HJBL8HVD293 TyObr3aG1cP2p7zw5A5Q/eCGRP/AFCtsQlduqn2xzhksdHpFhvQIDa2sBg0e5CcTKZO7 CPhoZT4Whf+cyF516ex6K9kSj/Ffac5VVrtgfsud/6QOZYjbxFgoFGUhYrAUTE/pTHpq DANVstvOWOlwtGSvZn1lezZKer4fVATDSQiGc2sCENbw5VRuXfUzUiwbF5vcThbukWvD Kvmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JsV8AWyX8acUS6WHQpB/l/52RmHryH1nT2n4AQxjNFw=; b=am8u5kT1NVsgXIzG3r9wYZ7YrRw8XZzOyLjuz/7leEv1L101qwvQm2C4P9bYRUg6wD zgSUf8FpBR2a8buBiHElbrSucCnTVGzS2U2t8dckF6cgEF8o+kiORrdsOBb7eJgQVWr2 INmggEMLtaOv7yZjZuxjVWM9CvsRvE5eqPj6d2F4JfpGVNAmsOUdUdKKnlHn9TH5Vm9S 38SBmWuDboVCxRYDlfShnr5EpBW0KMXGo0gHI1Eo6W6YrGYi/YboFN52E8DJrailFr4s 36kBnO1bs7CVV0CtY4GqaeQP3JvbktEkrBlPHDYS3UNXsqEoeb9nPITfHxId0ukYbRvq o5Aw== X-Gm-Message-State: ANoB5plcAEgTjKhptUnV2qd7OYWrus/m8CxYVKorMpAtV0r541YgxRty saaEA97zzwB9qiPKX7mJgsI= X-Google-Smtp-Source: AA0mqf4pPT8/4NO/pXyX73QBL/YeWIJ8mpN7WOHsn26nDHH1/K0XOxIweOXMwz5OS4yWGHGfWB2Jhg== X-Received: by 2002:a17:90a:d714:b0:21a:2d8:bf98 with SMTP id y20-20020a17090ad71400b0021a02d8bf98mr6987211pju.10.1670620050415; Fri, 09 Dec 2022 13:07:30 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y190-20020a6364c7000000b004777c56747csm1359273pgb.11.2022.12.09.13.07.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 13:07:30 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Message-Id: Date: Fri, 9 Dec 2022 13:07:28 -0800 To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: jostein@kjonigsen.net, theo@thornhill.no, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Your patch solves the issue described in the bug, but does not handle = another fontification error I discovered while > testing my patch: > > SimpleGenericMethod(params); > > In the above example SimpleGenericMethod is fontified using = font-lock-type-face instead of > font-lock-function-name-face. My patch fixes that case as well. > > As for which patch to choose: > > * =46rom an objective perspective, the way I understand the code, your = patch overrides an existing fontification to apply > variable-name instead. > * My patch however changes some selectors to be more specific = selectors to avoid fontifying the variable-identifier, and > also creates a new, highly-specific selector to fontify the = variable-name aspect as well. > > =46rom a performance perspective, I would assume the latter approach = is more performant, but I don't know enough > tree-sitter internals to say that with 100% confidence. > > Does anyone else know? I don=E2=80=99t think the two approach would have significant = difference. But I think more specific pattern is definitely better in terms of code = organization. Yuan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:11:47 2022 Received: (at 59897) by debbugs.gnu.org; 9 Dec 2022 21:11:47 +0000 Received: from localhost ([127.0.0.1]:38543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3keo-0005jE-PH for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:11:47 -0500 Received: from out-155.mta0.migadu.com ([91.218.175.155]:52332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3ken-0005j8-Nw for 59897@debbugs.gnu.org; Fri, 09 Dec 2022 16:11:46 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670620303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C7dyzb6wXtBi1lJSAu85u2yIA1q3PpR1sziRhrqFqkY=; b=E8iAgbDISww2mzUIRqvbPGslWj/fPOz73egD1nN97E/dxo9ErbxI/MsDhfcPQlESBrrGck 08MhcKZ+Gyod/rDiPh6SANG6phwrPQ0iN62U9nf3z+vkys5FxY9mbQ8/956CrYNX7Mas0i Q52NwSkT47Jak2yVI+sf996mS6fVAxs1L1oky792VuqTCRPTUeL9JdMdUNvXbRN/M/h8Yc cXVePyq62iMC6ioLRUkmrFB0Fk2iSY+pN4uuxj0e/vspFMV9NIuwlfcJfIPLeRCoGDGbL/ vevhCvhHZbXS1xxS3igCIzRJkoj46wE9p5uN03DG2nvYIK9JUeuDJ19f5K67ZQ== From: Theodor Thornhill To: Yuan Fu , Jostein =?utf-8?Q?Kj=C3=B8nigsen?= Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. In-Reply-To: <3703C4B6-0BCF-4EFB-A996-F1B0D6896DD6@gmail.com> References: <3703C4B6-0BCF-4EFB-A996-F1B0D6896DD6@gmail.com> Date: Fri, 09 Dec 2022 22:11:41 +0100 Message-ID: <87k030i8oi.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: jostein@kjonigsen.net, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi! >> >> In that regard, I miss our old test-suite from github's csharp-mode. >> It was a nice safety-net when making changes like this. > > A test suite is most welcome. I think we can even come up with a general > framework for testing fontification, indent, defun movement, imenu, etc. > To generate a test you would just need to open a file, verify everything > is expected, and run a command which records the current fontification > and indentation, etc, to a file. Then a test suite will just use that > file. I wonder if csharp-mode had something like this? > Yeah we had some trickery to check the font-locking and indentation, but it relies on external packages IIRC. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 09 16:12:42 2022 Received: (at 59897) by debbugs.gnu.org; 9 Dec 2022 21:12:42 +0000 Received: from localhost ([127.0.0.1]:38551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kfi-0005k1-4y for submit@debbugs.gnu.org; Fri, 09 Dec 2022 16:12:42 -0500 Received: from out2.migadu.com ([188.165.223.204]:21202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kfg-0005jv-PQ for 59897@debbugs.gnu.org; Fri, 09 Dec 2022 16:12:41 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670620360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=we7Y/qbVOCv1ixmeDLdHgf2fzZ+1oKR5fhusHwGWvD4=; b=vN1TJIKNS1RerngCVQleJCrvR8yXPJCvtbObbtyNPHsXMq7efA3QyEji06SKM54Is3RSd7 99jskUN2nLKY40/TXvLNLWGllAi3FxrD8fv3vE3lqHb4YcIoMSz24KNNlnFd+D7/Ko6NkL qhTNVeR/S+TgQs7CH+5M2BaK7e4NuH5/nd+x6KLXylf+iP7Na658CaLxy5WvdIp+FFRTWW ehvODW89s9yqqIhK8lP7qqSKcK04wvsypEOkV1bLaHqZDID9TQhCuOcU0taey5/V+k/aHq 1mBuIS/Z4SqhRAZjyem/IUiVYlDdoknLJ/MhjdUL4eUdHUBjHzWgposZxkaTMQ== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Yuan Fu Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. In-Reply-To: <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> Date: Fri, 09 Dec 2022 22:12:38 +0100 Message-ID: <87h6y4i8mx.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Hey guys. > > This patch seems to have been left out, or slightly forgotten. > > Yuan, I think in this case we are going to prefer my patch over Theo's > since it fixes 2 issues, instead of just 1. > > Could you install this? :) > I concur :-) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 02:58:47 2022 Received: (at 59897) by debbugs.gnu.org; 12 Dec 2022 07:58:47 +0000 Received: from localhost ([127.0.0.1]:51230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4di3-0001y6-CY for submit@debbugs.gnu.org; Mon, 12 Dec 2022 02:58:47 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4di1-0001xy-1k for 59897@debbugs.gnu.org; Mon, 12 Dec 2022 02:58:45 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id F0DAA5C00D5; Mon, 12 Dec 2022 02:58:39 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Dec 2022 02:58:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1670831919; x=1670918319; bh=X7 brYOIwIj31iPeaYzlnJiHkIGP34wGKvviON4yYUBM=; b=mMroorxAPjSUdHYHJO yxy8Bw46q7LmnATwYL/k/Z2hgANjIdW9lw1b+SX8Tbcrx39fXqRZ+/YYNmGIZqe9 M0TF9s40rvyLHuD7cM0X8OspoS7H+B9s7xdthypLdcnGamrq4Bz/OcU3chfFhaVW +DYlUqA5JxSsmAEiy9Vg77+t20vgwNKHz/voE8Qq0R1TOztdC3gz5FG6YthJ4O3L Kx+8itdyNdcoHeFq46wQYNkqjmcVcdAph+VIIu3xOPORnPdvAbz2e/90WVUW1XUW z6bkFrzc7oMl0SiahQPlv3DrmIYQcBtk4csWypHzx0OOb1Ja8ZeyaR7hiqvmwAeh Qnyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1670831919; x=1670918319; bh=X7brYOIwIj31iPeaYzlnJiHkIGP34wGKvvi ON4yYUBM=; b=viZFeEjpW5deSOFCXnRDpyc1829gu8mKob11Of/ft3zCtJo+W/Z 8TJWj+kVdqj/BZb70F2uhXQlT4ibSHZZDh2u2cv6Ym0a0EuKmJFKlzqzDV6VOeLR nStTjkvX9UNc/YSaszGjKV6/09isUZyWVZsmkfA62YMF5QibPkFuA5Btf4wZtvMU vQznNjzXEVu+ZlhcqGWkMmC3b+GRoWxtpQJwysnUJDNfQjEBhC6RgsYSix7HNA9t Wcpto8ff3XNBnT4UVhkVQgHHhtu6D5Nlh3ywncAAxDWnODJ+8NYUtGo0nUTDa5yw 2yLHmpo+lDeScz36fiouDMHY1zVd9ywUvew== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhephfegveevhfeffeeftddvhfdv ieeiffehieehgeehgedttdekveffleetteegvdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Dec 2022 02:58:39 -0500 (EST) Message-ID: <551f3d01-296e-e11e-df43-0363e3f9c5ab@secure.kjonigsen.net> Date: Mon, 12 Dec 2022 08:58:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Language: nb-NO To: Theodor Thornhill , Yuan Fu References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> <87h6y4i8mx.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87h6y4i8mx.fsf@thornhill.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 Cc: 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 09.12.2022 22:12, Theodor Thornhill wrote: >> Hey guys. >> >> This patch seems to have been left out, or slightly forgotten. >> >> Yuan, I think in this case we are going to prefer my patch over Theo's >> since it fixes 2 issues, instead of just 1. >> >> Could you install this? :) >> > I concur :-) Looking at my local emacs-29 branch it seems also this patch been "forgotten" and not been applied. Do you have time to get this installed, Yuan? -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 07:41:16 2022 Received: (at control) by debbugs.gnu.org; 12 Dec 2022 12:41:16 +0000 Received: from localhost ([127.0.0.1]:52729 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4i7P-0003xN-O2 for submit@debbugs.gnu.org; Mon, 12 Dec 2022 07:41:15 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4i7N-0003xG-Sj for control@debbugs.gnu.org; Mon, 12 Dec 2022 07:41:14 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CD6AA5C00E2 for ; Mon, 12 Dec 2022 07:41:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 12 Dec 2022 07:41:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:reply-to:sender:subject:to:to; s=fm1; t= 1670848868; x=1670935268; bh=4NpH8r4/3UWFu0+akVl7DMgiLQ/JTQBU2iH 74sInYTw=; b=Pu7iR1zCCJXU7njBMJnRI5TxyCtob7IKvUuVBWLE/mo5t6lNvFh 2ZZqCy0G/5J0UamejoyPwslgcuiyHFEbJYEJPKQKTsZaticS7xeq7vs+JlSjSRDr NCXbCiX9Bl0Tx0hItFIJ3DG4HFZ/lJ4dxmj4D2f0EiBJXcer2jJ/cMUF6RyiNw1E LTljuvbIqyhcIAEEgOxYWLxglk1FG+lrpJFQZWzYp85W+WPRKldGDY8y7yYYSOaN FmzY1AESmCj8eMqi5jaPx3lfvJkATq3FY3S+LKR59OqDNQ3YTFWsTrBHqNA9/+0w O3zLn9/kPg6ar2hQB2X76JlWvHjkYwHzcfg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:reply-to:sender:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1670848868; x=1670935268; bh=4NpH8r4/3UWFu0+akVl7DMgiLQ/J TQBU2iH74sInYTw=; b=U47zNcnu8snNTfZKsiXtad3gGwQZnXjeDD3BtvFknNI4 FYhvwqvuR/fgpAgaooFgzYUJSh30Fu9K5HvziDKxCNFim1l4+NFpaIPRLaY9hkGs fbrQiTiWEf+BHkxjTY8P+scTuDbUEHftTRuAqGAUu6O8mcssLmM4xwtbhpeRQvoJ /q4vWtej0M5izEeK+vTIsb9FQbpkJ82KOvKpbeBZiaAe22tncnaWHD1AbF+FHG3y de8Nzx33Ten69shm2X1rpSG8lnzkFXYIQw3IPCex2bs9faoidsUI924crhtFAaRN Ris4sVzv3R8TbcCbHdGXgA7r2Gt43L/WYEy1SahteA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecugfhmphhthicushhusghjvggtthculddutddmnecujf gurhepkfffgggfrhfvhfgtgfesthejredttdefjeenucfhrhhomheplfhoshhtvghinhcu mfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnh drnhgvtheqnecuggftrfgrthhtvghrnheptedvudekueekveevlefgteefgeekheehvefh teevgedugfetgeekfffgudduffefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghn rdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 12 Dec 2022 07:41:08 -0500 (EST) Message-ID: <8ad33559-2bf1-ca7a-2c8f-971ec11a1f5c@secure.kjonigsen.net> Date: Mon, 12 Dec 2022 13:41:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: nb-NO To: control@debbugs.gnu.org From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 59897 patch Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.29 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) tags 59897 patch From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:19:46 2022 Received: (at 59897) by debbugs.gnu.org; 12 Dec 2022 22:19:46 +0000 Received: from localhost ([127.0.0.1]:55753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4r9G-0004u6-CI for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:19:46 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:52095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4r9E-0004tt-2q; Mon, 12 Dec 2022 17:19:44 -0500 Received: by mail-pj1-f41.google.com with SMTP id gt4so1346555pjb.1; Mon, 12 Dec 2022 14:19:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZLWGMs7R4vOFQuP6PXe1f+US988GfN1KlsXC/8Peo7Q=; b=O+MUzyMBVh499L0ehTRMflOBHVRurLmy6w714U4V6ekxssQ6Q3a+csHZFX8UetMWkm XkuYG2C6PYOSuxIaVI4chLOCdwsHGef8+FIum2FJvr3swfRF1mTV7m7EYjqj+2RGRK7I coCSe0ujsoIDsE2qLQySIEk/FchVyM5tAjLFuzJtKI4w6pCA48UKyxKgt29+zHTBL8Dg US3j/d8F9BTZJz3YR0hQMzLYiSQb3XbLkBx3qAP5Jm5LsfhtyzQc0dDGx6Y3FT1tFEAm 56WHT0tVaX5PNoKJx1/Kt7xSDUv9cHfitfmhTXWGrS1so6WR14Brz6foCRC0L5meHwj/ pZiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZLWGMs7R4vOFQuP6PXe1f+US988GfN1KlsXC/8Peo7Q=; b=SPbmAvYRULilz0kefNMtzYeWqegU+R/T9PMS0rxmONaofMOxL6Wrw4ghud3pBICzVl 0OjRIBZE6kHRA/D+wA3HmKsd//HyilzwaXzVAtfSJLKsTB+Ib+VJgLpPDjCKV2Lb+qmM vbtwrwfZKK6BAbjtj/zpx457KXHy59hfTqlEYRSgRJrcavCssZlXK8LKsyIYQbIn6n/8 FA3BiLR4UQ9QJ0SdqR8yNr63m5hcD425fAU/ft6R24SzeNjF4GQtov+2HyBqzeMfvkon 9XmpzuzcZUzMyKLcwk8AC9AM/CQwBoG5SUT1L9AOXJuJtHWyrvxVEtk3LjLZTVe20pLk rHmQ== X-Gm-Message-State: ANoB5pmXlKDc27jL16AJfcxsSZiprPLfQtGhVRNq7rjHZA2TiHbzwOha OiQVTbKxKvH24Qgo60K45Rc= X-Google-Smtp-Source: AA0mqf4sYaalZHJbusLF78VxiYfrA6LlD6PKr/drYJMM9SL/4BaFDW95iSZIVMaF6Vu7/jcO93nLyw== X-Received: by 2002:a17:902:e0d4:b0:18f:438a:cfe1 with SMTP id e20-20020a170902e0d400b0018f438acfe1mr7079428pla.59.1670883577976; Mon, 12 Dec 2022 14:19:37 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q8-20020a170902eb8800b001868d4600b8sm6868793plg.158.2022.12.12.14.19.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:19:37 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. From: Yuan Fu In-Reply-To: <551f3d01-296e-e11e-df43-0363e3f9c5ab@secure.kjonigsen.net> Date: Mon, 12 Dec 2022 14:19:33 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> <87h6y4i8mx.fsf@thornhill.no> <551f3d01-296e-e11e-df43-0363e3f9c5ab@secure.kjonigsen.net> To: jostein@kjonigsen.net X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: Theodor Thornhill , 59897@debbugs.gnu.org, 59897-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 11, 2022, at 11:58 PM, Jostein Kj=C3=B8nigsen = wrote: >=20 > On 09.12.2022 22:12, Theodor Thornhill wrote: >>> Hey guys. >>>=20 >>> This patch seems to have been left out, or slightly forgotten. >>>=20 >>> Yuan, I think in this case we are going to prefer my patch over = Theo's >>> since it fixes 2 issues, instead of just 1. >>>=20 >>> Could you install this? :) >>>=20 >> I concur :-) >=20 > Looking at my local emacs-29 branch it seems also this patch been = "forgotten" and not been applied. >=20 > Do you have time to get this installed, Yuan? Yes, of course, my apologies :-) Also, beautiful commit message, = Jostein, I love it :-) Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 13:49:27 2022 Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 18:49:27 +0000 Received: from localhost ([127.0.0.1]:40949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Woo-0006Vn-Tw for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:49:27 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Wom-0006Va-5X; Wed, 14 Dec 2022 13:49:24 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1FA935C0191; Wed, 14 Dec 2022 13:49:19 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 14 Dec 2022 13:49:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1671043759; x=1671130159; bh=vx NkFe9fmTqeV1DIs1fUbXul+y/V8xFy29YKHR09cQc=; b=gCKsPK/RRMlf/gUTc5 xTaRfYG+McY3ZlhV6atWQM1EOkQ6MNVVN4XN+Q9JVRoMlRJiKm5LipD7+O89nint /qJtp5LMlf7X2m+noRVcJA/rciZ59Y+I/8tacgLMexn4QufMZiC/2KT1C8pTw+uQ bWJtAOmReZBDDPrg4CcDaVrDL7kF2S1tIhchNccIYQEhVfMCf4WmS3vDp5hUXEOB XDt+qmLNjhhBVTP2chv2Kri5ZolthSmEzYgXYVo75ns8mwe/EtgWwg7cDi00DyEY bAfPrO3YODn8/F0MIBGqrtp9HruPasH1bzBYLPaIMPITFZkIVIjvsnUPPqdpmPqU Ki1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1671043759; x=1671130159; bh=vxNkFe9fmTqeV1DIs1fUbXul+y/V8xFy29Y KHR09cQc=; b=F1yRWQ/zuPIWRKhHFv13TZHE8yMRr5yC4n1Bkm92uXNQjCUhi61 B4MKkLFRbzCT9NBBb0uuV6R3NqDEcHDiD2gSY4ncxTAWaBgYxxLUJtB+Rur4tq3M Cfxe8OimVtftVPUjDIgEzivPTAYLz8vTmBJOtZ8YEkdvYPTJHI4Z/241N2nmNw/s zQGCOhfczSuCUv3GTRMs8jvHL2j6xher5g0wlPhgjOZJfFmpLfX/yVuivgz5rK7T Lra++JPUZNf3/WoEZclvVBIMpUpxlhwuYYlDQbEDAsy4JeA/+omUB6Wdzy0GRkF4 mRmK0oG/dbF2WU12O14r2xNbfsBNxykWiig== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhephfegveevhfeffeeftddvhfdv ieeiffehieehgeehgedttdekveffleetteegvdejnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 13:49:17 -0500 (EST) Message-ID: <8f2b0144-0aae-10c5-ac14-15fcd56ede4e@secure.kjonigsen.net> Date: Wed, 14 Dec 2022 19:49:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Content-Language: en-GB, nb-NO To: Yuan Fu , Eli Zaretskii References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> <87h6y4i8mx.fsf@thornhill.no> <551f3d01-296e-e11e-df43-0363e3f9c5ab@secure.kjonigsen.net> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59897 Cc: 59897-reopen@debbugs.gnu.org, Theodor Thornhill , 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 12.12.2022 23:19, Yuan Fu wrote: > On 09.12.2022 22:12, Theodor Thornhill wrote: >>>> Hey guys. >>>> >>>> This patch seems to have been left out, or slightly forgotten. >>>> >>>> Yuan, I think in this case we are going to prefer my patch over Theo's >>>> since it fixes 2 issues, instead of just 1. >>>> >>>> Could you install this? :) >>>> >>> I concur :-) >> Looking at my local emacs-29 branch it seems also this patch been "forgotten" and not been applied. >> >> Do you have time to get this installed, Yuan? > Yes, of course, my apologies :-) Also, beautiful commit message, Jostein, I love it :-) > > Yuan I see bug marked as done, but I don't see this pushed to the emacs-29 branch. Are you sure this has been installed Yuan? -- Jostein From unknown Fri Aug 15 20:24:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 14 Dec 2022 19:02:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 14:44:01 2022 Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 19:44:01 +0000 Received: from localhost ([127.0.0.1]:41197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Xfc-0000ty-M1 for submit@debbugs.gnu.org; Wed, 14 Dec 2022 14:44:00 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:44800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Xfa-0000tp-E6; Wed, 14 Dec 2022 14:43:59 -0500 Received: by mail-pj1-f52.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so299289pjo.3; Wed, 14 Dec 2022 11:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=SgRMCe8hdTrWtHe8bzeSM3fQ41wMCG1r9ZlPWBZsil8=; b=KB8DJT7ddwGqweJc+yojW5UV4wUjhmdtwyXS8ImlNjf/lbvmNxe7pZBXykAUJmvnJn 8mX+FuTEiZq6/pzg1NNIvhU509WqRJgfi6chdLX5GoRIoH4PBSKuxbKTRcmW1i99O0Bt 4Rcb5uDmrxTjFo15DQkNcMMcaQTiimR7N+lhU6WvJIYZsM6zt1L1iqC/rkbUwKgD4+G3 raUQZUOLsBWb4oF4HCCjEmZ/ICh7bZhDmxCkMiJVxpQZqZh/7dvT7sZXAfyXvG9jnL32 oTwEZ7tLjWcocEsxWkCl17fYjTmx0SugWeCIdRLGdqdovl27Bq5Iz0WnUyFYWgveqXVr 7wSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SgRMCe8hdTrWtHe8bzeSM3fQ41wMCG1r9ZlPWBZsil8=; b=bi+V2/N+mBSDmGlNHpOBfNCofsB149FjsGGv0yT+iGSwQatDCMnfHdKjUOorgceMVS MJeDr8KTDK9iL8PLW7om9DXQW2R5JVs+S5IL7SH0D+uHN3lC1bqlZm71x1LdQdA0t1mY OqMgsoziTFMqWBsBrqiiMSRXuhMBbLQYmwpbijrODok1ORl9Pi3K/oALIIHCX61/AO8z YWVLXDvFrqZR5Gqvs8V7A1v/CJ8zp6m2rdmg0xpIaBhr51jJEdr22KynHXIK+zGnp29Y 1a9RZAOpD6AFslcozKWbNTAH1Zfk1jri1oZH8lxb2RrNF42jbjSwy4k+PrD7eJcfCgQX W9SQ== X-Gm-Message-State: ANoB5plwJmg/SqdTu1A8B8j1jg6lP4Pyws7dwPZYW82ktu4VBu3cBRg6 59HstAVW0luA8IDIare2bNCmtH48HcQw5Q== X-Google-Smtp-Source: AA0mqf4DgwffF7Ti+Z8B6KRiHJ0joSNsOS6MjYxUUH64x8woVd5ANdkk2FLzabkCHk1YWZMhvzGgCw== X-Received: by 2002:a17:903:248c:b0:189:c7e3:275f with SMTP id p12-20020a170903248c00b00189c7e3275fmr25055643plw.38.1671047032586; Wed, 14 Dec 2022 11:43:52 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id im22-20020a170902bb1600b00189502c8c8bsm2244881plb.87.2022.12.14.11.43.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 11:43:52 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. From: Yuan Fu In-Reply-To: <8f2b0144-0aae-10c5-ac14-15fcd56ede4e@secure.kjonigsen.net> Date: Wed, 14 Dec 2022 11:43:50 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <76edd79f-6da1-4c28-b20e-5eb4d9a819b2@app.fastmail.com> <87zgby9pax.fsf@thornhill.no> <8fdc4d5d-17ac-3a06-d602-637df9fe1be1@secure.kjonigsen.net> <87r0xa9mjy.fsf@thornhill.no> <667add54-91b3-f820-3163-0f33d9d97056@secure.kjonigsen.net> <44bc94b1-1c68-f1ff-fc50-bb289fdae2f2@secure.kjonigsen.net> <87h6y4i8mx.fsf@thornhill.no> <551f3d01-296e-e11e-df43-0363e3f9c5ab@secure.kjonigsen.net> <8f2b0144-0aae-10c5-ac14-15fcd56ede4e@secure.kjonigsen.net> To: jostein@kjonigsen.net X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: 59897-reopen@debbugs.gnu.org, Eli Zaretskii , Theodor Thornhill , 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 14, 2022, at 10:49 AM, Jostein Kj=C3=B8nigsen = wrote: >=20 > On 12.12.2022 23:19, Yuan Fu wrote: >> On 09.12.2022 22:12, Theodor Thornhill wrote: >>>>> Hey guys. >>>>>=20 >>>>> This patch seems to have been left out, or slightly forgotten. >>>>>=20 >>>>> Yuan, I think in this case we are going to prefer my patch over = Theo's >>>>> since it fixes 2 issues, instead of just 1. >>>>>=20 >>>>> Could you install this? :) >>>>>=20 >>>> I concur :-) >>> Looking at my local emacs-29 branch it seems also this patch been = "forgotten" and not been applied. >>>=20 >>> Do you have time to get this installed, Yuan? >> Yes, of course, my apologies :-) Also, beautiful commit message, = Jostein, I love it :-) >>=20 >> Yuan >=20 > I see bug marked as done, but I don't see this pushed to the emacs-29 = branch. >=20 > Are you sure this has been installed Yuan? >=20 > -- > Jostein Indeed, I forgot to push my local branch. I just did that. Now you = should see it, sorry for the inconvenience :-) Yuan From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 16:46:09 2022 Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 21:46:09 +0000 Received: from localhost ([127.0.0.1]:41895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZZp-00078K-5J for submit@debbugs.gnu.org; Wed, 14 Dec 2022 16:46:09 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZZj-00077W-Po; Wed, 14 Dec 2022 16:46:07 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B04145C0096; Wed, 14 Dec 2022 16:45:58 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 14 Dec 2022 16:45:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671054358; x=1671140758; bh=umacdySxqx bvRZMxCfSzccUGYgxY7XLu96tpdTqhWkQ=; b=Vbq0/mzvpfMs+HQ8DzoqUjszkY Bl07Danm8td6BnoqO2YXfNv0CJh7gOUoCiVNIpjcBGjpU8Am5xCSzY2W+nFGe9zl /IAO2yWxB76lg+p7tt2PWGP07LEuLLKGYm9gjFuzAkOF+cbWHskUWoaw3eO4foz4 xCxdb+dy3+q/kYa1lzCkZF92gZ4siufaM64loel4vcrnmQ5Armf/AehuACBLzrJr 3Qt+vTuO/1czYFBgKi1nvYov+SjoJvzFbY3Py6Cn8mxDnUkvzkRiiaZJWeG15Pa+ Zd2lDFHX6PwMYEMiwDVVGRS1ocywdMzxHoj6Fy9yPoYQaB7e3U2xAGCm4GQw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671054358; x= 1671140758; bh=umacdySxqxbvRZMxCfSzccUGYgxY7XLu96tpdTqhWkQ=; b=d z5Y2YbY/k8fRxlzLUu8gTsCS9Sfq85qs444mbntmC7FMZwTk03KkyWfIQLwG2BR2 BDrEAnBdADw58IYU8p6p9lX2LHpSkL5qDBuzR2lO72MUpHHJG3GJkYF1m4p59pEY 0mQKypBUp9Lej3M/HgueCnk+4XQXWpjvfKNdHWOOraLKpRUXHZN02teP1VS46wZC rvZsZ1QUuIFwDPAbYdD9AfpIDY1slo0oG1nDU3Va+c37hQ1BHJ9smrAfX/c/Nqd5 KnH6pciWKJkQqcHsCW76haoKKUW4b2OSKP6qpxctx7+oXk3hponhHdPhSLBLXGom Vvl5CHZmtEoEknHiUUASA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosegrjehmrehhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehveeujefgtdegffdthfeiteel veettdejfffffeeiffdtvefhgefhjefhgfegudenucffohhmrghinhepghhnuhdrohhrgh dpkhhjnhhighhsvghnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrd hnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 16:45:57 -0500 (EST) Content-Type: multipart/alternative; boundary=Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD Content-Transfer-Encoding: 7bit From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. Date: Wed, 14 Dec 2022 22:45:44 +0100 Message-Id: References: In-Reply-To: To: Yuan Fu X-Mailer: iPhone Mail (20C65) X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 59897 Cc: 59897-reopen@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii , jostein@kjonigsen.net, 59897@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD Content-Type: multipart/related; type="text/html"; boundary=Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Transfer-Encoding: 7bit --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hey Yuan. 

=46rom= what I can see you pushed Teos patch and not mine?

emac= s.git - Emacs source repository
savannah.gnu.org
3D"favicon.ico"

In the email discussion earlier we unanymously decided= on that for technical reasons my patch was more appropriate for this partic= ular bug, and it also fixed another fontification bug. 

<= /div>
What do we do now? Should we revert this commit and apply mine ins= tead?

Sorry for all the =E2=80=9Cnoise=E2=80=9D, bu= t this gets hard to follow up for all of us when latency between input and o= utput gets too long, and then we end up writing emails like this, instead of= writing good code to improve emacs and our new major-modes. 

If= this could get cleaned up, installed properly, confirmed -and- pushed at th= e same time, it would be easier for me to verify that the right patch was pu= t in place, and then I wouldn=E2=80=99t nag you for weeks end for what is re= ally just 4 lines of code ;)

=E2=80=94
Jostein K= j=C3=B8nigsen
https://jostein.kj=C3=B8nigsen.net

On 14 Dec 2022, at 20:45, Yuan Fu &= lt;casouri@gmail.com> wrote:

=EF=BB=BF

On Dec 14, 2022, at 10:49 AM, Jostein Kj=C3=B8nigsen &= lt;jostein@secure.kjonigsen.net> wrote:

On 12.12.2022 23:19, Yuan Fu wrote:
On 09.12.2022 22:12, Theodor Thor= nhill wrote:
<= blockquote type=3D"cite">
Hey guys.

=
This patch seems to have been left out, or slightly forgotten.

Yuan, I think in this case we are goi= ng to prefer my patch over Theo's
since it fixes 2 issues, instead of just 1.

=
Could you install this? :)
<= blockquote type=3D"cite">

I concur :-= )
Looki= ng at my local emacs-29 branch it seems also this patch been "forgotten" and= not been applied.
=
=
Do you have time t= o get this installed, Yuan?
Yes, of course, m= y apologies :-) Also, beautiful commit message, Jostein, I love it :-)

=
Yuan

I see bug marked as done, but I don't see this pushed to the emacs-= 29 branch.
Are you sure this has been ins= talled Yuan?
<= br>
--
Jostein
Indeed, I forgot to push my local branch. I just did that. Now you s= hould see it, sorry for the inconvenience :-)

Yuan

= --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4 Content-Type: image/x-icon; name=favicon.ico; x-apple-part-url=4B42ACF3-7848-454B-AC9D-DCADE7C79FB1 Content-Disposition: inline; filename=favicon.ico Content-Transfer-Encoding: base64 Content-Id: <4B42ACF3-7848-454B-AC9D-DCADE7C79FB1> iVBORw0KGgoAAAANSUhEUgAAACwAAAApCAYAAABOScuyAAAABmJLR0QA/wD/AP+gvaeTAAAACXBI WXMAAAsRAAALEQF/ZF+RAAAAB3RJTUUH0wMaCzkPshR2wAAADGdJREFUeJzNmHlwXNWVh7/7ln69 t9SSWou1y5ItLxgZjIOx2SKEgXEMYSkSAoGCZFgCGcKQkKpQhAzbzNTAQIAakskAs8AEpgaowixh K2OICWACeMe2Fmuztu5Wq9e33flDtrw1IV5SNb+/pPvePed7551z3rmt8v9QC+cu7YxFSstGE6ND h15TvmrzGYuWLnn8H36p/2XQiitSUb5hKpd666+/d+P3j2jjrFDF5c3Ruv+WUs6TUmp/Ib6iap7V 9Ps5zW3O/ff//TUHrn9phFuqW1faeevfHvrNE2uA7wgh7CNx2LV8ybltTbPWLD/tzH++/fZn/atW rTph3ryub7W1LVty/fU/8XzVftWWGwuTGeW9d9Y+nM068/eti2I3d5zYEduzpXdTrKay+9OerQ5w qRDisHwCWLFixayBgT1zq6rqMvl8YqAmQsPcGu3vykLKWR5NsGHbOB98ms9ZOD6hCqQARdVygWDo Xwp2yb3d3e9PFLNbG571pJPJXK0HvTz85K9ev/CiVecLIdyiER7ZNfKANJ2Krm+sigGfHAo7d+68 uqb69vua65t29e3sGcAy3xzu27G+RCR6T23V11WXqmfpKvSPZPjdu0O4Qvo8Xg8ejwfDY6Crqs/M ZW81xMTA6ctW3HSo/87Ozkghl7lIOi5O3uLVF186GTgZiqTEgvb5c91s9iqAiqpyDdi679qFF17o b6hruCc/lflCkfmfYrvNuqYTDWpcdmY5F5xapXo9igCITxV48e0+NMWDk7fIDibIDCYoJNJI2wXA NAvegd39j67sXPnaohPOLt3n57OPPvuuarkRAMey2bFthx84H+CwQkoMJm6VjqMKBCNDox4gCXDS oo4TP/nwk2d0VWl3TJt8Oo2iqqgeWHpyBbFSY8bG1p4km7enyOcVPLoHK52fviAldrqAnTHxhL3o IR9CwvbNW871GN7+5qbZj2fiU4qas6509xlzJSq4wNzDgO+66y7tVw88erGLpIDNC799vixTyF7R Mqvp+vjYxHLVlqIwmcHOFFA0Fce1qa+MkMs7+3jY1BNnw8YErWUxBjUTIQ55iYoAV2JO5rDShel9 jksGGQBuVxC4B++goaUlD+QPA37ppVeaXNMqU1Hwo5BLTWlr/ueF82XeRroSp2Dt9+sRLGmtJWfZ VJX5KFgOG7sT7NiZoT1WhU/XURwX27EO9u7KmT+lsx9NKV7/SCRdq1cmgb7DgJFWBfKAfwsOViF7 mBGhQkdzJSGvgSlMPB6FdZ+MoRd8zK+snrkv6NeZmNibDkJMv4IjVF1bU+Gib140CaydfrAD1NDY uVnoyp/st4oqWNBSCQJcKQmHdN75YJSwG8Z2XPriSYaSKTIFk1DAgyv2RvEoYB0hufOBe/p1Xe8D 1kGRPjyvZc4tqaGJh+yceVgHkUB1dZD5tZWo082AkUyKCn8IRew3NZ7OEs9ksByXTL5AJmNj2Q62 6xIIahh+hbrWBfkLVl0cL+RMOdC7y9i5dYd3y8bN/mw6o+geXba0teYvvfqK8R/+6JYR4DYhxLtF gQHW/37999569c0733t7bemOrdt8mVRajUbLHb+eV+fVxmYC5kgXgUBVBDnTQldVNHX/c6YLBfrj SUCSlSaBkEJjVYiyiBdNFRihinSwrPGDhrkrPr7qmu+mHcdtHRsbX1BeHlU8Ho/FdN7+7zmnn732 zXXvDD/yyOtq8UwHpJQxYBXwtXzemj+VSviv7jzrBL+uCj1SwtDQEBoQNAymCgUs3UM4GMLNZVAd G0PTsRwHiUQRCpXVOqaaY15T9KC3AVCwHKZM7+6hieyTY4XIM6+89mYKiK9YsSIaVtI3o3g/X7y4 Xd3eMzL2pcCH6vHHn5z1r7+8578CvvAZp5x2ChtefwPLdtBUhRKfj6RlM+Ia3HDt5fzhd6/SvaOH jGlRU1qCi8OyJVF6x1KYpsuchghBX/EBMGc6TObUzabt2NFo6QnRkoBVFauw3t4wOLi866oH1T8F +eBD/6gY9vg5f7Ws8V5r7KPHwj5ntqKUku7ppcznJRrwU+Lz4dU1Ij4vsxtq8Wk6NWVlZE2bfC6H ZVvMbQtRU+VlKGGyszfJxxvjpNIm4aCO33two9JVhaCXWGlIq3JcKSbik+oHnw9oWqhO3HDTD2RR 4EsvvdSQVuZKObHpPxfWGz+KhtQFhq7ovXvSkNXwcnjFCymZmJwECbsHhxkbHsbj81FVpbGgLYzQ dDbtihMIaJQGDUZHTPr7cwyP5VAUEAp4dAWxN10c1+WP20foHy8456y+Zvhnd93bGwz6vxA3fv+6 y1IjW1aPjiVmq5qw/N5wvDJsfq0mqlV4PdPPI4HReJbPv0gSU6IzRg+VBOLpDAXLImOZNDcHOLE9 iq6p6P4QL6/dzrKO2WzY1EPEqzA2bpGedMFluliFRPMIVK+Lowq54uurJ278m58ORctjceDXwPPa xJ5dHwa8+iMXn7uwMug3yKbGmZqcxN37RcrmbfbEswyOZbBzCiL45WkvgJKAD3wqTY2llISmx95w SQnvfzZAx5wqvn7aQkaTeTZu2UldZZCFc/2kMhaTaRPpAr4ys+PUrvi3r7pubFZtXQZ4GXhCCDG+ zwc//9kdZ4z1rH9lfM+oP50yUVUIGBqWLUlMmuQLLmG/jlUQ1ETCRWEtxyFjmsxqVGmpD82se30G H21LYKgOJ8xrZknHPDZt7+X5l9/H79UoWA6m5VISa8nd8fNHejsWL8wKIUaANcALQojhQ4MCwOuv vHzSx+vfeO6NNa80ipylRDwBbMclZ5v4g4JwRCWdVWXE9RYNsSslpp6ltjJATc305GY7Lt17Mkwk s1zYuYgN2yeYVVlKScjgxdc/oLzEi+NIhBBMZUy81af0P/X0v59nGMZWIcShM9DBwABSytLh4dGb N376h2+tf/eN8r6+Hm8kHLEraprzZ59z/uSWTz4NrP2PX9cWM+RIl3CZpKHRi6YqmLbL7pEpVEUh VuqjfU4TA+N5Pvysm5b6GDu7+1jUUoYrQdcUpJRs6JHOdbfe+9uurs4rvwz4oJ4ihEgAv5BSPtx1 3qqTgOVAA9Mzcfebr702JaV8+tCiy1oWlfWCptrAzJpHU5g9KwKA4TXoHkxieHRCAYOx8QkqSnx4 9AOblGBenSZOPLGjBVgMfFwMuOgRSQgxKYR4WwjxCyHEtUKI24QQj+3czXO2UAoH3islVNZBRZln plD32wEpFOrra+kbShAKeGlvrkQ6JhUl3pn9fXtSDOfDmcYl3xj0eBTJ3lGymI7o6P70U3fnr1h+ 6nqswpkHQu0ZdAiFnMO+XkIIxlMOi4NhEqk848ksAwNDNFeH0TWFvNStugWdY5f/+PKJ2vrWArAR eA3IHBdgAE3R3pLsBwYIhhTK90bsQCmqyp6xBKPxNLlclkQySXlYJ+caZvuyS0ZWfvO6McPwjQPP A2sO7QjHBThhOu9GOLhav2zUHRqdYiqT56PPviDoVUgk0+7iVd8ZXnX5D0Z9Pv8w8DTwohDC/HP9 /9nDzz5VV8fE6bU1o4ailO9b00sLtM8+uD8n0wW29iXwGdMxKa+Znb7+b+/vm9O+KMn0V+vZIwHd pyOO8PDwqIxXeHZV+2IzwAXn4ENKPFVgc08cn1ejtrrcPu/bP+k7vXN1EvgUuEcI0Xukfo8aGEDx WZ/nLXupV5/enksJNm2ewghKWhvCRMMGybRJY0Nd4Yd3/2ZnVV3rCHD3vlPDseiogCMiMum4+/u6 xzFwsyp9I2lSuTHqKoNUlHg597Kb+6vqWncCtwghdh8r7FED53LuBbqQbB0eQUqoioSIBvwEDQ9D owlCAR3NCNhnnL1yCnjweMEeNfBkIfmuT5S2t1XGUBWB5bh8PjiMZds0NwXYNZiS9z363A5/IDQB fHi8YI8a+JKu/E3vfRFb3r2tbz5AwXbwqIKqWADDq7Ds3MtGT1m6LA3cLITIH0/gr/wFvphueSTt LD21fvGZq7vexyeZ01BGNKYRiaqU1cxO33rHfYPAM0KIbccTFo4SGOC2u541S4P9K31hY3QoO0Gs 3Esub3PtzXf2G4b3j8Bjx5FzRkcNDPDje99IP/HUM40+v9+xpYY/4GfdurUh4J+EENZXGjgKHRMw wBWXnNNYEgmrc2bX4Q1EZFtbWw7oOA5sRXXMwDUVgRuEIN/eUoMiFNHbs8sD9B47WnEdM3AiNfls c32ld3gsSWXUh5VPG0DdcWArqv8DBUwmzpVc+KIAAAAASUVORK5CYII= --Apple-Mail-1A66813C-6E18-4782-829B-E680C6AFFEE4-- --Apple-Mail-EC01708F-6A46-4DB6-A0D5-76B3EB7897FD-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 17:34:16 2022 Received: (at 59897) by debbugs.gnu.org; 14 Dec 2022 22:34:16 +0000 Received: from localhost ([127.0.0.1]:41968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5aKO-0001Yd-BQ for submit@debbugs.gnu.org; Wed, 14 Dec 2022 17:34:16 -0500 Received: from mail-pg1-f175.google.com ([209.85.215.175]:36768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5aKK-0001YR-Ab; Wed, 14 Dec 2022 17:34:14 -0500 Received: by mail-pg1-f175.google.com with SMTP id s196so2978315pgs.3; Wed, 14 Dec 2022 14:34:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7avqEnwQnYDiOprPgNko18mMNv6EvDsUfFjjlJO86V8=; b=fkjHH6FBG8V2AOFci0k4UmVqoI+8y1r8amP0BBwn30N862PLBFk/FF94hKANbQrPhZ O/3mmcG9xx+WShgTny6KVUkpMohgQW9uZ6H/bvWgIXUxCaDzn3hlX7KqPjaCPNcaBUiJ 2xFplxFZp1UwPAzse3fDD3ScbPVi1ZuaWKpNXwBDLKnc9oyvkAT04AyIc41u/mlbKUGn S9vB5junnbyIRkD+lZ0dm6u90+pj3K70oBjbXeSgt510/mgQJn4Gj6uMzEECHx2XnCaM vvG2YMdcJzCYRf0ps33mdC7Gxc0945h9WNJ1NtXw97rb8XOZJLmIq1/LvBJL1MUky7GB z8lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7avqEnwQnYDiOprPgNko18mMNv6EvDsUfFjjlJO86V8=; b=XjIlKn8wDQiOiICuDDro/UFxMjQQeBkCWDH7t9QXOxJMLHmahu51GOssYtpTcR/c5o PxmDnNzYabqPRi+R3rkZSj8MA7FjvKTdSrl5N2ck7AuhpO7I81ThFfsuzP5iImVWTx01 JJ2+5EOhrloNMXs0j0G5qjXoJ6ppW3r4mryOAtiegJ/IuNQHAKkSfBjcFdRcOYSWwKQb 7W+JKbkED4kd/Z9U0Q3PVvMsWgKeQHo88ctWfZYuXejtlvyOtIWVzmGU6ygAPxKPm9km 8FAC3jzbs2yVLITjAmk0j1SSuKJeyV5rWk9foFPyfl3MZQJvKRYOxzh7UxhZVmMmCEX3 /1Ig== X-Gm-Message-State: ANoB5plp36ABCDUyTRSaUtp/v01UYflMJZKLzASDEDzDo4S31YmGBC6U ec2LTx+BDOjeDh/DvLbXUEw= X-Google-Smtp-Source: AA0mqf6FQdYUhgBGVS0Jx+ELL8h9UNr4UyX7WnplZ9b/CD69WSWbGU5scIILIZla38AmpQvRSrAVMQ== X-Received: by 2002:aa7:8147:0:b0:56e:9868:52fc with SMTP id d7-20020aa78147000000b0056e986852fcmr23527677pfn.25.1671057246261; Wed, 14 Dec 2022 14:34:06 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z3-20020aa79483000000b0056d73ef41fdsm355992pfk.75.2022.12.14.14.34.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 14:34:05 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59897: 29.0.60; csharp-ts-mode: variable-name fontified as method when invoking method with generic type-argument. From: Yuan Fu In-Reply-To: Date: Wed, 14 Dec 2022 14:34:04 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <25CBAC04-CD42-4C36-A331-653021DEBA0F@gmail.com> References: To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59897 Cc: Theodor Thornhill , Eli Zaretskii , jostein@kjonigsen.net, 59897@debbugs.gnu.org, 59897-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 14, 2022, at 1:45 PM, Jostein Kj=C3=B8nigsen = wrote: >=20 > Hey Yuan.=20 >=20 > =46rom what I can see you pushed Teos patch and not mine? >=20 > = https://git.savannah.gnu.org/cgit/emacs.git/commit/?h=3Demacs-29&id=3D647b= 6a8099f414e5a7b162efd3658e174064dfe7emacs.git - Emacs source repository > savannah.gnu.org > >=20 >=20 > In the email discussion earlier we unanymously decided on that for = technical reasons my patch was more appropriate for this particular bug, = and it also fixed another fontification bug.=20 >=20 > What do we do now? Should we revert this commit and apply mine = instead? >=20 > Sorry for all the =E2=80=9Cnoise=E2=80=9D, but this gets hard to = follow up for all of us when latency between input and output gets too = long, and then we end up writing emails like this, instead of writing = good code to improve emacs and our new major-modes.=20 >=20 > If this could get cleaned up, installed properly, confirmed -and- = pushed at the same time, it would be easier for me to verify that the = right patch was put in place, and then I wouldn=E2=80=99t nag you for = weeks end for what is really just 4 lines of code ;) Ahhhhh sorry! I reverted the old commit and applied yours, you should = now see it. I=E2=80=99ll try to process these patches more promptly in = the future. Yuan= From unknown Fri Aug 15 20:24:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Jan 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator