GNU bug report logs - #59878
[PATCH] c++-ts-mode: Highlight nullptr as a constant

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59878 in the body.
You can then email your comments to 59878 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] c++-ts-mode: Highlight nullptr as a constant
Date: Wed, 07 Dec 2022 10:16:18 +0000

[Message part 1 (text/plain, inline)]

Tags: patch





In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: 80df980e4100297942775eae4f89c5ccabe03afc
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 23.05 (Stoat)

Configured using:
 'configure
 --prefix=/nix/store/yc2vgl7zmby1dawpra4x92cfxlrvhrx1-emacs-git-20221206.0
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-native-compilation'

[0001-c-ts-mode-Highlight-nullptr-as-a-constant.patch (text/patch, attachment)]

Message #8 received at 59878 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Brian Leung <leungbk <at> posteo.net>
Cc: 59878 <at> debbugs.gnu.org
Subject: Re: bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant
Date: Wed, 07 Dec 2022 13:56:04 +0100

Hi!

Brian Leung <leungbk <at> posteo.net> writes:
> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
> index 0c66b4959e0..6f1488917a6 100644
> --- a/lisp/progmodes/c-ts-mode.el
> +++ b/lisp/progmodes/c-ts-mode.el
> @@ -233,7 +233,8 @@ c-ts-mode--font-lock-settings
>       (false) @font-lock-constant-face
>       (null) @font-lock-constant-face
>       ,@(when (eq mode 'cpp)
> -         '((this) @font-lock-constant-face)))
> +         '((this) @font-lock-constant-face
> +           (nullptr) @font-lock-constant-face)))
>  
>     :language mode
>     :feature 'keyword

Thanks!  Yuan, Will you apply this change?

Theo

Message #11 received at 59878 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: leungbk <at> posteo.net, 59878 <at> debbugs.gnu.org
Subject: Re: bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant
Date: Wed, 7 Dec 2022 11:24:38 -0800

Theodor Thornhill <theo <at> thornhill.no> writes:

> Hi!
>
> Brian Leung <leungbk <at> posteo.net> writes:
>> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
>> index 0c66b4959e0..6f1488917a6 100644
>> --- a/lisp/progmodes/c-ts-mode.el
>> +++ b/lisp/progmodes/c-ts-mode.el
>> @@ -233,7 +233,8 @@ c-ts-mode--font-lock-settings
>>       (false) @font-lock-constant-face
>>       (null) @font-lock-constant-face
>>       ,@(when (eq mode 'cpp)
>> -         '((this) @font-lock-constant-face)))
>> +         '((this) @font-lock-constant-face
>> +           (nullptr) @font-lock-constant-face)))
>>  
>>     :language mode
>>     :feature 'keyword
>
> Thanks!  Yuan, Will you apply this change?

Applied, thanks!

Yuan

Message #16 received at 59878-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>, Theodor Thornhill <theo <at> thornhill.no>
Cc: leungbk <at> posteo.net, 59878-done <at> debbugs.gnu.org
Subject: Re: bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant
Date: Wed, 7 Dec 2022 16:19:39 -0800

Yuan Fu <casouri <at> gmail.com> writes:

> Applied, thanks!

I'm therefore also closing this bug.

Message #19 received at 59878-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: leungbk <at> posteo.net, 59878-done <at> debbugs.gnu.org,
 Theodor Thornhill <theo <at> thornhill.no>
Subject: Re: bug#59878: [PATCH] c++-ts-mode: Highlight nullptr as a constant
Date: Wed, 7 Dec 2022 16:43:29 -0800

> On Dec 7, 2022, at 4:19 PM, Stefan Kangas <stefankangas <at> gmail.com> wrote:
> 
> Yuan Fu <casouri <at> gmail.com> writes:
> 
>> Applied, thanks!
> 
> I'm therefore also closing this bug.

Ah I forgot to close this, thank you, as always.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.