GNU bug report logs - #59871
[PATCH] guix: packages: Add type hint comment to home-page record field.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59871 in the body.
You can then email your comments to 59871 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] guix: packages: Add type hint comment to home-page record
 field.
Date: Tue,  6 Dec 2022 23:57:09 -0600

* guix/packages.scm (package)[home-page]: Add type comment.
---
 guix/packages.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/packages.scm b/guix/packages.scm
index 8f119d9fa7..1708c35b3d 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -8,6 +8,7 @@
 ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Chris Marusich <cmmarusich <at> gmail.com>
 ;;; Copyright © 2022 Maxime Devos <maximedevos <at> telenet.be>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -609,7 +610,7 @@ (define-record-type* <package>
                (sanitize validate-texinfo))       ; one or two paragraphs
   (license package-license                        ; (list of) <license>
            (sanitize validate-license))
-  (home-page package-home-page)
+  (home-page package-home-page)                   ; string
   (supported-systems package-supported-systems    ; list of strings
                      (default %supported-systems))
 
-- 
2.38.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>, 59871 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: Re: [bug#59871] [PATCH] guix: packages: Add type hint comment to
 home-page record field.
Date: Mon, 19 Dec 2022 15:59:21 +0400

[Message part 1 (text/plain, inline)]

On 2022-12-06 23:57, jgart via Guix-patches via wrote:

> * guix/packages.scm (package)[home-page]: Add type comment.
> ---
>  guix/packages.scm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/guix/packages.scm b/guix/packages.scm
> index 8f119d9fa7..1708c35b3d 100644
> --- a/guix/packages.scm
> +++ b/guix/packages.scm
> @@ -8,6 +8,7 @@
>  ;;; Copyright © 2020, 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>  ;;; Copyright © 2021 Chris Marusich <cmmarusich <at> gmail.com>
>  ;;; Copyright © 2022 Maxime Devos <maximedevos <at> telenet.be>
> +;;; Copyright © 2022 jgart <jgart <at> dismail.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -609,7 +610,7 @@ (define-record-type* <package>
>                 (sanitize validate-texinfo))       ; one or two paragraphs
>    (license package-license                        ; (list of) <license>
>             (sanitize validate-license))
> -  (home-page package-home-page)
> +  (home-page package-home-page)                   ; string
>    (supported-systems package-supported-systems    ; list of strings
>                       (default %supported-systems))

Applied, thank you, pushed as 061609ee57.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.