GNU bug report logs - #59866
[PATCH 0/2] services: mpd: Refactor MPD service.

Previous Next

Full log

Message #95 received at 59866-done <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>, 59866-done <at> debbugs.gnu.org
Subject: Re: [PATCH v6 2/3] services: mpd: Refactor MPD service.
Date: Sun, 05 Feb 2023 07:11:08 +0100

Am Donnerstag, dem 02.02.2023 um 22:08 +0100 schrieb Liliana Marie
Prikler:
> Not a complete review yet, just some quick pointers.
> 
> Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal:
> > Refactor mpd-service-type to support additional mpd.conf directives
> > and move activation-service-extension into service constructor.
> > 
> > * gnu/services/audio.scm
> > (mpd-plugin, mpd-partition): New record.
> No need to break the line before the paren here.
> 
> > (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers
> > into a single procedure for alist interop.
> That's not a good docstring here.  I think 
>   (mpd-serialize-boolean): Delete variable.  Move logic into...
>   (mpd-serialize-field): ... this.
> explains what's going on better.
It actually didn't, because mpd-serialize-boolean wasn't deleted, but
aliased.

> > [...]
> >    #:use-module (srfi srfi-1)
> > +  #:use-module (srfi srfi-8)
> >    #:use-module (srfi srfi-26)
> We generally prefer SRFI 71.
I fixed up the above, plus some compiler warnings and pushed it.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.