GNU bug report logs - #59866
[PATCH 0/2] services: mpd: Refactor MPD service.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: mirai <at> makinata.eu
Subject: bug#59866: closed (Re: [PATCH v6 2/3] services: mpd: Refactor MPD
 service.)
Date: Sun, 05 Feb 2023 06:12:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#59866: [PATCH 0/2] services: mpd: Refactor MPD service.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 59866 <at> debbugs.gnu.org.

-- 
59866: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59866
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>, 59866-done <at> debbugs.gnu.org
Subject: Re: [PATCH v6 2/3] services: mpd: Refactor MPD service.
Date: Sun, 05 Feb 2023 07:11:08 +0100

Am Donnerstag, dem 02.02.2023 um 22:08 +0100 schrieb Liliana Marie
Prikler:
> Not a complete review yet, just some quick pointers.
> 
> Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal:
> > Refactor mpd-service-type to support additional mpd.conf directives
> > and move activation-service-extension into service constructor.
> > 
> > * gnu/services/audio.scm
> > (mpd-plugin, mpd-partition): New record.
> No need to break the line before the paren here.
> 
> > (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers
> > into a single procedure for alist interop.
> That's not a good docstring here.  I think 
>   (mpd-serialize-boolean): Delete variable.  Move logic into...
>   (mpd-serialize-field): ... this.
> explains what's going on better.
It actually didn't, because mpd-serialize-boolean wasn't deleted, but
aliased.

> > [...]
> >    #:use-module (srfi srfi-1)
> > +  #:use-module (srfi srfi-8)
> >    #:use-module (srfi srfi-26)
> We generally prefer SRFI 71.
I fixed up the above, plus some compiler warnings and pushed it.

Cheers

[Message part 3 (message/rfc822, inline)]

From: mirai <at> makinata.eu
To: guix-patches <at> gnu.org
Cc: mirai <at> makinata.eu
Subject: [PATCH 0/2] services: mpd: Refactor MPD service
Date: Tue,  6 Dec 2022 23:22:16 +0000

Modernizes and expands 'mpd-service-type'.
Performs "pretty-formatting" to the generated configuration file
at the cost of a few extra procedures.
It also deprecates some of the fields (abbreviated forms).

Bruno Victal (2):
  services: mpd: use 'define-configuration'.
  services: mpd: Refactor MPD service.

 doc/guix.texi          | 172 +++++++++++--
 gnu/services/audio.scm | 549 ++++++++++++++++++++++++++++++-----------
 2 files changed, 556 insertions(+), 165 deletions(-)


base-commit: b94724e8b2102be0fe9d19e9dfe44d6f7101bd4b
-- 
2.38.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.