GNU bug report logs - #59866
[PATCH 0/2] services: mpd: Refactor MPD service.

Previous Next

Package: guix-patches;

Reported by: mirai <at> makinata.eu

Date: Tue, 6 Dec 2022 23:24:01 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>, 59866 <at> debbugs.gnu.org
Subject: [bug#59866] [PATCH v6 2/3] services: mpd: Refactor MPD service.
Date: Thu, 02 Feb 2023 22:08:02 +0100

Not a complete review yet, just some quick pointers.

Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal:
> Refactor mpd-service-type to support additional mpd.conf directives
> and move activation-service-extension into service constructor.
> 
> * gnu/services/audio.scm
> (mpd-plugin, mpd-partition): New record.
No need to break the line before the paren here.

> (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers
> into a single procedure for alist interop.
That's not a good docstring here.  I think 
  (mpd-serialize-boolean): Delete variable.  Move logic into...
  (mpd-serialize-field): ... this.
explains what's going on better.

> [...]
>    #:use-module (srfi srfi-1)
> +  #:use-module (srfi srfi-8)
>    #:use-module (srfi srfi-26)
We generally prefer SRFI 71.


Cheers
This bug report was last modified 2 years and 105 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.