Subject: [bug#59866] [PATCH v6 2/3] services: mpd: Refactor MPD service.

From: Liliana Marie Prikler <[email-masked]>
Date: Thu, 02 Feb 2023 22:08:02 +0100

Not a complete review yet, just some quick pointers.

Am Donnerstag, dem 02.02.2023 um 20:07 +0000 schrieb Bruno Victal:
> Refactor mpd-service-type to support additional mpd.conf directives
> and move activation-service-extension into service constructor.
> 
> * gnu/services/audio.scm
> (mpd-plugin, mpd-partition): New record.
No need to break the line before the paren here.

> (mpd-serialize-boolean, mpd-serialize-field): Integrate serializers
> into a single procedure for alist interop.
That's not a good docstring here.  I think 
  (mpd-serialize-boolean): Delete variable.  Move logic into...
  (mpd-serialize-field): ... this.
explains what's going on better.

> [...]
>    #:use-module (srfi srfi-1)
> +  #:use-module (srfi srfi-8)
>    #:use-module (srfi srfi-26)
We generally prefer SRFI 71.

Cheers