Subject: Re: bug#59851: Add Moonlight

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 16 Jan 2023 10:59:59 -0500

Hi,

phodina <[email-masked]> writes:

> Hello,
>
> these patches add support for game streaming solution for Nvidia GameStream protocol. The client is open source. However, the games and the server is a non-libre application.
>
> ----
> Petr
>
>
>
>
> From 2034d229893bd6b96e66c588f235da36efc025b9 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <[email-masked]>
> Date: Sat, 3 Dec 2022 10:34:03 +0100
> Subject: [PATCH 3/6] gnu: Add h264bitstream.
>
> * gnu/packages/video.scm (h264bitstream): New variable.

[...]

> +      (build-system gnu-build-system)
> +      (arguments
> +       (list #:tests? #f ;no test suite
> +             #:phases #~(modify-phases %standard-phases
> +                          (add-after 'install 'fix-include-bs-h
> +                            (lambda* _

Replace lambda* with lambda.

> +                              (display "")

Remove this extraneous display call.

> +                              (symlink (string-append #$output
> +                                        "/include/h264bitstream/bs.h")
> +                                       (string-append #$output "/include/bs.h")))))))
> +      (native-inputs (list autoconf automake libtool pkg-config))
> +      (inputs (list ffmpeg))
> +      (synopsis "Library to read and write H.264 video bitstreams")
> +      (description
> +       "This package provides the code GameStream code shared between @code{Moonlight} clients.")

There's a typo above, with 'code' repeated twice.  Since Moonlight is a
proper noun, I'd leave out the @code decorator for it.

Otherwise, LGTM.

-- 
Thanks,
Maxim