Subject: Re: bug#59851: Add Moonlight

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 16 Jan 2023 10:04:28 -0500

Hello,

phodina <[email-masked]> writes:

> Hello,
>
> these patches add support for game streaming solution for Nvidia GameStream protocol. The client is open source. However, the games and the server is a non-libre application.
>
> ----
> Petr
>
>
> From 038069c5a4b7034ac2a33b822a84744419ecb3c6 Mon Sep 17 00:00:00 2001
> From: Petr Hodina <[email-masked]>
> Date: Sat, 3 Dec 2022 10:30:01 +0100
> Subject: [PATCH 1/6] gnu: Add qmdnsengine.
>
> * gnu/packages/qt.scm (qmdnsengine): New variable.
>
> diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
> index 0f5e1c3530..c095eae871 100644
> --- a/gnu/packages/qt.scm
> +++ b/gnu/packages/qt.scm
> @@ -123,6 +123,31 @@ (define-module (gnu packages qt)
>    #:use-module (gnu packages xml)
>    #:use-module (srfi srfi-1))
>  
> +(define-public qmdnsengine
> +  (let ((commit "b7a5a9f225d5e14b39f9fd1f905c4f505cf2ee99")
> +        (revision "1"))

Please mention why we use a commit, e.g. ";; No release or tags.  Use
the latest commit".

> +    (package
> +      (name "qmdnsengine")
> +      (version commit)
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/cgutman/qmdnsengine")
> +                      (commit version)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1f5v5n9w4aszcdjxmw81cwmd26ssywvfiyr8x0vbyamp4kqd8mww"))))
> +      (build-system cmake-build-system)
> +      (arguments
> +       '(#:configure-flags (list "-DBUILD_TESTS=ON")))
> +      (inputs (list qtbase-5))
> +      (synopsis "Multicast DNS library for Qt application")
> +      (description "This package provides multicast DNS library for Qt
> +  applications.")
> +      (home-page "https://github.com/moonlight-stream/moonlight-common-c")
> +      (license license:expat))))

Apart from the above, LGTM.

-- 
Thanks,
Maxim