GNU bug report logs - #59842
[PATCH] Make proced-update Preserve Refinements

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59842: closed ([PATCH] Make proced-update Preserve Refinements)
Date: Wed, 14 Dec 2022 14:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 14 Dec 2022 16:55:05 +0200
with message-id <83r0x2m3w6.fsf <at> gnu.org>
and subject line Re: bug#59842: [PATCH] Make proced-update Preserve Refinements
has caused the debbugs.gnu.org bug report #59842,
regarding [PATCH] Make proced-update Preserve Refinements
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59842: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59842
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Laurence Warne <laurencewarne <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Make proced-update Preserve Refinements
Date: Mon, 5 Dec 2022 20:26:26 +0000

[Message part 3 (text/plain, inline)]

Hi,

Currently proced-update will clear any active refinements in proced-buffers
(see proced-refine for information on refinements), which can be annoying
when proced-auto-update-flag is non-nil as this will result in you only
being able to see the refinement for a few seconds before the buffer
updates and you're back to all processes.  To reproduce this:

(require 'proced)
(setq-default proced-auto-update-flag t)
(setq-default proced-auto-update-interval 1)

M-x proced, then create a new refinement by <ENTER> on the PID of any
process.  You should see your refinement vanish after the next update.

The patch fixes aims to fix this by introducing a new buffer local variable
"proced-refinements" which stores information about the current
refinements, and is used by proced-update to further refine
proced-process-alist in the case it is non-nil.

proced-revert will get rid of any existing refinements (bound to "g"), so
the existing behaviour of refinements with proced-auto-update-flag set to
nil should stay the same.

Thanks, Laurence

[Message part 4 (text/html, inline)]

[0001-Make-proced-update-preserve-refinements.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 59842-done <at> debbugs.gnu.org
Subject: Re: bug#59842: [PATCH] Make proced-update Preserve Refinements
Date: Wed, 14 Dec 2022 16:55:05 +0200

> From: Laurence Warne <laurencewarne <at> gmail.com>
> Date: Thu, 8 Dec 2022 19:06:35 +0000
> Cc: 59842 <at> debbugs.gnu.org
> 
> If it's helpful, I've attached a (seperate) patch containing a test suite (or at least the start of) for proced.el
> (though some parts are somewhat awkward - mainly testing the proced buffer contains strings we would
> expect - of course comments on the approach welcome), the last test there: 'proced-refine-with-update-test'
> fails without the original patch.  I didn't want to conflate the original patch with it, I can open a new report with it
> if you prefer.

I installed both on the master branch, and modified the tests so that
they could be run on more systems.

I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.