GNU bug report logs - #59833
29.0.60; json-ts-mode fontifies everything as string

Previous Next

Package: emacs;

Reported by: jostein <at> kjonigsen.net

Date: Mon, 5 Dec 2022 10:41:01 UTC

Severity: normal

Found in version 29.0.60

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>, 59833 <at> debbugs.gnu.org, jostein <at> kjonigsen.net
Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string
Date: Mon, 05 Dec 2022 20:19:00 +0000
On Monday, December 5th, 2022 at 15:14, Theodor Thornhill <theo <at> thornhill.no> wrote:
> 
> 
> On 5 December 2022 20:57:55 CET, Yuan Fu casouri <at> gmail.com wrote:
> 
> > > On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors bug-gnu-emacs <at> gnu.org wrote:
> > > 
> > > On 5 December 2022 16:35:12 CET, Randy Taylor dev <at> rjt.dev wrote:
> > > 
> > > > On Monday, December 5th, 2022 at 10:03, Theodor Thornhill theo <at> thornhill.no wrote:
> > > > 
> > > > > Yeah js-json-mode is a lot simpler, and is imo too simple. The json-mode
> > > > > is not infact default in emacs, but there are two, one in melpa and one
> > > > > in elpa, IIRC.
> > > > > 
> > > > > Anyway, last patch for now - are you both satisfied with this one?
> > > > > 
> > > > > Theo
> > > > 
> > > > It's perfect! Sorry for all the trouble :D.
> > > 
> > > No problem :)
> > > 
> > > Yuan, will you commit this one?
> > 
> > Yeah. IIUC :override t is not necessary for pair, right? If so, I’ll apply the patch and remove the :override, is that OK?
> > 
> > Yuan
> 
> 
> Please test it first, but sure! We want it to not be string face at least :)
> 
> Theo

It's necessary, since string comes first and pair needs to override it (just tested).




This bug report was last modified 2 years and 227 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.