From unknown Tue Aug 19 00:30:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59833 <59833@debbugs.gnu.org> To: bug#59833 <59833@debbugs.gnu.org> Subject: Status: 29.0.60; json-ts-mode fontifies everything as string Reply-To: bug#59833 <59833@debbugs.gnu.org> Date: Tue, 19 Aug 2025 07:30:27 +0000 retitle 59833 29.0.60; json-ts-mode fontifies everything as string reassign 59833 emacs submitter 59833 jostein@kjonigsen.net severity 59833 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 05:40:47 2022 Received: (at submit) by debbugs.gnu.org; 5 Dec 2022 10:40:48 +0000 Received: from localhost ([127.0.0.1]:35203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28ty-0002jg-K7 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 05:40:47 -0500 Received: from lists.gnu.org ([209.51.188.17]:37734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p28tv-0002ja-K7 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 05:40:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p28tv-00056d-5t for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 05:40:43 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p28tr-0001dP-He for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 05:40:42 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1F12F5C0091; Mon, 5 Dec 2022 05:40:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Dec 2022 05:40:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670236836; x=1670323236; bh=bq 9p2DRLPkO+s2QmidEGC3YfVBA9vcUzrbuSaCMxns4=; b=iOu4+lKSnuCezqaUWf 6kEsVv6jod2appUTClvO5jlOG8LG19r6N3QebBXSmNdoVzAUF4sOpVXqV+ysSeVv cryUusflOucASn0AidXfEh6t4MjcFR3PEH/lMnqs7wOhgiur6p+lMHb47VsKYTVj vQjqLIYeYynvlHVTO4L9+tlMyOFNbKPX9jY2EUbyO8Psd/A3fA2n9IWdQyoUqKxK 40JwHWqril1CZRnerdbCJZifM+2WINvKUGVmGJbrYuVa2Yh34w2AuTfVeiBvNpfz ZI1huRg6FaUQMFLCEF7LsU1AdDMmMR1AQmB32+c5XpNNTlADioiExeEqv/ESym8B GyIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670236836; x=1670323236; bh=bq9p2DRLPkO+s2QmidEGC3YfVBA9vcUzrbu SaCMxns4=; b=daTaTnEgY+asGSQCqp1iw5UYB29Jsc9czvrDx7RsfcOyNtMKhtW rcKZclhzJdYZQ0VvlyzlxGyVlaDUEMy/TErb5pn/kOLrirXXLyEQ0u8Eg98Osleq ChcLkz5Xd5J3QFDV+42TtcwaD8SHVvycF097JO2nKnl953WQDZegziCSNEUTf8pV oXnMyakcBx4heFeWRIOGKGKB83H4RsGyXAn0BB9t/XrFXyLvgK7UD0JEOriL505j rc0+TKLbujA49bjUiVena/V4EGaB18AEBl11xaVhZtl1x6AzPPlemybrNKO8QRwY cCMO0vGMiXmw9uuT+zJHPLw6jPLZo/IjeRQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfvfhrhffusegrtderredtfeejnecuhfhrohhmpeflohhsthgvihhn ucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvg hnrdhnvghtqeenucggtffrrghtthgvrhhnpeetgedtveefvdduveffkeeiheelgeduffev teffheefieeftdeuuedvgeehvdekhfenucffohhmrghinhepkhhjnhhighhsvghnrdhnoh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhs thgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 05:40:35 -0500 (EST) Content-Type: multipart/alternative; boundary="------------OuswDx9TzL70xdESkeBJYHft" Message-ID: Date: Mon, 5 Dec 2022 11:40:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: nb-NO To: "bug-gnu-emacs@gnu.org" , Yuan Fu , Theodor Thornhill , Randy Taylor From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; json-ts-mode fontifies everything as string Received-SPF: pass client-ip=66.111.4.26; envelope-from=jostein@secure.kjonigsen.net; helo=out2-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------OuswDx9TzL70xdESkeBJYHft Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hey everyone. When opening a JSON-file in a build from emacs git emacs-29 release-branch, Emacs still defaults to json-mode. Fontification in json-mode looks correct and proper. When trying to insteas use json-ts-mode, literally everything is fontified as strings. When I change the code to disable the string-fontification rule, this yields a buffer where everything is fontified using default-face. That is, no other fontification is taking place. Have this mode really been tested? Should it be working? Or is there an error on my end? Could someone else please give json-ts-mode a try? -- Jostein In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2022-12-02 built on ThinkPad-T14s Repository revision: 1e36ad9458e8deacfc85da573bb0ca0f270d4802 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: JSON Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   lsp-diagnostics-mode: t   lsp-headerline-breadcrumb-mode: t   lsp-modeline-workspace-status-mode: t   lsp-modeline-diagnostics-mode: t   lsp-modeline-code-actions-mode: t   electric-pair-mode: t   lsp-completion-mode: t   editorconfig-mode: t   flycheck-mode: t   which-function-mode: t   nlinum-mode: t   company-mode: t   global-ede-mode: t   dap-tooltip-mode: t   dap-ui-many-windows-mode: t   dap-ui-controls-mode: t   dap-ui-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   dap-auto-configure-mode: t   dap-mode: t   global-undo-tree-mode: t   undo-tree-mode: t   doom-modeline-mode: t   projectile-mode: t   ido-yes-or-no-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   server-mode: t   shell-dirtrack-mode: t   global-hl-line-mode: t   lsp-managed-mode: t   lsp-mode: t   yas-global-mode: t   yas-minor-mode: t   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   auto-fill-function: yas--auto-fill   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t   hs-minor-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221127.2242/transient hides /home/jostein/build/emacs/lisp/transient /home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot Features: (shadow sort emacsbug help-fns radix-tree json-ts-mode dired-aux ede/dired mule-util vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view json-mode json-snatcher yaml-mode magit-patch goto-addr git-rebase magit-extras flyspell ispell magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 executable tabify misearch multi-isearch semantic/lex-spp ede/emacs semantic/db semantic/find semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local bug-reference helm-command helm-elisp helm-eval helm-info typescript-ts-mode js mail-extr lsp-diagnostics lsp-headerline lsp-icons lsp-modeline view vc-git diff-mode vc-dir vc vc-dispatcher disp-table elec-pair csharp-mode treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus face-remap add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug backtrace nlinum linum company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company-web-html company-web company-css web-completion-data company hideshow eww url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage eieio-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat gud derived dframe bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs ido-yes-or-no ido helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load files-x tramp-compat parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel cl-extra autorevert server powershell advice shell pcomplete hl-line lsp-mode lsp-protocol yasnippet help-mode xref project tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode color thingatpt noutline outline icons lv inline imenu ht filenotify f f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme compile-eslint compile text-property-search comint ansi-osc ansi-color ring cl finder-inf git-timemachine-autoloads rx helm-projectile-autoloads expand-region-autoloads all-the-icons-autoloads dracula-theme-autoloads eglot-autoloads multiple-cursors-autoloads tree-sitter-langs-autoloads projectile-autoloads nlinum-autoloads doom-modeline-autoloads rust-mode-autoloads editorconfig-autoloads helm-autoloads helm-core-autoloads async-autoloads assess-autoloads m-buffer-autoloads cargo-autoloads package-lint-autoloads flycheck-autoloads company-autoloads magit-autoloads magit-section-autoloads web-mode-autoloads paredit-autoloads helpful-autoloads elisp-refs-autoloads js2-mode-autoloads yaml-mode-autoloads powershell-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads lsp-mode-autoloads markdown-mode-autoloads ht-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads compat-autoloads pcache-autoloads f-autoloads popup-autoloads s-autoloads info dash-autoloads macrostep-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 893822 107292)  (symbols 48 58306 34)  (strings 32 224415 12766)  (string-bytes 1 7012327)  (vectors 16 134309)  (vector-slots 8 2366207 177230)  (floats 8 1129 896)  (intervals 56 32198 3519)  (buffers 992 63)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------OuswDx9TzL70xdESkeBJYHft Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hey everyone.

When opening a JSON-file in a build from emacs git emacs-29 release-branch, Emacs still defaults to json-mode.

Fontification in json-mode looks correct and proper.

When trying to insteas use json-ts-mode, literally everything is fontified as strings.

When I change the code to disable the string-fontification rule, this yields a buffer where everything is fontified using default-face. That is, no other fontification is taking place.

Have this mode really been tested? Should it be working? Or is there an error on my end?

Could someone else please give json-ts-mode a try?

--
Jostein


In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.34, cairo version 1.16.0) of 2022-12-02 built on ThinkPad-T14s
Repository revision: 1e36ad9458e8deacfc85da573bb0ca0f270d4802
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12201003
System Description: Ubuntu 22.10

Configured using:
 'configure --with-tree-sitter'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LC_MONETARY: nb_NO.UTF-8
  value of $LC_NUMERIC: nb_NO.UTF-8
  value of $LC_TIME: nb_NO.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: JSON

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  lsp-diagnostics-mode: t
  lsp-headerline-breadcrumb-mode: t
  lsp-modeline-workspace-status-mode: t
  lsp-modeline-diagnostics-mode: t
  lsp-modeline-code-actions-mode: t
  electric-pair-mode: t
  lsp-completion-mode: t
  editorconfig-mode: t
  flycheck-mode: t
  which-function-mode: t
  nlinum-mode: t
  company-mode: t
  global-ede-mode: t
  dap-tooltip-mode: t
  dap-ui-many-windows-mode: t
  dap-ui-controls-mode: t
  dap-ui-mode: t
  treemacs-filewatch-mode: t
  treemacs-follow-mode: t
  treemacs-git-mode: t
  treemacs-fringe-indicator-mode: t
  dap-auto-configure-mode: t
  dap-mode: t
  global-undo-tree-mode: t
  undo-tree-mode: t
  doom-modeline-mode: t
  projectile-mode: t
  ido-yes-or-no-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  delete-selection-mode: t
  global-auto-revert-mode: t
  server-mode: t
  shell-dirtrack-mode: t
  global-hl-line-mode: t
  lsp-managed-mode: t
  lsp-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  auto-fill-function: yas--auto-fill
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  hs-minor-mode: t

Load-path shadows:
/home/jostein/.emacs.d/elpa/transient-20221127.2242/transient hides /home/jostein/build/emacs/lisp/transient
/home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot

Features:
(shadow sort emacsbug help-fns radix-tree json-ts-mode dired-aux
ede/dired mule-util vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs
log-view json-mode json-snatcher yaml-mode magit-patch goto-addr
git-rebase magit-extras flyspell ispell magit-submodule magit-obsolete
magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull
magit-fetch magit-clone magit-remote magit-commit magit-sequence
magit-notes magit-worktree magit-tag magit-merge magit-branch
magit-reset magit-files magit-refs magit-status magit magit-repos
magit-apply magit-wip magit-log magit-diff smerge-mode git-commit
log-edit message sendmail yank-media rfc822 mml mml-sec epa mm-decode
mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums
mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert
magit-margin magit-transient magit-process with-editor magit-mode
transient magit-git magit-base magit-section crm compat-27 compat-26
executable tabify misearch multi-isearch semantic/lex-spp ede/emacs
semantic/db semantic/find semantic/util-modes semantic/util semantic
semantic/tag semantic/lex semantic/fw mode-local bug-reference
helm-command helm-elisp helm-eval helm-info typescript-ts-mode js
mail-extr lsp-diagnostics lsp-headerline lsp-icons lsp-modeline view
vc-git diff-mode vc-dir vc vc-dispatcher disp-table elec-pair
csharp-mode treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds
cc-styles cc-align cc-engine cc-vars cc-defs winner ffap tramp-archive
tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus face-remap
add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree
lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html
lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform
lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket
lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls
lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix
lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin
lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack
lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp
lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm
lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal
lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount
lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript
ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit
editorconfig editorconfig-core editorconfig-core-handle
editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug
backtrace nlinum linum company-oddmuse company-keywords company-etags
etags fileloop generator company-gtags company-dabbrev-code
company-dabbrev company-files company-clang company-capf company-cmake
company-semantic company-template company-bbdb company-web-html
company-web company-css web-completion-data company hideshow eww
url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader
gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede
ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar
speedbar ezimage eieio-custom cedet dap-mouse dap-ui lsp-treemacs
lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs
treemacs-header-line treemacs-compatibility treemacs-mode
treemacs-interface treemacs-persistence treemacs-filewatch-mode
treemacs-follow-mode treemacs-rendering treemacs-annotations
treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals
treemacs-fringe-indicator treemacs-scope pulse treemacs-faces
treemacs-icons treemacs-themes treemacs-core-utils pfuture
treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat
gud derived dframe bui bui-list bui-info bui-entry bui-core bui-history
bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node
dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks
dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue
doom-modeline doom-modeline-segments doom-modeline-env
doom-modeline-core all-the-icons all-the-icons-faces data-material
data-weathericons data-octicons data-fileicons data-faicons
data-alltheicons shrink-path compat compat-macs projectile lisp-mnt grep
ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint
org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version
org-compat org-macs ido-yes-or-no ido helm-mode helm-misc helm-files
image-dired image-dired-tags image-dired-external image-dired-util xdg
image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver
tramp-integration cus-edit pp cus-load files-x tramp-compat parse-time
iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate
helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm
helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode
async-bytecomp helm-source helm-multi-match helm-lib async helm-config
delsel cl-extra autorevert server powershell advice shell pcomplete
hl-line lsp-mode lsp-protocol yasnippet help-mode xref project
tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode
color thingatpt noutline outline icons lv inline imenu ht filenotify f
f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme
compile-eslint compile text-property-search comint ansi-osc ansi-color
ring cl finder-inf git-timemachine-autoloads rx
helm-projectile-autoloads expand-region-autoloads
all-the-icons-autoloads dracula-theme-autoloads eglot-autoloads
multiple-cursors-autoloads tree-sitter-langs-autoloads
projectile-autoloads nlinum-autoloads doom-modeline-autoloads
rust-mode-autoloads editorconfig-autoloads helm-autoloads
helm-core-autoloads async-autoloads assess-autoloads m-buffer-autoloads
cargo-autoloads package-lint-autoloads flycheck-autoloads
company-autoloads magit-autoloads magit-section-autoloads
web-mode-autoloads paredit-autoloads helpful-autoloads
elisp-refs-autoloads js2-mode-autoloads yaml-mode-autoloads
powershell-autoloads dap-mode-autoloads lsp-docker-autoloads
yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads
posframe-autoloads hydra-autoloads pfuture-autoloads
ace-window-autoloads avy-autoloads lsp-mode-autoloads
markdown-mode-autoloads ht-autoloads git-commit-autoloads
with-editor-autoloads transient-autoloads compat-autoloads
pcache-autoloads f-autoloads popup-autoloads s-autoloads info
dash-autoloads macrostep-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 893822 107292)
 (symbols 48 58306 34)
 (strings 32 224415 12766)
 (string-bytes 1 7012327)
 (vectors 16 134309)
 (vector-slots 8 2366207 177230)
 (floats 8 1129 896)
 (intervals 56 32198 3519)
 (buffers 992 63))

--
Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
--------------OuswDx9TzL70xdESkeBJYHft-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 06:24:14 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 11:24:14 +0000 Received: from localhost ([127.0.0.1]:35416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29a1-0003Ln-Lv for submit@debbugs.gnu.org; Mon, 05 Dec 2022 06:24:13 -0500 Received: from out2.migadu.com ([188.165.223.204]:33915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29Zw-0003Lf-Mp for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 06:24:12 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670239447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ilIofjA47gxewr/L81Fl5uMqS3UGBhUS34c6/p/4u58=; b=T0Efrcxe4OR3UIviUtDye8PwLQsRnPnH7/mtYYP3oQxXyTfomUaqSjUl7WqKH4W+V6Jo1k 25jcbX3i06rqszwJi9MoJcpFQuJ4q2ebEk6/55jL0sySGz33WRL82Wn1Fjn0zUNkKZDNhj WmwBRCrXpvNQQGGRdNTW3+peVaXApU97BZ4S4is04aGFnEj10grOt43i+WETFHzgJ/5QBe hoT9wcA+bZgQW/Bo4JYlExWIiYRasKE65eTK9RCjL8+vH9ncIF3XAxeA6sj1ny9y+yXrUk gtiEkR63mpWbsA7oZHe9ZWlnqJ+ck48wyLWn3YZkryYF1zMIIcLbAqAD/vcRTA== From: Theodor Thornhill To: 59833@debbugs.gnu.org Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: References: Date: Mon, 05 Dec 2022 12:24:05 +0100 Message-ID: <87sfhudrfu.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Hey everyone. > > When opening a JSON-file in a build from emacs git emacs-29=20 > release-branch, Emacs still defaults to json-mode. > > Fontification in json-mode looks correct and proper. > > When trying to insteas use json-ts-mode, literally everything is=20 > fontified as strings. > > When I change the code to disable the string-fontification rule, this=20 > yields a buffer where everything is fontified using default-face. That=20 > is, no other fontification is taking place. > > Have this mode really been tested? Should it be working? Or is there an=20 > error on my end? > > Could someone else please give json-ts-mode a try? > Yeah, you are correct. It seems we've had a regression in this commit, 0ed313642227afdeccf48057eea458edca9d2962. I believe this is the offending commit - what do you think, Randy? Specifically the lhs should be fontified differently than the rhs, so not everything is a string. Do you want to do that, Randy, or should I? Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 06:35:13 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 11:35:13 +0000 Received: from localhost ([127.0.0.1]:35486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29kf-0003fD-4z for submit@debbugs.gnu.org; Mon, 05 Dec 2022 06:35:13 -0500 Received: from out2.migadu.com ([188.165.223.204]:43285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29kd-0003f5-1Z for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 06:35:12 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670240110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4J42m4Ex4pzwmaCVJ9xfOGkGWXV5wnVy754sI/OciNY=; b=Gn43YrbqaMrNR9v6BS1M39jcxs4UebaVS/CiTn16qFOd23NbLZX8X08UBnFvdY+a/2mTqG fOwmg67TLFA0EhgHd4gh+bBpDAdodpKHv4IYDOf5kV3G7bLcorSIOyAKZiP9jbyhGLVqlH rvNPLlRB0pttE7gSwQgbH/IPs1ik1osdKeRKsQfjTs+QbKSbTtcsM7C6dnvT3cqXGdhy7T G5EBE4xOjamcuzaP9IEwAvpG4EmkN6t9yAfqxF4+1qAxsm5ChKZB5502m+7UQzwCCbdCYc KYex+Gr+9LRIDRGWWFDlVrSRxxO5eTQRerOLyUDmrW9Tp7w3Z57PPPyQcNDOUg== From: Theodor Thornhill To: 59833@debbugs.gnu.org Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: <87sfhudrfu.fsf@thornhill.no> References: <87sfhudrfu.fsf@thornhill.no> Date: Mon, 05 Dec 2022 12:35:08 +0100 Message-ID: <87o7sidqxf.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> Hey everyone. >> >> When opening a JSON-file in a build from emacs git emacs-29=20 >> release-branch, Emacs still defaults to json-mode. >> >> Fontification in json-mode looks correct and proper. >> >> When trying to insteas use json-ts-mode, literally everything is=20 >> fontified as strings. >> >> When I change the code to disable the string-fontification rule, this=20 >> yields a buffer where everything is fontified using default-face. That=20 >> is, no other fontification is taking place. >> >> Have this mode really been tested? Should it be working? Or is there an= =20 >> error on my end? >> >> Could someone else please give json-ts-mode a try? >> > > Yeah, you are correct. It seems we've had a regression in this commit, > 0ed313642227afdeccf48057eea458edca9d2962. > > I believe this is the offending commit - what do you think, Randy? > > Specifically the lhs should be fontified differently than the rhs, so > not everything is a string. > > Do you want to do that, Randy, or should I? > > Theo Can you test this patch, Jostein? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-back-in-font-locking-for-pair-in-json-ts-mode.patch >From 78068ae89d178e8aac126994c82df4a294440f44 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Mon, 5 Dec 2022 12:34:08 +0100 Subject: [PATCH] Add back in font-locking for pair in json-ts-mode * lisp/progmodes/json-ts-mode.el (json-ts-mode--font-lock-settings): Add back in removed pair font-lock code. (json-ts-mode): Use the new feature. --- lisp/progmodes/json-ts-mode.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/json-ts-mode.el b/lisp/progmodes/json-ts-mode.el index 101e873cf6..7ec59704dc 100644 --- a/lisp/progmodes/json-ts-mode.el +++ b/lisp/progmodes/json-ts-mode.el @@ -93,6 +93,10 @@ json-ts-mode--font-lock-settings :override t '((escape_sequence) @font-lock-escape-face) :language 'json + :feature 'pair + :override t + `((pair key: (_) @font-lock-variable-name-face)) + :language 'json :feature 'error :override t '((ERROR) @font-lock-warning-face)) @@ -156,7 +160,7 @@ json-ts-mode ;; Font-lock. (setq-local treesit-font-lock-settings json-ts-mode--font-lock-settings) (setq-local treesit-font-lock-feature-list - '((constant number string) + '((constant number string pair) (escape-sequence) (bracket delimiter error))) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 06:53:24 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 11:53:24 +0000 Received: from localhost ([127.0.0.1]:35569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2A2F-0003r5-Pq for submit@debbugs.gnu.org; Mon, 05 Dec 2022 06:53:24 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2A2A-0003qy-Jy for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 06:53:22 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 53CC65C00B2; Mon, 5 Dec 2022 06:53:08 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Dec 2022 06:53:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670241188; x=1670327588; bh=Fn Q6DsPLcgekIfodyj5d5Wl9ts6SGofiXgytOdKMVzI=; b=c/k4yR+ik3+njD+qxE lvWQyM5C0FCh1N0IFj8DLPDTLK8qMqaAtDqZCxkAlt6E24j/ZF4cbcXaHqDsW+7w xlezQB+2HFgQQ2/rVJb+d5ztVwBY6gqqbvda77a6zfL70yhKqJ8Y1mL3oYh/nkbB Ar7VtOcYlZ4Qz2y5/jcPED90wBVxD4/CENp0t/6RCTbFMciNJACoTJ45PPm3snU3 iZq5ghYSdD4t3IHLvbzxdQc2JbIRxnR5cXABNieMh5QjXiOqq/pXey5OMXWTHyoz dT5pOBfEsevjNlFB1v7gk/As/4dpr2LkP7WP3gVbUvqSqKaDmJIFgBZiH/AFv+tI Me1w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670241188; x=1670327588; bh=FnQ6DsPLcgekIfodyj5d5Wl9ts6SGofiXgy tOdKMVzI=; b=cMM7e/zQxJj5qiz+Mx4gB6YsHXBJNlPqdw6Zc2pCH2gxopsTour CuAXS/kTM2BnZn+/a+iAOi1Ov9ZmRudXsQCZlr50Bk+ZzTUYUUVrsFec6X1+ZlaR lJwpBR3Lcue+Drh+ANjAx+ahb4FQsKtI2U7kxXp7daZGl5IwZsVwYgA9fgja8nCS ATkVliWskSAeAlOU7YThF5RwD663YYWCVfMghly274mSCINP5lVATmbouY55WWol i48CvOvcuORxH6R/4lHLmjfj8esjEkyDjkMT5M8w0oBXUkcFnOVANghq0GnqY20x u/qIPhhzbQWhPx6uEGDdBlIPW1LeboEbNmw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeefgfevjeefveegleevffdt gfekfffhjeehgfevteffhfffkedtueejudehheenucffohhmrghinhepkhhjnhhighhsvg hnrdhnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 06:53:03 -0500 (EST) Message-ID: <07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net> Date: Mon, 5 Dec 2022 12:53:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Content-Language: nb-NO To: Theodor Thornhill , 59833@debbugs.gnu.org References: <87sfhudrfu.fsf@thornhill.no> <87o7sidqxf.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87o7sidqxf.fsf@thornhill.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Yeah. That works for me. I tried making a similar patch, but I guess I was trying to overspecify, rather than just shortcutting the selection. Nice job! -- Jostein jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 05.12.2022 12:35, Theodor Thornhill wrote: > Theodor Thornhill writes: > >> Jostein Kjønigsen writes: >> >>> Hey everyone. >>> >>> When opening a JSON-file in a build from emacs git emacs-29 >>> release-branch, Emacs still defaults to json-mode. >>> >>> Fontification in json-mode looks correct and proper. >>> >>> When trying to insteas use json-ts-mode, literally everything is >>> fontified as strings. >>> >>> When I change the code to disable the string-fontification rule, this >>> yields a buffer where everything is fontified using default-face. That >>> is, no other fontification is taking place. >>> >>> Have this mode really been tested? Should it be working? Or is there an >>> error on my end? >>> >>> Could someone else please give json-ts-mode a try? >>> >> Yeah, you are correct. It seems we've had a regression in this commit, >> 0ed313642227afdeccf48057eea458edca9d2962. >> >> I believe this is the offending commit - what do you think, Randy? >> >> Specifically the lhs should be fontified differently than the rhs, so >> not everything is a string. >> >> Do you want to do that, Randy, or should I? >> >> Theo > Can you test this patch, Jostein? > > Theo > From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 07:06:58 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 12:06:58 +0000 Received: from localhost ([127.0.0.1]:35632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2AFN-0006GT-Vd for submit@debbugs.gnu.org; Mon, 05 Dec 2022 07:06:58 -0500 Received: from out2.migadu.com ([188.165.223.204]:15278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2AFL-0006GL-EN for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 07:06:56 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670242014; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6DS24EGFYX6y/hsZ6mSZilnuZwTiDw8hapTXqcVwmDM=; b=kkrvRhmV/LEfawEKw9KJgo9Os64vKrt3FNFWVxu2QQe1FEmv03NWFrmuQAV6di1meo6rNA oB6o0wQVnJtD5jt24Qzx8/6l7hS3Dinsd+mTiRquTSkFvmNMgMfWEUEcLq4c6Q185RkpFE IJ61aEXjE8QSBlQkVfZ+qlHbdjphCAO1qMQXeZWzIHzs724TmDGwhIHIPOs8OmRfsEGcs3 JhCew2Y9aOE9oyyccyzgIlrItaWcuChwrVeB4+sdxf51IhHYc0YvQ+czf9AdXU9ZHyAAhI FqZqt+WRJwc2ZCxDwubsIOKrfuqLwD6aXs4VkH5F2xWyYznCR3RA8r7G69EX/w== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , 59833@debbugs.gnu.org Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: <07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net> References: <87sfhudrfu.fsf@thornhill.no> <87o7sidqxf.fsf@thornhill.no> <07c73653-2983-519a-ea8b-8d955690304f@secure.kjonigsen.net> Date: Mon, 05 Dec 2022 13:06:53 +0100 Message-ID: <87fsdudpgi.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Yeah. That works for me. > > I tried making a similar patch, but I guess I was trying to overspecify,= =20 > rather than just shortcutting the selection. Nice job! > Great! Yuan, Eli - can one of you apply for me? :-) Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 08:52:23 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 13:52:23 +0000 Received: from localhost ([127.0.0.1]:36139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BtP-00018C-Gv for submit@debbugs.gnu.org; Mon, 05 Dec 2022 08:52:23 -0500 Received: from mail-40136.proton.ch ([185.70.40.136]:30109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BtN-000186-5C for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 08:52:22 -0500 Date: Mon, 05 Dec 2022 13:52:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670248333; x=1670507533; bh=4trHv5Zm96d03aaYsGZOZTVTz37fN//Mwhl9UbdMXh4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=FdWckVszvmNSDt9FAI72GsEsm1WEGY3Tca0KjHs4rsh1FaZPoRr2oFw5rQjJl0JVB TcDWhyO50mxYBQdAdLF4qv7Ezh+dd3P1f/4jRgWDq9nLh36KyibKTH7NyutXg+ub8s 2aqmj7ShMMdqIHrBnY8wq7bKRRqDN39+f1Vxu8UHUzX9LC+BdyStRdSzpckwTq2qpl GClpFTU21/+Xe+VFsZzfbN6O49rzeiGorFLa9Cna3V7JvjTb0VewXUYyG9xHHqyVRN bEUh0CEoCYLDaaA3Pfm9NE+VaF0HKHA3ZjhPzYSNZI82EMxBlapHzudNHnslNYNLdD 8agXOEgPKJLhQ== To: Theodor Thornhill From: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Message-ID: <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> In-Reply-To: <87sfhudrfu.fsf@thornhill.no> References: <87sfhudrfu.fsf@thornhill.no> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 06:24, Theodor Thornhill wrote: >=20 >=20 > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: >=20 > > Hey everyone. > >=20 > > When opening a JSON-file in a build from emacs git emacs-29 > > release-branch, Emacs still defaults to json-mode. > >=20 > > Fontification in json-mode looks correct and proper. > >=20 > > When trying to insteas use json-ts-mode, literally everything is > > fontified as strings. > >=20 > > When I change the code to disable the string-fontification rule, this > > yields a buffer where everything is fontified using default-face. That > > is, no other fontification is taking place. > >=20 > > Have this mode really been tested? Should it be working? Or is there an > > error on my end? > >=20 > > Could someone else please give json-ts-mode a try? >=20 >=20 > Yeah, you are correct. It seems we've had a regression in this commit, > 0ed313642227afdeccf48057eea458edca9d2962. >=20 > I believe this is the offending commit - what do you think, Randy? >=20 > Specifically the lhs should be fontified differently than the rhs, so > not everything is a string. >=20 > Do you want to do that, Randy, or should I? >=20 > Theo Can someone show me an example JSON file that shows this problem? Everythin= g looks the same for me in json-mode and json-ts-mode, except for the json-= ts-mode extras (even with Theo's patch) both with my own Emacs config and e= macs -Q. I must be doing something very silly. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 08:58:46 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 13:58:46 +0000 Received: from localhost ([127.0.0.1]:36175 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Bza-0001B2-6l for submit@debbugs.gnu.org; Mon, 05 Dec 2022 08:58:46 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:31497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2BzY-0001Av-Kz for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 08:58:45 -0500 Date: Mon, 05 Dec 2022 13:58:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670248718; x=1670507918; bh=1tUdfNEIpud5SqFFoQ6FqZ8fcmVBWdvoGMU8Exl6poA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=T7hoVgsWNUArK1CU9cZu2tdj2Fekt+/ujcoJFbY9h3aQz2ZLUKkvvNylVxDwwAlGt lDKv5z5o1BZZLEjwnkoZfdv34mxZGkfXYmiyXEa98nYfQbiIPNpFMCyXw0dpq+LRI8 Ro9epIjilamCFLkB6KT5HRNh7qw6UqgJL6/VqS01E7AT1rM6AE7U/M4JeMSBOAXt0D bebmwWaZ4jywqCivb/C2I6H0LgXZ7qY1DDYijff4/4MjyBzn7pGlpB3FjuWxxKS0Wn GobsLsAaklOu7Q6j+upgf+o5nbU8ivbGSGkdRMPiNnA+4lMEPXf8HdActWJ77w5qoj bV/YOUue/Lkyg== To: Theodor Thornhill From: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Message-ID: <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> In-Reply-To: <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 08:52, Randy Taylor wrote: >=20 > On Monday, December 5th, 2022 at 06:24, Theodor Thornhill theo@thornhill.= no wrote: >=20 > > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: > >=20 > > > Hey everyone. > > >=20 > > > When opening a JSON-file in a build from emacs git emacs-29 > > > release-branch, Emacs still defaults to json-mode. > > >=20 > > > Fontification in json-mode looks correct and proper. > > >=20 > > > When trying to insteas use json-ts-mode, literally everything is > > > fontified as strings. > > >=20 > > > When I change the code to disable the string-fontification rule, this > > > yields a buffer where everything is fontified using default-face. Tha= t > > > is, no other fontification is taking place. > > >=20 > > > Have this mode really been tested? Should it be working? Or is there = an > > > error on my end? > > >=20 > > > Could someone else please give json-ts-mode a try? > >=20 > > Yeah, you are correct. It seems we've had a regression in this commit, > > 0ed313642227afdeccf48057eea458edca9d2962. > >=20 > > I believe this is the offending commit - what do you think, Randy? > >=20 > > Specifically the lhs should be fontified differently than the rhs, so > > not everything is a string. > >=20 > > Do you want to do that, Randy, or should I? > >=20 > > Theo >=20 >=20 > Can someone show me an example JSON file that shows this problem? Everyth= ing looks the same for me in json-mode and json-ts-mode, except for the jso= n-ts-mode extras (even with Theo's patch) both with my own Emacs config and= emacs -Q. I must be doing something very silly. Scratch that, I got Theo's patch working, needed to rebuild. Looks good to = me (although it would be nice to keep treesit-font-lock-feature-list alphab= etized Theo ;)). json-mode still fontifies pretty much everything as a string though (at lea= st for me). From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 09:12:54 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 14:12:54 +0000 Received: from localhost ([127.0.0.1]:36240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CDF-0001Iy-O5 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 09:12:54 -0500 Received: from out2.migadu.com ([188.165.223.204]:22157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CDB-0001Ir-Qs for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 09:12:52 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670249568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zqo2tddyBPFn2eATg/8YloGwGNLSwhtZJ1+vwP0D0WU=; b=x+82siGDN9ZNEf1nshuX4pJNindL90Kf+bYTw0plYmJhi8zoRMpcmDzHy0Xi4Gp9RA5dHq 2vlOvBxP1+OxNVJH5id+D6vgX7Q0AwfE10yx4SDyRrOszjgXoZIRgvWsdmAxlQQL1LpfFi B+OS2fC6ZUBpGM85NLerk+1vuMS+oHorB4gzBEO+UTi76xc71vWILHwQI5ZPUmE5um4zOT shXSVSzZnd9Jx9nL9x8S8jTI0KyOKmS95pSISzJ5ztkp27mRrWgTkIkLasfKj0pmeBjbJP nHyaf7WUgXa4ddCDzEnb5xEYr+lhzdv3LhcEu7L6Kr1HBt7gCUsISwb4HXgA0Q== From: Theodor Thornhill To: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> Date: Mon, 05 Dec 2022 15:12:46 +0100 Message-ID: <87sfhuvt0h.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Randy Taylor writes: > On Monday, December 5th, 2022 at 08:52, Randy Taylor wrote: >>=20 >> On Monday, December 5th, 2022 at 06:24, Theodor Thornhill theo@thornhill= .no wrote: >>=20 >> > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: >> >=20 >> > > Hey everyone. >> > >=20 >> > > When opening a JSON-file in a build from emacs git emacs-29 >> > > release-branch, Emacs still defaults to json-mode. >> > >=20 >> > > Fontification in json-mode looks correct and proper. >> > >=20 >> > > When trying to insteas use json-ts-mode, literally everything is >> > > fontified as strings. >> > >=20 >> > > When I change the code to disable the string-fontification rule, this >> > > yields a buffer where everything is fontified using default-face. Th= at >> > > is, no other fontification is taking place. >> > >=20 >> > > Have this mode really been tested? Should it be working? Or is there= an >> > > error on my end? >> > >=20 >> > > Could someone else please give json-ts-mode a try? >> >=20 >> > Yeah, you are correct. It seems we've had a regression in this commit, >> > 0ed313642227afdeccf48057eea458edca9d2962. >> >=20 >> > I believe this is the offending commit - what do you think, Randy? >> >=20 >> > Specifically the lhs should be fontified differently than the rhs, so >> > not everything is a string. >> >=20 >> > Do you want to do that, Randy, or should I? >> >=20 >> > Theo >>=20 >>=20 >> Can someone show me an example JSON file that shows this problem? Everyt= hing looks the same for me in json-mode and json-ts-mode, except for the js= on-ts-mode extras (even with Theo's patch) both with my own Emacs config an= d emacs -Q. I must be doing something very silly. > > Scratch that, I got Theo's patch working, needed to rebuild. No need to rebuild. Just C-M-x the defvar and revert buffer. > Looks good to me (although it would be nice to keep treesit-font-lock-fea= ture-list alphabetized Theo ;)). > See new patch! > json-mode still fontifies pretty much everything as a string though (at l= east for me). Not for me. I get number-face, bracket-face, constant-face, warning-face. Don't you? Will you commit this, Yuan? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-back-in-font-locking-for-pair-in-json-ts-mode.patch >From 60b9dfeaec8d194c0b162f3eaa4ae4a4736d68e9 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Mon, 5 Dec 2022 12:34:08 +0100 Subject: [PATCH] Add back in font-locking for pair in json-ts-mode * lisp/progmodes/json-ts-mode.el (json-ts-mode--font-lock-settings): Add back in removed pair font-lock code. Also alphabetize features. (json-ts-mode): Use the new feature. (bug#59833) --- lisp/progmodes/json-ts-mode.el | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/lisp/progmodes/json-ts-mode.el b/lisp/progmodes/json-ts-mode.el index 101e873cf6..0ce820bafb 100644 --- a/lisp/progmodes/json-ts-mode.el +++ b/lisp/progmodes/json-ts-mode.el @@ -78,24 +78,30 @@ json-ts-mode--font-lock-settings '((["[" "]" "{" "}"]) @font-lock-bracket-face) :language 'json :feature 'constant + :override t '([(null) (true) (false)] @font-lock-constant-face) :language 'json :feature 'delimiter '((["," ":"]) @font-lock-delimiter-face) :language 'json - :feature 'number - '((number) @font-lock-number-face) - :language 'json - :feature 'string - '((string) @font-lock-string-face) + :feature 'error + :override t + '((ERROR) @font-lock-warning-face) :language 'json :feature 'escape-sequence :override t '((escape_sequence) @font-lock-escape-face) :language 'json - :feature 'error + :feature 'number :override t - '((ERROR) @font-lock-warning-face)) + '((number) @font-lock-number-face) + :language 'json + :feature 'pair + :override t + `((pair key: (_) @font-lock-variable-name-face)) + :language 'json + :feature 'string + '((string) @font-lock-string-face)) "Font-lock settings for JSON.") (defun json-ts-mode--imenu-1 (node) @@ -156,7 +162,7 @@ json-ts-mode ;; Font-lock. (setq-local treesit-font-lock-settings json-ts-mode--font-lock-settings) (setq-local treesit-font-lock-feature-list - '((constant number string) + '((constant number string pair) (escape-sequence) (bracket delimiter error))) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 09:42:53 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 14:42:53 +0000 Received: from localhost ([127.0.0.1]:36396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CgG-0003ra-VC for submit@debbugs.gnu.org; Mon, 05 Dec 2022 09:42:53 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:21439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CgD-0003rT-Ki for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 09:42:51 -0500 Date: Mon, 05 Dec 2022 14:42:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670251362; x=1670510562; bh=yYHZcR7iXXD9mTGXofjldLNoWAefIxLHFH/uo0FeyXI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=BWqi7/XGzZQ5ItO9AlpxKgeE3qpzyCqwZgvnpqRnWRztn4frIjp1rnNJKmVADW++p TYyGcgmruqzffZhc6cp6eqBuQ44EB43HZ58E864j3uAjoD/6ZMgfzeXRR/ZoRy52hn c7+Z82oLZXTaQHY+Cl0Y2naxcg9TESDnJARphFVjDnYgieDQSU1j9pXtNbfN/bmx6g C1G1/snmC9BTPeQPqoxyi1wrW5E4Qdtviyi25BXBtqXA74FvP7f7NrLtwvJBBys1Rx sxThvxzeucHtG5uBvLZ6o28qb0qoMMkBZuzScwMHDyXe+uigrlZRjMmftKlUvxtSzk eNkSjBbJqyzAQ== To: Theodor Thornhill From: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Message-ID: In-Reply-To: <87sfhuvt0h.fsf@thornhill.no> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 09:12, Theodor Thornhill wrote: >=20 >=20 > Randy Taylor dev@rjt.dev writes: >=20 > > On Monday, December 5th, 2022 at 08:52, Randy Taylor dev@rjt.dev wrote: > >=20 > > > On Monday, December 5th, 2022 at 06:24, Theodor Thornhill theo@thornh= ill.no wrote: > > >=20 > > > > Jostein Kj=C3=B8nigsen jostein@secure.kjonigsen.net writes: > > > >=20 > > > > > Hey everyone. > > > > >=20 > > > > > When opening a JSON-file in a build from emacs git emacs-29 > > > > > release-branch, Emacs still defaults to json-mode. > > > > >=20 > > > > > Fontification in json-mode looks correct and proper. > > > > >=20 > > > > > When trying to insteas use json-ts-mode, literally everything is > > > > > fontified as strings. > > > > >=20 > > > > > When I change the code to disable the string-fontification rule, = this > > > > > yields a buffer where everything is fontified using default-face.= That > > > > > is, no other fontification is taking place. > > > > >=20 > > > > > Have this mode really been tested? Should it be working? Or is th= ere an > > > > > error on my end? > > > > >=20 > > > > > Could someone else please give json-ts-mode a try? > > > >=20 > > > > Yeah, you are correct. It seems we've had a regression in this comm= it, > > > > 0ed313642227afdeccf48057eea458edca9d2962. > > > >=20 > > > > I believe this is the offending commit - what do you think, Randy? > > > >=20 > > > > Specifically the lhs should be fontified differently than the rhs, = so > > > > not everything is a string. > > > >=20 > > > > Do you want to do that, Randy, or should I? > > > >=20 > > > > Theo > > >=20 > > > Can someone show me an example JSON file that shows this problem? Eve= rything looks the same for me in json-mode and json-ts-mode, except for the= json-ts-mode extras (even with Theo's patch) both with my own Emacs config= and emacs -Q. I must be doing something very silly. > >=20 > > Scratch that, I got Theo's patch working, needed to rebuild. >=20 >=20 > No need to rebuild. Just C-M-x the defvar and revert buffer. I was even restarting and it wasn't picking up the changes for some reason. >=20 > > Looks good to me (although it would be nice to keep treesit-font-lock-f= eature-list alphabetized Theo ;)). >=20 >=20 > See new patch! Thanks, I meant just the treesit-font-lock-feature-list variable :) (so mov= ing pair before string). Having the font-lock settings alphabetized too is great, but I remember run= ning into some highlighting issues depending on the order of things. For example, since error is above number, the number face will not be highl= ighted as error when an error occurs. Try: { "test": 2 } and remove the colon. Before your patch, the entire line is red. After, onl= y "test" is red. So in general, I think we should stick all :overrides at the bottom of that= list (with error being the ultimate one), and keep everything above and be= low alphabetized, but separately, which is how I organized json-ts-mode. >=20 > > json-mode still fontifies pretty much everything as a string though (at= least for me). >=20 >=20 > Not for me. I get number-face, bracket-face, constant-face, > warning-face. Don't you? Are you guys talking about the json-mode package? Jostein mentioned "Emacs = still defaults to json-mode", but when I open a JSON file I get js-json-mod= e, which is what I assumed he meant. js-json-mode is what I was trying to m= atch in json-ts-mode. >=20 > Will you commit this, Yuan? >=20 > Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 09:52:31 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 14:52:31 +0000 Received: from localhost ([127.0.0.1]:36450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Cpb-00040E-0L for submit@debbugs.gnu.org; Mon, 05 Dec 2022 09:52:31 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:36193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CpX-000407-F5 for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 09:52:28 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 66A465C00E7; Mon, 5 Dec 2022 09:52:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 05 Dec 2022 09:52:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670251941; x=1670338341; bh=3l 7/DlN/ZyKwj0erqZT2xAiiKsg28TOZhwCM2ky1LLY=; b=Koj69dzUgP6uE/rwWl vJ6uPam0+tPsQVQyz1mdKXyi3DiXtMiNU7ZWHibGJXtPGFbuXTIhyvsymFmOgIe2 5MhegEEBH+OzwdwPaQvesCYVXkmVOK1rCQw+U0EbT/XLfEio9SMZ8pQYItutNQev 1RkayyM3kDB4R5mB7D+VF6iTuKmjaRF4b6ZGt1bhv/Ql+veP5U8I76Ng7OuZ1R/Z 8mEEZ3P4lyW+wmS9E7HWi5H2TNvQqfkexMz/8HcMMBXi2onoYa2jSbXpXkN0GkRx COl9vEH44ctwqWmhmxUEwovjyCW+9H9D45eTRF/IrH6QRAWu1kCZ53ZDCIpGAfmE /Dbw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670251941; x=1670338341; bh=3l7/DlN/ZyKwj0erqZT2xAiiKsg28TOZhwC M2ky1LLY=; b=RvHWZGurApk0/KQpF7q1J5TYEBUkufuWg4vJ5dMHVOJ/00dbwK7 MHZhh2pN9PqiaHALbVldM8i2y99Sdgzh3vS8qp8gRlL5yURG3kCYI/pDI6N6D+mW I0Aq/8eyf4CeUj9BawVDUVbdDsv7dTUx6FjtikIH00b6LIXKRgBPunSi/hamHIW/ Jj4mV/LrcpV2nbJJ7OVSZezL+vnZHhIc24cO/D4yv1CiL8a7n3awqc26KkSfeii5 TT+wVGaxm7U/sqrmpQHlk2A4pMsUG28+j31BkT3om6R/N9r6MUNmMDHfCeGziFaL PCKbNon/ZQ9UTJ8qyFQyzdHA13cJpErl/nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeevvefhfeeffedtvdfhvdei ieffheeiheegheegtddtkeevffelteetgedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 09:52:20 -0500 (EST) Message-ID: <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> Date: Mon, 5 Dec 2022 15:52:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Content-Language: nb-NO, en-GB To: Randy Taylor , Theodor Thornhill References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 05.12.2022 15:42, Randy Taylor wrote: > > Thanks, I meant just the treesit-font-lock-feature-list variable :) (so moving pair before string). > > Having the font-lock settings alphabetized too is great, but I remember running into some highlighting issues depending on the order of things. > For example, since error is above number, the number face will not be highlighted as error when an error occurs. > > Try: > { > "test": 2 > } > > and remove the colon. Before your patch, the entire line is red. After, only "test" is red. > > So in general, I think we should stick all :overrides at the bottom of that list (with error being the ultimate one), and keep everything above and below alphabetized, but separately, which is how I organized json-ts-mode. Good observation. Agreed. > > Are you guys talking about the json-mode package? Jostein mentioned "Emacs still defaults to json-mode", but when I open a JSON file I get js-json-mode, which is what I assumed he meant. js-json-mode is what I was trying to match in json-ts-mode. I've never heard of js-json-mode until today. I always use json-mode (which AFAIK) is still the default for json-files, unless overridden in your own .emacs setup. I can see that in Emacs git right now, json-ts-mode behaves closely to js-json-mode. I honestly expected it to match the Emacs-default json-mode though, and found the current highlighting ... somewhat unexpected. IMO, yes the keys are technically speaking strings, but the are predominantly and semantically keys, and IMO should be highlighted as such. Just like json-mode does. I realise this is somewhat subjective and preferential, but as far as my preference goes, I clearly prefer json-mode over js-json-mode, and as such also prefer the current patch-sets for json-ts-mode which Theo has submitted. (On my part we can avoid side-tracking related to why there are multiple json-modes, unless has a deep need to contextualize these changes related to those ;) ) -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 10:00:39 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 15:00:39 +0000 Received: from localhost ([127.0.0.1]:36531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CxS-00048e-T2 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:00:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CxQ-00048Y-OP for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 10:00:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2CxK-0004WG-Vm; Mon, 05 Dec 2022 10:00:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3Vr1sOiqJZH9VF7JaF9VkAA/8JIFg08gl+bcvbTNH0I=; b=MsKlDCKKThs4MYu6fm9a aefomsgxmqn/f9wbW58n1j68iyzcHHR2rzvvsAzY3UF8Zd1gza7HfcY9NbKFTKUinb5O8dybVRx7Z +gHnwaMlR0wBrOWS74Pvs2wOSeHzCIfP/dLSa2inNvPD4V7/1TtM0T5K7Acc2IYYiwLuVZZ3UWhF4 d+DKKR7QC8wUiohA8SQIEEsuLlWaUyGYNbO3xk70hyTVlsmpaQvY5sKgRA+AtrPWBNKoGPT1EfVUp Jk31vqJ2XuZbQDsfbYGSkXNWw6+eVqTOn3126f6UJacV8j9d4f35af4XBevuWg5Vw7hs6XH59hhru mP+Dc/tCCk1CgA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2CxK-0004pv-8q; Mon, 05 Dec 2022 10:00:30 -0500 Date: Mon, 05 Dec 2022 17:00:14 +0200 Message-Id: <83fsdt99q9.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Mon, 5 Dec 2022 15:52:17 +0100) Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59833 Cc: dev@rjt.dev, casouri@gmail.com, 59833@debbugs.gnu.org, theo@thornhill.no, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net > Date: Mon, 5 Dec 2022 15:52:17 +0100 > From: Jostein Kjønigsen > > I've never heard of js-json-mode until today. I always use json-mode > (which AFAIK) is still the default for json-files, unless overridden in > your own .emacs setup. Not in Emacs 29. I see the following in files.el, as part of auto-mode-alist: ("\\.json\\'" . js-json-mode) From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 10:01:42 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 15:01:42 +0000 Received: from localhost ([127.0.0.1]:36544 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CyT-00049b-Lb for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:01:41 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:20241) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2CyQ-00049V-Oi for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 10:01:40 -0500 Date: Mon, 05 Dec 2022 15:01:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670252491; x=1670511691; bh=gKR0HYWQyKVUBDhEb+QEbkJKqAGQoD/SOKXf+uxBnYA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=T53JBRBwsfXEMEvwfTCb+X4UpBjAfxV07Xb2f8tb36QEGfqRSXL5czQnFK1qvLoeN G8SE0KhNeBikx7hy5jD++wrRM+1aVjaGwPXD24Q67zv0OXI8IRZ6apFc5mJOmvy1X6 Ah3xJnS0TtnEZThBW8gMBJPWYKkZCqIgqs2FEDA+rPAsqLsYohvGX798CT0+XGeUhi P3pwdmTUHEy5V0t3Q9Jt+O2aJIWfF4LmMBv1Ouar1sFQ5fgQq6iMANlx4/TxmK6qNb jl+UDPl6w+3PLrPOqxGo9FdRZ8gxL5Y9wjArogKnbJKJA+g6+FtlfAqp4vNnxbqCcW WtVcFE4TYhpAg== To: jostein@kjonigsen.net From: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Message-ID: In-Reply-To: <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, Theodor Thornhill X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 09:52, Jostein Kj=C3=B8nigsen wrote: >=20 >=20 > On 05.12.2022 15:42, Randy Taylor wrote: >=20 > > Thanks, I meant just the treesit-font-lock-feature-list variable :) (so= moving pair before string). > >=20 > > Having the font-lock settings alphabetized too is great, but I remember= running into some highlighting issues depending on the order of things. > > For example, since error is above number, the number face will not be h= ighlighted as error when an error occurs. > >=20 > > Try: > > { > > "test": 2 > > } > >=20 > > and remove the colon. Before your patch, the entire line is red. After,= only "test" is red. > >=20 > > So in general, I think we should stick all :overrides at the bottom of = that list (with error being the ultimate one), and keep everything above an= d below alphabetized, but separately, which is how I organized json-ts-mode= . >=20 > Good observation. Agreed. >=20 > > Are you guys talking about the json-mode package? Jostein mentioned "Em= acs still defaults to json-mode", but when I open a JSON file I get js-json= -mode, which is what I assumed he meant. js-json-mode is what I was trying = to match in json-ts-mode. >=20 >=20 > I've never heard of js-json-mode until today. I always use json-mode > (which AFAIK) is still the default for json-files, unless overridden in > your own .emacs setup. >=20 > I can see that in Emacs git right now, json-ts-mode behaves closely to > js-json-mode. I honestly expected it to match the Emacs-default > json-mode though, and found the current highlighting ... somewhat > unexpected. >=20 > IMO, yes the keys are technically speaking strings, but the are > predominantly and semantically keys, and IMO should be highlighted as > such. Just like json-mode does. >=20 > I realise this is somewhat subjective and preferential, but as far as my > preference goes, I clearly prefer json-mode over js-json-mode, and as > such also prefer the current patch-sets for json-ts-mode which Theo has > submitted. >=20 > (On my part we can avoid side-tracking related to why there are multiple > json-modes, unless has a deep need to contextualize these changes > related to those ;) ) >=20 > -- > Jostein You say "Emacs-default json-mode" but I don't see that anywhere. If you run= emacs -Q and visit a JSON file, you get js-json-mode, which is the Emacs-d= efault JSON mode, unless I'm missing something. Regardless, I think your proposal (and Theo's patch) is great, and a defini= te improvement. I can't believe I've tolerated everything in JSON files as = a string face for so long ;). From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 10:03:49 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 15:03:49 +0000 Received: from localhost ([127.0.0.1]:36563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2D0X-0004B1-87 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:03:49 -0500 Received: from out-18.mta0.migadu.com ([91.218.175.18]:17292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2D0U-0004Av-ME for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 10:03:48 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670252624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q0DWaT4i+z5/tOm1yiaggFAQUbuMZVvPRms6jr3u0Ac=; b=JMIDHSVWATut3WVDbZVjR6rEMqPrY0rV6kKjij+q1QNnqRJCJA7151LOI5TlkqakTYChei whi5qYfkiu/R/9EFnjXdcVdqymFqs9T6+0tt9T0TW8pu/JBbFicPRJDNAYkrnP5ONaZs5T +lD6msLwqAzhDcvPui5gM7YUVbgyYCWqvzs1DB00W0aMfiz70ubSMRkD2q8BjYs7quZgRw ixt1AufacrGuyF4vf0FSn1cZ9MENZKdg86J8Yq+3nVKQZ/jHV7QixQ1tkPR9ai5gVfrc48 lHjbmFjVJfJlv/vrlGrT+emnZNLw0fNtWnfsWyl8cf9uAKGwhQGJWunp8o7ViA== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> Date: Mon, 05 Dec 2022 16:03:43 +0100 Message-ID: <87o7shx580.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jostein Kj=C3=B8nigsen writes: > On 05.12.2022 15:42, Randy Taylor wrote: >> >> Thanks, I meant just the treesit-font-lock-feature-list variable :) (so = moving pair before string). >> >> Having the font-lock settings alphabetized too is great, but I remember = running into some highlighting issues depending on the order of things. >> For example, since error is above number, the number face will not be hi= ghlighted as error when an error occurs. >> >> Try: >> { >> "test": 2 >> } >> >> and remove the colon. Before your patch, the entire line is red. After, = only "test" is red. >> >> So in general, I think we should stick all :overrides at the bottom >> of that list (with error being the ultimate one), and keep everything >> above and below alphabetized, but separately, which is how I >> organized json-ts-mode. > Good observation. Agreed. Yes ok ok ;-) >> >> Are you guys talking about the json-mode package? Jostein mentioned >> "Emacs still defaults to json-mode", but when I open a JSON file I >> get js-json-mode, which is what I assumed he meant. js-json-mode is >> what I was trying to match in json-ts-mode. > > I've never heard of js-json-mode until today. I always use json-mode=20 > (which AFAIK) is still the default for json-files, unless overridden in=20 > your own .emacs setup. > > I can see that in Emacs git right now, json-ts-mode behaves closely to=20 > js-json-mode. I honestly expected it to match the Emacs-default=20 > json-mode though, and found the current highlighting ... somewhat=20 > unexpected. > > IMO, yes the keys are technically speaking strings, but the are=20 > predominantly and semantically keys, and IMO should be highlighted as=20 > such. Just like json-mode does. > > I realise this is somewhat subjective and preferential, but as far as my= =20 > preference goes, I clearly prefer json-mode over js-json-mode, and as=20 > such also prefer the current patch-sets for json-ts-mode which Theo has=20 > submitted. > > (On my part we can avoid side-tracking related to why there are multiple= =20 > json-modes, unless has a deep need to contextualize these changes=20 > related to those ;) ) > Yeah js-json-mode is a lot simpler, and is imo too simple. The json-mode is not infact default in emacs, but there are two, one in melpa and one in elpa, IIRC. Anyway, last patch for now - are you both satisfied with this one? Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-back-in-font-locking-for-pair-in-json-ts-mode.patch >From ff88a7ca0d331b25579b5bbd7f90e2a7e31d109f Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Mon, 5 Dec 2022 15:59:41 +0100 Subject: [PATCH] Add back in font-locking for pair in json-ts-mode * lisp/progmodes/json-ts-mode.el (json-ts-mode--font-lock-settings): Add back in removed pair font-lock code. Also alphabetize features. (json-ts-mode): Use the new feature. (bug#59833) --- lisp/progmodes/json-ts-mode.el | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/json-ts-mode.el b/lisp/progmodes/json-ts-mode.el index 101e873cf6..440ffb3128 100644 --- a/lisp/progmodes/json-ts-mode.el +++ b/lisp/progmodes/json-ts-mode.el @@ -93,6 +93,10 @@ json-ts-mode--font-lock-settings :override t '((escape_sequence) @font-lock-escape-face) :language 'json + :feature 'pair + :override t + `((pair key: (_) @font-lock-variable-name-face)) + :language 'json :feature 'error :override t '((ERROR) @font-lock-warning-face)) @@ -156,7 +160,7 @@ json-ts-mode ;; Font-lock. (setq-local treesit-font-lock-settings json-ts-mode--font-lock-settings) (setq-local treesit-font-lock-feature-list - '((constant number string) + '((constant number pair string) (escape-sequence) (bracket delimiter error))) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 10:35:26 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 15:35:26 +0000 Received: from localhost ([127.0.0.1]:36747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DV8-0004UW-Fp for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:35:26 -0500 Received: from mail-4317.proton.ch ([185.70.43.17]:63447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DV5-0004UQ-LR for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 10:35:24 -0500 Date: Mon, 05 Dec 2022 15:35:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670254516; x=1670513716; bh=iCjOIbOJhbcO8fqUZXn32WqQWnJIZOpVm36Kk2Rp5ps=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=NlwT8omcnP4zXFvBFtC4FEAyC2U5f6enQLG+GAqC9cstRWD8fjo7xwIs5WaIJLe+8 109NFW35Ah3Drtq05jC3sCPT+0z1b8oVx05XnpV4Efq6COKFVv5l/tcb1rCs/TqD4W qVfqhb9FNZaNxe8aBNxe6SbJT5SelKoIcHW/O7w/+0ZvHo1kNIg8ZbsTw/qvpI71PO YkHtwXK4Efer/SYFiDyWwcza1IdxnLr+8hJbRvereSX8+VJKUEv5Q5XkpXFooc2XwH DJBthhRF0uMfs+7anyevTemksSJh7+JsgvycGhICLOTK9lR0qPR1yab2SdWG8QYvP0 RSy9+in1v84JQ== To: Theodor Thornhill From: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string Message-ID: In-Reply-To: <87o7shx580.fsf@thornhill.no> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: jostein@kjonigsen.net, Yuan Fu , 59833@debbugs.gnu.org, =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 10:03, Theodor Thornhill wrote:=20 > > Yeah js-json-mode is a lot simpler, and is imo too simple. The json-mode > is not infact default in emacs, but there are two, one in melpa and one > in elpa, IIRC. >=20 > Anyway, last patch for now - are you both satisfied with this one? >=20 > Theo It's perfect! Sorry for all the trouble :D. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 10:38:34 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 15:38:34 +0000 Received: from localhost ([127.0.0.1]:36776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DYA-0004Wh-C7 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 10:38:34 -0500 Received: from out-149.mta0.migadu.com ([91.218.175.149]:48745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2DY8-0004Wb-Sp for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 10:38:33 -0500 Date: Mon, 05 Dec 2022 16:37:41 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670254711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fdfpztEd4kiiIc95wMxgZzbyU0qTXE/rQWQHxppLoIE=; b=FXJMUuEjSWlyTPjxssyWYCHuvfvK3eePHKjmwaotexuJIyMGra1ENxBGNX0b1t/FYGLYYI H+M714k+PPjTpBmQZgUO7UGpA9yl7vZ+EbCdwkjzDEjvd1xqj527QAtsK5itGoW5b0V3w9 0HqDY+ghUmVjx9/yjiqPv4J6xtpJ7psyCYSBg7wA6AVpUN3BjGOodc1cQiEe5j7nyawSxL 78qQdI5egB7iLl31Q0HPCbUl65oeyHaXoaGVth3iFExXU40rS2NbJTTv7W/6M1RhrN4Hht bJnZsnL7JKi9CNCNOknyU4WPT4UasuC4sZITF1bfIGQstRUNUp1KORz5ae4+4g== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Randy Taylor Subject: Re: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> Message-ID: <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: jostein@kjonigsen.net, Yuan Fu , 59833@debbugs.gnu.org, =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5 December 2022 16:35:12 CET, Randy Taylor wrote: >On Monday, December 5th, 2022 at 10:03, Theodor Thornhill wrote:=20 >> >> Yeah js-json-mode is a lot simpler, and is imo too simple=2E The json-m= ode >> is not infact default in emacs, but there are two, one in melpa and one >> in elpa, IIRC=2E >>=20 >> Anyway, last patch for now - are you both satisfied with this one? >>=20 >> Theo > >It's perfect! Sorry for all the trouble :D=2E No problem :) Yuan, will you commit this one? Theo=20 From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 14:58:08 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 19:58:08 +0000 Received: from localhost ([127.0.0.1]:38034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2HbM-0000tX-HP for submit@debbugs.gnu.org; Mon, 05 Dec 2022 14:58:08 -0500 Received: from mail-pl1-f180.google.com ([209.85.214.180]:39770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2HbK-0000sj-Me for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 14:58:07 -0500 Received: by mail-pl1-f180.google.com with SMTP id k7so11847722pll.6 for <59833@debbugs.gnu.org>; Mon, 05 Dec 2022 11:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jLyjBXCnb7ZkKOBqyKJzmT4XNpPPDsKAnAAWWORr0bw=; b=ZTHVEW6nAPy7zkYQfmsyZqgrdLFJrfOx4eIwRXZUGWnfYubNih8ryLDcbhiD6CO9A0 qMOCJ87axAJNhXXWXM8UqQsKalTexL62EOqAelvGJduHS7+SSHi1mgL65Z+OD6tCFUu4 L7KkRYyvFczEYou188ZAbzpY/NkTn/hzDz2gIu+6eQy+vxuf1kaRoobaXRx+eUyEbOoL wfHJZNunwqoPlH7qVc39hd143rA4pog5wL4723Dk69kg3fHF2CGIM7mby8i6FLplb2gQ 2n7aHwcGmbBx0IcI6jqrrSf192XuwbOKjJ5/lFGdQZOF6WUSQcX3nNYo6oMN02J17ETK JiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jLyjBXCnb7ZkKOBqyKJzmT4XNpPPDsKAnAAWWORr0bw=; b=qnaXukxwY92AN/sQshFHbvP46PBq2tN4VoZYXoc28J0QbKdCGFKzx6apbW1zITPAzK G08E2IFcOmzBlcYZn+R/yJdyP+fAiKWoYCyO8dJ+RsD1dU3xQWosXOUsOgVFN1ObDfla wMHmHNYySXOEOy95/0DsI+v+8HHyPeLDCiIMFe/ZU1B1nPQm06lVw2D5xtSfH9IZsdw/ ExTpqcJMMnPozM3u9k9xfP4/0h3RNAIW4J9IvTJV5o3UZVtKZb6BE+cZ7dGEc/goBXTg cOMSbBLL4FlJscXxLB31TsdB6/qwllXm3quJRT/NxgfKulX72mYqu97DLkKzFgy67y6O +ImA== X-Gm-Message-State: ANoB5pkShcKSzLT/p1m2hARgCqYWq2m4o5w/z0hJ9/3eFlQB9ybBVoF2 KJLHdZfMMazaq25dfXYzNLM= X-Google-Smtp-Source: AA0mqf6cvlJMHLlDHY4SH8VmVOtfFTCBOsO6S96Hh6TKwlCY9TTpmVNHeVSuuF2wtgECUgyo6cwUWA== X-Received: by 2002:a17:902:848d:b0:188:f42d:5b1a with SMTP id c13-20020a170902848d00b00188f42d5b1amr66810096plo.26.1670270280721; Mon, 05 Dec 2022 11:58:00 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f14-20020a170902684e00b0018971fba556sm10980347pln.139.2022.12.05.11.57.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2022 11:58:00 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string From: Yuan Fu In-Reply-To: <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> Date: Mon, 5 Dec 2022 11:57:55 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , 59833@debbugs.gnu.org, jostein@kjonigsen.net, =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU = Emacs, the Swiss army knife of text editors = wrote: >=20 >=20 >=20 > On 5 December 2022 16:35:12 CET, Randy Taylor wrote: >> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill = wrote:=20 >>>=20 >>> Yeah js-json-mode is a lot simpler, and is imo too simple. The = json-mode >>> is not infact default in emacs, but there are two, one in melpa and = one >>> in elpa, IIRC. >>>=20 >>> Anyway, last patch for now - are you both satisfied with this one? >>>=20 >>> Theo >>=20 >> It's perfect! Sorry for all the trouble :D. >=20 > No problem :) >=20 > Yuan, will you commit this one? Yeah. IIUC :override t is not necessary for pair, right? If so, I=E2=80=99= ll apply the patch and remove the :override, is that OK? Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 15:15:16 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 20:15:16 +0000 Received: from localhost ([127.0.0.1]:38138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hrw-00015K-3p for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:15:16 -0500 Received: from out-18.mta0.migadu.com ([91.218.175.18]:20586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hru-00015C-Ec for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 15:15:15 -0500 Date: Mon, 05 Dec 2022 21:14:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670271311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dLsVD7z2rLa7UtIrKhH6JxrduqVU1jA//+wrek0gt2c=; b=RXcqOFF/mSgpeIZXhk+BaKevXT9fVgJ/G2MoN6j598WA6VOkd5ObqEsbh4lb+PR12JGC8i 3UMETOXcZcEy4fQOhorOqI4y+VK9DGieF1+AFYACt3UtlWRjVWBi/DuB1BCvEVrk2nvgzo gKqIPgyEptS0eyxG+cS59Sy1wlfrjPQWXOyDmYhFURhRQEPeliL3Mt/4LgU+O541hDzezd nOii7jo4Adkou5QHH7XBplhzgfU2RLB0mas4PCKeoLcidPGpcuATLSnjDnSksuUu5yf8vW 8S+RaoOLl1wpZTF+NW+jzvbQXvgtos439Xn3WnULBmYruxFnp6/7p5NhnYQ84w== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Yuan Fu Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> References: <87sfhudrfu.fsf@thornhill.no> <_KSXcXGtjgQ4mzy-Ml9kIV0QngRcfhNomsCAtEhd7ZAP6ih86_WavpD-qSNN-MnXBLi0VACZ57_Ig4MkuoD5FB5qk80Y7C-LYaZrZRvSdK8=@rjt.dev> <4pslNusoayXbQq867kk1hbmFpD9rInmrKFngvhWbFFEFg-V1SrZLqJ47TyJDGrFal86hf7cLAGAD_KiCUyCEh52J45_tu4wAQ9HXpkIiFzI=@rjt.dev> <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> Message-ID: <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: Randy Taylor , 59833@debbugs.gnu.org, jostein@kjonigsen.net, =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5 December 2022 20:57:55 CET, Yuan Fu wrote: > > >> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU E= macs, the Swiss army knife of text editors wrote: >>=20 >>=20 >>=20 >> On 5 December 2022 16:35:12 CET, Randy Taylor wrote: >>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill wrote:=20 >>>>=20 >>>> Yeah js-json-mode is a lot simpler, and is imo too simple=2E The json= -mode >>>> is not infact default in emacs, but there are two, one in melpa and o= ne >>>> in elpa, IIRC=2E >>>>=20 >>>> Anyway, last patch for now - are you both satisfied with this one? >>>>=20 >>>> Theo >>>=20 >>> It's perfect! Sorry for all the trouble :D=2E >>=20 >> No problem :) >>=20 >> Yuan, will you commit this one? > >Yeah=2E IIUC :override t is not necessary for pair, right? If so, I=E2=80= =99ll apply the patch and remove the :override, is that OK? > >Yuan Please test it first, but sure! We want it to not be string face at least = :) Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 15:19:12 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 20:19:12 +0000 Received: from localhost ([127.0.0.1]:38157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hvj-00017J-Pw for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:19:12 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:35433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hvh-00017D-PG for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 15:19:11 -0500 Date: Mon, 05 Dec 2022 20:19:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1670271542; x=1670530742; bh=G/BJVmlyXVNZ0k1FMwKSx8jBVmhp+ZObs9UxLGDp4fc=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=qhEDJ/Xje3gLtp00KopM/4tCNEdZDaq1I0dgJzbYPtkcjav2Gx2PORfRB4zEUjoxM NieY0VnCkLnAlEoriuzFY9rrDy9N2cwgdoMiMiGo8Bou8PDbuVnsI1oSTPmht61xl3 YaMIfHy55ACmKwzfq9eFGJhT6bZhkUrCfFs9hhjVmQWAkMBOmfhnRDPAet5lqNGZWN qcsry4Kr28QlSBu+s2ck5khs9DQzt/GNWC6IDWdsnfFg9DNm8KdYzXlcPRHT60pMtm HerBab/AQpyyzijMtJut2eDClvkWnfrx0BhCIgMh4wVqMemIM/IIDl48hOOYWAkosl xnmvjTJVqs4zQ== To: Theodor Thornhill From: Randy Taylor Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Message-ID: In-Reply-To: <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> References: <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , Yuan Fu , 59833@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Monday, December 5th, 2022 at 15:14, Theodor Thornhill wrote: >=20 >=20 > On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail.com wrote: >=20 > > > On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GNU= Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org wrote: > > >=20 > > > On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt.dev wrote: > > >=20 > > > > On Monday, December 5th, 2022 at 10:03, Theodor Thornhill theo@thor= nhill.no wrote: > > > >=20 > > > > > Yeah js-json-mode is a lot simpler, and is imo too simple. The js= on-mode > > > > > is not infact default in emacs, but there are two, one in melpa a= nd one > > > > > in elpa, IIRC. > > > > >=20 > > > > > Anyway, last patch for now - are you both satisfied with this one= ? > > > > >=20 > > > > > Theo > > > >=20 > > > > It's perfect! Sorry for all the trouble :D. > > >=20 > > > No problem :) > > >=20 > > > Yuan, will you commit this one? > >=20 > > Yeah. IIUC :override t is not necessary for pair, right? If so, I= =E2=80=99ll apply the patch and remove the :override, is that OK? > >=20 > > Yuan >=20 >=20 > Please test it first, but sure! We want it to not be string face at least= :) >=20 > Theo It's necessary, since string comes first and pair needs to override it (jus= t tested). From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 15:22:20 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 20:22:20 +0000 Received: from localhost ([127.0.0.1]:38172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hym-00019E-Dq for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:22:20 -0500 Received: from mail-pl1-f178.google.com ([209.85.214.178]:46913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hyk-000195-0z; Mon, 05 Dec 2022 15:22:19 -0500 Received: by mail-pl1-f178.google.com with SMTP id jn7so11894865plb.13; Mon, 05 Dec 2022 12:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JclPXqtPRSFCM/H3UPF1yF80wMCQSw0AL3nlhDQBW8E=; b=fa2DUMIEvBOyJrfhGBvATYwy2Oc8u+ebPhc+azH8uBcBUSPJSY0/tFiX6ejf47GHXG 3eHPApSA2QpbdUee5jM0rFb/n/ZxvNGpykGimVKWqueKpQmBUYbg8U3PXv8h28Y7xyKV nzrUmVrVz4mVaCB4d9+FpjWV1siYWbGid12MzTkEjWWdnPR0Htz65lth+8IC8gkoPyIO +Mib0xsSF74iokP6WcLQtzE63GPZE0NedWruhlJNdh/W+suacIXH4gLzfyKH+6BMvwzD Pqf/UXfM3twapOR7hBpAiWVIoDrAfPxuQczfxEWhcqSUOmTqapduWUGKQr+ysgqyovoM 4Btw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JclPXqtPRSFCM/H3UPF1yF80wMCQSw0AL3nlhDQBW8E=; b=d4OIfRDJSqXGZmF1O4b4LZGl3FViemPA+w3n5E9tQaffPcEX6+bTCw+zG4q+KkwrN0 x/AJ2ZvK8UG6ugifNYWbxYyOxZsUW777qWxMbYi6e+xnf7VA3uXt7M7NtTlRN9Vdflf/ iPxc3QNNb2LNRPDPnDkXUuVaIOfNa5zSqHs9Pv4yHGm0GgB4tDH2YVK77IAv5d/r1bBA bHlBMe0rn7z/baO3I90o7DBZk/cfM3+XV9rr+/sE57K9Uw+zKXnirCCg17/WV6O0ZmjH z7QZL0Rl4Y3lm6lc8FQPcLfT1OQPbLXJ62o3hNXl+WaseodzjpKfWa7bbXM/HUuw4qd1 HjEQ== X-Gm-Message-State: ANoB5pl31hHZPl2vtCiM1yZ6SllkWoRdqMB5H0JRLkuIDOjbYkubAcjt 2yTlc3MTPXZoBQsLMW1yuyU= X-Google-Smtp-Source: AA0mqf7cUKVG9QeuHtZNByMOCrpFwNQwrzKMv3ttjMTKIjeasuUOaxxbppCujY8DjAWiA3I5gSPuog== X-Received: by 2002:a17:903:28d:b0:189:b74e:cd07 with SMTP id j13-20020a170903028d00b00189b74ecd07mr19888165plr.169.1670271732159; Mon, 05 Dec 2022 12:22:12 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 188-20020a6304c5000000b00477bfac06b7sm8673631pge.34.2022.12.05.12.22.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2022 12:22:10 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string From: Yuan Fu In-Reply-To: Date: Mon, 5 Dec 2022 12:22:09 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> To: Randy Taylor X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: jostein@kjonigsen.net, 59833@debbugs.gnu.org, Theodor Thornhill , 59833-done@debbugs.gnu.org, =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 5, 2022, at 12:19 PM, Randy Taylor wrote: >=20 > On Monday, December 5th, 2022 at 15:14, Theodor Thornhill = wrote: >>=20 >>=20 >> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail.com wrote: >>=20 >>>> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for = GNU Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu.org = wrote: >>>>=20 >>>> On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt.dev wrote: >>>>=20 >>>>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill = theo@thornhill.no wrote: >>>>>=20 >>>>>> Yeah js-json-mode is a lot simpler, and is imo too simple. The = json-mode >>>>>> is not infact default in emacs, but there are two, one in melpa = and one >>>>>> in elpa, IIRC. >>>>>>=20 >>>>>> Anyway, last patch for now - are you both satisfied with this = one? >>>>>>=20 >>>>>> Theo >>>>>=20 >>>>> It's perfect! Sorry for all the trouble :D. >>>>=20 >>>> No problem :) >>>>=20 >>>> Yuan, will you commit this one? >>>=20 >>> Yeah. IIUC :override t is not necessary for pair, right? If so, = I=E2=80=99ll apply the patch and remove the :override, is that OK? >>>=20 >>> Yuan >>=20 >>=20 >> Please test it first, but sure! We want it to not be string face at = least :) >>=20 >> Theo >=20 > It's necessary, since string comes first and pair needs to override it = (just tested). Ah, yes, of course, sorry for my ignorance. Applied! Yuan= From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 15:39:16 2022 Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 20:39:16 +0000 Received: from localhost ([127.0.0.1]:38279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2IF9-0001LY-VS for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:39:16 -0500 Received: from out-199.mta0.migadu.com ([91.218.175.199]:41903) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2IF7-0001LM-6s for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 15:39:13 -0500 Date: Mon, 05 Dec 2022 21:38:14 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670272751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1hKkihXwzZqAoQL/PO8cjuTs4Sw+JmwVJNYKCy6O5PI=; b=t8Ici/NV2yjG6ZRZWJbYo+g4ub/r0jr1ODA66AdOiPsk4aQqIZROFx0KeId/DIi4w/fu8o qv3hptOsxKxFYugoLB1v6radQyEieRcNjQ5QEfW8RrMbM4QEroWbOsaS8grIaHpJwQK/MG hzdGWE4v8qbodjINpHbtUXkLu9AkUqlfbf25gZKbuuXEITyICp0UT33OPDIc8UngiDqG8O +/k2r9Y0TpZxlRxkDhVkwuRrMrqM2tYS2ix3S9W6Ysz6tLKo1W6uhfyNGSrDjFwUfiSSwB Ml+vs6pYqz9ORT6+kBRNbI25+wOjU4ph7Et13sTaeTUMl5Gd8W/afT76dubf/A== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill To: Yuan Fu , Randy Taylor Subject: Re: bug#59833: 29.0.60; json-ts-mode fontifies everything as string In-Reply-To: References: <87sfhuvt0h.fsf@thornhill.no> <3b83163d-1add-bf14-1376-60e391370d1a@secure.kjonigsen.net> <87o7shx580.fsf@thornhill.no> <848BAB21-6F05-4CE2-BCD7-F0CE0FC1ED5F@thornhill.no> <9990C324-CCC5-4B15-9112-FAB6508E41A8@gmail.com> <6344E557-688E-44C5-BF84-CA88999BAF4E@thornhill.no> Message-ID: <58E4C303-E76E-495B-90C3-6DAAB79FCFED@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59833 Cc: =?ISO-8859-1?Q?Jostein_Kj=F8nigsen?= , 59833@debbugs.gnu.org, jostein@kjonigsen.net, 59833-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 5 December 2022 21:22:09 CET, Yuan Fu wrote: > > >> On Dec 5, 2022, at 12:19 PM, Randy Taylor wrote: >>=20 >> On Monday, December 5th, 2022 at 15:14, Theodor Thornhill wrote: >>>=20 >>>=20 >>> On 5 December 2022 20:57:55 CET, Yuan Fu casouri@gmail=2Ecom wrote: >>>=20 >>>>> On Dec 5, 2022, at 7:37 AM, Theodor Thornhill via Bug reports for GN= U Emacs, the Swiss army knife of text editors bug-gnu-emacs@gnu=2Eorg wrote= : >>>>>=20 >>>>> On 5 December 2022 16:35:12 CET, Randy Taylor dev@rjt=2Edev wrote: >>>>>=20 >>>>>> On Monday, December 5th, 2022 at 10:03, Theodor Thornhill theo@thor= nhill=2Eno wrote: >>>>>>=20 >>>>>>> Yeah js-json-mode is a lot simpler, and is imo too simple=2E The j= son-mode >>>>>>> is not infact default in emacs, but there are two, one in melpa an= d one >>>>>>> in elpa, IIRC=2E >>>>>>>=20 >>>>>>> Anyway, last patch for now - are you both satisfied with this one? >>>>>>>=20 >>>>>>> Theo >>>>>>=20 >>>>>> It's perfect! Sorry for all the trouble :D=2E >>>>>=20 >>>>> No problem :) >>>>>=20 >>>>> Yuan, will you commit this one? >>>>=20 >>>> Yeah=2E IIUC :override t is not necessary for pair, right? If so, I= =E2=80=99ll apply the patch and remove the :override, is that OK? >>>>=20 >>>> Yuan >>>=20 >>>=20 >>> Please test it first, but sure! We want it to not be string face at le= ast :) >>>=20 >>> Theo >>=20 >> It's necessary, since string comes first and pair needs to override it = (just tested)=2E > >Ah, yes, of course, sorry for my ignorance=2E Applied! > >Yuan Great news, thanks! From unknown Tue Aug 19 00:30:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 03 Jan 2023 12:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator