GNU bug report logs - #59831
29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified

Previous Next

Full log

Message #14 received at 59831 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
 59831 <at> debbugs.gnu.org
Cc: jostein <at> kjonigsen.net, casuri <at> gmail.com
Subject: Re: 29.0.60; typescript-ts-mode: Variables, properties & fields are
 often not fontified
Date: Mon, 05 Dec 2022 10:24:48 +0100

Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:

> Attached is another patch with some further improvements.
>
> These too OK with you, Theodor?
>

Yep!

> From 441b2340f0a8d9bf27b0dbcb985051c84672f41f Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein <at> kjonigsen.net>
> Date: Mon, 5 Dec 2022 10:00:15 +0100
> Subject: [PATCH 2/2] lisp/progmodes/typescript-ts-mode: Improve fontifications
>  of variables in use.
>
> ---
>  lisp/progmodes/typescript-ts-mode.el | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
> index 48d3c084b6e..3da690567e2 100644
> --- a/lisp/progmodes/typescript-ts-mode.el
> +++ b/lisp/progmodes/typescript-ts-mode.el
> @@ -215,7 +215,12 @@ typescript-ts-mode--font-lock-settings
>         (_ (_ (identifier) @font-lock-variable-name-face))
>         (_ (_ (_ (identifier) @font-lock-variable-name-face)))])
>  
> -     (return_statement (identifier) @font-lock-variable-name-face))
> +     (return_statement (identifier) @font-lock-variable-name-face)
> +
> +     (binary_expression left: (identifier) @font-lock-variable-name-face)
> +     (binary_expression right: (identifier) @font-lock-variable-name-face)
> +
> +     (arguments (identifier) @font-lock-variable-name-face))
>  
>     :language language
>     :override t
> -- 
> 2.37.2

Theo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.