From unknown Sat Aug 16 10:47:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59831 <59831@debbugs.gnu.org> To: bug#59831 <59831@debbugs.gnu.org> Subject: Status: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Reply-To: bug#59831 <59831@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:47:39 +0000 retitle 59831 29.0.60; typescript-ts-mode: Variables, properties & fields a= re often not fontified reassign 59831 emacs submitter 59831 jostein@kjonigsen.net severity 59831 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 03:42:29 2022 Received: (at submit) by debbugs.gnu.org; 5 Dec 2022 08:42:29 +0000 Received: from localhost ([127.0.0.1]:34666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p273U-0001eF-1q for submit@debbugs.gnu.org; Mon, 05 Dec 2022 03:42:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:43162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p273S-0001e8-3L for submit@debbugs.gnu.org; Mon, 05 Dec 2022 03:42:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p273Q-0004T9-UG for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 03:42:25 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p273M-00067S-KS for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 03:42:24 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id EDF7A5C00B2; Mon, 5 Dec 2022 03:42:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 05 Dec 2022 03:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1670229731; x=1670316131; bh=mc 3U9MivnM8GHTrqtntAFEcXqmiLnpMHXJeOHyrXuUM=; b=Z4HSBef40X0hVw1Eij 5uTPVShb//rmR1LgQL253/03mS50sU9955p5ILnC/ImOS46oVQsjhZ5CTbkObVFs BnbKuuoirnq70SYmRneJoeRHKJl28O2SImZFxf64ijVOV4+yJOqCuwzuzmU92jq2 oYrLtxjlGRxzvHSLTrJ196VcLPkNL7E6aKFVUU47bIxcOFb3ARBpFbKX1gefbZkL IDAOHDv14oawfhWARJwh1Hhaz9J6Hmr0hX/JIMg3BvsFbtbIKwesBlA9Ldw5xb7t nHuE47SaMXkg9unSBQHvl1K0zlIlTmmFoGSa+IL/mUWoeHgVFMylycXkkOrfD8We q3sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1670229731; x=1670316131; bh=mc3U9MivnM8GHTrqtntAFEcXqmiLnpMHXJe OHyrXuUM=; b=hZ8Ui7lsA8Jv+wGTEKRC5VoaSph8tJTKpxzNjCjOcRY22pxWZFf OZTKx5Sb2H+9wAlYYu5tmj/JrMkOUToV8rRySIQJWTxYNChgbZqhXQpDml6CTbRk ec0v2MkiHpaBiprz2EbN1/LOsXOfsv3Q/gmPsG3+BEt6iBKr+hWHreZg7z7O9+1Y AvVMz8m3gdDH+CqlzzwIxacnsDH1YXzwii1xc6gz5RSkuZfwwgiFAeMPXq4ejH/0 FONzkpAbID0JcoCv2x6cM6YJtPYgJgW5O913aKF9kdalqUdQzpmETTVEtXmFgvYT EZ86yi6+nwWGIy0s1ixdtvZWntcDaCzzmnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefgdduvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghrvffhufesmhdtreertdefjeenucfhrhhomheplfhoshhtvghi nhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgsh gvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepueefveehfffhveeghedvkeduffejvdeu gedtgedvveevgfegffetgeekhfevhfegnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhs vghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 03:42:11 -0500 (EST) Content-Type: multipart/mixed; boundary="------------0oRR7QaIvP5jl1d3trXh5pcs" Message-ID: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> Date: Mon, 5 Dec 2022 09:42:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Content-Language: nb-NO To: "bug-gnu-emacs@gnu.org" , Yuan Fu , Theodor Thornhill From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Received-SPF: pass client-ip=66.111.4.26; envelope-from=jostein@secure.kjonigsen.net; helo=out2-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------0oRR7QaIvP5jl1d3trXh5pcs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit When I create or use a class in a Typescript-file, I often have properties and field declarations. These are all fontified using default-face, instead of font-lock-property-face. Also when creating new objects using bracket syntac { key: value, key: value, etc: etc }, default-face is used. Attached is a patch which improves fontification of these aspects in both typescript-ts-mode and typescript-tsx-mode. It also contains code to further improve fontification of retuen-statements, which IMO is a little bit lacking. -- Jostein In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2022-12-02 built on ThinkPad-T14s Repository revision: 1e36ad9458e8deacfc85da573bb0ca0f270d4802 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   bug-reference-prog-mode: t   elisp-slime-nav-mode: t   paredit-mode: t   editorconfig-mode: t   flycheck-mode: t   highlight-symbol-mode: t   which-function-mode: t   nlinum-mode: t   company-mode: t   global-ede-mode: t   ede-minor-mode: t   dap-tooltip-mode: t   dap-ui-many-windows-mode: t   dap-ui-controls-mode: t   dap-ui-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   dap-auto-configure-mode: t   dap-mode: t   global-undo-tree-mode: t   undo-tree-mode: t   doom-modeline-mode: t   projectile-mode: t   ido-yes-or-no-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   server-mode: t   shell-dirtrack-mode: t   global-hl-line-mode: t   yas-global-mode: t   yas-minor-mode: t   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221127.2242/transient hides /home/jostein/build/emacs/lisp/transient /home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot Features: (shadow sort emacsbug magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 helm-bookmark helm-net helm-adaptive treemacs-bookmarks treemacs-tags bookmark mail-extr misearch multi-isearch flyspell ispell mule-util cl-print executable semantic/lex-spp ede/emacs semantic/db semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local bug-reference helm-command helm-elisp helm-eval helm-info face-remap lsp-diagnostics lsp-headerline lsp-icons lsp-modeline view vc-git diff-mode vc-dispatcher disp-table elec-pair typescript-ts-mode js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs treesit winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug backtrace nlinum linum company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company-web-html company-web company-css web-completion-data company eww url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs ido-yes-or-no ido helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load files-x tramp-compat parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel cl-extra autorevert server powershell advice shell pcomplete hl-line lsp-mode lsp-protocol yasnippet help-mode xref project tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode color thingatpt noutline outline icons lv inline imenu ht filenotify f f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme compile-eslint compile text-property-search comint ansi-osc ansi-color ring cl finder-inf git-timemachine-autoloads rx helm-projectile-autoloads expand-region-autoloads all-the-icons-autoloads dracula-theme-autoloads eglot-autoloads multiple-cursors-autoloads tree-sitter-langs-autoloads projectile-autoloads nlinum-autoloads doom-modeline-autoloads rust-mode-autoloads editorconfig-autoloads helm-autoloads helm-core-autoloads async-autoloads assess-autoloads m-buffer-autoloads cargo-autoloads package-lint-autoloads flycheck-autoloads company-autoloads magit-autoloads magit-section-autoloads web-mode-autoloads paredit-autoloads helpful-autoloads elisp-refs-autoloads js2-mode-autoloads yaml-mode-autoloads powershell-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads lsp-mode-autoloads markdown-mode-autoloads ht-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads compat-autoloads pcache-autoloads f-autoloads popup-autoloads s-autoloads info dash-autoloads macrostep-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 2991132 164706)  (symbols 48 56330 18)  (strings 32 217806 17887)  (string-bytes 1 8280995)  (vectors 16 143455)  (vector-slots 8 2426206 213888)  (floats 8 1056 1320)  (intervals 56 367249 2248)  (buffers 992 53)) --------------0oRR7QaIvP5jl1d3trXh5pcs Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-typescript-ts-mode-improve-fontificat.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-typescript-ts-mode-improve-fontificat.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAzYmNiZDg5Y2M0M2M2YWQ3ODg1ZjExYWE0YzdjOTJlYmQ2MDBhMTY0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCA1IERlYyAyMDIyIDA5 OjMxOjU4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlOiBpbXByb3ZlIGZvbnRpZmljYXRpb24KCi0gc3ludGF4LWhpZ2hsaWdodCBw cm9wZXJ0eSBhbmQgZmllbGQgZGVmaW5pdGlvbnMgaW4gY2xhc3MgZGVjbGFyYXRpb24uCi0g c3ludGF4LWhpZ2hsaWdodCBwcm9wZXJ0eS1rZXlzIGluIG9iamVjdCBpbml0aWFsaXphdGVy cy4KLSBzeW50YXgtaGlnaGxpZ2h0IHZhcmlhYmxlLW5hbWVzIGluIGZ1bmN0aW9uL21ldGhv ZCByZXR1cm4tc3RhdGVtZW50cy4KLS0tCiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRz LW1vZGUuZWwgfCAxMyArKysrKysrKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0 aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy90 eXBlc2NyaXB0LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1v ZGUuZWwKaW5kZXggNDhhYzExNjlmZTguLjQ4ZDNjMDg0YjZlIDEwMDY0NAotLS0gYS9saXNw L3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMv dHlwZXNjcmlwdC10cy1tb2RlLmVsCkBAIC0yMTMsNyArMjEzLDkgQEAgdHlwZXNjcmlwdC10 cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKICAgICAgIHBhcmFtZXRlcnM6CiAgICAgICBb KF8gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogICAgICAg IChfIChfIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkpCi0g ICAgICAgKF8gKF8gKF8gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1m YWNlKSkpXSkpCisgICAgICAgKF8gKF8gKF8gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFy aWFibGUtbmFtZS1mYWNlKSkpXSkKKworICAgICAocmV0dXJuX3N0YXRlbWVudCAoaWRlbnRp ZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQogCiAgICA6bGFuZ3VhZ2Ug bGFuZ3VhZ2UKICAgIDpvdmVycmlkZSB0CkBAIC0yODIsNyArMjg0LDE0IEBAIHR5cGVzY3Jp cHQtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICA6bGFuZ3VhZ2UgbGFuZ3VhZ2UK ICAgIDpvdmVycmlkZSB0CiAgICA6ZmVhdHVyZSAncHJvcGVydHkKLSAgIGAoKHBhaXIgdmFs dWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkKKyAgIGAo KHByb3BlcnR5X3NpZ25hdHVyZQorICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIp IEBmb250LWxvY2stcHJvcGVydHktZmFjZSkKKyAgICAgKHB1YmxpY19maWVsZF9kZWZpbml0 aW9uCisgICAgICBuYW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlKQorCisgICAgIChwYWlyIGtleTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBm b250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYWlyIHZhbHVlOiAoaWRl bnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCiAKICAgICAgKChzaG9y dGhhbmRfcHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQog Ci0tIAoyLjM3LjIKCg== --------------0oRR7QaIvP5jl1d3trXh5pcs-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 03:52:03 2022 Received: (at 59831) by debbugs.gnu.org; 5 Dec 2022 08:52:03 +0000 Received: from localhost ([127.0.0.1]:34708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27Ck-0001mA-Tu for submit@debbugs.gnu.org; Mon, 05 Dec 2022 03:52:03 -0500 Received: from out-162.mta0.migadu.com ([91.218.175.162]:46475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27Cg-0001ll-Mm for 59831@debbugs.gnu.org; Mon, 05 Dec 2022 03:52:02 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670230316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NdjN/S9VNooD3U2hZE5K+1KkXT/Rly1w/vq/lZ+N4h0=; b=pVgG/iGux/Wr9BKmr1DQ84giysDlEST2jFNVsYSPxEW72ST7BVJrbHy2Y44EEf+LO+haXg uAnt3twQVpJqELgrnGL5FxS5dLhBBvqqznypP7Y1eGq0q2NZDBNvIvdaIzJR5lUPoofvkf yYZyiMjGW3U5FxNw/aIEez810s3g/3Kfruc57v6dHUmlOKUz+trYXCrJlRTAkoeKR5f0Sl jlnu2Ew2k00KtNuFY+oSImRbn7LM4nPwvcJ5Rco92dmhGZI9So34ufCcb0LsUOR/AFJoUh oYxLCdCr95YpxraOopZB7hxsonLuhSOMc1SeF8tiWEkIb7HUX8R3RHtuudYjdg== From: Theodor Thornhill To: 59831@debbugs.gnu.org Subject: Re: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified In-Reply-To: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> Date: Mon, 05 Dec 2022 09:51:55 +0100 Message-ID: <87v8mqxmfo.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59831 Cc: jostein@kjonigsen.net, casuri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > When I create or use a class in a Typescript-file, I often have=20 > properties and field declarations. > > These are all fontified using default-face, instead of=20 > font-lock-property-face. > > Also when creating new objects using bracket syntac { key: value, key:=20 > value, etc: etc }, default-face is used. > > Attached is a patch which improves fontification of these aspects in=20 > both typescript-ts-mode and typescript-tsx-mode. > > It also contains code to further improve fontification of=20 > retuen-statements, which IMO is a little bit lacking. > LGTM :) Yuan, feel free to apply when you have some free time! > From 3bcbd89cc43c6ad7885f11aa4c7c92ebd600a164 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D > Date: Mon, 5 Dec 2022 09:31:58 +0100 > Subject: [PATCH] lisp/progmodes/typescript-ts-mode: improve fontification > > - syntax-highlight property and field definitions in class declaration. > - syntax-highlight property-keys in object initializaters. > - syntax-highlight variable-names in function/method return-statements. > --- > lisp/progmodes/typescript-ts-mode.el | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typesc= ript-ts-mode.el > index 48ac1169fe8..48d3c084b6e 100644 > --- a/lisp/progmodes/typescript-ts-mode.el > +++ b/lisp/progmodes/typescript-ts-mode.el > @@ -213,7 +213,9 @@ typescript-ts-mode--font-lock-settings > parameters: > [(_ (identifier) @font-lock-variable-name-face) > (_ (_ (identifier) @font-lock-variable-name-face)) > - (_ (_ (_ (identifier) @font-lock-variable-name-face)))])) > + (_ (_ (_ (identifier) @font-lock-variable-name-face)))]) > + > + (return_statement (identifier) @font-lock-variable-name-face)) >=20=20 > :language language > :override t > @@ -282,7 +284,14 @@ typescript-ts-mode--font-lock-settings > :language language > :override t > :feature 'property > - `((pair value: (identifier) @font-lock-variable-name-face) > + `((property_signature > + name: (property_identifier) @font-lock-property-face) > + (public_field_definition > + name: (property_identifier) @font-lock-property-face) > + > + (pair key: (property_identifier) @font-lock-variable-name-face) > + > + (pair value: (identifier) @font-lock-variable-name-face) >=20=20 > ((shorthand_property_identifier) @font-lock-property-face) >=20=20 Thanks! Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 04:05:40 2022 Received: (at 59831) by debbugs.gnu.org; 5 Dec 2022 09:05:40 +0000 Received: from localhost ([127.0.0.1]:34780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27Pv-0001u2-Ov for submit@debbugs.gnu.org; Mon, 05 Dec 2022 04:05:40 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:60373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27Pu-0001tv-8H for 59831@debbugs.gnu.org; Mon, 05 Dec 2022 04:05:39 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D81015C008B; Mon, 5 Dec 2022 04:05:32 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 05 Dec 2022 04:05:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1670231132; x=1670317532; bh=VH/nDz3VAWcrL2QoSVwJOwlR/y3Iz0iYXHo lXmRS72M=; b=CJ0GGh/OHfCY8tI5EmHiLtqaSA6GI6EfPgWyWiAZ6l8XncngJwU poqnHFRf2VTedRVjmQGQ31ZBweYnXZhWFjRsPG7WugosWRLgA/3Fv+yI71NVXpks zmv83hDk++8mKBBURF25yn9HEQ6CerKaUiNyU2oRfkHQTBvKRnZ6wYWnHZDqldtX HAh48Y2we1rM0HyB29qd6f58gyBocd9Wzxue8duZ+9cAEn8KUgC5a/naNmBTeg+P YlwdiYXfKj/K6IE+ZF9L9Ifrp7VhHchtqftAoDOJR/GDGDUzWXllcj0tc77K6NlR 1IuEiuTil89EcX8RRvUCLswpcNQBkxMBlnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1670231132; x=1670317532; bh=VH/nDz3VAWcrL 2QoSVwJOwlR/y3Iz0iYXHolXmRS72M=; b=sinxQMBFhENHGx6e24U2DUs9w/OnY JB0k18dI5hvavYpuucniaCJX1gfvuddhP1caSv6prU3hzDtKTKwpdgd1eiY+tdwa Yv2SXQlygAWiK9O/OTNVWuKzw8cfKG9h+w2SaFnsWGJeWo1ObkQS+ugu4UTV6UrB EDV/U+p//Tjk+g+XdLjmg9AoT74FuZrt/h77o/esYvaTtKsq5fs69EbEAFgDFXeb OZM5ag/0fpJ+S1EqwEzWKsQIlFsOgyJxByVhH0S8KVK+3fzs8O8nwROJBHcQgSQ0 NIo4clxTHQNewp/Nn4yN7bUYu565KfhFA06aoiGBbQbWYbWoJLXxKl4FQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh eptgfkffggfghruffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhsthgvihhn ucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvg hnrdhnvghtqeenucggtffrrghtthgvrhhnpeevteevvedvffduheekudetledtffeuudet uedtveelffdvtdetuddtleelveduleenucffohhmrghinhepkhhjnhhighhsvghnrdhnoh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhs thgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Dec 2022 04:05:31 -0500 (EST) Content-Type: multipart/mixed; boundary="------------kNaHaaLH7RbVISibYpXji0KE" Message-ID: <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> Date: Mon, 5 Dec 2022 10:05:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Content-Language: nb-NO To: Theodor Thornhill , 59831@debbugs.gnu.org References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87v8mqxmfo.fsf@thornhill.no> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831 Cc: jostein@kjonigsen.net, casuri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------kNaHaaLH7RbVISibYpXji0KE Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Attached is another patch with some further improvements. These too OK with you, Theodor? -- Jostein jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 05.12.2022 09:51, Theodor Thornhill wrote: > Jostein Kjønigsen writes: > >> When I create or use a class in a Typescript-file, I often have >> properties and field declarations. >> >> These are all fontified using default-face, instead of >> font-lock-property-face. >> >> Also when creating new objects using bracket syntac { key: value, key: >> value, etc: etc }, default-face is used. >> >> Attached is a patch which improves fontification of these aspects in >> both typescript-ts-mode and typescript-tsx-mode. >> >> It also contains code to further improve fontification of >> retuen-statements, which IMO is a little bit lacking. >> > LGTM :) Yuan, feel free to apply when you have some free time! > >> From 3bcbd89cc43c6ad7885f11aa4c7c92ebd600a164 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= >> Date: Mon, 5 Dec 2022 09:31:58 +0100 >> Subject: [PATCH] lisp/progmodes/typescript-ts-mode: improve fontification >> >> - syntax-highlight property and field definitions in class declaration. >> - syntax-highlight property-keys in object initializaters. >> - syntax-highlight variable-names in function/method return-statements. >> --- >> lisp/progmodes/typescript-ts-mode.el | 13 +++++++++++-- >> 1 file changed, 11 insertions(+), 2 deletions(-) >> >> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el >> index 48ac1169fe8..48d3c084b6e 100644 >> --- a/lisp/progmodes/typescript-ts-mode.el >> +++ b/lisp/progmodes/typescript-ts-mode.el >> @@ -213,7 +213,9 @@ typescript-ts-mode--font-lock-settings >> parameters: >> [(_ (identifier) @font-lock-variable-name-face) >> (_ (_ (identifier) @font-lock-variable-name-face)) >> - (_ (_ (_ (identifier) @font-lock-variable-name-face)))])) >> + (_ (_ (_ (identifier) @font-lock-variable-name-face)))]) >> + >> + (return_statement (identifier) @font-lock-variable-name-face)) >> >> :language language >> :override t >> @@ -282,7 +284,14 @@ typescript-ts-mode--font-lock-settings >> :language language >> :override t >> :feature 'property >> - `((pair value: (identifier) @font-lock-variable-name-face) >> + `((property_signature >> + name: (property_identifier) @font-lock-property-face) >> + (public_field_definition >> + name: (property_identifier) @font-lock-property-face) >> + >> + (pair key: (property_identifier) @font-lock-variable-name-face) >> + >> + (pair value: (identifier) @font-lock-variable-name-face) >> >> ((shorthand_property_identifier) @font-lock-property-face) >> > Thanks! > > Theo --------------kNaHaaLH7RbVISibYpXji0KE Content-Type: text/x-patch; charset=UTF-8; name="0002-lisp-progmodes-typescript-ts-mode-Improve-fontificat.patch" Content-Disposition: attachment; filename*0="0002-lisp-progmodes-typescript-ts-mode-Improve-fontificat.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0NDFiMjM0MGYwYThkOWJmMjdiMGRiY2I5ODUwNTFjODQ2NzJmNDFmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogTW9uLCA1IERlYyAyMDIyIDEw OjAwOjE1ICswMTAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIGxpc3AvcHJvZ21vZGVzL3R5cGVz Y3JpcHQtdHMtbW9kZTogSW1wcm92ZSBmb250aWZpY2F0aW9ucwogb2YgdmFyaWFibGVzIGlu IHVzZS4KCi0tLQogbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIHwgNyAr KysrKystCiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsIGIv bGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmluZGV4IDQ4ZDNjMDg0YjZl Li4zZGE2OTA1NjdlMiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10 cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3JpcHQtdHMtbW9kZS5lbApA QCAtMjE1LDcgKzIxNSwxMiBAQCB0eXBlc2NyaXB0LXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0 aW5ncwogICAgICAgIChfIChfIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkpCiAgICAgICAgKF8gKF8gKF8gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFy aWFibGUtbmFtZS1mYWNlKSkpXSkKIAotICAgICAocmV0dXJuX3N0YXRlbWVudCAoaWRlbnRp ZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQorICAgICAocmV0dXJuX3N0 YXRlbWVudCAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisK KyAgICAgKGJpbmFyeV9leHByZXNzaW9uIGxlZnQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXZhcmlhYmxlLW5hbWUtZmFjZSkKKyAgICAgKGJpbmFyeV9leHByZXNzaW9uIHJpZ2h0OiAo aWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKGFy Z3VtZW50cyAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpKQog CiAgICA6bGFuZ3VhZ2UgbGFuZ3VhZ2UKICAgIDpvdmVycmlkZSB0Ci0tIAoyLjM3LjIKCg== --------------kNaHaaLH7RbVISibYpXji0KE-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 04:24:57 2022 Received: (at 59831) by debbugs.gnu.org; 5 Dec 2022 09:24:57 +0000 Received: from localhost ([127.0.0.1]:34863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27ib-00023C-47 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 04:24:57 -0500 Received: from out2.migadu.com ([188.165.223.204]:47392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p27iY-000236-PD for 59831@debbugs.gnu.org; Mon, 05 Dec 2022 04:24:56 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670232290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p5BFUwuhmtM1gInE+J8tg0ahMv69OGNYEBPcNrwX+SA=; b=rDv5ZcE5wLNdGJBZt/JC2MZE4T/DiPydGvv/bm876BL9rZY5oswQcRE9LGYbyXZkfLm8Yd GA2vMwc7aYiWSyOM8fuqJzVFLekoGszkX/G7q7tOOeh6/QHQOcKGQ+LuWYLaTQx8+9Qlh/ ZfAZKhIR7AoyKgkDN37MONVwJ24a2qBqP00mSHlIo9LGVn7TMmvNqPBg9WIEoPhfGhbc7m 17Pmx+NWMklBruQUgLHKGkLfE7oTkTkO/J+KeAtZfIAKC9DeaAo75HE4fhWSUDqz0jHCH4 CG83DoW2yfpIgR6LYpn+RR2oXXwUUIpCjzGex9X+0oY8qsbh1OWDJnu/nEgjfg== From: Theodor Thornhill To: Jostein =?utf-8?Q?Kj=C3=B8nigsen?= , 59831@debbugs.gnu.org Subject: Re: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified In-Reply-To: <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> Date: Mon, 05 Dec 2022 10:24:48 +0100 Message-ID: <87bkoifbj3.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59831 Cc: jostein@kjonigsen.net, casuri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Attached is another patch with some further improvements. > > These too OK with you, Theodor? > Yep! > From 441b2340f0a8d9bf27b0dbcb985051c84672f41f Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D > Date: Mon, 5 Dec 2022 10:00:15 +0100 > Subject: [PATCH 2/2] lisp/progmodes/typescript-ts-mode: Improve fontifica= tions > of variables in use. > > --- > lisp/progmodes/typescript-ts-mode.el | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typesc= ript-ts-mode.el > index 48d3c084b6e..3da690567e2 100644 > --- a/lisp/progmodes/typescript-ts-mode.el > +++ b/lisp/progmodes/typescript-ts-mode.el > @@ -215,7 +215,12 @@ typescript-ts-mode--font-lock-settings > (_ (_ (identifier) @font-lock-variable-name-face)) > (_ (_ (_ (identifier) @font-lock-variable-name-face)))]) >=20=20 > - (return_statement (identifier) @font-lock-variable-name-face)) > + (return_statement (identifier) @font-lock-variable-name-face) > + > + (binary_expression left: (identifier) @font-lock-variable-name-face) > + (binary_expression right: (identifier) @font-lock-variable-name-fac= e) > + > + (arguments (identifier) @font-lock-variable-name-face)) >=20=20 > :language language > :override t > --=20 > 2.37.2 Theo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 05 15:13:15 2022 Received: (at 59831) by debbugs.gnu.org; 5 Dec 2022 20:13:15 +0000 Received: from localhost ([127.0.0.1]:38109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hpz-00012b-Jl for submit@debbugs.gnu.org; Mon, 05 Dec 2022 15:13:15 -0500 Received: from mail-pf1-f170.google.com ([209.85.210.170]:41585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Hpx-00012S-VX; Mon, 05 Dec 2022 15:13:14 -0500 Received: by mail-pf1-f170.google.com with SMTP id 130so12477455pfu.8; Mon, 05 Dec 2022 12:13:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VjC9BfCqIB1vImeQQtNGEEMzXXTAWMFiGLak/1q5aMA=; b=nT1tbaAxV9deYZVGwy3ApNPYV3nvGyFV4ATpoHVHIl4WMX8gIHsrqqicONZb1fmgJ5 lf3bh/vgAVPi7BQHL1Kp1VKhTWNwiPIT+KCaK2DdT8mc+TdJP5KxngkGhAJplSoph4Ht lY4gnLkCKt+aQnKhsEkvYu7mySiHs1IA0yUCd3l+baK2o87fovzsZ4y7/GAGZDQ+nDL5 EhCYsQ6DtDrZfc/HImJ5eNaDMyqK+qphC6U3tFKPnW07dH36dcLaxRJdpWW0wT3wSmaY ihmiUKvsnMzbjR4wIh+nCS3ZoHEjYly/kQVn/Co6ICvpWWm2gDF0LaomxFrGRtAZ8SVS d0AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VjC9BfCqIB1vImeQQtNGEEMzXXTAWMFiGLak/1q5aMA=; b=WgkxGTmfnzSnQ80Xuz1PhgJPfVnHXSmafzpezxDnvZMEeflg7iWoLTq/t9hXK6ei+Q Q/rvb3lzhCdzwStQ4X2alLB6XLMVsNRIR1dway/4Fm6M/JuAj5Dd3a0vLxhkkl/MDghC LLzpZ5kHqDVAGWbyz2BtWfmooQ6mgMIqbT6Dlg/0NFtiTd5Df3/yCIeXF5gI0aV/dajP 5UesK6YT73ukCT/+T1JFlDP4m+/pBK6SwpGXhbtdpPnx94CgrqrJvTtEkrzGy/ZUYTFU HwH0JwaRiLjZ8BeXrPbfSC6/6LqEl3OBCNu5K3SVH6uDJbVvks33HkP8CPY6vX7CAco/ 3Xtg== X-Gm-Message-State: ANoB5pm9M2DMzVm8AsBFLDDctF1CvYvkAH5LYdXILWFJZoOErn9Eh8dE mjQdsqiDSVJD1TPl/Ay8wsk= X-Google-Smtp-Source: AA0mqf6oTXE+ARj+rWhFKXqjxlDj+WVR8/CfPgovFqBYa/dTAlRDZP1gnLgMrRqodsqd6PGbNALrsg== X-Received: by 2002:a63:fc1b:0:b0:46f:fea7:4816 with SMTP id j27-20020a63fc1b000000b0046ffea74816mr57783852pgi.532.1670271188043; Mon, 05 Dec 2022 12:13:08 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id u64-20020a626043000000b005751f455e0esm10241552pfb.120.2022.12.05.12.13.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Dec 2022 12:13:07 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified From: Yuan Fu In-Reply-To: <87bkoifbj3.fsf@thornhill.no> Date: Mon, 5 Dec 2022 12:13:05 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831-done@debbugs.gnu.org, 59831@debbugs.gnu.org, casuri@gmail.com, =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= , jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU = Emacs, the Swiss army knife of text editors = wrote: >=20 > Jostein Kj=C3=B8nigsen writes: >=20 >> Attached is another patch with some further improvements. >>=20 >> These too OK with you, Theodor? >>=20 >=20 > Yep! I squashed the two commits and applied them, Thanks! Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 04:25:09 2022 Received: (at 59831) by debbugs.gnu.org; 7 Dec 2022 09:25:09 +0000 Received: from localhost ([127.0.0.1]:48765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qft-0001OT-7C for submit@debbugs.gnu.org; Wed, 07 Dec 2022 04:25:09 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:43771) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qfq-0001O1-B1 for 59831@debbugs.gnu.org; Wed, 07 Dec 2022 04:25:07 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1A6EE32009A5; Wed, 7 Dec 2022 04:25:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 07 Dec 2022 04:25:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1670405099; x=1670491499; bh=kOCKF1ouurffjE8WIlHyc8Vl+0plBqIMSx8 NCEVVCYc=; b=uuD03lDDZve/0QT0BKaYiw241cn9zf+h7ibe12PjRwQgnT4mpJf 7f9UW6MJejoTU/XT4VevdSpxBMdZqirdOsXsGWZxAkKMhoXEjDCbMfXJH7jeGfqW jT5T/Gzwao3PSASPKFk8BblyJRE+7fWPfg954HRHFUiPnPZ5fSmNYCF/tGmmtJJg 8GwXK/ZSL0FohxP/8pDeQx+viFWuM3HnWP2o2nC1eLJTFV7WnqymL5v++gkdpLLe 0C68GK6wK+WAOmcHyWl6GcoObsK50jr8TC3gYIwvWfVbLEwDvrNTHajlj336GJ6O lJpEUaXN34NNFLwF+HRoqKU9oln7ux8ylUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1670405099; x=1670491499; bh=kOCKF1ouurffj E8WIlHyc8Vl+0plBqIMSx8NCEVVCYc=; b=nfKOJRicReA0Aogsg24jvWJlRYTXq 2GVPvci2eglbuPHFcUG73WOcPcg1TkDfr/g5m/ec+YAFS1Veh0/XOoJy9oFyoOWN 0QOz4JnQyTq0jmKmqgSlCLhnPEVC4aSa/SNPLPvDTWZE2Oo/RqsgIjSu6clJD/tg Z6lm88ZURX/IQU6fOtc8YdK+a9ouvFJypR00+xIxCH1WyZ6ASZZVWNgx0nDIN803 mibC8bCAYs0066CKwUhu5GEY1j1ejNZBUtQxN8t2FuKQ+BW8BEs4iM7HPJxFhrms UcJRPe5wWVjxMezEHgD4/vt3qX3DGXJiYPfLY9vv6gl6kxB3IJnCcujlg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleffffdt feevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 04:24:58 -0500 (EST) Content-Type: multipart/mixed; boundary="------------qh9oCXXieqapk4mBkOp34ePl" Message-ID: <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> Date: Wed, 7 Dec 2022 10:24:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Content-Language: nb-NO To: Yuan Fu , Theodor Thornhill References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------qh9oCXXieqapk4mBkOp34ePl Content-Type: multipart/alternative; boundary="------------wWbDOqTvrG6BUiwRDBcq08lX" --------------wWbDOqTvrG6BUiwRDBcq08lX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hey everyone. I'd like to add one more change to this particular bug, which makes fontification of variables more consistent when used in other expressions and statements. Please see attached patch. In short this patch changes the following: * fontifies property-access in general expressions * fontifies variables and property-access in if-expressions -- Jostein On 05.12.2022 21:13, Yuan Fu wrote: > >> On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: >> >> Jostein Kjønigsen writes: >> >>> Attached is another patch with some further improvements. >>> >>> These too OK with you, Theodor? >>> >> Yep! > I squashed the two commits and applied them, Thanks! > > Yuan --------------wWbDOqTvrG6BUiwRDBcq08lX Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hey everyone.

I'd like to add one more change to this particular bug, which makes fontification of variables more consistent when used in other expressions and statements.

Please see attached patch.

In short this patch changes the following:

  • fontifies property-access in general expressions
  • fontifies variables and property-access in if-expressions

--
Jostein

On 05.12.2022 21:13, Yuan Fu wrote:


On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:

Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:


Attached is another patch with some further improvements.

These too OK with you, Theodor?


Yep!

I squashed the two commits and applied them, Thanks!

Yuan
--------------wWbDOqTvrG6BUiwRDBcq08lX-- --------------qh9oCXXieqapk4mBkOp34ePl Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwODE3YTlhOWNlMDBiZjQ0ZTYzNjhhM2Q3NDI2MmY4M2U0OWViYmYzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogV2VkLCA3IERlYyAyMDIyIDA5 OjI3OjQyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsOiBJbXByb3ZlIGZvbnRpZmljYXRpb24KIG9mIHZhcmlhYmxlcwoKLS0t CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCA0MyArKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmlu ZGV4IDNkYTY5MDU2N2UyLi4zM2YzMzJkNjZkNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9k ZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp cHQtdHMtbW9kZS5lbApAQCAtMjIwLDcgKzIyMCwzMiBAQCB0eXBlc2NyaXB0LXRzLW1vZGUt LWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAoYmluYXJ5X2V4cHJlc3Npb24gbGVmdDogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogICAgICAoYmluYXJ5 X2V4cHJlc3Npb24gcmlnaHQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkKIAotICAgICAoYXJndW1lbnRzIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisgICAgIChhcmd1bWVudHMgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYXJlbnRoZXNpemVkX2V4cHJl c3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkKKwor ICAgOmxhbmd1YWdlIGxhbmd1YWdlCisgICA6b3ZlcnJpZGUgdAorICAgOmZlYXR1cmUgJ3By b3BlcnR5CisgICBgKChwcm9wZXJ0eV9zaWduYXR1cmUKKyAgICAgIG5hbWU6IChwcm9wZXJ0 eV9pZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgIChwdWJsaWNf ZmllbGRfZGVmaW5pdGlvbgorICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBm b250LWxvY2stcHJvcGVydHktZmFjZSkKKyAgICAgKG1lbWJlcl9leHByZXNzaW9uCisgICAg ICBvYmplY3Q6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5hbWUtZmFjZQor ICAgICAgcHJvcGVydHk6IChfKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgICht ZW1iZXJfZXhwcmVzc2lvbgorICAgICAgb2JqZWN0OiAodGhpcykgQGZvbnQtbG9jay1rZXl3 b3JkLWZhY2UKKyAgICAgIHByb3BlcnR5OiAoXykgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNl KQorCisgICAgIChwYWlyIGtleTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2st dmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYWlyIHZhbHVlOiAoaWRlbnRpZmllcikg QGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKChzaG9ydGhhbmRfcHJv cGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgICgo c2hvcnRoYW5kX3Byb3BlcnR5X2lkZW50aWZpZXJfcGF0dGVybikKKyAgICAgIEBmb250LWxv Y2stcHJvcGVydHktZmFjZSkpCiAKICAgIDpsYW5ndWFnZSBsYW5ndWFnZQogICAgOm92ZXJy aWRlIHQKQEAgLTI4NiwyMiArMzExLDggQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1mb250LWxv Y2stc2V0dGluZ3MKICAgIDpvdmVycmlkZSB0CiAgICAnKChlc2NhcGVfc2VxdWVuY2UpIEBm b250LWxvY2stZXNjYXBlLWZhY2UpCiAKLSAgIDpsYW5ndWFnZSBsYW5ndWFnZQotICAgOm92 ZXJyaWRlIHQKLSAgIDpmZWF0dXJlICdwcm9wZXJ0eQotICAgYCgocHJvcGVydHlfc2lnbmF0 dXJlCi0gICAgICBuYW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlKQotICAgICAocHVibGljX2ZpZWxkX2RlZmluaXRpb24KLSAgICAgIG5hbWU6 IChwcm9wZXJ0eV9pZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAKLSAg ICAgKHBhaXIga2V5OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJs ZS1uYW1lLWZhY2UpCi0KLSAgICAgKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXZhcmlhYmxlLW5hbWUtZmFjZSkKLQotICAgICAoKHNob3J0aGFuZF9wcm9wZXJ0eV9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCi0KLSAgICAgKChzaG9ydGhh bmRfcHJvcGVydHlfaWRlbnRpZmllcl9wYXR0ZXJuKQotICAgICAgQGZvbnQtbG9jay1wcm9w ZXJ0eS1mYWNlKSkpKQorICAgKSkKIAogOzs7IyMjYXV0b2xvYWQKIChhZGQtdG8tbGlzdCAn YXV0by1tb2RlLWFsaXN0ICcoIlxcLnRzXFwnIiAuIHR5cGVzY3JpcHQtdHMtbW9kZSkpCi0t IAoyLjM3LjIKCg== --------------qh9oCXXieqapk4mBkOp34ePl-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 04:33:36 2022 Received: (at 59831) by debbugs.gnu.org; 7 Dec 2022 09:33:36 +0000 Received: from localhost ([127.0.0.1]:48831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qo3-0001VC-Lm for submit@debbugs.gnu.org; Wed, 07 Dec 2022 04:33:36 -0500 Received: from out2.migadu.com ([188.165.223.204]:24442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qo1-0001V6-Jb for 59831@debbugs.gnu.org; Wed, 07 Dec 2022 04:33:35 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670405611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g1qceIBsGnO1eL2MkHtjEZKI/MfCRliA9b9lfvtamQg=; b=HdMNz3y+3HtEcSDng2qsVfMBaF8ieXGMfJMyXIMqaY1/yplV8eqnxnaS0+KkkGaBQsggD9 /39wgPfvucCTA5lMF35EWxs3ZHX91QD5Jro4uMwVTvYRCtfSB1xO3kPJMHyT8Cfe6e4R49 9+teET1QNAOPVy0u/3R3TnQ9fS1JrXhOlKjN5vAaEVwO9OfkzSviDoeSkTpczsm7/bdVJR /91xtGwkvmNiz6zavVrkEAxe/34fvvw3xYCshj1/yiBdAlFPQg84CAGRxqfRdOc6ilGKMP hJgs+k8OmiT8mRzI1IGQPcMqfc4Orov9tBvEzfQhj4Sc90wmFtolreSPxy3NDQ== From: Theodor Thornhill To: jostein@kjonigsen.net, Yuan Fu Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified In-Reply-To: <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> Date: Wed, 07 Dec 2022 10:33:29 +0100 Message-ID: <87mt7zzhg6.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein Kj=C3=B8nigsen writes: > Hey everyone. > > I'd like to add one more change to this particular bug, which makes=20 > fontification of variables more consistent when used in other=20 > expressions and statements. > > Please see attached patch. > > In short this patch changes the following: > > * fontifies property-access in general expressions > * fontifies variables and property-access in if-expressions > > -- > Jostein > > On 05.12.2022 21:13, Yuan Fu wrote: >> >>> On Dec 5, 2022, at 1:24 AM, Theodor Thornhill via Bug reports for GNU E= macs, the Swiss army knife of text editors wrote: >>> >>> Jostein Kj=C3=B8nigsen writes: >>> >>>> Attached is another patch with some further improvements. >>>> >>>> These too OK with you, Theodor? >>>> >>> Yep! >> I squashed the two commits and applied them, Thanks! >> >> Yuan > From 0817a9a9ce00bf44e6368a3d74262f83e49ebbf3 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Jostein=3D20Kj=3DC3=3DB8nigsen?=3D > Date: Wed, 7 Dec 2022 09:27:42 +0100 > Subject: [PATCH] lisp/progmodes/typescript-ts-mode.el: Improve fontificat= ion > of variables > > --- > lisp/progmodes/typescript-ts-mode.el | 43 +++++++++++++++++----------- > 1 file changed, 27 insertions(+), 16 deletions(-) > > diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typesc= ript-ts-mode.el > index 3da690567e2..33f332d66d6 100644 > --- a/lisp/progmodes/typescript-ts-mode.el > +++ b/lisp/progmodes/typescript-ts-mode.el > @@ -220,7 +220,32 @@ typescript-ts-mode--font-lock-settings > (binary_expression left: (identifier) @font-lock-variable-name-face) > (binary_expression right: (identifier) @font-lock-variable-name-fac= e) >=20=20 > - (arguments (identifier) @font-lock-variable-name-face)) > + (arguments (identifier) @font-lock-variable-name-face) > + > + (parenthesized_expression (identifier) @font-lock-variable-name-fac= e)) > + > + :language language > + :override t > + :feature 'property > + `((property_signature > + name: (property_identifier) @font-lock-property-face) > + (public_field_definition > + name: (property_identifier) @font-lock-property-face) > + (member_expression > + object: (identifier) @font-lock-variable-name-face > + property: (_) @font-lock-property-face) > + (member_expression > + object: (this) @font-lock-keyword-face Do we need this (this) here, or could that just go into the keyword feature? Otherwise LGTM. Go ahead and install, Yuan, unless you have something else to add :-) Theo From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 04:42:35 2022 Received: (at 59831) by debbugs.gnu.org; 7 Dec 2022 09:42:35 +0000 Received: from localhost ([127.0.0.1]:48892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qwl-0001bI-1C for submit@debbugs.gnu.org; Wed, 07 Dec 2022 04:42:35 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2qwk-0001bA-1o for 59831@debbugs.gnu.org; Wed, 07 Dec 2022 04:42:34 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 3E7CF320024A; Wed, 7 Dec 2022 04:42:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 07 Dec 2022 04:42:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm3; t= 1670406144; x=1670492544; bh=M+CVXV80ESa2eeuv0g6pAnMDU6wfoG7eeqv mokwcvjE=; b=bAeKhDOaZiFdRRVcgi33l0hycoLa+gipOj9W0jQG6+/S1cEYyR8 tJMDhVcXW8RBsWEuSRWxlDTAWVGcFQpx/7jQGhKn3j/cB7fH0/bMy5HfXf8W7aCR q1LndVCj2XTDtsUO8I+pqrVMRosbWteTt2/K9JjlyrcvQlyy/Cp1oAzx0O73fhG/ OPGOYgov914M9/uXh4JRdjZhIOiUeCU8lPPZbszqWPnbCW9DJh6Jk16EyE4zNvVb lEaUnifivtGy7YpRhW9P4QPKIWasxwJPJsyaAe+UutkED23n4u11ugG29ikJiNMP OKAQYhIacZEV+xw7ccIm4rAko4hqsFWhffg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1670406144; x=1670492544; bh=M+CVXV80ESa2e euv0g6pAnMDU6wfoG7eeqvmokwcvjE=; b=QwZa3MS5GQ4e6S2eDoUFcTCI+PVca lO5ZHy3bBy0RXUlk/fLUeA4yoQXAPqUW23R9Hv9zn6aM0AuM28M9dBjOSWzCLbf3 2BnsLjfYRq8tYqRqWjmDXKNx/ZCV2/THD8SxzK0pv8sogRb/U87FOrpzhygyHb87 jIHfkzv1f7MeGKB3WM88UACKlwS1XSHiYCu2j/SZhKJtFULZ9NPBGD/EvfkNIc3h aNqWhEw5JfOROCrXVo2EPlemxZwWdocrLvmf+xDuy6XsmHGzgiboqIShhe0XCHLn 2rn5dhT5RTLIxn6/AMWLAdgZ173axXYVveVwQwk7t430vY00+vXRUxiUQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudekgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleffffdt feevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhi ghhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Dec 2022 04:42:23 -0500 (EST) Content-Type: multipart/mixed; boundary="------------P00yLdQ52eHovmb8ZNlUwYQO" Message-ID: Date: Wed, 7 Dec 2022 10:42:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Content-Language: nb-NO To: Theodor Thornhill , jostein@kjonigsen.net, Yuan Fu References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <87mt7zzhg6.fsf@thornhill.no> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------P00yLdQ52eHovmb8ZNlUwYQO Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07.12.2022 10:33, Theodor Thornhill wrote: > > Do we need this (this) here, or could that just go into the keyword feature? > > Otherwise LGTM. Go ahead and install, Yuan, unless you have something > else to add :-) > > Theo You're right. We don't. I've cleaned that up in this patch, and also made sure to better support if-statements with negations. See new, attached patch with all changes applied. -- Jostein --------------P00yLdQ52eHovmb8ZNlUwYQO Content-Type: text/x-patch; charset=UTF-8; name="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.patch" Content-Disposition: attachment; filename*0="0001-lisp-progmodes-typescript-ts-mode.el-Improve-fontifi.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmMmY3OWIyYmRlMjE0N2ZkMGZlYmRkZWE2OTZhYjQzYmNjMjU3Yjk2IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogV2VkLCA3IERlYyAyMDIyIDA5 OjI3OjQyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsOiBJbXByb3ZlIGZvbnRpZmljYXRpb24KIG9mIHZhcmlhYmxlcwoKLS0t CiBsaXNwL3Byb2dtb2Rlcy90eXBlc2NyaXB0LXRzLW1vZGUuZWwgfCA0MiArKysrKysrKysr KysrKysrKy0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlw dC10cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCmlu ZGV4IDNkYTY5MDU2N2UyLi5mYzJmNzQ2YTBmNCAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9k ZXMvdHlwZXNjcmlwdC10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL3R5cGVzY3Jp cHQtdHMtbW9kZS5lbApAQCAtMjIwLDcgKzIyMCwzMSBAQCB0eXBlc2NyaXB0LXRzLW1vZGUt LWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAoYmluYXJ5X2V4cHJlc3Npb24gbGVmdDogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQogICAgICAoYmluYXJ5 X2V4cHJlc3Npb24gcmlnaHQ6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxlLW5h bWUtZmFjZSkKIAotICAgICAoYXJndW1lbnRzIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZh cmlhYmxlLW5hbWUtZmFjZSkpCisgICAgIChhcmd1bWVudHMgKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorCisgICAgIChwYXJlbnRoZXNpemVkX2V4cHJl c3Npb24gKGlkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAg ICAocGFyZW50aGVzaXplZF9leHByZXNzaW9uIChfIChpZGVudGlmaWVyKSkgQGZvbnQtbG9j ay12YXJpYWJsZS1uYW1lLWZhY2UpKQorCisgICA6bGFuZ3VhZ2UgbGFuZ3VhZ2UKKyAgIDpv dmVycmlkZSB0CisgICA6ZmVhdHVyZSAncHJvcGVydHkKKyAgIGAoKHByb3BlcnR5X3NpZ25h dHVyZQorICAgICAgbmFtZTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJv cGVydHktZmFjZSkKKyAgICAgKHB1YmxpY19maWVsZF9kZWZpbml0aW9uCisgICAgICBuYW1l OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorICAg ICAobWVtYmVyX2V4cHJlc3Npb24KKyAgICAgIG9iamVjdDogKGlkZW50aWZpZXIpIEBmb250 LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgICAobWVtYmVyX2V4cHJlc3Npb24KKyAg ICAgIHByb3BlcnR5OiAoXykgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgIChw YWlyIGtleTogKHByb3BlcnR5X2lkZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFt ZS1mYWNlKQorCisgICAgIChwYWlyIHZhbHVlOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay12 YXJpYWJsZS1uYW1lLWZhY2UpCisKKyAgICAgKChzaG9ydGhhbmRfcHJvcGVydHlfaWRlbnRp ZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQorCisgICAgICgoc2hvcnRoYW5kX3By b3BlcnR5X2lkZW50aWZpZXJfcGF0dGVybikKKyAgICAgIEBmb250LWxvY2stcHJvcGVydHkt ZmFjZSkpCiAKICAgIDpsYW5ndWFnZSBsYW5ndWFnZQogICAgOm92ZXJyaWRlIHQKQEAgLTI4 NiwyMiArMzEwLDggQEAgdHlwZXNjcmlwdC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MK ICAgIDpvdmVycmlkZSB0CiAgICAnKChlc2NhcGVfc2VxdWVuY2UpIEBmb250LWxvY2stZXNj YXBlLWZhY2UpCiAKLSAgIDpsYW5ndWFnZSBsYW5ndWFnZQotICAgOm92ZXJyaWRlIHQKLSAg IDpmZWF0dXJlICdwcm9wZXJ0eQotICAgYCgocHJvcGVydHlfc2lnbmF0dXJlCi0gICAgICBu YW1lOiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKQot ICAgICAocHVibGljX2ZpZWxkX2RlZmluaXRpb24KLSAgICAgIG5hbWU6IChwcm9wZXJ0eV9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCiAKLSAgICAgKHBhaXIga2V5 OiAocHJvcGVydHlfaWRlbnRpZmllcikgQGZvbnQtbG9jay12YXJpYWJsZS1uYW1lLWZhY2Up Ci0KLSAgICAgKHBhaXIgdmFsdWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlhYmxl LW5hbWUtZmFjZSkKLQotICAgICAoKHNob3J0aGFuZF9wcm9wZXJ0eV9pZGVudGlmaWVyKSBA Zm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCi0KLSAgICAgKChzaG9ydGhhbmRfcHJvcGVydHlf aWRlbnRpZmllcl9wYXR0ZXJuKQotICAgICAgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKSkp KQorICAgKSkKIAogOzs7IyMjYXV0b2xvYWQKIChhZGQtdG8tbGlzdCAnYXV0by1tb2RlLWFs aXN0ICcoIlxcLnRzXFwnIiAuIHR5cGVzY3JpcHQtdHMtbW9kZSkpCi0tIAoyLjM3LjIKCg== --------------P00yLdQ52eHovmb8ZNlUwYQO-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 02:53:13 2022 Received: (at 59831) by debbugs.gnu.org; 12 Dec 2022 07:53:14 +0000 Received: from localhost ([127.0.0.1]:51203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4dcf-0001uP-Kt for submit@debbugs.gnu.org; Mon, 12 Dec 2022 02:53:13 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4dcd-0001uJ-P1 for 59831@debbugs.gnu.org; Mon, 12 Dec 2022 02:53:12 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 67A385C0088; Mon, 12 Dec 2022 02:53:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 12 Dec 2022 02:53:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1670831586; x=1670917986; bh=5u P2yNecCQqKqzL7pD//T8uEAiCQOCJWCzCBhJXr/QU=; b=q/3e+w7eR2jubYx0Q/ 9Lqy2LIPycwAVs7SeNpu6E6lEbq5dAistDBTU7lOo/x5njG6H7FmrrKGBurDVgZv QKWFDMubqrp/eZfVuwoRuIR29GW6YugQHKlRNKf4VKfk3oSWksZ/CfJqXvZPo0ou 8s0hw0t/o3lbvN7dxaTUpHDxI8KCAs2h+912l6u/8OyGy2MdDK/+2HoeacelS08D E+B+VQOt2Jo7Vq0pwkSZZH3o9/zqbquJaOtLbYikZdEf6319ddPUFC3yPmwa67Vp o850p6ahoqpdQRiq7o4V3KUnD4x1dYQy1fUe5JZ4DHSoakPNI+kJ0NDFwLn8VLRS xAog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1670831586; x=1670917986; bh=5uP2yNecCQqKqzL7pD//T8uEAiCQOCJWCzC BhJXr/QU=; b=FL9ahQSKO6Z6iSGRvMpzF2jsV7SKZ+YG/K+JHBgCSESDfr792CB 8ZAWz4aLZhHJbsPEuEzyQ6o32GHMp14luKBzUIvxYin3+E4X06JcIF/0pTZJWOd5 08Wk3J+yoLUJNYV3Bgr4+4YBjvqKGb0hADot/ZjrkiYCbWMUTFanXpNHOF5v0EHa 28BLODHOX6uUym6PbK3ioCxBRylhz3njhD4Lz3HxTHi36Cnz14VKwTnbAYhDQYwf ugbq0zM5pEWJ1B71crXdS3Gqop+eKz60NRJqWadztfbM9mqa+fvuEDjCPKGHQXrf v7QPiWkQ9tUQUfmARTfgQx9m6YmfuLvqAhw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuhffvvehfjggtgfesthekredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepheeuhefhiefhlefggfekteeu gedvkeduleduueektdfgjeffledvkeelvddvvddunecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 12 Dec 2022 02:53:05 -0500 (EST) Message-ID: <2a8ecd09-6b69-e128-1fe9-3f715b1efd3d@secure.kjonigsen.net> Date: Mon, 12 Dec 2022 08:53:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Content-Language: nb-NO From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Theodor Thornhill , jostein@kjonigsen.net, Yuan Fu References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 07.12.2022 10:42, Jostein Kjønigsen wrote: > On 07.12.2022 10:33, Theodor Thornhill wrote: >> >> Do we need this (this) here, or could that just go into the keyword >> feature? >> >> Otherwise LGTM.  Go ahead and install, Yuan, unless you have something >> else to add :-) >> >> Theo > > You're right. We don't. I've cleaned that up in this patch, and also > made sure to better support if-statements with negations. > > See new, attached patch with all changes applied. > > -- > Jostein Looking at my local emacs-29 branch, this patch seems not to have been applied yet. Could you take a look and get it installed, Yuan? -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 13:46:19 2022 Received: (at 59831) by debbugs.gnu.org; 14 Dec 2022 18:46:19 +0000 Received: from localhost ([127.0.0.1]:40929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Wln-0006RE-3W for submit@debbugs.gnu.org; Wed, 14 Dec 2022 13:46:19 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:49599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Wll-0006R8-7d for 59831@debbugs.gnu.org; Wed, 14 Dec 2022 13:46:17 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 052EA5C0042; Wed, 14 Dec 2022 13:46:12 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 14 Dec 2022 13:46:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm1; t=1671043572; x=1671129972; bh=11 AAOafiAafLZwEQyn1mCu4kk7I6DTHzFbx6jlNxONs=; b=l+MXuluy8rxO62zByO mkIDdcl0WJRBq1s+aHZLA8Dk1+L3cVmZ8wd6gXRY/s8lKo8x4Yvxqm27qrpsPhV6 Ga1fcR/RTt1axzdLQaFa66Adr7vy43jnMzR3bP1K71Kp9zovuOO86pQS0jswevz2 IgzO5EkyYl0+O1fJrluzw4/AANmA68myoXP/PxPfVsObhwulGvcpj21x58lYU+p6 qAUv7DL6gpAb4c21oQhrDkhJ/JGvyvJz5LKPvF1LeF9yGF/V/Nl9Snm6WeQRbzbA Yaa8qMjxKG7K2rTaqHjww6N0N99S0Zdx/A6H2egmVHfydweKZi2+Ozrsg5NXAi6z FQgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1671043572; x=1671129972; bh=11AAOafiAafLZwEQyn1mCu4kk7I6DTHzFbx 6jlNxONs=; b=JCwkep0JQ4bHiazxb+RjcCDa+lObNX1T3FGG5NaQIasIZJISmWi MRYaurvK2odZUZCe48bLFzxVvl2ymFrjXrmWKyEGkkUU/jjHIcmkFMYMdh07YfxS ZMMo1k1TKB3O7pqiMpekI6QwCMJ/NYb2ZIuz7abXN/QahZaRxyJ3qxUkv9tkPI4J lEF0Cu4vKvzM4fgKaQN86+9ubN+QCt0grDpa0o2SU6Ys0KH84yd24PRT13mh/BII JRwpR1m8Y3zo6mHYS8rCk4Glk942fLAOfawTprdxMG5xqQUwESN0KcwbLKyPAxG9 DxlNbKQYAYZKekrUOvOFtm83l1UxZH5paHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuhffvvehfjggtgfesthekredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepheeuhefhiefhlefggfekteeu gedvkeduleduueektdfgjeffledvkeelvddvvddunecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 13:46:11 -0500 (EST) Message-ID: Date: Wed, 14 Dec 2022 19:46:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= To: Theodor Thornhill , Yuan Fu , Eli Zaretskii References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> <2a8ecd09-6b69-e128-1fe9-3f715b1efd3d@secure.kjonigsen.net> Content-Language: en-GB, nb-NO In-Reply-To: <2a8ecd09-6b69-e128-1fe9-3f715b1efd3d@secure.kjonigsen.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831 Cc: 59831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 12.12.2022 08:53, Jostein Kjønigsen wrote: > On 07.12.2022 10:42, Jostein Kjønigsen wrote: >> On 07.12.2022 10:33, Theodor Thornhill wrote: >>> >>> Do we need this (this) here, or could that just go into the keyword >>> feature? >>> >>> Otherwise LGTM.  Go ahead and install, Yuan, unless you have something >>> else to add :-) >>> >>> Theo >> >> You're right. We don't. I've cleaned that up in this patch, and also >> made sure to better support if-statements with negations. >> >> See new, attached patch with all changes applied. >> >> -- >> Jostein > > Looking at my local emacs-29 branch, this patch seems not to have been > applied yet. > > Could you take a look and get it installed, Yuan? > > -- > Jostein > I hate to be nagging, but I still don't see this patch applied. If Yuan is busy with stuff, could someone else help get this installed into the emacs-29 branch? -- Jostein From unknown Sat Aug 16 10:47:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: Did not alter fixed versions and reopened. Date: Wed, 14 Dec 2022 19:02:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # Did not alter fixed versions and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 14:03:47 2022 Received: (at 59831-done) by debbugs.gnu.org; 14 Dec 2022 19:03:47 +0000 Received: from localhost ([127.0.0.1]:41029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5X2g-0006gF-Uu for submit@debbugs.gnu.org; Wed, 14 Dec 2022 14:03:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5X2d-0006g7-Me for 59831-done@debbugs.gnu.org; Wed, 14 Dec 2022 14:03:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5X2Y-0004Vc-Ai; Wed, 14 Dec 2022 14:03:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=4BVol39N7y3bKQhMwwEPNpLZLqWX6gXeiaJTTnueh8M=; b=Vgn3CEoJp1ZonwMNQ4f8 /UxBNEzLjlM753IgEHuSOgW1dxj2mwGFyCw9uKUqX5f54zx7QXfzQNiRW6A2wG8T2aNJUmjhqqRsX 3X1G+KL7Ljbg1/+hzdfacmYnI6KIsRQc6N1R2jCrOWbth8ik6LCEIGmFOMTXLXCvV9S9iwwDMEufC G+4o3s64dxwYxFjSHyuDO6C9UeAUMCqgqU71UgtHBRF3/g26QTcrHKqQ8gmamlFAAYnUu9dij218R Ivs689TKPOrNU+SHlqFwNF6BXm/caj347ovoBU6onxWv7qv5WqdSrUVUBeRVZAyOq6NaKPfeCDsG3 T3lWj/RVL3p3UQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5X2X-0005e2-Pj; Wed, 14 Dec 2022 14:03:38 -0500 Date: Wed, 14 Dec 2022 21:03:35 +0200 Message-Id: <838rj9n6yg.fsf@gnu.org> From: Eli Zaretskii To: jostein@kjonigsen.net In-Reply-To: (message from Jostein =?utf-8?Q?Kj=C3=B8nigsen?= on Wed, 14 Dec 2022 19:46:06 +0100) Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> <2a8ecd09-6b69-e128-1fe9-3f715b1efd3d@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59831-done Cc: casouri@gmail.com, 59831-done@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 14 Dec 2022 19:46:06 +0100 > From: Jostein Kjønigsen > Cc: 59831@debbugs.gnu.org > > If Yuan is busy with stuff, could someone else help get this installed > into the emacs-29 branch? Done. Please in the future try following more closely our conventions for writing commit log messages. (See the minor corrections I made in this commit.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 14:39:59 2022 Received: (at 59831-done) by debbugs.gnu.org; 14 Dec 2022 19:39:59 +0000 Received: from localhost ([127.0.0.1]:41178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Xbj-0000rn-0k for submit@debbugs.gnu.org; Wed, 14 Dec 2022 14:39:59 -0500 Received: from mail-pl1-f177.google.com ([209.85.214.177]:37404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5Xbg-0000rg-2N for 59831-done@debbugs.gnu.org; Wed, 14 Dec 2022 14:39:58 -0500 Received: by mail-pl1-f177.google.com with SMTP id m4so4456746pls.4 for <59831-done@debbugs.gnu.org>; Wed, 14 Dec 2022 11:39:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=e/7IynvR5ZrsWWcv6o2LmLaHDGg/e39lERjxuJEMr7E=; b=NFCqZa7CldS8Mlnm8JSlEr/s8Y6AhHLBYT4hF4Cl1QejFNU/fFRiqfKnMvp24sMJpF rgpkTIEWzk2Cr8noRNJk2UfJljPAuey673eTloB0nY62jig2R/38NpeQ7on7yoxJVXIv B2JlCXn4hZbR/WHKu2O6DWX5DzIvQ5NYE4u1CNgabBPp194EOyOWfgJOvCyBXrhweVl/ 1nJXsvD7B/BO5tAFpXcdhSNrJxWts0CTWzkHh1UOVSKTktjnwfNmg+j4lE/FygtL4jZa su8NHAuAGeyqLQnbcFQzX991pPeTTn8ZeG9m8pmMLHxS7DSeZGc1jhCefayiUnXT55/c haRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e/7IynvR5ZrsWWcv6o2LmLaHDGg/e39lERjxuJEMr7E=; b=dfw89sPsp4yMZtjwgpcoQqSHaW4m+AVJwmBqoG7wbnuSWgefZJwStnwrId53PWIRZn y+Pbx485f0wJhzAJcG4AJ4ICJE2AghzPbwZew29hBxutoBR4KazfiCBQfNfngJ7bJUaj zDK9Vgss76hcUMlE7RT0/DsmIaIrE/42UEHeKO6K9PRJ6F9FW+o0nnMpV3345J/swK3c AlHeXn9tvbGnHnxkdDXbzZ5BKPVLd6jjrh0L3aWxhKkKDX27FkbhKncYBd8OTTZEVgEF XmbYNLErU0gSqq5/U+Q3uWGhycG1anBuwyuWCapQPK6xeMPdZOhoZ89uWyuBHDmMcB4C E1jg== X-Gm-Message-State: ANoB5plPD4F0msI0J/Z8eu2wgPz31zAL+ECkjAMapVqRRJObOBn1bLdv fxgFt0F9svOy62PqLPdBFm8= X-Google-Smtp-Source: AA0mqf7q97Z3j4JxexzkdbAyv0Ygo4zewRZz07TlYdVfmTKVo3qmE9TYsdDOQCCdiOhROkHfrh638Q== X-Received: by 2002:a05:6a20:9c89:b0:a3:9598:e5c5 with SMTP id mj9-20020a056a209c8900b000a39598e5c5mr29461880pzb.35.1671046789954; Wed, 14 Dec 2022 11:39:49 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id y193-20020a6264ca000000b00576d76c9927sm238422pfb.106.2022.12.14.11.39.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 11:39:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified From: Yuan Fu In-Reply-To: <838rj9n6yg.fsf@gnu.org> Date: Wed, 14 Dec 2022 11:39:47 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <6C6AA444-3DF4-4FF3-943C-72CA94AF3590@gmail.com> References: <676d4e95-dfe3-5ced-60a3-b2387512ee63@secure.kjonigsen.net> <87v8mqxmfo.fsf@thornhill.no> <2151efc1-b6f6-4e0d-7416-cccae9277a34@secure.kjonigsen.net> <87bkoifbj3.fsf@thornhill.no> <848e54b0-4b74-2d85-064d-bf8dc792d1e8@secure.kjonigsen.net> <87mt7zzhg6.fsf@thornhill.no> <2a8ecd09-6b69-e128-1fe9-3f715b1efd3d@secure.kjonigsen.net> <838rj9n6yg.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59831-done Cc: theo@thornhill.no, 59831-done@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 14, 2022, at 11:03 AM, Eli Zaretskii wrote: >=20 >> Date: Wed, 14 Dec 2022 19:46:06 +0100 >> From: Jostein Kj=C3=B8nigsen >> Cc: 59831@debbugs.gnu.org >>=20 >> If Yuan is busy with stuff, could someone else help get this = installed=20 >> into the emacs-29 branch? >=20 > Done. >=20 > Please in the future try following more closely our conventions for > writing commit log messages. (See the minor corrections I made in > this commit.) >=20 > Thanks. Ah, sorry, I must have somehow lost track of this report. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 16:56:52 2022 Received: (at 59831-done) by debbugs.gnu.org; 14 Dec 2022 21:56:52 +0000 Received: from localhost ([127.0.0.1]:41927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZkC-0007IC-90 for submit@debbugs.gnu.org; Wed, 14 Dec 2022 16:56:52 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ZkA-0007I6-ST for 59831-done@debbugs.gnu.org; Wed, 14 Dec 2022 16:56:51 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CA5F45C00CF; Wed, 14 Dec 2022 16:56:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 14 Dec 2022 16:56:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1671055005; x=1671141405; bh=BCBBfQV4pe ZvOiRMQbgtrcCIdnksVE+UQet6Jl8WRpM=; b=BbvfI8Ns6tWrCVea8PTbhfII4r 8q7ow8WuZBsmcD576f0sPj1s7FiMN/Y77nVRsdbrAMTVoW07U/P6an5ulMNxNdkQ dvoHY3TvLPYw8wU37ygl3Wt9jMqcjtBdSPMcy2jrJWLALptaidMUdpWfHlKDWCgV zespcin4ADcAHyt5uSoxhs31YesC6OVJhN91+PLDlI+4k6uCOLKQdnnnj+rO8VhO id4GlosegPGimcTpJRCo4Q4u8Mbv0CC6nFmOHKh40h97EZSrUm9fCJj5d/2jKVkh tR8moTqlURyWaTbzAjjrGmNxlLgj7fR6ePw5rDwTZOt5CZ4dfd7dqn+M2Xtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1671055005; x= 1671141405; bh=BCBBfQV4peZvOiRMQbgtrcCIdnksVE+UQet6Jl8WRpM=; b=i K4BpQ6ly6dl9lhIstgcR986MwYefOdaMrXm5ONzLCo67IKTXoPyfWBEhAoGhrmsU Lw4e8xnf37iGU+CR6P9i5ZhsSJkDOje7kA0+ziiHchGfPLXoAoo0IvyKrnFQanDX JILeDz+6WceQUsBxgqwLvMXwdoAyBp0SGdPbvJxRRG6MO8YqTkwT7sL9b2Bpbu1+ b6xH+OYFFwQpKsZo+6aLqcuRaLsJB3sQAGrYKSwPdOf07NzfSw9mg327hxfdcBw8 NSF3/Qquq91JmJBLoofwQbXvEw+RGuD4yM2Bndj0CUXhJs9XHpGLKCd8tGOfMCb8 5eI0CzoM8sZEZcJbfIZmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefgdduheehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfghfggufffkfhfvegjvffosehtqhhmtdhhtdejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeejgeduveffieefgeevudeiteef tdfgtefgffegfeefgefhgfefhfffgeeguddvudenucffohhmrghinhepkhhjnhhighhsvg hnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhho mhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Dec 2022 16:56:45 -0500 (EST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= Mime-Version: 1.0 (1.0) Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified Date: Wed, 14 Dec 2022 22:56:34 +0100 Message-Id: <153FC3C9-FA3F-45D2-A530-5C6941D5C6F5@secure.kjonigsen.net> References: <6C6AA444-3DF4-4FF3-943C-72CA94AF3590@gmail.com> In-Reply-To: <6C6AA444-3DF4-4FF3-943C-72CA94AF3590@gmail.com> To: Yuan Fu X-Mailer: iPhone Mail (20C65) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59831-done Cc: theo@thornhill.no, Eli Zaretskii , 59831-done@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) In your defence, it can be hard to keep track of 4-5 ongoing patches/bugs fr= om a single contributor ;) I=E2=80=99m just trying to make sure none of the patches get lost on the way= ! =E2=80=94 Jostein Kj=C3=B8nigsen https://jostein.kj=C3=B8nigsen.net > On 14 Dec 2022, at 20:45, Yuan Fu wrote: >=20 > =EF=BB=BF >=20 >>> On Dec 14, 2022, at 11:03 AM, Eli Zaretskii wrote: >>>=20 >>> Date: Wed, 14 Dec 2022 19:46:06 +0100 >>> From: Jostein Kj=C3=B8nigsen >>> Cc: 59831@debbugs.gnu.org >>>=20 >>> If Yuan is busy with stuff, could someone else help get this installed=20= >>> into the emacs-29 branch? >>=20 >> Done. >>=20 >> Please in the future try following more closely our conventions for >> writing commit log messages. (See the minor corrections I made in >> this commit.) >>=20 >> Thanks. >=20 > Ah, sorry, I must have somehow lost track of this report. >=20 > Yuan From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 14 17:21:58 2022 Received: (at 59831-done) by debbugs.gnu.org; 14 Dec 2022 22:21:58 +0000 Received: from localhost ([127.0.0.1]:41956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5a8T-0001QA-WF for submit@debbugs.gnu.org; Wed, 14 Dec 2022 17:21:58 -0500 Received: from mail-pj1-f45.google.com ([209.85.216.45]:39432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5a8R-0001Q4-Cl for 59831-done@debbugs.gnu.org; Wed, 14 Dec 2022 17:21:56 -0500 Received: by mail-pj1-f45.google.com with SMTP id e7-20020a17090a77c700b00216928a3917so744137pjs.4 for <59831-done@debbugs.gnu.org>; Wed, 14 Dec 2022 14:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=A1FYw4KcA3ccQ/gVQfdYIE4XDAKB8wz7PAnNK5wpNKA=; b=YNZNBum9nbC6X4TlTM/fUeUBRUmquDLCQ5p18RCDykz+VjZvllM93h05r/wilBOjeq rDyliK92oihJfA86d3ZilFE1mtVV+f7KNPA+Nb/P3W6gMokUGvaQz4XBgc1wuiuyVDp7 wbboe21CFgzPyjK3qvMOfgfEcvGKH+0kt3Jz2ZaTLSagalJqlZgZODbmIgoIrOh2kVZg 6FHlgazc5lHOTD7xMAI2tblNsvUg3rcbUnP+mnuli6aX2khUyHAMYHDmVAz8rqqM2Q3M GaTApnQWixOiBDud7JEkoRForM6VBvcSA7Z0Ap5lpultKefc4DHdPtY76Fm2pCYS0Wpq hZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1FYw4KcA3ccQ/gVQfdYIE4XDAKB8wz7PAnNK5wpNKA=; b=ePyUDkkYm8fVmRaa2AykrH1Eknd9+ZQ8jAZMM2CibuXdGfcDH3wiCSUb9NewG2Z1ix JXQkRiec5ePa6u4L1g+TJU6LzBRuAmXqwdmE1wjmsb2hAiA1VjNQgxkT9CqTdyX+isTv XM1izCQJxCQyiMoRiFNWPL7FEcCzcMEAlTC6/SEeUGHyCcUBcWmIxgtKuEyF5A5lU6vf FNm8mLEyoFv622BY5wc3UaskWRcmBnMO2BoLY8i2mPnOzw0gKpoIfflS6Xipv3UtS4Yq JOogeoXmn4ZyZSaCrLJe5gmsupl3P+2+b/TsjsiFBlxL1/+20voBfJe1GE/IybdKtArM lVaA== X-Gm-Message-State: ANoB5pnZzMCNUOZkQFm1yeqQyMcFPhQqmRU8kC9WlH7xBVHjpGtApzrj XF6AHAsBnosF/dnVg6vPdgA= X-Google-Smtp-Source: AA0mqf6aqbuzHlgSqM7kgb7RVYJuPgHEKWCBfgbgETWQnJT5Gm/uQXZifj2/aKvvWPGEFWu4nmEhnQ== X-Received: by 2002:a17:902:8349:b0:189:bc50:b93b with SMTP id z9-20020a170902834900b00189bc50b93bmr24842486pln.3.1671056509561; Wed, 14 Dec 2022 14:21:49 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f12-20020a170902684c00b00189ed861791sm2319497pln.266.2022.12.14.14.21.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Dec 2022 14:21:49 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59831: 29.0.60; typescript-ts-mode: Variables, properties & fields are often not fontified From: Yuan Fu In-Reply-To: <153FC3C9-FA3F-45D2-A530-5C6941D5C6F5@secure.kjonigsen.net> Date: Wed, 14 Dec 2022 14:21:47 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <072D77FE-A1B2-432F-89D8-8CF79EA97FE3@gmail.com> References: <6C6AA444-3DF4-4FF3-943C-72CA94AF3590@gmail.com> <153FC3C9-FA3F-45D2-A530-5C6941D5C6F5@secure.kjonigsen.net> To: =?utf-8?Q?Jostein_Kj=C3=B8nigsen?= X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59831-done Cc: theo@thornhill.no, Eli Zaretskii , 59831-done@debbugs.gnu.org, jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Dec 14, 2022, at 1:56 PM, Jostein Kj=C3=B8nigsen = wrote: >=20 > In your defence, it can be hard to keep track of 4-5 ongoing = patches/bugs from a single contributor ;) >=20 > I=E2=80=99m just trying to make sure none of the patches get lost on = the way! And thank you for your efforts! It=E2=80=99s a lot of work to make those = changes, put them into a patch, send a bug report, and do multiple ones = at the same time. I appreciate it very much. Yuan= From unknown Sat Aug 16 10:47:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 12 Jan 2023 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator