GNU bug report logs - #59822
[PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button.

Previous Next

Full log

Message #8 received at 59822 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: "(" <paren <at> disroot.org>
Cc: 59822 <at> debbugs.gnu.org
Subject: Re: [bug#59822] [PATCH guix-artwork] website: base: home: Add
 'DOWNLOAD LATEST' button.
Date: Sun, 04 Dec 2022 22:50:26 +0100

Hello (

"( via Guix-patches" via <guix-patches <at> gnu.org> writes:
> * website/apps/base/templates/home.scm (home-t)[#:content]: Add a
>   'DOWNLOAD LATEST' button.

Good idea.

Would you add a copyright line or copyright disclaimer line and send an
updated patch?

>           #:label (apply string-append
>                          (C_ "button" `("DOWNLOAD v" ,(latest-guix-version) "")))
> […]
>         " " ; A space for readability in non-CSS browsers.
> +       ,(button-big
> +         #:label (apply string-append
> +                        (C_ "button" `("DOWNLOAD LATEST")))

In the DOWNLOAD LATEST button, could you remove the (apply string-append
and its now unmatched parenthesis?

It is a trick to concatenate the translations for "DOWNLOAD v", the
latest-guix-version and the translation for "".  But for "DOWNLOAD
LATEST", it is unneeded.

And maybe untabify the lines you change.

Other than that, LGTM, thank you!

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.