From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 05:26:25 2010 Received: (at submit) by debbugs.gnu.org; 20 Apr 2010 09:26:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O49iq-000303-KT for submit@debbugs.gnu.org; Tue, 20 Apr 2010 05:26:25 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O49in-0002zy-N7 for submit@debbugs.gnu.org; Tue, 20 Apr 2010 05:26:23 -0400 Received: from lists.gnu.org ([199.232.76.165]:44911) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O49ik-0004I3-Oj for submit@debbugs.gnu.org; Tue, 20 Apr 2010 05:26:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O49ij-00022c-QA for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2010 05:26:17 -0400 Received: from [140.186.70.92] (port=38050 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O49ie-00021b-B1 for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2010 05:26:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O49iW-0001v8-Jk for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2010 05:26:12 -0400 Received: from mail.gmx.net ([213.165.64.20]:47055) by eggs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1O49iV-0001ud-UX for bug-gnu-emacs@gnu.org; Tue, 20 Apr 2010 05:26:04 -0400 Received: (qmail invoked by alias); 20 Apr 2010 09:26:01 -0000 Received: from p548628C7.dip.t-dialin.net (EHLO turtle.gmx.de) [84.134.40.199] by mail.gmx.net (mp046) with SMTP; 20 Apr 2010 11:26:01 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX1/dYmEk3K/d2peHw4/+T+LNr9irkiGdNAtM2dQ/Q1 7mZilQlCSYDjxT Received: by turtle.gmx.de (Postfix, from userid 1000) id 43BC63F587; Tue, 20 Apr 2010 11:26:00 +0200 (CEST) From: Sven Joachim To: bug-gnu-emacs@gnu.org Subject: 23.1.96; Dired regression - recursive copies turn symlinks into regular files X-Debbugs-Cc: Sven Joachim Date: Tue, 20 Apr 2010 11:26:00 +0200 Message-ID: <877ho2jx07.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.53000000000000003 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Suppose we have the following directory in dired: ,---- | /tmp/foo: | total used in directory 4 available 1674380 | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar | lrwxrwxrwx 1 sven sven 3 Apr 20 11:12 bar2 -> bar `---- Now type ^ to cd to the parent directory, move to the "foo" line and press "C /tmp/foo2 RET yes" (confirming the recursive copy and creating /tmp/foo2) and switch to the new directory. It looks like this: ,---- | /tmp/foo2: | total used in directory 8 available 1674380 | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar2 `---- This is a regression from Emacs 23.1 and 22.3 where the symlink would be copied as such instead of turning into a regular file. In GNU Emacs 23.1.96.1 (i486-pc-linux-gnu, GTK+ Version 2.20.0) of 2010-04-20 on turtle, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10706901 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.1.96/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1.96/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: de_DE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Group Minor modes in effect: shell-dirtrack-mode: t gnus-undo-mode: t display-time-mode: t auto-image-file-mode: t show-paren-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: m e s a / C-x 1 C-x d / t m g U + f f o o ! t o u c h SPC b a r g H C-g Y b a r 2 g C f o o 2 y e s g g g m m C . . g d d x y e s g U U a b d c d e SPC C-x C-s C-x k g D y s e s y g H C-g C 2 y e s g g D y e s g Y b a r 2 g D y e s C y e s g M-x g n u s SPC SPC q SPC q SPC SPC SPC SPC SPC SPC SPC SPC q SPC d SPC SPC SPC q SPC q SPC q SPC SPC q SPC q SPC q SPC q SPC q M-x r e p o r t - e m b u Recent messages: Fetching headers for gmane.linux.kernel...done Retrieving newsgroup: gmane.comp.gnu.core-utils.bugs... Fetching headers for gmane.comp.gnu.core-utils.bugs...done Retrieving newsgroup: gmane.comp.gnu.grep.bugs... Fetching headers for gmane.comp.gnu.grep.bugs...done Retrieving newsgroup: gmane.comp.shells.zsh.user... Fetching headers for gmane.comp.shells.zsh.user...done Retrieving newsgroup: nntp+news.eternal-september.org:de.comp.editoren... Opening nntp server on news.eternal-september.org...done Fetching headers for nntp+news.eternal-september.org:de.comp.editoren...done Load-path shadows: ~/elisp/po-mode hides /usr/share/emacs-snapshot/site-lisp/gettext/po-mode ~/elisp/debian-bts-control hides /usr/share/emacs-snapshot/site-lisp/dpkg-dev-el/debian-bts-control /usr/share/emacs/23.1.96/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex /usr/share/emacs/23.1.96/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex /usr/share/emacs/23.1.96/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex /usr/share/emacs/23.1.96/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold /usr/share/emacs/23.1.96/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp /usr/share/emacs/23.1.96/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar /usr/share/emacs/23.1.96/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik /usr/share/emacs/23.1.96/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context /usr/share/emacs/23.1.96/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl /usr/share/emacs/23.1.96/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite /usr/share/emacs/23.1.96/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt /usr/share/emacs/23.1.96/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf /usr/share/emacs/23.1.96/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp /usr/share/emacs/23.1.96/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en /usr/share/emacs/23.1.96/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font /usr/share/emacs/23.1.96/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x /usr/share/emacs/23.1.96/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style /usr/share/emacs/23.1.96/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex /usr/share/emacs/23.1.96/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info /usr/share/emacs-snapshot/site-lisp/bbdb/bbdb-pilot-jwz hides /usr/share/emacs/site-lisp/bbdb/bbdb-pilot-jwz ~/elisp/po-mode hides /usr/share/emacs/site-lisp/gettext/po-mode /usr/share/emacs-snapshot/site-lisp/gettext/po-compat hides /usr/share/emacs/site-lisp/gettext/po-compat /usr/share/emacs-snapshot/site-lisp/gnuplot-mode/gnuplot hides /usr/share/emacs/site-lisp/gnuplot-mode/gnuplot /usr/share/emacs-snapshot/site-lisp/gnuplot-mode/info-look.20.3 hides /usr/share/emacs/site-lisp/gnuplot-mode/info-look.20.3 /usr/share/emacs-snapshot/site-lisp/gnuplot-mode/gnuplot-gui hides /usr/share/emacs/site-lisp/gnuplot-mode/gnuplot-gui /usr/share/emacs/23.1.96/site-lisp/cmake/cmake-mode hides /usr/share/emacs/23.1.96/site-lisp/cmake-data/cmake-mode /usr/share/emacs/23.1.96/site-lisp/cmake/cmake-mode hides /usr/share/emacs/site-lisp/cmake-mode /usr/share/emacs/23.1.96/site-lisp/debian-startup hides /usr/share/emacs/site-lisp/debian-startup /usr/share/emacs/23.1.96/site-lisp/magit hides /usr/share/emacs/site-lisp/magit /usr/share/emacs-snapshot/site-lisp/w3m/w3m-util hides /usr/share/emacs/site-lisp/w3m/w3m-util /usr/share/emacs-snapshot/site-lisp/w3m/w3m-dtree hides /usr/share/emacs/site-lisp/w3m/w3m-dtree /usr/share/emacs-snapshot/site-lisp/w3m/w3m-hist hides /usr/share/emacs/site-lisp/w3m/w3m-hist /usr/share/emacs-snapshot/site-lisp/w3m/w3m-weather hides /usr/share/emacs/site-lisp/w3m/w3m-weather /usr/share/emacs-snapshot/site-lisp/w3m/w3m-rss hides /usr/share/emacs/site-lisp/w3m/w3m-rss /usr/share/emacs-snapshot/site-lisp/w3m/mew-w3m hides /usr/share/emacs/site-lisp/w3m/mew-w3m /usr/share/emacs-snapshot/site-lisp/w3m/w3m-filter hides /usr/share/emacs/site-lisp/w3m/w3m-filter /usr/share/emacs-snapshot/site-lisp/w3m/w3m-session hides /usr/share/emacs/site-lisp/w3m/w3m-session /usr/share/emacs-snapshot/site-lisp/w3m/w3mhack hides /usr/share/emacs/site-lisp/w3m/w3mhack /usr/share/emacs-snapshot/site-lisp/w3m/w3m-search hides /usr/share/emacs/site-lisp/w3m/w3m-search /usr/share/emacs-snapshot/site-lisp/w3m/w3m-lnum hides /usr/share/emacs/site-lisp/w3m/w3m-lnum /usr/share/emacs-snapshot/site-lisp/w3m/w3m-proc hides /usr/share/emacs/site-lisp/w3m/w3m-proc /usr/share/emacs-snapshot/site-lisp/w3m/w3m-fb hides /usr/share/emacs/site-lisp/w3m/w3m-fb /usr/share/emacs-snapshot/site-lisp/w3m/w3m-favicon hides /usr/share/emacs/site-lisp/w3m/w3m-favicon /usr/share/emacs-snapshot/site-lisp/w3m/w3m-bug hides /usr/share/emacs/site-lisp/w3m/w3m-bug /usr/share/emacs-snapshot/site-lisp/w3m/w3m-perldoc hides /usr/share/emacs/site-lisp/w3m/w3m-perldoc /usr/share/emacs-snapshot/site-lisp/w3m/mime-w3m hides /usr/share/emacs/site-lisp/w3m/mime-w3m /usr/share/emacs-snapshot/site-lisp/w3m/w3m-bookmark hides /usr/share/emacs/site-lisp/w3m/w3m-bookmark /usr/share/emacs-snapshot/site-lisp/w3m/octet hides /usr/share/emacs/site-lisp/w3m/octet /usr/share/emacs-snapshot/site-lisp/w3m/w3m-ems hides /usr/share/emacs/site-lisp/w3m/w3m-ems /usr/share/emacs-snapshot/site-lisp/w3m/w3m hides /usr/share/emacs/site-lisp/w3m/w3m /usr/share/emacs-snapshot/site-lisp/w3m/w3m-ccl hides /usr/share/emacs/site-lisp/w3m/w3m-ccl /usr/share/emacs-snapshot/site-lisp/w3m/w3m-mail hides /usr/share/emacs/site-lisp/w3m/w3m-mail /usr/share/emacs-snapshot/site-lisp/w3m/w3m-cookie hides /usr/share/emacs/site-lisp/w3m/w3m-cookie /usr/share/emacs-snapshot/site-lisp/w3m/w3m-image hides /usr/share/emacs/site-lisp/w3m/w3m-image /usr/share/emacs-snapshot/site-lisp/w3m/w3m-form hides /usr/share/emacs/site-lisp/w3m/w3m-form /usr/share/emacs-snapshot/site-lisp/w3m/w3m-antenna hides /usr/share/emacs/site-lisp/w3m/w3m-antenna /usr/share/emacs-snapshot/site-lisp/w3m/w3m-symbol hides /usr/share/emacs/site-lisp/w3m/w3m-symbol /usr/share/emacs-snapshot/site-lisp/w3m/w3m-tabmenu hides /usr/share/emacs/site-lisp/w3m/w3m-tabmenu /usr/share/emacs-snapshot/site-lisp/w3m/w3m-namazu hides /usr/share/emacs/site-lisp/w3m/w3m-namazu Features: (shadow emacsbug compile multi-isearch woman man assoc compface gnus-fun debian-bts-control ispell nndoc url-cache url-http tls url-gw url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-util url-handlers url-parse url-vars thingatpt shell comint ring imenu debian-bug debian-changelog-mode add-log view ffap w3m-form mule-util w3m-bookmark w3m-tabmenu w3m-session w3m doc-view image-mode w3m-hist w3m-fb w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util browse-url flow-fill jka-compr sort gnus-cite smiley ansi-color mail-extr gnus-async gnus-bcklg gnus-ml disp-table parse-time timezone byte-opt bytecomp byte-compile nnfolder nndraft nnmh auth-source gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 epg-config mm-view smime dig nntp gnus-cache gnus-sum nnoo gnus-group gnus-undo nnmail mail-source format-spec gnus-start gnus-spec gnus-int gnus-range message idna sendmail ecomplete rfc822 mml easymenu mml-sec password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231 rfc2047 rfc2045 qp ietf-drums mailabbrev gmm-utils mailheader canlock sha1 hex-util hashcash gnus-win gnus gnus-ems nnheader gnus-util netrc time-date mail-utils mm-util mail-prsvr wid-edit kmacro bookmark pp vc-git conf-mode newcomment tar-mode deb-view dired-x dired-aux dired time server uniquify advice help-fns advice-preload po generic-x regexp-opt image-file paren add-ons bitmap bitmap-ci poem poem-e20 poem-e20_3 pces pces-e20 pces-20 broken pcustom poe pym static apel-ver product debian-el debian-el-loaddefs w3m-load emacs-goodies-el emacs-goodies-custom emacs-goodies-loaddefs easy-mmode dpkg-dev-el dpkg-dev-el-loaddefs bbdb-autoloads preview-latex tex-site auto-loads tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces cus-face files text-properties overlay md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind font-render-setting gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 08:55:52 2010 Received: (at control) by debbugs.gnu.org; 20 Apr 2010 12:55:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4CzX-00050H-G3 for submit@debbugs.gnu.org; Tue, 20 Apr 2010 08:55:51 -0400 Received: from pantheon-po34.its.yale.edu ([130.132.50.80]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4CzV-00050B-RG for control@debbugs.gnu.org; Tue, 20 Apr 2010 08:55:50 -0400 Received: from furry (adsl-99-109-17-70.dsl.wlfrct.sbcglobal.net [99.109.17.70]) (authenticated bits=0) by pantheon-po34.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3KCtiQx018059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Tue, 20 Apr 2010 08:55:44 -0400 Received: by furry (Postfix, from userid 1000) id 52BE9C055; Tue, 20 Apr 2010 08:55:44 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: severity 5982 serious Date: Tue, 20 Apr 2010 08:55:44 -0400 Message-ID: <87d3xu471r.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.2 (--) severity 5982 serious thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 09:49:45 2010 Received: (at 5982) by debbugs.gnu.org; 20 Apr 2010 13:49:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4Dpg-0005vi-Oo for submit@debbugs.gnu.org; Tue, 20 Apr 2010 09:49:45 -0400 Received: from mail.gmx.net ([213.165.64.20]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1O4Dpd-0005vW-SP for 5982@debbugs.gnu.org; Tue, 20 Apr 2010 09:49:43 -0400 Received: (qmail invoked by alias); 20 Apr 2010 13:49:35 -0000 Received: from p548628C7.dip.t-dialin.net (EHLO turtle.gmx.de) [84.134.40.199] by mail.gmx.net (mp042) with SMTP; 20 Apr 2010 15:49:35 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX18UnnMl2sQUMmpdJjNW2C/0qxevvECLBFaPIOWzxC jy2vmffq0chNUC Received: by turtle.gmx.de (Postfix, from userid 1000) id 9935A3F587; Tue, 20 Apr 2010 15:49:33 +0200 (CEST) From: Sven Joachim To: 5982@debbugs.gnu.org Subject: Re: bug#5982: 23.1.96; Dired regression - recursive copies turn symlinks into regular files References: <877ho2jx07.fsf@turtle.gmx.de> Date: Tue, 20 Apr 2010 15:49:33 +0200 In-Reply-To: <877ho2jx07.fsf@turtle.gmx.de> (Sven Joachim's message of "Tue, 20 Apr 2010 11:26:00 +0200") Message-ID: <87wrw2i68i.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.58999999999999997 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 5982 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On 2010-04-20 11:26 +0200, Sven Joachim wrote: > Suppose we have the following directory in dired: > > ,---- > | /tmp/foo: > | total used in directory 4 available 1674380 > | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . > | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. > | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar > | lrwxrwxrwx 1 sven sven 3 Apr 20 11:12 bar2 -> bar > `---- > > Now type ^ to cd to the parent directory, move to the "foo" line and > press "C /tmp/foo2 RET yes" (confirming the recursive copy and creating > /tmp/foo2) and switch to the new directory. It looks like this: > > ,---- > | /tmp/foo2: > | total used in directory 8 available 1674380 > | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . > | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. > | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar > | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar2 > `---- > > This is a regression from Emacs 23.1 and 22.3 where the symlink would be > copied as such instead of turning into a regular file. Bisecting shows that this problem first occured in revision 97979 when dired-copy-file-recursive started to use the new copy-directory command (added in revision 97978). The latter just calls copy-file for non-directories, and copy-file has no option to preserve symlinks. Sven From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 10:54:35 2010 Received: (at 5982) by debbugs.gnu.org; 20 Apr 2010 14:54:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4EqQ-0006Q3-Iy for submit@debbugs.gnu.org; Tue, 20 Apr 2010 10:54:34 -0400 Received: from pantheon-po30.its.yale.edu ([130.132.50.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4EqO-0006Px-Ls for 5982@debbugs.gnu.org; Tue, 20 Apr 2010 10:54:33 -0400 Received: from furry (dhcp128036014104.central.yale.edu [128.36.14.104]) (authenticated bits=0) by pantheon-po30.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3KEsReL017360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 20 Apr 2010 10:54:27 -0400 Received: by furry (Postfix, from userid 1000) id BBFAFC055; Tue, 20 Apr 2010 10:54:27 -0400 (EDT) From: Chong Yidong To: Michael Albinus Subject: Re: bug#5982: 23.1.96; Dired regression - recursive copies turn symlinks into regular files References: <877ho2jx07.fsf@turtle.gmx.de> <87wrw2i68i.fsf@turtle.gmx.de> Date: Tue, 20 Apr 2010 10:54:27 -0400 In-Reply-To: <87wrw2i68i.fsf@turtle.gmx.de> (Sven Joachim's message of "Tue, 20 Apr 2010 15:49:33 +0200") Message-ID: <87sk6qqin0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 5982 Cc: 5982@debbugs.gnu.org, Sven Joachim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Sven Joachim writes: > On 2010-04-20 11:26 +0200, Sven Joachim wrote: > >> Suppose we have the following directory in dired: >> >> ,---- >> | /tmp/foo: >> | total used in directory 4 available 1674380 >> | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . >> | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. >> | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar >> | lrwxrwxrwx 1 sven sven 3 Apr 20 11:12 bar2 -> bar >> `---- >> >> Now type ^ to cd to the parent directory, move to the "foo" line and >> press "C /tmp/foo2 RET yes" (confirming the recursive copy and creating >> /tmp/foo2) and switch to the new directory. It looks like this: >> >> ,---- >> | /tmp/foo2: >> | total used in directory 8 available 1674380 >> | drwxr-xr-x 2 sven sven 80 Apr 20 11:12 . >> | drwxrwxrwt 14 root root 300 Apr 20 11:12 .. >> | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar >> | -rw-r--r-- 1 sven sven 6 Apr 20 11:09 bar2 >> `---- >> >> This is a regression from Emacs 23.1 and 22.3 where the symlink would be >> copied as such instead of turning into a regular file. > > Bisecting shows that this problem first occured in revision 97979 when > dired-copy-file-recursive started to use the new copy-directory command > (added in revision 97978). The latter just calls copy-file for > non-directories, and copy-file has no option to preserve symlinks. The following patch would add symlink copying to `copy-directory'. Michael, could you review the patch carefully, or suggest some other solution? *** lisp/files.el 2010-03-11 16:25:46 +0000 --- lisp/files.el 2010-04-20 14:50:35 +0000 *************** *** 4735,4744 **** (mapc (lambda (file) (let ((target (expand-file-name ! (file-name-nondirectory file) newname))) ! (if (file-directory-p file) ! (copy-directory file target keep-time parents) ! (copy-file file target t keep-time)))) ;; We do not want to copy "." and "..". (directory-files directory 'full directory-files-no-dot-files-regexp)) --- 4735,4748 ---- (mapc (lambda (file) (let ((target (expand-file-name ! (file-name-nondirectory file) newname)) ! (attrs (file-attributes file))) ! (cond ((file-directory-p file) ! (copy-directory file target keep-time parents)) ! ((stringp (car attrs)) ; Symbolic link ! (make-symbolic-link (car attrs) target t)) ! (t ! (copy-file file target t keep-time))))) ;; We do not want to copy "." and "..". (directory-files directory 'full directory-files-no-dot-files-regexp)) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 11:11:06 2010 Received: (at 5982) by debbugs.gnu.org; 20 Apr 2010 15:11:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4F6Q-0006Xb-2F for submit@debbugs.gnu.org; Tue, 20 Apr 2010 11:11:06 -0400 Received: from mailrelay2.alcatel.de ([194.113.59.96]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4F6O-0006XF-CX for 5982@debbugs.gnu.org; Tue, 20 Apr 2010 11:11:05 -0400 Received: from destgsu0048.de.alcatel-lucent.com (destgsu0048.de.alcatel-lucent.com [149.204.242.4]) by mailrelay2.alcatel.de (8.14.3/8.14.3/ICT) with ESMTP id o3KFAwrq019471; Tue, 20 Apr 2010 17:10:58 +0200 Received: from slbhn1.alcatel.de (slbhn1.de.alcatel-lucent.com [149.204.90.35]) by destgsu0048.de.alcatel-lucent.com (8.12.3/8.12.3) with ESMTP id o3KFAv2Y000533; Tue, 20 Apr 2010 17:10:57 +0200 (MEST) From: Michael Albinus To: Chong Yidong Subject: Re: bug#5982: 23.1.96; Dired regression - recursive copies turn symlinks into regular files References: <877ho2jx07.fsf@turtle.gmx.de> <87wrw2i68i.fsf@turtle.gmx.de> <87sk6qqin0.fsf@stupidchicken.com> Date: Tue, 20 Apr 2010 17:10:57 +0200 In-Reply-To: <87sk6qqin0.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 20 Apr 2010 16:54:27 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Alcanet-virus-scanned: o3KFAv2Y000533 at destgsu0048.de.alcatel-lucent.com X-Scanned-By: MIMEDefang 2.64 on 149.204.45.73 X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 5982 Cc: "5982@debbugs.gnu.org" <5982@debbugs.gnu.org>, Sven Joachim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) Chong Yidong writes: > The following patch would add symlink copying to `copy-directory'. > Michael, could you review the patch carefully, or suggest some other > solution? I've started already to check the problem. I'll review the patch later tonight, let you know then (just being too busy @work). Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 18:17:05 2010 Received: (at 5982) by debbugs.gnu.org; 20 Apr 2010 22:17:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4Lkf-0002r5-Jc for submit@debbugs.gnu.org; Tue, 20 Apr 2010 18:17:05 -0400 Received: from mail.gmx.net ([213.165.64.20]) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1O4Lkd-0002qg-DR for 5982@debbugs.gnu.org; Tue, 20 Apr 2010 18:17:04 -0400 Received: (qmail invoked by alias); 20 Apr 2010 22:16:58 -0000 Received: from p4FC01665.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [79.192.22.101] by mail.gmx.net (mp032) with SMTP; 21 Apr 2010 00:16:58 +0200 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX198Xn04AW18Gv5pkqnTw0/LjKFIcT/5QjSUO9UEUt F5XMINYEHpmLwF From: Michael Albinus To: Chong Yidong Subject: Re: bug#5982: 23.1.96; Dired regression - recursive copies turn symlinks into regular files References: <877ho2jx07.fsf@turtle.gmx.de> <87wrw2i68i.fsf@turtle.gmx.de> <87sk6qqin0.fsf@stupidchicken.com> Date: Wed, 21 Apr 2010 00:16:55 +0200 In-Reply-To: <87sk6qqin0.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 20 Apr 2010 10:54:27 -0400") Message-ID: <87d3xtixbc.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 5982 Cc: 5982@debbugs.gnu.org, Sven Joachim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Chong Yidong writes: > The following patch would add symlink copying to `copy-directory'. > Michael, could you review the patch carefully, or suggest some other > solution? Looks good. It works also for remote files. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 20 18:29:09 2010 Received: (at 5982-done) by debbugs.gnu.org; 20 Apr 2010 22:29:10 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4LwL-0002vm-Jv for submit@debbugs.gnu.org; Tue, 20 Apr 2010 18:29:09 -0400 Received: from pantheon-po30.its.yale.edu ([130.132.50.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O4LwJ-0002vh-NC for 5982-done@debbugs.gnu.org; Tue, 20 Apr 2010 18:29:08 -0400 Received: from furry (dhcp128036014104.central.yale.edu [128.36.14.104]) (authenticated bits=0) by pantheon-po30.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o3KMT3ds008909 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 20 Apr 2010 18:29:03 -0400 Received: by furry (Postfix, from userid 1000) id 6407FC055; Tue, 20 Apr 2010 18:29:03 -0400 (EDT) From: Chong Yidong To: Michael Albinus Subject: Re: bug#5982: 23.1.96; Dired regression - recursive copies turn symlinks into regular files References: <877ho2jx07.fsf@turtle.gmx.de> <87wrw2i68i.fsf@turtle.gmx.de> <87sk6qqin0.fsf@stupidchicken.com> <87d3xtixbc.fsf@gmx.de> Date: Tue, 20 Apr 2010 18:29:03 -0400 In-Reply-To: <87d3xtixbc.fsf@gmx.de> (Michael Albinus's message of "Wed, 21 Apr 2010 00:16:55 +0200") Message-ID: <87k4s1bvww.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.96 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 5982-done Cc: Sven Joachim , 5982-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) Michael Albinus writes: > Chong Yidong writes: > >> The following patch would add symlink copying to `copy-directory'. >> Michael, could you review the patch carefully, or suggest some other >> solution? > > Looks good. It works also for remote files. Thanks for checking. I've committed it to the branch. From unknown Sun Jun 22 08:10:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 May 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator