GNU bug report logs - #59807
29.0.60; [PATCH] python-ts-mode does not auto-complete the closing quote

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kai Ma <justksqsf <at> gmail.com>
Subject: bug#59807: closed (Re: bug#59807: 29.0.60; [PATCH] python-ts-mode
 does not  auto-complete the closing quote)
Date: Wed, 14 Dec 2022 02:09:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#59807: 29.0.60; [PATCH] python-ts-mode does not auto-complete the closing quote

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 59807 <at> debbugs.gnu.org.

-- 
59807: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59807
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: yuf011 <at> ucsd.edu
Cc: Kai Ma <justksqsf <at> gmail.com>, eliz <at> gnu.org,
 Stefan Kangas <stefankangas <at> gmail.com>, 59807-done <at> debbugs.gnu.org
Subject: Re: bug#59807: 29.0.60; [PATCH] python-ts-mode does not 
 auto-complete the closing quote
Date: Tue, 13 Dec 2022 18:08:27 -0800

Yuan Fu <yuf011 <at> ucsd.edu> writes:

>> On Dec 12, 2022, at 6:24 PM, Stefan Kangas <stefankangas <at> gmail.com> wrote:
>> 
>> Kai Ma <justksqsf <at> gmail.com> writes:
>> 
>>> Unfortunately, I cannot complete the assignment process, at least for
>>> now. The licensing officer at my university is really reluctant to
>>> sign a copyright disclaimer for me.
>> 
>> Thanks for trying.
>
> Yes, thanks!
>
>> 
>>> However, the cumulative number of lines changed by me is below 15 so
>>> far, so at least for this issue, we can move forward. I’ve added
>>> Copyright-paperwork-exempt in the attached patch.
>> 
>> -ENOPATCH
>> 
>
> I can see his patch. I attached it below.

I applied the patch. Due to recent changes on the branch I needed to
modify it a little.  As a result, the patch contains fewer lines of
change.

Yuan

[Message part 3 (message/rfc822, inline)]

From: Kai Ma <justksqsf <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; [PATCH] python-ts-mode does not auto-complete the closing
 quote
Date: Sun, 04 Dec 2022 06:27:18 +0800

[Message part 4 (text/plain, inline)]

When electric-pair-mode is enabled, a single quote ' should be auto
completed to be '' (which means an empty string).  Python-mode correctly
does this, but python-ts-mode does not.  This is clearly a problem
regarding the syntax table.

The attached patch makes python-ts-mode uses the same syntax table as
python-mode's, and fixes this problem.  I also checked a few other ts
modes, and some also have this issue.  For example, js-ts-mode does not
auto complete '' either, which is also fixed by this patch.

[0001-Fix-syntax-tables-of-tree-sitter-modes.patch (text/x-patch, attachment)]

[Message part 6 (text/plain, inline)]

Kai

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.