GNU bug report logs - #59802
30.0.50; Checkbox button not rendered

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: stephen.berman <at> gmx.net, 59802 <at> debbugs.gnu.org
Subject: bug#59802: 30.0.50; Checkbox button not rendered
Date: Tue, 13 Dec 2022 18:40:51 +0200

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: stephen.berman <at> gmx.net,  59802 <at> debbugs.gnu.org
> Date: Tue, 13 Dec 2022 17:16:28 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> [...]
> 
> > I'm not sure I understand the reason for "else if".  Isn't possible
> > that both conditions could be true?
> 
> True for both conditions is unlikely because we are into a "if (! (0 <
> viewbox_width && 0 < viewbox_height))" so either viewbox_height is zero
> or viewbox_width is zero.

Perhaps this means you need to reshuffle the code so that the case
where both dimensions are non-zero comes the first.  Then you will
have fewer negations in the conditions and the code will be easier to
read and understand.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.