GNU bug report logs - #598
23.0.60; frame size issue (--geometry or default-frame-alist) when using customized default face

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Tim Van Holder <tim.vanholder <at> gmail.com>, 598 <at> debbugs.gnu.org
Cc: Chong Yidong <cyd <at> stupidchicken.com>
Subject: bug#598: 23.0.60;	frame size issue (--geometry or default-frame-alist) when using	customized default face
Date: Tue, 07 Oct 2008 14:09:12 +0200

> Unfortunately, even after a maintainer-clean + make bootstrap, the issue is not
> resolved for me.  In fact, the very first run of the new emacs
> resulted in a frame that
> was 168x61 instead of 132x57 (is that 132x60->132x57 as a result of
> menu/toolbars
> considered a bug or a feature?).

Could you try commenting out the code below from x_figure_window_size in
frame.c and tell whether and how the behavior changes?

  if (toolbar_p && FRAME_TOOL_BAR_LINES (f))
    {
      int margin, relief, bar_height;

      relief = (tool_bar_button_relief >= 0
		? tool_bar_button_relief
		: DEFAULT_TOOL_BAR_BUTTON_RELIEF);

      if (INTEGERP (Vtool_bar_button_margin)
	  && XINT (Vtool_bar_button_margin) > 0)
	margin = XFASTINT (Vtool_bar_button_margin);
      else if (CONSP (Vtool_bar_button_margin)
	       && INTEGERP (XCDR (Vtool_bar_button_margin))
	       && XINT (XCDR (Vtool_bar_button_margin)) > 0)
	margin = XFASTINT (XCDR (Vtool_bar_button_margin));
      else
	margin = 0;

      bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief;
      FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
    }

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.