GNU bug report logs -
#59754
[PATCH] scripts: repl: Add --interactive and --list-types flags.
Previous Next
Reported by: Antero Mejr <antero <at> mailbox.org>
Date: Fri, 2 Dec 2022 02:58:01 UTC
Severity: normal
Tags: patch
Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):
Hi,
Thanks, nice!
On Fri, 02 Dec 2022 at 02:56, Antero Mejr via Guix-patches via <guix-patches <at> gnu.org> wrote:
> * guix/scripts/repl.scm (guix-repl): Honor -i, --interactive flag.
> (%options): Add -i/--interactive and --l/--list-types.
-^
Typo
The patch LGTM, minor three comments.
1. I would not use the shortkey -l; only the long one.
2. I would move --list-types right before -t/--type
--8<---------------cut here---------------start------------->8---
--list-types display REPL types and exit
-t, --type=TYPE start a REPL of the given TYPE
--listen=ENDPOINT listen to ENDPOINT instead of standard input
-q inhibit loading of ~/.guile
-i, --interactive launch REPL after evaluating FILE
-L, --load-path=DIR prepend DIR to the package module search path
-h, --help display this help and exit
-V, --version display version information and exit
--8<---------------cut here---------------end--------------->8---
3. I would split the addition of --list-types and --interactive in two
separated commits. But for each option, I would also change the manual
with the same commit. Else, please squash this submission. :-)
Cheers,
simon
This bug report was last modified 2 years and 121 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.