GNU bug report logs - #59742
server-tests failures

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59742 in the body.
You can then email your comments to 59742 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Jim Porter <jporterbugs <at> gmail.com>
Subject: server-tests failures
Date: Thu, 1 Dec 2022 16:01:45 +0100

The server-tests still fail for an apparent variety of reasons. The behaviour differs depending how the test is run: from a terminal, from ´M-x compile`, interactively via `M-x ert`, Emacs started with or without `-nw`, and so on.

At least the batch-mode tests would cease failing if we just applied the following:

 (defconst server-tests/can-create-frames-p
-  (not (memq system-type '(windows-nt ms-dos)))
+  (and window-system (not (memq system-type '(windows-nt ms-dos))))

Any reason not to?

Even so, there is still a failure if run interactively (M-x ert), and a created frame isn't removed properly.

Message #8 received at 59742 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>,
 59742 <at> debbugs.gnu.org
Subject: Re: bug#59742: server-tests failures
Date: Thu, 1 Dec 2022 09:24:19 -0800

On 12/1/2022 7:01 AM, Mattias Engdegård wrote:
> At least the batch-mode tests would cease failing if we just applied the following:
> 
>   (defconst server-tests/can-create-frames-p
> -  (not (memq system-type '(windows-nt ms-dos)))
> +  (and window-system (not (memq system-type '(windows-nt ms-dos))))
> 
> Any reason not to?

These tests pass on GNU/Linux when 'window-system' is nil, so I think 
we'd need a different way to check things.

> Even so, there is still a failure if run interactively (M-x ert), and a created frame isn't removed properly.

I'll see if I can improve the tests when run interactively, though I'm 
not sure that will affect the first part of this bug.

Message #11 received at 59742 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59742 <at> debbugs.gnu.org
Subject: Re: bug#59742: server-tests failures
Date: Thu, 1 Dec 2022 18:42:42 +0100

1 dec. 2022 kl. 18.24 skrev Jim Porter <jporterbugs <at> gmail.com>:

> These tests pass on GNU/Linux when 'window-system' is nil, so I think we'd need a different way to check things.

They evidently don't pass on the (Linux) CI server either. No wonder, if they rely on the ability to create new frames.

Message #14 received at 59742 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59742 <at> debbugs.gnu.org
Subject: Re: bug#59742: server-tests failures
Date: Fri, 2 Dec 2022 17:45:37 +0100

I pushed (to emacs-29) an experimental change to fix one of the test that didn't clean up its frame, and to avoid running frame-creating tests when TERM=dumb which is what M-x compile uses.

Please give it a try. Let's see how the CI takes it.

Message #19 received at 59742-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59742-done <at> debbugs.gnu.org
Subject: Re: bug#59742: server-tests failures
Date: Sat, 3 Dec 2022 16:20:21 +0100

> Let's see how the CI takes it.

Looks like it's happy now. Closing now, but do tell if you have misgivings.

Message #22 received at 59742 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 59742 <at> debbugs.gnu.org, mattias.engdegard <at> gmail.com
Subject: Re: bug#59742: server-tests failures
Date: Fri, 9 Dec 2022 23:02:23 -0800

On 12/3/2022 7:20 AM, Mattias Engdegård wrote:
>> Let's see how the CI takes it.
> 
> Looks like it's happy now. Closing now, but do tell if you have misgivings.

Thanks. I finally had a chance to look into this myself. I pushed one 
tiny fix (3785fe52e4692ffef14c0a1e50361c22d66fabe8) so that the tests 
pass on GNU/Linux when run from a terminal.

Message #25 received at 59742 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59742 <at> debbugs.gnu.org
Subject: Re: bug#59742: server-tests failures
Date: Sat, 10 Dec 2022 11:09:58 +0100

10 dec. 2022 kl. 08.02 skrev Jim Porter <jporterbugs <at> gmail.com>:

> I pushed one tiny fix (3785fe52e4692ffef14c0a1e50361c22d66fabe8) so that the tests pass on GNU/Linux when run from a terminal.

Looks fine; now back-ported to emacs-29.
(These days we mostly prefer `dolist` to `mapc`, but there is no reason to change your code!)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.