GNU bug report logs - #5974
23.1.95; enabling disabled cmd & saving doesn't respect `custom-file'

Previous Next

Full log

Message #25 received at 5974 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicolas Richard <nrichard <at> ulb.ac.be>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 5974 <at> debbugs.gnu.org
Subject: Re: bug#5974: 23.1.95;
 enabling disabled cmd & saving doesn't respect `custom-file'
Date: Fri, 29 Apr 2016 01:08:34 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Nicolas Richard <nrichard <at> ulb.ac.be> writes:
>
>> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>>> That's the code that puts
>>>
>>> (put 'narrow-to-region 'disabled nil)
>>>
>>> into our .emacs files, right?  Yes, it would be better if that was
>>> handled by Custom.  But how?  Custom works by setting (variable) values,
>>> not adjusting symbol properties...
>>
>> We could add a defcustom like
>> (defcustom enabled-commands nil
>>   "List of commands to enable"
>>   :set (lambda (sym val)
>>          (dolist (cmd val)
>>            (put cmd 'disabled nil))
>>          (set-default sym val)))
>
> Hm...  the `set-default' wouldn't be necessary, would it?  

But otherwise this seems like a good idea.  We do potentially have
clobbering definitions -- where there is a

(put 'narrow-to-region 'disabled nil)

in the buffer, and then it's also customised...

But I don't really think this is much of a problem in practice.

If that defcustom form works, then I'm all for changing over the
enabled-command stuff to customise.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.