GNU bug report logs - #59735
29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently

Previous Next

Package: emacs;

Reported by: jostein <at> kjonigsen.net

Date: Thu, 1 Dec 2022 08:36:02 UTC

Severity: minor

Found in version 29.0.60

Fixed in version 29.1

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Theodor Thornhill <theo <at> thornhill.no>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 59735 <at> debbugs.gnu.org
Subject: bug#59735: 29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently
Date: Tue, 06 Dec 2022 11:22:52 +0100
Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:

> I almost forgot about this one.
>

Same!

> Here's a patch which solves this issue.
>

Thanks! LGTM - Yuan, will you install?

Theo

> --
> Jostein
> From 2922c5cd3be95cbd7dfc5b427e0bb38b4daf15ea Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Jostein=20Kj=C3=B8nigsen?= <jostein <at> kjonigsen.net>
> Date: Tue, 6 Dec 2022 09:40:03 +0100
> Subject: [PATCH] lisp/progmodes/csharp-mode.el: consistent fontification of
>  using-directives
>
> ---
>  lisp/progmodes/csharp-mode.el | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> index 054dabfed07..bdddb46e727 100644
> --- a/lisp/progmodes/csharp-mode.el
> +++ b/lisp/progmodes/csharp-mode.el
> @@ -748,8 +748,11 @@ csharp-ts-mode--font-lock-settings
>     :language 'c-sharp
>     :feature 'definition
>     :override t
> -   '((qualified_name (identifier) @font-lock-variable-name-face)
> +   '((qualified_name (identifier) @font-lock-type-face)
>       (using_directive (identifier) @font-lock-type-face)
> +     (using_directive (name_equals
> +                       (identifier) @font-lock-type-face
> +                       ["="] @default-face))
>  
>       (enum_declaration (identifier) @font-lock-type-face)
>       (enum_member_declaration (identifier) @font-lock-variable-name-face)
> -- 
> 2.34.1




This bug report was last modified 2 years and 215 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.