GNU bug report logs - #59735
29.0.60; csharp-ts-mode: imported namespaces are fontified inconsistently

Previous Next

Full log

Message #16 received at 59735 <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>
Cc: 59735 <at> debbugs.gnu.org
Subject: Re: 29.0.60; csharp-ts-mode: imported namespaces are fontified
 inconsistently
Date: Tue, 6 Dec 2022 09:50:57 +0100

[Message part 1 (text/plain, inline)]

I almost forgot about this one.

Here's a patch which solves this issue.

--
Jostein

On 01.12.2022 10:23, Jostein Kjønigsen wrote:
> On 01.12.2022 09:45, Theodor Thornhill wrote:
>> I don't have a strong preference there, so open to suggestions,
>> absolutely.
>>
>> How does visual studio or vscode do it?
>
> VSCode fontifies all namespaces using the same font as types, both in 
> imports and in declarations.
>
> I'm OK with either, but we should at least be consistent.
>
> Historically we've used variable-name face, but I can see for custom 
> imports (for instance "using List = System.Collections.ArrayList;") it 
> might look better if we use this occasion to change to type-face?
>
>> BTW, you should add CC's to the X-Debbugs-CC header, not as a normal CC.
>> That way I won't get CC'd until after the bug is created, and can reply
>> directly :)
>
> I'm not able to send emails from Emacs, so I copy paste all these 
> things into my regular email-client.
>
> No such ability to set a header there :)
>
> -- 
> Jostein

[0001-lisp-progmodes-csharp-mode.el-consistent-fontificati.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.