GNU bug report logs - #59728
30.0.50; package-vc does not handle package-quickstart

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Matt Armstrong <matt <at> rfc20.org>
Cc: 59728 <at> debbugs.gnu.org, stefan monnier <monnier <at> iro.umontreal.ca>
Subject: bug#59728: 30.0.50; package-vc does not handle package-quickstart
Date: Wed, 30 Nov 2022 19:53:01 +0000

[Message part 1 (text/plain, inline)]

Matt Armstrong <matt <at> rfc20.org> writes:

> X-debbugs-cc: Philip Kaludercic <philipk <at> posteo.net>, Stefan Monnier <monnier <at> iro.umontreal.ca>
>
> package.el provides `package-quickstart':
>
>     package-quickstart is a variable defined in ‘package.el’.
>
>     Its value is t
>     Original value was nil
>
>     Precompute activation actions to speed up startup.
>     This requires the use of ‘package-quickstart-refresh’ every time the
>     activations need to be changed, such as when ‘package-load-list’ is modified.
>
> This places a package-quickstart.elc file in `user-emacs-directory' that
> is loaded at startup, instead of loading the individual
> `user-emacs-directory'/elpa/*-autoloads.el files.
>
> In practice package.el takes care of calling
> `package-quickstart-refresh' as needed.  As a user making normal use of
> package.el I don't believe I have ever needed to call
> `package-quickstart-refresh' manually.
>
> I am playing with package-vc.el and immediately noticed that functions
> like `package-vc-install-from-checkout' and `package-vc-rebuild' do not
> call `package-quickstart-refresh'.
>
> The effect is that package-vc leaves a "stale" package-quickstart.elc in
> the `user-emacs-directory', and the user must run
> `package-quickstart-refresh' manually.
>
> Ideally the various `package-vc-*' functions take care of running the
> function when necessary.

The central function here is `package-vc--unpack-1' so the following
patch should take care of that:

[Message part 2 (text/plain, inline)]

diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index a4520ab800..5f7674190b 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -433,7 +433,8 @@ package-vc--unpack-1
                               (car load-path))))
                   (current-buffer))
            (buffer-string))
-         nil (expand-file-name auto-name pkg-dir))))
+         nil (expand-file-name auto-name pkg-dir)))
+      (package-quickstart-refresh))
 
     ;; Generate package file
     (package-vc--generate-description-file pkg-desc pkg-file)

[Message part 3 (text/plain, inline)]

However I am uncertain if this is too aggressive?  I don't have the time
to test it properly right now, but could try this (or some variation
thereof) and tell me if it addresses the issue?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.