From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 13:35:16 2022 Received: (at submit) by debbugs.gnu.org; 30 Nov 2022 18:35:16 +0000 Received: from localhost ([127.0.0.1]:34381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0RvP-0001zZ-JJ for submit@debbugs.gnu.org; Wed, 30 Nov 2022 13:35:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:33418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0RvN-0001zQ-7x for submit@debbugs.gnu.org; Wed, 30 Nov 2022 13:35:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0RvM-000125-UW for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 13:35:13 -0500 Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0RvK-0004xh-AD for bug-gnu-emacs@gnu.org; Wed, 30 Nov 2022 13:35:12 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 25C5F20004 for ; Wed, 30 Nov 2022 18:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1669833306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/8dHMSp0Z2WLP7ADZPYHQc224CrvvnfwD/FlNUP/7nc=; b=VKDWJJcRwev6inQ7tJ55SJws2WvkZGtCWBseWXwvblkli6b/58Hkcg6uEWzXUmAUii2jAU TPfI5VnJgywpdW+lW/9AUn6Fr0auWVkZqS/RMLcF3TSqLQbRjqkCuSGPi+lLlhZg2Z+n64 Qc8pIejtQopdO+tt8LgV+Ab3nSmXnA8rL7c4HbFy5mnOlj0W38hCsJhmPn+k1SPMNQHupQ 8rGeCHCisTsYRYptdar93ATGut+QPcwcoyLC6RYrrqcG6NuN7vJa48UVsC4ERnyCiRS0jL qOddUDrLUxasEA0bMY1OJnHppi8Wr9NBXV8oznUxCsw0xMjWxtidmrU4oYK7XQ== Received: by mac-mini.lan (Postfix) with ESMTPS id 0A9F63CF31 for ; Wed, 30 Nov 2022 10:35:03 -0800 (PST) Received: by naz.lan (Postfix, from userid 1000) id DF77243D9B31; Wed, 30 Nov 2022 10:35:02 -0800 (PST) From: Matt Armstrong To: bug-gnu-emacs@gnu.org Subject: 30.0.50; package-vc does not handle package-quickstart Date: Wed, 30 Nov 2022 10:35:02 -0800 Message-ID: <87iliw8f55.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4b98:dc4:8::227; envelope-from=matt@rfc20.org; helo=relay7-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) X-debbugs-cc: Philip Kaludercic , Stefan Monnier package.el provides `package-quickstart': package-quickstart is a variable defined in =E2=80=98package.el=E2=80= =99. Its value is t Original value was nil Precompute activation actions to speed up startup. This requires the use of =E2=80=98package-quickstart-refresh=E2=80=99 e= very time the activations need to be changed, such as when =E2=80=98package-load-list= =E2=80=99 is modified. This places a package-quickstart.elc file in `user-emacs-directory' that is loaded at startup, instead of loading the individual `user-emacs-directory'/elpa/*-autoloads.el files. In practice package.el takes care of calling `package-quickstart-refresh' as needed. As a user making normal use of package.el I don't believe I have ever needed to call `package-quickstart-refresh' manually. I am playing with package-vc.el and immediately noticed that functions like `package-vc-install-from-checkout' and `package-vc-rebuild' do not call `package-quickstart-refresh'. The effect is that package-vc leaves a "stale" package-quickstart.elc in the `user-emacs-directory', and the user must run `package-quickstart-refresh' manually. Ideally the various `package-vc-*' functions take care of running the function when necessary. ---------------------------------------------------------------------- In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.16.0) of 2022-11-30 built on naz Repository revision: 1abda0c83981a6d35dd4b2dd3e88e9886d13cb09 Repository branch: master System Description: Debian GNU/Linux bookworm/sid Configured using: 'configure 'CFLAGS=3D-Og -g3 -fsanitize=3Daddress' 'CXXFLAGS=3D-Og -g3 -fsanitize=3Daddress' LDFLAGS=3D-static-libasan --enable-checking=3Dyes --enable-check-lisp-object-type --with-pgtk' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t bug-reference-prog-mode: t msb-mode: t display-time-mode: t flyspell-mode: t global-tab-line-mode: t tab-line-mode: t server-mode: t shell-dirtrack-mode: t auto-insert-mode: t keyfreq-autosave-mode: t keyfreq-mode: t savehist-mode: t icomplete-vertical-mode: t icomplete-mode: t editorconfig-mode: t which-key-mode: t electric-pair-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t Load-path shadows: ~/env/elisp/ol-notmuch hides /home/matt/.config/emacs/elpa/ol-notmuch-2.0.0= /ol-notmuch /home/matt/.config/emacs/elpa/transient-0.3.7/transient hides /home/matt/gi= t/e/daily-driver/lisp/transient Features: (shadow sort mail-extr dabbrev emacsbug shortdoc cl-print cus-edit pp cus-start cus-load badautoloads-autoloads magit-extras face-remap magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu edebug debug backtrace magit-diff smerge-mode diff git-commit log-edit add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor magit-mode magit-git dired-aux copyright mule-util magit-utils crm loaddefs-gen mm-archive network-stream url-cache url-http url-auth url-gw nsm vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util package-vc vc lisp-mnt package-x misearch multi-isearch vc-git diff-mode vc-dispatcher bug-reference protbuf msb time flyspell ispell org-element org-persist org-id avl-tree ol-w3m ol-rmail ol-mhe ol-irc ol-info org-habit org-agenda org-refile ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win ol-eww eww xdg url-queue shr pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils range wid-edit mm-util mail-prsvr ol-doi org-link-doi ol-docview doc-view filenotify jka-compr image-mode exif dired dired-loaddefs ol-bibtex bibtex iso8601 ol-bbdb midnight tab-line server geiser-guile info-look transient geiser-debug geiser-repl compile text-property-search geiser-image geiser-capf geiser-doc geiser-menu geiser-autodoc geiser-edit etags fileloop generator xref geiser-completion geiser-eval geiser-connection tq geiser-syntax scheme geiser-log geiser-popup view geiser web-mode disp-table nix-mode ffap thingatpt smie nix-repl nix-shell nix-store magit-section dash nix-log nix-instantiate nix-shebang nix-format nix finder-inf dirtrack ob-shell shell ob-ruby ob-python python pcase treesit ob-dot org-protocol org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete comint ansi-osc ansi-color org-list org-footnote org-faces org-entities time-date noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs ol-notmuch ol rx org-fold org-fold-core org-compat org-version org-macs format-spec skeleton autoinsert advice keyfreq project edmacro kmacro warnings icons savehist icomplete editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch which-key package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core password-cache json subr-x map byte-opt url-vars cl-extra cl-macs gv cl-seq elec-pair use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core bytecomp byte-compile info geiser-guile-autoloads geiser-impl help-fns radix-tree help-mode cl-loaddefs cl-lib geiser-custom geiser-base ring geiser-autoloads orderless-autoloads nix-mode-autoloads graphviz-dot-mode-autoloads markdown-mode-autoloads org-drill-autoloads persist-autoloads ox-hugo-autoloads tomelr-autoloads ol-notmuch-autoloads notmuch-autoloads pylint-autoloads elpy-autoloads highlight-indentation-autoloads pyvenv-autoloads s-autoloads flymake-ruby-autoloads flymake-easy-autoloads go-mode-autoloads yasnippet-autoloads company-autoloads shfmt-autoloads flymake-yamllint-autoloads yaml-mode-autoloads debbugs-autoloads bazel-autoloads clang-format+-autoloads clang-format-autoloads google-c-style-autoloads cmake-mode-autoloads meson-mode-autoloads d-mode-autoloads magit-autoloads git-commit-autoloads transient-autoloads magit-section-autoloads dash-autoloads with-editor-autoloads vertico-autoloads editorconfig-autoloads which-key-autoloads exec-path-from-shell-autoloads use-package-autoloads bind-key-autoloads envrc-autoloads inheritenv-autoloads web-mode-autoloads nixpkgs-fmt-autoloads reformatter-autoloads rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 654397 159228) (symbols 48 41290 29) (strings 32 217792 26674) (string-bytes 1 6059735) (vectors 16 76757) (vector-slots 8 887126 115596) (floats 8 417 667) (intervals 56 8512 1191) (buffers 984 31)) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 14:53:13 2022 Received: (at 59728) by debbugs.gnu.org; 30 Nov 2022 19:53:13 +0000 Received: from localhost ([127.0.0.1]:34752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T8q-0004xs-Cl for submit@debbugs.gnu.org; Wed, 30 Nov 2022 14:53:13 -0500 Received: from mout02.posteo.de ([185.67.36.66]:38729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0T8l-0004xY-SP for 59728@debbugs.gnu.org; Wed, 30 Nov 2022 14:53:11 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 80CDD240103 for <59728@debbugs.gnu.org>; Wed, 30 Nov 2022 20:53:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669837981; bh=XJS+woZMEr6vvJLpIn5CzgAG5lIQFeZT/pTs7cU+7Q4=; h=From:To:Cc:Subject:Date:From; b=ZUFJjyJacTjAqvxs9QUKxJBYCCGcCTkRvmtXJkbgiRTExtTXB3FlntY5bHLbi3CgK 9FhI8UbcSziRVoqLiWu0i/jDKEH/xw0s56WVHb16LztzOuZ8XASyYQnU82hz/somKD eaxsKCruWR6BsyFy4f6zHl6/TLjjgw9JbScmIJdmDicuoUShQ/bJDcpjbHNefTx/yS Z8Ic6i4NC4yAajdxRA60YXjnRb4D4d34MwcWCEc5pY8KcXrs/IBWKzPExUA6paOlSf dGmIJUCXSDadJvmV2WMk1hJpUs7WKAv62OfSMR4Qk6vKQ9WIufa8Wau5wtngPREkuh USk4+wNS3vyXA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NMqcp6MhLz6tpD; Wed, 30 Nov 2022 20:52:58 +0100 (CET) From: Philip Kaludercic To: Matt Armstrong Subject: Re: bug#59728: 30.0.50; package-vc does not handle package-quickstart In-Reply-To: <87iliw8f55.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 30 Nov 2022 10:35:02 -0800") References: <87iliw8f55.fsf@rfc20.org> Date: Wed, 30 Nov 2022 19:53:01 +0000 Message-ID: <87y1rsw76q.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59728 Cc: 59728@debbugs.gnu.org, stefan monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Matt Armstrong writes: > X-debbugs-cc: Philip Kaludercic , Stefan Monnier > > package.el provides `package-quickstart': > > package-quickstart is a variable defined in =E2=80=98package.el=E2=80= =99. > > Its value is t > Original value was nil > > Precompute activation actions to speed up startup. > This requires the use of =E2=80=98package-quickstart-refresh=E2=80=99= every time the > activations need to be changed, such as when =E2=80=98package-load-li= st=E2=80=99 is modified. > > This places a package-quickstart.elc file in `user-emacs-directory' that > is loaded at startup, instead of loading the individual > `user-emacs-directory'/elpa/*-autoloads.el files. > > In practice package.el takes care of calling > `package-quickstart-refresh' as needed. As a user making normal use of > package.el I don't believe I have ever needed to call > `package-quickstart-refresh' manually. > > I am playing with package-vc.el and immediately noticed that functions > like `package-vc-install-from-checkout' and `package-vc-rebuild' do not > call `package-quickstart-refresh'. > > The effect is that package-vc leaves a "stale" package-quickstart.elc in > the `user-emacs-directory', and the user must run > `package-quickstart-refresh' manually. > > Ideally the various `package-vc-*' functions take care of running the > function when necessary. The central function here is `package-vc--unpack-1' so the following patch should take care of that: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index a4520ab800..5f7674190b 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -433,7 +433,8 @@ package-vc--unpack-1 (car load-path)))) (current-buffer)) (buffer-string)) - nil (expand-file-name auto-name pkg-dir)))) + nil (expand-file-name auto-name pkg-dir))) + (package-quickstart-refresh)) ;; Generate package file (package-vc--generate-description-file pkg-desc pkg-file) --=-=-= Content-Type: text/plain However I am uncertain if this is too aggressive? I don't have the time to test it properly right now, but could try this (or some variation thereof) and tell me if it addresses the issue? --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 19:15:24 2022 Received: (at 59728) by debbugs.gnu.org; 1 Dec 2022 00:15:24 +0000 Received: from localhost ([127.0.0.1]:35964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0XEZ-0005j9-L4 for submit@debbugs.gnu.org; Wed, 30 Nov 2022 19:15:24 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:46707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0XEI-0005iP-9G for 59728@debbugs.gnu.org; Wed, 30 Nov 2022 19:15:22 -0500 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 3E2C560002; Thu, 1 Dec 2022 00:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1669853697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dvT3BqfkibxcGTkNBO5E/WPzMataUAss59P9fgEvfFg=; b=GOXXMeThfxfhRBeXVQgH/Rt1BI/wLrzS7qBC+3yNevsvVyv3cFkFkwh5/kbPKlgxXne/FG ghL1ahcj6dTI1vDNbu+mI4vsl0ta6MUbcjxx/txKYFahibH8Z8mm8RTF02c9/kcq8An/Gb 71egAjZVyFER+PcoqZVezX7R56ZXduPTAuxw1NkshajJ3/Ag592oODdZFUhaLkJ4gtPDnb d76v9iA26DEZasA10h+MRkgJbtZhwyTGF7XJh+YX6a1mxjHR23xCNMvqQypgzG1UUnrKiI NFth58X8ipxZQ/Lrp8Ck4Ouc5LJ8HItdNqpGYSyQYlUatxtzFhdVU6PfjZC6wQ== Received: by mac-mini.lan (Postfix) with ESMTPS id 5E97C3CF89; Wed, 30 Nov 2022 16:14:53 -0800 (PST) Received: by naz.lan (Postfix, from userid 1000) id 3AB0A43DC006; Wed, 30 Nov 2022 16:14:53 -0800 (PST) From: Matt Armstrong To: Philip Kaludercic Subject: Re: bug#59728: 30.0.50; package-vc does not handle package-quickstart In-Reply-To: <87y1rsw76q.fsf@posteo.net> References: <87iliw8f55.fsf@rfc20.org> <87y1rsw76q.fsf@posteo.net> Date: Wed, 30 Nov 2022 16:14:53 -0800 Message-ID: <87bkoo7zeq.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59728 Cc: 59728@debbugs.gnu.org, stefan monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > The central function here is `package-vc--unpack-1' so the following > patch should take care of that: > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index a4520ab800..5f7674190b 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -433,7 +433,8 @@ package-vc--unpack-1 > (car load-path)))) > (current-buffer)) > (buffer-string)) > - nil (expand-file-name auto-name pkg-dir)))) > + nil (expand-file-name auto-name pkg-dir))) > + (package-quickstart-refresh)) > > ;; Generate package file > (package-vc--generate-description-file pkg-desc pkg-file) > > However I am uncertain if this is too aggressive? I don't have the time > to test it properly right now, but could try this (or some variation > thereof) and tell me if it addresses the issue? I moved the call to `package-quickstart-refresh' down, as it byte compiles the autoloads and judging from other comments in this function, and also discussion in bug#59707, that is best done after the new version of the package is loaded. Also, the two `package--quickstart-maybe-refresh' calls in package.el are just after a `package--save-selected-packages' call, so I did the same here. The seems to work fine in my manual testing. Thanks for the tip! As for whether this is too aggressive, I'm not sure. Seems about as aggressive as package.el is today. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0002-Refresh-the-package-quickstart-file-in-package-vc.patch >From b74f1ac29f6427094a6beb15a6a0227f750281c3 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Wed, 30 Nov 2022 15:58:07 -0800 Subject: [PATCH 2/2] Refresh the package quickstart file in package-vc * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Call `package--quickstart-maybe-refresh', just as `package-install-from-buffer' does. (bug#59728) --- lisp/emacs-lisp/package-vc.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index a4520ab800..04b4c81c13 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -464,6 +464,7 @@ package-vc--unpack-1 (package--save-selected-packages (cons (package-desc-name pkg-desc) package-selected-packages)) + (package--quickstart-maybe-refresh) ;; Confirm that the installation was successful (let ((main-file (package-vc--main-file pkg-desc))) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 04:01:43 2022 Received: (at 59728) by debbugs.gnu.org; 10 Dec 2022 09:01:43 +0000 Received: from localhost ([127.0.0.1]:41573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3vjr-0006LZ-09 for submit@debbugs.gnu.org; Sat, 10 Dec 2022 04:01:43 -0500 Received: from mout01.posteo.de ([185.67.36.65]:59635) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3vjo-0006LR-H4 for 59728@debbugs.gnu.org; Sat, 10 Dec 2022 04:01:41 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id F404F24002E for <59728@debbugs.gnu.org>; Sat, 10 Dec 2022 10:01:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670662895; bh=m1DQG+Vtw3VzaPN4cGi7oQSwmvQDqpMZj2w1+cYvn14=; h=From:To:Cc:Subject:Date:From; b=rL/Dvx5XtL75/KMmAVdcxQ45OjbHNBEkl5CohZ6If+VQob/QtnzyvE/OGKPfyXecI wBa7fULItY+LneC2pQRGVJMhL2++iSnml4MBAGPkP7u3a9uQv0q7VJrOc5h2TwfgF2 OiCMJSHztcY/kWz0Slb6du7A93rdk97iEtdU+NPBf3wkFOGMVkU9koYU3hCvn4xbEt zT4y5DzYTuQZMCu6QlK2i2Y9g6gVinQPf6YVyJ0Lxj/+YruBl8+2k4oiMxHLxP7tU+ yahoPQ74aD6UKRlIayAaJuyaQTRfWTH9JkwUdUXEesNHmqVBr7MqOYqbhtWTPQpBgD xH0k7AX6myDFA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NThhZ0gcmz9rxR; Sat, 10 Dec 2022 10:01:33 +0100 (CET) From: Philip Kaludercic To: Matt Armstrong Subject: Re: bug#59728: 30.0.50; package-vc does not handle package-quickstart In-Reply-To: <87bkoo7zeq.fsf@rfc20.org> (Matt Armstrong's message of "Wed, 30 Nov 2022 16:14:53 -0800") References: <87iliw8f55.fsf@rfc20.org> <87y1rsw76q.fsf@posteo.net> <87bkoo7zeq.fsf@rfc20.org> Date: Sat, 10 Dec 2022 09:01:37 +0000 Message-ID: <87pmcrhbta.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59728 Cc: 59728@debbugs.gnu.org, stefan monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Matt Armstrong writes: > Philip Kaludercic writes: > >> The central function here is `package-vc--unpack-1' so the following >> patch should take care of that: >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index a4520ab800..5f7674190b 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -433,7 +433,8 @@ package-vc--unpack-1 >> (car load-path)))) >> (current-buffer)) >> (buffer-string)) >> - nil (expand-file-name auto-name pkg-dir)))) >> + nil (expand-file-name auto-name pkg-dir))) >> + (package-quickstart-refresh)) >> >> ;; Generate package file >> (package-vc--generate-description-file pkg-desc pkg-file) >> >> However I am uncertain if this is too aggressive? I don't have the time >> to test it properly right now, but could try this (or some variation >> thereof) and tell me if it addresses the issue? > > I moved the call to `package-quickstart-refresh' down, as it byte > compiles the autoloads and judging from other comments in this function, > and also discussion in bug#59707, that is best done after the new > version of the package is loaded. > > Also, the two `package--quickstart-maybe-refresh' calls in package.el > are just after a `package--save-selected-packages' call, so I did the > same here. > > The seems to work fine in my manual testing. Thanks for the tip! > > As for whether this is too aggressive, I'm not sure. Seems about as > aggressive as package.el is today. > > From b74f1ac29f6427094a6beb15a6a0227f750281c3 Mon Sep 17 00:00:00 2001 > From: Matt Armstrong > Date: Wed, 30 Nov 2022 15:58:07 -0800 > Subject: [PATCH 2/2] Refresh the package quickstart file in package-vc > > * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Call > `package--quickstart-maybe-refresh', just as > `package-install-from-buffer' does. (bug#59728) > --- > lisp/emacs-lisp/package-vc.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el > index a4520ab800..04b4c81c13 100644 > --- a/lisp/emacs-lisp/package-vc.el > +++ b/lisp/emacs-lisp/package-vc.el > @@ -464,6 +464,7 @@ package-vc--unpack-1 > (package--save-selected-packages > (cons (package-desc-name pkg-desc) > package-selected-packages)) > + (package--quickstart-maybe-refresh) > > ;; Confirm that the installation was successful > (let ((main-file (package-vc--main-file pkg-desc))) Sorry for the delay, I've tested the patch and it seems fine. It has been pushed to the emacs-29 branch. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 10 04:05:37 2022 Received: (at control) by debbugs.gnu.org; 10 Dec 2022 09:05:37 +0000 Received: from localhost ([127.0.0.1]:41601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3vnd-0006QU-9N for submit@debbugs.gnu.org; Sat, 10 Dec 2022 04:05:37 -0500 Received: from mout01.posteo.de ([185.67.36.65]:56129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3vna-0006QM-FX for control@debbugs.gnu.org; Sat, 10 Dec 2022 04:05:36 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id E0C06240026 for ; Sat, 10 Dec 2022 10:05:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1670663128; bh=LBm0XBFGLCnsUVyLCIlD03rVhH+N5mg/GZJ6EOLw9ck=; h=Date:To:From:Subject:From; b=fCZTkc0IVD6jqouTj4OABri+nMjhKe2I9kfSPlmGm9Qya5dXCl2QVRRCwMqayZai5 eYDwB5rvkRlNXDAJ+0pdVRFJK0FPosvNv5H5HhRT159W66RI93Nigmovb6Ftigm82g Nmh63UCCuXAFjugkPeF8yjh7QOL7ojB4RktI/cMFxwH2nffv799FBMFAaYQVtRCaGs n881fRfT4Zazc2zJmTGodFpHjKM7TbwsXddITx+ttqNabfKUi3Gk8gX0HaJ+tg6ctp zzLQsU6lfg+8Uuy7QUyekfANQATJkniWWddGr0jXZx8RQwDlCIKJ+GE4L+1j7Hw9iD SajN6ZSRUeh8w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NThn43nR6z9rxQ for ; Sat, 10 Dec 2022 10:05:28 +0100 (CET) Date: Sat, 10 Dec 2022 09:05:30 +0000 Message-Id: <87lenfhbmt.fsf@posteo.net> To: control@debbugs.gnu.org From: Philip Kaludercic Subject: control message for bug #59728 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 59728 29.1 quit From unknown Mon Aug 18 06:57:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Jan 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator