GNU bug report logs - #59694
[PATCH] gnu: dino: Update to 0.3.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59694 in the body.
You can then email your comments to 59694 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: dino: Update to 0.3.1.
Date: Tue, 29 Nov 2022 21:30:24 +0100

* gnu/packages/messaging.scm (dino): Update to 0.3.1.
[arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
[inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.
---
 gnu/packages/messaging.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..fd7cbf921d 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -1375,7 +1375,7 @@ (define-public gajim-openpgp
 (define-public dino
   (package
     (name "dino")
-    (version "0.3.0")
+    (version "0.3.1")
     (source
      (origin
        (method url-fetch)
@@ -1383,11 +1383,11 @@ (define-public dino
         (string-append "https://github.com/dino/dino/releases/download/v"
                        version "/dino-" version ".tar.gz"))
        (sha256
-        (base32 "07nw275xfamczzvzps8hsnpbhzvr4qc726fx92w8ncmdag7wlw1r"))))
+        (base32 "1rs6qpkidiww805cd91q059r2lm5lzblrkyn01zz4g1mls8ghk5a"))))
     (build-system cmake-build-system)
     (outputs '("out" "debug"))
     (arguments
-     (list #:configure-flags #~(list "-DBUILD_TESTS=true")
+     (list #:configure-flags #~(list "-DBUILD_TESTS=true" "-DUSE_SOUP3=true")
            #:parallel-build? #f         ; not supported
            #:modules '((guix build cmake-build-system)
                        ((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
@@ -1439,7 +1439,7 @@ (define-public dino
            libgee
            libnice
            libsignal-protocol-c
-           libsoup-minimal-2
+           libsoup
            libsrtp                      ;for calls support
            pango
            qrencode
-- 
2.38.1

Message #8 received at 59694 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 59694 <at> debbugs.gnu.org
Subject: Re: [bug#59694] [PATCH] gnu: dino: Update to 0.3.1.
Date: Wed, 30 Nov 2022 12:10:46 -0500 (EST)

[Message part 1 (text/plain, inline)]

On Tue, 29 Nov 2022, Liliana Marie Prikler wrote:

> * gnu/packages/messaging.scm (dino): Update to 0.3.1.
> [arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
> [inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.

Hi,

I built and ran Dino 0.3.1 on x86_64, and it works well for me with no new 
problems. I was able to receive files, which presumably exercises the 
libsoup code paths (I didn't upload any files). The Guix changes look good 
to me. I did not audit upstream changes.

Best,
Jack

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: 59694-done <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, guix-patches <at> gnu.org
Subject: Re: [bug#59694] [PATCH] gnu: dino: Update to 0.3.1.
Date: Tue, 06 Dec 2022 11:40:20 +0000

[Message part 1 (text/plain, inline)]

Jack Hill <jackhill <at> jackhill.us> writes:

> On Tue, 29 Nov 2022, Liliana Marie Prikler wrote:
>
>> * gnu/packages/messaging.scm (dino): Update to 0.3.1.
>> [arguments]<#:configure-flags>: Add “-DUSE_SOUP3=true”.
>> [inputs]: Use ‘libsoup’ rather than ‘libsoup-minimal-2’.
>
> Hi,
>
> I built and ran Dino 0.3.1 on x86_64, and it works well for me with no
> new problems. I was able to receive files, which presumably exercises
> the libsoup code paths (I didn't upload any files). The Guix changes
> look good to me. I did not audit upstream changes.

This also looks good to me. I didn't spot that this was submitted by
Liliana who has commit access, so I ended up pushing this as
d8c8a2987a6709f8a9be007754b5884f189f61f7.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.