GNU bug report logs - #59691
29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression

Previous Next

Full log

View this message in rfc822 format

From: Theodor Thornhill <theo <at> thornhill.no>
To: Yuan Fu <casouri <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59691 <at> debbugs.gnu.org, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>, jostein <at> kjonigsen.net
Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression
Date: Fri, 02 Dec 2022 21:29:28 +0100

Yuan Fu <casouri <at> gmail.com> writes:

>> On Dec 1, 2022, at 4:10 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>> From: Theodor Thornhill <theo <at> thornhill.no>
>>> Cc: casouri <at> gmail.com, jostein <at> secure.kjonigsen.net, 59691 <at> debbugs.gnu.org,
>>> jostein <at> kjonigsen.net
>>> Date: Thu, 01 Dec 2022 11:52:00 +0100
>>> 
>>>> Yes, I missed that, sorry.  But the NEWS entry should clearly say that one
>>>> mode is the default for *.ts files, the other for *.tsx files.
>>> 
>>> No worries :)
>>> 
>>> Is this patch suitable?
>> 
>> LGTM, thanks.
>> 
>> Yuan, if you are okay with this, please install.
>
> Cool. I applied the patch, thanks Theo! I changed typescript-ts-mode—base-mode to typescript-ts-base-mode, since I don’t think anyone has strong opinions about its naming, and typescript-ts-base-mode is more consistent with other tree-sitter base modes.
>
> Yuan

Thanks!  I believe this can be closed.  What do you think, Jostein?

Theo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.