GNU bug report logs - #59691
29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression

Previous Next

Package: emacs;

Reported by: jostein <at> kjonigsen.net

Date: Tue, 29 Nov 2022 20:04:01 UTC

Severity: normal

Found in version 29.0.60

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>, Theodor Thornhill <theo <at> thornhill.no>, jostein <at> kjonigsen.net, 59691 <at> debbugs.gnu.org
Subject: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression
Date: Thu, 1 Dec 2022 20:44:59 -0800


> On Dec 1, 2022, at 4:10 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Theodor Thornhill <theo <at> thornhill.no>
>> Cc: casouri <at> gmail.com, jostein <at> secure.kjonigsen.net, 59691 <at> debbugs.gnu.org,
>> jostein <at> kjonigsen.net
>> Date: Thu, 01 Dec 2022 11:52:00 +0100
>> 
>>> Yes, I missed that, sorry.  But the NEWS entry should clearly say that one
>>> mode is the default for *.ts files, the other for *.tsx files.
>> 
>> No worries :)
>> 
>> Is this patch suitable?
> 
> LGTM, thanks.
> 
> Yuan, if you are okay with this, please install.

Cool. I applied the patch, thanks Theo! I changed typescript-ts-mode—base-mode to typescript-ts-base-mode, since I don’t think anyone has strong opinions about its naming, and typescript-ts-base-mode is more consistent with other tree-sitter base modes.

Yuan
This bug report was last modified 2 years and 229 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.