GNU bug report logs - #59691
29.0.60; typescript-ts-mode: any HTML-like elements causes fontification to become invalid and remaining parse-tree to become jsx-expression

Previous Next

Full log

Message #62 received at 59691 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59691 <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> secure.kjonigsen.net,
 jostein <at> kjonigsen.net
Subject: Re: bug#59691: 29.0.60; typescript-ts-mode: any HTML-like elements
 causes fontification to become invalid and remaining parse-tree to become
 jsx-expression
Date: Thu, 01 Dec 2022 09:44:49 +0200

> From: Theodor Thornhill <theo <at> thornhill.no>
> Cc: casouri <at> gmail.com, jostein <at> secure.kjonigsen.net, 59691 <at> debbugs.gnu.org,
>  jostein <at> kjonigsen.net
> Date: Thu, 01 Dec 2022 07:01:55 +0100
> 
> diff --git a/etc/NEWS b/etc/NEWS
> index 4e091a5fed..439d20960b 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -2972,7 +2972,12 @@ A major mode based on the tree-sitter library for editing programs
>  in the TypeScript language.  It includes support for font-locking,
>  indentation, and navigation.
>  
> -** New major mode 'c-ts-mode'.
> +** New mode 'tsx-ts-mode'.
> +A major mode based on the tree-sitter library for editing programs
> +in the TypeScript language, with support for TSX.  It includes
> +support for font-locking, indentation, and navigation.
> +
> +** New mode 'c-ts-mode'.

Looks like some "git merge" snafu?  You are in fact reverting a change I
made in NEWS yesterday.

> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el
> index 6c926a4e3e..c1beaf3134 100644
> --- a/lisp/progmodes/typescript-ts-mode.el
> +++ b/lisp/progmodes/typescript-ts-mode.el

I don't see a change to auto-mode-alist to turn on each mode for the files
it supports?  I thought this was the idea?  Or is this because we don't want
tree-sitter based modes to be turned on by default?  In that case, how do we
explain to users that they should use each mode in the relevant cases?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.