From unknown Fri Jun 20 07:27:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59689 <59689@debbugs.gnu.org> To: bug#59689 <59689@debbugs.gnu.org> Subject: Status: 29.0.60; csharp-ts-mode: unable to uncomment region commented using comment-region Reply-To: bug#59689 <59689@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:27:39 +0000 retitle 59689 29.0.60; csharp-ts-mode: unable to uncomment region commented= using comment-region reassign 59689 emacs submitter 59689 jostein@kjonigsen.net severity 59689 normal tag 59689 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 14:47:55 2022 Received: (at submit) by debbugs.gnu.org; 29 Nov 2022 19:47:55 +0000 Received: from localhost ([127.0.0.1]:55910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p06aA-000649-BS for submit@debbugs.gnu.org; Tue, 29 Nov 2022 14:47:55 -0500 Received: from lists.gnu.org ([209.51.188.17]:47212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p06a5-000643-Qi for submit@debbugs.gnu.org; Tue, 29 Nov 2022 14:47:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p06a2-0000LZ-Lw for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 14:47:47 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p06Zz-00070g-CO for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 14:47:46 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 624895C00E2; Tue, 29 Nov 2022 14:47:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 29 Nov 2022 14:47:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:reply-to:sender:subject:subject:to:to; s= fm3; t=1669751262; x=1669837662; bh=KchA4CmklprJ8GeeBwE6RWuzLjJG HT4SNpQehl1HWUA=; b=GZvf3F6wOfJpemvo8xMT6vqiqkT8v8t6qzuzakrzalsp KX+Cwg/yd2mzpHqL8Nim+4WU2AnxiuOb1jJu9+VgvmTS5DjELCPEZYrKhsgh0lE/ eWgghM1P7Vyho145f6N+EaA/kTp3qkKtoxkRuL1tbTagu2BJenJqXOsOR+U3aCWN fvnCwzp20nFNCswrlXW1dHZDpanBIU6/Z3k2ftuZALkte/3XpWBUUbynR5mUfTgG td0ipZMfysLuhESx3kF5C9m6Zavzp+i6DMtagtYXvf41zA3eJ3HjW0Z4SdInxwMJ 4mFC+21dLoyJhPpBR2oIYAAa5gucyyqs78rCNqZy0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1669751262; x=1669837662; bh=KchA4CmklprJ8 GeeBwE6RWuzLjJGHT4SNpQehl1HWUA=; b=h+3b5PwLvnOu6ir5HTM0khtigyYdh aiuCHvvspjQq1+Ps/xXAm/5WOA0V9I1SAKCMjMIQL1nwZFZxilhsz6rp7i8ABt3o IaNpl01XWOxmVmoll8e5Efo6b0iOV3zRKVj6aWLqYAld+CKBGaChU29LcRGTLbgn aqLlRXZxUgIkouGL86+UWKxgHEPBsc7ESY2rpdPAjXMAflh9gzz+k7RjQkfoUxqF C9IZlbgJMsFTDsQ+4KFqikw2cRgFXriBPrkjWVXitQCW9is66GtooEr+WuKYnMR5 g/BTfisD7yeLDTp+TX7IWKqOJZpZL9O7aQIm/oR4Ew9ad0K2JGc7jC1JQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtddtgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfvfhrhffutgfgsehtkeertddtfeejnecuhfhrohhmpeflohhsthgv ihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhigh hsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpeehvefhtdegfeejhedtgeeiuefghedt vedufffgfedvfeejvdfhvefhveejfeeghfenucffohhmrghinhepkhhjnhhighhsvghnrd hnohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehj ohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 29 Nov 2022 14:47:41 -0500 (EST) Message-ID: <15b365bb-9cd1-03c4-638c-489f93d679e1@secure.kjonigsen.net> Date: Tue, 29 Nov 2022 20:47:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: nb-NO To: "bug-gnu-emacs@gnu.org" , Theodor Thornhill From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Subject: 29.0.60; csharp-ts-mode: unable to uncomment region commented using comment-region Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.25; envelope-from=jostein@secure.kjonigsen.net; helo=out1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) When I: 1. build emacs from git source, emacs-29 branch 2. open a CS-file and activate csharp-ts-mode. 3. select a region 4. M-x comment-region 5. re-select region. 6. M-x uncomment-region I observe that: Region is not uncommented, but instead I get the following error in *Messages*: uncomment-region-default-1: Can’t find the comment end Instead I expected that: Region should be uncommented. Note: This issue is NOT present with cc-mode based csharp-mode. In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, GTK+ Version  3.24.34, cairo version 1.16.0) of 2022-11-29 built on ThinkPad-T14s Repository revision: c43cdfd639518c5f2e7e7cbbaf1eca40ac957eb0 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Ubuntu 22.10 Configured using:  'configure --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LC_MONETARY: nb_NO.UTF-8   value of $LC_NUMERIC: nb_NO.UTF-8   value of $LC_TIME: nb_NO.UTF-8   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: TypeScript Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   lsp-diagnostics-mode: t   lsp-headerline-breadcrumb-mode: t   lsp-modeline-workspace-status-mode: t   lsp-modeline-diagnostics-mode: t   lsp-modeline-code-actions-mode: t   electric-pair-mode: t   lsp-completion-mode: t   editorconfig-mode: t   flycheck-mode: t   which-function-mode: t   nlinum-mode: t   company-mode: t   global-ede-mode: t   ede-minor-mode: t   dap-tooltip-mode: t   dap-ui-many-windows-mode: t   dap-ui-controls-mode: t   dap-ui-mode: t   treemacs-filewatch-mode: t   treemacs-follow-mode: t   treemacs-git-mode: t   treemacs-fringe-indicator-mode: t   dap-auto-configure-mode: t   dap-mode: t   global-undo-tree-mode: t   undo-tree-mode: t   doom-modeline-mode: t   projectile-mode: t   ido-yes-or-no-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   server-mode: t   shell-dirtrack-mode: t   global-hl-line-mode: t   lsp-managed-mode: t   lsp-mode: t   yas-global-mode: t   yas-minor-mode: t   tooltip-mode: t   global-eldoc-mode: t   eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   auto-fill-function: yas--auto-fill   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20221127.2242/transient hides /home/jostein/build/emacs/lisp/transient /home/jostein/.emacs.d/elpa/eglot-20221020.1010/eglot hides /home/jostein/build/emacs/lisp/progmodes/eglot Features: (shadow sort emacsbug typescript-ts-mode js git-rebase vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view vc bug-reference magit-extras magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm compat-27 compat-26 dired-aux ede/dired flyspell ispell mule-util executable misearch multi-isearch helm-bookmark helm-net helm-adaptive treemacs-bookmarks treemacs-tags bookmark lsp-diagnostics lsp-headerline lsp-icons lsp-modeline face-remap mail-extr helm-command helm-elisp helm-eval helm-info view vc-git diff-mode vc-dispatcher disp-table elec-pair csharp-mode treesit cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs winner ffap tramp-archive tramp-gvfs tramp-cache warnings time-stamp zeroconf dbus add-log lsp-zig lsp-steep lsp-svelte lsp-sqls lsp-ruby-syntax-tree lsp-yaml lsp-xml lsp-vimscript lsp-vhdl lsp-volar lsp-vetur lsp-html lsp-verilog lsp-vala lsp-v lsp-typeprof lsp-ttcn3 lsp-toml lsp-terraform lsp-tex lsp-sorbet lsp-solargraph lsp-rust lsp-rf lsp-remark lsp-racket lsp-r lsp-purescript lsp-pylsp lsp-pyls lsp-php lsp-pls lsp-perlnavigator lsp-perl lsp-openscad lsp-ocaml lsp-magik lsp-nix lsp-nim lsp-nginx lsp-mint lsp-marksman lsp-markdown lsp-lua lsp-kotlin lsp-json lsp-javascript lsp-idris lsp-haxe lsp-groovy lsp-hack lsp-graphql lsp-gleam lsp-go lsp-completion lsp-gdscript lsp-fsharp lsp-fortran lsp-eslint lsp-erlang lsp-emmet lsp-elixir lsp-elm lsp-dockerfile lsp-dhall lsp-d lsp-css lsp-csharp gnutls lsp-crystal lsp-cmake lsp-clojure lsp-semantic-tokens lsp-clangd lsp-beancount lsp-bash lsp-astro lsp-ansible lsp-angular lsp-ada lsp-actionscript ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch flycheck highlight-symbol which-func edebug debug backtrace nlinum linum company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company-web-html company-web company-css web-completion-data company eww url-queue shr pixel-fill kinsoku url-file svg mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom cedet dap-mouse dap-ui lsp-treemacs lsp-treemacs-generic lsp-treemacs-themes treemacs-treelib treemacs treemacs-header-line treemacs-compatibility treemacs-mode treemacs-interface treemacs-persistence treemacs-filewatch-mode treemacs-follow-mode treemacs-rendering treemacs-annotations treemacs-async treemacs-workspaces treemacs-dom treemacs-visuals treemacs-fringe-indicator treemacs-scope pulse treemacs-faces treemacs-icons treemacs-themes treemacs-core-utils pfuture treemacs-logging treemacs-customization treemacs-macros gdb-mi bindat gud bui bui-list bui-info bui-entry bui-core bui-history bui-button bui-utils lsp-lens dap-gdb-lldb dap-netcore dap-node dap-utils dom xml dap-pwsh lsp-pwsh dap-python dap-mode dap-tasks dap-launch lsp-docker yaml posframe dap-overlays undo-tree diff queue doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path compat compat-macs projectile lisp-mnt grep ibuf-ext ibuffer ibuffer-loaddefs helm-imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs ido-yes-or-no ido helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load files-x tramp-compat parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp format-spec helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu edmacro kmacro helm-core easy-mmode async-bytecomp helm-source helm-multi-match helm-lib async helm-config delsel cl-extra autorevert server powershell advice shell pcomplete hl-line lsp-mode lsp-protocol yasnippet help-mode xref project tree-widget wid-edit spinner pcase network-stream puny nsm markdown-mode color thingatpt noutline outline icons lv inline imenu ht filenotify f f-shortdoc shortdoc s ewoc epg rfc6068 epg-config dash dracula-theme compile-eslint compile text-property-search comint ansi-osc ansi-color ring cl finder-inf git-timemachine-autoloads rx helm-projectile-autoloads expand-region-autoloads all-the-icons-autoloads dracula-theme-autoloads eglot-autoloads multiple-cursors-autoloads tree-sitter-langs-autoloads projectile-autoloads nlinum-autoloads doom-modeline-autoloads rust-mode-autoloads editorconfig-autoloads helm-autoloads helm-core-autoloads async-autoloads assess-autoloads m-buffer-autoloads cargo-autoloads package-lint-autoloads flycheck-autoloads company-autoloads magit-autoloads magit-section-autoloads web-mode-autoloads paredit-autoloads helpful-autoloads elisp-refs-autoloads js2-mode-autoloads yaml-mode-autoloads powershell-autoloads dap-mode-autoloads lsp-docker-autoloads yaml-autoloads lsp-treemacs-autoloads treemacs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads lsp-mode-autoloads markdown-mode-autoloads ht-autoloads git-commit-autoloads with-editor-autoloads transient-autoloads compat-autoloads pcache-autoloads f-autoloads popup-autoloads s-autoloads info dash-autoloads macrostep-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 672869 72433)  (symbols 48 57045 15)  (strings 32 217478 14464)  (string-bytes 1 6722564)  (vectors 16 133339)  (vector-slots 8 2312365 169193)  (floats 8 1048 572)  (intervals 56 9138 4037)  (buffers 992 47)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 15:42:54 2022 Received: (at 59689) by debbugs.gnu.org; 29 Nov 2022 20:42:54 +0000 Received: from localhost ([127.0.0.1]:56215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p07RO-0000Va-1P for submit@debbugs.gnu.org; Tue, 29 Nov 2022 15:42:54 -0500 Received: from out2.migadu.com ([188.165.223.204]:16733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p07RK-0000VU-SF for 59689@debbugs.gnu.org; Tue, 29 Nov 2022 15:42:52 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669754568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=/gDCulYXR2Rd6cQPtCoQpFhfpu/OFSyss/Z3v7q5vTQ=; b=MZj9cZepXWgm6TU4acTjm0nz9XZHtjmKcAy7r2oKas7s4PomhbMRdPslBuq4td73rxxR4L pVQrB4IHprOdUrlI4Jh8cjvXYqeUp7NWCfgAElXaD/B08HSaP+m738lespE4OZpccoDnes WgK7HIAIDVvF3B069aizhodku7uB4bQkm2affzSTF1v/k1n/JMWw/5/orbdTXzqB8YGAuF 3f8H9msIxi2vjLUkKq7oQEWgkqJuvlrTXyJI++bB0vaddoWkr1a5QaPRsJ4tYIa1J8Z1XZ ZTy2kPdBZFH0y5EEY89sDU4pB5HOXlNUytvSuE5hk1B1i2CVpQtZHKO8BihEZA== From: Theodor Thornhill To: 59689@debbugs.gnu.org Subject: 29.0.60; csharp-ts-mode: unable to uncomment region commented using comment-region Date: Tue, 29 Nov 2022 21:42:46 +0100 Message-ID: <877czda3w9.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: jostein@kjonigsen.net, eliz@gnu.org, casuri@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hi all. Here's a patch fixing this bug. This also fixes the same problem for all the ts-modes. The regression was introduced in d5dc1dbf7cb263d8ff541a0def028c2d7d24f82b See attached patch. Theo --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-comment-start-skip-in-ts-modes.patch >From 396f02d03faf65ded0b01b7b9aa9eb989aff4291 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Tue, 29 Nov 2022 21:33:42 +0100 Subject: [PATCH] Fix comment-start-skip in *-ts-modes The new rx-based regex didn't work correctly with C++ style comments, so we revert back to the old non-rx-based comment-start-skip. * lisp/progmodes/c-ts-mode.el (c-ts-mode): Use new regex. * lisp/progmodes/csharp-mode.el (csharp-ts-mode): Use new regex. * lisp/progmodes/java-ts-mode.el (java-ts-mode): Use new regex. * lisp/progmodes/js.el (js-ts-mode): Use new regex. * lisp/progmodes/typescript-ts-mode.el (typescript-ts-mode): Use new regex. Fixes (Bug#59689) --- lisp/progmodes/c-ts-mode.el | 3 +-- lisp/progmodes/csharp-mode.el | 3 +-- lisp/progmodes/java-ts-mode.el | 3 +-- lisp/progmodes/js.el | 3 +-- lisp/progmodes/typescript-ts-mode.el | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el index a79dabcd31..18d0e2a87b 100644 --- a/lisp/progmodes/c-ts-mode.el +++ b/lisp/progmodes/c-ts-mode.el @@ -546,8 +546,7 @@ c-ts-mode ;; Comments. (setq-local comment-start "/* ") (setq-local comment-end " */") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 3da3079f08..451fedce1b 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -900,8 +900,7 @@ csharp-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/java-ts-mode.el b/lisp/progmodes/java-ts-mode.el index cf2482bb6e..ea3d2144df 100644 --- a/lisp/progmodes/java-ts-mode.el +++ b/lisp/progmodes/java-ts-mode.el @@ -301,8 +301,7 @@ java-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index ad1fe62d42..f8d510625c 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3849,8 +3849,7 @@ js-ts-mode ;; Comment. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el index 6c926a4e3e..8a5e537213 100644 --- a/lisp/progmodes/typescript-ts-mode.el +++ b/lisp/progmodes/typescript-ts-mode.el @@ -301,8 +301,7 @@ typescript-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 15:51:08 2022 Received: (at 59689) by debbugs.gnu.org; 29 Nov 2022 20:51:08 +0000 Received: from localhost ([127.0.0.1]:56253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p07ZM-0000aC-G9 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 15:51:08 -0500 Received: from out2.migadu.com ([188.165.223.204]:21906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p07ZJ-0000a5-8Y for 59689@debbugs.gnu.org; Tue, 29 Nov 2022 15:51:06 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669755064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fogGqvO3VocSVh9bSVJLJutLnSqkTUaKWgH0GaW4GKE=; b=G3nnJF5bCXclQn1bjwD5h8pjhSmqwgX/b+y3FRHUyEk1zLjYtUpykUaMOTj8K3VFmUZH56 TOBfoVOqbYf6av3PSv8sFn0r6yFbQchh5iAY93KdOFFU6M/fQUAfCV2Eq+a85hDzVMgwsg g4UQd8GH++Xl6HkFvvypaGswvJmfewD3VittVMbW+M0XqA3i+qGXXz23KJhJmBOXiD6MXV U7PkNGwGfKTAQ+30ehNo5ds1lBk43XWLvZ7loHu5p+2aD4qyx0Fi7InWjlbaosqtVGFDK5 pv5av7U168gBWJgvdZYtYbzzJsmRqPkvgB03v4TPe0e6NVRrV5aFfqg3BNtVfg== From: Theodor Thornhill To: 59689@debbugs.gnu.org Subject: Re: 29.0.60; csharp-ts-mode: unable to uncomment region commented using comment-region In-Reply-To: <877czda3w9.fsf@thornhill.no> References: <877czda3w9.fsf@thornhill.no> Date: Tue, 29 Nov 2022 21:51:03 +0100 Message-ID: <871qpla3ig.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: casouri@gmail.com, jostein@kjonigsen.net, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Resending with correct address for Yuan... --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-comment-start-skip-in-ts-modes.patch >From 396f02d03faf65ded0b01b7b9aa9eb989aff4291 Mon Sep 17 00:00:00 2001 From: Theodor Thornhill Date: Tue, 29 Nov 2022 21:33:42 +0100 Subject: [PATCH] Fix comment-start-skip in *-ts-modes The new rx-based regex didn't work correctly with C++ style comments, so we revert back to the old non-rx-based comment-start-skip. * lisp/progmodes/c-ts-mode.el (c-ts-mode): Use new regex. * lisp/progmodes/csharp-mode.el (csharp-ts-mode): Use new regex. * lisp/progmodes/java-ts-mode.el (java-ts-mode): Use new regex. * lisp/progmodes/js.el (js-ts-mode): Use new regex. * lisp/progmodes/typescript-ts-mode.el (typescript-ts-mode): Use new regex. Fixes (Bug#59689) --- lisp/progmodes/c-ts-mode.el | 3 +-- lisp/progmodes/csharp-mode.el | 3 +-- lisp/progmodes/java-ts-mode.el | 3 +-- lisp/progmodes/js.el | 3 +-- lisp/progmodes/typescript-ts-mode.el | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el index a79dabcd31..18d0e2a87b 100644 --- a/lisp/progmodes/c-ts-mode.el +++ b/lisp/progmodes/c-ts-mode.el @@ -546,8 +546,7 @@ c-ts-mode ;; Comments. (setq-local comment-start "/* ") (setq-local comment-end " */") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 3da3079f08..451fedce1b 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -900,8 +900,7 @@ csharp-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/java-ts-mode.el b/lisp/progmodes/java-ts-mode.el index cf2482bb6e..ea3d2144df 100644 --- a/lisp/progmodes/java-ts-mode.el +++ b/lisp/progmodes/java-ts-mode.el @@ -301,8 +301,7 @@ java-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index ad1fe62d42..f8d510625c 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3849,8 +3849,7 @@ js-ts-mode ;; Comment. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el index 6c926a4e3e..8a5e537213 100644 --- a/lisp/progmodes/typescript-ts-mode.el +++ b/lisp/progmodes/typescript-ts-mode.el @@ -301,8 +301,7 @@ typescript-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) - (* (syntax whitespace)))) + (setq-local comment-start-skip "\\(?://+\\|/\\*+\\)\\s *") (setq-local comment-end-skip (rx (* (syntax whitespace)) (group (or (syntax comment-end) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 20:51:07 2022 Received: (at control) by debbugs.gnu.org; 30 Nov 2022 01:51:07 +0000 Received: from localhost ([127.0.0.1]:57761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0CFe-0005vl-QB for submit@debbugs.gnu.org; Tue, 29 Nov 2022 20:51:07 -0500 Received: from mail-ot1-f41.google.com ([209.85.210.41]:39457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0CFc-0005ui-7e for control@debbugs.gnu.org; Tue, 29 Nov 2022 20:51:04 -0500 Received: by mail-ot1-f41.google.com with SMTP id g51-20020a9d12b6000000b0066dbea0d203so10339690otg.6 for ; Tue, 29 Nov 2022 17:51:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=jUCE5tgtuyw49s5sCF+BqUTOVC/5ShCrtgXTxzS2+Wc=; b=D61V5dSvuwsiHzGfuSp3tNChN0voRRTWz4QM/mNM5hoIV2avV15hGrhGgM1K22/Kmx zCYv3KokLIHDz3Inc/B0tCxy155ejJtpQRPrCVS5hJHGFHeuNf6gehIqTZL8d2+FZYP0 +98HmlvhkYZRFVSC8ecnvqEsHokKiPUSSSWFh3tWdBJeflVn4qBc1rDjG7SE3GZzQ/Za U9xT6cpqRC5/ezxTKWtuCkknrlzKZuW1vArhvk/HxVNDwYox5F1I+41dDiZeG4yksbu3 239dmy99J5wWMcEzQUqCh83JGWkQmSykDXODJ5etyRA8YW3DVRqAspPoy9idd68GA/Vy 00VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jUCE5tgtuyw49s5sCF+BqUTOVC/5ShCrtgXTxzS2+Wc=; b=w94Axu4dL0buQdtnEwIqi9nNuivzx53bee2qLZD8VljPGZ9b4GInh8FnhlFu2Uh+IQ 6X6SmTsoetIk9HEl/t7x5LGvIGHhEPqUDuNVA9Qa1gLc/MsPdT7SRHNI8y+humWbvkIG vPujlRg2IkibVv/PTW/v3WsTxOWKsJ1OS7qVbUnH+brtOXXjfB6PO/4cKJfP1s/JHY5L G2tkOmW0vdEmPxTZL3dslPTKjplEvWy2bAJXiiSEYBYAEBT4xbLDaHhmqd+O8H6ZdKAn 7VhaDflt6A49WBXCLOqNynsnmhLcwcS/h7ptV+nNrzZuQUnHb2Vl38vTN+McndZcXBoZ ciOA== X-Gm-Message-State: ANoB5pnY10NG8cpoh2c0hC91AG/60izzdaI0zywWI9VULTT680WyQabb brR12qXhJMMSRO42nQsLgTy3e6afXJOZSBvBIrc= X-Google-Smtp-Source: AA0mqf7MuhHCPZ8lxWkCmqXtYAPqE+rG9q9a4JgREDe8ByEuhrc4gbjxl4K2Wp9pSsvrX1cAcTxcNApzKEzud85SxMg= X-Received: by 2002:a9d:70cc:0:b0:66c:5232:b9d1 with SMTP id w12-20020a9d70cc000000b0066c5232b9d1mr19120885otj.224.1669773058662; Tue, 29 Nov 2022 17:50:58 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 29 Nov 2022 17:50:58 -0800 From: Stefan Kangas In-Reply-To: <87sfi18oof.fsf@thornhill.no> References: <87sfi18oof.fsf@thornhill.no> X-Hashcash: 1:20:221130:jostein@kjonigsen.net::6VUxynTB6x8QD/i9:36Vf MIME-Version: 1.0 Date: Tue, 29 Nov 2022 17:50:58 -0800 Message-ID: Subject: Re: bug#59690: 29.0.60; typescript-ts-mode: unable to uncomment region commented using comment-region To: Theodor Thornhill , 59690@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Bcc: control@debbugs.gnu.org X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: jostein@kjonigsen.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) forcemerge 59689 59690 thanks Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > This bug is a duplication of > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59689 > > The other bug has attached a patch that fixes this. I'm therefore merging the bugs. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 29 20:51:31 2022 Received: (at control) by debbugs.gnu.org; 30 Nov 2022 01:51:31 +0000 Received: from localhost ([127.0.0.1]:57765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0CG3-0005w4-54 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 20:51:31 -0500 Received: from mail-oa1-f42.google.com ([209.85.160.42]:34555) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0CG1-0005vx-Qe for control@debbugs.gnu.org; Tue, 29 Nov 2022 20:51:30 -0500 Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-14263779059so19386741fac.1 for ; Tue, 29 Nov 2022 17:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=1GclXRbdY2UbBvt8BHbQ7AerW+gMP86HPD3m25uee3Y=; b=qg0AQxV7+jU8gTF/IaJEQwgcArhE6eWC+SBj8GI1Ad2V/yuaewwmXXfD9Z0vu5Dnvc MI39VC9Q/ozKMGMYwYGkdIxMWH7b0t93Sef+1Dd4JRYhM2XLDwM6p1ANpaqqjUiPivQj Eq/1ubgUAsGkn31cET8JpV+73IPYTVmzYUgsU/2cEZfNdazjglrtqhwmFuWVDU0v197y NrHKaXiRcBxyQvtIfYrj1ZBdoaBdmyx5xyLq2wklSW8YBV/BwBuFHGTw8wyE7m9en90H XQAtxF27TEwh8arEkmIuihD/RTcN46sA7nEDd7frKohApRMnGfS22imvmxKb8B0G1lZ5 Pa2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1GclXRbdY2UbBvt8BHbQ7AerW+gMP86HPD3m25uee3Y=; b=iA93qxu2EeBWqKYtA4h+yuoMaTITuh/7kpUFFpb92I7gJ4zJKI5qcB1MVLSGOFMt3C zttp0CGVElHby2ECs12qHsWT3KXMaPfQxAdSwi1NTOjHZGi33OiKJwENmZXw9Tmygqkb Gk7HNBB1V2aJE0PVk7X0cJSmFDmT7TSCLbOfp0vFQj60dTmN7ZAjQLaeOY+olpAQXL9Q AuokOWlw/5NmUkyyArElXHbJ7eZbzqAan0dGgLC3HDUezldvetQuE4OEgfSH4ZB2XjkO V9UdT0U62mHPb8YRiAnKlxVpNc4OFdg6hVSO1DvtUPRGalXMYMm2b+4OIt7aEMDlZBRR vRlg== X-Gm-Message-State: ANoB5plxFYN1h0q1nwv+ju6qnl3+Gg3MRTY6VkfrhKvz08/o8Se2pctA KonMfy63QWSZuACmvAUKor0OKbQT2HE6tz+rMMHl7RHO X-Google-Smtp-Source: AA0mqf6oWoUBzTc8s2Paabw3wvPVzoqdQbF6rgPoxwNBWadCuPtsp1funCblHPt5Gn/1dl3HCDZhM+VHZKiyweA2w90= X-Received: by 2002:a05:6870:cc89:b0:12b:fbe7:b793 with SMTP id ot9-20020a056870cc8900b0012bfbe7b793mr34634548oab.92.1669773084376; Tue, 29 Nov 2022 17:51:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 29 Nov 2022 17:51:24 -0800 From: Stefan Kangas X-Hashcash: 1:20:221130:control@debbugs.gnu.org::d9PNRi9sLeNCndEL:HQn MIME-Version: 1.0 Date: Tue, 29 Nov 2022 17:51:24 -0800 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 59689 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.160.42 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.160.42 listed in wl.mailspike.net] 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 59689 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 05:27:56 2022 Received: (at 59689) by debbugs.gnu.org; 30 Nov 2022 10:27:56 +0000 Received: from localhost ([127.0.0.1]:60095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KJn-000752-Lj for submit@debbugs.gnu.org; Wed, 30 Nov 2022 05:27:55 -0500 Received: from mail-pl1-f182.google.com ([209.85.214.182]:36408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KJk-00074r-Cr; Wed, 30 Nov 2022 05:27:54 -0500 Received: by mail-pl1-f182.google.com with SMTP id y17so8333797plp.3; Wed, 30 Nov 2022 02:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=QMD+tkr7gNGbl3jEVbwh3dNIVfM4LHlLSbV8zii+T90=; b=AvAHKSoWe1NfyKov2vgcLT/lizUfzUcswfnMZcrv7mTtdpJi1fYv90vCk3d2OEQzyl l57gfiNgYMzx6y7FKnRgs4rRkezg5RVdY2q+m3cCNSJuculzhgfyi16mE7O6WqHzsNG/ ssGRKaImrCv0l+ZQQ1vkCjqVJUnEMfl6ilSzSorYvM6/u6rLpzRl4CxIPT8MdaSKxrGh 05HPoZqIj5s4TwtF7JJWvl2P70/JT7qpyEfNfc6gjIU6zNGDHYTkrdETnsZUaFHKmhVF 4JNywWmbFd8H7Oy2UHCcB6nDBNQa1SJZq30Dy/BxWfZ+4mL/wqYAlrSfmrwm3r1LuGO6 4G9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QMD+tkr7gNGbl3jEVbwh3dNIVfM4LHlLSbV8zii+T90=; b=C7YaBEHfmx4K/5sXLBOazNseKQEb5DH2+/o86kjsJcYQpByVZHCtSNQkNurMBS3GWm GqdsdmY1unbrHM66bFmiTAN5HOBClcqZkhSTixDR30CRK/gqndrcp1hGrlvvpveXP/kx smPqsLuphBDsNZ7MXZn1T7HnMwmBuQh9qTl1LRvIf1CYDktlsDZvHpX1p9d4I8dG2PHu 7sRLEfxW6NCOWW/w0JXRtkkiEDXGtsmpRPGbbCmZFqeeIVtAtQiYfrtGEDzZ/GF7fehq RUpZSblNLlnBfKvnZet29scnuS/kqo/7hpxHtPEl0Y4ICfAlM7XDSrM2GqQS11XFLXY3 On3g== X-Gm-Message-State: ANoB5pkd8cvPf7rBBKqf1sh/b8k5CCJ2M3njkDJuo8ItboG2bol3L1TP 3PZEsDfchRnBH7w1ZNI3VKc= X-Google-Smtp-Source: AA0mqf7auLWNsHMVy5eZHnt2GDxNXXUam7oyDzwBCxupOw+x8ixUTJ2dWou4SRSX4ZSCy49Sw7Masw== X-Received: by 2002:a17:902:b682:b0:188:f8bd:9589 with SMTP id c2-20020a170902b68200b00188f8bd9589mr45193171pls.91.1669804066653; Wed, 30 Nov 2022 02:27:46 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x9-20020aa79a49000000b0056e0ff577edsm1075430pfj.43.2022.11.30.02.27.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2022 02:27:46 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59690: 29.0.60; typescript-ts-mode: unable to uncomment region commented using comment-region Message-Id: <97CFA258-2B25-4735-99D6-B0976FC62CFE@gmail.com> Date: Wed, 30 Nov 2022 02:27:45 -0800 To: Theodor Thornhill X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: 59690@debbugs.gnu.org, 59689@debbugs.gnu.org, jostein@kjonigsen.net, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Resending with correct address for Yuan... > > Oops, sorry. But why it didn=E2=80=99t work? :-( I did a (almost) direct conversion from the old regexp to rx. Let me see if I can fix it with rx. Yuan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 05:39:31 2022 Received: (at 59689) by debbugs.gnu.org; 30 Nov 2022 10:39:31 +0000 Received: from localhost ([127.0.0.1]:60182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KV0-0007Ea-Vu for submit@debbugs.gnu.org; Wed, 30 Nov 2022 05:39:31 -0500 Received: from out2.migadu.com ([188.165.223.204]:34420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0KUw-0007EQ-P2; Wed, 30 Nov 2022 05:39:28 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669804765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XEDSBRK6bhM7MkNj3628V3zHwLDirFsn8+rFcygfXBU=; b=IKz27ACeBk/LgpBEWQRiCgIYdYqZrBZXDfZawVWKAOCPOML7fNsTuG1poU86Uts5lLJt8H 9inlkYTjU030btDBZob/y+14/psa32WMsgMr4vHXvIlCQfxMcngB62Wu38MPFv7RKx//TJ NY8x2pgBiaqt1VjZ3u1Jr01+sAXsJ0GWcbvWyDqA3yDoj3qPZNpO6o8lqA9zkSR/1u4Bp0 rQs2krm65zLh6Ok7ROcQrcavy8L26rknX5Z7pNp5M7Lyi9R9q61TaeD/sJXP/tEqCdvxV2 OesfpEXjZXiDCcZncDe69kCgayRGIYRI6u6VHVRQrPKKlJTo1y5RO6bcyc/Now== From: Theodor Thornhill To: Yuan Fu Subject: Re: bug#59690: 29.0.60; typescript-ts-mode: unable to uncomment region commented using comment-region In-Reply-To: <97CFA258-2B25-4735-99D6-B0976FC62CFE@gmail.com> References: <97CFA258-2B25-4735-99D6-B0976FC62CFE@gmail.com> Date: Wed, 30 Nov 2022 11:39:24 +0100 Message-ID: <87o7solo9v.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: 59690@debbugs.gnu.org, 59689@debbugs.gnu.org, jostein@kjonigsen.net, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: > Theodor Thornhill writes: > >> Resending with correct address for Yuan... >> >> > > Oops, sorry. But why it didn=E2=80=99t work? :-( I did a (almost) direct > conversion from the old regexp to rx. Let me see if I can fix it with > rx. If you use the xr package from ELPA you get an rx equivalent, but to me that was more unreadable than the plain regex :) Theo From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 30 07:45:01 2022 Received: (at 59689) by debbugs.gnu.org; 30 Nov 2022 12:45:01 +0000 Received: from localhost ([127.0.0.1]:60746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0MST-0004i0-Dt for submit@debbugs.gnu.org; Wed, 30 Nov 2022 07:45:01 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42969) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0MSR-0004hu-CX for 59689@debbugs.gnu.org; Wed, 30 Nov 2022 07:44:59 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5369E5C016C; Wed, 30 Nov 2022 07:44:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 30 Nov 2022 07:44:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm3; t=1669812293; x=1669898693; bh=/2 43PnRfi83K4tnE5VoJCqYyFN73UIR+8pth0jPvwDA=; b=hTrDPvjMYZM3s8V71a Fff/2SarR9DIVmOSnl99oAPkfHkUoO+CrI+ZU/s201MmRLJKqhaZ4osyIxcV/IU7 dByrnaeYVe/Q1pVzg73UHB+dKreC275KRXCv92r8jJHr1ndvBnZaZ8T65LTTNm7X 1WJeeFSkqDFjK/cYzYaBE/3bYxVCDnQUeJZCFSIaPUWK1nH3/VioEPVtaoearqOH s3BJYUkhMmi/rMnfRXHXhZdDj0SinOMlM85qwsbQYQR30Yq96qCtHX+fFHK4xeLb YFn6O4PS97KaU+kOpX22BYlgo6hXf1wIheFPcE+ht4oNCP1hlGEQLhVMRCiEIxUN a4gA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1669812293; x=1669898693; bh=/243PnRfi83K4tnE5VoJCqYyFN73UIR+8pt h0jPvwDA=; b=ksWbW7wKSaMnKC+9DparJxP+dQDeRw6dg5ZacyDhVRYxjZSfnjJ BoFOv0xTJNPMCTKpiHiiDmPXJlzl25sH3eTtkbP6ubRF1hV185tJTK3Sm6K58s7A g8ZxgqQHcPj6uBHpohW1VPq4f6+yyaCPf4waRa7yeexN13c2N5CglXWCJ+ffCAsD 8rxYV9hQLfMJPagEzd4iaf4QjQ2r+gYh37bBSZtowbypK1NFNAozUuG3H6Oa9LOk 9SZ1S+LqJ46Ad2BRhNM1kwKqAD3frYTWpUEhc/hIFPbQFcnqDwibJFSiamuf2gy7 jA/Lix12COJXUwOH0oRBwXfm8riVov52QdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdefgdegudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfghruffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeevvefhfeeffedtvdfhvdei ieffheeiheegheegtddtkeevffelteetgedvjeenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhn ihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Nov 2022 07:44:52 -0500 (EST) Message-ID: Date: Wed, 30 Nov 2022 13:44:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: 29.0.60; csharp-ts-mode: unable to uncomment region commented using comment-region Content-Language: nb-NO To: Theodor Thornhill , 59689@debbugs.gnu.org References: <877czda3w9.fsf@thornhill.no> From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= In-Reply-To: <877czda3w9.fsf@thornhill.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59689 Cc: eliz@gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: jostein@kjonigsen.net Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 29.11.2022 21:42, Theodor Thornhill wrote: > Hi all. > > Here's a patch fixing this bug. This also fixes the same problem for all > the ts-modes. > > The regression was introduced in > d5dc1dbf7cb263d8ff541a0def028c2d7d24f82b > > See attached patch. > > Theo > I can confirm this patch fixes the problem on my end. -- Jostein From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 22:56:43 2022 Received: (at 59689) by debbugs.gnu.org; 2 Dec 2022 03:56:44 +0000 Received: from localhost ([127.0.0.1]:43789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0xAJ-0005fK-ET for submit@debbugs.gnu.org; Thu, 01 Dec 2022 22:56:43 -0500 Received: from mail-pj1-f48.google.com ([209.85.216.48]:43827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0xAC-0005f8-OK; Thu, 01 Dec 2022 22:56:41 -0500 Received: by mail-pj1-f48.google.com with SMTP id u15-20020a17090a3fcf00b002191825cf02so4042801pjm.2; Thu, 01 Dec 2022 19:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=5oU4A3bCuJ0Zm+qKqBHV6S5wkf/eyGGkIXs0v2cVWjY=; b=Kule9PREeySWMo/oj0L4xA7Z12MjannKskpnfYJQjFcVsdDVVg9ZqZOnmKH5vx42Uo bSa/4hxrZRbSUePa/Pj0GoVUd0+RDph0FiJQ0P1sRj4YMOrla6P2O+2+n2YovbPcbusC baS1SImgAGT0Pz/dApobm8K88NXPy92i2B4sJy7oJqR062AnyLwIDekfUF8hYek0JJL1 kfzldkl1VbTXkRNqJcvYooxtlIuz9ruX4tPXrNnjcGVRk3TBnHnvvaxacS9Pac6KIg3P j4LbNRY6Vg6iplvps8Zr+uSAjIl+tQWvqDMMROvLQhxjr1fPes4csqB+9dm91UH6YsOn L+Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5oU4A3bCuJ0Zm+qKqBHV6S5wkf/eyGGkIXs0v2cVWjY=; b=CoYnfXcE07QPzN0/TN/zn+PxeuHqtgvxfIEFyudlLEJvNMf761USfQbQNa8teE8q96 PfaQAFbtVHQ1MCr4LDw5gkMX/v9rSJ5qOv/+nCzNvSooAMvqneV1xCYhWj3wGVogqLjH 3gC4Oo4gUstuyIR9XLOAiAfmGwB7d9bvzHeWUxey+NSAVa46sXjAQXlr5lTW+mSKYjWI A3tphDtlxebPoXQbvUB6+R41kpHuuP8A+mDM53UpPXU3vW3K/csJ/GNM1HArCxwpMWN6 eU9palItGFQk/OcUlstC4phjz+gqrIpMiAnIBpe2YcaiNapKX9mvWvxHXyBLE+3SRIHP 0ySA== X-Gm-Message-State: ANoB5pkJ3z6WvwAp9DN9rTGE0wq+CvVDE4SyzJ2/AKiBMh+HZ2kgM0Tb wI9XvKh9OUi6jST2tlnsRlM= X-Google-Smtp-Source: AA0mqf6G/BhUgygDWCOGFslBHtrwAaS/hNI312tWy8ad+YaTGQgzGSZ8b6xykEvzQKxDfTyYjVM+Pg== X-Received: by 2002:a17:90a:fe05:b0:219:29eb:bc4b with SMTP id ck5-20020a17090afe0500b0021929ebbc4bmr27512961pjb.199.1669953389916; Thu, 01 Dec 2022 19:56:29 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id p3-20020a170902e74300b00189988a1a9esm4449172plf.135.2022.12.01.19.56.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2022 19:56:29 -0800 (PST) From: Yuan Fu Message-Id: <9E07E286-B6B7-4626-A41A-A87ADE402D09@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_66763624-7250-440B-9918-D0CB1E1B719B" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: bug#59689: bug#59690: 29.0.60; typescript-ts-mode: unable to uncomment region commented using comment-region Date: Thu, 1 Dec 2022 19:56:28 -0800 In-Reply-To: <87o7solo9v.fsf@thornhill.no> To: Theodor Thornhill References: <97CFA258-2B25-4735-99D6-B0976FC62CFE@gmail.com> <87o7solo9v.fsf@thornhill.no> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: 59690@debbugs.gnu.org, 59689@debbugs.gnu.org, jostein@kjonigsen.net, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_66763624-7250-440B-9918-D0CB1E1B719B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Nov 30, 2022, at 2:39 AM, Theodor Thornhill via Bug reports for GNU = Emacs, the Swiss army knife of text editors = wrote: >=20 > Yuan Fu writes: >=20 >> Theodor Thornhill writes: >>=20 >>> Resending with correct address for Yuan... >>>=20 >>>=20 >>=20 >> Oops, sorry. But why it didn=E2=80=99t work? :-( I did a (almost) = direct >> conversion from the old regexp to rx. Let me see if I can fix it with >> rx. >=20 > If you use the xr package from ELPA you get an rx equivalent, but to = me > that was more unreadable than the plain regex :) That=E2=80=99s what I used, but perhaps I should change the result of it = :-) Could you try this patch? This should be one-to-one conversion from the = plain one. Yuan --Apple-Mail=_66763624-7250-440B-9918-D0CB1E1B719B Content-Disposition: attachment; filename=comment-start.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="comment-start.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el index ad64df6143c..d63a77cb50f 100644 --- a/lisp/progmodes/c-ts-mode.el +++ b/lisp/progmodes/c-ts-mode.el @@ -566,7 +566,8 @@ c-ts-mode ;; Comments. (setq-local comment-start "/* ") (setq-local comment-end " */") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) + (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) + (seq "/" (+ "*"))) (* (syntax whitespace)))) (setq-local comment-end-skip (rx (* (syntax whitespace)) diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el index 3da3079f089..054dabfed07 100644 --- a/lisp/progmodes/csharp-mode.el +++ b/lisp/progmodes/csharp-mode.el @@ -900,7 +900,8 @@ csharp-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) + (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) + (seq "/" (+ "*"))) (* (syntax whitespace)))) (setq-local comment-end-skip (rx (* (syntax whitespace)) diff --git a/lisp/progmodes/java-ts-mode.el b/lisp/progmodes/java-ts-mode.el index cf2482bb6ee..2c42505ac94 100644 --- a/lisp/progmodes/java-ts-mode.el +++ b/lisp/progmodes/java-ts-mode.el @@ -301,7 +301,8 @@ java-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) + (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) + (seq "/" (+ "*"))) (* (syntax whitespace)))) (setq-local comment-end-skip (rx (* (syntax whitespace)) diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index ad1fe62d429..389096147ac 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -3849,7 +3849,8 @@ js-ts-mode ;; Comment. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) + (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) + (seq "/" (+ "*"))) (* (syntax whitespace)))) (setq-local comment-end-skip (rx (* (syntax whitespace)) diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el index 6c926a4e3e0..ddc478f7320 100644 --- a/lisp/progmodes/typescript-ts-mode.el +++ b/lisp/progmodes/typescript-ts-mode.el @@ -301,7 +301,8 @@ typescript-ts-mode ;; Comments. (setq-local comment-start "// ") (setq-local comment-end "") - (setq-local comment-start-skip (rx (group "/" (or (+ "/") (+ "*"))) + (setq-local comment-start-skip (rx (or (seq "/" (+ "/")) + (seq "/" (+ "*"))) (* (syntax whitespace)))) (setq-local comment-end-skip (rx (* (syntax whitespace)) --Apple-Mail=_66763624-7250-440B-9918-D0CB1E1B719B Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_66763624-7250-440B-9918-D0CB1E1B719B-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 07:43:05 2022 Received: (at 59689) by debbugs.gnu.org; 2 Dec 2022 12:43:05 +0000 Received: from localhost ([127.0.0.1]:46486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p15Nh-0004wY-7h for submit@debbugs.gnu.org; Fri, 02 Dec 2022 07:43:05 -0500 Received: from out-96.mta0.migadu.com ([91.218.175.96]:53119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p15Nf-0004wL-2h for 59689@debbugs.gnu.org; Fri, 02 Dec 2022 07:43:03 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669984981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLMuQ7eGH9ZMX+LEXVGLkCj+xxfuj3MGxyyp0g/usck=; b=h4JJuxjAXaSqWNjZytGH4fhCA8KVhZPTHC4xOW6FF4ayNRJnmUXh+A3ys2LlYNiK+gYdSH 0a8C4xR/Mdw6v+zMx+5lSZgaNpeP97REMX6XBekvdpVinoEM8lBixwS6Fya1EqBlY+h49w hi12aeZRLLi+dYTYG3ST6FeOU6wrmcLdGzZeuHvAhwEPmQwrKs4/PTsvJNHNbrXp13vrvh QD3YFIrvsHrrgyzdNcea6Hj+1la5pRL40MVNQfLGkdnNb66zr1iwSptOwPyYH4P00q9TYE +FvuoF808u3kX4DtHoqV8On6Q+w8ND0yPjeUWb4FH6dxOzqcZrSytu11Ak06+Q== From: Theodor Thornhill To: Yuan Fu Subject: Re: bug#59689: bug#59690: 29.0.60; typescript-ts-mode: unable to uncomment region commented using comment-region In-Reply-To: <9E07E286-B6B7-4626-A41A-A87ADE402D09@gmail.com> References: <97CFA258-2B25-4735-99D6-B0976FC62CFE@gmail.com> <87o7solo9v.fsf@thornhill.no> <9E07E286-B6B7-4626-A41A-A87ADE402D09@gmail.com> Date: Fri, 02 Dec 2022 13:43:00 +0100 Message-ID: <87y1rq9dt7.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59689 Cc: 59690@debbugs.gnu.org, 59689@debbugs.gnu.org, jostein@kjonigsen.net, eliz@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yuan Fu writes: >> On Nov 30, 2022, at 2:39 AM, Theodor Thornhill via Bug reports for GNU E= macs, the Swiss army knife of text editors wrote: >>=20 >> Yuan Fu writes: >>=20 >>> Theodor Thornhill writes: >>>=20 >>>> Resending with correct address for Yuan... >>>>=20 >>>>=20 >>>=20 >>> Oops, sorry. But why it didn=E2=80=99t work? :-( I did a (almost) direct >>> conversion from the old regexp to rx. Let me see if I can fix it with >>> rx. >>=20 >> If you use the xr package from ELPA you get an rx equivalent, but to me >> that was more unreadable than the plain regex :) > > That=E2=80=99s what I used, but perhaps I should change the result of it = :-) > This works, and prettier than the xr variant ;) Nice. Theo From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 14:38:28 2022 Received: (at control) by debbugs.gnu.org; 7 Dec 2022 19:38:28 +0000 Received: from localhost ([127.0.0.1]:51864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p30FQ-0000Lg-7B for submit@debbugs.gnu.org; Wed, 07 Dec 2022 14:38:28 -0500 Received: from mail-pg1-f177.google.com ([209.85.215.177]:34720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p30FN-0000LV-Fw for control@debbugs.gnu.org; Wed, 07 Dec 2022 14:38:26 -0500 Received: by mail-pg1-f177.google.com with SMTP id 142so1850486pga.1 for ; Wed, 07 Dec 2022 11:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:from:to:cc:subject:date:message-id:reply-to; bh=d4tLDhhAvkEl/v5QTxzOZkH4Dq7tUmk0whOdIIWORMc=; b=L9eeQu3rliqb3+VR1b6fodfJhLa/QRXl6h5WET74xf4g1ZeUPoaeSOo71zcAtgu9FU B2j1dJTvLr+apS28vSnCIIQhx2Dq8Fow30HEWO6zDgDayVdDcZcceLShwMnsajM5cw5q RCyAtmKMfepLWZzBTR9be9Lxra9d2GKZ03MhrxBCxUTa8n1g74SpHQCvWC/hAXIKflzo m52xUpHyQueajOmbQ0mjKWvsnNLeWBrGtEVSOauW6C1cHZ3G+YsLv+WSAOF3WBF1x5tY H7ql4QOpl2DXYISaSUfoQqAMLhLrloe93ybJDWac4Ga0C5ZjY71GkHdLs35QoM0cpsWx J10w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:date:message-id:subject:mime-version:content-transfer-encoding :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d4tLDhhAvkEl/v5QTxzOZkH4Dq7tUmk0whOdIIWORMc=; b=H2xhnXnopsL+VWy3nDMoJ7oaW1JOqMeDKTTCw2Yesr3tS0wIK31wGOzNrVlHRV1Nd2 DDsl88l+n3qDxNbLf1KskGIb5ZpmCPUqSBXx3xv24Zt57zTW4PGd+CnBLqtVTq67f8tP asrJbDOg3EVkjpkVwD89wsPuwiwhcr1mBo29WoHvOXoORlFCJksvRqZgO9lvAaZ/wRgP OJLRwbBYLybcp77wJz8fOiFHVALqeNeFyJSPab4AejhKHCmAVPVSkE0muiPGMfGR6IVd gHHtxFKSGFd6O0FfQ3bkg8SCBPUCfqXP308A3+8KmKYw9l9xL1fjF0LTa77WElZMw4G8 6SYA== X-Gm-Message-State: ANoB5pmJVP1pokylZtlTZobJioM6EpMbTNbK1ZnHbaDXCZj47cGRfOb1 OAV7rIgMFfbTsrt0fD7PF7lseRfYoQ1sww== X-Google-Smtp-Source: AA0mqf5X3NrfelnSzABP2KFc8BlrFY6ciNuF+j7+4Wg970iGRT5br3vfEEZx/z9ybgSoRVYBedNu1w== X-Received: by 2002:a63:de14:0:b0:477:4a61:eb99 with SMTP id f20-20020a63de14000000b004774a61eb99mr75409470pgg.48.1670441899565; Wed, 07 Dec 2022 11:38:19 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id b1-20020a170902d50100b001869efb722csm15032866plg.215.2022.12.07.11.38.19 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Dec 2022 11:38:19 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: control message for bug #59690 Message-Id: <972290AB-81CF-4C1C-8D5D-6F67B0BACDDA@gmail.com> Date: Wed, 7 Dec 2022 11:38:18 -0800 To: control@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 59690 29.1 quit From unknown Fri Jun 20 07:27:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Jan 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator