GNU bug report logs - #59684
29.0.50; [PATCH] package.el: Insert news for installed packages only

Previous Next

Full log

Message #17 received at 59684 <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 59684 <at> debbugs.gnu.org
Subject: Re: bug#59684: 29.0.50; [PATCH] package.el: Insert news for
 installed packages only
Date: Tue, 29 Nov 2022 23:38:24 +0200

[Message part 1 (text/plain, inline)]

Philip Kaludercic <philipk <at> posteo.net> writes:

>>>> +                          ((file-regular-p file)))
>>>
>>> Shouldn't we keep `file-readable-p'?
>>
>> I think we should use `file-regular-p' so even if the pkg-dir will
>> contain directory named "news" we will not try to insert it with
>> `insert-file-contents'.
>
> I agree that `file-regular-p' is sensible, what I meant was using
> `file-readable-p' in addition to that.  But I guess that all in all,
> this is a rare circumstance...

Oh, right.  Makes sense.  I've updated the patch.

[0001-Insert-news-for-installed-packages-only.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.