GNU bug report logs - #59684
29.0.50; [PATCH] package.el: Insert news for installed packages only

Previous Next

Package: emacs;

Reported by: Andrii Kolomoiets <andreyk.mad <at> gmail.com>

Date: Tue, 29 Nov 2022 16:55:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrii Kolomoiets <andreyk.mad <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: 29.0.50; [PATCH] package.el: Insert news for installed packages
 only
Date: Tue, 29 Nov 2022 23:16:00 +0200

Philip Kaludercic <philipk <at> posteo.net> writes:

>> +                          ((file-regular-p file)))
>
> Shouldn't we keep `file-readable-p'?

I think we should use `file-regular-p' so even if the pkg-dir will
contain directory named "news" we will not try to insert it with
`insert-file-contents'.

-- 
Andrii
This bug report was last modified 2 years and 229 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.