GNU bug report logs - #59678
[PATCH] sh-script: use completion-table-with-cache to improve performance

Previous Next

Full log

Message #22 received at 59678-done <at> debbugs.gnu.org (full text, mbox):

From: Yikai Zhao <yikai <at> z1k.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 59678-done <at> debbugs.gnu.org
Subject: Re: bug#59678: [PATCH] sh-script: use completion-table-with-cache to
 improve performance
Date: Sat, 3 Dec 2022 01:00:00 +0800

On Fri, Dec 2, 2022 at 9:44 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > Cc: Yikai Zhao <yikai <at> z1k.dev>
> > From: yikai <at> z1k.dev
> > Date: Tue, 29 Nov 2022 22:30:14 +0800
> >
> > Hi,
> >
> > I found that the auto-completion on .sh files (with company-mode) was pretty slow (takes several seconds).
> > It turns out that company-mode would call the capf function with 'metadata action for each candidate,
> > where each function call would need to list all the cmds. In this patch, I modified the code to use
> > completion-table-with-cache which fixes the problem for me.
>
> Thanks, installed on the emacs-29 branch.
>
> In the future, please accompany your changes with ChangeLog-style commit of
> messages (see CONTRIBUTE for the details).

Thanks. I will do that next time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.