GNU bug report logs - #59668
29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#59668: closed (29.0.50; [PATCH] Make 'server-stop-automatically'
 into a defcustom)
Date: Thu, 08 Dec 2022 06:03:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 7 Dec 2022 22:02:39 -0800
with message-id <d2d2b79e-2c5e-420b-11ed-dc0176da4efc <at> gmail.com>
and subject line Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom
has caused the debbugs.gnu.org bug report #59668,
regarding 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
59668: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59668
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom
Date: Mon, 28 Nov 2022 20:23:17 -0800

[Message part 3 (text/plain, inline)]

The manual says:

  The Emacs server can optionally be stopped automatically when
  certain conditions are met.  To do this, call the function
  @code{server-stop-automatically} in your init file (@pxref{Init
  File}), with one of the following arguments...

It'd be nice if this were a defcustom so that people who prefer the 
Customize interface could use that instead of editing their init files. 
Here's a patch for that.

I've tried to make sure this is as robust as possible, so that 
everything is always properly set, especially when adjusting the value 
in the Customize UI. It should even work correctly if a user stopped the 
server temporarily and restarted it (you might do this to clear out old 
clients, do some work, and then make the server available again). Maybe 
this last bit is a little paranoid, but it was minimal extra work 
compared to getting the Customize part working.

One question though: should this only go on the master branch, or should 
it go into the 29 branch? To me, it seems like it could go either way, 
though I think it'd be nice to make this easier for users in 29. I'll do 
whatever the maintainers think is best though.

If it goes on the master branch only, I'll add back the function form of 
'server-stop-automatically' for compatibility, and then mark it obsolete.

[0001-Make-server-stop-automatically-into-a-defcustom.patch (text/plain, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59668-done <at> debbugs.gnu.org
Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into
 a defcustom
Date: Wed, 7 Dec 2022 22:02:39 -0800

On 12/7/2022 4:48 AM, Eli Zaretskii wrote:
>> Date: Tue, 6 Dec 2022 17:39:52 -0800
>> Cc: 59668 <at> debbugs.gnu.org
>> From: Jim Porter <jporterbugs <at> gmail.com>
>>
>> How about "When empty (no clients, unsaved files, or processes)"?
> 
> Just leave the text inside the parentheses (but without the
> parentheses themselves), there's no need to have the "empty part there.

Ok by me.

>> Attached is an updated patch (rebased on top of my previous patches for
>> bug#51993).
> 
> OK with the above change.  Thanks.

Thanks, merged to master as
153c67fa92eaad39410b1809ab9b125616bdc5c1. Closing this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.