GNU bug report logs - #59668
29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom

Previous Next

Full log

Message #22 received at 59668 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 59668 <at> debbugs.gnu.org
Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into
 a defcustom
Date: Fri, 02 Dec 2022 16:42:21 +0200

> Date: Thu, 1 Dec 2022 19:30:03 -0800
> Cc: 59668 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> @@ -1805,7 +1814,7 @@ server-save-buffers-kill-terminal
>  	    (t (error "Invalid client frame"))))))
>  
>  (defun server-stop-automatically--handle-delete-frame (frame)
> -  "Handle deletion of FRAME when `server-stop-automatically' is used."
> +  "Handle deletion of FRAME when `server-stop-automatically' is `delete-frame'."
>    (when server-stop-automatically
>      (if (if (and (processp (frame-parameter frame 'client))
>  		 (eq this-command 'save-buffers-kill-terminal))
> @@ -1828,7 +1837,7 @@ server-stop-automatically--handle-delete-frame
>  	  (delete-frame frame)))))

AFAIU, this delete-frame is called after save-buffers-kill-emacs, which is
strange: there will be no Emacs to perform this call after that.  What am I
missing?
> +          (const :tag "When empty" empty)

"When empty" doesn't explain itself well enough.  Can we come up with a
better description?

Otherwise LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.