GNU bug report logs - #59668
29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom

Previous Next

Full log

Message #19 received at 59668 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59668 <at> debbugs.gnu.org
Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into
 a defcustom
Date: Thu, 1 Dec 2022 19:30:03 -0800

[Message part 1 (text/plain, inline)]

On 12/1/2022 9:08 AM, Eli Zaretskii wrote:
> I see no reason to make the function obsolete.  It does not harm to have
> both a variable and a function by the same name.

Ok, fixed. I've added back a 'server-stop-automatically' function that 
just sets the variable.

> This @itemize list should be converted to a @table, formatted like this:
> 
>    @item empty
>    This value caused the server to be stopped when...
> 
>    @item delete-frame
>    This value means that when the last client frame is deleted...

Done.

>> @@ -1780,7 +1784,8 @@ server-save-buffers-kill-terminal
>>   
>>   If emacsclient was started with a list of filenames to edit, then
>>   only these files will be asked to be saved."
>> -  (if server-stop-automatically
>> +  (if (and (daemonp)
>> +           (memq server-stop-automatically '(kill-terminal delete-frame))
> 
> Why is this needed?  I guess I don't understand why non-trivial code changes
> are in a patch that was supposed to just add a defcustom?

Addressed in my other message, but I've added a defsubst to make this 
clearer (I hope).

[0001-Make-server-stop-automatically-into-a-defcustom.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.