From unknown Mon Jul 14 20:52:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#59668 <59668@debbugs.gnu.org> To: bug#59668 <59668@debbugs.gnu.org> Subject: Status: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Reply-To: bug#59668 <59668@debbugs.gnu.org> Date: Tue, 15 Jul 2025 03:52:00 +0000 retitle 59668 29.0.50; [PATCH] Make 'server-stop-automatically' into a defc= ustom reassign 59668 emacs submitter 59668 Jim Porter severity 59668 wishlist tag 59668 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 28 23:23:26 2022 Received: (at submit) by debbugs.gnu.org; 29 Nov 2022 04:23:26 +0000 Received: from localhost ([127.0.0.1]:52890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozs9V-0002zT-Br for submit@debbugs.gnu.org; Mon, 28 Nov 2022 23:23:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:48928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozs9T-0002zN-Fu for submit@debbugs.gnu.org; Mon, 28 Nov 2022 23:23:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozs9T-0007dm-7y for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 23:23:23 -0500 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozs9Q-000488-Eu for bug-gnu-emacs@gnu.org; Mon, 28 Nov 2022 23:23:22 -0500 Received: by mail-pl1-x635.google.com with SMTP id d3so7257704plr.10 for ; Mon, 28 Nov 2022 20:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=iYEae16H58/LE3Q9VIDAucma7ppwiDfEZw/rWyZosLY=; b=Qumnw+I1cmfQN4zKgaRlblcXw9ufBq23hTfRUHkCuuToCgr8FpXqdqcae+IDAwVGfm 8q+PrmUup05IrGSeXCNY9qHYPx1mkwMt4m50cDodUROwYDtCSvhISX0LJiuMGuG9hyRg ZLg2d3XqpDt9q73W4g7rnjRZ9+ZsR5UFt5cm8tNajcNZmpsDjjumku7v0o9HyDCj7mzx RGoLAvWOI0JimrRuhGTlIfUL/55JVAhIqm2zvdAlnbR1t+TKS3Lq/+hh+Gue3lqhZEJz VkopM0iDg74IWAV17mTo1vABHeW/UyH5sHLk88jn/OI9XmxqFH5pq8a9aqGYjAo2rA2S VzTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iYEae16H58/LE3Q9VIDAucma7ppwiDfEZw/rWyZosLY=; b=GJCGqkIGGp/Rntdo3TPgXhhZAmrj5DKMXzxfHvZBfvJsrbpfd4E9an7lu9c5XwYQhf lQPCOU8ZXmzzvtU3laiFvgZ6gF1FbK5rulka+kyu0UUFgr/DZ4RmW8GS6Uso36rwn1gD iBIRNrICBCU/jheqZSm0lEEitbUBvgLJfgqWdlDSXN1zpkWDsdZGjOF2lqjom4ROvARf nCWOwDQhD7siHfwIsOvSJGL8s+F2xDreC4oXnL4+ETAfhLXM/3AvQXBDAJf3kUgcAiw6 Bb4qUtuuDhfZguFjd9Cp0pPPKLO3D0x/HWnP0Utn3O/Q8sZNoCNqweWq7nKfug0B2ASn Sy+Q== X-Gm-Message-State: ANoB5pnMEOS/63RpkvLvfzheAVvLAph2i6+dxzcjxXtTe4LZYAH0RPjI e2XEcL3yeW1DZLZwMBmRhAZSx6Buda8= X-Google-Smtp-Source: AA0mqf6aLUaMkDNvYG4i4ZETXzEfvG3lHgMnCrLUpBY3PooHNC5oKmXLd9PxpRheprRyZ8FIOOZDcA== X-Received: by 2002:a17:903:25cf:b0:189:9dae:6f18 with SMTP id jc15-20020a17090325cf00b001899dae6f18mr715652plb.161.1669695798398; Mon, 28 Nov 2022 20:23:18 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j4-20020a170903028400b00189651e5c26sm8063075plr.236.2022.11.28.20.23.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 20:23:17 -0800 (PST) Content-Type: multipart/mixed; boundary="------------JdPxMcdoofZo9WJZFNYSIyKJ" Message-ID: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> Date: Mon, 28 Nov 2022 20:23:17 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------JdPxMcdoofZo9WJZFNYSIyKJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The manual says: The Emacs server can optionally be stopped automatically when certain conditions are met. To do this, call the function @code{server-stop-automatically} in your init file (@pxref{Init File}), with one of the following arguments... It'd be nice if this were a defcustom so that people who prefer the Customize interface could use that instead of editing their init files. Here's a patch for that. I've tried to make sure this is as robust as possible, so that everything is always properly set, especially when adjusting the value in the Customize UI. It should even work correctly if a user stopped the server temporarily and restarted it (you might do this to clear out old clients, do some work, and then make the server available again). Maybe this last bit is a little paranoid, but it was minimal extra work compared to getting the Customize part working. One question though: should this only go on the master branch, or should it go into the 29 branch? To me, it seems like it could go either way, though I think it'd be nice to make this easier for users in 29. I'll do whatever the maintainers think is best though. If it goes on the master branch only, I'll add back the function form of 'server-stop-automatically' for compatibility, and then mark it obsolete. --------------JdPxMcdoofZo9WJZFNYSIyKJ Content-Type: text/plain; charset=UTF-8; name="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Disposition: attachment; filename*0="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Transfer-Encoding: base64 RnJvbSBkMTI3M2FkMzE3MDUxNGJjMjg0NjBiMzI4ODZhNmI0ZDc2MTU3NDJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMjI6MjE6MTAgLTA4MDAKU3ViamVjdDogW1BB VENIXSBNYWtlICdzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpbnRvIGEgZGVmY3VzdG9t CgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5KTogQ29udmVy dCB0aGUgdmFyaWFibGUgdG8KYSBkZWZjdXN0b20uICBSZW1vdmUgdGhlIGZ1bmN0aW9uLgoo c2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGltZXIpOiBOZXcgdmFyaWFibGUuCihzZXJ2 ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5KTogTmV3IGZ1bmN0aW9uLgooc2VydmVyLXN0 b3AsIHNlcnZlci1zdGFydCk6IENhbGwgJ3NlcnZlci1hcHBseS1zdG9wLWF1dG9tYXRpY2Fs bHknLgooc2VydmVyLXNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFsKTogQWRqdXN0CidzZXJ2 ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBjb25kaXRpb25hbC4KKHNlcnZlci1zdG9wLWF1dG9t YXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJhbWUpCihzZXJ2ZXItc3RvcC1hdXRvbWF0aWNh bGx5LS1tYXliZS1raWxsLWVtYWNzKTogVXBkYXRlIGRvY3N0cmluZ3MuCgoqIGRvYy9lbWFj cy9taXNjLnRleGkgKEVtYWNzIFNlcnZlcik6IFVwZGF0ZSBkb2N1bWVudGF0aW9uLgotLS0K IGRvYy9lbWFjcy9taXNjLnRleGkgfCAxMyArKystLS0tCiBsaXNwL3NlcnZlci5lbCAgICAg IHwgODkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCiAy IGZpbGVzIGNoYW5nZWQsIDYzIGluc2VydGlvbnMoKyksIDM5IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2RvYy9lbWFjcy9taXNjLnRleGkgYi9kb2MvZW1hY3MvbWlzYy50ZXhpCmlu ZGV4IDI5YzBiZWQxOWMuLmUzYzAxM2FjYjEgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9taXNj LnRleGkKKysrIGIvZG9jL2VtYWNzL21pc2MudGV4aQpAQCAtMTgwOCwyNiArMTgwOCwyNSBA QCBFbWFjcyBTZXJ2ZXIKICAgZW1hY3MgLS1kYWVtb249Zm9vCiBAZW5kIGV4YW1wbGUKIAot QGZpbmRleCBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CitAdmluZGV4IHNlcnZlci1zdG9w LWF1dG9tYXRpY2FsbHkKICAgVGhlIEVtYWNzIHNlcnZlciBjYW4gb3B0aW9uYWxseSBiZSBz dG9wcGVkIGF1dG9tYXRpY2FsbHkgd2hlbgotY2VydGFpbiBjb25kaXRpb25zIGFyZSBtZXQu ICBUbyBkbyB0aGlzLCBjYWxsIHRoZSBmdW5jdGlvbgotQGNvZGV7c2VydmVyLXN0b3AtYXV0 b21hdGljYWxseX0gaW4geW91ciBpbml0IGZpbGUgKEBweHJlZntJbml0Ci1GaWxlfSksIHdp dGggb25lIG9mIHRoZSBmb2xsb3dpbmcgYXJndW1lbnRzOgorY2VydGFpbiBjb25kaXRpb25z IGFyZSBtZXQuICBUbyBkbyB0aGlzLCBzZXQgdGhlIG9wdGlvbgorQGNvZGV7c2VydmVyLXN0 b3AtYXV0b21hdGljYWxseX0gdG8gb25lIG9mIHRoZSBmb2xsb3dpbmcgdmFsdWVzOgogCiBA aXRlbWl6ZQogQGl0ZW0KLVdpdGggdGhlIGFyZ3VtZW50IEBjb2Rle2VtcHR5fSwgdGhlIHNl cnZlciBpcyBzdG9wcGVkIHdoZW4gaXQgaGFzIG5vCitXaXRoIHRoZSB2YWx1ZSBAY29kZXtl bXB0eX0sIHRoZSBzZXJ2ZXIgaXMgc3RvcHBlZCB3aGVuIGl0IGhhcyBubwogY2xpZW50cywg bm8gdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYW5kIG5vIHJ1bm5pbmcgcHJvY2Vz c2VzCiBhbnltb3JlLgogCiBAaXRlbQotV2l0aCB0aGUgYXJndW1lbnQgQGNvZGV7ZGVsZXRl LWZyYW1lfSwgd2hlbiB0aGUgbGFzdCBjbGllbnQgZnJhbWUgaXMKK1dpdGggdGhlIHZhbHVl IEBjb2Rle2RlbGV0ZS1mcmFtZX0sIHdoZW4gdGhlIGxhc3QgY2xpZW50IGZyYW1lIGlzCiBi ZWluZyBjbG9zZWQsIHlvdSBhcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12 aXNpdGluZyBidWZmZXIKIG11c3QgYmUgc2F2ZWQgYW5kIGVhY2ggdW5maW5pc2hlZCBwcm9j ZXNzIGNhbiBiZSBzdG9wcGVkLCBhbmQgaWYgc28sCiB0aGUgc2VydmVyIGlzIHN0b3BwZWQu CiAKIEBpdGVtCi1XaXRoIHRoZSBhcmd1bWVudCBAY29kZXtraWxsLXRlcm1pbmFsfSwgd2hl biB0aGUgbGFzdCBjbGllbnQgZnJhbWUgaXMKK1dpdGggdGhlIHZhbHVlIEBjb2Rle2tpbGwt dGVybWluYWx9LCB3aGVuIHRoZSBsYXN0IGNsaWVudCBmcmFtZSBpcwogYmVpbmcgY2xvc2Vk IHdpdGggQGtiZHtDLXggQy1jfSAoQGNvZGV7c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9 KSwKIHlvdSBhcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBi dWZmZXIgbXVzdCBiZSBzYXZlZAogYW5kIGVhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBi ZSBzdG9wcGVkLCBhbmQgaWYgc28sIHRoZSBzZXJ2ZXIgaXMKZGlmZiAtLWdpdCBhL2xpc3Av c2VydmVyLmVsIGIvbGlzcC9zZXJ2ZXIuZWwKaW5kZXggMWIwMjdmODhjZS4uZGFjMDdkZmEz NSAxMDA2NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAg LTI3Myw2ICsyNzMsMTEgQEAgc2VydmVyLWNsaWVudC1pbnN0cnVjdGlvbnMKICAgOnZlcnNp b24gIjI4LjEiCiAgIDp0eXBlICdib29sZWFuKQogCisoZGVmdmFyIHNlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHkpICAgICAgOyBEZWZpbmVkIGJlbG93IHRvIGF2b2lkIHJlY3Vyc2l2ZSBs b2FkLgorCisoZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyIG5pbAor ICAiVGhlIHRpbWVyIG9iamVjdCBmb3IgYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1h eWJlLWtpbGwtZW1hY3MnLiIpCisKIDs7IFdlIGRvIG5vdCB1c2UgYHRlbXBvcmFyeS1maWxl LWRpcmVjdG9yeScgaGVyZSwgYmVjYXVzZSBlbWFjc2NsaWVudAogOzsgZG9lcyBub3QgcmVh ZCB0aGUgaW5pdCBmaWxlLgogKGRlZnZhciBzZXJ2ZXItc29ja2V0LWRpcgpAQCAtNjM2LDcg KzY0MSw4IEBAIHNlcnZlci1zdG9wCiAgICAgICAoc2V0cSBzdG9wcGVkLXAgdAogICAgICAg ICAgICAgc2VydmVyLXByb2Nlc3MgbmlsCiAgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwK LSAgICAgICAgICAgIGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xv YmFsLW1pbm9yLW1vZGVzKSkpCisgICAgICAgICAgICBnbG9iYWwtbWlub3ItbW9kZXMgKGRl bHEgJ3NlcnZlci1tb2RlIGdsb2JhbC1taW5vci1tb2RlcykpCisgICAgICAoc2VydmVyLWFw cGx5LXN0b3AtYXV0b21hdGljYWxseSkpCiAgICAgKHVud2luZC1wcm90ZWN0CiAgICAgICAg IDs7IERlbGV0ZSB0aGUgc29ja2V0IGZpbGVzIG1hZGUgYnkgcHJldmlvdXMgc2VydmVyCiAg ICAgICAgIDs7IGludm9jYXRpb25zLgpAQCAtNzU3LDYgKzc2Myw3IEBAIHNlcnZlci1zdGFy dAogCQkJIChsaXN0IDpmYW1pbHkgJ2xvY2FsCiAJCQkgICAgICAgOnNlcnZpY2Ugc2VydmVy LWZpbGUKIAkJCSAgICAgICA6cGxpc3QgJyg6YXV0aGVudGljYXRlZCB0KSkpKSkKKyAgICAg ICAgICAoc2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSkKIAkgICh1bmxlc3Mgc2Vy dmVyLXByb2Nlc3MgKGVycm9yICJDb3VsZCBub3Qgc3RhcnQgc2VydmVyIHByb2Nlc3MiKSkK ICAgICAgICAgICAoc2VydmVyLWxvZyAiU3RhcnRlZCBzZXJ2ZXIiKQogCSAgKHByb2Nlc3Mt cHV0IHNlcnZlci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKQEAgLTE3Njks OSArMTc3Niw2IEBAIHNlcnZlci1zd2l0Y2gtYnVmZmVyCiAgICAgKHdoZW4gc2VydmVyLXJh aXNlLWZyYW1lCiAgICAgICAoc2VsZWN0LWZyYW1lLXNldC1pbnB1dC1mb2N1cyAod2luZG93 LWZyYW1lKSkpKSkKIAotKGRlZnZhciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbAot ICAiSW50ZXJuYWwgc3RhdHVzIHZhcmlhYmxlIGZvciBgc2VydmVyLXN0b3AtYXV0b21hdGlj YWxseScuIikKLQogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItc2F2ZS1idWZmZXJz LWtpbGwtdGVybWluYWwgKGFyZykKICAgOzsgQ2FsbGVkIGZyb20gc2F2ZS1idWZmZXJzLWtp bGwtdGVybWluYWwgaW4gZmlsZXMuZWwuCkBAIC0xNzgwLDcgKzE3ODQsOCBAQCBzZXJ2ZXIt c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWwKIAogSWYgZW1hY3NjbGllbnQgd2FzIHN0YXJ0 ZWQgd2l0aCBhIGxpc3Qgb2YgZmlsZW5hbWVzIHRvIGVkaXQsIHRoZW4KIG9ubHkgdGhlc2Ug ZmlsZXMgd2lsbCBiZSBhc2tlZCB0byBiZSBzYXZlZC4iCi0gIChpZiBzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5CisgIChpZiAoYW5kIChkYWVtb25wKQorICAgICAgICAgICAobWVtcSBz ZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5ICcoa2lsbC10ZXJtaW5hbCBkZWxldGUtZnJhbWUp KQogICAgICAgKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJh bWUgKHNlbGVjdGVkLWZyYW1lKSkKICAgICAobGV0ICgocHJvYyAoZnJhbWUtcGFyYW1ldGVy IG5pbCAnY2xpZW50KSkpCiAgICAgICAoY29uZCAoKGVxIHByb2MgJ25vd2FpdCkKQEAgLTE4 MDUsNyArMTgxMCw3IEBAIHNlcnZlci1zYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbAogCSAg ICAodCAoZXJyb3IgIkludmFsaWQgY2xpZW50IGZyYW1lIikpKSkpKQogCiAoZGVmdW4gc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZSAoZnJhbWUpCi0g ICJIYW5kbGUgZGVsZXRpb24gb2YgRlJBTUUgd2hlbiBgc2VydmVyLXN0b3AtYXV0b21hdGlj YWxseScgaXMgdXNlZC4iCisgICJIYW5kbGUgZGVsZXRpb24gb2YgRlJBTUUgd2hlbiBgc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseScgaXMgYGRlbGV0ZS1mcmFtZScuIgogICAod2hlbiBz ZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CiAgICAgKGlmIChpZiAoYW5kIChwcm9jZXNzcCAo ZnJhbWUtcGFyYW1ldGVyIGZyYW1lICdjbGllbnQpKQogCQkgKGVxIHRoaXMtY29tbWFuZCAn c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWwpKQpAQCAtMTgyOCw3ICsxODMzLDcgQEAgc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZQogCSAgKGRlbGV0 ZS1mcmFtZSBmcmFtZSkpKSkpCiAKIChkZWZ1biBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5 LS1tYXliZS1raWxsLWVtYWNzICgpCi0gICJIYW5kbGUgY2xvc2luZyBvZiBFbWFjcyBkYWVt b24gd2hlbiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScgaXMgdXNlZC4iCisgICJIYW5k bGUgY2xvc2luZyBvZiBFbWFjcyBkYWVtb24gd2hlbiBgc2VydmVyLXN0b3AtYXV0b21hdGlj YWxseScgaXMgYGVtcHR5Jy4iCiAgICh1bmxlc3MgKGNkciAoZnJhbWUtbGlzdCkpCiAgICAg KHdoZW4gKGFuZAogCSAgIChub3QgKG1lbXEgdCAobWFwY2FyIChsYW1iZGEgKGIpCkBAIC0x ODQyLDQxICsxODQ3LDYxIEBAIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtp bGwtZW1hY3MKIAkJCQkocHJvY2Vzcy1saXN0KSkpKSkKICAgICAgIChraWxsLWVtYWNzKSkp KQogCi07OzsjIyNhdXRvbG9hZAotKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkg KGFyZykKLSAgIkF1dG9tYXRpY2FsbHkgc3RvcCBzZXJ2ZXIgYXMgc3BlY2lmaWVkIGJ5IEFS Ry4KLQotSWYgQVJHIGlzIHRoZSBzeW1ib2wgYGVtcHR5Jywgc3RvcCB0aGUgc2VydmVyIHdo ZW4gaXQgaGFzIG5vCisoZGVmdW4gc2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSAo KQorICAiQXBwbHkgdGhlIGN1cnJlbnQgdmFsdWUgb2YgYHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHknLgorVGhpcyBmdW5jdGlvbiBhZGRzIG9yIHJlbW92ZXMgdGhlIG5lY2Vzc2FyeSBo ZWxwZXJzIHRvIG1hbmFnZQorc3RvcHBpbmcgdGhlIEVtYWNzIHNlcnZlciBhdXRvbWF0aWNh bGx5LCBkZXBlbmRpbmcgb24gdGhlIHdoZXRoZXIKK3RoZSBzZXJ2ZXIgaXMgcnVubmluZyBv ciBub3QuICBUaGlzIGZ1bmN0aW9uIG9ubHkgYXBwbGllcyB3aGVuCitydW5uaW5nIEVtYWNz IGFzIGEgZGFlbW9uLiIKKyAgKHdoZW4gKGRhZW1vbnApCisgICAgKGxldCAoZW1wdHktdGlt ZXItcCBkZWxldGUtZnJhbWUtcCkKKyAgICAgICh3aGVuIHNlcnZlci1wcm9jZXNzCisgICAg ICAgIChwY2FzZSBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CisgICAgICAgICAgKCdlbXB0 eSAgICAgICAgKHNldHEgZW1wdHktdGltZXItcCB0KSkKKyAgICAgICAgICAoJ2RlbGV0ZS1m cmFtZSAoc2V0cSBkZWxldGUtZnJhbWUtcCB0KSkpKQorICAgICAgOzsgU3RhcnQgb3Igc3Rv cCB0aGUgdGltZXIuCisgICAgICAoaWYgZW1wdHktdGltZXItcAorICAgICAgICAgICh1bmxl c3Mgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGltZXIKKyAgICAgICAgICAgIChzZXRx IHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyCisgICAgICAgICAgICAgICAgICAo cnVuLXdpdGgtdGltZXIKKyAgICAgICAgICAgICAgICAgICAxMCAyCisJCSAgICMnc2VydmVy LXN0b3AtYXV0b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcykpKQorICAgICAgICAod2hl biBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10aW1lcgorICAgICAgICAgIChjYW5jZWwt dGltZXIgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGltZXIpCisgICAgICAgICAgKHNl dHEgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGltZXIgbmlsKSkpCisgICAgICA7OyBB ZGQgb3IgcmVtb3ZlIHRoZSBkZWxldGUtZnJhbWUgaG9vay4KKyAgICAgIChpZiBkZWxldGUt ZnJhbWUtcAorICAgICAgICAgIChhZGQtaG9vayAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucwor CQkgICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1l KQorICAgICAgICAocmVtb3ZlLWhvb2sgJ2RlbGV0ZS1mcmFtZS1mdW5jdGlvbnMKKyAgICAg ICAgICAgICAgICAgICAgICMnc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0taGFuZGxlLWRl bGV0ZS1mcmFtZSkpKSkpCisKKyhkZWZjdXN0b20gc2VydmVyLXN0b3AtYXV0b21hdGljYWxs eSBuaWwKKyAgIklmIG5vbi1uaWwsIHN0b3AgdGhlIHNlcnZlciB1bmRlciB0aGUgcmVxdWVz dGVkIGNvbmRpdGlvbnMuCisKK0lmIHRoaXMgaXMgdGhlIHN5bWJvbCBgZW1wdHknLCBzdG9w IHRoZSBzZXJ2ZXIgd2hlbiBpdCBoYXMgbm8KIHJlbWFpbmluZyBjbGllbnRzLCBubyByZW1h aW5pbmcgdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMsCiBhbmQgbm8gcnVubmluZyBw cm9jZXNzZXMgd2l0aCBhIGBxdWVyeS1vbi1leGl0JyBmbGFnLgogCi1JZiBBUkcgaXMgdGhl IHN5bWJvbCBgZGVsZXRlLWZyYW1lJywgYXNrIHRoZSB1c2VyIHdoZW4gdGhlIGxhc3QKK0lm IHRoaXMgaXMgdGhlIHN5bWJvbCBgZGVsZXRlLWZyYW1lJywgYXNrIHRoZSB1c2VyIHdoZW4g dGhlIGxhc3QKIGZyYW1lIGlzIGRlbGV0ZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12 aXNpdGluZyBidWZmZXIgbXVzdAogYmUgc2F2ZWQgYW5kIGVhY2ggcnVubmluZyBwcm9jZXNz IHdpdGggYSBgcXVlcnktb24tZXhpdCcgZmxhZwogY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBz bywgc3RvcCB0aGUgc2VydmVyIGl0c2VsZi4KIAotSWYgQVJHIGlzIHRoZSBzeW1ib2wgYGtp bGwtdGVybWluYWwnLCBhc2sgdGhlIHVzZXIgd2hlbiB0aGUKK0lmIHRoaXMgaXMgdGhlIHN5 bWJvbCBga2lsbC10ZXJtaW5hbCcsIGFzayB0aGUgdXNlciB3aGVuIHRoZQogdGVybWluYWwg aXMga2lsbGVkIHdpdGggXFxbc2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWxdIFwKIHdoZXRo ZXIgZWFjaCB1bnNhdmVkIGZpbGUtdmlzaXRpbmcKIGJ1ZmZlciBtdXN0IGJlIHNhdmVkIGFu ZCBlYWNoIHJ1bm5pbmcgcHJvY2VzcyB3aXRoIGEgYHF1ZXJ5LW9uLWV4aXQnCi1mbGFnIGNh biBiZSBzdG9wcGVkLCBhbmQgaWYgc28sIHN0b3AgdGhlIHNlcnZlciBpdHNlbGYuCi0KLUFu eSBvdGhlciB2YWx1ZSBvZiBBUkcgd2lsbCBjYXVzZSB0aGlzIGZ1bmN0aW9uIHRvIHNpZ25h bCBhbiBlcnJvci4KLQotVGhpcyBmdW5jdGlvbiBpcyBtZWFudCB0byBiZSBjYWxsZWQgZnJv bSB0aGUgdXNlciBpbml0IGZpbGUuIgotICAod2hlbiAoZGFlbW9ucCkKLSAgICAoc2V0cSBz ZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IGFyZykKLSAgICAoY29uZAotICAgICAoKGVxIGFy ZyAnZW1wdHkpCi0gICAgICAoc2V0cSBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbCkK LSAgICAgIChydW4td2l0aC10aW1lciAxMCAyCi0JCSAgICAgICMnc2VydmVyLXN0b3AtYXV0 b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcykpCi0gICAgICgoZXEgYXJnICdkZWxldGUt ZnJhbWUpCi0gICAgICAoYWRkLWhvb2sgJ2RlbGV0ZS1mcmFtZS1mdW5jdGlvbnMKLQkJIydz ZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lKSkKLSAgICAg KChlcSBhcmcgJ2tpbGwtdGVybWluYWwpKQotICAgICAodAotICAgICAgKGVycm9yICJVbmV4 cGVjdGVkIGFyZ3VtZW50IikpKSkpCitmbGFnIGNhbiBiZSBzdG9wcGVkLCBhbmQgaWYgc28s IHN0b3AgdGhlIHNlcnZlciBpdHNlbGYuIgorICA6dHlwZSAnKGNob2ljZQorICAgICAgICAg IChjb25zdCA6dGFnICJOZXZlciIgbmlsKQorICAgICAgICAgIChjb25zdCA6dGFnICJXaGVu IGVtcHR5IiBlbXB0eSkKKyAgICAgICAgICAoY29uc3QgOnRhZyAiV2hlbiBraWxsaW5nIGxh c3QgdGVybWluYWwiIGtpbGwtdGVybWluYWwpCisgICAgICAgICAgKGNvbnN0IDp0YWcgIldo ZW4ga2lsbGluZyBsYXN0IHRlcm1pbmFsIG9yIGZyYW1lIiBkZWxldGUtZnJhbWUpKQorICA6 c2V0IChsYW1iZGEgKHN5bWJvbCB2YWx1ZSkKKyAgICAgICAgIChzZXQtZGVmYXVsdCBzeW1i b2wgdmFsdWUpCisgICAgICAgICAoc2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSkp CisgIDp2ZXJzaW9uICIyOS4xIikKIAogKGRlZmluZS1rZXkgY3RsLXgtbWFwICIjIiAnc2Vy dmVyLWVkaXQpCiAKLS0gCjIuMjUuMQoK --------------JdPxMcdoofZo9WJZFNYSIyKJ-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 08:25:37 2022 Received: (at control) by debbugs.gnu.org; 1 Dec 2022 13:25:37 +0000 Received: from localhost ([127.0.0.1]:39697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0jZJ-00030x-1g for submit@debbugs.gnu.org; Thu, 01 Dec 2022 08:25:37 -0500 Received: from mail-ot1-f47.google.com ([209.85.210.47]:35404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0jZC-00030d-N6 for control@debbugs.gnu.org; Thu, 01 Dec 2022 08:25:35 -0500 Received: by mail-ot1-f47.google.com with SMTP id cn2-20020a056830658200b0066c74617e3dso935914otb.2 for ; Thu, 01 Dec 2022 05:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=1yBdpRIu7wp97SVXxeDSN1+HcgvHiSCGF+qa0dKanxE=; b=BDIn/6Mlx6uWueHZbAs3lrBXqHHF5xz5cKMxJasDvUssmN6X8sfc9hF/DkVD+tbXqJ cvX6UaqqPKWNZP4ggkiwTfhi9rIkV8GWZwD3mVMSX9/5NSEith2d2BRf2nLYwN8FND9s M7unmsS2kwLVr7dR20dYYqRrH0BzCZrkjgZI9N2Gna7tnEKjaqmkOFLLCzUWt7/WwH4L UleimdVoCVi6UwIOFShYjguBU0zF6Vd+Rar9YrDtsw6mx2GHkSQ0t1LEhH6Yyy0eGNt8 htrxtOQRwesk3KW/L/t9qXFysl5kps94Sx2c8bcn2Ca8rHaM832r7z8p1I6caBOqZ3VY PPuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1yBdpRIu7wp97SVXxeDSN1+HcgvHiSCGF+qa0dKanxE=; b=dF66BTbftRGtUoiB2oNGmn15XJaSbR83+gmr30O0wsMft+oumFO+o9W+M0/juzazb8 Sbde3RJmbEbVHrs2K06jcERBunNbvJ47Ike6araP9tX+spdZ/BxGDvk8uY72X97Yemr+ nTQI0Pl97ZpUpJclJj1Fz2DJGg8HddTEJ6HfNNu5TWbs7iaB85OLxuQt4t1kUi5kVAMC eOgOCnVR6acoR6UqVpkKFyd9lxwZWfxZaOpwan7WNWhk3flOyXmUkZS6SKaZvXj8WtK+ sChgBY953m+jkH5a2ETuLxjSUnaUalKyt26i2asBGD9gB4j5C/bJgv0elVAyAGUpgGB0 R4vw== X-Gm-Message-State: ANoB5pnFEmWzoKH3M1ieOU4g2ACP7/dYefHjoIoNNAeMuaV9jTJ5ilFF vLlWKWTC7pSE21y0SgfKVd64LD7jVXQyNNnrT3yPWj3w X-Google-Smtp-Source: AA0mqf75yqwJ09nPdldom6GqsyH7iW4EHLcGYhqImqW300P2G/bnSBA6HTrTM8zAOfoWsxoMBJ4P5gaY3t59JXgwrto= X-Received: by 2002:a9d:5c81:0:b0:661:c48b:12db with SMTP id a1-20020a9d5c81000000b00661c48b12dbmr23840310oti.105.1669901125260; Thu, 01 Dec 2022 05:25:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 1 Dec 2022 05:25:24 -0800 From: Stefan Kangas X-Hashcash: 1:20:221201:control@debbugs.gnu.org::x+JieZTy3EQGSOTq:6dut MIME-Version: 1.0 Date: Thu, 1 Dec 2022 05:25:24 -0800 Message-ID: Subject: control message for bug #59668 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 59668 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 12:08:42 2022 Received: (at 59668) by debbugs.gnu.org; 1 Dec 2022 17:08:42 +0000 Received: from localhost ([127.0.0.1]:40862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0n3B-000888-V7 for submit@debbugs.gnu.org; Thu, 01 Dec 2022 12:08:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0n3A-000882-5e for 59668@debbugs.gnu.org; Thu, 01 Dec 2022 12:08:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0n34-0001X0-QY; Thu, 01 Dec 2022 12:08:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5TvXb/3yda+BhhsOVkphu00zUUDh0uAeVV8TNI/v1Tg=; b=pZfRLn5EhrBQ 5Z8ZrKalOwReVk1baSRuk420JZ7FFGOYxVfL9QsCpcv0M6WivZwX6RZxJr786+qSDeG4yzA0yC9gi BE1pAyqfhMylpV1SkaKGXQ6vIPdLa2MWvt7w1yiHs/Y+Hz2+CeXj0oUdhOCACiE/61+mlaKML/6jd qKW+Ky88DCsGW/WWngeYBxnnEFkj20eF2OyY8lCWR0kZ5TePFVHYrOfXMgu8ZSu1Q+z522HAWZ507 6ixLsS7tpQh//eaDfO0El6OWfrLmAEEHByJqqHd2TJItU42fp/ESCJ+6CttUdJoVs3r/w+nbtvhx3 44o969cfqnx63YRC1fiBZA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p0n34-0003Mx-4H; Thu, 01 Dec 2022 12:08:34 -0500 Date: Thu, 01 Dec 2022 19:08:07 +0200 Message-Id: <83mt87gih4.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> (message from Jim Porter on Mon, 28 Nov 2022 20:23:17 -0800) Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 28 Nov 2022 20:23:17 -0800 > From: Jim Porter > > The Emacs server can optionally be stopped automatically when > certain conditions are met. To do this, call the function > @code{server-stop-automatically} in your init file (@pxref{Init > File}), with one of the following arguments... > > It'd be nice if this were a defcustom so that people who prefer the > Customize interface could use that instead of editing their init files. > Here's a patch for that. Thanks. > One question though: should this only go on the master branch, or should > it go into the 29 branch? To me, it seems like it could go either way, > though I think it'd be nice to make this easier for users in 29. I'll do > whatever the maintainers think is best though. Let's not start installing new features on the release branch. We have enough new stuff there already. Besides, the changes you suggest are hardly trivial, and saying just "make a function into a defcustom" doesn't come close to describing it, IMO. So please install on master, once you take care of the comments below. > If it goes on the master branch only, I'll add back the function form of > 'server-stop-automatically' for compatibility, and then mark it obsolete. I see no reason to make the function obsolete. It does not harm to have both a variable and a function by the same name. > -@findex server-stop-automatically > +@vindex server-stop-automatically > The Emacs server can optionally be stopped automatically when > -certain conditions are met. To do this, call the function > -@code{server-stop-automatically} in your init file (@pxref{Init > -File}), with one of the following arguments: > +certain conditions are met. To do this, set the option > +@code{server-stop-automatically} to one of the following values: > > @itemize > @item > -With the argument @code{empty}, the server is stopped when it has no > +With the value @code{empty}, the server is stopped when it has no > clients, no unsaved file-visiting buffers and no running processes > anymore. > > @item > -With the argument @code{delete-frame}, when the last client frame is > +With the value @code{delete-frame}, when the last client frame is > being closed, you are asked whether each unsaved file-visiting buffer > must be saved and each unfinished process can be stopped, and if so, > the server is stopped. This @itemize list should be converted to a @table, formatted like this: @item empty This value caused the server to be stopped when... @item delete-frame This value means that when the last client frame is deleted... etc., I guess you get the idea. > @@ -1780,7 +1784,8 @@ server-save-buffers-kill-terminal > > If emacsclient was started with a list of filenames to edit, then > only these files will be asked to be saved." > - (if server-stop-automatically > + (if (and (daemonp) > + (memq server-stop-automatically '(kill-terminal delete-frame)) Why is this needed? I guess I don't understand why non-trivial code changes are in a patch that was supposed to just add a defcustom? > +(defun server-apply-stop-automatically () > + "Apply the current value of `server-stop-automatically'. > +This function adds or removes the necessary helpers to manage > +stopping the Emacs server automatically, depending on the whether > +the server is running or not. This function only applies when > +running Emacs as a daemon." And why this significant refactoring of the original function? was there something wrong with it? From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 13:34:08 2022 Received: (at 59668) by debbugs.gnu.org; 1 Dec 2022 18:34:09 +0000 Received: from localhost ([127.0.0.1]:41259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0oNs-0000TE-IQ for submit@debbugs.gnu.org; Thu, 01 Dec 2022 13:34:08 -0500 Received: from mail-pj1-f52.google.com ([209.85.216.52]:47014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0oNp-0000Sq-9q for 59668@debbugs.gnu.org; Thu, 01 Dec 2022 13:34:06 -0500 Received: by mail-pj1-f52.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so2925366pjd.5 for <59668@debbugs.gnu.org>; Thu, 01 Dec 2022 10:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=MXM1Kxgu1Z7q0G47eOY1Y6V1KaKZS1fqxoTIBi8VaFI=; b=WHoNlzjnIvq5OD0UY9QB9BpC5+Zjp4XjHIXyoqtV2qJHE7S1wY4BSKtmtZmTShbA9a S6gtBva3aNL0gTdEeKxiotAkHiiOyIQRbi7vmsctb5ef3ZRsbUjA1Af2keOXFbS+W6uZ /9wQHu5UmtQ0MfhwHpFac/3EIrnxtkkqOjD4Nr3l4WlmIHscTXzzBGAvS+/y/oLQquCv iRQd84d3LpCxWUb9jqshnRSJKEJ27gL6Ryizhks7g8YdZ2Q5Wp4Gkq4lay9UVFsLemYw brUKctCPqZd2Ddc67eQNk0weSoHQtRT+bvJDlzYWzD+dW03OfkSEQJYXwOPtKm2PHjny eobA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MXM1Kxgu1Z7q0G47eOY1Y6V1KaKZS1fqxoTIBi8VaFI=; b=m8KColhI/VoH97lnJnfoWB91zAoYM1f/DOhe9nO/yQWlR2Oy71wy81wmTgW94hi4We YArlu0qGLqA6swRObig8DQTvg4VJMs7d8xyP7k/FHQJ4QSXqlGpJv9opzT5Z32DJiexF v4cad6q+fL4RxO4AxqbXzR+K1k60Y4b/TMawKRW6PRgUGVW7RslB5uczactto2IzAYe9 t1lc6BAN7dhw6PafeUrjfNIJI5qYf3TmE32kB5Rns1L0Hb8GC/LUC9Hu7A7Lpsh9i7o7 2SuXcSa1dArNnecSPmkCblMH0UpOCvB8twLfF/FqExUKlRgAJe/W6DrFZL1Fql+FFka+ HeKQ== X-Gm-Message-State: ANoB5pkPmN12F5vP9pPVCZwTUH7t5lrXJtlX6ZvGZ9ZzMonF+2O0flVF 1I2CkXzKRBHF3UHCbqixtKDPxph5ozo= X-Google-Smtp-Source: AA0mqf5Fbn0geplTZFu55k9PDPgh1AbRqDLK1cKU/qsJBnrqbZotnzBAMio4rZGHn6ITp494uwy6bw== X-Received: by 2002:a17:903:2350:b0:189:8ea3:7455 with SMTP id c16-20020a170903235000b001898ea37455mr20477738plh.19.1669919639298; Thu, 01 Dec 2022 10:33:59 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id d11-20020a170902cecb00b00189327b022bsm3962738plg.286.2022.12.01.10.33.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 10:33:58 -0800 (PST) Message-ID: <70013d69-1d9d-c268-fd9b-8b04c362aabc@gmail.com> Date: Thu, 1 Dec 2022 10:33:57 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> From: Jim Porter In-Reply-To: <83mt87gih4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/1/2022 9:08 AM, Eli Zaretskii wrote: >> Date: Mon, 28 Nov 2022 20:23:17 -0800 >> From: Jim Porter >> >> One question though: should this only go on the master branch, or should >> it go into the 29 branch? To me, it seems like it could go either way, >> though I think it'd be nice to make this easier for users in 29. I'll do >> whatever the maintainers think is best though. > > Let's not start installing new features on the release branch. ... Sounds good to me. >> If it goes on the master branch only, I'll add back the function form of >> 'server-stop-automatically' for compatibility, and then mark it obsolete. > > I see no reason to make the function obsolete. It does not harm to have > both a variable and a function by the same name. Fine by me. The function will just be a one-liner anyway: (setopt server-stop-automatically arg). > This @itemize list should be converted to a @table, formatted like this: > > @item empty > This value caused the server to be stopped when... > > @item delete-frame > This value means that when the last client frame is deleted... > > etc., I guess you get the idea. Will do. I made the minimal set of changes to the manual, but while I'm here, I agree that it would be good to improve things further. >> @@ -1780,7 +1784,8 @@ server-save-buffers-kill-terminal >> >> If emacsclient was started with a list of filenames to edit, then >> only these files will be asked to be saved." >> - (if server-stop-automatically >> + (if (and (daemonp) >> + (memq server-stop-automatically '(kill-terminal delete-frame)) > > Why is this needed? I guess I don't understand why non-trivial code changes > are in a patch that was supposed to just add a defcustom? It's due to a change in the meaning of the 'server-stop-automatically' value. Previously, it was an internal variable that was set to nil after calling "(server-stop-automatically 'empty)", or when calling 'server-stop-automatically' in a non-daemon session. Since 'server-stop-automatically' is now a defcustom, that means that a) it can really be set to 'empty', and b) it can be non-nil in non-daemon sessions. So this extra code is just to account for the change in meaning. I could make a helper function that returns the same value as the *old* version of the 'server-stop-automatically' variable; either way has the same meaning. I could also keep the old variable around, possibly renamed to something like 'server-stop-automatically--kill-terminal', but I think a helper function would be cleaner. >> +(defun server-apply-stop-automatically () >> + "Apply the current value of `server-stop-automatically'. >> +This function adds or removes the necessary helpers to manage >> +stopping the Emacs server automatically, depending on the whether >> +the server is running or not. This function only applies when >> +running Emacs as a daemon." > > And why this significant refactoring of the original function? was there > something wrong with it? The previous implementation was limited in that you could call it once, but you couldn't necessarily call it a second time to change the setting. For example, this would put you in an inconsistent state: (server-stop-automatically 'delete-frame) (server-stop-automatically 'empty) After this, the 'empty' setting would be enabled, and the 'delete-frame' setting would still be partially-enabled too. That wasn't so much of a problem when you'd just call this function only once in your init file, but for the Customize interface, I think it's important to make sure that users can set the defcustom multiple times, e.g. if they change their minds while customizing it. The changes for 'server-apply-stop-automatically' are to support that. As you said, these changes are more extensive than "just" adding a defcustom, but all the other changes are there to support the Customize interface. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 13:41:32 2022 Received: (at 59668) by debbugs.gnu.org; 1 Dec 2022 18:41:32 +0000 Received: from localhost ([127.0.0.1]:41303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0oV1-0000XN-Pf for submit@debbugs.gnu.org; Thu, 01 Dec 2022 13:41:32 -0500 Received: from mail-pg1-f179.google.com ([209.85.215.179]:46673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0oUw-0000XC-J6 for 59668@debbugs.gnu.org; Thu, 01 Dec 2022 13:41:30 -0500 Received: by mail-pg1-f179.google.com with SMTP id 62so2381167pgb.13 for <59668@debbugs.gnu.org>; Thu, 01 Dec 2022 10:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=WcYh8e+QPPlX/1wYDezT9rsOJOwExSqmDwbSd8E4w1Y=; b=OcnTPvX5JvCsMpyUepZyUwGdru4j/pWA20OQRh1+VRaWGZ151sO7Rg1HkjmJyY0sYL +Vmz8dtjDItZomy5fjcSHjSxbOgn4iuScUz5u+IsEAX4Pwsyh1cgX9jie2hlBWEJ6gOR rM7D7+cxC9UsMj9bhvhKYV4O7fH6/N4+rDuflZrj6kPmqDTynscwAF51dxsrduBVXaMc F/3WPoyvDcPKkjaMFtr/zSkt8dr79SBJ4qigTF5aO41UsaQObmEghOYWyOax2xfIQ3dt xyga/WQw/LsjB/Ocv3r9dHOH1XIjTJ7oitwmwzjiki3DmtblRE+X/NdHZcXf9cpOuPcE ROpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WcYh8e+QPPlX/1wYDezT9rsOJOwExSqmDwbSd8E4w1Y=; b=fJ70hl5Ge4XH+/hnaDc13AshWzhscxZJa5952xoN/6Jnge4A8M0bqg++x3IB9xCaQ2 M2UPk2g75e6sTRfuMfAYayIp661DaN4QW/Mzu0bZQ74/f08JjenDcZX/VpzDUlGDFAjz SVEaVh0bW+83ejxdrFQ6eqEPqbzkbfVYbz4xbVDLjFMBmKIExl7vNCBDHs37iOvVtMrK pQV3xaEcKPoZyd2p3xH0rC3Qyc+y9VlHNUMAM2bTgq4dG8ULYjcL5JDNtJd40t2j2slF 264ZbKdWs9PTi1jiASTG431USPQBL+sA+zGmPyJiurHV1B4+uIwkuDekF7oZSkYCWdPB nQFA== X-Gm-Message-State: ANoB5pnjjdtMxOB9J2QO68+6JBw3tv0sKgcMsxIjeEkIKogmOTewtRmC 60jhyrT7a0tNnw6IFSF0z/Q= X-Google-Smtp-Source: AA0mqf5IN3tSpGuasO4nnV1yZM8OT1W2KpdLXKhfiSQmN8CW0jrmBDcMCAtWr+VAes/yWGghSnovig== X-Received: by 2002:a63:e509:0:b0:476:a862:53a6 with SMTP id r9-20020a63e509000000b00476a86253a6mr40359197pgh.489.1669920080600; Thu, 01 Dec 2022 10:41:20 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k1-20020a170902c40100b001895b2c4cf6sm3949975plk.297.2022.12.01.10.41.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 10:41:19 -0800 (PST) Message-ID: <987eccaa-2a81-70dc-ee71-63f8709bd1b8@gmail.com> Date: Thu, 1 Dec 2022 10:41:19 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <70013d69-1d9d-c268-fd9b-8b04c362aabc@gmail.com> In-Reply-To: <70013d69-1d9d-c268-fd9b-8b04c362aabc@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/1/2022 10:33 AM, Jim Porter wrote: > I could make a helper function that returns the same value as the *old* > version of the 'server-stop-automatically' variable; either way has the > same meaning. Oops, the bit after the semicolon should be "this would do the same thing as the current conditional." From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 01 22:30:14 2022 Received: (at 59668) by debbugs.gnu.org; 2 Dec 2022 03:30:14 +0000 Received: from localhost ([127.0.0.1]:43640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0wkf-0005Ne-QI for submit@debbugs.gnu.org; Thu, 01 Dec 2022 22:30:14 -0500 Received: from mail-pf1-f179.google.com ([209.85.210.179]:36780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p0wkc-0005MQ-NK for 59668@debbugs.gnu.org; Thu, 01 Dec 2022 22:30:12 -0500 Received: by mail-pf1-f179.google.com with SMTP id x66so3759056pfx.3 for <59668@debbugs.gnu.org>; Thu, 01 Dec 2022 19:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=de6klC36xIwrP74pHYYkAbDNY7yyKK4VCDRI0jIPDOs=; b=ZTWEgGz6dJ+9yTF7LX8zsZYH25sc+hdaGb+U4xPO95hNxSWBBl9JylV0Fle6L7ffQC fieU1FbKMsDKB3cMGry+tIbNsQPsQC3HARH6zws2d43IT8Rg6MieaPfnwlPON6qv+Q4D GYjUnZj3+vWB2cpx6dvXAIRqdec3aTHcx6yKVYheGTe5UZgkTn4ZAe/IhbpEDYv28b/5 UkFXI3tnzwzqzNL1iPl3QAyatVfOKEyrZmkZmLBLLqb9wap0sWNQg+R46E94EizBn/sq SFwekF5Q8yzsuVbPOnJ/228TsKF7jPyFRo4tEaczEy3azXUCvs6KMSLo0I/5ZtKoy2sC DOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=de6klC36xIwrP74pHYYkAbDNY7yyKK4VCDRI0jIPDOs=; b=VgjOjvsf9a+ozyKikGPF1+6+NANJIcGyHJ9D2+xlFb7CBQktPKFNQnlpiibH/LwRu4 eB2dG8yK8mOGCTSFwWu+brK90d6ObQC3SMQ8GBUlnuPAqEht5mSXQ53ZaZU3m9fmJ0P/ jcjYLbERTKU2GImiB0fODp+hnwF13UldFjU1NAVwAt/ZsAzNi/JS1JLslmLGGkCSusL4 UTRY7nQT/kCnF+BHg6h/SvgYirjzr9x+PYmeqdWQJ8CQ4tb6DQ5TW//CMM5XQzEKIEIy SPSQuj/fBx945trGAJk3GEN2sFGxaCu5h2x6gjnDKpavQrybBxQ5p3eBrPOBZR79FsQi OjhQ== X-Gm-Message-State: ANoB5plsX5kIOt7oAo/VYIXvpwE85ViZOyuvQIJeNaJxsT6NHhlqlqZZ l21MKg+PKc1G+rQHu7v5mTQ= X-Google-Smtp-Source: AA0mqf7LSXVU7UEJKbT6ClkYxluM3wnQzhi1b0D0xq1wXIR57fWZ80KXT+kAWnb2kepFKl/DIdgeYw== X-Received: by 2002:a05:6a00:2:b0:576:14a5:359 with SMTP id h2-20020a056a00000200b0057614a50359mr6727716pfk.26.1669951804778; Thu, 01 Dec 2022 19:30:04 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x189-20020a6263c6000000b00575d6ec23f2sm3979295pfb.106.2022.12.01.19.30.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Dec 2022 19:30:03 -0800 (PST) Content-Type: multipart/mixed; boundary="------------3AhE3xjk2Qceq02C2pDPufCo" Message-ID: <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> Date: Thu, 1 Dec 2022 19:30:03 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> From: Jim Porter In-Reply-To: <83mt87gih4.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------3AhE3xjk2Qceq02C2pDPufCo Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/1/2022 9:08 AM, Eli Zaretskii wrote: > I see no reason to make the function obsolete. It does not harm to have > both a variable and a function by the same name. Ok, fixed. I've added back a 'server-stop-automatically' function that just sets the variable. > This @itemize list should be converted to a @table, formatted like this: > > @item empty > This value caused the server to be stopped when... > > @item delete-frame > This value means that when the last client frame is deleted... Done. >> @@ -1780,7 +1784,8 @@ server-save-buffers-kill-terminal >> >> If emacsclient was started with a list of filenames to edit, then >> only these files will be asked to be saved." >> - (if server-stop-automatically >> + (if (and (daemonp) >> + (memq server-stop-automatically '(kill-terminal delete-frame)) > > Why is this needed? I guess I don't understand why non-trivial code changes > are in a patch that was supposed to just add a defcustom? Addressed in my other message, but I've added a defsubst to make this clearer (I hope). --------------3AhE3xjk2Qceq02C2pDPufCo Content-Type: text/plain; charset=UTF-8; name="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Disposition: attachment; filename*0="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Transfer-Encoding: base64 RnJvbSBjMGYyNDViZmZhNzI0M2FkMTQxMThlMWI2MTQ1YzdiMGUwYjNjZDNmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMjI6MjE6MTAgLTA4MDAKU3ViamVjdDogW1BB VENIXSBNYWtlICdzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpbnRvIGEgZGVmY3VzdG9t CgoqIGxpc3Avc2VydmVyLmVsIChzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5KTogQ29udmVy dCB0aGUgdmFyaWFibGUgdG8KYSBkZWZjdXN0b20sIGFuZCBtYWtlIHRoZSBmdW5jdGlvbiBz aW1wbHkgc2V0IHRoZSBkZWZjdXN0b20uCihzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lcik6IE5ldyB2YXJpYWJsZS4KKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXdoZW4t a2lsbGluZy10ZXJtaW5hbCk6CihzZXJ2ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5KTog TmV3IGZ1bmN0aW9ucy4KKHNlcnZlci1zdG9wLCBzZXJ2ZXItc3RhcnQpOiBDYWxsICdzZXJ2 ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5Jy4KKHNlcnZlci1zYXZlLWJ1ZmZlcnMta2ls bC10ZXJtaW5hbCk6IEFkanVzdAonc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScgY29uZGl0 aW9uYWwuCihzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1l KQooc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcyk6IFVwZGF0 ZSBkb2NzdHJpbmdzLgoKKiBkb2MvZW1hY3MvbWlzYy50ZXhpIChFbWFjcyBTZXJ2ZXIpOiBV cGRhdGUgZG9jdW1lbnRhdGlvbi4KLS0tCiBkb2MvZW1hY3MvbWlzYy50ZXhpIHwgNDEgKysr KysrKysrLS0tLS0tLS0tLQogbGlzcC9zZXJ2ZXIuZWwgICAgICB8IDk2ICsrKysrKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCA4 NCBpbnNlcnRpb25zKCspLCA1MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvZW1h Y3MvbWlzYy50ZXhpIGIvZG9jL2VtYWNzL21pc2MudGV4aQppbmRleCAyOWMwYmVkMTljLi43 MDJjNzJiYWMyIDEwMDY0NAotLS0gYS9kb2MvZW1hY3MvbWlzYy50ZXhpCisrKyBiL2RvYy9l bWFjcy9taXNjLnRleGkKQEAgLTE4MDgsMzEgKzE4MDgsMjggQEAgRW1hY3MgU2VydmVyCiAg IGVtYWNzIC0tZGFlbW9uPWZvbwogQGVuZCBleGFtcGxlCiAKLUBmaW5kZXggc2VydmVyLXN0 b3AtYXV0b21hdGljYWxseQorQHZpbmRleCBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CiAg IFRoZSBFbWFjcyBzZXJ2ZXIgY2FuIG9wdGlvbmFsbHkgYmUgc3RvcHBlZCBhdXRvbWF0aWNh bGx5IHdoZW4KLWNlcnRhaW4gY29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8gdGhpcywgY2Fs bCB0aGUgZnVuY3Rpb24KLUBjb2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9IGluIHlv dXIgaW5pdCBmaWxlIChAcHhyZWZ7SW5pdAotRmlsZX0pLCB3aXRoIG9uZSBvZiB0aGUgZm9s bG93aW5nIGFyZ3VtZW50czoKK2NlcnRhaW4gY29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8g dGhpcywgc2V0IHRoZSBvcHRpb24KK0Bjb2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9 IHRvIG9uZSBvZiB0aGUgZm9sbG93aW5nIHZhbHVlczoKIAotQGl0ZW1pemUKLUBpdGVtCi1X aXRoIHRoZSBhcmd1bWVudCBAY29kZXtlbXB0eX0sIHRoZSBzZXJ2ZXIgaXMgc3RvcHBlZCB3 aGVuIGl0IGhhcyBubwotY2xpZW50cywgbm8gdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZl cnMgYW5kIG5vIHJ1bm5pbmcgcHJvY2Vzc2VzCi1hbnltb3JlLgotCi1AaXRlbQotV2l0aCB0 aGUgYXJndW1lbnQgQGNvZGV7ZGVsZXRlLWZyYW1lfSwgd2hlbiB0aGUgbGFzdCBjbGllbnQg ZnJhbWUgaXMKLWJlaW5nIGNsb3NlZCwgeW91IGFyZSBhc2tlZCB3aGV0aGVyIGVhY2ggdW5z YXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcgotbXVzdCBiZSBzYXZlZCBhbmQgZWFjaCB1bmZp bmlzaGVkIHByb2Nlc3MgY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBzbywKLXRoZSBzZXJ2ZXIg aXMgc3RvcHBlZC4KLQotQGl0ZW0KLVdpdGggdGhlIGFyZ3VtZW50IEBjb2Rle2tpbGwtdGVy bWluYWx9LCB3aGVuIHRoZSBsYXN0IGNsaWVudCBmcmFtZSBpcwotYmVpbmcgY2xvc2VkIHdp dGggQGtiZHtDLXggQy1jfSAoQGNvZGV7c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9KSwK LXlvdSBhcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZm ZXIgbXVzdCBiZSBzYXZlZAotYW5kIGVhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBiZSBz dG9wcGVkLCBhbmQgaWYgc28sIHRoZSBzZXJ2ZXIgaXMKK0B0YWJsZSBAY29kZQorQGl0ZW0g ZW1wdHkKK1RoaXMgdmFsdWUgY2F1c2VzIHRoZSBzZXJ2ZXIgdG8gYmUgc3RvcHBlZCB3aGVu IGl0IGhhcyBubyBjbGllbnRzLCBubwordW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMg YW5kIG5vIHJ1bm5pbmcgcHJvY2Vzc2VzIGFueW1vcmUuCisKK0BpdGVtIGRlbGV0ZS1mcmFt ZQorVGhpcyB2YWx1ZSBtZWFucyB0aGF0IHdoZW4gdGhlIGxhc3QgY2xpZW50IGZyYW1lIGlz IGJlaW5nIGNsb3NlZCwgeW91CithcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmls ZS12aXNpdGluZyBidWZmZXIgbXVzdCBiZSBzYXZlZCBhbmQKK2VhY2ggdW5maW5pc2hlZCBw cm9jZXNzIGNhbiBiZSBzdG9wcGVkLCBhbmQgaWYgc28sIHRoZSBzZXJ2ZXIgaXMKIHN0b3Bw ZWQuCi1AZW5kIGl0ZW1pemUKKworQGl0ZW0ga2lsbC10ZXJtaW5hbAorVGhpcyB2YWx1ZSBt ZWFucyB0aGF0IHdoZW4gdGhlIGxhc3QgY2xpZW50IGZyYW1lIGlzIGJlaW5nIGNsb3NlZCB3 aXRoCitAa2Jke0MteCBDLWN9IChAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbH0p LCB5b3UgYXJlIGFza2VkCit3aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1 ZmZlciBtdXN0IGJlIHNhdmVkIGFuZCBlYWNoCit1bmZpbmlzaGVkIHByb2Nlc3MgY2FuIGJl IHN0b3BwZWQsIGFuZCBpZiBzbywgdGhlIHNlcnZlciBpcyBzdG9wcGVkLgorQGVuZCB0YWJs ZQogCiBAZmluZGV4IHNlcnZlci1ldmFsLWF0CiAgIElmIHlvdSBoYXZlIGRlZmluZWQgYSBz ZXJ2ZXIgYnkgYSB1bmlxdWUgc2VydmVyIG5hbWUsIGl0IGlzIHBvc3NpYmxlCmRpZmYgLS1n aXQgYS9saXNwL3NlcnZlci5lbCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IDFiMDI3Zjg4Y2Uu LmUxNmE5ZTQ2NGUgMTAwNjQ0Ci0tLSBhL2xpc3Avc2VydmVyLmVsCisrKyBiL2xpc3Avc2Vy dmVyLmVsCkBAIC0yNzMsNiArMjczLDExIEBAIHNlcnZlci1jbGllbnQtaW5zdHJ1Y3Rpb25z CiAgIDp2ZXJzaW9uICIyOC4xIgogICA6dHlwZSAnYm9vbGVhbikKIAorKGRlZnZhciBzZXJ2 ZXItc3RvcC1hdXRvbWF0aWNhbGx5KSAgICAgIDsgRGVmaW5lZCBiZWxvdyB0byBhdm9pZCBy ZWN1cnNpdmUgbG9hZC4KKworKGRlZnZhciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lciBuaWwKKyAgIlRoZSB0aW1lciBvYmplY3QgZm9yIGBzZXJ2ZXItc3RvcC1hdXRvbWF0 aWNhbGx5LS1tYXliZS1raWxsLWVtYWNzJy4iKQorCiA7OyBXZSBkbyBub3QgdXNlIGB0ZW1w b3JhcnktZmlsZS1kaXJlY3RvcnknIGhlcmUsIGJlY2F1c2UgZW1hY3NjbGllbnQKIDs7IGRv ZXMgbm90IHJlYWQgdGhlIGluaXQgZmlsZS4KIChkZWZ2YXIgc2VydmVyLXNvY2tldC1kaXIK QEAgLTYzNiw3ICs2NDEsOCBAQCBzZXJ2ZXItc3RvcAogICAgICAgKHNldHEgc3RvcHBlZC1w IHQKICAgICAgICAgICAgIHNlcnZlci1wcm9jZXNzIG5pbAogICAgICAgICAgICAgc2VydmVy LW1vZGUgbmlsCi0gICAgICAgICAgICBnbG9iYWwtbWlub3ItbW9kZXMgKGRlbHEgJ3NlcnZl ci1tb2RlIGdsb2JhbC1taW5vci1tb2RlcykpKQorICAgICAgICAgICAgZ2xvYmFsLW1pbm9y LW1vZGVzIChkZWxxICdzZXJ2ZXItbW9kZSBnbG9iYWwtbWlub3ItbW9kZXMpKQorICAgICAg KHNlcnZlci1hcHBseS1zdG9wLWF1dG9tYXRpY2FsbHkpKQogICAgICh1bndpbmQtcHJvdGVj dAogICAgICAgICA7OyBEZWxldGUgdGhlIHNvY2tldCBmaWxlcyBtYWRlIGJ5IHByZXZpb3Vz IHNlcnZlcgogICAgICAgICA7OyBpbnZvY2F0aW9ucy4KQEAgLTc1Nyw2ICs3NjMsNyBAQCBz ZXJ2ZXItc3RhcnQKIAkJCSAobGlzdCA6ZmFtaWx5ICdsb2NhbAogCQkJICAgICAgIDpzZXJ2 aWNlIHNlcnZlci1maWxlCiAJCQkgICAgICAgOnBsaXN0ICcoOmF1dGhlbnRpY2F0ZWQgdCkp KSkpCisgICAgICAgICAgKHNlcnZlci1hcHBseS1zdG9wLWF1dG9tYXRpY2FsbHkpCiAJICAo dW5sZXNzIHNlcnZlci1wcm9jZXNzIChlcnJvciAiQ291bGQgbm90IHN0YXJ0IHNlcnZlciBw cm9jZXNzIikpCiAgICAgICAgICAgKHNlcnZlci1sb2cgIlN0YXJ0ZWQgc2VydmVyIikKIAkg IChwcm9jZXNzLXB1dCBzZXJ2ZXItcHJvY2VzcyA6c2VydmVyLWZpbGUgc2VydmVyLWZpbGUp CkBAIC0xNzY5LDggKzE3NzYsMTAgQEAgc2VydmVyLXN3aXRjaC1idWZmZXIKICAgICAod2hl biBzZXJ2ZXItcmFpc2UtZnJhbWUKICAgICAgIChzZWxlY3QtZnJhbWUtc2V0LWlucHV0LWZv Y3VzICh3aW5kb3ctZnJhbWUpKSkpKQogCi0oZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkgbmlsCi0gICJJbnRlcm5hbCBzdGF0dXMgdmFyaWFibGUgZm9yIGBzZXJ2ZXItc3Rv cC1hdXRvbWF0aWNhbGx5Jy4iKQorKGRlZnN1YnN0IHNlcnZlci1zdG9wLWF1dG9tYXRpY2Fs bHktLXdoZW4ta2lsbGluZy10ZXJtaW5hbCAoKQorICAiUmV0dXJuIG5vbi1uaWwgaWYgd2Ug c2hvdWxkIHBvdGVudGlhbGx5IHN0b3AgRW1hY3Mgd2hlbiBraWxsaW5nIGEgdGVybWluYWwu IgorICAoYW5kIChkYWVtb25wKQorICAgICAgIChtZW1xIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkgJyhraWxsLXRlcm1pbmFsIGRlbGV0ZS1mcmFtZSkpKSkKIAogOzs7IyMjYXV0b2xv YWQKIChkZWZ1biBzZXJ2ZXItc2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWwgKGFyZykKQEAg LTE3ODAsNyArMTc4OSw3IEBAIHNlcnZlci1zYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbAog CiBJZiBlbWFjc2NsaWVudCB3YXMgc3RhcnRlZCB3aXRoIGEgbGlzdCBvZiBmaWxlbmFtZXMg dG8gZWRpdCwgdGhlbgogb25seSB0aGVzZSBmaWxlcyB3aWxsIGJlIGFza2VkIHRvIGJlIHNh dmVkLiIKLSAgKGlmIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkKKyAgKGlmIChzZXJ2ZXIt c3RvcC1hdXRvbWF0aWNhbGx5LS13aGVuLWtpbGxpbmctdGVybWluYWwpCiAgICAgICAoc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZSAoc2VsZWN0ZWQt ZnJhbWUpKQogICAgIChsZXQgKChwcm9jIChmcmFtZS1wYXJhbWV0ZXIgbmlsICdjbGllbnQp KSkKICAgICAgIChjb25kICgoZXEgcHJvYyAnbm93YWl0KQpAQCAtMTgwNSw3ICsxODE0LDcg QEAgc2VydmVyLXNhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFsCiAJICAgICh0IChlcnJvciAi SW52YWxpZCBjbGllbnQgZnJhbWUiKSkpKSkpCiAKIChkZWZ1biBzZXJ2ZXItc3RvcC1hdXRv bWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lIChmcmFtZSkKLSAgIkhhbmRsZSBkZWxl dGlvbiBvZiBGUkFNRSB3aGVuIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpcyB1c2Vk LiIKKyAgIkhhbmRsZSBkZWxldGlvbiBvZiBGUkFNRSB3aGVuIGBzZXJ2ZXItc3RvcC1hdXRv bWF0aWNhbGx5JyBpcyBgZGVsZXRlLWZyYW1lJy4iCiAgICh3aGVuIHNlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHkKICAgICAoaWYgKGlmIChhbmQgKHByb2Nlc3NwIChmcmFtZS1wYXJhbWV0 ZXIgZnJhbWUgJ2NsaWVudCkpCiAJCSAoZXEgdGhpcy1jb21tYW5kICdzYXZlLWJ1ZmZlcnMt a2lsbC10ZXJtaW5hbCkpCkBAIC0xODI4LDcgKzE4MzcsNyBAQCBzZXJ2ZXItc3RvcC1hdXRv bWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lCiAJICAoZGVsZXRlLWZyYW1lIGZyYW1l KSkpKSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtpbGwt ZW1hY3MgKCkKLSAgIkhhbmRsZSBjbG9zaW5nIG9mIEVtYWNzIGRhZW1vbiB3aGVuIGBzZXJ2 ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpcyB1c2VkLiIKKyAgIkhhbmRsZSBjbG9zaW5nIG9m IEVtYWNzIGRhZW1vbiB3aGVuIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpcyBgZW1w dHknLiIKICAgKHVubGVzcyAoY2RyIChmcmFtZS1saXN0KSkKICAgICAod2hlbiAoYW5kCiAJ ICAgKG5vdCAobWVtcSB0IChtYXBjYXIgKGxhbWJkYSAoYikKQEAgLTE4NDIsNDEgKzE4NTEs NjYgQEAgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcwogCQkJ CShwcm9jZXNzLWxpc3QpKSkpKQogICAgICAgKGtpbGwtZW1hY3MpKSkpCiAKLTs7OyMjI2F1 dG9sb2FkCi0oZGVmdW4gc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSAoYXJnKQotICAiQXV0 b21hdGljYWxseSBzdG9wIHNlcnZlciBhcyBzcGVjaWZpZWQgYnkgQVJHLgotCi1JZiBBUkcg aXMgdGhlIHN5bWJvbCBgZW1wdHknLCBzdG9wIHRoZSBzZXJ2ZXIgd2hlbiBpdCBoYXMgbm8K KyhkZWZ1biBzZXJ2ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5ICgpCisgICJBcHBseSB0 aGUgY3VycmVudCB2YWx1ZSBvZiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScuCitUaGlz IGZ1bmN0aW9uIGFkZHMgb3IgcmVtb3ZlcyB0aGUgbmVjZXNzYXJ5IGhlbHBlcnMgdG8gbWFu YWdlCitzdG9wcGluZyB0aGUgRW1hY3Mgc2VydmVyIGF1dG9tYXRpY2FsbHksIGRlcGVuZGlu ZyBvbiB0aGUgd2hldGhlcgordGhlIHNlcnZlciBpcyBydW5uaW5nIG9yIG5vdC4gIFRoaXMg ZnVuY3Rpb24gb25seSBhcHBsaWVzIHdoZW4KK3J1bm5pbmcgRW1hY3MgYXMgYSBkYWVtb24u IgorICAod2hlbiAoZGFlbW9ucCkKKyAgICAobGV0IChlbXB0eS10aW1lci1wIGRlbGV0ZS1m cmFtZS1wKQorICAgICAgKHdoZW4gc2VydmVyLXByb2Nlc3MKKyAgICAgICAgKHBjYXNlIHNl cnZlci1zdG9wLWF1dG9tYXRpY2FsbHkKKyAgICAgICAgICAoJ2VtcHR5ICAgICAgICAoc2V0 cSBlbXB0eS10aW1lci1wIHQpKQorICAgICAgICAgICgnZGVsZXRlLWZyYW1lIChzZXRxIGRl bGV0ZS1mcmFtZS1wIHQpKSkpCisgICAgICA7OyBTdGFydCBvciBzdG9wIHRoZSB0aW1lci4K KyAgICAgIChpZiBlbXB0eS10aW1lci1wCisgICAgICAgICAgKHVubGVzcyBzZXJ2ZXItc3Rv cC1hdXRvbWF0aWNhbGx5LS10aW1lcgorICAgICAgICAgICAgKHNldHEgc2VydmVyLXN0b3At YXV0b21hdGljYWxseS0tdGltZXIKKyAgICAgICAgICAgICAgICAgIChydW4td2l0aC10aW1l cgorICAgICAgICAgICAgICAgICAgIDEwIDIKKwkJICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0 aWNhbGx5LS1tYXliZS1raWxsLWVtYWNzKSkpCisgICAgICAgICh3aGVuIHNlcnZlci1zdG9w LWF1dG9tYXRpY2FsbHktLXRpbWVyCisgICAgICAgICAgKGNhbmNlbC10aW1lciBzZXJ2ZXIt c3RvcC1hdXRvbWF0aWNhbGx5LS10aW1lcikKKyAgICAgICAgICAoc2V0cSBzZXJ2ZXItc3Rv cC1hdXRvbWF0aWNhbGx5LS10aW1lciBuaWwpKSkKKyAgICAgIDs7IEFkZCBvciByZW1vdmUg dGhlIGRlbGV0ZS1mcmFtZSBob29rLgorICAgICAgKGlmIGRlbGV0ZS1mcmFtZS1wCisgICAg ICAgICAgKGFkZC1ob29rICdkZWxldGUtZnJhbWUtZnVuY3Rpb25zCisJCSAgICAjJ3NlcnZl ci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJhbWUpCisgICAgICAgIChy ZW1vdmUtaG9vayAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucworICAgICAgICAgICAgICAgICAg ICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lKSkp KSkKKworKGRlZmN1c3RvbSBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbAorICAiSWYg bm9uLW5pbCwgc3RvcCB0aGUgc2VydmVyIHVuZGVyIHRoZSByZXF1ZXN0ZWQgY29uZGl0aW9u cy4KKworSWYgdGhpcyBpcyB0aGUgc3ltYm9sIGBlbXB0eScsIHN0b3AgdGhlIHNlcnZlciB3 aGVuIGl0IGhhcyBubwogcmVtYWluaW5nIGNsaWVudHMsIG5vIHJlbWFpbmluZyB1bnNhdmVk IGZpbGUtdmlzaXRpbmcgYnVmZmVycywKIGFuZCBubyBydW5uaW5nIHByb2Nlc3NlcyB3aXRo IGEgYHF1ZXJ5LW9uLWV4aXQnIGZsYWcuCiAKLUlmIEFSRyBpcyB0aGUgc3ltYm9sIGBkZWxl dGUtZnJhbWUnLCBhc2sgdGhlIHVzZXIgd2hlbiB0aGUgbGFzdAorSWYgdGhpcyBpcyB0aGUg c3ltYm9sIGBkZWxldGUtZnJhbWUnLCBhc2sgdGhlIHVzZXIgd2hlbiB0aGUgbGFzdAogZnJh bWUgaXMgZGVsZXRlZCB3aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZl ciBtdXN0CiBiZSBzYXZlZCBhbmQgZWFjaCBydW5uaW5nIHByb2Nlc3Mgd2l0aCBhIGBxdWVy eS1vbi1leGl0JyBmbGFnCiBjYW4gYmUgc3RvcHBlZCwgYW5kIGlmIHNvLCBzdG9wIHRoZSBz ZXJ2ZXIgaXRzZWxmLgogCi1JZiBBUkcgaXMgdGhlIHN5bWJvbCBga2lsbC10ZXJtaW5hbCcs IGFzayB0aGUgdXNlciB3aGVuIHRoZQorSWYgdGhpcyBpcyB0aGUgc3ltYm9sIGBraWxsLXRl cm1pbmFsJywgYXNrIHRoZSB1c2VyIHdoZW4gdGhlCiB0ZXJtaW5hbCBpcyBraWxsZWQgd2l0 aCBcXFtzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbF0gXAogd2hldGhlciBlYWNoIHVuc2F2 ZWQgZmlsZS12aXNpdGluZwogYnVmZmVyIG11c3QgYmUgc2F2ZWQgYW5kIGVhY2ggcnVubmlu ZyBwcm9jZXNzIHdpdGggYSBgcXVlcnktb24tZXhpdCcKLWZsYWcgY2FuIGJlIHN0b3BwZWQs IGFuZCBpZiBzbywgc3RvcCB0aGUgc2VydmVyIGl0c2VsZi4KLQotQW55IG90aGVyIHZhbHVl IG9mIEFSRyB3aWxsIGNhdXNlIHRoaXMgZnVuY3Rpb24gdG8gc2lnbmFsIGFuIGVycm9yLgot Ci1UaGlzIGZ1bmN0aW9uIGlzIG1lYW50IHRvIGJlIGNhbGxlZCBmcm9tIHRoZSB1c2VyIGlu aXQgZmlsZS4iCi0gICh3aGVuIChkYWVtb25wKQotICAgIChzZXRxIHNlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHkgYXJnKQotICAgIChjb25kCi0gICAgICgoZXEgYXJnICdlbXB0eSkKLSAg ICAgIChzZXRxIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkgbmlsKQotICAgICAgKHJ1bi13 aXRoLXRpbWVyIDEwIDIKLQkJICAgICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1t YXliZS1raWxsLWVtYWNzKSkKLSAgICAgKChlcSBhcmcgJ2RlbGV0ZS1mcmFtZSkKLSAgICAg IChhZGQtaG9vayAnZGVsZXRlLWZyYW1lLWZ1bmN0aW9ucwotCQkjJ3NlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHktLWhhbmRsZS1kZWxldGUtZnJhbWUpKQotICAgICAoKGVxIGFyZyAna2ls bC10ZXJtaW5hbCkpCi0gICAgICh0Ci0gICAgICAoZXJyb3IgIlVuZXhwZWN0ZWQgYXJndW1l bnQiKSkpKSkKK2ZsYWcgY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBzbywgc3RvcCB0aGUgc2Vy dmVyIGl0c2VsZi4iCisgIDp0eXBlICcoY2hvaWNlCisgICAgICAgICAgKGNvbnN0IDp0YWcg Ik5ldmVyIiBuaWwpCisgICAgICAgICAgKGNvbnN0IDp0YWcgIldoZW4gZW1wdHkiIGVtcHR5 KQorICAgICAgICAgIChjb25zdCA6dGFnICJXaGVuIGtpbGxpbmcgbGFzdCB0ZXJtaW5hbCIg a2lsbC10ZXJtaW5hbCkKKyAgICAgICAgICAoY29uc3QgOnRhZyAiV2hlbiBraWxsaW5nIGxh c3QgdGVybWluYWwgb3IgZnJhbWUiIGRlbGV0ZS1mcmFtZSkpCisgIDpzZXQgKGxhbWJkYSAo c3ltYm9sIHZhbHVlKQorICAgICAgICAgKHNldC1kZWZhdWx0IHN5bWJvbCB2YWx1ZSkKKyAg ICAgICAgIChzZXJ2ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5KSkKKyAgOnZlcnNpb24g IjI5LjEiKQorCisoZGVmdW4gc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSAodmFsdWUpCisg ICJBdXRvbWF0aWNhbGx5IHN0b3AgdGhlIEVtYWNzIHNlcnZlciBhcyBzcGVjaWZpZWQgYnkg VkFMVUUuCitUaGlzIHNldHMgdGhlIHZhcmlhYmxlIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNh bGx5JyAod2hpY2ggc2VlKS4iCisgIChzZXRvcHQgc2VydmVyLXN0b3AtYXV0b21hdGljYWxs eSB2YWx1ZSkpCiAKIChkZWZpbmUta2V5IGN0bC14LW1hcCAiIyIgJ3NlcnZlci1lZGl0KQog Ci0tIAoyLjI1LjEKCg== --------------3AhE3xjk2Qceq02C2pDPufCo-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 02 09:42:52 2022 Received: (at 59668) by debbugs.gnu.org; 2 Dec 2022 14:42:52 +0000 Received: from localhost ([127.0.0.1]:47115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17Fc-0006B6-Fu for submit@debbugs.gnu.org; Fri, 02 Dec 2022 09:42:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p17Fb-0006Az-C4 for 59668@debbugs.gnu.org; Fri, 02 Dec 2022 09:42:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17FW-0007yH-1p; Fri, 02 Dec 2022 09:42:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4s9p6hIR6y2n8883xiW1OGS+5Vr3cM03kSTqv4vOt/0=; b=nWb/BIKe7jf/ 0y5/apo3CqxTmKBCRWzdklJK54xF6ZvfdilhRGPr4v3kWXt0/cv4fnq/VWQRWOb25VPp2tp7BHx7w OyApzc85F7nyAEkIA4777iWnqlTcxzHG5YG70ReWg/DMDgpkEbD3QxVpIYsbMJq0/nKq2dRVEOLVv vHUZUg1Nl5kLOazfeCIhLrPgw1VYT329GPt1ebZfbEdrY0bDXifPxyhlPfFSpT8Wc1yzLix0Cf54T gYskjR41+IOlK30qCozR7Z6pjnbKHDGeJxehmYwCfNwKWRBF51apxD5YE2GVUsLUuvF6uXExmHm3k h31BwOqoaBw8a7NqZYVg9Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p17FV-0006B4-8s; Fri, 02 Dec 2022 09:42:45 -0500 Date: Fri, 02 Dec 2022 16:42:21 +0200 Message-Id: <83a645g94i.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> (message from Jim Porter on Thu, 1 Dec 2022 19:30:03 -0800) Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 1 Dec 2022 19:30:03 -0800 > Cc: 59668@debbugs.gnu.org > From: Jim Porter > > @@ -1805,7 +1814,7 @@ server-save-buffers-kill-terminal > (t (error "Invalid client frame")))))) > > (defun server-stop-automatically--handle-delete-frame (frame) > - "Handle deletion of FRAME when `server-stop-automatically' is used." > + "Handle deletion of FRAME when `server-stop-automatically' is `delete-frame'." > (when server-stop-automatically > (if (if (and (processp (frame-parameter frame 'client)) > (eq this-command 'save-buffers-kill-terminal)) > @@ -1828,7 +1837,7 @@ server-stop-automatically--handle-delete-frame > (delete-frame frame))))) AFAIU, this delete-frame is called after save-buffers-kill-emacs, which is strange: there will be no Emacs to perform this call after that. What am I missing? > + (const :tag "When empty" empty) "When empty" doesn't explain itself well enough. Can we come up with a better description? Otherwise LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 06 20:40:05 2022 Received: (at 59668) by debbugs.gnu.org; 7 Dec 2022 01:40:05 +0000 Received: from localhost ([127.0.0.1]:46405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2jPn-0000Va-Rk for submit@debbugs.gnu.org; Tue, 06 Dec 2022 20:40:05 -0500 Received: from mail-pf1-f173.google.com ([209.85.210.173]:33293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2jPk-0000V7-H9 for 59668@debbugs.gnu.org; Tue, 06 Dec 2022 20:40:02 -0500 Received: by mail-pf1-f173.google.com with SMTP id 124so16256215pfy.0 for <59668@debbugs.gnu.org>; Tue, 06 Dec 2022 17:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=egEfSd28lB9/yk3I5hMGVSzpBfO9yA5rF86gabf67ok=; b=iQHx8r5QThiGKtV9lv4EzV4jDX2prCfjab0+0He+FqmfQHwxVvly+TSjYXR9QjowlS 5uoULK+X4jCdlDyeqye1CHuFzXSDmqnDBAapdESDghHUuhaet0wd3rEGjbwXf5jUVUDz ymfMoWJibpKMBguV7x/LgBgcIMKgEPmqjoHoW9o5Omgn2b9YAs/FY+CYvSfiGiLv61ah pzaF/iC6IjFgZ6ykaa5bX05hF4G3oyHo4HyqDx1icGs3wTP3yAfEDvCh00bJOIfeaHPc sub8NYRUkclLaWAvLOIFt3tqh1+SvGRaDhIofSx/XQCOHXT07u8Q1rlLFWnm/8eoxEzg 4Jtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=egEfSd28lB9/yk3I5hMGVSzpBfO9yA5rF86gabf67ok=; b=GA7sxBtpBs1HPRlyarNYe8Ydk/fR/v25ZfVYgwzAt1befr39klijh4ur23bsvoByzQ zyLMAzy+tKjVz9ceRx/l4VlnIJ+5u5QpHjCQ7k30qYtgzh7CB14y9AGgNM5y3qAh6nTk 5NIsMs2ysvj59NLAPafYkwd5JhcYx6zeGlEDV6SD8st8sy8rJAOoUNKzoAgKjShICkQW ETF2Xz0TiHWrwsMNhLKXGq5lt4LTIh9rBT/56X1F0QHHKnGkY1b6Ik0pIWhcVS9Rzl12 pA938j3fdDJI6JJ9NM/iku8iwZPOgTioWMwmhaQ/xzB+Ta/9qzzwmypE+5rWtI7esH9A JEKA== X-Gm-Message-State: ANoB5plgxhiFmjqhCATjskKF4szWDaXCHGbIZLRj43a7qdpJOK0YzLy0 EKE5Fq9VHNqUhxPdplIDt1q9sSFQktI= X-Google-Smtp-Source: AA0mqf7EWX5EOLmYre13Jlk2HSHbC3iAJiEZu8uF9NJnZEDtudNwqCNtiq2dL9kf2ZvkkPQRBZ9u7g== X-Received: by 2002:a63:d602:0:b0:478:d2ac:ebda with SMTP id q2-20020a63d602000000b00478d2acebdamr7635987pgg.99.1670377194569; Tue, 06 Dec 2022 17:39:54 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id kb12-20020a17090ae7cc00b0020b21019086sm2891539pjb.3.2022.12.06.17.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 17:39:53 -0800 (PST) Content-Type: multipart/mixed; boundary="------------DndFmlWwS6CtGpHF5MKd0zyx" Message-ID: <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> Date: Tue, 6 Dec 2022 17:39:52 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> <83a645g94i.fsf@gnu.org> From: Jim Porter In-Reply-To: <83a645g94i.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------DndFmlWwS6CtGpHF5MKd0zyx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/2/2022 6:42 AM, Eli Zaretskii wrote: >> Date: Thu, 1 Dec 2022 19:30:03 -0800 >> Cc: 59668@debbugs.gnu.org >> From: Jim Porter >> >> @@ -1805,7 +1814,7 @@ server-save-buffers-kill-terminal >> (t (error "Invalid client frame")))))) >> >> (defun server-stop-automatically--handle-delete-frame (frame) >> - "Handle deletion of FRAME when `server-stop-automatically' is used." >> + "Handle deletion of FRAME when `server-stop-automatically' is `delete-frame'." >> (when server-stop-automatically >> (if (if (and (processp (frame-parameter frame 'client)) >> (eq this-command 'save-buffers-kill-terminal)) >> @@ -1828,7 +1837,7 @@ server-stop-automatically--handle-delete-frame >> (delete-frame frame))))) > > AFAIU, this delete-frame is called after save-buffers-kill-emacs, which is > strange: there will be no Emacs to perform this call after that. What am I > missing? Thanks. I think that's just an oversight. I removed it in my patch for bug#51993, since this seems more closely-related to that bug. >> + (const :tag "When empty" empty) > > "When empty" doesn't explain itself well enough. Can we come up with a > better description? How about "When empty (no clients, unsaved files, or processes)"? That seems a bit clumsy to me, but I wanted to keep the word "empty" in there somehow, since that's the name of the option value. Attached is an updated patch (rebased on top of my previous patches for bug#51993). --------------DndFmlWwS6CtGpHF5MKd0zyx Content-Type: text/plain; charset=UTF-8; name="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Disposition: attachment; filename*0="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Transfer-Encoding: base64 RnJvbSA3ZDljOWJiY2NmOGZkZjY4NTFhYzNjZjU0MjVjNTY0ZDkxOTE5NDM4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMjI6MjE6MTAgLTA4MDAKU3ViamVjdDogW1BB VENIXSBNYWtlICdzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpbnRvIGEgZGVmY3VzdG9t CgpUaGlzIGNoYW5nZXMgdGhlIG1lYW5pbmcgb2YgdGhlIChmb3JtZXJseSBpbnRlcm5hbCkg dmFyaWFibGUKJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknOiBpdCBub3cgYWx3YXlzIGhv bGRzIHRoZSByZXF1ZXN0ZWQKY29uZmlndXJhdGlvbiwgZXZlbiB3aGVuIEVtYWNzIHdhcyBu b3Qgc3RhcnRlZCBhcyBhIGRhZW1vbgooYnVnIzU5NjY4KS4KCiogbGlzcC9zZXJ2ZXIuZWwg KHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkpOiBDb252ZXJ0IHRoZSB2YXJpYWJsZSB0bwph IGRlZmN1c3RvbSwgYW5kIG1ha2UgdGhlIGZ1bmN0aW9uIHNpbXBseSBzZXQgdGhlIGRlZmN1 c3RvbS4KKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyKTogTmV3IHZhcmlhYmxl Lgooc2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSk6IE5ldyBmdW5jdGlvbi4uLgoo c2VydmVyLXN0b3AsIHNlcnZlci1zdGFydCk6IC4uLiBjYWxsIGl0Lgooc2VydmVyLXNhdmUt YnVmZmVycy1raWxsLXRlcm1pbmFsKTogQWRqdXN0IHRoZSBjb25kaXRpb25zIGZvcgpzdG9w cGluZyBhdXRvbWF0aWNhbGx5IHRvIGFjY291bnQgZm9yIHRoZSBjaGFuZ2Ugb2YgbWVhbmlu ZyBmb3IKJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknLgooc2VydmVyLXN0b3AtYXV0b21h dGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZSk6IFJlbW92ZSB1bm5lY2Vzc2FyeQp0ZXN0 IG9mIHRoZSAnc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScgb3B0aW9uOyB0aGlzIGhvb2sg aXMgb25seSBzZXQKd2hlbiBpdCBzaG91bGQgZG8gaXRzIGpvYi4KKHNlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHktLW1heWJlLWtpbGwtZW1hY3MpOiBVcGRhdGUgZG9jc3RyaW5nLgoKKiBk b2MvZW1hY3MvbWlzYy50ZXhpIChFbWFjcyBTZXJ2ZXIpOiBVcGRhdGUgZG9jdW1lbnRhdGlv bi4KLS0tCiBkb2MvZW1hY3MvbWlzYy50ZXhpIHwgIDQxICsrKysrKysrLS0tLS0tLS0KIGxp c3Avc2VydmVyLmVsICAgICAgfCAxMTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgOTMgaW5zZXJ0aW9ucygrKSwgNTkg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL21pc2MudGV4aSBiL2RvYy9l bWFjcy9taXNjLnRleGkKaW5kZXggMjljMGJlZDE5YzAuLjcwMmM3MmJhYzI1IDEwMDY0NAot LS0gYS9kb2MvZW1hY3MvbWlzYy50ZXhpCisrKyBiL2RvYy9lbWFjcy9taXNjLnRleGkKQEAg LTE4MDgsMzEgKzE4MDgsMjggQEAgRW1hY3MgU2VydmVyCiAgIGVtYWNzIC0tZGFlbW9uPWZv bwogQGVuZCBleGFtcGxlCiAKLUBmaW5kZXggc2VydmVyLXN0b3AtYXV0b21hdGljYWxseQor QHZpbmRleCBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CiAgIFRoZSBFbWFjcyBzZXJ2ZXIg Y2FuIG9wdGlvbmFsbHkgYmUgc3RvcHBlZCBhdXRvbWF0aWNhbGx5IHdoZW4KLWNlcnRhaW4g Y29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8gdGhpcywgY2FsbCB0aGUgZnVuY3Rpb24KLUBj b2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9IGluIHlvdXIgaW5pdCBmaWxlIChAcHhy ZWZ7SW5pdAotRmlsZX0pLCB3aXRoIG9uZSBvZiB0aGUgZm9sbG93aW5nIGFyZ3VtZW50czoK K2NlcnRhaW4gY29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8gdGhpcywgc2V0IHRoZSBvcHRp b24KK0Bjb2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9IHRvIG9uZSBvZiB0aGUgZm9s bG93aW5nIHZhbHVlczoKIAotQGl0ZW1pemUKLUBpdGVtCi1XaXRoIHRoZSBhcmd1bWVudCBA Y29kZXtlbXB0eX0sIHRoZSBzZXJ2ZXIgaXMgc3RvcHBlZCB3aGVuIGl0IGhhcyBubwotY2xp ZW50cywgbm8gdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYW5kIG5vIHJ1bm5pbmcg cHJvY2Vzc2VzCi1hbnltb3JlLgotCi1AaXRlbQotV2l0aCB0aGUgYXJndW1lbnQgQGNvZGV7 ZGVsZXRlLWZyYW1lfSwgd2hlbiB0aGUgbGFzdCBjbGllbnQgZnJhbWUgaXMKLWJlaW5nIGNs b3NlZCwgeW91IGFyZSBhc2tlZCB3aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5n IGJ1ZmZlcgotbXVzdCBiZSBzYXZlZCBhbmQgZWFjaCB1bmZpbmlzaGVkIHByb2Nlc3MgY2Fu IGJlIHN0b3BwZWQsIGFuZCBpZiBzbywKLXRoZSBzZXJ2ZXIgaXMgc3RvcHBlZC4KLQotQGl0 ZW0KLVdpdGggdGhlIGFyZ3VtZW50IEBjb2Rle2tpbGwtdGVybWluYWx9LCB3aGVuIHRoZSBs YXN0IGNsaWVudCBmcmFtZSBpcwotYmVpbmcgY2xvc2VkIHdpdGggQGtiZHtDLXggQy1jfSAo QGNvZGV7c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9KSwKLXlvdSBhcmUgYXNrZWQgd2hl dGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZmZXIgbXVzdCBiZSBzYXZlZAot YW5kIGVhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBiZSBzdG9wcGVkLCBhbmQgaWYgc28s IHRoZSBzZXJ2ZXIgaXMKK0B0YWJsZSBAY29kZQorQGl0ZW0gZW1wdHkKK1RoaXMgdmFsdWUg Y2F1c2VzIHRoZSBzZXJ2ZXIgdG8gYmUgc3RvcHBlZCB3aGVuIGl0IGhhcyBubyBjbGllbnRz LCBubwordW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYW5kIG5vIHJ1bm5pbmcgcHJv Y2Vzc2VzIGFueW1vcmUuCisKK0BpdGVtIGRlbGV0ZS1mcmFtZQorVGhpcyB2YWx1ZSBtZWFu cyB0aGF0IHdoZW4gdGhlIGxhc3QgY2xpZW50IGZyYW1lIGlzIGJlaW5nIGNsb3NlZCwgeW91 CithcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZmZXIg bXVzdCBiZSBzYXZlZCBhbmQKK2VhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBiZSBzdG9w cGVkLCBhbmQgaWYgc28sIHRoZSBzZXJ2ZXIgaXMKIHN0b3BwZWQuCi1AZW5kIGl0ZW1pemUK KworQGl0ZW0ga2lsbC10ZXJtaW5hbAorVGhpcyB2YWx1ZSBtZWFucyB0aGF0IHdoZW4gdGhl IGxhc3QgY2xpZW50IGZyYW1lIGlzIGJlaW5nIGNsb3NlZCB3aXRoCitAa2Jke0MteCBDLWN9 IChAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbH0pLCB5b3UgYXJlIGFza2VkCit3 aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlciBtdXN0IGJlIHNhdmVk IGFuZCBlYWNoCit1bmZpbmlzaGVkIHByb2Nlc3MgY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBz bywgdGhlIHNlcnZlciBpcyBzdG9wcGVkLgorQGVuZCB0YWJsZQogCiBAZmluZGV4IHNlcnZl ci1ldmFsLWF0CiAgIElmIHlvdSBoYXZlIGRlZmluZWQgYSBzZXJ2ZXIgYnkgYSB1bmlxdWUg c2VydmVyIG5hbWUsIGl0IGlzIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5l bCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IGFhNjJiMjVhODkxLi45NzI2NWMxYTY4YyAxMDA2 NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTI3Myw2 ICsyNzMsMTEgQEAgc2VydmVyLWNsaWVudC1pbnN0cnVjdGlvbnMKICAgOnZlcnNpb24gIjI4 LjEiCiAgIDp0eXBlICdib29sZWFuKQogCisoZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkpICAgICAgOyBEZWZpbmVkIGJlbG93IHRvIGF2b2lkIHJlY3Vyc2l2ZSBsb2FkLgor CisoZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyIG5pbAorICAiVGhl IHRpbWVyIG9iamVjdCBmb3IgYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtp bGwtZW1hY3MnLiIpCisKIDs7IFdlIGRvIG5vdCB1c2UgYHRlbXBvcmFyeS1maWxlLWRpcmVj dG9yeScgaGVyZSwgYmVjYXVzZSBlbWFjc2NsaWVudAogOzsgZG9lcyBub3QgcmVhZCB0aGUg aW5pdCBmaWxlLgogKGRlZnZhciBzZXJ2ZXItc29ja2V0LWRpcgpAQCAtNjM2LDcgKzY0MSw4 IEBAIHNlcnZlci1zdG9wCiAgICAgICAoc2V0cSBzdG9wcGVkLXAgdAogICAgICAgICAgICAg c2VydmVyLXByb2Nlc3MgbmlsCiAgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwKLSAgICAg ICAgICAgIGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xvYmFsLW1p bm9yLW1vZGVzKSkpCisgICAgICAgICAgICBnbG9iYWwtbWlub3ItbW9kZXMgKGRlbHEgJ3Nl cnZlci1tb2RlIGdsb2JhbC1taW5vci1tb2RlcykpCisgICAgICAoc2VydmVyLWFwcGx5LXN0 b3AtYXV0b21hdGljYWxseSkpCiAgICAgKHVud2luZC1wcm90ZWN0CiAgICAgICAgIDs7IERl bGV0ZSB0aGUgc29ja2V0IGZpbGVzIG1hZGUgYnkgcHJldmlvdXMgc2VydmVyCiAgICAgICAg IDs7IGludm9jYXRpb25zLgpAQCAtNzU3LDYgKzc2Myw3IEBAIHNlcnZlci1zdGFydAogCQkJ IChsaXN0IDpmYW1pbHkgJ2xvY2FsCiAJCQkgICAgICAgOnNlcnZpY2Ugc2VydmVyLWZpbGUK IAkJCSAgICAgICA6cGxpc3QgJyg6YXV0aGVudGljYXRlZCB0KSkpKSkKKyAgICAgICAgICAo c2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSkKIAkgICh1bmxlc3Mgc2VydmVyLXBy b2Nlc3MgKGVycm9yICJDb3VsZCBub3Qgc3RhcnQgc2VydmVyIHByb2Nlc3MiKSkKICAgICAg ICAgICAoc2VydmVyLWxvZyAiU3RhcnRlZCBzZXJ2ZXIiKQogCSAgKHByb2Nlc3MtcHV0IHNl cnZlci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKQEAgLTE3NjksOSArMTc3 Niw2IEBAIHNlcnZlci1zd2l0Y2gtYnVmZmVyCiAgICAgKHdoZW4gc2VydmVyLXJhaXNlLWZy YW1lCiAgICAgICAoc2VsZWN0LWZyYW1lLXNldC1pbnB1dC1mb2N1cyAod2luZG93LWZyYW1l KSkpKSkKIAotKGRlZnZhciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbAotICAiSW50 ZXJuYWwgc3RhdHVzIHZhcmlhYmxlIGZvciBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScu IikKLQogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItc2F2ZS1idWZmZXJzLWtpbGwt dGVybWluYWwgKGFyZykKICAgOzsgQ2FsbGVkIGZyb20gc2F2ZS1idWZmZXJzLWtpbGwtdGVy bWluYWwgaW4gZmlsZXMuZWwuCkBAIC0xNzc5LDExICsxNzgzLDE5IEBAIHNlcnZlci1zYXZl LWJ1ZmZlcnMta2lsbC10ZXJtaW5hbAogV2l0aCBBUkcgbm9uLW5pbCwgc2lsZW50bHkgc2F2 ZSBhbGwgZmlsZS12aXNpdGluZyBidWZmZXJzLCB0aGVuIGtpbGwuCiAKIElmIGVtYWNzY2xp ZW50IHdhcyBzdGFydGVkIHdpdGggYSBsaXN0IG9mIGZpbGVuYW1lcyB0byBlZGl0LCB0aGVu Ci1vbmx5IHRoZXNlIGZpbGVzIHdpbGwgYmUgYXNrZWQgdG8gYmUgc2F2ZWQuIgotICAobGV0 ICgocHJvYyAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50KSkpCitvbmx5IHRoZXNlIGZp bGVzIHdpbGwgYmUgYXNrZWQgdG8gYmUgc2F2ZWQuCisKK1doZW4gcnVubmluZyBFbWFjcyBh cyBhIGRhZW1vbiBhbmQgd2l0aAorYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknICh3aGlj aCBzZWUpIHNldCB0byBga2lsbC10ZXJtaW5hbCcgb3IKK2BkZWxldGUtZnJhbWUnLCB0aGlz IGZ1bmN0aW9uIG1heSBjYWxsIGBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycKK2lmIHRoZXJl IGFyZSBubyBvdGhlciBhY3RpdmUgY2xpZW50cy4iCisgIChsZXQgKChzdG9wLWF1dG9tYXRp Y2FsbHkKKyAgICAgICAgIChhbmQgKGRhZW1vbnApCisgICAgICAgICAgICAgIChtZW1xIHNl cnZlci1zdG9wLWF1dG9tYXRpY2FsbHkgJyhraWxsLXRlcm1pbmFsIGRlbGV0ZS1mcmFtZSkp KSkKKyAgICAgICAgKHByb2MgKGZyYW1lLXBhcmFtZXRlciBuaWwgJ2NsaWVudCkpKQogICAg IChjb25kICgoZXEgcHJvYyAnbm93YWl0KQogCSAgIDs7IE5vd2FpdCBmcmFtZXMgaGF2ZSBu byBjbGllbnQgYnVmZmVyIGxpc3QuCi0JICAgKGlmIChsZW5ndGg+IChmcmFtZS1saXN0KSAo aWYgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSAyIDEpKQorCSAgIChpZiAobGVuZ3RoPiAo ZnJhbWUtbGlzdCkgKGlmIHN0b3AtYXV0b21hdGljYWxseSAyIDEpKQogICAgICAgICAgICAg ICAgOzsgSWYgdGhlcmUgYXJlIGFueSBvdGhlciBmcmFtZXMsIG9ubHkgZGVsZXRlIHRoaXMg b25lLgogICAgICAgICAgICAgICAgOzsgV2hlbiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxs eScgaXMgc2V0LCBkb24ndCBjb3VudAogICAgICAgICAgICAgICAgOzsgdGhlIGRhZW1vbiBm cmFtZS4KQEAgLTE3OTIsNyArMTgwNCw3IEBAIHNlcnZlci1zYXZlLWJ1ZmZlcnMta2lsbC10 ZXJtaW5hbAogCSAgICAgOzsgSWYgd2UncmUgdGhlIGxhc3QgZnJhbWUgc3RhbmRpbmcsIGtp bGwgRW1hY3MuCiAJICAgICAoc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MgYXJnKSkpCiAJICAo KHByb2Nlc3NwIHByb2MpCi0gICAgICAgICAgIChpZiAob3IgKG5vdCBzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5KQorICAgICAgICAgICAoaWYgKG9yIChub3Qgc3RvcC1hdXRvbWF0aWNh bGx5KQogICAgICAgICAgICAgICAgICAgIChsZW5ndGg+IHNlcnZlci1jbGllbnRzIDEpCiAg ICAgICAgICAgICAgICAgICAgKHNlcS1zb21lCiAgICAgICAgICAgICAgICAgICAgIChsYW1i ZGEgKGZyYW1lKQpAQCAtMTgxOSwxNCArMTgzMSwxMyBAQCBzZXJ2ZXItc2F2ZS1idWZmZXJz LWtpbGwtdGVybWluYWwKIAkgICh0IChlcnJvciAiSW52YWxpZCBjbGllbnQgZnJhbWUiKSkp KSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRsZS1kZWxldGUt ZnJhbWUgKGZyYW1lKQotICAiSGFuZGxlIGRlbGV0aW9uIG9mIEZSQU1FIHdoZW4gYHNlcnZl ci1zdG9wLWF1dG9tYXRpY2FsbHknIGlzIHVzZWQuIgotICAod2hlbiAoYW5kIHNlcnZlci1z dG9wLWF1dG9tYXRpY2FsbHkKLSAgICAgICAgICAgICAobnVsbCAoY2RkciAoZnJhbWUtbGlz dCkpKSkKKyAgIkhhbmRsZSBkZWxldGlvbiBvZiBGUkFNRSB3aGVuIGBzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5JyBpcyBgZGVsZXRlLWZyYW1lJy4iCisgICh3aGVuIChudWxsIChjZGRy IChmcmFtZS1saXN0KSkpCiAgICAgKGxldCAoKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkg bmlsKSkKICAgICAgIChzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcykpKSkKIAogKGRlZnVuIHNl cnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtpbGwtZW1hY3MgKCkKLSAgIkhhbmRs ZSBjbG9zaW5nIG9mIEVtYWNzIGRhZW1vbiB3aGVuIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNh bGx5JyBpcyB1c2VkLiIKKyAgIkhhbmRsZSBjbG9zaW5nIG9mIEVtYWNzIGRhZW1vbiB3aGVu IGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpcyBgZW1wdHknLiIKICAgKHVubGVzcyAo Y2RyIChmcmFtZS1saXN0KSkKICAgICAod2hlbiAoYW5kCiAJICAgKG5vdCAobWVtcSB0ICht YXBjYXIgKGxhbWJkYSAoYikKQEAgLTE4NDAsNDEgKzE4NTEsNjcgQEAgc2VydmVyLXN0b3At YXV0b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcwogCQkJCShwcm9jZXNzLWxpc3QpKSkp KQogICAgICAgKGtpbGwtZW1hY3MpKSkpCiAKLTs7OyMjI2F1dG9sb2FkCi0oZGVmdW4gc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseSAoYXJnKQotICAiQXV0b21hdGljYWxseSBzdG9wIHNl cnZlciBhcyBzcGVjaWZpZWQgYnkgQVJHLgotCi1JZiBBUkcgaXMgdGhlIHN5bWJvbCBgZW1w dHknLCBzdG9wIHRoZSBzZXJ2ZXIgd2hlbiBpdCBoYXMgbm8KKyhkZWZ1biBzZXJ2ZXItYXBw bHktc3RvcC1hdXRvbWF0aWNhbGx5ICgpCisgICJBcHBseSB0aGUgY3VycmVudCB2YWx1ZSBv ZiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScuCitUaGlzIGZ1bmN0aW9uIGFkZHMgb3Ig cmVtb3ZlcyB0aGUgbmVjZXNzYXJ5IGhlbHBlcnMgdG8gbWFuYWdlCitzdG9wcGluZyB0aGUg RW1hY3Mgc2VydmVyIGF1dG9tYXRpY2FsbHksIGRlcGVuZGluZyBvbiB0aGUgd2hldGhlcgor dGhlIHNlcnZlciBpcyBydW5uaW5nIG9yIG5vdC4gIFRoaXMgZnVuY3Rpb24gb25seSBhcHBs aWVzIHdoZW4KK3J1bm5pbmcgRW1hY3MgYXMgYSBkYWVtb24uIgorICAod2hlbiAoZGFlbW9u cCkKKyAgICAobGV0IChlbXB0eS10aW1lci1wIGRlbGV0ZS1mcmFtZS1wKQorICAgICAgKHdo ZW4gc2VydmVyLXByb2Nlc3MKKyAgICAgICAgKHBjYXNlIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkKKyAgICAgICAgICAoJ2VtcHR5ICAgICAgICAoc2V0cSBlbXB0eS10aW1lci1wIHQp KQorICAgICAgICAgICgnZGVsZXRlLWZyYW1lIChzZXRxIGRlbGV0ZS1mcmFtZS1wIHQpKSkp CisgICAgICA7OyBTdGFydCBvciBzdG9wIHRoZSB0aW1lci4KKyAgICAgIChpZiBlbXB0eS10 aW1lci1wCisgICAgICAgICAgKHVubGVzcyBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lcgorICAgICAgICAgICAgKHNldHEgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGlt ZXIKKyAgICAgICAgICAgICAgICAgIChydW4td2l0aC10aW1lcgorICAgICAgICAgICAgICAg ICAgIDEwIDIKKwkJICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1tYXliZS1raWxs LWVtYWNzKSkpCisgICAgICAgICh3aGVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRp bWVyCisgICAgICAgICAgKGNhbmNlbC10aW1lciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5 LS10aW1lcikKKyAgICAgICAgICAoc2V0cSBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lciBuaWwpKSkKKyAgICAgIDs7IEFkZCBvciByZW1vdmUgdGhlIGRlbGV0ZS1mcmFtZSBo b29rLgorICAgICAgKGlmIGRlbGV0ZS1mcmFtZS1wCisgICAgICAgICAgKGFkZC1ob29rICdk ZWxldGUtZnJhbWUtZnVuY3Rpb25zCisJCSAgICAjJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2Fs bHktLWhhbmRsZS1kZWxldGUtZnJhbWUpCisgICAgICAgIChyZW1vdmUtaG9vayAnZGVsZXRl LWZyYW1lLWZ1bmN0aW9ucworICAgICAgICAgICAgICAgICAgICAgIydzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lKSkpKSkKKworKGRlZmN1c3RvbSBz ZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbAorICAiSWYgbm9uLW5pbCwgc3RvcCB0aGUg c2VydmVyIHVuZGVyIHRoZSByZXF1ZXN0ZWQgY29uZGl0aW9ucy4KKworSWYgdGhpcyBpcyB0 aGUgc3ltYm9sIGBlbXB0eScsIHN0b3AgdGhlIHNlcnZlciB3aGVuIGl0IGhhcyBubwogcmVt YWluaW5nIGNsaWVudHMsIG5vIHJlbWFpbmluZyB1bnNhdmVkIGZpbGUtdmlzaXRpbmcgYnVm ZmVycywKIGFuZCBubyBydW5uaW5nIHByb2Nlc3NlcyB3aXRoIGEgYHF1ZXJ5LW9uLWV4aXQn IGZsYWcuCiAKLUlmIEFSRyBpcyB0aGUgc3ltYm9sIGBkZWxldGUtZnJhbWUnLCBhc2sgdGhl IHVzZXIgd2hlbiB0aGUgbGFzdAorSWYgdGhpcyBpcyB0aGUgc3ltYm9sIGBkZWxldGUtZnJh bWUnLCBhc2sgdGhlIHVzZXIgd2hlbiB0aGUgbGFzdAogZnJhbWUgaXMgZGVsZXRlZCB3aGV0 aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlciBtdXN0CiBiZSBzYXZlZCBh bmQgZWFjaCBydW5uaW5nIHByb2Nlc3Mgd2l0aCBhIGBxdWVyeS1vbi1leGl0JyBmbGFnCiBj YW4gYmUgc3RvcHBlZCwgYW5kIGlmIHNvLCBzdG9wIHRoZSBzZXJ2ZXIgaXRzZWxmLgogCi1J ZiBBUkcgaXMgdGhlIHN5bWJvbCBga2lsbC10ZXJtaW5hbCcsIGFzayB0aGUgdXNlciB3aGVu IHRoZQorSWYgdGhpcyBpcyB0aGUgc3ltYm9sIGBraWxsLXRlcm1pbmFsJywgYXNrIHRoZSB1 c2VyIHdoZW4gdGhlCiB0ZXJtaW5hbCBpcyBraWxsZWQgd2l0aCBcXFtzYXZlLWJ1ZmZlcnMt a2lsbC10ZXJtaW5hbF0gXAogd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZwog YnVmZmVyIG11c3QgYmUgc2F2ZWQgYW5kIGVhY2ggcnVubmluZyBwcm9jZXNzIHdpdGggYSBg cXVlcnktb24tZXhpdCcKLWZsYWcgY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBzbywgc3RvcCB0 aGUgc2VydmVyIGl0c2VsZi4KLQotQW55IG90aGVyIHZhbHVlIG9mIEFSRyB3aWxsIGNhdXNl IHRoaXMgZnVuY3Rpb24gdG8gc2lnbmFsIGFuIGVycm9yLgotCi1UaGlzIGZ1bmN0aW9uIGlz IG1lYW50IHRvIGJlIGNhbGxlZCBmcm9tIHRoZSB1c2VyIGluaXQgZmlsZS4iCi0gICh3aGVu IChkYWVtb25wKQotICAgIChzZXRxIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkgYXJnKQot ICAgIChjb25kCi0gICAgICgoZXEgYXJnICdlbXB0eSkKLSAgICAgIChzZXRxIHNlcnZlci1z dG9wLWF1dG9tYXRpY2FsbHkgbmlsKQotICAgICAgKHJ1bi13aXRoLXRpbWVyIDEwIDIKLQkJ ICAgICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1tYXliZS1raWxsLWVtYWNzKSkK LSAgICAgKChlcSBhcmcgJ2RlbGV0ZS1mcmFtZSkKLSAgICAgIChhZGQtaG9vayAnZGVsZXRl LWZyYW1lLWZ1bmN0aW9ucwotCQkjJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRs ZS1kZWxldGUtZnJhbWUpKQotICAgICAoKGVxIGFyZyAna2lsbC10ZXJtaW5hbCkpCi0gICAg ICh0Ci0gICAgICAoZXJyb3IgIlVuZXhwZWN0ZWQgYXJndW1lbnQiKSkpKSkKK2ZsYWcgY2Fu IGJlIHN0b3BwZWQsIGFuZCBpZiBzbywgc3RvcCB0aGUgc2VydmVyIGl0c2VsZi4iCisgIDp0 eXBlICcoY2hvaWNlCisgICAgICAgICAgKGNvbnN0IDp0YWcgIk5ldmVyIiBuaWwpCisgICAg ICAgICAgKGNvbnN0IDp0YWcgIldoZW4gZW1wdHkgKG5vIGNsaWVudHMsIHVuc2F2ZWQgZmls ZXMsIG9yIHByb2Nlc3NlcykiCisgICAgICAgICAgICAgICAgIGVtcHR5KQorICAgICAgICAg IChjb25zdCA6dGFnICJXaGVuIGtpbGxpbmcgbGFzdCB0ZXJtaW5hbCIga2lsbC10ZXJtaW5h bCkKKyAgICAgICAgICAoY29uc3QgOnRhZyAiV2hlbiBraWxsaW5nIGxhc3QgdGVybWluYWwg b3IgZnJhbWUiIGRlbGV0ZS1mcmFtZSkpCisgIDpzZXQgKGxhbWJkYSAoc3ltYm9sIHZhbHVl KQorICAgICAgICAgKHNldC1kZWZhdWx0IHN5bWJvbCB2YWx1ZSkKKyAgICAgICAgIChzZXJ2 ZXItYXBwbHktc3RvcC1hdXRvbWF0aWNhbGx5KSkKKyAgOnZlcnNpb24gIjI5LjEiKQorCiso ZGVmdW4gc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSAodmFsdWUpCisgICJBdXRvbWF0aWNh bGx5IHN0b3AgdGhlIEVtYWNzIHNlcnZlciBhcyBzcGVjaWZpZWQgYnkgVkFMVUUuCitUaGlz IHNldHMgdGhlIHZhcmlhYmxlIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyAod2hpY2gg c2VlKS4iCisgIChzZXRvcHQgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSB2YWx1ZSkpCiAK IChkZWZpbmUta2V5IGN0bC14LW1hcCAiIyIgJ3NlcnZlci1lZGl0KQogCi0tIAoyLjI1LjEK Cg== --------------DndFmlWwS6CtGpHF5MKd0zyx-- From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 06 20:49:44 2022 Received: (at 59668) by debbugs.gnu.org; 7 Dec 2022 01:49:44 +0000 Received: from localhost ([127.0.0.1]:46456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2jZ9-0000dd-NR for submit@debbugs.gnu.org; Tue, 06 Dec 2022 20:49:44 -0500 Received: from mail-pj1-f44.google.com ([209.85.216.44]:43598) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2jZ7-0000cx-DU for 59668@debbugs.gnu.org; Tue, 06 Dec 2022 20:49:42 -0500 Received: by mail-pj1-f44.google.com with SMTP id u15-20020a17090a3fcf00b002191825cf02so103512pjm.2 for <59668@debbugs.gnu.org>; Tue, 06 Dec 2022 17:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=mVQcd8MDeVFnVqYbu6Tv+/aqFQKp5MI1Q6lpnNhCdbI=; b=ZXWmf2zj+qQSwvGvjDjw91UJIlR+C5SWaEVYWaZJ2y5VnoM8iLNmh1Hl7xRxTNYIfR s6eFLvmf5VUpeBowCqTyLSkCnJbG/rtonGupA/z1D+jwxpLNwURjd8MEfTRKoAPef8Fg wPKK8PgNrhY/nZVMgGfZ7U9MSpJl82aojST7IM8mHdKp3qDD5GQ66c3zpRm1+Off6eXB MpXhKTsT0+WHto3e7ArWEAFts4JQI46HKAuNunFbXvrsbX7yngdYKxfRTAPtsrXNvLZM +CsCrdK6hYAMF/tmPvjCVlLkZSuLlCx/gBN9Uzy/kl31zP7yjvD5A+yQf6p2Y2xy+6h0 qgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mVQcd8MDeVFnVqYbu6Tv+/aqFQKp5MI1Q6lpnNhCdbI=; b=jDN+KA+FUy9pfIZtfZeeqjJ7AVzKgkKHQe1RhOHilDxjgddtimHazH9psYmZrFK+4w zw9gWlge9Y9n8thqiIEtOFUFtk2DnO6q8WydQ0JWvoGrJ73xVeSeIJRPjIx6bi/XG86s jwmulmw9iHNCFwMrZxYUHlJ6xM1cv2RrH3n1m8FOPfeH3cWvZSQSEwiKf2GRgreh5yGa U1Rc3f8y/nzSWpKZ3aAcTlafvFM1FLTsu5nld/4tRQoqxOCVsbWB1WNLb7s9ch+vQTj+ xCDMTIMoHdkgLjMZTAkTPh+gGbWrCEpF2OcXlyBN9X5stlgcmPRtQNjw+5ikxsbDsWFj mGrA== X-Gm-Message-State: ANoB5pmyaldw3MUQCikJOtZGzzLNWO+wAHjSLnJzR/9iV1zMY7tO//8s hh/f2PtNDp1KnCbNDg17/38= X-Google-Smtp-Source: AA0mqf4Nmw7GG7rcHakhvihxOi/9Sf8v+oepCA3oE5jFDG7bXdQRQZNJFq+gGk06ZMz71USOZS443g== X-Received: by 2002:a17:90a:a607:b0:213:971d:902e with SMTP id c7-20020a17090aa60700b00213971d902emr97146025pjq.123.1670377775483; Tue, 06 Dec 2022 17:49:35 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q4-20020a170902eb8400b0018862bb3976sm4547460plg.308.2022.12.06.17.49.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Dec 2022 17:49:34 -0800 (PST) Content-Type: multipart/mixed; boundary="------------sXjGk2L7MXlUpQg7y0PAmbzc" Message-ID: <6e5102ab-76d8-88d4-b63f-69241fd41427@gmail.com> Date: Tue, 6 Dec 2022 17:49:34 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> <83a645g94i.fsf@gnu.org> <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> In-Reply-To: <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------sXjGk2L7MXlUpQg7y0PAmbzc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/6/2022 5:39 PM, Jim Porter wrote: > Attached is an updated patch (rebased on top of my previous patches for > bug#51993). Oops. Forgot to save the file after my last change. --------------sXjGk2L7MXlUpQg7y0PAmbzc Content-Type: text/plain; charset=UTF-8; name="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Disposition: attachment; filename*0="0001-Make-server-stop-automatically-into-a-defcustom.patch" Content-Transfer-Encoding: base64 RnJvbSA2ODk0NmFiYzljZDZiZWM0M2YwNGFlODUzNTdlNzAxODYxOTgzYjA3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFN1biwgMjcgTm92IDIwMjIgMjI6MjE6MTAgLTA4MDAKU3ViamVjdDogW1BB VENIXSBNYWtlICdzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpbnRvIGEgZGVmY3VzdG9t CgpUaGlzIGNoYW5nZXMgdGhlIG1lYW5pbmcgb2YgdGhlIChmb3JtZXJseSBpbnRlcm5hbCkg dmFyaWFibGUKJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknOiBpdCBub3cgYWx3YXlzIGhv bGRzIHRoZSByZXF1ZXN0ZWQKY29uZmlndXJhdGlvbiwgZXZlbiB3aGVuIEVtYWNzIHdhcyBu b3Qgc3RhcnRlZCBhcyBhIGRhZW1vbgooYnVnIzU5NjY4KS4KCiogbGlzcC9zZXJ2ZXIuZWwg KHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkpOiBDb252ZXJ0IHRoZSB2YXJpYWJsZSB0bwph IGRlZmN1c3RvbSwgYW5kIG1ha2UgdGhlIGZ1bmN0aW9uIHNpbXBseSBzZXQgdGhlIGRlZmN1 c3RvbS4KKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyKTogTmV3IHZhcmlhYmxl Lgooc2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSk6IE5ldyBmdW5jdGlvbi4uLgoo c2VydmVyLXN0b3AsIHNlcnZlci1zdGFydCk6IC4uLiBjYWxsIGl0Lgooc2VydmVyLXNhdmUt YnVmZmVycy1raWxsLXRlcm1pbmFsKTogQWRqdXN0IHRoZSBjb25kaXRpb25zIGZvcgpzdG9w cGluZyBhdXRvbWF0aWNhbGx5IHRvIGFjY291bnQgZm9yIHRoZSBjaGFuZ2Ugb2YgbWVhbmlu ZyBmb3IKJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknLgooc2VydmVyLXN0b3AtYXV0b21h dGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZSk6IFJlbW92ZSB1bm5lY2Vzc2FyeQp0ZXN0 IG9mIHRoZSAnc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScgb3B0aW9uOyB0aGlzIGhvb2sg aXMgb25seSBzZXQKd2hlbiBpdCBzaG91bGQgZG8gaXRzIGpvYi4KKHNlcnZlci1zdG9wLWF1 dG9tYXRpY2FsbHktLW1heWJlLWtpbGwtZW1hY3MpOiBVcGRhdGUgZG9jc3RyaW5nLgoKKiBk b2MvZW1hY3MvbWlzYy50ZXhpIChFbWFjcyBTZXJ2ZXIpOiBVcGRhdGUgZG9jdW1lbnRhdGlv bi4KLS0tCiBkb2MvZW1hY3MvbWlzYy50ZXhpIHwgIDQxICsrKysrKysrLS0tLS0tLS0KIGxp c3Avc2VydmVyLmVsICAgICAgfCAxMTMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgOTUgaW5zZXJ0aW9ucygrKSwgNTkg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2VtYWNzL21pc2MudGV4aSBiL2RvYy9l bWFjcy9taXNjLnRleGkKaW5kZXggMjljMGJlZDE5YzAuLjcwMmM3MmJhYzI1IDEwMDY0NAot LS0gYS9kb2MvZW1hY3MvbWlzYy50ZXhpCisrKyBiL2RvYy9lbWFjcy9taXNjLnRleGkKQEAg LTE4MDgsMzEgKzE4MDgsMjggQEAgRW1hY3MgU2VydmVyCiAgIGVtYWNzIC0tZGFlbW9uPWZv bwogQGVuZCBleGFtcGxlCiAKLUBmaW5kZXggc2VydmVyLXN0b3AtYXV0b21hdGljYWxseQor QHZpbmRleCBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5CiAgIFRoZSBFbWFjcyBzZXJ2ZXIg Y2FuIG9wdGlvbmFsbHkgYmUgc3RvcHBlZCBhdXRvbWF0aWNhbGx5IHdoZW4KLWNlcnRhaW4g Y29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8gdGhpcywgY2FsbCB0aGUgZnVuY3Rpb24KLUBj b2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9IGluIHlvdXIgaW5pdCBmaWxlIChAcHhy ZWZ7SW5pdAotRmlsZX0pLCB3aXRoIG9uZSBvZiB0aGUgZm9sbG93aW5nIGFyZ3VtZW50czoK K2NlcnRhaW4gY29uZGl0aW9ucyBhcmUgbWV0LiAgVG8gZG8gdGhpcywgc2V0IHRoZSBvcHRp b24KK0Bjb2Rle3NlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHl9IHRvIG9uZSBvZiB0aGUgZm9s bG93aW5nIHZhbHVlczoKIAotQGl0ZW1pemUKLUBpdGVtCi1XaXRoIHRoZSBhcmd1bWVudCBA Y29kZXtlbXB0eX0sIHRoZSBzZXJ2ZXIgaXMgc3RvcHBlZCB3aGVuIGl0IGhhcyBubwotY2xp ZW50cywgbm8gdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYW5kIG5vIHJ1bm5pbmcg cHJvY2Vzc2VzCi1hbnltb3JlLgotCi1AaXRlbQotV2l0aCB0aGUgYXJndW1lbnQgQGNvZGV7 ZGVsZXRlLWZyYW1lfSwgd2hlbiB0aGUgbGFzdCBjbGllbnQgZnJhbWUgaXMKLWJlaW5nIGNs b3NlZCwgeW91IGFyZSBhc2tlZCB3aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5n IGJ1ZmZlcgotbXVzdCBiZSBzYXZlZCBhbmQgZWFjaCB1bmZpbmlzaGVkIHByb2Nlc3MgY2Fu IGJlIHN0b3BwZWQsIGFuZCBpZiBzbywKLXRoZSBzZXJ2ZXIgaXMgc3RvcHBlZC4KLQotQGl0 ZW0KLVdpdGggdGhlIGFyZ3VtZW50IEBjb2Rle2tpbGwtdGVybWluYWx9LCB3aGVuIHRoZSBs YXN0IGNsaWVudCBmcmFtZSBpcwotYmVpbmcgY2xvc2VkIHdpdGggQGtiZHtDLXggQy1jfSAo QGNvZGV7c2F2ZS1idWZmZXJzLWtpbGwtdGVybWluYWx9KSwKLXlvdSBhcmUgYXNrZWQgd2hl dGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZmZXIgbXVzdCBiZSBzYXZlZAot YW5kIGVhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBiZSBzdG9wcGVkLCBhbmQgaWYgc28s IHRoZSBzZXJ2ZXIgaXMKK0B0YWJsZSBAY29kZQorQGl0ZW0gZW1wdHkKK1RoaXMgdmFsdWUg Y2F1c2VzIHRoZSBzZXJ2ZXIgdG8gYmUgc3RvcHBlZCB3aGVuIGl0IGhhcyBubyBjbGllbnRz LCBubwordW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlcnMgYW5kIG5vIHJ1bm5pbmcgcHJv Y2Vzc2VzIGFueW1vcmUuCisKK0BpdGVtIGRlbGV0ZS1mcmFtZQorVGhpcyB2YWx1ZSBtZWFu cyB0aGF0IHdoZW4gdGhlIGxhc3QgY2xpZW50IGZyYW1lIGlzIGJlaW5nIGNsb3NlZCwgeW91 CithcmUgYXNrZWQgd2hldGhlciBlYWNoIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZmZXIg bXVzdCBiZSBzYXZlZCBhbmQKK2VhY2ggdW5maW5pc2hlZCBwcm9jZXNzIGNhbiBiZSBzdG9w cGVkLCBhbmQgaWYgc28sIHRoZSBzZXJ2ZXIgaXMKIHN0b3BwZWQuCi1AZW5kIGl0ZW1pemUK KworQGl0ZW0ga2lsbC10ZXJtaW5hbAorVGhpcyB2YWx1ZSBtZWFucyB0aGF0IHdoZW4gdGhl IGxhc3QgY2xpZW50IGZyYW1lIGlzIGJlaW5nIGNsb3NlZCB3aXRoCitAa2Jke0MteCBDLWN9 IChAY29kZXtzYXZlLWJ1ZmZlcnMta2lsbC10ZXJtaW5hbH0pLCB5b3UgYXJlIGFza2VkCit3 aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nIGJ1ZmZlciBtdXN0IGJlIHNhdmVk IGFuZCBlYWNoCit1bmZpbmlzaGVkIHByb2Nlc3MgY2FuIGJlIHN0b3BwZWQsIGFuZCBpZiBz bywgdGhlIHNlcnZlciBpcyBzdG9wcGVkLgorQGVuZCB0YWJsZQogCiBAZmluZGV4IHNlcnZl ci1ldmFsLWF0CiAgIElmIHlvdSBoYXZlIGRlZmluZWQgYSBzZXJ2ZXIgYnkgYSB1bmlxdWUg c2VydmVyIG5hbWUsIGl0IGlzIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9saXNwL3NlcnZlci5l bCBiL2xpc3Avc2VydmVyLmVsCmluZGV4IGFhNjJiMjVhODkxLi5mNmQ5YTQzOWUzMiAxMDA2 NDQKLS0tIGEvbGlzcC9zZXJ2ZXIuZWwKKysrIGIvbGlzcC9zZXJ2ZXIuZWwKQEAgLTI3Myw2 ICsyNzMsMTEgQEAgc2VydmVyLWNsaWVudC1pbnN0cnVjdGlvbnMKICAgOnZlcnNpb24gIjI4 LjEiCiAgIDp0eXBlICdib29sZWFuKQogCisoZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkpICAgICAgOyBEZWZpbmVkIGJlbG93IHRvIGF2b2lkIHJlY3Vyc2l2ZSBsb2FkLgor CisoZGVmdmFyIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRpbWVyIG5pbAorICAiVGhl IHRpbWVyIG9iamVjdCBmb3IgYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtp bGwtZW1hY3MnLiIpCisKIDs7IFdlIGRvIG5vdCB1c2UgYHRlbXBvcmFyeS1maWxlLWRpcmVj dG9yeScgaGVyZSwgYmVjYXVzZSBlbWFjc2NsaWVudAogOzsgZG9lcyBub3QgcmVhZCB0aGUg aW5pdCBmaWxlLgogKGRlZnZhciBzZXJ2ZXItc29ja2V0LWRpcgpAQCAtNjM2LDcgKzY0MSw4 IEBAIHNlcnZlci1zdG9wCiAgICAgICAoc2V0cSBzdG9wcGVkLXAgdAogICAgICAgICAgICAg c2VydmVyLXByb2Nlc3MgbmlsCiAgICAgICAgICAgICBzZXJ2ZXItbW9kZSBuaWwKLSAgICAg ICAgICAgIGdsb2JhbC1taW5vci1tb2RlcyAoZGVscSAnc2VydmVyLW1vZGUgZ2xvYmFsLW1p bm9yLW1vZGVzKSkpCisgICAgICAgICAgICBnbG9iYWwtbWlub3ItbW9kZXMgKGRlbHEgJ3Nl cnZlci1tb2RlIGdsb2JhbC1taW5vci1tb2RlcykpCisgICAgICAoc2VydmVyLWFwcGx5LXN0 b3AtYXV0b21hdGljYWxseSkpCiAgICAgKHVud2luZC1wcm90ZWN0CiAgICAgICAgIDs7IERl bGV0ZSB0aGUgc29ja2V0IGZpbGVzIG1hZGUgYnkgcHJldmlvdXMgc2VydmVyCiAgICAgICAg IDs7IGludm9jYXRpb25zLgpAQCAtNzU3LDYgKzc2Myw3IEBAIHNlcnZlci1zdGFydAogCQkJ IChsaXN0IDpmYW1pbHkgJ2xvY2FsCiAJCQkgICAgICAgOnNlcnZpY2Ugc2VydmVyLWZpbGUK IAkJCSAgICAgICA6cGxpc3QgJyg6YXV0aGVudGljYXRlZCB0KSkpKSkKKyAgICAgICAgICAo c2VydmVyLWFwcGx5LXN0b3AtYXV0b21hdGljYWxseSkKIAkgICh1bmxlc3Mgc2VydmVyLXBy b2Nlc3MgKGVycm9yICJDb3VsZCBub3Qgc3RhcnQgc2VydmVyIHByb2Nlc3MiKSkKICAgICAg ICAgICAoc2VydmVyLWxvZyAiU3RhcnRlZCBzZXJ2ZXIiKQogCSAgKHByb2Nlc3MtcHV0IHNl cnZlci1wcm9jZXNzIDpzZXJ2ZXItZmlsZSBzZXJ2ZXItZmlsZSkKQEAgLTE3NjksOSArMTc3 Niw2IEBAIHNlcnZlci1zd2l0Y2gtYnVmZmVyCiAgICAgKHdoZW4gc2VydmVyLXJhaXNlLWZy YW1lCiAgICAgICAoc2VsZWN0LWZyYW1lLXNldC1pbnB1dC1mb2N1cyAod2luZG93LWZyYW1l KSkpKSkKIAotKGRlZnZhciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IG5pbAotICAiSW50 ZXJuYWwgc3RhdHVzIHZhcmlhYmxlIGZvciBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScu IikKLQogOzs7IyMjYXV0b2xvYWQKIChkZWZ1biBzZXJ2ZXItc2F2ZS1idWZmZXJzLWtpbGwt dGVybWluYWwgKGFyZykKICAgOzsgQ2FsbGVkIGZyb20gc2F2ZS1idWZmZXJzLWtpbGwtdGVy bWluYWwgaW4gZmlsZXMuZWwuCkBAIC0xNzc5LDExICsxNzgzLDE5IEBAIHNlcnZlci1zYXZl LWJ1ZmZlcnMta2lsbC10ZXJtaW5hbAogV2l0aCBBUkcgbm9uLW5pbCwgc2lsZW50bHkgc2F2 ZSBhbGwgZmlsZS12aXNpdGluZyBidWZmZXJzLCB0aGVuIGtpbGwuCiAKIElmIGVtYWNzY2xp ZW50IHdhcyBzdGFydGVkIHdpdGggYSBsaXN0IG9mIGZpbGVuYW1lcyB0byBlZGl0LCB0aGVu Ci1vbmx5IHRoZXNlIGZpbGVzIHdpbGwgYmUgYXNrZWQgdG8gYmUgc2F2ZWQuIgotICAobGV0 ICgocHJvYyAoZnJhbWUtcGFyYW1ldGVyIG5pbCAnY2xpZW50KSkpCitvbmx5IHRoZXNlIGZp bGVzIHdpbGwgYmUgYXNrZWQgdG8gYmUgc2F2ZWQuCisKK1doZW4gcnVubmluZyBFbWFjcyBh cyBhIGRhZW1vbiBhbmQgd2l0aAorYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknICh3aGlj aCBzZWUpIHNldCB0byBga2lsbC10ZXJtaW5hbCcgb3IKK2BkZWxldGUtZnJhbWUnLCB0aGlz IGZ1bmN0aW9uIG1heSBjYWxsIGBzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcycKK2lmIHRoZXJl IGFyZSBubyBvdGhlciBhY3RpdmUgY2xpZW50cy4iCisgIChsZXQgKChzdG9wLWF1dG9tYXRp Y2FsbHkKKyAgICAgICAgIChhbmQgKGRhZW1vbnApCisgICAgICAgICAgICAgIChtZW1xIHNl cnZlci1zdG9wLWF1dG9tYXRpY2FsbHkgJyhraWxsLXRlcm1pbmFsIGRlbGV0ZS1mcmFtZSkp KSkKKyAgICAgICAgKHByb2MgKGZyYW1lLXBhcmFtZXRlciBuaWwgJ2NsaWVudCkpKQogICAg IChjb25kICgoZXEgcHJvYyAnbm93YWl0KQogCSAgIDs7IE5vd2FpdCBmcmFtZXMgaGF2ZSBu byBjbGllbnQgYnVmZmVyIGxpc3QuCi0JICAgKGlmIChsZW5ndGg+IChmcmFtZS1saXN0KSAo aWYgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSAyIDEpKQorCSAgIChpZiAobGVuZ3RoPiAo ZnJhbWUtbGlzdCkgKGlmIHN0b3AtYXV0b21hdGljYWxseSAyIDEpKQogICAgICAgICAgICAg ICAgOzsgSWYgdGhlcmUgYXJlIGFueSBvdGhlciBmcmFtZXMsIG9ubHkgZGVsZXRlIHRoaXMg b25lLgogICAgICAgICAgICAgICAgOzsgV2hlbiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxs eScgaXMgc2V0LCBkb24ndCBjb3VudAogICAgICAgICAgICAgICAgOzsgdGhlIGRhZW1vbiBm cmFtZS4KQEAgLTE3OTIsNyArMTgwNCw3IEBAIHNlcnZlci1zYXZlLWJ1ZmZlcnMta2lsbC10 ZXJtaW5hbAogCSAgICAgOzsgSWYgd2UncmUgdGhlIGxhc3QgZnJhbWUgc3RhbmRpbmcsIGtp bGwgRW1hY3MuCiAJICAgICAoc2F2ZS1idWZmZXJzLWtpbGwtZW1hY3MgYXJnKSkpCiAJICAo KHByb2Nlc3NwIHByb2MpCi0gICAgICAgICAgIChpZiAob3IgKG5vdCBzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5KQorICAgICAgICAgICAoaWYgKG9yIChub3Qgc3RvcC1hdXRvbWF0aWNh bGx5KQogICAgICAgICAgICAgICAgICAgIChsZW5ndGg+IHNlcnZlci1jbGllbnRzIDEpCiAg ICAgICAgICAgICAgICAgICAgKHNlcS1zb21lCiAgICAgICAgICAgICAgICAgICAgIChsYW1i ZGEgKGZyYW1lKQpAQCAtMTgxOSwxNCArMTgzMSwxMyBAQCBzZXJ2ZXItc2F2ZS1idWZmZXJz LWtpbGwtdGVybWluYWwKIAkgICh0IChlcnJvciAiSW52YWxpZCBjbGllbnQgZnJhbWUiKSkp KSkKIAogKGRlZnVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLWhhbmRsZS1kZWxldGUt ZnJhbWUgKGZyYW1lKQotICAiSGFuZGxlIGRlbGV0aW9uIG9mIEZSQU1FIHdoZW4gYHNlcnZl ci1zdG9wLWF1dG9tYXRpY2FsbHknIGlzIHVzZWQuIgotICAod2hlbiAoYW5kIHNlcnZlci1z dG9wLWF1dG9tYXRpY2FsbHkKLSAgICAgICAgICAgICAobnVsbCAoY2RkciAoZnJhbWUtbGlz dCkpKSkKKyAgIkhhbmRsZSBkZWxldGlvbiBvZiBGUkFNRSB3aGVuIGBzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5JyBpcyBgZGVsZXRlLWZyYW1lJy4iCisgICh3aGVuIChudWxsIChjZGRy IChmcmFtZS1saXN0KSkpCiAgICAgKGxldCAoKHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHkg bmlsKSkKICAgICAgIChzYXZlLWJ1ZmZlcnMta2lsbC1lbWFjcykpKSkKIAogKGRlZnVuIHNl cnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtpbGwtZW1hY3MgKCkKLSAgIkhhbmRs ZSBjbG9zaW5nIG9mIEVtYWNzIGRhZW1vbiB3aGVuIGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNh bGx5JyBpcyB1c2VkLiIKKyAgIkhhbmRsZSBjbG9zaW5nIG9mIEVtYWNzIGRhZW1vbiB3aGVu IGBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5JyBpcyBgZW1wdHknLiIKICAgKHVubGVzcyAo Y2RyIChmcmFtZS1saXN0KSkKICAgICAod2hlbiAoYW5kCiAJICAgKG5vdCAobWVtcSB0ICht YXBjYXIgKGxhbWJkYSAoYikKQEAgLTE4NDAsNDEgKzE4NTEsNjkgQEAgc2VydmVyLXN0b3At YXV0b21hdGljYWxseS0tbWF5YmUta2lsbC1lbWFjcwogCQkJCShwcm9jZXNzLWxpc3QpKSkp KQogICAgICAgKGtpbGwtZW1hY3MpKSkpCiAKLTs7OyMjI2F1dG9sb2FkCi0oZGVmdW4gc2Vy dmVyLXN0b3AtYXV0b21hdGljYWxseSAoYXJnKQotICAiQXV0b21hdGljYWxseSBzdG9wIHNl cnZlciBhcyBzcGVjaWZpZWQgYnkgQVJHLgotCi1JZiBBUkcgaXMgdGhlIHN5bWJvbCBgZW1w dHknLCBzdG9wIHRoZSBzZXJ2ZXIgd2hlbiBpdCBoYXMgbm8KKyhkZWZ1biBzZXJ2ZXItYXBw bHktc3RvcC1hdXRvbWF0aWNhbGx5ICgpCisgICJBcHBseSB0aGUgY3VycmVudCB2YWx1ZSBv ZiBgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseScuCitUaGlzIGZ1bmN0aW9uIGFkZHMgb3Ig cmVtb3ZlcyB0aGUgbmVjZXNzYXJ5IGhlbHBlcnMgdG8gbWFuYWdlCitzdG9wcGluZyB0aGUg RW1hY3Mgc2VydmVyIGF1dG9tYXRpY2FsbHksIGRlcGVuZGluZyBvbiB0aGUgd2hldGhlcgor dGhlIHNlcnZlciBpcyBydW5uaW5nIG9yIG5vdC4gIFRoaXMgZnVuY3Rpb24gb25seSBhcHBs aWVzIHdoZW4KK3J1bm5pbmcgRW1hY3MgYXMgYSBkYWVtb24uIgorICAod2hlbiAoZGFlbW9u cCkKKyAgICAobGV0IChlbXB0eS10aW1lci1wIGRlbGV0ZS1mcmFtZS1wKQorICAgICAgKHdo ZW4gc2VydmVyLXByb2Nlc3MKKyAgICAgICAgKHBjYXNlIHNlcnZlci1zdG9wLWF1dG9tYXRp Y2FsbHkKKyAgICAgICAgICAoJ2VtcHR5ICAgICAgICAoc2V0cSBlbXB0eS10aW1lci1wIHQp KQorICAgICAgICAgICgnZGVsZXRlLWZyYW1lIChzZXRxIGRlbGV0ZS1mcmFtZS1wIHQpKSkp CisgICAgICA7OyBTdGFydCBvciBzdG9wIHRoZSB0aW1lci4KKyAgICAgIChpZiBlbXB0eS10 aW1lci1wCisgICAgICAgICAgKHVubGVzcyBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lcgorICAgICAgICAgICAgKHNldHEgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0tdGlt ZXIKKyAgICAgICAgICAgICAgICAgIChydW4td2l0aC10aW1lcgorICAgICAgICAgICAgICAg ICAgIDEwIDIKKwkJICAgIydzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS1tYXliZS1raWxs LWVtYWNzKSkpCisgICAgICAgICh3aGVuIHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHktLXRp bWVyCisgICAgICAgICAgKGNhbmNlbC10aW1lciBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5 LS10aW1lcikKKyAgICAgICAgICAoc2V0cSBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5LS10 aW1lciBuaWwpKSkKKyAgICAgIDs7IEFkZCBvciByZW1vdmUgdGhlIGRlbGV0ZS1mcmFtZSBo b29rLgorICAgICAgKGlmIGRlbGV0ZS1mcmFtZS1wCisgICAgICAgICAgKGFkZC1ob29rICdk ZWxldGUtZnJhbWUtZnVuY3Rpb25zCisJCSAgICAjJ3NlcnZlci1zdG9wLWF1dG9tYXRpY2Fs bHktLWhhbmRsZS1kZWxldGUtZnJhbWUpCisgICAgICAgIChyZW1vdmUtaG9vayAnZGVsZXRl LWZyYW1lLWZ1bmN0aW9ucworICAgICAgICAgICAgICAgICAgICAgIydzZXJ2ZXItc3RvcC1h dXRvbWF0aWNhbGx5LS1oYW5kbGUtZGVsZXRlLWZyYW1lKSkpKQorICA7OyBSZXR1cm4gdGhl IGN1cnJlbnQgdmFsdWUgb2YgYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknLgorICBzZXJ2 ZXItc3RvcC1hdXRvbWF0aWNhbGx5KQorCisoZGVmY3VzdG9tIHNlcnZlci1zdG9wLWF1dG9t YXRpY2FsbHkgbmlsCisgICJJZiBub24tbmlsLCBzdG9wIHRoZSBzZXJ2ZXIgdW5kZXIgdGhl IHJlcXVlc3RlZCBjb25kaXRpb25zLgorCitJZiB0aGlzIGlzIHRoZSBzeW1ib2wgYGVtcHR5 Jywgc3RvcCB0aGUgc2VydmVyIHdoZW4gaXQgaGFzIG5vCiByZW1haW5pbmcgY2xpZW50cywg bm8gcmVtYWluaW5nIHVuc2F2ZWQgZmlsZS12aXNpdGluZyBidWZmZXJzLAogYW5kIG5vIHJ1 bm5pbmcgcHJvY2Vzc2VzIHdpdGggYSBgcXVlcnktb24tZXhpdCcgZmxhZy4KIAotSWYgQVJH IGlzIHRoZSBzeW1ib2wgYGRlbGV0ZS1mcmFtZScsIGFzayB0aGUgdXNlciB3aGVuIHRoZSBs YXN0CitJZiB0aGlzIGlzIHRoZSBzeW1ib2wgYGRlbGV0ZS1mcmFtZScsIGFzayB0aGUgdXNl ciB3aGVuIHRoZSBsYXN0CiBmcmFtZSBpcyBkZWxldGVkIHdoZXRoZXIgZWFjaCB1bnNhdmVk IGZpbGUtdmlzaXRpbmcgYnVmZmVyIG11c3QKIGJlIHNhdmVkIGFuZCBlYWNoIHJ1bm5pbmcg cHJvY2VzcyB3aXRoIGEgYHF1ZXJ5LW9uLWV4aXQnIGZsYWcKIGNhbiBiZSBzdG9wcGVkLCBh bmQgaWYgc28sIHN0b3AgdGhlIHNlcnZlciBpdHNlbGYuCiAKLUlmIEFSRyBpcyB0aGUgc3lt Ym9sIGBraWxsLXRlcm1pbmFsJywgYXNrIHRoZSB1c2VyIHdoZW4gdGhlCitJZiB0aGlzIGlz IHRoZSBzeW1ib2wgYGtpbGwtdGVybWluYWwnLCBhc2sgdGhlIHVzZXIgd2hlbiB0aGUKIHRl cm1pbmFsIGlzIGtpbGxlZCB3aXRoIFxcW3NhdmUtYnVmZmVycy1raWxsLXRlcm1pbmFsXSBc CiB3aGV0aGVyIGVhY2ggdW5zYXZlZCBmaWxlLXZpc2l0aW5nCiBidWZmZXIgbXVzdCBiZSBz YXZlZCBhbmQgZWFjaCBydW5uaW5nIHByb2Nlc3Mgd2l0aCBhIGBxdWVyeS1vbi1leGl0Jwot ZmxhZyBjYW4gYmUgc3RvcHBlZCwgYW5kIGlmIHNvLCBzdG9wIHRoZSBzZXJ2ZXIgaXRzZWxm LgotCi1Bbnkgb3RoZXIgdmFsdWUgb2YgQVJHIHdpbGwgY2F1c2UgdGhpcyBmdW5jdGlvbiB0 byBzaWduYWwgYW4gZXJyb3IuCi0KLVRoaXMgZnVuY3Rpb24gaXMgbWVhbnQgdG8gYmUgY2Fs bGVkIGZyb20gdGhlIHVzZXIgaW5pdCBmaWxlLiIKLSAgKHdoZW4gKGRhZW1vbnApCi0gICAg KHNldHEgc2VydmVyLXN0b3AtYXV0b21hdGljYWxseSBhcmcpCi0gICAgKGNvbmQKLSAgICAg KChlcSBhcmcgJ2VtcHR5KQotICAgICAgKHNldHEgc2VydmVyLXN0b3AtYXV0b21hdGljYWxs eSBuaWwpCi0gICAgICAocnVuLXdpdGgtdGltZXIgMTAgMgotCQkgICAgICAjJ3NlcnZlci1z dG9wLWF1dG9tYXRpY2FsbHktLW1heWJlLWtpbGwtZW1hY3MpKQotICAgICAoKGVxIGFyZyAn ZGVsZXRlLWZyYW1lKQotICAgICAgKGFkZC1ob29rICdkZWxldGUtZnJhbWUtZnVuY3Rpb25z Ci0JCSMnc2VydmVyLXN0b3AtYXV0b21hdGljYWxseS0taGFuZGxlLWRlbGV0ZS1mcmFtZSkp Ci0gICAgICgoZXEgYXJnICdraWxsLXRlcm1pbmFsKSkKLSAgICAgKHQKLSAgICAgIChlcnJv ciAiVW5leHBlY3RlZCBhcmd1bWVudCIpKSkpKQorZmxhZyBjYW4gYmUgc3RvcHBlZCwgYW5k IGlmIHNvLCBzdG9wIHRoZSBzZXJ2ZXIgaXRzZWxmLiIKKyAgOnR5cGUgJyhjaG9pY2UKKyAg ICAgICAgICAoY29uc3QgOnRhZyAiTmV2ZXIiIG5pbCkKKyAgICAgICAgICAoY29uc3QgOnRh ZyAiV2hlbiBlbXB0eSAobm8gY2xpZW50cywgdW5zYXZlZCBmaWxlcywgb3IgcHJvY2Vzc2Vz KSIKKyAgICAgICAgICAgICAgICAgZW1wdHkpCisgICAgICAgICAgKGNvbnN0IDp0YWcgIldo ZW4ga2lsbGluZyBsYXN0IHRlcm1pbmFsIiBraWxsLXRlcm1pbmFsKQorICAgICAgICAgIChj b25zdCA6dGFnICJXaGVuIGtpbGxpbmcgbGFzdCB0ZXJtaW5hbCBvciBmcmFtZSIgZGVsZXRl LWZyYW1lKSkKKyAgOnNldCAobGFtYmRhIChzeW1ib2wgdmFsdWUpCisgICAgICAgICAoc2V0 LWRlZmF1bHQgc3ltYm9sIHZhbHVlKQorICAgICAgICAgKHNlcnZlci1hcHBseS1zdG9wLWF1 dG9tYXRpY2FsbHkpKQorICA6dmVyc2lvbiAiMjkuMSIpCisKKyhkZWZ1biBzZXJ2ZXItc3Rv cC1hdXRvbWF0aWNhbGx5ICh2YWx1ZSkKKyAgIkF1dG9tYXRpY2FsbHkgc3RvcCB0aGUgRW1h Y3Mgc2VydmVyIGFzIHNwZWNpZmllZCBieSBWQUxVRS4KK1RoaXMgc2V0cyB0aGUgdmFyaWFi bGUgYHNlcnZlci1zdG9wLWF1dG9tYXRpY2FsbHknICh3aGljaCBzZWUpLiIKKyAgKHNldG9w dCBzZXJ2ZXItc3RvcC1hdXRvbWF0aWNhbGx5IHZhbHVlKSkKIAogKGRlZmluZS1rZXkgY3Rs LXgtbWFwICIjIiAnc2VydmVyLWVkaXQpCiAKLS0gCjIuMjUuMQoK --------------sXjGk2L7MXlUpQg7y0PAmbzc-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 07 07:48:26 2022 Received: (at 59668) by debbugs.gnu.org; 7 Dec 2022 12:48:26 +0000 Received: from localhost ([127.0.0.1]:50169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2tqc-0006d5-08 for submit@debbugs.gnu.org; Wed, 07 Dec 2022 07:48:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2tqY-0006cY-8g for 59668@debbugs.gnu.org; Wed, 07 Dec 2022 07:48:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2tqS-0001nG-Td; Wed, 07 Dec 2022 07:48:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tsMoTifLGnA+cJmr7n74Zlzptf7+BbsglTsJE7ogCuI=; b=L35JqfCoGNrD PccpuVH13j/zYvCwCL60k3Ymcky34mBsIYiieaZNkcxhvYgFVBkghK0HCicnrZEkAB8UHoZp0wuiZ LrjsvV7AET1xldo1mOgH0cF68SjAeB4XwX+0tLoqJS5Mi20qiGvEQAzDWmgSnYg+S0VCAfALl77Mi 2up1CPBslsmENNDNp9ruATASHnvMbIfs1E71Ud0goGHy1VSL9l7m/IRnDlAY0tEm+d1ZDvwx2/tIY l1ezBVg7Qu71uJyU4qUif6hrXfMstlCo+HRRslg7U9tE7+3c20c23F91M6H6C+OLZC3yWqjZIhqTe UgbA5sF0qtyoAlLMM9Vz8g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2tqS-0003i9-DY; Wed, 07 Dec 2022 07:48:16 -0500 Date: Wed, 07 Dec 2022 14:48:04 +0200 Message-Id: <831qpb5qij.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> (message from Jim Porter on Tue, 6 Dec 2022 17:39:52 -0800) Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> <83a645g94i.fsf@gnu.org> <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59668 Cc: 59668@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 6 Dec 2022 17:39:52 -0800 > Cc: 59668@debbugs.gnu.org > From: Jim Porter > > >> + (const :tag "When empty" empty) > > > > "When empty" doesn't explain itself well enough. Can we come up with a > > better description? > > How about "When empty (no clients, unsaved files, or processes)"? Just leave the text inside the parentheses (but without the parentheses themselves), there's no need to have the "empty part there. > Attached is an updated patch (rebased on top of my previous patches for > bug#51993). OK with the above change. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 08 01:02:49 2022 Received: (at 59668-done) by debbugs.gnu.org; 8 Dec 2022 06:02:49 +0000 Received: from localhost ([127.0.0.1]:54567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p39zd-000479-05 for submit@debbugs.gnu.org; Thu, 08 Dec 2022 01:02:49 -0500 Received: from mail-pj1-f50.google.com ([209.85.216.50]:44719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p39zZ-000473-RG for 59668-done@debbugs.gnu.org; Thu, 08 Dec 2022 01:02:47 -0500 Received: by mail-pj1-f50.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so525637pjo.3 for <59668-done@debbugs.gnu.org>; Wed, 07 Dec 2022 22:02:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=be7OgJabgdDIxCJAE8+a6+e1wcXEoVYP2dGigJyxwkQ=; b=CYhj+0KQMVGcupewGCaBT4JlL8X59lt35KkUrDgPB6v16bev42pNketPBkkFPse2ql fZKIj2G7TKNZ2UG0UMn0Ka1/gWUnsu0/7PAfLW5O5GSbEI+8s3DUSQ4TIM/PUMAYW5Iu 98OGCf5zgjVzy3l13NV5MH3IqiaDF9qjlT9Elk/kb98IRA2yRpAzLXd6MHwWSB/77TLM 9/IfhduX4KH7x3tWHka+Q9VKShnP7+17qGp5nkC5Zpf7efYI4FBlGcAG/IyhfLBhwml4 viel4McOrM+ecNeqRV/kqfeNHhD0/ZoGtKSmyL7HHQ11cb9qgvERvKhBGOoBFiN60O5n 5X9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=be7OgJabgdDIxCJAE8+a6+e1wcXEoVYP2dGigJyxwkQ=; b=03y3JVWEBgzvUDPf1aC0FkhFK6dabq46T7cQD2VeP3Cwe9JE58c5CnBZY3Iw7+LnKp Ek05hqknv/3TlrQ9njlpnVWF2esTD0xM2lNtUlq6ZE6YInETy43VXcRezAu3lvO3KYpn +AoHXfMM6j9prdWaODIFAfNsnuZMhze8FIcVRKk2LH66W0Mhhx6vVrPIqBTCb+zVUmZh /y17VXDNBTnaSuOM7kQhU3RWasKvvWEICoZDQTGSuBVf66HyxeSf8gAr8wCxwzPzJX91 jYXZ1ityNznRXW8c8zfioZufnAYXWMERY6zHjA9S9lwL1KKc1VVl7DRoy+EdJLvR0Il2 ZHpw== X-Gm-Message-State: ANoB5pmGPv+aQtbkBuF4tF8bMB5/HO6c9z/ttPl2UsI2IsO/xCq/pa6m kTjjHfc25+qIb9yxDDfi5gs= X-Google-Smtp-Source: AA0mqf5cFrrZUAlb7heL7EjsfZMwtfPIiHKDQmPnMFBHJhqf65AZWZltJn+mg+ZtvxuZ+BGtVVFh/Q== X-Received: by 2002:a17:90a:a383:b0:219:9410:c59e with SMTP id x3-20020a17090aa38300b002199410c59emr27819003pjp.129.1670479359983; Wed, 07 Dec 2022 22:02:39 -0800 (PST) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id r6-20020a632046000000b0046ec0ef4a7esm12382027pgm.78.2022.12.07.22.02.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Dec 2022 22:02:39 -0800 (PST) Message-ID: Date: Wed, 7 Dec 2022 22:02:39 -0800 MIME-Version: 1.0 Subject: Re: bug#59668: 29.0.50; [PATCH] Make 'server-stop-automatically' into a defcustom Content-Language: en-US To: Eli Zaretskii References: <155f479d-3bae-c327-47a3-7b58daf912c0@gmail.com> <83mt87gih4.fsf@gnu.org> <072e4903-4166-ce53-236b-86a8f7e05b9f@gmail.com> <83a645g94i.fsf@gnu.org> <6bcebd26-2128-d29c-31e6-e0ee096d9b35@gmail.com> <831qpb5qij.fsf@gnu.org> From: Jim Porter In-Reply-To: <831qpb5qij.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 59668-done Cc: 59668-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 12/7/2022 4:48 AM, Eli Zaretskii wrote: >> Date: Tue, 6 Dec 2022 17:39:52 -0800 >> Cc: 59668@debbugs.gnu.org >> From: Jim Porter >> >> How about "When empty (no clients, unsaved files, or processes)"? > > Just leave the text inside the parentheses (but without the > parentheses themselves), there's no need to have the "empty part there. Ok by me. >> Attached is an updated patch (rebased on top of my previous patches for >> bug#51993). > > OK with the above change. Thanks. Thanks, merged to master as 153c67fa92eaad39410b1809ab9b125616bdc5c1. Closing this bug now. From unknown Mon Jul 14 20:52:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Jan 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator